| hg-reviewers |
The metadata in properties can be incomplete or missing entirely, in which case
we can fallback to retrieving some from the diff itself.
| No Linters Available |
| No Unit Test Coverage |
| Path | Packages | |||
|---|---|---|---|---|
| M | hgext/phabricator.py (41 lines) | |||
| M | tests/test-phabricator.t (4 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| 1a17aba4b5f7 | 69efa9fea863 | Ian Moody | phabricator: fallback to reading metadata from diff for phabread (Show More…) | Apr 20 2019, 1:55 PM |
| } | } | ||||
| } | } | ||||
| Note: metadata extracted from "local:commits" will lose time zone | Note: metadata extracted from "local:commits" will lose time zone | ||||
| information. | information. | ||||
| """ | """ | ||||
| props = diff.get(b'properties') or {} | props = diff.get(b'properties') or {} | ||||
| meta = props.get(b'hg:meta') | meta = props.get(b'hg:meta') | ||||
| if not meta and props.get(b'local:commits'): | if not meta: | ||||
| if props.get(b'local:commits'): | |||||
| commit = sorted(props[b'local:commits'].values())[0] | commit = sorted(props[b'local:commits'].values())[0] | ||||
| meta = {} | meta = {} | ||||
| if b'author' in commit and b'authorEmail' in commit: | if b'author' in commit and b'authorEmail' in commit: | ||||
| meta[b'user'] = b'%s <%s>' % (commit[b'author'], | meta[b'user'] = b'%s <%s>' % (commit[b'author'], | ||||
| commit[b'authorEmail']) | commit[b'authorEmail']) | ||||
| if b'time' in commit: | if b'time' in commit: | ||||
| meta[b'date'] = b'%d 0' % commit[b'time'] | meta[b'date'] = b'%d 0' % commit[b'time'] | ||||
| if b'branch' in commit: | if b'branch' in commit: | ||||
| meta[b'branch'] = commit[b'branch'] | meta[b'branch'] = commit[b'branch'] | ||||
| node = commit.get(b'commit', commit.get(b'rev')) | node = commit.get(b'commit', commit.get(b'rev')) | ||||
| if node: | if node: | ||||
| meta[b'node'] = node | meta[b'node'] = node | ||||
| if len(commit.get(b'parents', ())) >= 1: | if len(commit.get(b'parents', ())) >= 1: | ||||
| meta[b'parent'] = commit[b'parents'][0] | meta[b'parent'] = commit[b'parents'][0] | ||||
| return meta or {} | else: | ||||
| meta = {} | |||||
| if b'date' not in meta and b'dateCreated' in diff: | |||||
| meta[b'date'] = b'%s 0' % diff[b'dateCreated'] | |||||
| if b'branch' not in meta and diff.get(b'branch'): | |||||
| meta[b'branch'] = diff[b'branch'] | |||||
| if b'parent' not in meta and diff.get(b'sourceControlBaseRevision'): | |||||
| meta[b'parent'] = diff[b'sourceControlBaseRevision'] | |||||
| return meta | |||||
| def readpatch(repo, drevs, write): | def readpatch(repo, drevs, write): | ||||
| """generate plain-text patch readable by 'hg import' | """generate plain-text patch readable by 'hg import' | ||||
| write is usually ui.write. drevs is what "querydrev" returns, results of | write is usually ui.write. drevs is what "querydrev" returns, results of | ||||
| "differential.query". | "differential.query". | ||||
| """ | """ | ||||
| # Prefetch hg:meta property for all diffs | # Prefetch hg:meta property for all diffs | ||||
| this test. | this test. | ||||
| $ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \ | $ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \ | ||||
| > --test-vcr "$VCR/phabread-conduit-error.json" D4480 | head | > --test-vcr "$VCR/phabread-conduit-error.json" D4480 | head | ||||
| abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long. | abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long. | ||||
| Basic phabread: | Basic phabread: | ||||
| $ hg phabread --test-vcr "$VCR/phabread-4480.json" D4480 | head | $ hg phabread --test-vcr "$VCR/phabread-4480.json" D4480 | head | ||||
| # HG changeset patch | # HG changeset patch | ||||
| # Date 1536771503 0 | |||||
| # Parent a5de21c9e3703f8e8eb064bd7d893ff2f703c66a | |||||
| exchangev2: start to implement pull with wire protocol v2 | exchangev2: start to implement pull with wire protocol v2 | ||||
| Wire protocol version 2 will take a substantially different | Wire protocol version 2 will take a substantially different | ||||
| approach to exchange than version 1 (at least as far as pulling | approach to exchange than version 1 (at least as far as pulling | ||||
| is concerned). | is concerned). | ||||
| This commit establishes a new exchangev2 module for holding | This commit establishes a new exchangev2 module for holding | ||||
| code related to exchange using wire protocol v2. I could have | |||||
| added things to the existing exchange module. But it is already | |||||
| phabupdate with an accept: | phabupdate with an accept: | ||||
| $ hg phabupdate --accept D4564 \ | $ hg phabupdate --accept D4564 \ | ||||
| > -m 'I think I like where this is headed. Will read rest of series later.'\ | > -m 'I think I like where this is headed. Will read rest of series later.'\ | ||||
| > --test-vcr "$VCR/accept-4564.json" | > --test-vcr "$VCR/accept-4564.json" | ||||
| Create a differential diff: | Create a differential diff: | ||||
| $ HGENCODING=utf-8; export HGENCODING | $ HGENCODING=utf-8; export HGENCODING | ||||