This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6725

tests: split joint repo/changelog fake into one for each type
ClosedPublic

Authored by durin42 on Aug 14 2019, 4:14 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG791791a1fd4e: tests: split joint repo/changelog fake into one for each type
rHG034b2bf377f0: tests: split joint repo/changelog fake into one for each type
Summary

I'm just not comfortable with fakes that get overloaded for multiple
types: too often it gets out of hand and becomes difficult to trace.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mtests/test-rust-discovery.py (7 lines)

Diff 16210

tests/test-rust-discovery.py

b'\x0e\xc6&\xa1\x92\xae6\x0b\x02i\xfe-\xe5\xbao\x05\xd1\xe7\x00' b'\x0e\xc6&\xa1\x92\xae6\x0b\x02i\xfe-\xe5\xbao\x05\xd1\xe7\x00'
b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01F' b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01F'
b'\x13\x00\x00\x00\x00\x01\xec\x00\x00\x03\x06\x00\x00\x00\x01' b'\x13\x00\x00\x00\x00\x01\xec\x00\x00\x03\x06\x00\x00\x00\x01'
b'\x00\x00\x00\x03\x00\x00\x00\x02\xff\xff\xff\xff\x12\xcb\xeby1' b'\x00\x00\x00\x03\x00\x00\x00\x02\xff\xff\xff\xff\x12\xcb\xeby1'
b'\xb6\r\x98B\xcb\x07\xbd`\x8f\x92\xd9\xc4\x84\xbdK\x00\x00\x00' b'\xb6\r\x98B\xcb\x07\xbd`\x8f\x92\xd9\xc4\x84\xbdK\x00\x00\x00'
b'\x00\x00\x00\x00\x00\x00\x00\x00\x00' b'\x00\x00\x00\x00\x00\x00\x00\x00\x00'
) )
class fakechangelog(object):
def __init__(self, idx):
self.index = idx
class fakerepo(object): class fakerepo(object):
def __init__(self, idx): def __init__(self, idx):
"""Just make so that self.changelog.index is the given idx.""" """Just make so that self.changelog.index is the given idx."""
self.index = idx self.changelog = fakechangelog(idx)
self.changelog = self
@unittest.skipIf(PartialDiscovery is None or cparsers is None, @unittest.skipIf(PartialDiscovery is None or cparsers is None,
"rustext or the C Extension parsers module " "rustext or the C Extension parsers module "
"discovery relies on is not available") "discovery relies on is not available")
class rustdiscoverytest(unittest.TestCase): class rustdiscoverytest(unittest.TestCase):
"""Test the correctness of binding to Rust code. """Test the correctness of binding to Rust code.
This test is merely for the binding to Rust itself: extraction of This test is merely for the binding to Rust itself: extraction of