( )⚙ D6750 context: filter out invalid copies from workingctx.p[12]copies()

This is an archive of the discontinued Mercurial Phabricator instance.

context: filter out invalid copies from workingctx.p[12]copies()
ClosedPublic

Authored by martinvonz on Aug 20 2019, 12:29 PM.

Details

Summary

workingctx normally gets its lists of modified, added, removed files
etc. based on the dirstate status. Its constructor also accepts a
"changes" argument to override the status from the dirstate. This is
used for partial commits. If a "changed" argument was passed, we
should clearly also filter out copies to those paths, which I had
previously missed. This patch adds that filtering and fixes the bugs
demonstrated in the previous patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 20 2019, 12:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.