Page MenuHomePhabricator

run-tests: handle --local before --with-hg
ClosedPublic

Authored by martinvonz on Aug 23 2019, 5:05 PM.

Details

Summary

We no longer support them both together, so this is now safe to do. By
checking --local first, we avoid error out about an invalid --with-hg
script if --local was also given (we instead tell the user that the
options are mutually exclusive).

I also had to wrap the 'binpath' we pass to setattr() in _strpath() to
keep python3 run-tests.py -l working. That change also made `python3
run-tests.py -l --chg` work, which was the reason for this series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 23 2019, 5:05 PM
pulkit accepted this revision.Aug 27 2019, 3:57 PM
This revision is now accepted and ready to land.Aug 27 2019, 3:57 PM
This revision was automatically updated to reflect the committed changes.