This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6863

py3: byte-prefix sanitisation regexes in phabricator.py
ClosedPublic

Authored by Kwan on Sep 17 2019, 4:10 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG04c6de38734d: py3: byte-prefix sanitisation regexes in phabricator.py
Summary

So it doesn't die with "TypeError: cannot use a string pattern on a bytes-like
object".

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Sep 17 2019, 4:10 PM
Kwan added a commit: rHG04c6de38734d: py3: byte-prefix sanitisation regexes in phabricator.py.Sep 18 2019, 12:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG04c6de38734d: py3: byte-prefix sanitisation regexes in phabricator.py (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (4 lines)

Diff 16584

hgext/phabricator.py

if r1.uri != r2.uri or r1.method != r2.method: if r1.uri != r2.uri or r1.method != r2.method:
return False return False
r1params = r1.body.split(b'&') r1params = r1.body.split(b'&')
r2params = r2.body.split(b'&') r2params = r2.body.split(b'&')
return set(r1params) == set(r2params) return set(r1params) == set(r2params)
def sanitiserequest(request): def sanitiserequest(request):
request.body = re.sub( request.body = re.sub(
r'cli-[a-z0-9]+', br'cli-[a-z0-9]+',
r'cli-hahayouwish', br'cli-hahayouwish',
request.body request.body
) )
return request return request
def sanitiseresponse(response): def sanitiseresponse(response):
if r'set-cookie' in response[r'headers']: if r'set-cookie' in response[r'headers']:
del response[r'headers'][r'set-cookie'] del response[r'headers'][r'set-cookie']
return response return response