( )⚙ D6875 phabricator: use exthelper to register commands, config, and templates

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6875

phabricator: use exthelper to register commands, config, and templates
ClosedPublic

Authored by mharbison72 on Sep 25 2019, 1:17 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG24bf7a3d3c30: phabricator: use exthelper to register commands, config, and templates

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (27 lines)

Diff 16613

hgext/phabricator.py

from mercurial.node import bin, nullid from mercurial.node import bin, nullid
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
cmdutil, cmdutil,
context, context,
encoding, encoding,
error, error,
exthelper,
httpconnection as httpconnectionmod, httpconnection as httpconnectionmod,
mdiff, mdiff,
obsutil, obsutil,
parser, parser,
patch, patch,
phases, phases,
pycompat, pycompat,
registrar,
scmutil, scmutil,
smartset, smartset,
tags, tags,
templatefilters, templatefilters,
templateutil, templateutil,
url as urlmod, url as urlmod,
util, util,
) )
from mercurial.utils import ( from mercurial.utils import (
procutil, procutil,
stringutil, stringutil,
) )
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = 'ships-with-hg-core'
cmdtable = {} eh = exthelper.exthelper()
command = registrar.command(cmdtable)
configtable = {} cmdtable = eh.cmdtable
configitem = registrar.configitem(configtable) command = eh.command
configtable = eh.configtable
templatekeyword = eh.templatekeyword
# developer config: phabricator.batchsize # developer config: phabricator.batchsize
configitem(b'phabricator', b'batchsize', eh.configitem(b'phabricator', b'batchsize',
default=12, default=12,
) )
configitem(b'phabricator', b'callsign', eh.configitem(b'phabricator', b'callsign',
default=None, default=None,
) )
configitem(b'phabricator', b'curlcmd', eh.configitem(b'phabricator', b'curlcmd',
default=None, default=None,
) )
# developer config: phabricator.repophid # developer config: phabricator.repophid
configitem(b'phabricator', b'repophid', eh.configitem(b'phabricator', b'repophid',
default=None, default=None,
) )
configitem(b'phabricator', b'url', eh.configitem(b'phabricator', b'url',
default=None, default=None,
) )
configitem(b'phabsend', b'confirm', eh.configitem(b'phabsend', b'confirm',
default=False, default=False,
) )
colortable = { colortable = {
b'phabricator.action.created': b'green', b'phabricator.action.created': b'green',
b'phabricator.action.skipped': b'magenta', b'phabricator.action.skipped': b'magenta',
b'phabricator.action.updated': b'magenta', b'phabricator.action.updated': b'magenta',
b'phabricator.desc': b'', b'phabricator.desc': b'',
for i, drev in enumerate(drevs): for i, drev in enumerate(drevs):
if i + 1 == len(drevs) and opts.get(b'comment'): if i + 1 == len(drevs) and opts.get(b'comment'):
actions.append({b'type': b'comment', b'value': opts[b'comment']}) actions.append({b'type': b'comment', b'value': opts[b'comment']})
if actions: if actions:
params = {b'objectIdentifier': drev[b'phid'], params = {b'objectIdentifier': drev[b'phid'],
b'transactions': actions} b'transactions': actions}
callconduit(ui, b'differential.revision.edit', params) callconduit(ui, b'differential.revision.edit', params)
templatekeyword = registrar.templatekeyword() @eh.templatekeyword(b'phabreview', requires={b'ctx'})
@templatekeyword(b'phabreview', requires={b'ctx'})
def template_review(context, mapping): def template_review(context, mapping):
""":phabreview: Object describing the review for this changeset. """:phabreview: Object describing the review for this changeset.
Has attributes `url` and `id`. Has attributes `url` and `id`.
""" """
ctx = context.resource(mapping, b'ctx') ctx = context.resource(mapping, b'ctx')
m = _differentialrevisiondescre.search(ctx.description()) m = _differentialrevisiondescre.search(ctx.description())
if m: if m:
return templateutil.hybriddict({ return templateutil.hybriddict({