Page MenuHomePhabricator

merge: check argument value with if/raise instead of an assert
ClosedPublic

Authored by durin42 on Sep 25 2019, 11:10 AM.

Details

Summary

This shouldn't make any difference for legal code, but it'll prevent
the assertion from being optimized out if someone decides to do -O on
our code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 25 2019, 11:10 AM
pulkit accepted this revision.Sep 25 2019, 11:35 AM
This revision is now accepted and ready to land.Sep 25 2019, 11:35 AM