This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: change conduit data format to match arcanist
ClosedPublic

Authored by Kwan on Oct 10 2019, 5:52 PM.

Details

Summary

The existing form isn't handled well by Phabricator for certain data types.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17082.Oct 11 2019, 1:55 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

Kwan updated this revision to Diff 17102.Oct 12 2019, 9:45 AM

I'd missed out the attrs key conversion needed on py3.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.