This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7110

rust-refsharing: add missing lifetime parameter in ref_sharing
ClosedPublic

Authored by Alphare on Oct 15 2019, 3:11 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG00222775d59b: rust-refsharing: add missing lifetime parameter in ref_sharing
rHGb902066d9b86: rust-refsharing: add missing lifetime parameter in ref_sharing
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 15 2019, 3:11 PM
Alphare retitled this revision from rust-status: add missing lifetime parameter in ref_sharing to rust-refsharing: add missing lifetime parameter in ref_sharing.Oct 16 2019, 4:01 AM
martinvonz accepted this revision.Oct 16 2019, 5:19 PM
This revision is now accepted and ready to land.Oct 16 2019, 5:19 PM

Revision Contents
Changeset List

PathPackages
Mrust/hg-cpython/src/ref_sharing.rs (2 lines)

Diff 17268

rust/hg-cpython/src/ref_sharing.rs

pub unsafe fn new( pub unsafe fn new(
py: Python<'a>, py: Python<'a>,
owner: &'a PyObject, owner: &'a PyObject,
data: &'a PySharedRefCell<T>, data: &'a PySharedRefCell<T>,
) -> Self { ) -> Self {
Self { py, owner, data } Self { py, owner, data }
} }
pub fn borrow(&self) -> Ref<T> { pub fn borrow(&self) -> Ref<'a, T> {
self.data.borrow() self.data.borrow()
} }
pub fn borrow_mut(&self) -> PyResult<PyRefMut<'a, T>> { pub fn borrow_mut(&self) -> PyResult<PyRefMut<'a, T>> {
self.data.borrow_mut(self.py) self.data.borrow_mut(self.py)
} }
/// Returns a leaked reference and its management object. /// Returns a leaked reference and its management object.