This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7128

rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions
ClosedPublic

Authored by Alphare on Oct 17 2019, 8:24 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6230c70a1863: rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions
rHG93827664a7d7: rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions
Summary

When I initially ran the tests on my series, there were test failures related
to those extensions. Now that the initial series has landed, I felt like going
back to those issues because people with performance issues will often want to
use fsmonitor and sparse.

Either because of flaky tests or because the series has changed so much, I
can't seem to reproduce these issues... let's widen the scope of the fast-path.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 17 2019, 8:24 AM
Alphare added a commit: rHG93827664a7d7: rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions.Oct 18 2019, 7:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG93827664a7d7: rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
martinvonz added a subscriber: martinvonz.Oct 18 2019, 12:37 PM
martinvonz added inline comments.
mercurial/dirstate.py
1119

This made the import of sparse unused. I'll remove it.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (5 lines)

Diff 17338

mercurial/dirstate.py

use_rust = False use_rust = False
elif self._ignorefiles() and listignored: elif self._ignorefiles() and listignored:
# Rust has no ignore mechanism yet, so don't use Rust for # Rust has no ignore mechanism yet, so don't use Rust for
# commands that need ignore. # commands that need ignore.
use_rust = False use_rust = False
elif not match.always(): elif not match.always():
# Matchers have yet to be implemented # Matchers have yet to be implemented
use_rust = False use_rust = False
# We don't yet have a mechanism for extensions
elif sparse.enabled:
martinvonzUnsubmitted
Not Done

This made the import of sparse unused. I'll remove it.

martinvonz: This made the import of `sparse` unused. I'll remove it.
use_rust = False
elif not getattr(self, "_fsmonitordisable", True):
use_rust = False
if use_rust: if use_rust:
( (
lookup, lookup,
modified, modified,
added, added,
removed, removed,
deleted, deleted,