This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7291

bundle2: more pytype suppressions around bytestring
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:59 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGea25b4673231: bundle2: more pytype suppressions around bytestring
Summary

We clearly need to work around this somehow.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:59 PM
indygreg accepted this revision.Nov 7 2019, 3:23 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:23 AM
durin42 added a commit: rHGea25b4673231: bundle2: more pytype suppressions around bytestring.Nov 7 2019, 3:35 AM
Closed by commit rHGea25b4673231: bundle2: more pytype suppressions around bytestring (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (8 lines)

Diff 17704

mercurial/bundle2.py

"""total number of parts added to the bundler""" """total number of parts added to the bundler"""
return len(self._parts) return len(self._parts)
# methods used to defines the bundle2 content # methods used to defines the bundle2 content
def addparam(self, name, value=None): def addparam(self, name, value=None):
"""add a stream level parameter""" """add a stream level parameter"""
if not name: if not name:
raise error.ProgrammingError(b'empty parameter name') raise error.ProgrammingError(b'empty parameter name')
if name[0:1] not in pycompat.bytestr(string.ascii_letters): if name[0:1] not in pycompat.bytestr(
string.ascii_letters # pytype: disable=wrong-arg-types
):
raise error.ProgrammingError( raise error.ProgrammingError(
b'non letter first character: %s' % name b'non letter first character: %s' % name
) )
self._params.append((name, value)) self._params.append((name, value))
def addpart(self, part): def addpart(self, part):
"""add a new part to the bundle2 container """add a new part to the bundle2 container
ignored when unknown. Those starting with an upper case letter are ignored when unknown. Those starting with an upper case letter are
mandatory and will this function will raise a KeyError when unknown. mandatory and will this function will raise a KeyError when unknown.
Note: no option are currently supported. Any input will be either Note: no option are currently supported. Any input will be either
ignored or failing. ignored or failing.
""" """
if not name: if not name:
raise ValueError(r'empty parameter name') raise ValueError(r'empty parameter name')
if name[0:1] not in pycompat.bytestr(string.ascii_letters): if name[0:1] not in pycompat.bytestr(
string.ascii_letters # pytype: disable=wrong-arg-types
):
raise ValueError(r'non letter first character: %s' % name) raise ValueError(r'non letter first character: %s' % name)
try: try:
handler = b2streamparamsmap[name.lower()] handler = b2streamparamsmap[name.lower()]
except KeyError: except KeyError:
if name[0:1].islower(): if name[0:1].islower():
indebug(self.ui, b"ignoring unknown parameter %s" % name) indebug(self.ui, b"ignoring unknown parameter %s" % name)
else: else:
raise error.BundleUnknownFeatureError(params=(name,)) raise error.BundleUnknownFeatureError(params=(name,))