Previously HTTPConnection._connect() called socket.create_connection() without
specifying a timeout. This could cause the code to hang forever trying to
establish a connection, even if a timeout parameter was specified when
creating the HTTPConnection object.
Details
Details
- Reviewers
phillco durin42 - Group Reviewers
hg-reviewers
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
httpclient is off by default, and is actually vendored code from https://bitbucket.org/durin42/httpplus - Could you sign https://cla.developers.google.com/about/google-individual and send this patch to httpplus (and then we can update the vendored copy).
Alternatively, httpplus is probably a dead end, and we should instead look into switching to requests (so we pick up Cory Benfield's awesome work on that), so we could just rip out httpclient and everything that requires it...