This is an archive of the discontinued Mercurial Phabricator instance.

debugcommands: suppress import errors for pytype
ClosedPublic

Authored by durin42 on Nov 13 2019, 10:51 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 13 2019, 10:51 PM
dlax accepted this revision.Nov 14 2019, 5:02 AM
dlax added a subscriber: dlax.

I wonder if using importlib.import_module() wouldn't help. Or is it something we avoid in Mercurial?

In D7385#108592, @dlax wrote:

I wonder if using importlib.import_module() wouldn't help. Or is it something we avoid in Mercurial?

We use it in other places. I have no idea the extent to which it'd help.

durin42 updated this revision to Diff 18157.Nov 15 2019, 11:32 AM
indygreg accepted this revision.Nov 18 2019, 10:44 PM
This revision is now accepted and ready to land.Nov 18 2019, 10:44 PM
This revision was automatically updated to reflect the committed changes.