( )⚙ D7507 phabricator: add a "phabstatus" template keyword

This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: add a "phabstatus" template keyword
ClosedPublic

Authored by dlax on Nov 22 2019, 11:00 AM.

Details

Summary

We add a "phabstatus" template keyword, returning an object with "url"
and "status" keys. This is quite similar to "phabreview" template
keyword, but it queries phabricator for each specified revision so it's
going to be slow (as compared to the "phabstatus" show view from
previous changeset).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

dlax created this revision.Nov 22 2019, 11:00 AM
dlax updated this revision to Diff 18316.Nov 22 2019, 11:03 AM
dlax updated this revision to Diff 18321.Nov 22 2019, 4:13 PM

I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

dlax added a comment.Nov 23 2019, 11:45 AM
I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

Not that I am aware. Using this keyword on large revsets is indeed slow.

pulkit accepted this revision.Dec 10 2019, 10:48 AM
This revision is now accepted and ready to land.Dec 10 2019, 10:48 AM
dlax updated this revision to Diff 18590.Dec 10 2019, 2:46 PM
This revision was automatically updated to reflect the committed changes.