| hg-reviewers |
IIRC, it's common in Rust to call functions with the module prefix.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| //! `hg-core` crate. From Python, this will be seen as `rustext.filepatterns` | //! `hg-core` crate. From Python, this will be seen as `rustext.filepatterns` | ||||
| //! and can be used as replacement for the the pure `filepatterns` Python | //! and can be used as replacement for the the pure `filepatterns` Python | ||||
| //! module. | //! module. | ||||
| //! | //! | ||||
| use crate::exceptions::{PatternError, PatternFileError}; | use crate::exceptions::{PatternError, PatternFileError}; | ||||
| use cpython::{ | use cpython::{ | ||||
| PyBytes, PyDict, PyModule, PyObject, PyResult, PyTuple, Python, ToPyObject, | PyBytes, PyDict, PyModule, PyObject, PyResult, PyTuple, Python, ToPyObject, | ||||
| }; | }; | ||||
| use hg::{ | use hg::utils::files; | ||||
| build_single_regex, read_pattern_file, utils::files::get_path_from_bytes, | use hg::{build_single_regex, read_pattern_file, LineNumber, PatternTuple}; | ||||
| LineNumber, PatternTuple, | |||||
| }; | |||||
| use std::path::PathBuf; | use std::path::PathBuf; | ||||
| /// Rust does not like functions with different return signatures. | /// Rust does not like functions with different return signatures. | ||||
| /// The 3-tuple version is always returned by the hg-core function, | /// The 3-tuple version is always returned by the hg-core function, | ||||
| /// the (potential) conversion is handled at this level since it is not likely | /// the (potential) conversion is handled at this level since it is not likely | ||||
| /// to have any measurable impact on performance. | /// to have any measurable impact on performance. | ||||
| /// | /// | ||||
| /// The Python implementation passes a function reference for `warn` instead | /// The Python implementation passes a function reference for `warn` instead | ||||
| /// of a boolean that is used to emit warnings while parsing. The Rust | /// of a boolean that is used to emit warnings while parsing. The Rust | ||||
| /// implementation chooses to accumulate the warnings and propagate them to | /// implementation chooses to accumulate the warnings and propagate them to | ||||
| /// Python upon completion. See the `readpatternfile` function in `match.py` | /// Python upon completion. See the `readpatternfile` function in `match.py` | ||||
| /// for more details. | /// for more details. | ||||
| fn read_pattern_file_wrapper( | fn read_pattern_file_wrapper( | ||||
| py: Python, | py: Python, | ||||
| file_path: PyObject, | file_path: PyObject, | ||||
| warn: bool, | warn: bool, | ||||
| source_info: bool, | source_info: bool, | ||||
| ) -> PyResult<PyTuple> { | ) -> PyResult<PyTuple> { | ||||
| let bytes = file_path.extract::<PyBytes>(py)?; | let bytes = file_path.extract::<PyBytes>(py)?; | ||||
| let path = get_path_from_bytes(bytes.data(py)); | let path = files::get_path_from_bytes(bytes.data(py)); | ||||
| match read_pattern_file(path, warn) { | match read_pattern_file(path, warn) { | ||||
| Ok((patterns, warnings)) => { | Ok((patterns, warnings)) => { | ||||
| if source_info { | if source_info { | ||||
| let itemgetter = |x: &PatternTuple| { | let itemgetter = |x: &PatternTuple| { | ||||
| (PyBytes::new(py, &x.0), x.1, PyBytes::new(py, &x.2)) | (PyBytes::new(py, &x.0), x.1, PyBytes::new(py, &x.2)) | ||||
| }; | }; | ||||
| let results: Vec<(PyBytes, LineNumber, PyBytes)> = | let results: Vec<(PyBytes, LineNumber, PyBytes)> = | ||||
| patterns.iter().map(itemgetter).collect(); | patterns.iter().map(itemgetter).collect(); | ||||