( )⚙ D7625 config: catch intended exception when failing to parse config

This is an archive of the discontinued Mercurial Phabricator instance.

config: catch intended exception when failing to parse config
ClosedPublic

Authored by martinvonz on Dec 12 2019, 6:44 PM.

Details

Summary

When a new config parser was introduced in fca54469480e (ui: introduce
new config parser, 2009-04-23), the reading side would raise a
ConfigError which was then caught in the ui code. Then, in
2123aad24d56 (error: add new ParseError for various parsing errors,
2010-06-04), a ParseError was raised instead, but the call site was
not updated. Let's start catching that ParseError. We still don't
print it in a friendly way, but that's not worse than before.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 12 2019, 6:44 PM
martinvonz updated this revision to Diff 18777.Dec 16 2019, 6:33 PM
pulkit accepted this revision.Dec 17 2019, 6:31 AM
This revision is now accepted and ready to land.Dec 17 2019, 6:31 AM