This is an archive of the discontinued Mercurial Phabricator instance.

nodemap: only use persistent nodemap for non-inlined revlog
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:03 PM.

Details

Summary

Revlog are inlined while they are small (to avoid having too many file to deal
with). The persistent nodemap will only provides a significant boost for large
enough revlog index. So it does not make sens to add an extra file to store
nodemap for small revlog.

We could consider inclining the nodemap data inside the revlog itself, but the
benefit is unclear so let it be an adventure for another time.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Jan 11 2020, 12:03 PM
marmoute updated this revision to Diff 19174.Jan 13 2020, 10:06 AM
marmoute updated this revision to Diff 19427.Jan 17 2020, 1:05 PM
martinvonz accepted this revision.Jan 23 2020, 1:57 PM
This revision is now accepted and ready to land.Jan 23 2020, 1:57 PM
marmoute updated this revision to Diff 19753.Jan 31 2020, 10:28 AM
marmoute updated this revision to Diff 19783.Jan 31 2020, 5:58 PM
marmoute updated this revision to Diff 19827.Feb 2 2020, 3:17 AM

small doc update on .#s[1]

marmoute updated this revision to Diff 19885.Feb 4 2020, 7:24 PM

rebase to latest default