This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7874

phabricator: post revisions in ascending topological order (issue6241)
ClosedPublic

Authored by mharbison72 on Jan 14 2020, 4:39 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa7c4bcf7018a: phabricator: post revisions in ascending topological order (issue6241)
Summary

The parent in phabricator ends up being the last revision posted, so sorting the
user input into ascending order should be enough to preserve the proper
relationships.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 14 2020, 4:39 PM
mharbison72 added a comment.Jan 14 2020, 4:43 PM

I don't see any guardrails that prevent mixing unrelated local stuff into the revset and erroneously assigning the last revision processed as a parent, but that's less trivial and can probably wait until someone stumbles on it.

pulkit accepted this revision.Jan 14 2020, 4:46 PM
This revision is now accepted and ready to land.Jan 14 2020, 4:46 PM

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (1 line)

Diff 19271

hgext/phabricator.py

confirm = true confirm = true
phabsend will check obsstore and the above association to decide whether to phabsend will check obsstore and the above association to decide whether to
update an existing Differential Revision, or create a new one. update an existing Differential Revision, or create a new one.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
revs = list(revs) + opts.get(b'rev', []) revs = list(revs) + opts.get(b'rev', [])
revs = scmutil.revrange(repo, revs) revs = scmutil.revrange(repo, revs)
revs.sort() # ascending order to preserve topological parent/child in phab
if not revs: if not revs:
raise error.Abort(_(b'phabsend requires at least one changeset')) raise error.Abort(_(b'phabsend requires at least one changeset'))
if opts.get(b'amend'): if opts.get(b'amend'):
cmdutil.checkunfinished(repo) cmdutil.checkunfinished(repo)
# {newnode: (oldnode, olddiff, olddrev} # {newnode: (oldnode, olddiff, olddrev}
oldmap = getoldnodedrevmap(repo, [repo[r].node() for r in revs]) oldmap = getoldnodedrevmap(repo, [repo[r].node() for r in revs])