This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8109

context: use manifest.find() instead of two separate calls
ClosedPublic

Authored by durin42 on Feb 11 2020, 12:08 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG2e2cfc3bea0b: context: use manifest.find() instead of two separate calls
Summary

I noticed this while debugging an extension that's implementing the manifest
interface. Always nice to save a function call.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 11 2020, 12:08 AM
durin42 added a commit: rHG2e2cfc3bea0b: context: use manifest.find() instead of two separate calls.Feb 11 2020, 12:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG2e2cfc3bea0b: context: use manifest.find() instead of two separate calls (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 20147

mercurial/context.py

parents = self._parents parents = self._parents
if len(parents) == 2: if len(parents) == 2:
return parents[1] return parents[1]
return self._repo[nullrev] return self._repo[nullrev]
def _fileinfo(self, path): def _fileinfo(self, path):
if '_manifest' in self.__dict__: if '_manifest' in self.__dict__:
try: try:
return self._manifest[path], self._manifest.flags(path) return self._manifest.find(path)
except KeyError: except KeyError:
raise error.ManifestLookupError( raise error.ManifestLookupError(
self._node, path, _(b'not found in manifest') self._node, path, _(b'not found in manifest')
) )
if '_manifestdelta' in self.__dict__ or path in self.files(): if '_manifestdelta' in self.__dict__ or path in self.files():
if path in self._manifestdelta: if path in self._manifestdelta:
return ( return (
self._manifestdelta[path], self._manifestdelta[path],