This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8366

manifest: also declare treemanifest as implementing imanifestdict
ClosedPublic

Authored by durin42 on Apr 2 2020, 1:16 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8c66a680f396: manifest: also declare treemanifest as implementing imanifestdict
Summary

It always has been intended to be, but it had a mismatched flags()
method until the previous change.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 2 2020, 1:16 PM
pulkit accepted this revision.Apr 3 2020, 5:20 AM
This revision is now accepted and ready to land.Apr 3 2020, 5:20 AM

Revision Contents
Changeset List

Diff 20983

mercurial/manifest.py

return dir + b'/', subpath return dir + b'/', subpath
else: else:
return b'', f return b'', f
_noop = lambda s: None _noop = lambda s: None
@interfaceutil.implementer(repository.imanifestdict)
class treemanifest(object): class treemanifest(object):
def __init__(self, dir=b'', text=b''): def __init__(self, dir=b'', text=b''):
self._dir = dir self._dir = dir
self._node = nullid self._node = nullid
self._loadfunc = _noop self._loadfunc = _noop
self._copyfunc = _noop self._copyfunc = _noop
self._dirty = False self._dirty = False
self._dirs = {} self._dirs = {}

tests/test-check-interfaces.py

httpv1 = wireprotoserver.httpv1protocolhandler(None, None, None) httpv1 = wireprotoserver.httpv1protocolhandler(None, None, None)
checkzobject(httpv1) checkzobject(httpv1)
httpv2 = wireprotov2server.httpv2protocolhandler(None, None) httpv2 = wireprotov2server.httpv2protocolhandler(None, None)
checkzobject(httpv2) checkzobject(httpv2)
ziverify.verifyClass(repository.ifilestorage, filelog.filelog) ziverify.verifyClass(repository.ifilestorage, filelog.filelog)
ziverify.verifyClass(repository.imanifestdict, manifest.manifestdict) ziverify.verifyClass(repository.imanifestdict, manifest.manifestdict)
ziverify.verifyClass(repository.imanifestdict, manifest.treemanifest)
ziverify.verifyClass( ziverify.verifyClass(
repository.imanifestrevisionstored, manifest.manifestctx repository.imanifestrevisionstored, manifest.manifestctx
) )
ziverify.verifyClass( ziverify.verifyClass(
repository.imanifestrevisionwritable, manifest.memmanifestctx repository.imanifestrevisionwritable, manifest.memmanifestctx
) )
ziverify.verifyClass( ziverify.verifyClass(
repository.imanifestrevisionstored, manifest.treemanifestctx repository.imanifestrevisionstored, manifest.treemanifestctx