This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8391

histedit: add test that an invalid editor doesn't bork client state
ClosedPublic

Authored by durin42 on Apr 9 2020, 3:47 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbca57ad9e630: histedit: add test that an invalid editor doesn't bork client state
Summary

We had a report of a situation like this borking a user at Google, but
I can't reproduce it in a test. Let's at least backstop the issue with
a test, so we don't accidentally introduce such a bug...

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 9 2020, 3:47 PM
pulkit accepted this revision.Apr 10 2020, 7:42 AM
This revision is now accepted and ready to land.Apr 10 2020, 7:42 AM

Revision Contents
Changeset List

PathPackages
Mtests/test-histedit-non-commute.t (3 lines)

Diff 21025

tests/test-histedit-non-commute.t

| summary: a | summary: a
| |
o changeset: 0:1715188a53c7 o changeset: 0:1715188a53c7
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: Initial commit summary: Initial commit
An invalid editor shouldn't leave the user in a broken state:
$ EDITOR=totally-not-a-thing-unsensible-editor-value hg histedit 4
$ cd .. $ cd ..