This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	mharbison72	D9206 posix: avoid a leaked file descriptor in a unix domain socket exception case
	Closed	mharbison72	D9205 posix: use context managers in a couple of places

Diff 23219


	def bindunixsocket(sock, path):			def bindunixsocket(sock, path):
	"""Bind the UNIX domain socket to the specified path"""			"""Bind the UNIX domain socket to the specified path"""
	# use relative path instead of full path at bind() if possible, since			# use relative path instead of full path at bind() if possible, since
	# AF_UNIX path has very small length limit (107 chars) on common			# AF_UNIX path has very small length limit (107 chars) on common
	# platforms (see sys/un.h)			# platforms (see sys/un.h)
	dirname, basename = os.path.split(path)			dirname, basename = os.path.split(path)
	bakwdfd = None			bakwdfd = None

				try:
	if dirname:			if dirname:
	bakwdfd = os.open(b'.', os.O_DIRECTORY)			bakwdfd = os.open(b'.', os.O_DIRECTORY)
	os.chdir(dirname)			os.chdir(dirname)
	sock.bind(basename)			sock.bind(basename)
	if bakwdfd:			if bakwdfd:
	os.fchdir(bakwdfd)			os.fchdir(bakwdfd)
				finally:
				if bakwdfd:
	os.close(bakwdfd)			os.close(bakwdfd)