This is an archive of the discontinued Mercurial Phabricator instance.

share: fix a typo in a safe share error message
AbandonedPublic

Authored by mharbison72 on Nov 9 2020, 7:09 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Nov 9 2020, 7:09 PM
mharbison72 added inline comments.
mercurial/commands.py
2230–2236

Hmm... This whole block actually looks unreachable. Any idea where this is supposed to go @pulkit ? Is the raise clause above this supposed to come after this conditional?

pulkit added inline comments.Nov 19 2020, 4:22 AM
mercurial/commands.py
2230–2236

Oops, this if requirements... not in ... should come after if not repo.shared() instead of nested inside it.

pulkit added inline comments.Nov 21 2020, 8:09 AM
mercurial/commands.py
2230–2236

Sent D9360 to fix this.

mharbison72 abandoned this revision.Nov 23 2020, 11:53 AM

Superseded by D9360