This is an archive of the discontinued Mercurial Phabricator instance.

remotenames: add functions to read remotenames data from .hg/remotenames/
AbandonedPublic

Authored by pulkit on Oct 4 2017, 5:53 PM.

Details

Reviewers
dlax
Group Reviewers
hg-reviewers
Summary

This patch functions which can be used to read remotenames data from
.hg/remotenames/. The logic for the function which reads the remotenames file is
taken from the remotenames extension.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 4 2017, 5:53 PM
dlax requested changes to this revision.Oct 5 2017, 4:07 AM
dlax added a subscriber: dlax.

Overall, the series only introduces helper functions. So it's hard to tell if the implementation is meaningful without any use of the code...

mercurial/remotenames.py
20

repo not used

49

Why only "bookmarks"? (and not "branches")

73

As in previous patch, readremotebookmarks and readremotebranches functions only differ from the file name; this could be factored out as a function parameter.

This revision now requires changes to proceed.Oct 5 2017, 4:07 AM
pulkit abandoned this revision.Oct 17 2017, 7:20 PM

Will revisit after the freeze.

pulkit abandoned this revision.Nov 29 2017, 5:04 PM

Updated the series with new differentials D1547 to D1551.