Feed All Stories

Sat, Nov 17

yuja added a comment to D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.

> + $ if [ -x /usr/local/bin/gmake ] ; then
> + > MAKE=gmake

Isn't this assuming that /usr/local/bin is in $PATH? IOW, shouldn't this
assignment be:

	MAKE=/usr/local/bin/gmake
Sat, Nov 17, 9:56 PM
av6 committed rHG69268a13ffa5: branch: allow changing branch of merge commits with --rev.
branch: allow changing branch of merge commits with --rev
Sat, Nov 17, 9:32 PM
mharbison72 committed rHGfb379b78b93e: lfs: ensure that the return of urlopener.open() is closed.
lfs: ensure that the return of urlopener.open() is closed
Sat, Nov 17, 9:32 PM
yuja added a comment to D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.

Missing includes of stdint.h and stddef.h (or stdlib.h).

Sat, Nov 17, 9:30 PM
lothiraldan created D5283: tests: add Balto configuration file.
Sat, Nov 17, 8:41 PM
yuja added a comment to D5278: narrow: detect if narrowspec was changed in a different share.
  1. d1/f, d3/f, d3/g and d5/f should no longer be reported $ hg -R main files + not deleting possibly dirty file d3/f + not deleting possibly dirty file d3/g + not deleting possibly dirty file d5/f
Sat, Nov 17, 2:25 AM
spectral closed D5280: changegroup: avoid instantiating storage if we are not using it.
Sat, Nov 17, 1:12 AM
spectral committed rHGdba590f27c7a: changegroup: avoid instantiating storage if we are not using it.
changegroup: avoid instantiating storage if we are not using it
Sat, Nov 17, 1:12 AM
mharbison72 committed rHGc53f0ead5781: http: allow 'auth.prefix' to have a username consistent with the URI.
http: allow 'auth.prefix' to have a username consistent with the URI
Sat, Nov 17, 1:12 AM

Fri, Nov 16

mharbison72 committed rHG380f5131ee7b: lfs: handle URLErrors to add additional information.
lfs: handle URLErrors to add additional information
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG93e5d18251d6: lfs: make the exception messages consistent.
lfs: make the exception messages consistent
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG9f78d10742af: lfs: improve the hints for common errors in the Batch API.
lfs: improve the hints for common errors in the Batch API
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG4ec8bee15930: scmutil: display the optional hint when handling StorageError in catchall().
scmutil: display the optional hint when handling StorageError in catchall()
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG8863f08c1630: lfs: provide more Batch API error info via a hint in the raised exception.
lfs: provide more Batch API error info via a hint in the raised exception
Fri, Nov 16, 11:48 PM
lothiraldan committed rHG2eb48aa0acce: sparse-revlog: align endrevidx usages in the _slicechunktosize.
sparse-revlog: align endrevidx usages in the _slicechunktosize
Fri, Nov 16, 11:48 PM
yuja committed rHG3bc2e550f2bd: graft: do not try to skip rev derived from ancestor more than once (issue6024).
graft: do not try to skip rev derived from ancestor more than once (issue6024)
Fri, Nov 16, 11:04 PM
mharbison72 committed rHG69d4c8c5c25e: subrepo: print the status line before creating the peer for better diagnostics.
subrepo: print the status line before creating the peer for better diagnostics
Fri, Nov 16, 9:18 PM
yuja committed rHGd0895b5f51c9: graft: do not try to skip rev derived from ancestor more than once (issue6024).
graft: do not try to skip rev derived from ancestor more than once (issue6024)
Fri, Nov 16, 5:31 PM
lothiraldan committed rHGfd1d41ccbe38: sparse-revlog: use `span` variable as intended.
sparse-revlog: use `span` variable as intended
Fri, Nov 16, 1:59 PM
yuja added a comment to D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.

+ self.repo.ui.log("rebase",
+ "using in-memory rebase: %r\n" % self.inmemory,

Fri, Nov 16, 8:58 AM
lothiraldan closed D5282: logtoprocess: update commandfinish options arguments.
Fri, Nov 16, 8:58 AM
mharbison72 committed rHG6d0fdeda43f7: tests: stabilize test-commandserver.t on Windows.
tests: stabilize test-commandserver.t on Windows
Fri, Nov 16, 8:58 AM
mharbison72 committed rHG291080871f50: histedit: conditionalize the imports of 'fcntl' and 'termios'.
histedit: conditionalize the imports of 'fcntl' and 'termios'
Fri, Nov 16, 8:58 AM
lothiraldan committed rHG1243295fcc3a: logtoprocess: update commandfinish options arguments.
logtoprocess: update commandfinish options arguments
Fri, Nov 16, 8:58 AM
spectral committed rHGea84c2b286a2: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Fri, Nov 16, 8:58 AM
lothiraldan created D5282: logtoprocess: update commandfinish options arguments.
Fri, Nov 16, 8:33 AM
spectral closed D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Fri, Nov 16, 7:59 AM
spectral committed rHG7ce3662bf1bc: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Fri, Nov 16, 7:59 AM
lothiraldan accepted D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.

Looks good to me, queued thanks

Fri, Nov 16, 7:58 AM
martinvonz closed D5281: wireprotov2server: let repo.narrowmatch(match) do matcher intersection.
Fri, Nov 16, 6:41 AM
martinvonz committed rHGf83cea7f54d7: wireprotov2server: let repo.narrowmatch(match) do matcher intersection.
wireprotov2server: let repo.narrowmatch(match) do matcher intersection
Fri, Nov 16, 6:41 AM
pulkit accepted D5281: wireprotov2server: let repo.narrowmatch(match) do matcher intersection.
Fri, Nov 16, 5:51 AM

Thu, Nov 15

martinvonz created D5281: wireprotov2server: let repo.narrowmatch(match) do matcher intersection.
Thu, Nov 15, 6:33 PM
spectral created D5280: changegroup: avoid instantiating storage if we are not using it.
Thu, Nov 15, 5:40 PM
spectral created D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Thu, Nov 15, 5:36 PM
yuja committed rHG85372dc0cca3: blackbox: extract function to test if log event is tracked.
blackbox: extract function to test if log event is tracked
Thu, Nov 15, 9:42 AM
yuja committed rHG179c02baaa8c: blackbox: initialize repo attribute properly.
blackbox: initialize repo attribute properly
Thu, Nov 15, 9:42 AM
yuja committed rHG6d9a87fb8c89: blackbox: initialize inlog flag properly.
blackbox: initialize inlog flag properly
Thu, Nov 15, 9:42 AM
yuja committed rHGfff3e213ace9: blackbox: unindent "if True" block.
blackbox: unindent "if True" block
Thu, Nov 15, 9:42 AM
yuja committed rHGa9393d7600f3: blackbox: extract logger class from ui wrapper.
blackbox: extract logger class from ui wrapper
Thu, Nov 15, 9:42 AM
yuja committed rHG56694b4d41b0: blackbox: rename variables to prepare extracting core logic from ui wrapper.
blackbox: rename variables to prepare extracting core logic from ui wrapper
Thu, Nov 15, 9:42 AM
lothiraldan committed rHG9c3c697267db: sparse-revlog: rework the way we enforce chunk size limit.
sparse-revlog: rework the way we enforce chunk size limit
Thu, Nov 15, 7:15 AM
lothiraldan committed rHGa3183ca7ce8f: tests: add `revlogutils.deltas` module to doctests.
tests: add `revlogutils.deltas` module to doctests
Thu, Nov 15, 7:15 AM
lothiraldan committed rHG85b14f0dc334: doctest: add a `issnapshot` method to _testrevlog.
doctest: add a `issnapshot` method to _testrevlog
Thu, Nov 15, 7:15 AM
yuja committed rHG437520219e0c: merge with stable.
merge with stable
Thu, Nov 15, 6:34 AM
Diffusion closed D5255: mergetools: adjust Beyond Compare config on Mac/Linux.
Thu, Nov 15, 6:34 AM
durin42 closed D5272: tests: allow for 100% of profiled time in sleep in test-profile.t.
Thu, Nov 15, 6:34 AM
joco <joco@google.com> committed rHGa182dc714afa: mergetools: adjust Beyond Compare config on Mac/Linux.
mergetools: adjust Beyond Compare config on Mac/Linux
Thu, Nov 15, 6:34 AM
durin42 committed rHG4790732559ad: tests: allow for 100% of profiled time in sleep in test-profile.t.
tests: allow for 100% of profiled time in sleep in test-profile.t
Thu, Nov 15, 6:34 AM
yuja added a comment to D5273: hgignore: faster conversion from globs to regexp.
I couldn't find documentation on how encoding works for this (user
data interpreted by hg). This function appears to assume the
encoding of the input pattern is an extension of ascii, so I think
my change should be correct for that.
Thu, Nov 15, 6:33 AM
av6 committed rHG8c6329fa6038: rewriteutil: move publicrevs closer to where it's used.
rewriteutil: move publicrevs closer to where it's used
Thu, Nov 15, 6:16 AM
martinvonz updated the diff for D5278: narrow: detect if narrowspec was changed in a different share.
Thu, Nov 15, 12:32 AM

Wed, Nov 14

martinvonz created D5278: narrow: detect if narrowspec was changed in a different share.
Wed, Nov 14, 8:13 PM
martinvonz created D5276: tests: add test for narrow+share.
Wed, Nov 14, 8:13 PM
martinvonz added a dependent revision for D5277: narrow: extract helper for parsing narrowspec file: D5278: narrow: detect if narrowspec was changed in a different share.
Wed, Nov 14, 8:13 PM
martinvonz created D5277: narrow: extract helper for parsing narrowspec file.
Wed, Nov 14, 8:13 PM
martinvonz added a dependent revision for D5276: tests: add test for narrow+share: D5277: narrow: extract helper for parsing narrowspec file.
Wed, Nov 14, 8:13 PM
martinvonz added a dependent revision for D5275: tests: update store narrowspec when narrowspec, not dirstate, is accessed: D5276: tests: add test for narrow+share.
Wed, Nov 14, 8:12 PM
av6 committed rHGe5f54c4ec075: copystore: provide unit to ui.makeprogress().
copystore: provide unit to ui.makeprogress()
Wed, Nov 14, 3:29 PM
av6 committed rHGd2ff0af6e959: verify: provide unit to ui.makeprogress().
verify: provide unit to ui.makeprogress()
Wed, Nov 14, 3:29 PM
martinvonz closed D5274: requires: use atomictemp=True when writing .hg/requires.
Wed, Nov 14, 3:26 PM
martinvonz committed rHGacd17caa699a: requires: use atomictemp=True when writing .hg/requires.
requires: use atomictemp=True when writing .hg/requires
Wed, Nov 14, 3:26 PM
martinvonz created D5275: tests: update store narrowspec when narrowspec, not dirstate, is accessed.
Wed, Nov 14, 3:21 PM
martinvonz created D5274: requires: use atomictemp=True when writing .hg/requires.
Wed, Nov 14, 3:05 PM
valentin.gatienbaron created D5273: hgignore: faster conversion from globs to regexp.
Wed, Nov 14, 2:48 PM
yuja committed rHGc9876c00d292: blackbox: extract _log() function which is called after lastui is resolved.
blackbox: extract _log() function which is called after lastui is resolved
Wed, Nov 14, 1:02 PM
yuja committed rHGda3bc2f54b02: blackbox: simply update global lastui variable at once.
blackbox: simply update global lastui variable at once
Wed, Nov 14, 1:02 PM
yuja committed rHG4a38a67d0e96: blackbox: inline temporary variables which are referenced only once.
blackbox: inline temporary variables which are referenced only once
Wed, Nov 14, 1:02 PM
yuja committed rHG345cdb93851b: blackbox: consolidate conditions for early return.
blackbox: consolidate conditions for early return
Wed, Nov 14, 1:02 PM
yuja committed rHG5bd3d6b264c1: blackbox: remove redundant check for unassigned repo.
blackbox: remove redundant check for unassigned repo
Wed, Nov 14, 1:02 PM
durin42 created D5272: tests: allow for 100% of profiled time in sleep in test-profile.t.
Wed, Nov 14, 11:52 AM
durin42 closed D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:33 AM
durin42 committed rHGab59cc71f80c: tests: fix bytes/str issue I introduced when adding this test.
tests: fix bytes/str issue I introduced when adding this test
Wed, Nov 14, 10:33 AM
pulkit accepted D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:20 AM
durin42 created D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:15 AM
durin42 created D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM
durin42 added a dependent revision for D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t: D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM
durin42 created D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM
spectral closed D5268: shelve: use matcher to restrict prefetch to just the modified files.
Wed, Nov 14, 8:02 AM
spectral committed rHG29e4a77b5305: shelve: use matcher to restrict prefetch to just the modified files.
shelve: use matcher to restrict prefetch to just the modified files
Wed, Nov 14, 8:02 AM
yuja added a comment to D5268: shelve: use matcher to restrict prefetch to just the modified files.

+ # Create a matcher so that prefetch doesn't attempt to fetch the entire
+ # repository pointlessly.
+ match = scmutil.matchfiles(repo, repo[node].files())

with shelvedfile(repo, name, patchextension).opener('wb') as fp:
  • cmdutil.exportfile(repo, [node], fp, opts=mdiff.diffopts(git=True)) + cmdutil.exportfile(repo, [node], fp, opts=mdiff.diffopts(git=True), + match=match)
Wed, Nov 14, 8:02 AM
indygreg closed D5267: revlog: automatically read from opened file handles.
Wed, Nov 14, 7:29 AM
indygreg closed D5266: revlog: detect incomplete revlog reads.
Wed, Nov 14, 7:29 AM
indygreg closed D5265: revlog: use single file handle when de-inlining revlog.
Wed, Nov 14, 7:29 AM
indygreg committed rHGe9293c5f8bb9: revlog: automatically read from opened file handles.
revlog: automatically read from opened file handles
Wed, Nov 14, 7:29 AM
indygreg committed rHG87a872555e90: revlog: detect incomplete revlog reads.
revlog: detect incomplete revlog reads
Wed, Nov 14, 7:29 AM
indygreg committed rHG39369475445c: revlog: use single file handle when de-inlining revlog.
revlog: use single file handle when de-inlining revlog
Wed, Nov 14, 7:29 AM
pulkit closed D5264: store: raise ProgrammingError if unable to decode a storage path.
Wed, Nov 14, 7:29 AM
pulkit committed rHG66adfd58cb77: store: raise ProgrammingError if unable to decode a storage path.
store: raise ProgrammingError if unable to decode a storage path
Wed, Nov 14, 7:29 AM
mharbison72 committed rHG7c5a922be068: tests: document a known failing interaction between narrow and lfs.
tests: document a known failing interaction between narrow and lfs
Wed, Nov 14, 7:29 AM
yuja added a comment to D5267: revlog: automatically read from opened file handles.

This looked a bit scary, but it should work so long as both reader and writer
sides do seek().

Wed, Nov 14, 7:28 AM
pulkit abandoned D5170: branchmap: pass changelog into revbranchcache.branchinfo().

I think this patch can be abandoned because of other work late in the 4.8 cycle?

Wed, Nov 14, 5:40 AM
av6 added a comment to D5064: style: run black on a subset of mercurial.

I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable.

Wed, Nov 14, 1:41 AM

Tue, Nov 13

spectral planned changes to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

(not sure when I'll get to the changes, but removing from Needs Review, sorry I delayed so long doing that)

Tue, Nov 13, 9:23 PM
spectral created D5268: shelve: use matcher to restrict prefetch to just the modified files.
Tue, Nov 13, 9:09 PM
indygreg added a comment to D5064: style: run black on a subset of mercurial.

Where do we stand on the intent to mass reformat the code base?

Tue, Nov 13, 8:20 PM
indygreg added a comment to D5170: branchmap: pass changelog into revbranchcache.branchinfo().

I think this patch can be abandoned because of other work late in the 4.8 cycle?

Tue, Nov 13, 8:15 PM
yuja committed rHGd2c997b8001f: logtoprocess: drop support for ui.log() call with invalid msg arguments (BC).
logtoprocess: drop support for ui.log() call with invalid msg arguments (BC)
Tue, Nov 13, 8:04 PM
yuja committed rHG175b590b1f51: py3: byte-stringify inline extension in test-logtoprocess.t.
py3: byte-stringify inline extension in test-logtoprocess.t
Tue, Nov 13, 8:04 PM
yuja committed rHGb2e5a554bc7b: logtoprocess: rewrite dict building in py3-compatible way.
logtoprocess: rewrite dict building in py3-compatible way
Tue, Nov 13, 8:04 PM