Page MenuHomePhabricator
Feed All Stories

Today

martinvonz updated the diff for D8168: merge: introduce a merge() for that use-case.
Wed, Feb 26, 2:17 PM
martinvonz created D8168: merge: introduce a merge() for that use-case.
Wed, Feb 26, 2:15 PM
martinvonz created D8167: merge: drop redundant mergeforce argument from hg.merge().
Wed, Feb 26, 2:14 PM
martinvonz created D8169: tests: use new, use-case-specific methods from merge module.
Wed, Feb 26, 2:14 PM
martinvonz created D8166: merge: change default of hg.merge()'s "force" argument from None to False.
Wed, Feb 26, 2:14 PM
marmoute committed rHGa6fb134bd086: revlog-compression: release note entry for update the config to be a list.
revlog-compression: release note entry for update the config to be a list
Wed, Feb 26, 1:44 PM
marmoute closed D8165: revlog-compression: release note entry for update the config to be a list.
Wed, Feb 26, 1:44 PM
marmoute created D8165: revlog-compression: release note entry for update the config to be a list.
Wed, Feb 26, 1:08 PM
Alphare created D8164: rust-nodemap: automatically use the rust index for persistent nodemap.
Wed, Feb 26, 12:37 PM
Alphare created D8163: nodemap: use data from the index in debugnodemap --dump-new.
Wed, Feb 26, 12:37 PM
Alphare created D8162: hghave: add a `rust` keyword to detect the use of compiled rust code.
Wed, Feb 26, 12:37 PM
Alphare created D8161: rust-nodemap: also clear Rust data in `clearcaches`.
Wed, Feb 26, 12:37 PM
Alphare created D8160: rust-nodemap: add binding to `nodemap_update_data`.
Wed, Feb 26, 12:37 PM
Alphare created D8159: rust-nodemap: add binding for `nodemap_data_incremental`.
Wed, Feb 26, 12:37 PM
Alphare created D8158: rust-nodemap: add binding for `nodemap_data_all`.
Wed, Feb 26, 12:36 PM
Alphare created D8157: rust-nodemap: use proper Index API instead of using the C API.
Wed, Feb 26, 12:36 PM
Alphare created D8156: rust-nodemap: add utils for propagating errors.
Wed, Feb 26, 12:36 PM
Alphare created D8155: rust-nodemap: add utils to create `Node`s from Python objects.
Wed, Feb 26, 12:36 PM
Alphare created D8152: revlog: using two new functions in C capsule from Rust code.
Wed, Feb 26, 12:36 PM
Alphare created D8154: rust-index: add `append` method to cindex/Index.
Wed, Feb 26, 12:36 PM
Alphare created D8153: rust-index: moved constructor in separate impl block.
Wed, Feb 26, 12:36 PM
gracinet committed rHGd518994384a4: rust-nodemap: a method for full invalidation.
rust-nodemap: a method for full invalidation
Wed, Feb 26, 11:52 AM
gracinet committed rHG5ac1eecc9c64: rust-nodemap: core implementation for shortest.
rust-nodemap: core implementation for shortest
Wed, Feb 26, 11:52 AM
gracinet committed rHG6329ce04c69f: rust-nodemap: accounting for dead blocks.
rust-nodemap: accounting for dead blocks
Wed, Feb 26, 11:52 AM
gracinet committed rHG8f7c6656ac79: rust-nodemap: pure Rust example.
rust-nodemap: pure Rust example
Wed, Feb 26, 11:52 AM
gracinet committed rHG00d251d32007: rust-nodemap: special case for prefixes of NULL_NODE.
rust-nodemap: special case for prefixes of NULL_NODE
Wed, Feb 26, 11:52 AM
gracinet committed rHGa98ba6983a63: rust-nodemap: input/output primitives.
rust-nodemap: input/output primitives
Wed, Feb 26, 11:52 AM
martinvonz committed rHG6689cebacb32: pyoxidizer: allow extensions to be loaded from the file system.
pyoxidizer: allow extensions to be loaded from the file system
Wed, Feb 26, 11:52 AM
valentin.gatienbaron committed rHG218feb1a7e00: graft: always allow hg graft --base . (issue6248).
graft: always allow hg graft --base . (issue6248)
Wed, Feb 26, 11:52 AM
marmoute committed rHGf0027a3dd7cb: revlog-compression: update the config to be a list.
revlog-compression: update the config to be a list
Wed, Feb 26, 11:52 AM
pulkit committed rHG454bc51f114c: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).
remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269)
Wed, Feb 26, 11:52 AM
valentin.gatienbaron created D8151: relnotes: move entry to the right spot.
Wed, Feb 26, 10:57 AM
gracinet committed rHG706c1bd7f71c: rust-nodemap: accounting for dead blocks.
rust-nodemap: accounting for dead blocks
Wed, Feb 26, 10:34 AM
marmoute closed D8148: revlog-compression: update the config to be a list.
Wed, Feb 26, 10:34 AM
gracinet committed rHGbbc61f36733c: rust-nodemap: a method for full invalidation.
rust-nodemap: a method for full invalidation
Wed, Feb 26, 10:34 AM
gracinet closed D7819: rust-nodemap: core implementation for shortest.
Wed, Feb 26, 10:34 AM
gracinet closed D8097: rust-nodemap: accounting for dead blocks.
Wed, Feb 26, 10:34 AM
gracinet closed D8098: rust-nodemap: a method for full invalidation.
Wed, Feb 26, 10:34 AM
gracinet closed D7797: rust-nodemap: pure Rust example.
Wed, Feb 26, 10:33 AM
gracinet committed rHG0e8a9c0fbc8c: rust-nodemap: core implementation for shortest.
rust-nodemap: core implementation for shortest
Wed, Feb 26, 10:33 AM
gracinet closed D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Wed, Feb 26, 10:33 AM
gracinet committed rHG895934342631: rust-nodemap: special case for prefixes of NULL_NODE.
rust-nodemap: special case for prefixes of NULL_NODE
Wed, Feb 26, 10:33 AM
valentin.gatienbaron closed D8127: graft: always allow hg graft --base . (issue6248).
Wed, Feb 26, 10:33 AM
gracinet committed rHG57d5b0fb9740: rust-nodemap: pure Rust example.
rust-nodemap: pure Rust example
Wed, Feb 26, 10:33 AM
gracinet closed D7796: rust-nodemap: input/output primitives.
Wed, Feb 26, 10:33 AM
gracinet committed rHGc3cc881aaa17: rust-nodemap: input/output primitives.
rust-nodemap: input/output primitives
Wed, Feb 26, 10:32 AM
martinvonz closed D8122: pyoxidizer: allow extensions to be loaded from the file system.
Wed, Feb 26, 10:32 AM
martinvonz committed rHG4e3dbb48ef76: pyoxidizer: allow extensions to be loaded from the file system.
pyoxidizer: allow extensions to be loaded from the file system
Wed, Feb 26, 10:32 AM
valentin.gatienbaron committed rHG2e534a710b15: graft: always allow hg graft --base . (issue6248).
graft: always allow hg graft --base . (issue6248)
Wed, Feb 26, 10:32 AM
marmoute committed rHG54b9238c27be: revlog-compression: update the config to be a list.
revlog-compression: update the config to be a list
Wed, Feb 26, 10:32 AM
pulkit committed rHG3cd79f55c1d7: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).
remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269)
Wed, Feb 26, 10:32 AM
pulkit closed D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).
Wed, Feb 26, 10:32 AM
mharbison72 closed D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Wed, Feb 26, 5:51 AM
martinvonz committed rHGdda2341d6664: drawdag: abide by new createmarkers() API.
drawdag: abide by new createmarkers() API
Wed, Feb 26, 5:51 AM
martinvonz closed D8149: drawdag: abide by new createmarkers() API.
Wed, Feb 26, 5:51 AM
mharbison72 committed rHGca82929e433d: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
lfutil: provide a hint if the largefiles/lfs cache path cannot be determined
Wed, Feb 26, 5:51 AM
pulkit accepted D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Wed, Feb 26, 4:38 AM
D8149: drawdag: abide by new createmarkers() API is now accepted and ready to land.
Wed, Feb 26, 4:37 AM
pulkit added a comment to D8148: revlog-compression: update the config to be a list.

Looks good to me, can you add an entry to relnotes/next?

Wed, Feb 26, 4:31 AM

Yesterday

mharbison72 added a comment to D8148: revlog-compression: update the config to be a list.

LGTM, thanks for the update.

Tue, Feb 25, 6:58 PM
martinvonz added a comment to D8115: rebase: show bug when rebasing merge with obsoleted revs on both sides.

We already have tests for this (grepping for "unwanted changes" in tests/ should be enough to find them).

Tue, Feb 25, 6:30 PM
marmoute updated the diff for D8148: revlog-compression: update the config to be a list.
Tue, Feb 25, 6:19 PM
sfink added a comment to D8150: histedit: py3 fixes for curses mode.

Maybe this should be in the patch comment, but justification for the change:

Tue, Feb 25, 4:37 PM
sfink created D8150: histedit: py3 fixes for curses mode.
Tue, Feb 25, 4:32 PM
martinvonz created D8149: drawdag: abide by new createmarkers() API.
Tue, Feb 25, 3:53 PM
durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Tue, Feb 25, 1:52 PM
D8148: revlog-compression: update the config to be a list now requires changes to proceed.
Tue, Feb 25, 12:45 PM
mharbison72 closed D8142: setup: exclude the __index__ module from itself when generating.
Tue, Feb 25, 10:10 AM
mharbison72 committed rHGbb58931d0c4f: setup: exclude the __index__ module from itself when generating.
setup: exclude the __index__ module from itself when generating
Tue, Feb 25, 10:09 AM
mharbison72 closed D8144: tests: stabilize test-amend.t on Windows.
Tue, Feb 25, 10:09 AM
mharbison72 committed rHG1813f79017ac: tests: stabilize test-amend.t on Windows.
tests: stabilize test-amend.t on Windows
Tue, Feb 25, 10:09 AM
mharbison72 closed D8147: tests: replace truncate(1) with inline python.
Tue, Feb 25, 9:53 AM
mharbison72 committed rHG56f089e40c5a: tests: replace truncate(1) with inline python.
tests: replace truncate(1) with inline python
Tue, Feb 25, 9:53 AM
mharbison72 closed D8146: tests: stabilize test-rename-merge2.t on Windows.
Tue, Feb 25, 9:53 AM
mharbison72 committed rHG35d2afc6966a: tests: stabilize test-rename-merge2.t on Windows.
tests: stabilize test-rename-merge2.t on Windows
Tue, Feb 25, 9:53 AM
mharbison72 updated the diff for D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Tue, Feb 25, 9:37 AM
pulkit added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

test-check-code.t says hi:

Tue, Feb 25, 7:49 AM
D8147: tests: replace truncate(1) with inline python is now accepted and ready to land.
Tue, Feb 25, 7:23 AM
D8146: tests: stabilize test-rename-merge2.t on Windows is now accepted and ready to land.
Tue, Feb 25, 7:23 AM
D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined is now accepted and ready to land.
Tue, Feb 25, 7:19 AM
D8144: tests: stabilize test-amend.t on Windows is now accepted and ready to land.
Tue, Feb 25, 6:17 AM
D8142: setup: exclude the __index__ module from itself when generating is now accepted and ready to land.
Tue, Feb 25, 6:16 AM
pulkit added a comment to D8148: revlog-compression: update the config to be a list.

Looks good to me, can you add an entry to relnotes/next?

Tue, Feb 25, 6:12 AM
marmoute created D8148: revlog-compression: update the config to be a list.
Tue, Feb 25, 5:15 AM
marmoute added a comment to D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).

I just mean to use changelog=changelog in the super call... but this actually looks more robust.

Tue, Feb 25, 4:52 AM
marmoute accepted D8144: tests: stabilize test-amend.t on Windows.
Tue, Feb 25, 4:49 AM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Thanks for adding the test.

Tue, Feb 25, 3:46 AM
Alphare retitled D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276) from rust-cpython: make `NonNormalEntires` iterable to fix bug with `fsmonitor` to rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276).
Tue, Feb 25, 3:18 AM
martinvonz added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Perhaps the line doesn't actually happen before that commit? You can try removing the (?) in the commit before my commit and see if that line is actually printed. I'm thinking that that commit pushed the number of files to close above some threshold that made it get printed. In that case, it was probably some of my earlier commits that made it no longer get printed and we just didn't notice since (?) means optional (no error if it doesn't get printed).

I can confirm that it was required in e1ecfc7c84be, and reconfirmed that it is needed in the latest code by removing the line from both. I'm not too worried about why it popped up- it just seemed odd that it didn't with the earlier followup patch I added to fix similar conditionalizing of this exact text elsewhere, and the commit where it started failing looked innocuous.

Tue, Feb 25, 1:05 AM
mharbison72 added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Perhaps the line doesn't actually happen before that commit? You can try removing the (?) in the commit before my commit and see if that line is actually printed. I'm thinking that that commit pushed the number of files to close above some threshold that made it get printed. In that case, it was probably some of my earlier commits that made it no longer get printed and we just didn't notice since (?) means optional (no error if it doesn't get printed).

Tue, Feb 25, 1:01 AM
martinvonz added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Tue, Feb 25, 12:21 AM

Mon, Feb 24

mharbison72 updated the summary of D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Mon, Feb 24, 8:20 PM
marmoute added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since run-test has no idea where to put (?) line with the surounding change, they often end up preserved at start/end of the changeset section. This is probably just something like that.

Mon, Feb 24, 7:14 PM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

The reason I didn't add a test (or see any changes to existing ones) is because the config property is baked into the config file generated by run-tests.py, so it never hits this path. But I did test by hand on Windows.

Mon, Feb 24, 7:07 PM
mharbison72 updated subscribers of D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Mon, Feb 24, 6:55 PM
mharbison72 added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

Mon, Feb 24, 6:52 PM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

Mon, Feb 24, 6:37 PM
marmoute added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Mon, Feb 24, 6:37 PM
marmoute added a comment to D8147: tests: replace truncate(1) with inline python.

sure

Mon, Feb 24, 6:36 PM
marmoute added a comment to D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276).

You need to add (issue6276) in your changeset summary so that the ticket get closed when you land this.

Mon, Feb 24, 6:35 PM