Page MenuHomePhabricator
Feed All Stories

Today

martinvonz added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.

Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.

In this case, I could use the Differential revision (D8724) to refer to the other patch. Would that also make sense? (I wonder why you didn’t mention this possibility — is it because the repository should be self-contained?)

Fri, Jul 10, 1:19 PM
mjacob added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.

Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.

Fri, Jul 10, 1:15 PM
martinvonz added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.

Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.

Fri, Jul 10, 11:18 AM
martinvonz added a comment to D8721: scmutil: allowing different files to be prefetched per revision.

Should we have an entry in the release notes about this or have we given up on documenting API changes? I'm fine with either, as long as we have some policy.

Fri, Jul 10, 10:53 AM
joerg.sonnenberger updated the diff for D8575: hooklib: fix detection of successors for changeset_obsoleted.
Fri, Jul 10, 7:51 AM
mjacob committed rHG194ade3477c6: tests: make names in test-stdio.py more distinctive.
tests: make names in test-stdio.py more distinctive
Fri, Jul 10, 7:30 AM
mjacob committed rHG65b0784dea6c: tests: terminate subprocess in test-stdio.py in case of exception.
tests: terminate subprocess in test-stdio.py in case of exception
Fri, Jul 10, 7:30 AM
mjacob committed rHG4d2b6cfa08e7: tests: proof test-stdio.py against buffer fill-up.
tests: proof test-stdio.py against buffer fill-up
Fri, Jul 10, 7:30 AM
mjacob created D8724: commit: check branch change on to-be-committed changeset.
Fri, Jul 10, 6:50 AM
mjacob created D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
Fri, Jul 10, 6:50 AM
rdamazio closed D8721: scmutil: allowing different files to be prefetched per revision.
Fri, Jul 10, 6:48 AM
rdamazio closed D8723: fix: prefetch file contents.
Fri, Jul 10, 6:48 AM
rdamazio committed rHG263cf0f60b70: fix: prefetch file contents.
fix: prefetch file contents
Fri, Jul 10, 6:47 AM
rdamazio closed D8722: fix: obtain base paths before starting workers.
Fri, Jul 10, 6:47 AM
marmoute closed D8701: commitctx: reorder some conditional for efficiency in _filecommit.
Fri, Jul 10, 6:47 AM
rdamazio committed rHGf204ba74004b: fix: obtain base paths before starting workers.
fix: obtain base paths before starting workers
Fri, Jul 10, 6:47 AM
marmoute closed D8705: commitctx: document the manifest writing function.
Fri, Jul 10, 6:47 AM
mharbison72 committed rHG8c06f479cfc1: tests: stablize test-serve.t on Windows.
tests: stablize test-serve.t on Windows
Fri, Jul 10, 6:47 AM
mharbison72 closed D8720: tests: stablize test-serve.t on Windows.
Fri, Jul 10, 6:47 AM
marmoute committed rHG3c2b4f08d79e: commitctx: document the manifest writing function.
commitctx: document the manifest writing function
Fri, Jul 10, 6:47 AM
marmoute committed rHGd4db0230e568: commitctx: reorder some conditional for efficiency in _filecommit.
commitctx: reorder some conditional for efficiency in _filecommit
Fri, Jul 10, 6:47 AM
joerg.sonnenberger closed D8644: util: provide a helper function to estimate RAM size.
Fri, Jul 10, 6:47 AM
marmoute closed D8699: commitctx: document _filecommit input and output.
Fri, Jul 10, 6:47 AM
marmoute committed rHG74c590085697: commitctx: document _filecommit input and output.
commitctx: document _filecommit input and output
Fri, Jul 10, 6:47 AM
joerg.sonnenberger closed D8645: clonebundles: optional memory-requirement attribution.
Fri, Jul 10, 6:46 AM
joerg.sonnenberger committed rHG31f111d4bf61: phases: replace magic number by constant.
phases: replace magic number by constant
Fri, Jul 10, 6:46 AM
joerg.sonnenberger closed D8695: phases: replace magic number by constant.
Fri, Jul 10, 6:46 AM
joerg.sonnenberger committed rHG9c7ff8877592: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
Fri, Jul 10, 6:45 AM
marmoute closed D8711: documentation: add some internals documentation about bid merge.
Fri, Jul 10, 6:45 AM
joerg.sonnenberger committed rHGcfe0f4915793: util: provide a helper function to estimate RAM size.
util: provide a helper function to estimate RAM size
Fri, Jul 10, 6:45 AM
joerg.sonnenberger closed D8676: tests: allow timing difference in output.
Fri, Jul 10, 6:45 AM
joerg.sonnenberger committed rHG3990a56491fd: tests: allow timing difference in output.
tests: allow timing difference in output
Fri, Jul 10, 6:45 AM
marmoute committed rHG6c22f3ab2fcb: documentation: add some internals documentation about bid merge.
documentation: add some internals documentation about bid merge
Fri, Jul 10, 6:45 AM
rdamazio committed rHG2fac78d5ae87: scmutil: allowing different files to be prefetched per revision.
scmutil: allowing different files to be prefetched per revision
Fri, Jul 10, 6:45 AM
D8723: fix: prefetch file contents is now accepted and ready to land.
Fri, Jul 10, 6:16 AM
D8722: fix: obtain base paths before starting workers is now accepted and ready to land.
Fri, Jul 10, 6:15 AM
D8720: tests: stablize test-serve.t on Windows is now accepted and ready to land.
Fri, Jul 10, 6:08 AM
D8645: clonebundles: optional memory-requirement attribution is now accepted and ready to land.
Fri, Jul 10, 6:03 AM
D8644: util: provide a helper function to estimate RAM size is now accepted and ready to land.
Fri, Jul 10, 6:02 AM
D8676: tests: allow timing difference in output is now accepted and ready to land.
Fri, Jul 10, 6:00 AM
pulkit added inline comments to D8575: hooklib: fix detection of successors for changeset_obsoleted.
Fri, Jul 10, 5:59 AM
D8711: documentation: add some internals documentation about bid merge is now accepted and ready to land.
Fri, Jul 10, 5:58 AM
D8721: scmutil: allowing different files to be prefetched per revision is now accepted and ready to land.
Fri, Jul 10, 5:56 AM
pulkit added a comment to D8631: scmutil: add writereporequirements() and route requires writing through it.

Gentle ping for review.

Fri, Jul 10, 4:30 AM
rdamazio created D8721: scmutil: allowing different files to be prefetched per revision.
Fri, Jul 10, 2:47 AM
rdamazio created D8723: fix: prefetch file contents.
Fri, Jul 10, 2:45 AM
rdamazio created D8722: fix: obtain base paths before starting workers.
Fri, Jul 10, 2:45 AM

Yesterday

mharbison72 created D8720: tests: stablize test-serve.t on Windows.
Thu, Jul 9, 11:13 PM
pulkit created D8719: mergestate: document mergestate records in an organized way.
Thu, Jul 9, 8:37 AM
pulkit created D8718: mergestate: remove unused unsupported related mergestate records.
Thu, Jul 9, 8:37 AM
pulkit created D8717: mergestate: add comments about couple of record types and minor reorder.
Thu, Jul 9, 8:37 AM
pulkit created D8716: mergestate: remove unrequired RECORD_RESOLVED_OTHER record.
Thu, Jul 9, 8:37 AM
pulkit created D8715: mergestate: rename addpath() -> addpathonflict() to prevent confusion.
Thu, Jul 9, 8:37 AM
pulkit added inline comments to D8709: commitctx: extract the function in a dedicated module.
Thu, Jul 9, 4:42 AM
D8708: commitctx: move a tiny else clause above the very long one is now accepted and ready to land.
Thu, Jul 9, 4:40 AM
D8707: commitctx: consider removed as touched is now accepted and ready to land.
Thu, Jul 9, 4:38 AM
D8706: commitctx: rename "changed" to touched is now accepted and ready to land.
Thu, Jul 9, 4:37 AM
D8705: commitctx: document the manifest writing function is now accepted and ready to land.
Thu, Jul 9, 4:36 AM
D8701: commitctx: reorder some conditional for efficiency in _filecommit is now accepted and ready to land.
Thu, Jul 9, 4:32 AM
pulkit added inline comments to D8700: commitctx: document a fast path in _filecommit.
Thu, Jul 9, 4:32 AM
D8699: commitctx: document _filecommit input and output is now accepted and ready to land.
Thu, Jul 9, 4:29 AM
pulkit added inline comments to D8699: commitctx: document _filecommit input and output.
Thu, Jul 9, 4:28 AM
D8695: phases: replace magic number by constant is now accepted and ready to land.
Thu, Jul 9, 4:12 AM

Wed, Jul 8

durin42 added a comment to D8712: black: format some files in preparation for subsequent changes.

Yeah, if you’re seeing these changes I’m pretty sure you have a too-old black...

Wed, Jul 8, 10:25 PM
mjacob added a comment to D8714: state: support validated declaration of nested unfinished ops.

Can you give an example of an extension that would benefit from this? It’s not immediately obvious to me, and ideally patches should be written such that it’s obvious for most people. :)

Wed, Jul 8, 8:28 PM
mjacob added a comment to D8713: error: normalize "unresolved conflicts" error messages with a custom class.

Can you separate the change from "unresolved conflicts (see hg resolve, then hg rebase --continue)" to "unresolved conflicts (see 'hg resolve', then 'hg rebase --continue')", to make the diff less noisy?

Wed, Jul 8, 8:20 PM
D8712: black: format some files in preparation for subsequent changes now requires changes to proceed.

Our sources should already be formatted. E.g. if I run black --config=black.toml hgext/rebase.py, it doesn’t change anything. The tests would catch if a file should be reformatted.

Wed, Jul 8, 8:08 PM
dploch created D8713: error: normalize "unresolved conflicts" error messages with a custom class.
Wed, Jul 8, 6:55 PM
dploch created D8712: black: format some files in preparation for subsequent changes.
Wed, Jul 8, 6:51 PM
dploch created D8714: state: support validated declaration of nested unfinished ops.
Wed, Jul 8, 6:50 PM
marmoute updated subscribers of D8653: copies: handle more cases where a file got replaced by a copy.
Wed, Jul 8, 2:50 PM
martinvonz added inline comments to D8653: copies: handle more cases where a file got replaced by a copy.
Wed, Jul 8, 2:01 PM
yuja committed rHGf43bc4ce0d69: cmdserver: document message-encodings and channel output options.
cmdserver: document message-encodings and channel output options
Wed, Jul 8, 12:28 PM
yuja committed rHGd6e99a446eea: cmdserver: add option to not exit from message loop on SIGINT.
cmdserver: add option to not exit from message loop on SIGINT
Wed, Jul 8, 12:28 PM
graemenail updated graemenail.
Wed, Jul 8, 9:22 AM
mjacob committed rHG2c0043977b6d: archival: abort if compression method is unavailable.
archival: abort if compression method is unavailable
Wed, Jul 8, 7:26 AM
mjacob committed rHG40120de810ba: demandimport: ignore `lzma` module for demandimport.
demandimport: ignore `lzma` module for demandimport
Wed, Jul 8, 7:26 AM
mjacob committed rHG9694895749ad: pycompat: remove pycompat.{stdin,stdout,stderr}.
pycompat: remove pycompat.{stdin,stdout,stderr}
Wed, Jul 8, 7:04 AM
mjacob committed rHG4c1b4805db57: pycompat: change users of pycompat.{stdin,stdout,stderr} to use procutil.std*.
pycompat: change users of pycompat.{stdin,stdout,stderr} to use procutil.std*
Wed, Jul 8, 7:04 AM
marmoute created D8711: documentation: add some internals documentation about bid merge.
Wed, Jul 8, 5:53 AM
graemenail added a comment to D8691: hg: allow usage of XDG_CONFIG_HOME/hg/hgrc on OSX.

! In D8691#129814, @durin42 wrote:
Yes and no: setting HGRCPATH means you won't pick up any system-wide configs (eg in /etc/mercurial/hgrc.d/), so it's not really a great option for institutional users. I guess I'd be "+0" on a change to core that would look in the relevant Library/Preferences places for config files: I'll review it, but I'm not excited about it.

Wed, Jul 8, 5:08 AM
marmoute created D8710: commitctx: extract _filecommit too.
Wed, Jul 8, 4:39 AM
marmoute created D8709: commitctx: extract the function in a dedicated module.
Wed, Jul 8, 4:38 AM
marmoute created D8708: commitctx: move a tiny else clause above the very long one.
Wed, Jul 8, 4:38 AM
marmoute created D8707: commitctx: consider removed as touched.
Wed, Jul 8, 4:38 AM
marmoute created D8706: commitctx: rename "changed" to touched.
Wed, Jul 8, 4:38 AM
marmoute created D8702: commitctx: return "touched" status from _filecommit.
Wed, Jul 8, 4:37 AM
marmoute created D8704: commitctx: more filesremoved assignment closer to removed computation.
Wed, Jul 8, 4:37 AM
marmoute created D8705: commitctx: document the manifest writing function.
Wed, Jul 8, 4:37 AM
marmoute created D8703: commitctx: compute files added from _filecommit returns.
Wed, Jul 8, 4:37 AM
marmoute created D8701: commitctx: reorder some conditional for efficiency in _filecommit.
Wed, Jul 8, 4:37 AM
marmoute created D8700: commitctx: document a fast path in _filecommit.
Wed, Jul 8, 4:37 AM
marmoute created D8699: commitctx: document _filecommit input and output.
Wed, Jul 8, 4:37 AM

Tue, Jul 7

joerg.sonnenberger created D8697: phases: sparsify phase lists.
Tue, Jul 7, 6:39 PM
joerg.sonnenberger created D8698: phases: sparsify phaseroots and phasesets.
Tue, Jul 7, 6:39 PM
joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

Superseded by D8694, D8695, D8697 and D8698.

Tue, Jul 7, 6:39 PM
joerg.sonnenberger created D8696: phases: updatephases should not skip internal phase.
Tue, Jul 7, 6:38 PM
joerg.sonnenberger created D8695: phases: replace magic number by constant.
Tue, Jul 7, 6:38 PM
joerg.sonnenberger created D8694: phases: provide a test and accessor for non-public phase roots.
Tue, Jul 7, 6:38 PM
durin42 added a comment to D8691: hg: allow usage of XDG_CONFIG_HOME/hg/hgrc on OSX.

Thanks for the prompt review.

(If anything, ~/Library/Preferences/org.mercurial-scm.hgrc might make sense, but that seems silly to me.)

I agree that ~/Library/Preferences would be the default XDG analogy in macOS. However, the patch was more motivated by relocating the configuration file.
Am I to understand that setting HGRCPATH is the preferred approach for relocating hgrc on macOS?

Tue, Jul 7, 5:39 PM