Page MenuHomePhabricator
Feed All Stories

Thu, Sep 19

martinvonz committed rHG9668744c9122: wireprototypes: clarify documentation of getbundle argument types.
wireprototypes: clarify documentation of getbundle argument types
Thu, Sep 19, 7:57 AM
martinvonz closed D6871: wireprototypes: clarify documentation of getbundle argument types.
Thu, Sep 19, 7:57 AM
D6871: wireprototypes: clarify documentation of getbundle argument types is now accepted and ready to land.
Thu, Sep 19, 7:20 AM
marmoute accepted D6871: wireprototypes: clarify documentation of getbundle argument types.
Thu, Sep 19, 3:47 AM

Wed, Sep 18

yuja committed rHG2c14bf83b58b: merge with stable.
merge with stable
Wed, Sep 18, 7:02 PM
av6 committed rHG085295f82845: merge: respect parents order when using `graft` on a merge, this time for real.
merge: respect parents order when using `graft` on a merge, this time for real
Wed, Sep 18, 6:52 PM
martinvonz created D6871: wireprototypes: clarify documentation of getbundle argument types.
Wed, Sep 18, 4:58 PM
martinvonz committed rHG44be33cf7a57: py3: don't double-convert "opts" to bytes.
py3: don't double-convert "opts" to bytes
Wed, Sep 18, 9:24 AM
martinvonz closed D6864: py3: don't double-convert "opts" to bytes.
Wed, Sep 18, 9:24 AM
D6864: py3: don't double-convert "opts" to bytes is now accepted and ready to land.
Wed, Sep 18, 7:48 AM
joerg.sonnenberger added a comment to D6267: incoming: detect if server send partial replies.

Will be implemented properly.

Wed, Sep 18, 2:59 AM
Kwan closed D6863: py3: byte-prefix sanitisation regexes in phabricator.py.
Wed, Sep 18, 12:52 AM
Kwan committed rHG04c6de38734d: py3: byte-prefix sanitisation regexes in phabricator.py.
py3: byte-prefix sanitisation regexes in phabricator.py
Wed, Sep 18, 12:52 AM
joerg.sonnenberger created D6870: tests: recognize DNS timeouts as well.
Wed, Sep 18, 12:41 AM
Kwan closed D6869: py3: pass a bytestring into querydrev instead of a string that'll TypeError.
Wed, Sep 18, 12:08 AM
Kwan committed rHG6fb281f39c25: py3: pass a bytestring into querydrev instead of a string that'll TypeError.
py3: pass a bytestring into querydrev instead of a string that'll TypeError
Wed, Sep 18, 12:08 AM
Kwan closed D6868: py3: add test demonstrating TypeError when phabsending skips unchanged commits.
Wed, Sep 18, 12:08 AM
Kwan committed rHG3355e0c2845f: py3: add test demonstrating TypeError when phabsending skips unchanged commits.
py3: add test demonstrating TypeError when phabsending skips unchanged commits
Wed, Sep 18, 12:08 AM

Tue, Sep 17

Kwan created D6869: py3: pass a bytestring into querydrev instead of a string that'll TypeError.

For stable

Tue, Sep 17, 7:23 PM
Kwan created D6868: py3: add test demonstrating TypeError when phabsending skips unchanged commits.

For stable

Tue, Sep 17, 7:23 PM
spectral created D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error.
Tue, Sep 17, 6:58 PM
spectral created D6866: osutil: tolerate Py_GetArgcArgv not being set up properly.
Tue, Sep 17, 6:58 PM
spectral created D6865: osutil: allow disabling setprocname via a define passed to the compiler.
Tue, Sep 17, 6:58 PM
martinvonz created D6864: py3: don't double-convert "opts" to bytes.
Tue, Sep 17, 6:38 PM
Kwan created D6863: py3: byte-prefix sanitisation regexes in phabricator.py.
Tue, Sep 17, 4:11 PM
martinvonz closed D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 3:58 PM
durin42 closed D6862: tests: clean up built binaries after running test-fuzz-targets.t.
Tue, Sep 17, 3:58 PM
durin42 closed D6861: fastannotate: remove support for flock() locking.
Tue, Sep 17, 3:58 PM
durin42 committed rHG39cab871e880: tests: clean up built binaries after running test-fuzz-targets.t.
tests: clean up built binaries after running test-fuzz-targets.t
Tue, Sep 17, 3:58 PM
durin42 committed rHG0152a907f714: fastannotate: remove support for flock() locking.
fastannotate: remove support for flock() locking
Tue, Sep 17, 3:57 PM
durin42 committed rHG5316f9ff3e48: remotefilelog: remove dead code for using flock() for locking.
remotefilelog: remove dead code for using flock() for locking
Tue, Sep 17, 3:57 PM
durin42 closed D6860: remotefilelog: remove dead code for using flock() for locking.
Tue, Sep 17, 3:57 PM
martinvonz committed rHG40f78072fda9: narrow: add option for automatically removing unused includes.
narrow: add option for automatically removing unused includes
Tue, Sep 17, 3:57 PM
martinvonz closed D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
Tue, Sep 17, 3:57 PM
martinvonz committed rHGc2676b5a9f59: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
narrow: don't hexify paths and double-hexify known nodes on wire (BC)
Tue, Sep 17, 3:57 PM
D6862: tests: clean up built binaries after running test-fuzz-targets.t is now accepted and ready to land.
Tue, Sep 17, 3:34 PM
D6861: fastannotate: remove support for flock() locking is now accepted and ready to land.
Tue, Sep 17, 3:34 PM
D6860: remotefilelog: remove dead code for using flock() for locking is now accepted and ready to land.
Tue, Sep 17, 3:33 PM
D6848: narrow: add option for automatically removing unused includes is now accepted and ready to land.
Tue, Sep 17, 3:33 PM
durin42 created D6862: tests: clean up built binaries after running test-fuzz-targets.t.
Tue, Sep 17, 3:10 PM
durin42 created D6861: fastannotate: remove support for flock() locking.
Tue, Sep 17, 2:27 PM
durin42 created D6860: remotefilelog: remove dead code for using flock() for locking.
Tue, Sep 17, 2:27 PM
lothiraldan closed D6844: remotefilelog: replace repack lock to solve race condition.
Tue, Sep 17, 2:20 PM
lothiraldan committed rHG5fadf6103790: remotefilelog: replace repack lock to solve race condition.
remotefilelog: replace repack lock to solve race condition
Tue, Sep 17, 2:19 PM
marmoute committed rHGadac17faa72e: perf: add a --stats argument to perfhelper-pathcopies.
perf: add a --stats argument to perfhelper-pathcopies
Tue, Sep 17, 2:19 PM
marmoute committed rHG3a1ad3aeb64a: perf: add a --stats argument to perfhelper-mergecopies.
perf: add a --stats argument to perfhelper-mergecopies
Tue, Sep 17, 2:19 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:19 PM
martinvonz updated the diff for D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:19 PM
D6816: flagprocessors: writetransform function take side data as parameter (API) is now accepted and ready to land.
Tue, Sep 17, 2:14 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:14 PM
D6815: flagprocessors: add a `sidedata` parameters to _processflagswrite is now accepted and ready to land.
Tue, Sep 17, 2:14 PM
D6814: revlog: add a `sidedata` parameters to addrevision now requires changes to proceed.
Tue, Sep 17, 2:14 PM
D6813: flagprocessors: have the read transform function return side data (API) is now accepted and ready to land.
Tue, Sep 17, 2:13 PM
D6812: flagprocessors: return flagdata in the main processing function is now accepted and ready to land.
Tue, Sep 17, 2:11 PM
D6811: flagprocessors: return sidedata map in `_processflagsread` is now accepted and ready to land.
Tue, Sep 17, 2:10 PM
D6810: revlog: use the new sidedata map return in the sidedata method is now accepted and ready to land.
Tue, Sep 17, 2:10 PM
D6809: revlog: return sidedata map from `_revisiondata` is now accepted and ready to land.
Tue, Sep 17, 2:08 PM
D6808: revlog: introduce a `sidedata` method is now accepted and ready to land.
Tue, Sep 17, 2:05 PM
martinvonz updated the summary of D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:58 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:58 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:50 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:45 PM
D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC) is now accepted and ready to land.

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Sounds like a good idea!

If it's just tracked --add-include then it's not a big deal, it won't disrupt regular flow.
If backward compatibility doesn't complicate the code - great, if not - don't worry about it.

Tue, Sep 17, 1:45 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:44 PM
markand committed rHGc04e0836f039: archive: add XZ support if built with Python 3.
archive: add XZ support if built with Python 3
Tue, Sep 17, 1:18 PM
markand committed rHG56c207b9fbbe: archive: add XZ support if built with Python 3.
archive: add XZ support if built with Python 3
Tue, Sep 17, 10:11 AM
pulkit added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#100698, @av6 wrote:

And to make the review process easier, I propose doing this in 3 or 4 patches:

  • adding --registered: will simply show all registered options in key=value format
  • adding defaults and experimental/devel/debug statuses to showconfig --debug output (this one can be split into two)
  • showing config options in a human-friendly format
Tue, Sep 17, 7:54 AM
marmoute added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#100698, @av6 wrote:
In D6709#99199, @av6 wrote:

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

I disagree that the primary use is script only. As a suer I have wanted this for a long time and I am happy to finally have a way to get this data without grepping the source.

Oh, now I see what you wanted from this patch. But you want it as a developer who works with and on hg, not just as a user (hopefully regular users don't have to grep the source). This distinction makes things easier to design, because we now have simply two (plus one) cases:

Tue, Sep 17, 5:10 AM
Alphare added a comment to D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC).

It is indeed Sync because the py_class! macro forces us to have a reference to the GIL at the type level to access the data attributes, but I would also like to be extra sure and have someone else confirm it.

Tue, Sep 17, 5:04 AM
av6 added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#99199, @av6 wrote:

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

I disagree that the primary use is script only. As a suer I have wanted this for a long time and I am happy to finally have a way to get this data without grepping the source.

Tue, Sep 17, 4:58 AM

Mon, Sep 16

yuja created D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC).
Mon, Sep 16, 7:27 PM
martinvonz added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Sounds like a good idea!

If it's just tracked --add-include then it's not a big deal, it won't disrupt regular flow.
If backward compatibility doesn't complicate the code - great, if not - don't worry about it.

Mon, Sep 16, 2:14 PM
idlsoft added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Sounds like a good idea!

Mon, Sep 16, 2:03 PM
mharbison72 closed D6852: tests: stabilize test-fix.t on Windows.
Mon, Sep 16, 1:56 PM
mharbison72 committed rHGa2dffe68b4ea: tests: stabilize test-fix.t on Windows.
tests: stabilize test-fix.t on Windows
Mon, Sep 16, 1:56 PM
indygreg committed rHG69de49c4e39c: zstandard: vendor python-zstandard 0.12.
zstandard: vendor python-zstandard 0.12
Mon, Sep 16, 1:56 PM
yuja committed rHG06080afd0565: rust-cpython: add sanity check to PySharedState::decrease_leak_count().
rust-cpython: add sanity check to PySharedState::decrease_leak_count()
Mon, Sep 16, 1:56 PM
indygreg closed D6858: zstandard: vendor python-zstandard 0.12.
Mon, Sep 16, 1:56 PM
mharbison72 closed D6854: amend: prevent '\n' in the note string.
Mon, Sep 16, 1:56 PM
mharbison72 closed D6853: amend: add option to update to the current user.
Mon, Sep 16, 1:56 PM
mharbison72 closed D6857: uncommit: enable support for adding a note.
Mon, Sep 16, 1:56 PM
mharbison72 committed rHG2da754532dd3: uncommit: enable support for adding a note.
uncommit: enable support for adding a note
Mon, Sep 16, 1:56 PM
mharbison72 closed D6856: amend: enable support for using the secret phase.
Mon, Sep 16, 1:56 PM
mharbison72 committed rHGf10a0f5eedae: amend: enable support for using the secret phase.
amend: enable support for using the secret phase
Mon, Sep 16, 1:55 PM
mharbison72 closed D6855: amend: enable support for closing the branch.
Mon, Sep 16, 1:55 PM
mharbison72 committed rHG09d46b90f6f9: amend: enable support for closing the branch.
amend: enable support for closing the branch
Mon, Sep 16, 1:55 PM
mharbison72 committed rHG7e9997041781: amend: prevent '\n' in the note string.
amend: prevent '\n' in the note string
Mon, Sep 16, 1:55 PM
mharbison72 committed rHGe4803231f538: amend: add option to update to the current user.
amend: add option to update to the current user
Mon, Sep 16, 1:55 PM
pulkit added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

@idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and client at the same time?

I did that a little while ago to move to 5.0. It was not fun. It's server, teamcity, clients, docker images.
What operations does this affect? Regular push/pull/clone or only tracked --add-include?

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Mon, Sep 16, 1:47 PM
martinvonz added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

@idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and client at the same time?

I did that a little while ago to move to 5.0. It was not fun. It's server, teamcity, clients, docker images.
What operations does this affect? Regular push/pull/clone or only tracked --add-include?

Mon, Sep 16, 1:39 PM
idlsoft added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

@idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and client at the same time?

Mon, Sep 16, 1:31 PM
D6852: tests: stabilize test-fix.t on Windows is now accepted and ready to land.
Mon, Sep 16, 1:11 PM
D6858: zstandard: vendor python-zstandard 0.12 is now accepted and ready to land.
Mon, Sep 16, 1:09 PM
pulkit updated subscribers of D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

This is clearly a breaking change, but the feature is experimental and
we're not aware of anyone running a server using this command yet.

Mon, Sep 16, 1:05 PM
D6857: uncommit: enable support for adding a note is now accepted and ready to land.

Should these note options (including on amend) be marked advanced to keep the
help text clutter level down?

Mon, Sep 16, 1:02 PM
D6856: amend: enable support for using the secret phase is now accepted and ready to land.
Mon, Sep 16, 1:01 PM
D6855: amend: enable support for closing the branch is now accepted and ready to land.
Mon, Sep 16, 1:00 PM
D6854: amend: prevent '\n' in the note string is now accepted and ready to land.
Mon, Sep 16, 1:00 PM
D6853: amend: add option to update to the current user is now accepted and ready to land.
Mon, Sep 16, 12:59 PM
durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Mon, Sep 16, 10:27 AM