Feed All Stories

Today

yuja added a comment to D3648: show: Get rid of extraneous space if `tip` also has other bookmarks.

separate() can't be used here since it takes non-list arguments.

Wed, May 23, 8:41 AM
spectral closed D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
Wed, May 23, 8:34 AM
pulkit committed rHGdce718404ce6: state: raise CorruptedState error isntead of ProgrammingError.
state: raise CorruptedState error isntead of ProgrammingError
Wed, May 23, 8:34 AM
spectral committed rHG2b8cb0ab231c: localrepo: add docstring to _makedirstate to make it less likely to be removed.
localrepo: add docstring to _makedirstate to make it less likely to be removed
Wed, May 23, 8:34 AM
pulkit closed D3644: state: raise CorruptedState error isntead of ProgrammingError.
Wed, May 23, 8:34 AM
markand committed rHG46c2b19a1263: scmutil: move repair.stripbmrevset as scmutil.bookmarkrevs (API).
scmutil: move repair.stripbmrevset as scmutil.bookmarkrevs (API)
Wed, May 23, 8:34 AM
mharbison72 committed rHGa40cc6d7d8c3: githelp: cleanup one more abort message.
githelp: cleanup one more abort message
Wed, May 23, 8:34 AM
durin42 committed rHGd46a38c07b1a: merge with i18n.
merge with i18n
Wed, May 23, 7:22 AM
Wagner Bruna <wbruna@softwareexpress.com.br> committed rHGbad736e65221: i18n-pt_BR: synchronized with 32a75a8a5b0f.
i18n-pt_BR: synchronized with 32a75a8a5b0f
Wed, May 23, 7:22 AM
Wagner Bruna <wbruna@softwareexpress.com.br> committed rHGb8d25c6dfb25: i18n-ja: fix block indentation.
i18n-ja: fix block indentation
Wed, May 23, 7:22 AM
FUJIWARA Katsunori <foozy@lares.dti.ne.jp> committed rHGcf6605c2d135: i18n-ja: synchronized with 32a75a8a5b0f.
i18n-ja: synchronized with 32a75a8a5b0f
Wed, May 23, 7:22 AM
tom.prince abandoned D3648: show: Get rid of extraneous space if `tip` also has other bookmarks.
Wed, May 23, 4:09 AM
tom.prince created D3648: show: Get rid of extraneous space if `tip` also has other bookmarks.
Wed, May 23, 3:47 AM

Yesterday

spectral created D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
Tue, May 22, 6:38 PM
spectral created D3645: debian: skip using rust extensions for now since the debian rules aren't correct.
Tue, May 22, 6:38 PM
spectral added a dependent revision for D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list: D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
Tue, May 22, 6:38 PM
spectral created D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
Tue, May 22, 6:38 PM
spectral added a dependent revision for D3645: debian: skip using rust extensions for now since the debian rules aren't correct: D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
Tue, May 22, 6:38 PM
pulkit created D3644: state: raise CorruptedState error isntead of ProgrammingError.
Tue, May 22, 5:52 PM
yuja committed rHGc65931d23baf: githelp: do not concatenate i18n messages dynamically so they can be collected.
githelp: do not concatenate i18n messages dynamically so they can be collected
Tue, May 22, 5:36 PM
spectral created D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
Tue, May 22, 2:21 PM
martinvonz added a comment to D3579: state: write the version number in plain text on top of state files.
In D3579#57298, @yuja wrote:

mercurial/state.py:65: undefined name 'iv'
mercurial/state.py:73: local variable 'version' is assigned to but never used

Queued the fixes.

Tue, May 22, 11:26 AM
spectral closed D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
Tue, May 22, 8:37 AM
spectral committed rHG1cba497491be: narrow: only wrap dirstate functions once, instead of per-reposetup.
narrow: only wrap dirstate functions once, instead of per-reposetup
Tue, May 22, 8:37 AM
yuja added a comment to D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
  • a/mercurial/localrepo.py +++ b/mercurial/localrepo.py @@ -778,6 +778,9 @@

    @repofilecache('dirstate') def dirstate(self): + return self._makedirstate() + + def _makedirstate(self):
Tue, May 22, 8:34 AM
yuja added a comment to D3579: state: write the version number in plain text on top of state files.

mercurial/state.py:65: undefined name 'iv'
mercurial/state.py:73: local variable 'version' is assigned to but never used

Tue, May 22, 8:13 AM
pulkit committed rHGb7e5c53a779e: state: temporary silence pyflakes warning by removing variable assignment.
state: temporary silence pyflakes warning by removing variable assignment
Tue, May 22, 8:12 AM
pulkit closed D3641: state: temporary silence pyflakes warning by removing variable assignment.
Tue, May 22, 8:12 AM
pulkit committed rHGbdc4079ceb16: state: fix usage of an unassigned variable.
state: fix usage of an unassigned variable
Tue, May 22, 8:12 AM
pulkit closed D3640: state: fix usage of an unassigned variable.
Tue, May 22, 8:12 AM
lothiraldan committed rHG13b2812cff2b: httppeer: declare 'dbg' at the function level.
httppeer: declare 'dbg' at the function level
Tue, May 22, 8:06 AM
lothiraldan committed rHG307c770da188: httppeer: declare 'dgb' at the function level.
httppeer: declare 'dgb' at the function level
Tue, May 22, 7:55 AM
lothiraldan committed rHGf9dc1d5b676b: httppeer: properly gate debug usage behind debug flag check.
httppeer: properly gate debug usage behind debug flag check
Tue, May 22, 7:55 AM
lothiraldan added a comment to D3556: run-tests: update the test case name format.

I fixed the issue, it was a last minute style fix that turns out to not be equivalent to the previous code.

Tue, May 22, 7:51 AM
lothiraldan updated the diff for D3556: run-tests: update the test case name format.
Tue, May 22, 7:48 AM
lothiraldan updated the diff for D3555: run-tests: add support for running specific test cases.
Tue, May 22, 7:48 AM
pulkit committed rHG282f3daac1d7: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
py3: use encoding.strfromlocal() instead of pycompat.sysstr()
Tue, May 22, 7:41 AM
pulkit committed rHG6ef01102ebff: py3: add b'' prefixes in tests/test-revset2.t.
py3: add b'' prefixes in tests/test-revset2.t
Tue, May 22, 7:41 AM
mharbison72 committed rHGf44306940c94: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
Tue, May 22, 7:41 AM
mharbison72 committed rHG10befe8e8b59: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
Tue, May 22, 7:41 AM
mharbison72 committed rHG26b73fad45d9: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
Tue, May 22, 7:41 AM
mharbison72 committed rHGee96458afdb6: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
Tue, May 22, 7:41 AM
mharbison72 committed rHG16463278e7f4: githelp: make several strings localizable.
githelp: make several strings localizable
Tue, May 22, 7:41 AM
mharbison72 committed rHGd8bd6a9c64a5: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
Tue, May 22, 7:41 AM
Paul Morelle <paul.morelle@octobus.net> committed rHG69ec6f98cfa6: revlog: isgooddeltainfo takes the whole revinfo object.
revlog: isgooddeltainfo takes the whole revinfo object
Tue, May 22, 7:41 AM
Paul Morelle <paul.morelle@octobus.net> committed rHGbf59f95583c1: revlog: make variable name 'd' more explicit in _isgooddeltainfo.
revlog: make variable name 'd' more explicit in _isgooddeltainfo
Tue, May 22, 7:41 AM
Paul Morelle <paul.morelle@octobus.net> committed rHGf79ba1d1b4b1: revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta.
revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta
Tue, May 22, 7:41 AM
Paul Morelle <paul.morelle@octobus.net> committed rHGb17fa9041695: debugdeltachain: r.start and r.length can be retrieved outside the loop.
debugdeltachain: r.start and r.length can be retrieved outside the loop
Tue, May 22, 7:41 AM
durin42 committed rHGf7a0398996ad: pathencode: remove unused variable.
pathencode: remove unused variable
Tue, May 22, 7:41 AM
yuja added a comment to D3635: py3: add support for NoneType in stringutil.pprint().

> --- a/mercurial/utils/stringutil.py
> +++ b/mercurial/utils/stringutil.py
> @@ -29,6 +29,8 @@
> if bprefix:
> return "b'%s'" % escapestr(o)
> return "'%s'" % escapestr(o)
> + elif o is None:
> + return 'None'

Should be handled by b'%r' % o.

Tue, May 22, 7:41 AM
yuja added a comment to D3635: py3: add support for NoneType in stringutil.pprint().
  • a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -29,6 +29,8 @@ if bprefix: return "b'%s'" % escapestr(o) return "'%s'" % escapestr(o) + elif o is None: + return 'None'
Tue, May 22, 7:23 AM
yuja added a comment to D3631: py3: use pycompat.fsencode to convert path to bytes.
    • a/contrib/hg-ssh +++ b/contrib/hg-ssh @@ -39,6 +39,7 @@

      from mercurial import ( dispatch, + pycompat, ui as uimod, )

      @@ -69,7 +70,7 @@ path = cmdargv[2] repo = os.path.normpath(os.path.join(cwd, os.path.expanduser(path))) if repo in allowed_paths:
  • cmd = [b'-R', repo, b'serve', b'--stdio'] + cmd = [b'-R', pycompat.fsencode(repo), b'serve', b'--stdio']
Tue, May 22, 7:20 AM
pulkit closed D3637: py3: add b'' prefixes in tests/test-revset2.t.
Tue, May 22, 7:14 AM
pulkit committed rHGdbea87a2d7e8: py3: add b'' prefixes in tests/test-revset2.t.
py3: add b'' prefixes in tests/test-revset2.t
Tue, May 22, 7:14 AM
pulkit committed rHGd6d939a3676f: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
py3: use encoding.strfromlocal() instead of pycompat.sysstr()
Tue, May 22, 7:14 AM
pulkit closed D3642: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
Tue, May 22, 7:14 AM
mharbison72 committed rHG1721a2ef74b8: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
Tue, May 22, 7:14 AM
yuja added a comment to D3579: state: write the version number in plain text on top of state files.
  • def save(self, data): + def save(self, version, data): """write all the state data stored to .hg/<filename> file

    we use third-party library cbor to serialize data to write in the file. """ + if not isinstance(version, int): + raise error.ProgrammingError("version of state file should be" + " an integer") + with self._repo.vfs(self.fname, 'wb', atomictemp=True) as fp: + fp.write('%d\n' % iv) cbor.dump(self.opts, fp, canonical=True)

    def _read(self): """reads the state file and returns a dictionary which contain data in the same format as it was before storing""" with self._repo.vfs(self.fname, 'rb') as fp: + try: + version = int(fp.readline())
Tue, May 22, 7:13 AM
mharbison72 committed rHGed103895d9a2: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
Tue, May 22, 5:21 AM
mharbison72 committed rHG8e4cdc86c55f: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
Tue, May 22, 5:21 AM
mharbison72 committed rHGd00bfbf24df0: githelp: make several strings localizable.
githelp: make several strings localizable
Tue, May 22, 5:21 AM
mharbison72 committed rHGc137053c30e3: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
Tue, May 22, 5:21 AM
mharbison72 committed rHGa34bed7475cc: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
Tue, May 22, 5:21 AM

Mon, May 21

Paul Morelle <paul.morelle@octobus.net> committed rHG90e02bd8c447: revlog: isgooddeltainfo takes the whole revinfo object.
revlog: isgooddeltainfo takes the whole revinfo object
Mon, May 21, 7:15 PM
Paul Morelle <paul.morelle@octobus.net> committed rHG048c0c992892: debugdeltachain: r.start and r.length can be retrieved outside the loop.
debugdeltachain: r.start and r.length can be retrieved outside the loop
Mon, May 21, 7:15 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGa391ecf67904: revlog: make variable name 'd' more explicit in _isgooddeltainfo.
revlog: make variable name 'd' more explicit in _isgooddeltainfo
Mon, May 21, 7:15 PM
Paul Morelle <paul.morelle@octobus.net> committed rHG02a31040c654: revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta.
revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta
Mon, May 21, 7:15 PM
joerg.sonnenberger added a comment to D3557: commit: add new close-branch command.

It doesn't seem to fit the argument schema for hg branch at all. I'm open for better places, but I couldn't think of a consistent place.

Mon, May 21, 5:03 PM
pulkit created D3642: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
Mon, May 21, 4:44 PM
pulkit added a dependent revision for D3640: state: fix usage of an unassigned variable: D3641: state: temporary silence pyflakes warning by removing variable assignment.
Mon, May 21, 2:56 PM
pulkit created D3641: state: temporary silence pyflakes warning by removing variable assignment.
Mon, May 21, 2:56 PM
pulkit created D3640: state: fix usage of an unassigned variable.
Mon, May 21, 2:56 PM
durin42 committed rHGf9eaa5cd9ee9: pathencode: remove unused variable.
pathencode: remove unused variable
Mon, May 21, 2:39 PM
durin42 closed D3618: pathencode: remove unused variable.
Mon, May 21, 2:39 PM
indygreg accepted D3618: pathencode: remove unused variable.
Mon, May 21, 2:37 PM
pulkit closed D3635: py3: add support for NoneType in stringutil.pprint().
Mon, May 21, 2:36 PM
pulkit committed rHG7aeb8aa262eb: py3: add support for NoneType in stringutil.pprint().
py3: add support for NoneType in stringutil.pprint()
Mon, May 21, 2:36 PM
pulkit closed D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output.
Mon, May 21, 2:36 PM
pulkit committed rHGd7cecea0b254: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py
Mon, May 21, 2:36 PM
pulkit closed D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
Mon, May 21, 2:36 PM
pulkit committed rHGbacbe829c2bf: py3: use bytes in tests/printenv.py.
py3: use bytes in tests/printenv.py
Mon, May 21, 2:36 PM
pulkit closed D3633: py3: use bytes in tests/printenv.py.
Mon, May 21, 2:36 PM
pulkit closed D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
Mon, May 21, 2:36 PM
pulkit committed rHGb0144fc8b681: py3: use stringutil.pprint() to prevent b'' prefixes in output.
py3: use stringutil.pprint() to prevent b'' prefixes in output
Mon, May 21, 2:36 PM
pulkit committed rHG666d90ace0bb: py3: use pycompat.fsencode to convert path to bytes.
py3: use pycompat.fsencode to convert path to bytes
Mon, May 21, 2:36 PM
pulkit committed rHGe69628f36196: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t
Mon, May 21, 2:36 PM
pulkit closed D3631: py3: use pycompat.fsencode to convert path to bytes.
Mon, May 21, 2:36 PM
pulkit committed rHG44ef9bb7ccd9: py3: add b'' prefixes in contrib/hg-ssh.
py3: add b'' prefixes in contrib/hg-ssh
Mon, May 21, 2:36 PM
pulkit closed D3629: py3: add b'' prefixes in contrib/hg-ssh.
Mon, May 21, 2:36 PM
indygreg accepted D3635: py3: add support for NoneType in stringutil.pprint().
Mon, May 21, 2:30 PM
indygreg accepted D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
Mon, May 21, 2:29 PM
indygreg accepted D3633: py3: use bytes in tests/printenv.py.

This one worries me a bit because environment variable values can contain non-ASCII. However, the changed code only operates on HG_ variables and I think those variables are well-sanitized and should be ASCII safe.

Mon, May 21, 2:29 PM
indygreg accepted D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output.
Mon, May 21, 2:25 PM
indygreg accepted D3631: py3: use pycompat.fsencode to convert path to bytes.
Mon, May 21, 2:24 PM
indygreg accepted D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
Mon, May 21, 2:24 PM
indygreg accepted D3629: py3: add b'' prefixes in contrib/hg-ssh.
Mon, May 21, 2:24 PM
pulkit committed rHGa0e4d654bceb: state: write the version number in plain text on top of state files.
state: write the version number in plain text on top of state files
Mon, May 21, 1:40 PM
pulkit committed rHG18c6d8b565bf: state: set canonical=True to write deterministically.
state: set canonical=True to write deterministically
Mon, May 21, 1:40 PM
pulkit closed D3579: state: write the version number in plain text on top of state files.
Mon, May 21, 1:40 PM
pulkit closed D3578: state: set canonical=True to write deterministically.
Mon, May 21, 1:40 PM