Feed All Stories

Today

joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:16 PM
martinvonz created D1867: evolution: report new unstable changesets.
Tue, Jan 16, 3:16 PM
Matt DeVore <matvore@google.com> committed rNRWHG487edd5b33a2: narrowspec.py: error if a narrowspec path has '.' or '..' path components.
narrowspec.py: error if a narrowspec path has '.' or '..' path components
Tue, Jan 16, 3:16 PM
yuja committed rHG821d8a5ab4ff: match: do not weirdly include explicit files excluded by -X option.
match: do not weirdly include explicit files excluded by -X option
Tue, Jan 16, 3:16 PM
mharbison72 committed rHGa1222a8cc93b: lfs: add the '{oid}' template keyword to '{lfs_files}'.
lfs: add the '{oid}' template keyword to '{lfs_files}'
Tue, Jan 16, 3:16 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:16 PM
mharbison72 committed rHG8580e5898cb7: lfs: convert '{lfs_files}' keyword to a hybrid list.
lfs: convert '{lfs_files}' keyword to a hybrid list
Tue, Jan 16, 3:16 PM
lothiraldan committed rHGc9eb92fb87b7: showstack: add an extension docstring.
showstack: add an extension docstring
Tue, Jan 16, 3:16 PM
lothiraldan committed rHG2f54a3e228ff: bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'.
bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'
Tue, Jan 16, 3:16 PM
av6 committed rHG59c842a3d1e1: hgweb: remove unused second argument of nextPageVarGet().
hgweb: remove unused second argument of nextPageVarGet()
Tue, Jan 16, 3:16 PM
lothiraldan added a comment to D1074: branch: add a --rev flag to change branch name of given revisions.

Apart from my review, it looks good to me.

Tue, Jan 16, 3:15 PM
quark added inline comments to D1849: lfs: remove internal url in test.
Tue, Jan 16, 3:14 PM
quark updated the diff for D1849: lfs: remove internal url in test.
Tue, Jan 16, 3:14 PM
joerg.sonnenberger added a dependency for D1856: wireproto: support for pullbundles: D1862: wireproto: split streamres into legacy and modern case.
Tue, Jan 16, 3:14 PM
joerg.sonnenberger added a dependent revision for D1862: wireproto: split streamres into legacy and modern case: D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:14 PM
martinvonz created D1868: evolution: make reporting of new unstable changesets optional.
Tue, Jan 16, 3:14 PM
martinvonz created D1866: transaction: register summary callbacks only at start of transaction (BC).
Tue, Jan 16, 3:14 PM
lothiraldan added a comment to D1867: evolution: report new unstable changesets.

LGTM on a first quick review

Tue, Jan 16, 3:14 PM
martinvonz added a comment to D1867: evolution: report new unstable changesets.

For the effects on the evolve repo, see https://bitbucket.org/martinvonz/mutable-history/commits/288b3db249c10bc22158d06cc11bceea94c0dc6a

Tue, Jan 16, 3:14 PM
martinvonz abandoned D1863: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:14 PM
martinvonz added a dependent revision for D1867: evolution: report new unstable changesets: D1868: evolution: make reporting of new unstable changesets optional.
Tue, Jan 16, 3:13 PM
martinvonz created D1864: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:13 PM
martinvonz created D1865: repair: filter out unknown revisions from phasecache within transaction.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1866: transaction: register summary callbacks only at start of transaction (BC): D1867: evolution: report new unstable changesets.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1865: repair: filter out unknown revisions from phasecache within transaction: D1866: transaction: register summary callbacks only at start of transaction (BC).
Tue, Jan 16, 3:13 PM
martinvonz created D1863: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1864: repair: drop unnecessary phase cache invalidation: D1865: repair: filter out unknown revisions from phasecache within transaction.
Tue, Jan 16, 3:13 PM

Yesterday

joerg.sonnenberger created D1862: wireproto: split streamres into legacy and modern case.
Mon, Jan 15, 6:31 PM
indygreg created D1861: wireproto: drop support for reader interface from streamres (API).
Mon, Jan 15, 6:20 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

The ideal solution would be a way to reset the context for the byte stream. Essentially we'd add a marker telling consumers they've reached EOF of either a bundle2 stream or a compression context. The next byte should be interpreted as a new bundle2 stream or a new compression context.

Mon, Jan 15, 5:39 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

Mon, Jan 15, 5:33 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 5:31 PM
tom.prince updated the diff for D1802: phabricator: add a template item for linking to a differential review.
Mon, Jan 15, 4:58 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 2:33 PM
joerg.sonnenberger abandoned D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.

Merging into the parent review.

Mon, Jan 15, 2:26 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 2:22 PM
pulkit updated subscribers of D1074: branch: add a --rev flag to change branch name of given revisions.

@durin42 @yuja @indygreg @krbullock this one is lying here for months. Does this conflict with anything or is a BC or something else, or was just missed for the review?

Mon, Jan 15, 1:45 PM
durin42 added a comment to D1856: wireproto: support for pullbundles.

My biggest concern with the architecture of this feature is the multiple roundtrips. I really wish we could stream multiple bundles off disk to the wire with no decompression/compression involved. That would mean storing compressed bundles on disk. But this would require some additional bundle2 magic. The existing solution is simple and elegant. I do like that. I'd very much like to get the opinion of someone like @durin42 (who also likes designing protocols).

Mon, Jan 15, 11:02 AM
indygreg closed D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 8:25 AM
indygreg committed rHG48fe4f56a3b4: dispatch: handle IOError when writing to stderr.
dispatch: handle IOError when writing to stderr
Mon, Jan 15, 8:25 AM
indygreg committed rHG40da2d7b4871: commandserver: restore cwd in case of exception.
commandserver: restore cwd in case of exception
Mon, Jan 15, 8:25 AM
indygreg closed D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 8:25 AM
indygreg closed D1858: tests: make hg frame optional.
Mon, Jan 15, 8:25 AM
indygreg committed rHG15cfd343d3a9: tests: make hg frame optional.
tests: make hg frame optional
Mon, Jan 15, 8:25 AM
mharbison72 committed rHG4568e98b5f45: test-lfs: add tests to show that hashes remain unchanged by conversions.
test-lfs: add tests to show that hashes remain unchanged by conversions
Mon, Jan 15, 8:25 AM
mharbison72 committed rHG1f0690bfc683: test-lfs: drop an unresolved issue note, now that lfs.track=none() is a thing.
test-lfs: drop an unresolved issue note, now that lfs.track=none() is a thing
Mon, Jan 15, 8:25 AM
mharbison72 committed rHG588d02d9208a: lfs: always exclude '.hg*' text files.
lfs: always exclude '.hg*' text files
Mon, Jan 15, 8:25 AM
pulkit committed rHGfc39e2bfcd70: bookmarks: calculate visibility exceptions only once.
bookmarks: calculate visibility exceptions only once
Mon, Jan 15, 8:25 AM
yuja accepted D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 8:12 AM
yuja accepted D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 8:08 AM
yuja accepted D1858: tests: make hg frame optional.
Mon, Jan 15, 8:05 AM
yuja added a comment to D1858: tests: make hg frame optional.

I think the frame details aren't important here, so making some lines optional
should be just fine.

Mon, Jan 15, 8:05 AM
indygreg created D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 12:00 AM
indygreg created D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 12:00 AM
indygreg added a dependent revision for D1859: commandserver: restore cwd in case of exception: D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 12:00 AM

Sun, Jan 14

joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Sun, Jan 14, 7:02 PM
mharbison72 added a comment to D1858: tests: make hg frame optional.

I haven't been paying attention to the rust threads, but is there an hghave test for it? I don't see one locally. If so, then all that should be needed is appending ' (no-rust !)'. (Note the spaces.) I think this works for #test-cases too.

Sun, Jan 14, 6:30 PM
joerg.sonnenberger added a dependency for D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads: D1856: wireproto: support for pullbundles.
Sun, Jan 14, 6:29 PM
joerg.sonnenberger added a dependent revision for D1856: wireproto: support for pullbundles: D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.
Sun, Jan 14, 6:29 PM
joerg.sonnenberger added a comment to D1856: wireproto: support for pullbundles.

I wish we could find a way to send multiple, inline, pre-generated bundles in one response. However, the existing design of compression within the bundle2 format doesn't easily facilitate this. We should think long and hard about whether to implement this feature as partial pull or extend bundle2 to allow us to do nice things and avoid the extra client-server roundtrips.

Sun, Jan 14, 6:29 PM
indygreg created D1858: tests: make hg frame optional.
Sun, Jan 14, 6:04 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

Another idea to consider is storing changegroup data or bundle2 parts on disk instead of full bundles. Then, we could stream multiple changegroup parts into a larger bundle2 payload.

Sun, Jan 14, 5:55 PM
joerg.sonnenberger updated the diff for D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.
Sun, Jan 14, 5:47 PM
indygreg requested changes to D1856: wireproto: support for pullbundles.

This patch needs a lot of work. But I'm very supportive of the feature and the preliminary implementation!

Sun, Jan 14, 5:43 PM
indygreg requested changes to D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.

I'm generally in favor of this functionality. It enables some interesting server features (such as pullbundles).

Sun, Jan 14, 5:04 PM
indygreg added a comment to D1850: hgweb: when no agreement on compression can be found, fail for v2.

Which status code shall we use then, just plain 400?

Sun, Jan 14, 4:35 PM
yuja committed rHGa177c6aa055a: log: rewrite --follow-first -rREV like --follow for consistency (BC).
log: rewrite --follow-first -rREV like --follow for consistency (BC)
Sun, Jan 14, 4:19 PM
yuja committed rHGb6b7855c79aa: log: use revsetlang.formatspec() thoroughly.
log: use revsetlang.formatspec() thoroughly
Sun, Jan 14, 4:19 PM
yuja committed rHG7a0a90d63a8c: log: use revsetlang.formatspec() to concatenate list expression.
log: use revsetlang.formatspec() to concatenate list expression
Sun, Jan 14, 4:19 PM
yuja committed rHG668c5a527eff: log: simplify 'x or ancestors(x)' expression.
log: simplify 'x or ancestors(x)' expression
Sun, Jan 14, 4:19 PM
yuja committed rHGe64baf32782a: log: make opt2revset table a module constant.
log: make opt2revset table a module constant
Sun, Jan 14, 4:19 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGfa4278171add: revlog: rename 'rev' to 'base', as it is the base revision.
revlog: rename 'rev' to 'base', as it is the base revision
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGc41bb85c09ff: revlog: group revision info into a dedicated structure.
revlog: group revision info into a dedicated structure
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHG30f5f33250c8: revlog: separate diff computation from the collection of other info.
revlog: separate diff computation from the collection of other info
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGedc9330acac1: revlog: introduce 'deltainfo' to distinguish from 'delta'.
revlog: introduce 'deltainfo' to distinguish from 'delta'
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGa7d39f08bc66: revlog: extract 'builddelta' closure function from _addrevision.
revlog: extract 'builddelta' closure function from _addrevision
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHG8108bb51309d: revlog: extract 'buildtext' closure function from _addrevision.
revlog: extract 'buildtext' closure function from _addrevision
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHG0b52c0ecbc23: revlog: choose between ifh and dfh once for all.
revlog: choose between ifh and dfh once for all
Sun, Jan 14, 4:11 PM
Paul Morelle <paul.morelle@octobus.net> committed rHGb43578ec483a: revlog: refactor out the selection of candidate revisions.
revlog: refactor out the selection of candidate revisions
Sun, Jan 14, 3:47 PM
pulkit committed rHGa981ab2a1b4c: py3: use email.parser module to parse email messages.
py3: use email.parser module to parse email messages
Sun, Jan 14, 3:16 PM
indygreg updated the diff for D1478: py3: cast error message to localstr in blackbox.py.
Sun, Jan 14, 3:13 PM
indygreg abandoned D1479: py3: use byteskwargs in templatekw.showobsfate().

This was addressed by D1536.

Sun, Jan 14, 3:09 PM
yuja committed rHGfa9747e7fc86: rust: convert Unix path to CString transparently.
rust: convert Unix path to CString transparently
Sun, Jan 14, 2:52 PM
yuja committed rHGedbe11cfedcf: rust: extract function to convert Path to platform CString.
rust: extract function to convert Path to platform CString
Sun, Jan 14, 2:52 PM
indygreg abandoned D1481: py3: ensure hashes are bytes in sparse.py.

This was addressed in D1792.

Sun, Jan 14, 2:41 PM
lothiraldan closed D1833: style: remove multiple statement on a single line in zeroconf.
Sun, Jan 14, 2:36 PM
lothiraldan closed D1834: pylint: add a check for multiple statement on a single line.
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG6061e54ff81d: pylint: add a check for multiple statement on a single line.
pylint: add a check for multiple statement on a single line
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG31451f3f4b56: style: remove multiple statement on a single line in zeroconf.
style: remove multiple statement on a single line in zeroconf
Sun, Jan 14, 2:36 PM
lothiraldan committed rHGab11af15a149: style: remove multiple statement on a single line.
style: remove multiple statement on a single line
Sun, Jan 14, 2:36 PM
lothiraldan closed D1832: style: remove multiple statement on a single line.
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG882998f08c3c: pylint: split command line argument on multiple lines.
pylint: split command line argument on multiple lines
Sun, Jan 14, 2:36 PM
lothiraldan closed D1831: pylint: split command line argument on multiple lines.
Sun, Jan 14, 2:36 PM
indygreg accepted D1834: pylint: add a check for multiple statement on a single line.

Nice cleanup. Always happy to turn on more lint checks.

Sun, Jan 14, 2:34 PM
tom.prince closed D1801: Use named group for parsing differential reviews lines..
Sun, Jan 14, 2:34 PM
tom.prince committed rHGa0d33f4ddff9: phabricator: use named group for parsing differential reviews lines.
phabricator: use named group for parsing differential reviews lines
Sun, Jan 14, 2:34 PM
indygreg accepted D1833: style: remove multiple statement on a single line in zeroconf.
Sun, Jan 14, 2:34 PM
indygreg accepted D1832: style: remove multiple statement on a single line.
Sun, Jan 14, 2:34 PM
indygreg accepted D1831: pylint: split command line argument on multiple lines.
Sun, Jan 14, 2:33 PM
indygreg requested changes to D1802: phabricator: add a template item for linking to a differential review.

Please also remove the double newlines and fix the commit message to abide by our message standards.

Sun, Jan 14, 2:31 PM