Feed All Stories

Jan 16 2019

durin42 added a dependent revision for D5600: remotefilelog: fix logging in retry decorator: D5601: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
Jan 16 2019, 11:16 AM
durin42 created D5600: remotefilelog: fix logging in retry decorator.
Jan 16 2019, 11:16 AM
durin42 added a dependent revision for D5599: remotefilelog: import Queue on Python 2, and queue on Python 3: D5600: remotefilelog: fix logging in retry decorator.
Jan 16 2019, 11:16 AM
durin42 created D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 11:16 AM
durin42 added a dependent revision for D5598: basepack: avoid 'rbe' mode in Python 3: D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 11:16 AM
durin42 created D5598: basepack: avoid 'rbe' mode in Python 3.
Jan 16 2019, 11:16 AM
durin42 added a dependent revision for D5597: remotefilelog: do file IO in terms of bytes: D5598: basepack: avoid 'rbe' mode in Python 3.
Jan 16 2019, 11:16 AM
durin42 created D5597: remotefilelog: do file IO in terms of bytes.
Jan 16 2019, 11:16 AM
gracinet added a comment to D5579: rust: factorized testing Graphs.

@yuja the doc you're linking is about integration tests, so it wouldn't apply to these tests which are really unitary in my mind. Usually the main difference would be the access to the private constructs that the integration tests can't perform, but it's true that most of these implementations are public anyway.

Jan 16 2019, 9:50 AM
yuja added a comment to D5493: match: support rooted globs in hgignore.

I haven't handled your other remark,

Jan 16 2019, 8:24 AM
yuja added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
> `[, samebranch]` or [, samebranch=False]`.

I guess that means:

@predicate('merge([withbranch [, samebranch=None]])', safe=True)

Right? (I realized that it is incorrect to say that samebranch's default value is False).
Jan 16 2019, 8:10 AM
gracinet closed D5551: rust-cpython: using MissingAncestors from Python code.
Jan 16 2019, 7:45 AM
gracinet closed D5584: rust: MissingAncestors.basesheads().
Jan 16 2019, 7:45 AM
gracinet committed rHGa89b20a49c13: rust-cpython: using MissingAncestors from Python code.
rust-cpython: using MissingAncestors from Python code
Jan 16 2019, 7:44 AM
gracinet committed rHG619ee4039bd4: rust: MissingAncestors.basesheads().
rust: MissingAncestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet committed rHG4856c9b8cbaf: ancestor: incrementalmissingancestors.basesheads().
ancestor: incrementalmissingancestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet closed D5579: rust: factorized testing Graphs.
Jan 16 2019, 7:44 AM
gracinet closed D5582: ancestor: incrementalmissingancestors.basesheads().
Jan 16 2019, 7:44 AM
gracinet committed rHG2a8782cc2e16: discovery: using the new basesheads().
discovery: using the new basesheads()
Jan 16 2019, 7:44 AM
gracinet closed D5583: discovery: using the new basesheads().
Jan 16 2019, 7:44 AM
gracinet closed D5578: rust-cpython: moved generic conversion fn out of ancestors module.
Jan 16 2019, 7:44 AM
gracinet committed rHG5257e6299d4c: rust-cpython: set conversion for MissingAncestors.bases().
rust-cpython: set conversion for MissingAncestors.bases()
Jan 16 2019, 7:44 AM
Diffusion closed D5580: rust: dagop.headrevs() Rust counterparts.
Jan 16 2019, 7:44 AM
Georges Racinet on ishtar.racinet.fr <georges@racinet.fr> committed rHG47881d2a9d99: rust: dagop.headrevs() Rust counterparts.
rust: dagop.headrevs() Rust counterparts
Jan 16 2019, 7:44 AM
gracinet closed D5581: rust-cpython: set conversion for MissingAncestors.bases().
Jan 16 2019, 7:44 AM
gracinet committed rHG168041fa6d5f: rust: factorized testing Graphs.
rust: factorized testing Graphs
Jan 16 2019, 7:44 AM
gracinet committed rHGff333620a4cc: rust-cpython: moved generic conversion fn out of ancestors module.
rust-cpython: moved generic conversion fn out of ancestors module
Jan 16 2019, 7:44 AM
lothiraldan committed rHG26b0a7514f01: revset: transparently forward _intlist argument in all case.
revset: transparently forward _intlist argument in all case
Jan 16 2019, 7:43 AM
martinvonz committed rHG8c366af085f4: narrow: reuse narrowspec.updateworkingcopy() when narrowing.
narrow: reuse narrowspec.updateworkingcopy() when narrowing
Jan 16 2019, 7:43 AM
martinvonz committed rHGad9ab2523149: narrow: reuse narrowspec.updateworkingcopy() when widening.
narrow: reuse narrowspec.updateworkingcopy() when widening
Jan 16 2019, 7:43 AM
yuja added a comment to D5579: rust: factorized testing Graphs.

Queued the series, thanks.

Jan 16 2019, 7:42 AM
yuja added a comment to D5510: narrow: reuse narrowspec.updateworkingcopy() when widening.

Fixed pyflakes warnings in flight.

Jan 16 2019, 7:42 AM
martinvonz closed D5509: narrow: move copytonarrowspec() out of setnarrowpats().
Jan 16 2019, 4:34 AM
lothiraldan committed rHGc9fd08893247: revset: transparently forward _intlist argument in all case.
revset: transparently forward _intlist argument in all case
Jan 16 2019, 4:34 AM
martinvonz committed rHG8a26faac4a45: narrow: reuse narrowspec.updateworkingcopy() when narrowing.
narrow: reuse narrowspec.updateworkingcopy() when narrowing
Jan 16 2019, 4:34 AM
martinvonz closed D5507: narrow: drop now-unnecessary reassignment of repo attributes.
Jan 16 2019, 4:34 AM
martinvonz closed D5510: narrow: reuse narrowspec.updateworkingcopy() when widening.
Jan 16 2019, 4:34 AM
martinvonz closed D5511: narrow: reuse narrowspec.updateworkingcopy() when narrowing.
Jan 16 2019, 4:34 AM
martinvonz committed rHG092700100f94: narrow: reuse narrowspec.updateworkingcopy() when widening.
narrow: reuse narrowspec.updateworkingcopy() when widening
Jan 16 2019, 4:34 AM
Diffusion closed D5571: packaging: allow running packaging with custom uid+gid for CentOS.
Jan 16 2019, 4:34 AM
martinvonz committed rHG44a51c1c8e17: narrow: move copytonarrowspec() out of setnarrowpats().
narrow: move copytonarrowspec() out of setnarrowpats()
Jan 16 2019, 4:34 AM
martinvonz committed rHGa2ae27993e16: narrow: drop now-unnecessary reassignment of repo attributes.
narrow: drop now-unnecessary reassignment of repo attributes
Jan 16 2019, 4:34 AM
Diffusion closed D5570: hg-docker: fix Python 3.4 compatibility (for CentOS 7).
Jan 16 2019, 4:34 AM
Mathias De Mare <mathias.de_mare@nokia.com> committed rHG4c0d4bbdc395: packaging: allow running packaging with custom uid+gid for CentOS.
packaging: allow running packaging with custom uid+gid for CentOS
Jan 16 2019, 4:34 AM
Mathias De Mare <mathias.de_mare@nokia.com> committed rHG92b3811fd15f: hg-docker: fix Python 3.4 compatibility (for CentOS 7).
hg-docker: fix Python 3.4 compatibility (for CentOS 7)
Jan 16 2019, 4:34 AM
martinvonz closed D5593: copies: use node.nullrev instead of literal -1.
Jan 16 2019, 3:07 AM
martinvonz committed rHGf3f5bfbf7e04: copies: use node.nullrev instead of literal -1.
copies: use node.nullrev instead of literal -1
Jan 16 2019, 3:07 AM
martinvonz closed D5592: copies: use node.wdirrev instead of inventing another constant for it.
Jan 16 2019, 3:07 AM
martinvonz committed rHGe3e1b0639375: copies: use node.wdirrev instead of inventing another constant for it.
copies: use node.wdirrev instead of inventing another constant for it
Jan 16 2019, 3:07 AM
angel.ezquerra added a comment to D5495: revset: add "branch" positional arguments to the merge revset.

Thank you Matt. I just did that.

Jan 16 2019, 3:04 AM
angel.ezquerra abandoned D5497: revset: add tests for the new merge() arguments (withbranch and samebranch).

The tests in this revision where integrated into the other 2 revisions in this set of patches upon request by @yuja .

Jan 16 2019, 2:58 AM
pulkit accepted D5593: copies: use node.nullrev instead of literal -1.
Jan 16 2019, 2:51 AM
martinvonz closed D5506: narrow: copy store narrowspec to working copy immediately.
Jan 16 2019, 2:50 AM
martinvonz committed rHGd2d716cc0700: narrow: extract repo property for store narrowmatcher.
narrow: extract repo property for store narrowmatcher
Jan 16 2019, 2:49 AM
martinvonz closed D5508: narrow: extract repo property for store narrowmatcher.
Jan 16 2019, 2:49 AM
martinvonz committed rHG50ca531f1f24: narrow: copy store narrowspec to working copy immediately.
narrow: copy store narrowspec to working copy immediately
Jan 16 2019, 2:49 AM
martinvonz closed D5556: narrow: include journal.narrowspec in transaction journal.
Jan 16 2019, 2:49 AM
martinvonz closed D5505: narrow: include working copy narrowspec in transaction journal.
Jan 16 2019, 2:49 AM
martinvonz closed D5531: progress: deprecate ui.progress().
Jan 16 2019, 2:49 AM
martinvonz committed rHG3b35ebdb9f8c: narrow: include working copy narrowspec in transaction journal.
narrow: include working copy narrowspec in transaction journal
Jan 16 2019, 2:49 AM
martinvonz committed rHGb74481038438: narrow: make dirstateguard back up and restore working copy narrowspec instead.
narrow: make dirstateguard back up and restore working copy narrowspec instead
Jan 16 2019, 2:49 AM
martinvonz closed D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead.
Jan 16 2019, 2:49 AM
martinvonz committed rHG0f2b8d51bfdf: narrow: include journal.narrowspec in transaction journal.
narrow: include journal.narrowspec in transaction journal
Jan 16 2019, 2:49 AM
martinvonz committed rHG44914de4e915: progress: deprecate ui.progress().
progress: deprecate ui.progress()
Jan 16 2019, 2:49 AM
pulkit accepted D5592: copies: use node.wdirrev instead of inventing another constant for it.
Jan 16 2019, 2:48 AM
pulkit added a comment to D5531: progress: deprecate ui.progress().

Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that.

Jan 16 2019, 2:42 AM
pulkit accepted D5508: narrow: extract repo property for store narrowmatcher.
Jan 16 2019, 2:29 AM
pulkit accepted D5506: narrow: copy store narrowspec to working copy immediately.
Jan 16 2019, 2:23 AM
pulkit accepted D5505: narrow: include working copy narrowspec in transaction journal.
Jan 16 2019, 2:21 AM
pulkit accepted D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead.
Jan 16 2019, 2:18 AM
pulkit accepted D5556: narrow: include journal.narrowspec in transaction journal.
Jan 16 2019, 2:14 AM
martinvonz added a comment to D5531: progress: deprecate ui.progress().

Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that.

Jan 16 2019, 2:07 AM
pulkit accepted D5531: progress: deprecate ui.progress().
Jan 16 2019, 2:02 AM
martinvonz created D5596: copies: get working copy parents from wctx, not dirstate, to make in-mem work.
Jan 16 2019, 1:06 AM
martinvonz created D5595: copies: pass contexts into _findlimit().
Jan 16 2019, 1:06 AM
martinvonz added a dependent revision for D5595: copies: pass contexts into _findlimit(): D5596: copies: get working copy parents from wctx, not dirstate, to make in-mem work.
Jan 16 2019, 1:06 AM
mharbison72 added a comment to D5495: revset: add "branch" positional arguments to the merge revset.

I've sent an updated set of patches, following your recommendations. There are 2 patches now, since each includes its own tests. This means that the 3rd patch on the original patch set is no longer needed. However I don't know what is the best way to tell that to phabricator...

Jan 16 2019, 12:59 AM

Jan 15 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Sorry, it took me a while to come back to this. I renamed the syntax to rootglob.

Jan 15 2019, 11:57 PM
martinvonz created D5594: copies: consider nullrev a common ancestor.
Jan 15 2019, 7:27 PM
martinvonz created D5593: copies: use node.nullrev instead of literal -1.
Jan 15 2019, 7:27 PM
martinvonz added a dependent revision for D5593: copies: use node.nullrev instead of literal -1: D5594: copies: consider nullrev a common ancestor.
Jan 15 2019, 7:27 PM
martinvonz added a dependent revision for D5592: copies: use node.wdirrev instead of inventing another constant for it: D5593: copies: use node.nullrev instead of literal -1.
Jan 15 2019, 7:27 PM
martinvonz created D5592: copies: use node.wdirrev instead of inventing another constant for it.
Jan 15 2019, 7:27 PM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 15 2019, 7:02 PM
angel.ezquerra added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
In D5496#82394, @yuja wrote:

-@predicate('merge(withbranch)', safe=True)
+@predicate('merge(withbranch, samebranch=True)', safe=True)

[, samebranch] or [, samebranch=False]`.

Jan 15 2019, 7:02 PM
spectral closed D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Jan 15 2019, 6:57 PM
spectral committed rHGb129837190f7: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
context: use scmutil.matchfiles instead of matchmod.match(exact=True)
Jan 15 2019, 6:57 PM
spectral added a comment to D5532: context: schedule file prefetch before comparing for cleanliness.
In D5532#82319, @yuja wrote:

+ scmutil.prefetchfiles(
+ self.repo(), [self.p1().rev()],
+ matchmod.match('', '', patterns=self._cache.keys(), exact=True))

Perhaps scmutil.matchfiles() can be used instead of the low-level constructor.

Jan 15 2019, 6:47 PM
spectral created D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Jan 15 2019, 6:47 PM
kevincox accepted D5579: rust: factorized testing Graphs.
Jan 15 2019, 2:58 PM
kevincox accepted D5580: rust: dagop.headrevs() Rust counterparts.
Jan 15 2019, 2:55 PM
kevincox accepted D5581: rust-cpython: set conversion for MissingAncestors.bases().
Jan 15 2019, 2:46 PM
lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a RFC flag

Jan 15 2019, 12:51 PM
lothiraldan created D5590: watchman: ignore some of watchman errors.
Jan 15 2019, 11:57 AM
lothiraldan created D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5589: watchman: add the possibility to set the exact watchman binary location: D5590: watchman: ignore some of watchman errors.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5588: watchman: disable fsmonitor when running non-interactively: D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 15 2019, 11:57 AM
lothiraldan created D5588: watchman: disable fsmonitor when running non-interactively.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5587: watchman: detect nested mercurial repositories and abort: D5588: watchman: disable fsmonitor when running non-interactively.
Jan 15 2019, 11:57 AM
lothiraldan created D5587: watchman: detect nested mercurial repositories and abort.
Jan 15 2019, 11:57 AM