Page MenuHomePhabricator
Feed All Stories

Jan 16 2019

pulkit committed rHG9eb8c54471b9: py3: add 11 more passing tests caught by ratchet.
py3: add 11 more passing tests caught by ratchet
Jan 16 2019, 3:54 PM
pulkit closed D5616: py3: add 11 more passing tests caught by ratchet.
Jan 16 2019, 3:54 PM
durin42 created D5617: py3: test*gendoc*.t passes on Python 3.
Jan 16 2019, 3:52 PM
spectral updated the diff for D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Jan 16 2019, 3:50 PM
spectral added a comment to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

Alright that test seems a bit ridiculous now that I'm looking at it in the diff, but it's at least thorough? :)

Jan 16 2019, 3:50 PM
indygreg requested changes to D5588: watchman: disable fsmonitor when running non-interactively.

Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from watchman.

Jan 16 2019, 2:50 PM
indygreg accepted D5587: watchman: detect nested mercurial repositories and abort.
Jan 16 2019, 2:44 PM
indygreg added a comment to D5586: watchman: add verbose config knob.

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

Jan 16 2019, 2:40 PM
pulkit created D5616: py3: add 11 more passing tests caught by ratchet.
Jan 16 2019, 1:44 PM
angel.ezquerra added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
In D5496#82671, @yuja wrote:
> `[, samebranch]` or [, samebranch=False]`.
I guess that means:
@predicate('merge([withbranch [, samebranch=None]])', safe=True)
Right? (I realized that it is incorrect to say that samebranch's default value is False).

Okay, I didn't notice that. And it's tricky to map samebranch=False to
"different branch" constraint. I would read it as "I don't care whether
the branches are the same or not."

Jan 16 2019, 1:11 PM
durin42 closed D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 12:22 PM
durin42 committed rHGdfc73c803b77: fastannotate: adapt to buffer() going a way in Python 3.
fastannotate: adapt to buffer() going a way in Python 3
Jan 16 2019, 12:22 PM
durin42 committed rHG433c736f6f1c: py3: all fastannotate tests now pass.
py3: all fastannotate tests now pass
Jan 16 2019, 12:22 PM
durin42 committed rHG92cf293fd93d: remotefilelog: import Queue on Python 2, and queue on Python 3.
remotefilelog: import Queue on Python 2, and queue on Python 3
Jan 16 2019, 12:22 PM
durin42 closed D5614: fastannotate: adapt to buffer() going a way in Python 3.
Jan 16 2019, 12:22 PM
durin42 closed D5615: py3: all fastannotate tests now pass.
Jan 16 2019, 12:22 PM
durin42 committed rHGc2f62720e37d: fastannotate: use pycompat.maplist instead of map.
fastannotate: use pycompat.maplist instead of map
Jan 16 2019, 12:22 PM
durin42 closed D5612: fastannotate: slice strings to get single character.
Jan 16 2019, 12:22 PM
durin42 committed rHGe40b7a504b1d: fastannotate: slice strings to get single character.
fastannotate: slice strings to get single character
Jan 16 2019, 12:22 PM
durin42 closed D5613: fastannotate: use pycompat.maplist instead of map.
Jan 16 2019, 12:22 PM
durin42 closed D5611: fastannotate: fix isinstance checks to be against bytes instead of str.
Jan 16 2019, 12:22 PM
durin42 closed D5610: absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3.
Jan 16 2019, 12:22 PM
durin42 closed D5609: remotefilelog: fix some bytes/str portability issues for Python 3.
Jan 16 2019, 12:21 PM
durin42 committed rHG1198c86beb73: fastannotate: fix isinstance checks to be against bytes instead of str.
fastannotate: fix isinstance checks to be against bytes instead of str
Jan 16 2019, 12:21 PM
durin42 committed rHGc146651a78e1: absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3.
absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3
Jan 16 2019, 12:21 PM
durin42 committed rHG194e43c2bac9: remotefilelog: fix some bytes/str portability issues for Python 3.
remotefilelog: fix some bytes/str portability issues for Python 3
Jan 16 2019, 12:21 PM
durin42 closed D5608: shallowutil: fsdecode the bytes group name before passing to os.
Jan 16 2019, 12:21 PM
durin42 committed rHGa6b98c95bcf0: shallowutil: fsdecode the bytes group name before passing to os.
shallowutil: fsdecode the bytes group name before passing to os
Jan 16 2019, 12:21 PM
durin42 closed D5607: shallowutil: slice off a byte instead of subscripting.
Jan 16 2019, 12:21 PM
durin42 closed D5604: tests: fix up uses of xrange in remotefilelog tests for py3.
Jan 16 2019, 12:21 PM
durin42 committed rHGebda5d4265ec: remotefilelog: check against bytes type instead of buffer and coerce to bytes.
remotefilelog: check against bytes type instead of buffer and coerce to bytes
Jan 16 2019, 12:21 PM
durin42 committed rHGd08c816a11d3: shallowutil: slice off a byte instead of subscripting.
shallowutil: slice off a byte instead of subscripting
Jan 16 2019, 12:21 PM
durin42 closed D5606: remotefilelog: check against bytes type instead of buffer and coerce to bytes.
Jan 16 2019, 12:21 PM
durin42 closed D5605: remotefilelog: use list comprehension instead of filter for py3 portability.
Jan 16 2019, 12:21 PM
durin42 committed rHG2888d12b80a6: tests: fix up uses of xrange in remotefilelog tests for py3.
tests: fix up uses of xrange in remotefilelog tests for py3
Jan 16 2019, 12:21 PM
durin42 committed rHG29996f6c2687: tests: add missing b prefixes in remotefilelog-getflogheads.py.
tests: add missing b prefixes in remotefilelog-getflogheads.py
Jan 16 2019, 12:21 PM
durin42 committed rHG60b3edccf2f7: remotefilelog: use list comprehension instead of filter for py3 portability.
remotefilelog: use list comprehension instead of filter for py3 portability
Jan 16 2019, 12:21 PM
durin42 closed D5602: tests: make python oneliner portable to python 3 in remotefilelog test.
Jan 16 2019, 12:21 PM
durin42 closed D5603: tests: add missing b prefixes in remotefilelog-getflogheads.py.
Jan 16 2019, 12:21 PM
durin42 committed rHGbeb0d944a99b: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
remotefilelog: implement __bool__ as well as __nonzero__ for py3
Jan 16 2019, 12:21 PM
durin42 committed rHGa495435d980e: tests: make python oneliner portable to python 3 in remotefilelog test.
tests: make python oneliner portable to python 3 in remotefilelog test
Jan 16 2019, 12:21 PM
durin42 closed D5601: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
Jan 16 2019, 12:21 PM
durin42 closed D5600: remotefilelog: fix logging in retry decorator.
Jan 16 2019, 12:21 PM
durin42 committed rHG8a6995513d9a: remotefilelog: fix logging in retry decorator.
remotefilelog: fix logging in retry decorator
Jan 16 2019, 12:21 PM
durin42 closed D5597: remotefilelog: do file IO in terms of bytes.
Jan 16 2019, 12:21 PM
durin42 committed rHGc891a11ffe27: basepack: avoid 'rbe' mode in Python 3.
basepack: avoid 'rbe' mode in Python 3
Jan 16 2019, 12:21 PM
durin42 committed rHG312afd164009: remotefilelog: do file IO in terms of bytes.
remotefilelog: do file IO in terms of bytes
Jan 16 2019, 12:21 PM
durin42 closed D5598: basepack: avoid 'rbe' mode in Python 3.
Jan 16 2019, 12:21 PM
pulkit accepted D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 12:13 PM
pulkit accepted D5615: py3: all fastannotate tests now pass.
Jan 16 2019, 12:07 PM
pulkit accepted D5614: fastannotate: adapt to buffer() going a way in Python 3.
Jan 16 2019, 12:07 PM
pulkit accepted D5613: fastannotate: use pycompat.maplist instead of map.
Jan 16 2019, 12:05 PM
durin42 updated the diff for D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 12:03 PM
pulkit accepted D5612: fastannotate: slice strings to get single character.
Jan 16 2019, 12:02 PM
pulkit accepted D5611: fastannotate: fix isinstance checks to be against bytes instead of str.
Jan 16 2019, 12:02 PM
durin42 created D5615: py3: all fastannotate tests now pass.
Jan 16 2019, 11:58 AM
durin42 created D5614: fastannotate: adapt to buffer() going a way in Python 3.
Jan 16 2019, 11:57 AM
durin42 created D5613: fastannotate: use pycompat.maplist instead of map.
Jan 16 2019, 11:57 AM
durin42 created D5612: fastannotate: slice strings to get single character.
Jan 16 2019, 11:57 AM
durin42 created D5611: fastannotate: fix isinstance checks to be against bytes instead of str.
Jan 16 2019, 11:57 AM
pulkit accepted D5610: absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3.
Jan 16 2019, 11:55 AM
pulkit accepted D5609: remotefilelog: fix some bytes/str portability issues for Python 3.
Jan 16 2019, 11:49 AM
pulkit accepted D5608: shallowutil: fsdecode the bytes group name before passing to os.
Jan 16 2019, 11:48 AM
pulkit accepted D5607: shallowutil: slice off a byte instead of subscripting.
Jan 16 2019, 11:47 AM
pulkit accepted D5606: remotefilelog: check against bytes type instead of buffer and coerce to bytes.
Jan 16 2019, 11:45 AM
pulkit accepted D5605: remotefilelog: use list comprehension instead of filter for py3 portability.
Jan 16 2019, 11:44 AM
pulkit accepted D5604: tests: fix up uses of xrange in remotefilelog tests for py3.
Jan 16 2019, 11:44 AM
durin42 added a comment to D5602: tests: make python oneliner portable to python 3 in remotefilelog test.
In D5602#82808, @pulkit wrote:

It's weird that print works as a function too in Python 2.

Jan 16 2019, 11:44 AM
pulkit accepted D5603: tests: add missing b prefixes in remotefilelog-getflogheads.py.
Jan 16 2019, 11:42 AM
pulkit accepted D5602: tests: make python oneliner portable to python 3 in remotefilelog test.

It's weird that print works as a function too in Python 2.

Jan 16 2019, 11:42 AM
pulkit accepted D5601: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
Jan 16 2019, 11:40 AM
pulkit accepted D5600: remotefilelog: fix logging in retry decorator.
Jan 16 2019, 11:39 AM
pulkit added a comment to D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
In D5599#82802, @pulkit wrote:

Let's use pycompat.queue() for consistency.

Jan 16 2019, 11:38 AM
pulkit added a comment to D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.

Let's use pycompat.queue() for consistency.

Jan 16 2019, 11:38 AM
pulkit accepted D5598: basepack: avoid 'rbe' mode in Python 3.
Jan 16 2019, 11:36 AM
pulkit accepted D5597: remotefilelog: do file IO in terms of bytes.
Jan 16 2019, 11:35 AM
durin42 created D5610: absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3.
Jan 16 2019, 11:34 AM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 16 2019, 11:28 AM
martinvonz added a comment to D5510: narrow: reuse narrowspec.updateworkingcopy() when widening.
In D5510#82651, @yuja wrote:

Fixed pyflakes warnings in flight.

hgext/narrow/narrowcommands.py:13: 'mercurial.merge' imported but unused
hgext/narrow/narrowcommands.py:262: local variable 'newmatch' is assigned to but never used
Jan 16 2019, 11:25 AM
durin42 created D5609: remotefilelog: fix some bytes/str portability issues for Python 3.
Jan 16 2019, 11:16 AM
durin42 created D5608: shallowutil: fsdecode the bytes group name before passing to os.
Jan 16 2019, 11:16 AM
durin42 created D5607: shallowutil: slice off a byte instead of subscripting.
Jan 16 2019, 11:16 AM
durin42 created D5604: tests: fix up uses of xrange in remotefilelog tests for py3.
Jan 16 2019, 11:16 AM
durin42 created D5605: remotefilelog: use list comprehension instead of filter for py3 portability.
Jan 16 2019, 11:16 AM
durin42 created D5606: remotefilelog: check against bytes type instead of buffer and coerce to bytes.
Jan 16 2019, 11:16 AM
durin42 created D5602: tests: make python oneliner portable to python 3 in remotefilelog test.
Jan 16 2019, 11:16 AM
durin42 created D5603: tests: add missing b prefixes in remotefilelog-getflogheads.py.
Jan 16 2019, 11:16 AM
durin42 created D5601: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
Jan 16 2019, 11:16 AM
durin42 created D5600: remotefilelog: fix logging in retry decorator.
Jan 16 2019, 11:16 AM
durin42 created D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Jan 16 2019, 11:16 AM
durin42 created D5598: basepack: avoid 'rbe' mode in Python 3.
Jan 16 2019, 11:16 AM
durin42 created D5597: remotefilelog: do file IO in terms of bytes.
Jan 16 2019, 11:16 AM
gracinet added a comment to D5579: rust: factorized testing Graphs.

@yuja the doc you're linking is about integration tests, so it wouldn't apply to these tests which are really unitary in my mind. Usually the main difference would be the access to the private constructs that the integration tests can't perform, but it's true that most of these implementations are public anyway.

Jan 16 2019, 9:50 AM
yuja added a comment to D5493: match: support rooted globs in hgignore.

I haven't handled your other remark,

Jan 16 2019, 8:24 AM
yuja added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
> `[, samebranch]` or [, samebranch=False]`.
I guess that means:
@predicate('merge([withbranch [, samebranch=None]])', safe=True)
Right? (I realized that it is incorrect to say that samebranch's default value is False).
Jan 16 2019, 8:10 AM
gracinet closed D5551: rust-cpython: using MissingAncestors from Python code.
Jan 16 2019, 7:45 AM
gracinet closed D5584: rust: MissingAncestors.basesheads().
Jan 16 2019, 7:45 AM
gracinet committed rHGa89b20a49c13: rust-cpython: using MissingAncestors from Python code.
rust-cpython: using MissingAncestors from Python code
Jan 16 2019, 7:44 AM
gracinet committed rHG619ee4039bd4: rust: MissingAncestors.basesheads().
rust: MissingAncestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet committed rHG4856c9b8cbaf: ancestor: incrementalmissingancestors.basesheads().
ancestor: incrementalmissingancestors.basesheads()
Jan 16 2019, 7:44 AM