Feed All Stories

Jan 20 2019

yuja committed rHG13c23396c7fe: rust: add comment about lack of wdirrev handling.
rust: add comment about lack of wdirrev handling
Jan 20 2019, 12:53 AM
yuja committed rHG66102f6fa10a: templatekw: fix crash on multiple latesttags resolution at wdir (issue6055).
templatekw: fix crash on multiple latesttags resolution at wdir (issue6055)
Jan 20 2019, 12:53 AM
yuja committed rHGff1222a7d714: test-template-keywords: add test for {latesttag} of wdir() revision.
test-template-keywords: add test for {latesttag} of wdir() revision
Jan 20 2019, 12:53 AM

Jan 19 2019

martinvonz closed D5634: narrow: fix crash when restoring backup in legacy repo.
Jan 19 2019, 6:39 AM
martinvonz committed rHG88a7c211b21e: narrow: fix crash when restoring backup in legacy repo.
narrow: fix crash when restoring backup in legacy repo
Jan 19 2019, 6:39 AM
lothiraldan committed rHGb1ea90613af3: revset: introduce an internal `_rev` predicate for '%d' usage.
revset: introduce an internal `_rev` predicate for '%d' usage
Jan 19 2019, 6:30 AM
lothiraldan added a reverting commit for rHG74a9f428227e: mmapindex: set default to 1MB: rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
Jan 19 2019, 6:30 AM
lothiraldan committed rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
mmap: backed out changeset 74a9f428227e
Jan 19 2019, 6:30 AM
lothiraldan committed rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
mmap: backed out changeset 875d2af8cb4e
Jan 19 2019, 6:30 AM
lothiraldan added a reverting commit for rHG875d2af8cb4e: mmapindex: move the 'mmapindexthreshold' option out of experimental: rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
Jan 19 2019, 6:30 AM
mharbison72 committed rHGb5d7413e4009: help: document the minimumhgversion variable for extensions.
help: document the minimumhgversion variable for extensions
Jan 19 2019, 6:30 AM
mharbison72 committed rHG86f6b441adea: help: modernize the example for command registration.
help: modernize the example for command registration
Jan 19 2019, 6:30 AM
martinvonz added a comment to D5634: narrow: fix crash when restoring backup in legacy repo.

This is meant for the stable branch

Jan 19 2019, 2:53 AM
martinvonz created D5634: narrow: fix crash when restoring backup in legacy repo.
Jan 19 2019, 2:51 AM

Jan 18 2019

martinvonz created D5633: grep: use set instead of dict with dummy value.
Jan 18 2019, 2:19 PM
martinvonz updated the diff for D5620: grep: don't look up copy info unless --follow is given.
Jan 18 2019, 2:11 PM
durin42 committed rHG593718ff5844: merge default into stable for 4.9 release.
merge default into stable for 4.9 release
Jan 18 2019, 1:37 PM
durin42 committed rHG74525c3e9476: Added signature for changeset 593718ff5844.
Added signature for changeset 593718ff5844
Jan 18 2019, 1:37 PM
durin42 committed rHG9c290711e175: Added tag 4.9rc0 for changeset 593718ff5844.
Added tag 4.9rc0 for changeset 593718ff5844
Jan 18 2019, 1:37 PM
martinvonz added a reviewer for D5632: setdiscovery: pass srvheads into partialdiscovery constructor: lothiraldan.
Jan 18 2019, 1:21 PM
martinvonz created D5632: setdiscovery: pass srvheads into partialdiscovery constructor.
Jan 18 2019, 1:20 PM
yuja added a comment to D5594: copies: consider nullrev a common ancestor.
There are definitely repositories in the wild where p1 is nullrev (and p2 is not). It's unusual but expressable so, of course, it happened.

For that matters, there is also case with nullrev != p1 && p1 == p2.
Jan 18 2019, 9:01 AM
lothiraldan added a comment to D5594: copies: consider nullrev a common ancestor.
In D5594#83078, @yuja wrote:
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.

I agree with that, but I don't think every non-merge revision (p2 = null)
should be considered a direct child of null revision.

@@ -65,8 +63,6 @@

else:
    parents = cl.parentrevs(r)

Here parents[1] may be nullrev. Is that expected?

for p in parents:
  • if p < 0:
  • continue
Jan 18 2019, 8:25 AM
martinvonz closed D5626: scmutil: drop unreachable except clause.
Jan 18 2019, 7:36 AM
martinvonz closed D5625: tests: suppress "Checked out 1 paths of <hash>" from modern git.
Jan 18 2019, 7:36 AM
lothiraldan committed rHG593f6359681d: update: fix edge-case with update.atomic-file and read-only files.
update: fix edge-case with update.atomic-file and read-only files
Jan 18 2019, 7:36 AM
martinvonz committed rHG17941fc53ae9: scmutil: drop unreachable except clause.
scmutil: drop unreachable except clause
Jan 18 2019, 7:36 AM
martinvonz committed rHGc0221d929eb9: tests: suppress "Checked out 1 paths of <hash>" from modern git.
tests: suppress "Checked out 1 paths of <hash>" from modern git
Jan 18 2019, 7:36 AM
yuja added a comment to D5626: scmutil: drop unreachable except clause.
socket.error is a subclass of IOError, which we catch higher up. It
Jan 18 2019, 7:29 AM
yuja added a comment to D5594: copies: consider nullrev a common ancestor.
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.
Jan 18 2019, 7:14 AM
yuja committed rHG00b314c42094: revlog: document that mmap resources are released implicitly by GC.
revlog: document that mmap resources are released implicitly by GC
Jan 18 2019, 4:54 AM
yuja committed rHGcf8677cd7286: ui: proxy protect/restorestdio() calls to update internal flag.
ui: proxy protect/restorestdio() calls to update internal flag
Jan 18 2019, 4:54 AM
yuja committed rHGb0e3f2d7c143: ui: move protectedstdio() context manager from procutil.
ui: move protectedstdio() context manager from procutil
Jan 18 2019, 4:54 AM
yuja committed rHG4948b327d3b9: cext: clang-format new code coming from stable branch.
cext: clang-format new code coming from stable branch
Jan 18 2019, 4:54 AM
martinvonz updated the diff for D5629: cleanup: delete lots of unused local variables.
Jan 18 2019, 2:10 AM
martinvonz created D5631: hghave: let OSError with ENOENT through like any other.
Jan 18 2019, 2:08 AM
lothiraldan accepted D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

Jan 18 2019, 1:59 AM
martinvonz created D5630: remotefilelog: remove pointless return statement from constructor.
Jan 18 2019, 1:19 AM

Jan 17 2019

martinvonz created D5629: cleanup: delete lots of unused local variables.
Jan 17 2019, 1:29 PM
martinvonz updated the diff for D5620: grep: don't look up copy info unless --follow is given.
Jan 17 2019, 11:49 AM
lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...

The change seems reasonable though.

Jan 17 2019, 11:47 AM
lothiraldan added inline comments to D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 17 2019, 11:46 AM
lothiraldan added a comment to D5588: watchman: disable fsmonitor when running non-interactively.

Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from watchman.

Your commit message details an issue that I assume you encountered in the wild. Are there other ways we can work around this? Perhaps we can set the idle timeout/shutdown interval of watchman to be much smaller when Mercurial is non-interactive?

Jan 17 2019, 11:36 AM
lothiraldan added a comment to D5586: watchman: add verbose config knob.
In D5586#83031, @pulkit wrote:

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

I support introducing the config knob. But I don't like silently suppressing watchman errors that could lead to false user expectations.

I on +1 with what @indygreg said. These warning messages have proved much helpful for us internally.

Jan 17 2019, 11:29 AM
yuja added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
> Okay, I didn't notice that. And it's tricky to map `samebranch=False` to
>  "different branch" constraint. I would read it as "I don't care whether
>  the branches are the same or not."
>
> We can instead express it as `merge() - merge(samebranch=True)`.

Do you mean that the flag should only indicate whether you want to hide the same branch merges?
Jan 17 2019, 9:21 AM
yuja added a comment to D5579: rust: factorized testing Graphs.
@yuja the doc you're linking is about integration tests, so it wouldn't apply to these tests which are really unitary in my mind. Usually the main difference would be the access to the private constructs that the integration tests can't perform, but it's true that most of these implementations are public anyway.
Jan 17 2019, 9:21 AM
spectral closed D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Jan 17 2019, 8:43 AM
valentin.gatienbaron closed D5493: match: support rooted globs in hgignore.
Jan 17 2019, 8:42 AM
valentin.gatienbaron committed rHG4fab8a7d2d72: match: support rooted globs in hgignore.
match: support rooted globs in hgignore
Jan 17 2019, 8:42 AM
spectral committed rHG183df3df6031: resolve: fix mark-check when a file was deleted on one side (issue6020).
resolve: fix mark-check when a file was deleted on one side (issue6020)
Jan 17 2019, 8:42 AM
yuja added a comment to D5493: match: support rooted globs in hgignore.

Queued this, many thanks.

Jan 17 2019, 8:17 AM
yuja added a comment to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

Replaced all [[ -f ]] with [ -f ]. `[[]]` requires Bash.

Jan 17 2019, 8:17 AM
navaneeth.suresh created D5628: diffstat: make --git work properly on renames (issue6025).
Jan 17 2019, 7:46 AM
mharbison72 committed rHGc9e1104e6272: exthelper: drop the addattr() decorator.
exthelper: drop the addattr() decorator
Jan 17 2019, 7:10 AM
lothiraldan committed rHGf4277a35c42c: discovery: compute newly discovered missing in a more efficient way.
discovery: compute newly discovered missing in a more efficient way
Jan 17 2019, 7:10 AM
lothiraldan committed rHG61f9ef23a12f: dagop: minor python optimization to `headrevs`.
dagop: minor python optimization to `headrevs`
Jan 17 2019, 6:39 AM
lothiraldan committed rHG41f14e8f335f: revsetbenchmark: add more example for roots usages.
revsetbenchmark: add more example for roots usages
Jan 17 2019, 6:39 AM
lothiraldan committed rHG5affe1583e1d: revset: use changelog's `headrevs` method to compute heads.
revset: use changelog's `headrevs` method to compute heads
Jan 17 2019, 6:39 AM
lothiraldan committed rHG1421d0487a61: revlog: accept a revs argument in `headrevs`.
revlog: accept a revs argument in `headrevs`
Jan 17 2019, 6:39 AM
lothiraldan committed rHG4c6fdc7e2e7d: revset: inline parents computation to reuse the input argument.
revset: inline parents computation to reuse the input argument
Jan 17 2019, 6:39 AM
lothiraldan committed rHG71ef4e923886: revsetbenchmarks: support revset starting with a "-".
revsetbenchmarks: support revset starting with a "-"
Jan 17 2019, 6:39 AM
lothiraldan committed rHG5409f7ec7850: revsetbenchmarks: add various examples around the 'heads()' revset.
revsetbenchmarks: add various examples around the 'heads()' revset
Jan 17 2019, 6:39 AM
durin42 closed D5627: py3: two more passing tests from the ratchet.
Jan 17 2019, 5:21 AM
durin42 committed rHG774b5195fac6: py3: two more passing tests from the ratchet.
py3: two more passing tests from the ratchet
Jan 17 2019, 5:21 AM
martinvonz committed rHG8b7973d40a01: bdiff: drop duplicate definition of splitnewlines().
bdiff: drop duplicate definition of splitnewlines()
Jan 17 2019, 5:21 AM
durin42 committed rHG188880a3e87b: py3: test*gendoc*.t passes on Python 3.
py3: test*gendoc*.t passes on Python 3
Jan 17 2019, 5:21 AM
durin42 closed D5617: py3: test*gendoc*.t passes on Python 3.
Jan 17 2019, 5:21 AM
martinvonz closed D5618: bdiff: drop duplicate definition of splitnewlines().
Jan 17 2019, 5:21 AM
pulkit added a comment to D5586: watchman: add verbose config knob.

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

I support introducing the config knob. But I don't like silently suppressing watchman errors that could lead to false user expectations.

Jan 17 2019, 5:17 AM
pulkit added a comment to D5617: py3: test*gendoc*.t passes on Python 3.

Nice! Let's install docutils on Python 3 on buildbot too.

Jan 17 2019, 5:03 AM
durin42 abandoned D5619: tests: sort py3 whitelist to make test-check-code.t happy.
Jan 17 2019, 5:01 AM
durin42 commandeered D5619: tests: sort py3 whitelist to make test-check-code.t happy.
Jan 17 2019, 5:01 AM
durin42 added a comment to D5619: tests: sort py3 whitelist to make test-check-code.t happy.
In D5619#83024, @pulkit wrote:

This one does not apply anymore on tip of default branch.

Jan 17 2019, 5:01 AM
pulkit added a comment to D5619: tests: sort py3 whitelist to make test-check-code.t happy.

This one does not apply anymore on tip of default branch.

Jan 17 2019, 4:57 AM
pulkit accepted D5627: py3: two more passing tests from the ratchet.
Jan 17 2019, 4:53 AM
pulkit accepted D5618: bdiff: drop duplicate definition of splitnewlines().
Jan 17 2019, 4:51 AM
pulkit accepted D5619: tests: sort py3 whitelist to make test-check-code.t happy.
Jan 17 2019, 4:50 AM
mharbison72 committed rHG878084a495ef: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:41 AM
pulkit committed rHGe30eef62e743: py3: add 10 more passing tests caught by ratchet.
py3: add 10 more passing tests caught by ratchet
Jan 17 2019, 4:41 AM
durin42 created D5627: py3: two more passing tests from the ratchet.
Jan 17 2019, 4:35 AM
pulkit committed rHG5d332ef126f6: py3: add 11 more passing tests caught by ratchet.
py3: add 11 more passing tests caught by ratchet
Jan 17 2019, 4:35 AM
mharbison72 committed rHG8bde55072523: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:35 AM
martinvonz added a comment to D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

Jan 17 2019, 3:45 AM
lothiraldan added a comment to D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

Jan 17 2019, 3:41 AM
mharbison72 committed rHG6ffe7c15f75d: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 3:34 AM
martinvonz created D5626: scmutil: drop unreachable except clause.
Jan 17 2019, 12:50 AM
martinvonz created D5625: tests: suppress "Checked out 1 paths of <hash>" from modern git.
Jan 17 2019, 12:32 AM
martinvonz created D5622: localrepo: use context manager for transaction in commit().
Jan 17 2019, 12:29 AM
martinvonz created D5624: localrepo: use context manager for lock and transaction in commitctx().
Jan 17 2019, 12:28 AM
martinvonz created D5623: localrepo: use context manager for locks in commit().
Jan 17 2019, 12:28 AM
martinvonz created D5621: commit: print "commit message saved in" message also if bookmark update fails.
Jan 17 2019, 12:28 AM
martinvonz added a dependent revision for D5623: localrepo: use context manager for locks in commit(): D5624: localrepo: use context manager for lock and transaction in commitctx().
Jan 17 2019, 12:28 AM
martinvonz added a dependent revision for D5622: localrepo: use context manager for transaction in commit(): D5623: localrepo: use context manager for locks in commit().
Jan 17 2019, 12:28 AM
martinvonz added a dependent revision for D5621: commit: print "commit message saved in" message also if bookmark update fails: D5622: localrepo: use context manager for transaction in commit().
Jan 17 2019, 12:28 AM

Jan 16 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Alright, I think I did what you asked for.

Jan 16 2019, 11:30 PM
martinvonz created D5620: grep: don't look up copy info unless --follow is given.
Jan 16 2019, 8:23 PM
martinvonz created D5619: tests: sort py3 whitelist to make test-check-code.t happy.
Jan 16 2019, 8:22 PM
martinvonz created D5618: bdiff: drop duplicate definition of splitnewlines().
Jan 16 2019, 8:09 PM
indygreg accepted D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...

Jan 16 2019, 4:33 PM
indygreg added a comment to D5589: watchman: add the possibility to set the exact watchman binary location.

Overall I like the feature. But the class initialization logic is wonky. That's not your fault: you happen to be wading into a mess. Since it looks like there will be a v2 on this series, I'd encourage you to add some inline comments about the __init__ mess at the least, or ideally refactor it so the code is cleaner.

Jan 16 2019, 4:32 PM