The changes looks okay but I can't think why you want to do that. Can you add some details about the motivation for this change to commit message?

Amending the following diff in flight:

In D6356#92695, @sangeet259 wrote:

In D6356#92644, @pulkit wrote:

Why do I need to split the patches into two ?
The reason to split what would have been a single patch into two is because
for the next patch to be able to use the mdiff during tests,
this revision has to be there in the system's mercurial installation.

I didn't get the last line. Can you explain more?

I think both can be folded in one and should be good.

@pulkit
Well the next patch imports mercurial and then calls mdff.new_diff . If I combine those two patches then you can not see the change as while testing D6359 , if there mdiff doesn't already have new_diff
it will always fall back to unified_diff as happened with @durin42 , while he was trying to see the alternate path as he trying to test D5514 .

What I am trying to do here is, once D6356 is has added new_diff to mdiff, you can then have this revision installed in your system or wherever one tests this, and then check D6359 to see the alternate path it follows.

The commit message has diff which confuses hg import. You need to indent those diffs.

Patch 1/2

This fails to apply cleanly on tip of default.

Why do I need to split the patches into two ?
The reason to split what would have been a single patch into two is because
for the next patch to be able to use the mdiff during tests,
this revision has to be there in the system's mercurial installation.

Queuing this, many thanks!

Queueing this, many thanks!

Also, this patch is meant for stable branch.

In D6297#91657, @Kwan wrote:

In D6297#91618, @pulkit wrote:

wow, does it work?

For future posterity, since I already replied to pulkit on IRC, this won't make Phab display the branch in the web UI anywhere (still need to use creatediff API for that), but D6302 makes phabread use this to include the branch in its hg importable output.

In D6310#91785, @indygreg wrote:

Ideally the new part would be documented in internals.bundle2. But other narrow parts aren't documented, so maybe we can hold off...

I created a new version at D6310.

This is a new version of https://phab.mercurial-scm.org/D6218. I updated that one but it was not showing in Yadda as that's already marked as closed. So creating a new one.