Feed Advanced Search

Thu, Jan 17

pulkit added a comment to D5586: watchman: add verbose config knob.

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

I support introducing the config knob. But I don't like silently suppressing watchman errors that could lead to false user expectations.

Thu, Jan 17, 5:17 AM
pulkit added a comment to D5617: py3: test*gendoc*.t passes on Python 3.

Nice! Let's install docutils on Python 3 on buildbot too.

Thu, Jan 17, 5:03 AM
pulkit added a comment to D5619: tests: sort py3 whitelist to make test-check-code.t happy.

This one does not apply anymore on tip of default branch.

Thu, Jan 17, 4:57 AM
pulkit accepted D5627: py3: two more passing tests from the ratchet.
Thu, Jan 17, 4:53 AM
pulkit accepted D5618: bdiff: drop duplicate definition of splitnewlines().
Thu, Jan 17, 4:51 AM
pulkit accepted D5619: tests: sort py3 whitelist to make test-check-code.t happy.
Thu, Jan 17, 4:50 AM
pulkit committed rHGe30eef62e743: py3: add 10 more passing tests caught by ratchet.
py3: add 10 more passing tests caught by ratchet
Thu, Jan 17, 4:41 AM
pulkit committed rHG5d332ef126f6: py3: add 11 more passing tests caught by ratchet.
py3: add 11 more passing tests caught by ratchet
Thu, Jan 17, 4:35 AM

Wed, Jan 16

pulkit committed rHG9eb8c54471b9: py3: add 11 more passing tests caught by ratchet.
py3: add 11 more passing tests caught by ratchet
Wed, Jan 16, 3:54 PM
pulkit closed D5616: py3: add 11 more passing tests caught by ratchet.
Wed, Jan 16, 3:54 PM
pulkit created D5616: py3: add 11 more passing tests caught by ratchet.
Wed, Jan 16, 1:44 PM
pulkit accepted D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
Wed, Jan 16, 12:13 PM
pulkit accepted D5615: py3: all fastannotate tests now pass.
Wed, Jan 16, 12:07 PM
pulkit accepted D5614: fastannotate: adapt to buffer() going a way in Python 3.
Wed, Jan 16, 12:07 PM
pulkit accepted D5613: fastannotate: use pycompat.maplist instead of map.
Wed, Jan 16, 12:05 PM
pulkit accepted D5612: fastannotate: slice strings to get single character.
Wed, Jan 16, 12:02 PM
pulkit accepted D5611: fastannotate: fix isinstance checks to be against bytes instead of str.
Wed, Jan 16, 12:02 PM
pulkit accepted D5610: absorb: add a pycompat.bytestr() to fix --edit-lines functionality on Python 3.
Wed, Jan 16, 11:55 AM
pulkit accepted D5609: remotefilelog: fix some bytes/str portability issues for Python 3.
Wed, Jan 16, 11:49 AM
pulkit accepted D5608: shallowutil: fsdecode the bytes group name before passing to os.
Wed, Jan 16, 11:48 AM
pulkit accepted D5607: shallowutil: slice off a byte instead of subscripting.
Wed, Jan 16, 11:47 AM
pulkit accepted D5606: remotefilelog: check against bytes type instead of buffer and coerce to bytes.
Wed, Jan 16, 11:45 AM
pulkit accepted D5605: remotefilelog: use list comprehension instead of filter for py3 portability.
Wed, Jan 16, 11:44 AM
pulkit accepted D5604: tests: fix up uses of xrange in remotefilelog tests for py3.
Wed, Jan 16, 11:44 AM
pulkit accepted D5603: tests: add missing b prefixes in remotefilelog-getflogheads.py.
Wed, Jan 16, 11:42 AM
pulkit accepted D5602: tests: make python oneliner portable to python 3 in remotefilelog test.

It's weird that print works as a function too in Python 2.

Wed, Jan 16, 11:42 AM
pulkit accepted D5601: remotefilelog: implement __bool__ as well as __nonzero__ for py3.
Wed, Jan 16, 11:40 AM
pulkit accepted D5600: remotefilelog: fix logging in retry decorator.
Wed, Jan 16, 11:39 AM
pulkit added a comment to D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.
In D5599#82802, @pulkit wrote:

Let's use pycompat.queue() for consistency.

Wed, Jan 16, 11:38 AM
pulkit added a comment to D5599: remotefilelog: import Queue on Python 2, and queue on Python 3.

Let's use pycompat.queue() for consistency.

Wed, Jan 16, 11:38 AM
pulkit accepted D5598: basepack: avoid 'rbe' mode in Python 3.
Wed, Jan 16, 11:36 AM
pulkit accepted D5597: remotefilelog: do file IO in terms of bytes.
Wed, Jan 16, 11:35 AM
pulkit accepted D5593: copies: use node.nullrev instead of literal -1.
Wed, Jan 16, 2:51 AM
pulkit accepted D5592: copies: use node.wdirrev instead of inventing another constant for it.
Wed, Jan 16, 2:48 AM
pulkit added a comment to D5531: progress: deprecate ui.progress().

Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that.

Wed, Jan 16, 2:42 AM
pulkit accepted D5508: narrow: extract repo property for store narrowmatcher.
Wed, Jan 16, 2:29 AM
pulkit accepted D5506: narrow: copy store narrowspec to working copy immediately.
Wed, Jan 16, 2:23 AM
pulkit accepted D5505: narrow: include working copy narrowspec in transaction journal.
Wed, Jan 16, 2:21 AM
pulkit accepted D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead.
Wed, Jan 16, 2:18 AM
pulkit accepted D5556: narrow: include journal.narrowspec in transaction journal.
Wed, Jan 16, 2:14 AM
pulkit accepted D5531: progress: deprecate ui.progress().
Wed, Jan 16, 2:02 AM

Fri, Jan 11

pulkit committed rHG8d0d695fc791: py3: add a test to whitelist caught by buildbot.
py3: add a test to whitelist caught by buildbot
Fri, Jan 11, 7:53 AM
pulkit closed D5555: py3: add a test to whitelist caught by buildbot.
Fri, Jan 11, 7:53 AM

Thu, Jan 10

pulkit accepted D5512: narrow: use merge.ACTION_GET instead of duplicating 'g' constant.
Thu, Jan 10, 2:10 PM
pulkit added inline comments to D5505: narrow: include working copy narrowspec in transaction journal.
Thu, Jan 10, 1:54 PM
pulkit added a comment to D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead.

This one removes clearbackup() while restorebackup() and savebackup() are still there. Does that means that we are sure that we won't need to manually clear the backup from store?

Thu, Jan 10, 1:52 PM
pulkit accepted D5515: narrow: drop explicit dirstate write.
Thu, Jan 10, 1:43 PM
pulkit created D5555: py3: add a test to whitelist caught by buildbot.
Thu, Jan 10, 12:52 PM

Wed, Jan 9

pulkit closed D5413: manifest: convert a recursive function to iterative one using stacks.
Wed, Jan 9, 3:10 PM
pulkit committed rHG2c3f69855ce8: manifest: convert a recursive function to iterative one using stacks.
manifest: convert a recursive function to iterative one using stacks
Wed, Jan 9, 3:10 PM
pulkit added a comment to D5494: histedit: add user input to warning message on editing tagged commits.

Sorry for bumping on this now, can you add tests for this as follow-up?

Wed, Jan 9, 3:03 PM
pulkit closed D5481: sparse: fix debugrebuilddirsate when narrow extension is enabled.
Wed, Jan 9, 2:48 PM
pulkit closed D5480: tests: show that debugrebuilddirstate is broken with narrow+sparse.
Wed, Jan 9, 2:48 PM
pulkit committed rHGb05eb98a6b67: sparse: fix debugrebuilddirsate when narrow extension is enabled.
sparse: fix debugrebuilddirsate when narrow extension is enabled
Wed, Jan 9, 2:48 PM
pulkit committed rHG76dcf7958c5f: tests: show that debugrebuilddirstate is broken with narrow+sparse.
tests: show that debugrebuilddirstate is broken with narrow+sparse
Wed, Jan 9, 2:48 PM
pulkit closed D5479: sparse: don't enable on clone if it was a narrow clone.
Wed, Jan 9, 2:48 PM
pulkit closed D5478: tests: add tests for narrow clone when both sparse and narrow are enabled.
Wed, Jan 9, 2:48 PM
pulkit committed rHG8eaf693b1409: sparse: don't enable on clone if it was a narrow clone.
sparse: don't enable on clone if it was a narrow clone
Wed, Jan 9, 2:47 PM
pulkit committed rHGeb172f9c208c: tests: add tests for narrow clone when both sparse and narrow are enabled.
tests: add tests for narrow clone when both sparse and narrow are enabled
Wed, Jan 9, 2:47 PM
pulkit accepted D5525: xdiff: don't attempt to use fuzzer inputs larger than 100k.
Wed, Jan 9, 3:56 AM

Tue, Jan 8

pulkit accepted D5526: progress: document progress.debug config option.
Tue, Jan 8, 2:06 PM
pulkit added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.

If you couldn't follow those steps, you can simply check the diffs here:

test's diff: https://pastebin.com/Z4LRg4vx
diff used by hg diff: https://pastebin.com/qanQEsiA

Tue, Jan 8, 12:27 PM
pulkit added a comment to D5495: revset: add "branch" positional arguments to the merge revset.
In D5495#81562, @yuja wrote:

+@predicate('merge(*withbranch)', safe=True)

def merge(repo, subset, x):
  • """Changeset is a merge changeset. + """Changeset is a merge changeset + + All merge revisions are returned by default. If one or more "withbranch" + names are provided only merges with those branches (i.e. whose + second parent belongs to one of those branches) will be returned.

I understand this will be useful in a certain branch strategy, but the
proposed syntax is hardly extensible. Maybe it can be a non-wildcard argument
of stringmatcher type so we can at least add another option later.

Any thoughts? Do anyone love this feature?

Tue, Jan 8, 7:05 AM
pulkit accepted D5522: tests: migrate test-wireproto-serverreactor.py to our internal CBOR.
Tue, Jan 8, 6:58 AM
pulkit accepted D5518: state: update comment about use of CBOR.
Tue, Jan 8, 6:57 AM

Mon, Jan 7

pulkit added a comment to D5513: amend: concise logic for rewrite.updatetimestamp.

Thanks for the quick follow-up. Yuya did it better and I pushed his patches which can be found at https://www.mercurial-scm.org/repo/hg-committed/rev/b153a4aa06f8 and https://www.mercurial-scm.org/repo/hg-committed/rev/cffa8e0ba77a. This one can be abandoned.

Mon, Jan 7, 9:34 AM
pulkit closed D5484: pull: use opts.get('bookmark') instead of opts['bookmark'].
Mon, Jan 7, 7:19 AM
pulkit committed rHG5967995c32bb: pull: use opts.get('bookmark') instead of opts['bookmark'].
pull: use opts.get('bookmark') instead of opts['bookmark']
Mon, Jan 7, 7:19 AM
pulkit updated the diff for D5484: pull: use opts.get('bookmark') instead of opts['bookmark'].
Mon, Jan 7, 6:40 AM
pulkit added a comment to D5478: tests: add tests for narrow clone when both sparse and narrow are enabled.

Ping for review!

Mon, Jan 7, 6:36 AM
pulkit accepted D5491: amend: added config option to update time to current in hg amend(issue5828).

Queueing this, many thanks!

Mon, Jan 7, 6:15 AM
pulkit accepted D5502: tests: correct version check in clientreactor test.
Mon, Jan 7, 5:32 AM
pulkit accepted D5501: py3: buildbot spotted more passing tests.
Mon, Jan 7, 5:31 AM
pulkit accepted D5500: tests: add lots of b prefix goo to test-fastannotate-revmap.py.
Mon, Jan 7, 5:31 AM
pulkit accepted D5499: fastannotate: add a missing b prefix.
Mon, Jan 7, 5:30 AM
pulkit added a comment to D5498: server: always close http socket if responding with an error (issue6033).

Is this meant for stable?

Mon, Jan 7, 5:27 AM
pulkit accepted D5498: server: always close http socket if responding with an error (issue6033).
Mon, Jan 7, 5:24 AM

Sat, Jan 5

pulkit added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

Nice work! Can you update description of this patch with details in commit message about behavior of the new config option and how it solves the given issue?

Sat, Jan 5, 2:44 PM

Fri, Jan 4

pulkit added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that.

Fri, Jan 4, 12:28 PM
pulkit added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

no the date is updated in 2560. So below that it wont work

Fri, Jan 4, 11:33 AM
pulkit added inline comments to D5491: amend: added config option to update time to current in hg amend(issue5828).
Fri, Jan 4, 10:37 AM
pulkit added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

Nice! I left an inline comment.

Fri, Jan 4, 8:39 AM
pulkit added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

The patch is going in a good direction. We now need to make sure that we don't amend if date is the only thing which has changed.

Fri, Jan 4, 5:45 AM

Wed, Jan 2

pulkit added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

Hi, thanks for the patch.

Wed, Jan 2, 8:14 AM
pulkit added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

@yuja Can this be closed?

Wed, Jan 2, 7:23 AM

Thu, Dec 27

pulkit updated the diff for D5484: pull: use opts.get('bookmark') instead of opts['bookmark'].
Thu, Dec 27, 7:54 AM
pulkit added inline comments to D5484: pull: use opts.get('bookmark') instead of opts['bookmark'].
Thu, Dec 27, 7:16 AM

Wed, Dec 26

pulkit added a comment to D5408: progress: avoid ui.configbool() lookup when progress bar is active.

It turned out to be important optimization for us. Since it's holiday in US, I updated this with Yuya's comment.

Wed, Dec 26, 12:08 PM
pulkit updated the diff for D5408: progress: avoid ui.configbool() lookup when progress bar is active.
Wed, Dec 26, 12:06 PM
pulkit created D5484: pull: use opts.get('bookmark') instead of opts['bookmark'].
Wed, Dec 26, 9:44 AM

Dec 24 2018

pulkit created D5481: sparse: fix debugrebuilddirsate when narrow extension is enabled.
Dec 24 2018, 8:19 AM
pulkit added a dependent revision for D5480: tests: show that debugrebuilddirstate is broken with narrow+sparse: D5481: sparse: fix debugrebuilddirsate when narrow extension is enabled.
Dec 24 2018, 8:19 AM
pulkit created D5480: tests: show that debugrebuilddirstate is broken with narrow+sparse.
Dec 24 2018, 8:19 AM
pulkit added a dependent revision for D5479: sparse: don't enable on clone if it was a narrow clone: D5480: tests: show that debugrebuilddirstate is broken with narrow+sparse.
Dec 24 2018, 8:19 AM
pulkit created D5479: sparse: don't enable on clone if it was a narrow clone.
Dec 24 2018, 8:19 AM
pulkit added a dependent revision for D5478: tests: add tests for narrow clone when both sparse and narrow are enabled: D5479: sparse: don't enable on clone if it was a narrow clone.
Dec 24 2018, 8:18 AM
pulkit created D5478: tests: add tests for narrow clone when both sparse and narrow are enabled.
Dec 24 2018, 8:18 AM
pulkit updated subscribers of D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

Didn't looked at the code in detail yet, but this patch needs tests.

Dec 24 2018, 6:54 AM

Dec 23 2018

pulkit added a comment to D5475: branch:Added option to show branch name of a given rev (Issue5948).
In D5475#81060, @yuja wrote:
_('set branch name even if it shadows an existing branch')),
('C', 'clean', None, _('reset branch name to parent branch name')),
('r', 'rev', [], _('change branches of the given revs (EXPERIMENTAL)')),

+ ('s', 'show', None, _('show branch name of the given rev'))

],
_('[-fC] [NAME]'),
helpcategory=command.CATEGORY_CHANGE_ORGANIZATION)

@@ -1097,6 +1098,11 @@

ui.write("%s\n" % repo.dirstate.branch())
return

+ elif opts.get('show') and label:
+ ctx = scmutil.revsingle(repo, label)
+ ui.write("%s\n" % ctx.branch())
+ return

How about adding the -r/--rev option to the branches command instead?

I came to this idea while working on the issue4505, tag sorting. I haven't sent
the patch yet because I noticed we would also want to sort tags
lexicographically, which can't be achieved by the revset. But at least, tags,
branches, and bookmarks can be filtered by the -r/--rev option.

https://bz.mercurial-scm.org/show_bug.cgi?id=4505

branch, tag, and bookmark (without -l) are basically the commands to mutate
the repository, and the -r option of the branch command is highly experimental.
IIRC, @pulkit regrets of adding branch -r.

Dec 23 2018, 9:14 AM

Dec 21 2018

pulkit committed rHG9f06cd72cccb: contrib: remove unused version of os.
contrib: remove unused version of os
Dec 21 2018, 9:47 PM