Feed Advanced Search

Today

pulkit committed rHG868bb2821e29: py3: replace file() with open() in test-convert-git.t.
py3: replace file() with open() in test-convert-git.t
Sat, Feb 17, 7:43 AM
pulkit closed D2133: py3: replace file() with open() in test-convert-git.t.
Sat, Feb 17, 7:43 AM
pulkit updated the diff for D2133: py3: replace file() with open() in test-convert-git.t.
Sat, Feb 17, 5:27 AM
pulkit created D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str.
Sat, Feb 17, 5:03 AM
pulkit added a comment to D2295: py3: get bytes-repr of network errors portably.

For converting error messages to bytes, util.forcebytestr() is preferred. https://phab.mercurial-scm.org/D2269#inline-5791

Sat, Feb 17, 4:43 AM
pulkit accepted D2294: hgweb: open server logs in binary mode.
Sat, Feb 17, 4:40 AM
pulkit accepted D2293: tests: add some b prefixes in test-http-bundle1.t.
Sat, Feb 17, 4:40 AM
pulkit added a comment to D2292: scmutil: bytes-ify IOErrors before wrapping them in abort message.

It's recommended using util.forcebytestr() to convert error messages to bytes. https://phab.mercurial-scm.org/D2269#inline-5791

Sat, Feb 17, 4:39 AM
pulkit accepted D2291: hgweb: correctly bytes-ify status, not string-ify.
Sat, Feb 17, 4:37 AM
pulkit accepted D2290: printenv: port to python3.
Sat, Feb 17, 4:36 AM

Yesterday

pulkit updated the diff for D2277: remotenames: don't use the default value of logfmt for namespaces.
Fri, Feb 16, 7:33 AM

Thu, Feb 15

pulkit requested changes to D2281: py3: whitelist another eight passing tests.
Thu, Feb 15, 12:44 PM
pulkit closed D2269: py3: use util.forcebytestr instead of str for converting errors to bytes.
Thu, Feb 15, 7:40 AM
pulkit committed rHG6ea0b78ddcac: py3: use util.forcebytestr instead of str for converting errors to bytes.
py3: use util.forcebytestr instead of str for converting errors to bytes
Thu, Feb 15, 7:40 AM
pulkit closed D2261: py3: use pycompat.bytestr to convert str to bytes.
Thu, Feb 15, 7:40 AM
pulkit committed rHGddeb7653b31c: py3: use pycompat.bytestr to convert str to bytes.
py3: use pycompat.bytestr to convert str to bytes
Thu, Feb 15, 7:40 AM
pulkit created D2277: remotenames: don't use the default value of logfmt for namespaces.
Thu, Feb 15, 7:02 AM
pulkit added a comment to D2108: infinitepush: drop the `--to` flag to push and use `-B` instead.

I'm find with you sending more parts to this series. Especially if they delete code: if they delete code then my review of the import will be a review of the final state of the code post deletions.

Thu, Feb 15, 5:18 AM
pulkit added a comment to D2096: infinitepush: move the extension to core from fb-hgext.

I see the following high-level potential use cases for infinitepush:

  1. A hosting/repo management alternative to forks
  2. A central repository for submitting changesets to a service (e.g. code review, a "try" repo to trigger CI, etc)
  3. As a backup mechanism
Thu, Feb 15, 5:14 AM

Wed, Feb 14

pulkit abandoned D1143: revset: update visibility exceptions with hidden commits from the tree.
Wed, Feb 14, 11:26 AM
pulkit updated the diff for D2261: py3: use pycompat.bytestr to convert str to bytes.
Wed, Feb 14, 11:26 AM
pulkit updated the diff for D2269: py3: use util.forcebytestr instead of str for converting errors to bytes.
Wed, Feb 14, 11:26 AM
pulkit closed D2271: py3: slice over bytes to prevent getting ascii values.
Wed, Feb 14, 8:43 AM
pulkit closed D2264: py3: use pycompat.bytestr instead of str.
Wed, Feb 14, 8:43 AM
pulkit committed rHGeb91ffdaaece: py3: slice over bytes to prevent getting ascii values.
py3: slice over bytes to prevent getting ascii values
Wed, Feb 14, 8:43 AM
pulkit closed D2263: py3: use "%d" to convert integers to bytes.
Wed, Feb 14, 8:43 AM
pulkit closed D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py.
Wed, Feb 14, 8:43 AM
pulkit committed rHG80301c90a2dc: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating.
py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating
Wed, Feb 14, 8:43 AM
pulkit closed D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating.
Wed, Feb 14, 8:43 AM
pulkit committed rHG7fda2a8ed24e: py3: use pycompat.{bytes|str}kwargs in transplant.py.
py3: use pycompat.{bytes|str}kwargs in transplant.py
Wed, Feb 14, 8:43 AM
pulkit closed D2267: py3: replace file() with open() in transplant.py.
Wed, Feb 14, 8:43 AM
pulkit committed rHG2f309b8846cf: py3: replace file() with open() in transplant.py.
py3: replace file() with open() in transplant.py
Wed, Feb 14, 8:43 AM
pulkit closed D2266: py3: use "%d" for converting int to bytes in transplant.py.
Wed, Feb 14, 8:43 AM
pulkit committed rHG4e33aa8639d0: py3: use "%d" for converting int to bytes in transplant.py.
py3: use "%d" for converting int to bytes in transplant.py
Wed, Feb 14, 8:42 AM
pulkit closed D2265: py3: open files in bytes mode in transplant.py.
Wed, Feb 14, 8:42 AM
pulkit committed rHGa9d1ac7b91a8: py3: open files in bytes mode in transplant.py.
py3: open files in bytes mode in transplant.py
Wed, Feb 14, 8:42 AM
pulkit committed rHGc1628a5eac87: py3: use pycompat.bytestr instead of str.
py3: use pycompat.bytestr instead of str
Wed, Feb 14, 8:42 AM
pulkit committed rHGacc8e6e52af6: py3: use "%d" to convert integers to bytes.
py3: use "%d" to convert integers to bytes
Wed, Feb 14, 8:42 AM
pulkit closed D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py.
Wed, Feb 14, 8:42 AM
pulkit committed rHG56635c506608: py3: add couple of missing b'' in fakemergerecord.py.
py3: add couple of missing b'' in fakemergerecord.py
Wed, Feb 14, 8:42 AM
pulkit closed D2262: py3: add couple of missing b'' in fakemergerecord.py.
Wed, Feb 14, 8:42 AM
pulkit committed rHG44a519ec5077: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py.
py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py
Wed, Feb 14, 8:42 AM
pulkit closed D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t.
Wed, Feb 14, 8:42 AM
pulkit closed D2258: py3: add b'' prefixes in test-worker.t.
Wed, Feb 14, 8:42 AM
pulkit committed rHG4f0439981a8a: py3: add b'' prefixes in test-worker.t.
py3: add b'' prefixes in test-worker.t
Wed, Feb 14, 8:42 AM
pulkit committed rHGf1addba385e5: py3: add b'' prefixes to make printrevset.py work in test-glog.t.
py3: add b'' prefixes to make printrevset.py work in test-glog.t
Wed, Feb 14, 8:42 AM
pulkit closed D2256: py3: slice over bytes to prevent getting ascii values.
Wed, Feb 14, 8:42 AM
pulkit committed rHG34e850440271: py3: slice over bytes to prevent getting ascii values.
py3: slice over bytes to prevent getting ascii values
Wed, Feb 14, 8:42 AM
pulkit created D2271: py3: slice over bytes to prevent getting ascii values.
Wed, Feb 14, 7:37 AM
pulkit added a dependent revision for D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating: D2271: py3: slice over bytes to prevent getting ascii values.
Wed, Feb 14, 7:36 AM
pulkit created D2269: py3: use util.forcebytestr instead of str for converting errors to bytes.
Wed, Feb 14, 7:36 AM
pulkit created D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating.
Wed, Feb 14, 7:36 AM
pulkit added a dependent revision for D2269: py3: use util.forcebytestr instead of str for converting errors to bytes: D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating.
Wed, Feb 14, 7:36 AM
pulkit added a dependent revision for D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py: D2269: py3: use util.forcebytestr instead of str for converting errors to bytes.
Wed, Feb 14, 7:36 AM
pulkit created D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py.
Wed, Feb 14, 7:36 AM
pulkit added a dependent revision for D2267: py3: replace file() with open() in transplant.py: D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py.
Wed, Feb 14, 7:36 AM
pulkit created D2267: py3: replace file() with open() in transplant.py.
Wed, Feb 14, 7:36 AM
pulkit added a dependent revision for D2266: py3: use "%d" for converting int to bytes in transplant.py: D2267: py3: replace file() with open() in transplant.py.
Wed, Feb 14, 7:36 AM
pulkit created D2264: py3: use pycompat.bytestr instead of str.
Wed, Feb 14, 7:36 AM
pulkit created D2266: py3: use "%d" for converting int to bytes in transplant.py.
Wed, Feb 14, 7:36 AM
pulkit added a dependent revision for D2265: py3: open files in bytes mode in transplant.py: D2266: py3: use "%d" for converting int to bytes in transplant.py.
Wed, Feb 14, 7:35 AM
pulkit created D2265: py3: open files in bytes mode in transplant.py.
Wed, Feb 14, 7:35 AM
pulkit added a dependent revision for D2264: py3: use pycompat.bytestr instead of str: D2265: py3: open files in bytes mode in transplant.py.
Wed, Feb 14, 7:35 AM
pulkit added a dependent revision for D2263: py3: use "%d" to convert integers to bytes: D2264: py3: use pycompat.bytestr instead of str.
Wed, Feb 14, 7:35 AM
pulkit created D2263: py3: use "%d" to convert integers to bytes.
Wed, Feb 14, 7:35 AM
pulkit added a dependent revision for D2261: py3: use pycompat.bytestr to convert str to bytes: D2262: py3: add couple of missing b'' in fakemergerecord.py.
Wed, Feb 14, 6:25 AM
pulkit created D2262: py3: add couple of missing b'' in fakemergerecord.py.
Wed, Feb 14, 6:25 AM
pulkit created D2261: py3: use pycompat.bytestr to convert str to bytes.
Wed, Feb 14, 6:25 AM
pulkit added a dependent revision for D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py: D2261: py3: use pycompat.bytestr to convert str to bytes.
Wed, Feb 14, 6:25 AM
pulkit created D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py.
Wed, Feb 14, 6:25 AM
pulkit added a dependent revision for D2259: py3: use pycompat.bytestr to convert int/bytes to bytes: D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py.
Wed, Feb 14, 6:25 AM
pulkit created D2259: py3: use pycompat.bytestr to convert int/bytes to bytes.
Wed, Feb 14, 6:25 AM
pulkit added a dependent revision for D2258: py3: add b'' prefixes in test-worker.t: D2259: py3: use pycompat.bytestr to convert int/bytes to bytes.
Wed, Feb 14, 6:25 AM
pulkit created D2258: py3: add b'' prefixes in test-worker.t.
Wed, Feb 14, 6:24 AM
pulkit added a dependent revision for D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t: D2258: py3: add b'' prefixes in test-worker.t.
Wed, Feb 14, 6:24 AM
pulkit created D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t.
Wed, Feb 14, 6:24 AM
pulkit added a dependent revision for D2256: py3: slice over bytes to prevent getting ascii values: D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t.
Wed, Feb 14, 6:24 AM
pulkit created D2256: py3: slice over bytes to prevent getting ascii values.
Wed, Feb 14, 6:24 AM
pulkit added inline comments to D1758: remotenames: add new namespaces for remotebookmarks and remotebranches.
Wed, Feb 14, 5:04 AM
pulkit added inline comments to D2253: releasenotes: mention changeset with warning and abort.
Wed, Feb 14, 5:04 AM
pulkit added a comment to D2255: releasenotes: replace abort with warning while parsing.

This one is a bugfix, so please add the issue number in the commit message. Also add related tests as that will help make sure we don't encounter such problems again in future.

Wed, Feb 14, 5:01 AM
pulkit added a comment to D2254: releasenotes: allow notes for multiple directives in a single changeset.

Can you add tests showing what the new behavior is? The correct behavior should be to include multiple directives in the notes correctly.

Wed, Feb 14, 4:59 AM
pulkit added a comment to D2253: releasenotes: mention changeset with warning and abort.

I think ordering on the patches here is wrong. D2255 seems to be parent of this one. Also can you add related tests?

Wed, Feb 14, 4:58 AM

Tue, Feb 13

pulkit closed D2002: remotenames: add three new revsets related to remotenames.
Tue, Feb 13, 10:19 AM
pulkit committed rHG828f44cdfee3: remotenames: add three new revsets related to remotenames.
remotenames: add three new revsets related to remotenames
Tue, Feb 13, 10:19 AM
pulkit added a comment to D2200: hg: move share._getsrcrepo into core.

Fb's hg-experimental also uses a utility module just for this function, so I am +1 on moving this to core. https://bitbucket.org/facebook/hg-experimental/src/f27f094e91553d3cae5167c0b1c42ae940f888d5/hgext3rd/shareutil.py

Tue, Feb 13, 4:19 AM
pulkit accepted D2199: tests: glob over line number.
Tue, Feb 13, 4:13 AM

Mon, Feb 12

pulkit closed D1759: remotenames: introduce new template keywords for remotenames.
Mon, Feb 12, 4:33 PM
pulkit closed D1758: remotenames: add new namespaces for remotebookmarks and remotebranches.
Mon, Feb 12, 4:33 PM
pulkit committed rHG5a53af7d09aa: remotenames: introduce new template keywords for remotenames.
remotenames: introduce new template keywords for remotenames
Mon, Feb 12, 4:33 PM
pulkit committed rHG382aefea8faf: remotenames: add new namespaces for remotebookmarks and remotebranches.
remotenames: add new namespaces for remotebookmarks and remotebranches
Mon, Feb 12, 4:33 PM
pulkit closed D1756: remotenames: introduce class to encapsulate remotenames info in an extension.
Mon, Feb 12, 4:33 PM
pulkit committed rHGcabe8ef5c71e: remotenames: introduce class to encapsulate remotenames info in an extension.
remotenames: introduce class to encapsulate remotenames info in an extension
Mon, Feb 12, 4:33 PM
pulkit committed rHGbe72f6420f3c: remotenames: introduce a class to lazily resolve remotnames.
remotenames: introduce a class to lazily resolve remotnames
Mon, Feb 12, 4:33 PM
pulkit closed D1757: remotenames: introduce a class to lazily resolve remotnames.
Mon, Feb 12, 4:33 PM
pulkit committed rHG62a428bf6359: logexchange: introduce helper function to get remote path name.
logexchange: introduce helper function to get remote path name
Mon, Feb 12, 4:33 PM
pulkit closed D1755: logexchange: introduce helper function to get remote path name.
Mon, Feb 12, 4:33 PM
pulkit closed D2132: py3: replace file() with open() in test-convert-hg-source.t.
Mon, Feb 12, 6:07 AM
pulkit committed rHG3c9f2d4dbb39: py3: replace file() with open() in test-convert-hg-source.t.
py3: replace file() with open() in test-convert-hg-source.t
Mon, Feb 12, 6:07 AM
pulkit committed rHGaf9cb761b5f3: py3: replace file() with open() in test-encoding-align.t.
py3: replace file() with open() in test-encoding-align.t
Mon, Feb 12, 6:07 AM