Feed Advanced Search

Today

pulkit closed D4300: context: make sure file is not deleted while checking path conflicts.
Thu, Aug 16, 12:48 PM
pulkit closed D4299: tests: demonstrate that IMM needs to be smarter with path conflicts.
Thu, Aug 16, 12:48 PM
pulkit committed rHG873f3a56993f: context: make sure file is not deleted while checking path conflicts.
context: make sure file is not deleted while checking path conflicts
Thu, Aug 16, 12:48 PM
pulkit committed rHG02e80e37fbbc: tests: demonstrate that IMM needs to be smarter with path conflicts.
tests: demonstrate that IMM needs to be smarter with path conflicts
Thu, Aug 16, 12:48 PM
pulkit closed D4298: tests: don't create new repo inside existing repo in test-rebase-inmemory.t.
Thu, Aug 16, 12:48 PM
pulkit committed rHG0600d09764df: tests: don't create new repo inside existing repo in test-rebase-inmemory.t.
tests: don't create new repo inside existing repo in test-rebase-inmemory.t
Thu, Aug 16, 12:48 PM
pulkit added a comment to D4301: tests: add a directory 'knownfailures' to check in known failures.

I also think that the 'knowfailures' can serve as a good place for new contributors.
I don't want to check-in all the failures and leave them unfixed. It's like I don't know which one I will be able to fix and I have a reproduction which can help others.

Thu, Aug 16, 11:07 AM
pulkit created D4301: tests: add a directory 'knownfailures' to check in known failures.
Thu, Aug 16, 10:59 AM
pulkit added a comment to D3896: copies: handle case when both merge cset are not descendant of merge base.

Any updates on this? I'm poking at updating this function in core, and not too excited to have to also modify the copy in evolve that seems to have spawned :/

Thu, Aug 16, 10:08 AM
pulkit created D4300: context: make sure file is not deleted while checking path conflicts.
Thu, Aug 16, 10:07 AM
pulkit added a dependent revision for D4299: tests: demonstrate that IMM needs to be smarter with path conflicts: D4300: context: make sure file is not deleted while checking path conflicts.
Thu, Aug 16, 10:07 AM
pulkit created D4299: tests: demonstrate that IMM needs to be smarter with path conflicts.
Thu, Aug 16, 10:07 AM
pulkit added a dependent revision for D4298: tests: don't create new repo inside existing repo in test-rebase-inmemory.t: D4299: tests: demonstrate that IMM needs to be smarter with path conflicts.
Thu, Aug 16, 10:07 AM
pulkit created D4298: tests: don't create new repo inside existing repo in test-rebase-inmemory.t.
Thu, Aug 16, 10:07 AM
pulkit accepted D4289: tests: update test-check-py3-compat.t output in the py3exe branch.
Thu, Aug 16, 9:22 AM
pulkit accepted D4288: tests: remove test-py3-commands.t.

Macro killitwithfire:

Thu, Aug 16, 9:21 AM
pulkit accepted D4287: overlayworkingctx: fix exception in metadata-only inmemory merges (issue5960).

Thanks @phillco for the review.

Thu, Aug 16, 9:17 AM

Yesterday

pulkit added a comment to D4053: [RFC]hgweb: garbage collect on every request in hgweb_mod too.
In D4053#62855, @av6 wrote:

Are you sure you're not just using hgwebdir_mod? hgweb_mod is for cases when you don't use --web-conf flag, at least that seems to be the logic that hgweb.createapp() uses to pick one of the two modules.

Wed, Aug 15, 7:10 AM

Fri, Aug 10

pulkit closed D4259: context: safegaurd from 'lx' being passed as file flag in manifest.
Fri, Aug 10, 12:32 PM
pulkit committed rHG2488dcfa71f8: context: safegaurd from 'lx' being passed as file flag in manifest.
context: safegaurd from 'lx' being passed as file flag in manifest
Fri, Aug 10, 12:32 PM
pulkit created D4259: context: safegaurd from 'lx' being passed as file flag in manifest.
Fri, Aug 10, 12:16 PM
pulkit accepted D4255: debugcommands: fix a missing b prefix.
Fri, Aug 10, 11:52 AM
pulkit accepted D4254: wireprotohelpers: add missing b prefixes.
Fri, Aug 10, 11:52 AM
pulkit accepted D4253: util: fix signature of setsockopt in socket observer.

I also have been here a lot of times and I was unable to found what's wrong. Kudos for fixing this.

Fri, Aug 10, 11:52 AM
pulkit accepted D4252: tests: port test-glog.t to Python 3 by using extracted printrevset.
Fri, Aug 10, 11:50 AM
pulkit accepted D4251: tests: extract printrevset extension from test-glog-beautifygraph.t.
Fri, Aug 10, 11:50 AM
pulkit accepted D4250: tests: add missing b'' prefix in test-check-code.t.
Fri, Aug 10, 8:12 AM
pulkit accepted D4249: contrib: have check-code look at files in latin1 instead of ascii.
Fri, Aug 10, 8:12 AM
pulkit accepted D4247: tests: port inline extension in test for beautifygraph to Python 3.
Fri, Aug 10, 8:11 AM
pulkit accepted D4246: beautifygraph: use slicing instead of subscripting on bytestr.
Fri, Aug 10, 8:11 AM
pulkit accepted D4245: beautifygraph: use sysstr for checking encoding._wide.
Fri, Aug 10, 8:10 AM
pulkit accepted D4244: stringutil: have buildrepr delegate to pprint for unknown types.
Fri, Aug 10, 8:10 AM
pulkit accepted D4242: parser: replace bespoke _brepr with stringutil.pprint.
Fri, Aug 10, 8:09 AM
pulkit accepted D4243: stringutil: teach pprint about sets.
Fri, Aug 10, 8:09 AM
pulkit accepted D4248: mq: use stringutil.pprint instead of pycompat.byterepr.
Fri, Aug 10, 8:08 AM
pulkit accepted D4185: tests: remove expected output of test-parseindex2.py.
Fri, Aug 10, 8:06 AM
pulkit accepted D4183: parsers: adjust pure-python version to mimic a3dacabd476b.
Fri, Aug 10, 8:06 AM
pulkit accepted D4182: tests: restore Python 3 compat in test-parseindex2.py.
Fri, Aug 10, 8:05 AM
pulkit accepted D4181: tests: port remaining bits of test-parseindex2 to unittest asserts.
Fri, Aug 10, 8:04 AM

Thu, Aug 9

pulkit accepted D4180: tests: rename variables in revlog index parse test for clarity.
Thu, Aug 9, 3:04 PM
pulkit accepted D4179: tests: move assertion closer to want/got declarations in test-parseindex2.py.
Thu, Aug 9, 3:04 PM
pulkit accepted D4178: tests: move chunks of test-parseindex2.py to use unittest properly.
Thu, Aug 9, 2:51 PM
pulkit accepted D4177: tests: fix up indent width in test-parseindex2.py.
Thu, Aug 9, 2:48 PM
pulkit accepted D4176: tests: start moving test-parseindex2.py to a unittest.
Thu, Aug 9, 2:47 PM
pulkit added a comment to D4125: narrow: add '--extend' flag to tracked command.

Seems fine to me, though thinking we should probably spend some time to make sure the sparse and narrow patterns are cross-compatible like this change seems to hope for.

Thu, Aug 9, 2:25 PM
pulkit accepted D4175: tests: port test-absorb-filefixupstate to Python 3.
Thu, Aug 9, 2:13 PM
pulkit accepted D4174: absorb: port partway to Python 3.
Thu, Aug 9, 2:12 PM
pulkit closed D4169: status: advertise --abort instead of 'update -C .' to abort graft.
Thu, Aug 9, 2:06 PM
pulkit closed D4168: status: advertise --abort instead of 'update -C .' to abort a merge.
Thu, Aug 9, 2:06 PM
pulkit committed rHG5b04b6204931: status: advertise --abort instead of 'update -C .' to abort graft.
status: advertise --abort instead of 'update -C .' to abort graft
Thu, Aug 9, 2:06 PM
pulkit committed rHGcf68e2649e0a: status: advertise --abort instead of 'update -C .' to abort a merge.
status: advertise --abort instead of 'update -C .' to abort a merge
Thu, Aug 9, 2:06 PM
pulkit committed rHG05ded838c997: narrow: add '()' to ellipsis in the revset help.
narrow: add '()' to ellipsis in the revset help
Thu, Aug 9, 2:06 PM
pulkit closed D4167: narrow: add '()' to ellipsis in the revset help.
Thu, Aug 9, 2:06 PM
pulkit accepted D4173: py3: whitelist another test caught by the ratchet.
Thu, Aug 9, 2:04 PM
pulkit accepted D4172: debugcommands: force import of fileset in debugfileset.
Thu, Aug 9, 2:04 PM
pulkit created D4169: status: advertise --abort instead of 'update -C .' to abort graft.
Thu, Aug 9, 6:19 AM
pulkit created D4168: status: advertise --abort instead of 'update -C .' to abort a merge.
Thu, Aug 9, 6:19 AM
pulkit added a dependent revision for D4168: status: advertise --abort instead of 'update -C .' to abort a merge: D4169: status: advertise --abort instead of 'update -C .' to abort graft.
Thu, Aug 9, 6:18 AM
pulkit added a dependent revision for D4167: narrow: add '()' to ellipsis in the revset help: D4168: status: advertise --abort instead of 'update -C .' to abort a merge.
Thu, Aug 9, 6:18 AM
pulkit created D4167: narrow: add '()' to ellipsis in the revset help.
Thu, Aug 9, 6:18 AM

Wed, Aug 8

pulkit created D4156: narrow: add a --narrowspec flag to clone command.
Wed, Aug 8, 7:09 AM

Tue, Aug 7

pulkit added a comment to D4099: narrow: move .hg/narrowspec to .hg/store/narrowspec (BC).
In D4099#64268, @pulkit wrote:

There are non-Google users of narrow at this point (recall we've gotten non-Googler patches), so please publish the temporary migration hack someplace for the benefit of the other users.

(A phabricator review that we immediately abandon would probably be fine, but we should definitely make a note in the relnotes for 4.8)

Yes, we might roll-out narrow with mercurial 4.7 first, so this script will be of great help. (BTW, isn't it just a move of file?)

It's "just" a move, but typically the way we handle these migrations at Google is we write an extension that does one of the following:

  1. Hijacks reads for the new file and reads the old file
  2. Hijacks reads for the new file if it doesn't exist and moves the new file

    we run in mode 1 when we're doing the rollout and might roll back, then switch to mode 2 when we're past the rubicon on the rollout and can finalize the data migration. Once everyone has run the extension in mode 2 for a while, we reap the extension.
Tue, Aug 7, 10:35 AM
pulkit added a comment to D4099: narrow: move .hg/narrowspec to .hg/store/narrowspec (BC).

There are non-Google users of narrow at this point (recall we've gotten non-Googler patches), so please publish the temporary migration hack someplace for the benefit of the other users.

(A phabricator review that we immediately abandon would probably be fine, but we should definitely make a note in the relnotes for 4.8)

Tue, Aug 7, 10:29 AM
pulkit added a comment to D2679: [PoC] obsolete: config option to enable local only obsolescence mode.
In D2679#62662, @pulkit wrote:

These patches were result of a very extensive discussion about what ways we have to start supporting obsmarkers by default. I will like to push these changesets so that we can try these in this cycle. If I don't hear any concern in a week, I will push them.

We made a series with Ryan during the sprint that had the advantage of not requiring to delete obs-markers. I will undust it, rebase it and send it here for making the discussion go forward.

Tue, Aug 7, 6:58 AM

Mon, Aug 6

pulkit created D4125: narrow: add '--extend' flag to tracked command.
Mon, Aug 6, 7:07 AM

Sun, Aug 5

pulkit added a comment to D4102: resolve: support confirm config option with --unmark flag.

Please add about this config option in the releasenotes page for 4.8 at https://www.mercurial-scm.org/wiki/Release4.8.

Sun, Aug 5, 10:29 PM
pulkit accepted D4103: resolve: update commands.resolve.confirm help text.

Updated the commit message in flight to follow the updated version of patch.

Sun, Aug 5, 10:22 PM
pulkit accepted D4102: resolve: support confirm config option with --unmark flag.
Sun, Aug 5, 10:20 PM

Sat, Aug 4

pulkit accepted D4100: fix: compute changed lines lazily to make whole-file fixer tools faster.
Sat, Aug 4, 1:17 PM
pulkit added inline comments to D4103: resolve: update commands.resolve.confirm help text.
Sat, Aug 4, 1:13 PM
pulkit added inline comments to D4102: resolve: support confirm config option with --unmark flag.
Sat, Aug 4, 1:12 PM
pulkit accepted D4101: resolve: support commands.resolve.confirm option with --mark flag.
Sat, Aug 4, 1:09 PM
pulkit accepted D4072: resolve: add commands.resolve.mark-check=abort to tweakdefaults.
Sat, Aug 4, 1:05 PM
pulkit accepted D4071: resolve: graduate resolve.mark-check from experimental, add docs.
Sat, Aug 4, 1:05 PM

Fri, Aug 3

pulkit closed D4058: narrowspec: remove the unused _parsestoredpatterns() function.
Fri, Aug 3, 8:04 PM
pulkit committed rHG794afa91f0a5: narrowspec: remove the unused _parsestoredpatterns() function.
narrowspec: remove the unused _parsestoredpatterns() function
Fri, Aug 3, 8:04 PM
pulkit committed rHGf64ebe7d2259: narrowspec: use sparse.parseconfig() to parse narrowspec file (BC).
narrowspec: use sparse.parseconfig() to parse narrowspec file (BC)
Fri, Aug 3, 8:04 PM
pulkit closed D4057: narrowspec: use sparse.parseconfig() to parse narrowspec file (BC).
Fri, Aug 3, 8:04 PM
pulkit committed rHG8fe62ad9f4ff: sparse: add an action argument to parseconfig().
sparse: add an action argument to parseconfig()
Fri, Aug 3, 8:04 PM
pulkit closed D4056: sparse: add an action argument to parseconfig().
Fri, Aug 3, 8:04 PM
pulkit accepted D4060: changegroup: move ellipsisdata() from narrow.
Fri, Aug 3, 5:57 PM
pulkit accepted D4040: shortest: make isrev() a top-level function.
Fri, Aug 3, 5:52 PM
pulkit accepted D4093: tests: avoid unnecessarily looking inside .hg/ in test-narrow*.
Fri, Aug 3, 5:50 PM
pulkit added inline comments to D4040: shortest: make isrev() a top-level function.
Fri, Aug 3, 5:48 PM
pulkit accepted D4095: narrow: extract part of narrowspec backup to core.
Fri, Aug 3, 5:40 PM
pulkit added inline comments to D4093: tests: avoid unnecessarily looking inside .hg/ in test-narrow*.
Fri, Aug 3, 5:37 PM
pulkit added inline comments to D4071: resolve: graduate resolve.mark-check from experimental, add docs.
Fri, Aug 3, 5:35 PM
pulkit accepted D4094: narrow: move requirement constant from changegroup to repository.
Fri, Aug 3, 5:31 PM
pulkit added a comment to D4093: tests: avoid unnecessarily looking inside .hg/ in test-narrow*.

The commit message says you used hg debugdirstate but looking at changes, you used hg files. I think the commit message needs to be updated.

Fri, Aug 3, 5:29 PM
pulkit added inline comments to D4071: resolve: graduate resolve.mark-check from experimental, add docs.
Fri, Aug 3, 5:24 PM
pulkit added inline comments to D3988: resolve: add confirm config option.
Fri, Aug 3, 1:32 PM
pulkit updated the summary of D4057: narrowspec: use sparse.parseconfig() to parse narrowspec file (BC).
Fri, Aug 3, 12:59 PM
pulkit updated the diff for D4057: narrowspec: use sparse.parseconfig() to parse narrowspec file (BC).
Fri, Aug 3, 12:56 PM
pulkit updated the diff for D4058: narrowspec: remove the unused _parsestoredpatterns() function.
Fri, Aug 3, 12:55 PM
pulkit updated the diff for D4056: sparse: add an action argument to parseconfig().
Fri, Aug 3, 12:55 PM
pulkit accepted D4069: py3: whitelist another 3 tests caught by the ratchet.
Fri, Aug 3, 11:44 AM
pulkit abandoned D4054: hgsubversion: add 4.7 to list of supported mercurial.

Sorry for the noise. I managed to email it using my personal laptop.

Fri, Aug 3, 10:21 AM
pulkit added inline comments to D4049: testrunner: allow multiple #testcases.
Fri, Aug 3, 10:07 AM
pulkit accepted D4052: testrunner: use "#" for "test cases" suffix in .err filename too.
Fri, Aug 3, 10:01 AM
pulkit accepted D3988: resolve: add confirm config option.
Fri, Aug 3, 10:00 AM