Fri, Oct 19
How do we want to move forward with this?
Since these two patches are simple but great speedups, I am queueing them and also I will be sending patches to fix this at other places too if nobody beats me to it.
Thu, Oct 18
First of all, thank you for reviewing the patch.
We switched to mercurial a few months ago, mainly because of the narrow extension.
Is the goal is to include this in 4.8?
Many thanks for investing time and efforts into this. \o/
@martinvonz many thanks for changing things in flight. Any reason why D5138 and D5139 are not considered during review because with them, you won't have to change much things except the config knob to experimental.
Wed, Oct 17
I have tested this and it works well with our internal repo too. Thanks!
There are no children reviews of this one. Could you please set the parent-child relationships so the entire stack renders in the web UI?
(I'm assuming there are commits that follow this one - an unimplemented narrow stream clone feature doesn't seem very useful!)
I'll hold off formally accepting until the whole series is up. But this looks pretty good.
We need to land this in 4.8 or less the client-side feature detection logic will require a new server capability (or a bump of the version of the capability string).
Tue, Oct 16
@martinvonz Looks like this got missed for discussing in sprint, can you have a look at this please? This is important because once we have narrowspecs greater than 255 length and and don't use ellipses, we hit https://bz.mercurial-scm.org/show_bug.cgi?id=5952
Sun, Oct 14
Another conceptual problem with this is that it assumes data/ and meta/ are used for tracking just filelogs and manifestlogs. In theory, other revlogs / data files could be stored there.
For files / data/ paths, I think we're OK making this assumption. But for manifests / meta/, I would feel better if we built up a set of tree manifest directories and then intersected that with files in meta/ that map to their revlogs.
This patch is now waiting for me to test it on our internal repo and make sure it works on multi-level dirs and big repos. Since this a server side fix, it will take some time for me to test this internally and I will try to do it in next couple of days. Also this is something which we will definitely want in the upcoming release.