Feed Advanced Search

Today

pulkit updated the diff for D5174: py3: make sure we pass sysstr in sqlite3.connect().
Sun, Oct 21, 11:28 AM

Yesterday

pulkit closed D5172: statprof: update the name as the i increases (issue6003).
Sat, Oct 20, 3:14 AM
pulkit committed rHG4613f9274fc0: statprof: update the name as the i increases (issue6003).
statprof: update the name as the i increases (issue6003)
Sat, Oct 20, 3:13 AM
pulkit committed rHG1ce4fe0603a6: test: show more profile lines in test-profile.t.
test: show more profile lines in test-profile.t
Sat, Oct 20, 3:13 AM
pulkit closed D5171: test: show more profile lines in test-profile.t.
Sat, Oct 20, 3:13 AM

Fri, Oct 19

pulkit added a dependent revision for D5174: py3: make sure we pass sysstr in sqlite3.connect(): D5175: py3: add one more passing test to whitelist.
Fri, Oct 19, 5:26 PM
pulkit created D5173: py3: make debugindexstats output printing compatible.
Fri, Oct 19, 5:26 PM
pulkit created D5175: py3: add one more passing test to whitelist.
Fri, Oct 19, 5:26 PM
pulkit created D5174: py3: make sure we pass sysstr in sqlite3.connect().
Fri, Oct 19, 5:26 PM
pulkit added a dependent revision for D5173: py3: make debugindexstats output printing compatible: D5174: py3: make sure we pass sysstr in sqlite3.connect().
Fri, Oct 19, 5:26 PM
pulkit added a comment to D5002: extensions: fix up many many debug logs that use %r.

How do we want to move forward with this?

Fri, Oct 19, 5:09 PM
pulkit added inline comments to D5159: phabricator: do more of the VCR work in demandimport.deactivated().
Fri, Oct 19, 4:44 PM
pulkit accepted D5160: keepalive: use getattr to avoid AttributeErrors when vcr is in use.
Fri, Oct 19, 4:40 PM
pulkit accepted D5159: phabricator: do more of the VCR work in demandimport.deactivated().
Fri, Oct 19, 4:39 PM
pulkit accepted D5157: tests: sleep longer in test-logtoprocess.t.
Fri, Oct 19, 4:38 PM
pulkit accepted D5158: tests: fix pyflakes warning in test-duplicateoptions.py.
Fri, Oct 19, 4:36 PM
pulkit added inline comments to D5172: statprof: update the name as the i increases (issue6003).
Fri, Oct 19, 4:36 PM
pulkit created D5172: statprof: update the name as the i increases (issue6003).
Fri, Oct 19, 4:35 PM
pulkit added a dependent revision for D5171: test: show more profile lines in test-profile.t: D5172: statprof: update the name as the i increases (issue6003).
Fri, Oct 19, 4:35 PM
pulkit created D5171: test: show more profile lines in test-profile.t.
Fri, Oct 19, 4:35 PM
pulkit created D5170: branchmap: pass changelog into revbranchcache.branchinfo().
Fri, Oct 19, 1:39 PM
pulkit added a comment to D5161: branchmap: pass changelog into branchmap functions.

Since these two patches are simple but great speedups, I am queueing them and also I will be sending patches to fix this at other places too if nobody beats me to it.

Fri, Oct 19, 1:19 PM
pulkit added inline comments to D5161: branchmap: pass changelog into branchmap functions.
Fri, Oct 19, 1:15 PM
pulkit added inline comments to D5161: branchmap: pass changelog into branchmap functions.
Fri, Oct 19, 1:14 PM
pulkit accepted D5162: branchmap: avoid changelog and attribute lookups in replacecache().
Fri, Oct 19, 1:09 PM
pulkit accepted D5161: branchmap: pass changelog into branchmap functions.
Fri, Oct 19, 1:08 PM
pulkit updated the diff for D5147: config: make 'experimental' the section instead of 'experimental.server'.
Fri, Oct 19, 9:02 AM
pulkit updated the diff for D5139: store: introduce _matchtrackedpath() and use it to filter store files.
Fri, Oct 19, 9:01 AM
pulkit updated the diff for D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Fri, Oct 19, 9:01 AM
pulkit added inline comments to D5147: config: make 'experimental' the section instead of 'experimental.server'.
Fri, Oct 19, 6:48 AM

Thu, Oct 18

pulkit accepted D5153: update: clarify update() call sites by specifying argument names.
Thu, Oct 18, 2:13 PM
pulkit set the repository for D4312: New bookflow extension for bookmark-based branching to rHG Mercurial.
Thu, Oct 18, 1:36 PM
pulkit added a comment to D4312: New bookflow extension for bookmark-based branching.

First of all, thank you for reviewing the patch.

We switched to mercurial a few months ago, mainly because of the narrow extension.

Thu, Oct 18, 1:30 PM
pulkit accepted D5151: tests: fix up pure case of test-sqlitestore.t.
Thu, Oct 18, 11:25 AM
pulkit accepted D5150: tests: don't emit false failures when sqlite3 is missing.
Thu, Oct 18, 11:22 AM
pulkit closed D5149: py3: add a r'' prefix in mercurial/exchange.py.
Thu, Oct 18, 9:11 AM
pulkit committed rHGdd816e5391f6: py3: add a r'' prefix in mercurial/exchange.py.
py3: add a r'' prefix in mercurial/exchange.py
Thu, Oct 18, 9:11 AM
pulkit committed rHGb1eb19301c94: py3: add 5 new passing tests to whitelist caught by buildbot.
py3: add 5 new passing tests to whitelist caught by buildbot
Thu, Oct 18, 9:11 AM
pulkit closed D5148: py3: add 5 new passing tests to whitelist caught by buildbot.
Thu, Oct 18, 9:11 AM
pulkit accepted D5120: match: fix up a repr to not crash on Python 3.
Thu, Oct 18, 7:56 AM
pulkit added inline comments to D4895: narrow: when widening, don't include manifests the client already has.
Thu, Oct 18, 7:55 AM
pulkit created D5149: py3: add a r'' prefix in mercurial/exchange.py.
Thu, Oct 18, 7:47 AM
pulkit added a dependent revision for D5148: py3: add 5 new passing tests to whitelist caught by buildbot: D5149: py3: add a r'' prefix in mercurial/exchange.py.
Thu, Oct 18, 7:47 AM
pulkit created D5148: py3: add 5 new passing tests to whitelist caught by buildbot.
Thu, Oct 18, 7:46 AM
pulkit added a comment to D5146: histedit: import chistedit curses UI from hg-experimental.

Is the goal is to include this in 4.8?

Thu, Oct 18, 7:02 AM
pulkit abandoned D5060: releasenotes: fix dumb whitespace bug I missed.
Thu, Oct 18, 6:55 AM
pulkit commandeered D5060: releasenotes: fix dumb whitespace bug I missed.
Thu, Oct 18, 6:55 AM
pulkit accepted D4895: narrow: when widening, don't include manifests the client already has.

Many thanks for investing time and efforts into this. \o/

Thu, Oct 18, 6:52 AM
pulkit accepted D5143: tests: add test for widening from an empty clone.
Thu, Oct 18, 6:46 AM
pulkit accepted D5144: subrepo: access status members by name instead of by position.
Thu, Oct 18, 6:44 AM
pulkit removed a dependent revision for D5119: exchange: pass includepats and excludepats as arguments to getbundle(): D5137: streamclone: new server config and some API changes for narrow stream clones.
Thu, Oct 18, 6:41 AM
pulkit removed a dependency for D5137: streamclone: new server config and some API changes for narrow stream clones: D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Thu, Oct 18, 6:41 AM
pulkit edited dependencies for D5138: narrow: only send includepats and excludepats if they are not empty, added: 1; removed: 1.
Thu, Oct 18, 6:40 AM
pulkit added a dependent revision for D5119: exchange: pass includepats and excludepats as arguments to getbundle(): D5138: narrow: only send includepats and excludepats if they are not empty.
Thu, Oct 18, 6:40 AM
pulkit removed a dependent revision for D4850: store: pass matcher to store.datafiles(): D5138: narrow: only send includepats and excludepats if they are not empty.
Thu, Oct 18, 6:40 AM
pulkit created D5147: config: make 'experimental' the section instead of 'experimental.server'.
Thu, Oct 18, 6:38 AM
pulkit updated the diff for D5139: store: introduce _matchtrackedpath() and use it to filter store files.
Thu, Oct 18, 6:38 AM
pulkit added a dependent revision for D5139: store: introduce _matchtrackedpath() and use it to filter store files: D5147: config: make 'experimental' the section instead of 'experimental.server'.
Thu, Oct 18, 6:38 AM
pulkit updated the diff for D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Thu, Oct 18, 6:38 AM
pulkit updated the diff for D5138: narrow: only send includepats and excludepats if they are not empty.
Thu, Oct 18, 6:38 AM
pulkit added a comment to D5137: streamclone: new server config and some API changes for narrow stream clones.

@martinvonz many thanks for changing things in flight. Any reason why D5138 and D5139 are not considered during review because with them, you won't have to change much things except the config knob to experimental.

Thu, Oct 18, 5:21 AM

Wed, Oct 17

pulkit closed D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 7:25 PM
pulkit closed D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 7:25 PM
pulkit committed rHG2d45b549392f: store: pass matcher to store.datafiles().
store: pass matcher to store.datafiles()
Wed, Oct 17, 7:25 PM
pulkit committed rHGf0e8f27768eb: streamclone: pass narrowing related info in _walkstreamfiles().
streamclone: pass narrowing related info in _walkstreamfiles()
Wed, Oct 17, 7:25 PM
pulkit committed rHGaf62936c2508: streamclone: new server config and some API changes for narrow stream clones.
streamclone: new server config and some API changes for narrow stream clones
Wed, Oct 17, 7:25 PM
pulkit closed D4851: streamclone: pass narrowing related info in _walkstreamfiles().
Wed, Oct 17, 7:25 PM
pulkit closed D4931: narrow: only send the narrowspecs back if ACL in play.
Wed, Oct 17, 6:34 PM
pulkit committed rHGcb516a854bc7: narrow: only send the narrowspecs back if ACL in play.
narrow: only send the narrowspecs back if ACL in play
Wed, Oct 17, 6:34 PM
pulkit added a comment to D4895: narrow: when widening, don't include manifests the client already has.

I have tested this and it works well with our internal repo too. Thanks!

Wed, Oct 17, 12:06 PM
pulkit added a comment to D5137: streamclone: new server config and some API changes for narrow stream clones.

There are no children reviews of this one. Could you please set the parent-child relationships so the entire stack renders in the web UI?

(I'm assuming there are commits that follow this one - an unimplemented narrow stream clone feature doesn't seem very useful!)

Wed, Oct 17, 11:30 AM
pulkit removed a dependency for D4850: store: pass matcher to store.datafiles(): D4849: store: introduce a function to get tracked path from a fncache entry.
Wed, Oct 17, 11:28 AM
pulkit removed a dependent revision for D4849: store: introduce a function to get tracked path from a fncache entry: D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 11:28 AM
pulkit added a dependent revision for D4851: streamclone: pass narrowing related info in _walkstreamfiles(): D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 11:26 AM
pulkit added a dependency for D4850: store: pass matcher to store.datafiles(): D4851: streamclone: pass narrowing related info in _walkstreamfiles().
Wed, Oct 17, 11:26 AM
pulkit removed a dependency for D4851: streamclone: pass narrowing related info in _walkstreamfiles(): D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 11:26 AM
pulkit removed a dependent revision for D4850: store: pass matcher to store.datafiles(): D4851: streamclone: pass narrowing related info in _walkstreamfiles().
Wed, Oct 17, 11:26 AM
pulkit edited dependent revision(s) for D5137: streamclone: new server config and some API changes for narrow stream clones, added 1: D4851: streamclone: pass narrowing related info in _walkstreamfiles(); removed 1: D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 11:26 AM
pulkit added a dependency for D4851: streamclone: pass narrowing related info in _walkstreamfiles(): D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 11:26 AM
pulkit removed a dependency for D4850: store: pass matcher to store.datafiles(): D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 11:26 AM
pulkit added a dependent revision for D5137: streamclone: new server config and some API changes for narrow stream clones: D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 11:25 AM
pulkit added a dependency for D4850: store: pass matcher to store.datafiles(): D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 11:25 AM
pulkit added a comment to D5137: streamclone: new server config and some API changes for narrow stream clones.

I'll hold off formally accepting until the whole series is up. But this looks pretty good.

We need to land this in 4.8 or less the client-side feature detection logic will require a new server capability (or a bump of the version of the capability string).

Wed, Oct 17, 11:24 AM
pulkit created D5139: store: introduce _matchtrackedpath() and use it to filter store files.
Wed, Oct 17, 10:53 AM
pulkit created D5138: narrow: only send includepats and excludepats if they are not empty.
Wed, Oct 17, 10:53 AM
pulkit added a dependent revision for D5138: narrow: only send includepats and excludepats if they are not empty: D5139: store: introduce _matchtrackedpath() and use it to filter store files.
Wed, Oct 17, 10:53 AM
pulkit created D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 10:53 AM
pulkit added a dependent revision for D4850: store: pass matcher to store.datafiles(): D5138: narrow: only send includepats and excludepats if they are not empty.
Wed, Oct 17, 10:53 AM
pulkit updated the diff for D4850: store: pass matcher to store.datafiles().
Wed, Oct 17, 10:53 AM
pulkit updated the diff for D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Wed, Oct 17, 10:53 AM
pulkit updated the diff for D4851: streamclone: pass narrowing related info in _walkstreamfiles().
Wed, Oct 17, 10:52 AM
pulkit added a dependent revision for D5119: exchange: pass includepats and excludepats as arguments to getbundle(): D5137: streamclone: new server config and some API changes for narrow stream clones.
Wed, Oct 17, 10:52 AM
pulkit updated the diff for D4931: narrow: only send the narrowspecs back if ACL in play.
Wed, Oct 17, 7:32 AM

Tue, Oct 16

pulkit created D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Tue, Oct 16, 12:14 PM
pulkit accepted D5117: storageutil: convert fileid to bytes to avoid cast to %s.
Tue, Oct 16, 11:56 AM
pulkit accepted D5114: tests: use byte literals in test-storage.py.
Tue, Oct 16, 11:56 AM
pulkit added a comment to D4931: narrow: only send the narrowspecs back if ACL in play.

@martinvonz Looks like this got missed for discussing in sprint, can you have a look at this please? This is important because once we have narrowspecs greater than 255 length and and don't use ellipses, we hit https://bz.mercurial-scm.org/show_bug.cgi?id=5952

Tue, Oct 16, 9:57 AM

Sun, Oct 14

pulkit added a comment to D4850: store: pass matcher to store.datafiles().

Another conceptual problem with this is that it assumes data/ and meta/ are used for tracking just filelogs and manifestlogs. In theory, other revlogs / data files could be stored there.

For files / data/ paths, I think we're OK making this assumption. But for manifests / meta/, I would feel better if we built up a set of tree manifest directories and then intersected that with files in meta/ that map to their revlogs.

Sun, Oct 14, 9:21 AM
pulkit added a comment to D4895: narrow: when widening, don't include manifests the client already has.

This patch is now waiting for me to test it on our internal repo and make sure it works on multi-level dirs and big repos. Since this a server side fix, it will take some time for me to test this internally and I will try to do it in next couple of days. Also this is something which we will definitely want in the upcoming release.

Sun, Oct 14, 8:51 AM
pulkit accepted D5097: logcmdutil: add a helpful assertion to catch mistyped templates early.
Sun, Oct 14, 6:01 AM