Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 19

D6657: cleanup: remove redundant import is now accepted and ready to land.
Fri, Jul 19, 1:32 AM
D6656: py3: another passing test is now accepted and ready to land.
Fri, Jul 19, 1:32 AM

Thu, Jul 18

pulkit added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 18, 1:19 PM
pulkit added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 18, 12:50 AM
pulkit added inline comments to D6645: continue: added logic for hg continue.
Thu, Jul 18, 12:44 AM

Wed, Jul 17

pulkit added a comment to D6430: rust-discovery: using from Python code.

I tested this series on our repository and found the following speedup in a case when there are 6k heads and 15k csets missing:

Wed, Jul 17, 6:33 AM
D6647: copies: remove unnecessary override of p[12]copies() in workingctx is now accepted and ready to land.
Wed, Jul 17, 1:18 AM
D6648: inno: correct the path display in a literal block of the readme is now accepted and ready to land.
Wed, Jul 17, 1:16 AM

Mon, Jul 15

D6640: tests: properly position conditional output on Windows in test-subrepo.t is now accepted and ready to land.
Mon, Jul 15, 9:54 AM
D6638: abort: removed labels argument from abortmerge() is now accepted and ready to land.
Mon, Jul 15, 9:50 AM
D6641: py3: source-transform only call-sites of iteritems(), not definitions is now accepted and ready to land.
Mon, Jul 15, 9:33 AM
D6644: py3: fix formatting of branchmap log messages with repo.filtername=None is now accepted and ready to land.
Mon, Jul 15, 9:32 AM

Thu, Jul 11

pulkit added a comment to D6638: abort: removed labels argument from abortmerge().

However when merge is aborted there is no unresolved merge in progress and hence

Thu, Jul 11, 9:21 AM
pulkit added a comment to D6596: unshelve: add interactive mode.

It will be nice to add information to commit message about how thing unshelving of a subset works.

Thu, Jul 11, 9:18 AM

Wed, Jul 10

D6588: abort: added support for merge is now accepted and ready to land.
Wed, Jul 10, 4:50 PM
pulkit added inline comments to D6588: abort: added support for merge.
Wed, Jul 10, 4:46 PM
D6588: abort: added support for merge now requires changes to proceed.
Wed, Jul 10, 4:25 PM
D6579: abort: added support for unshelve is now accepted and ready to land.
Wed, Jul 10, 3:18 PM
pulkit added inline comments to D6579: abort: added support for unshelve.
Wed, Jul 10, 3:06 PM
pulkit added a comment to D6579: abort: added support for unshelve.

The commit message is outdated.

Wed, Jul 10, 2:54 PM
pulkit added a comment to D6636: unshelve: changed Corruptedstate error msg from ui.warn to error.Abort.

This is fone so as to avoid the return statement

Wed, Jul 10, 2:51 PM
D6636: unshelve: changed Corruptedstate error msg from ui.warn to error.Abort is now accepted and ready to land.
Wed, Jul 10, 2:47 PM
pulkit added inline comments to D6588: abort: added support for merge.
Wed, Jul 10, 1:12 PM
pulkit added inline comments to D6579: abort: added support for unshelve.
Wed, Jul 10, 1:10 PM
D6624: tests: update test-commit-interactive.t for no-execbit platforms is now accepted and ready to land.
Wed, Jul 10, 9:06 AM
D6588: abort: added support for merge is now accepted and ready to land.
Wed, Jul 10, 8:58 AM
D6582: abort: added support for histedit is now accepted and ready to land.
Wed, Jul 10, 8:43 AM
D6568: abort: added support for rebase is now accepted and ready to land.
Wed, Jul 10, 8:41 AM
pulkit accepted D6567: abort: added support for graft.
Wed, Jul 10, 8:40 AM
D6566: abort: added logic for of hg abort is now accepted and ready to land.
Wed, Jul 10, 8:39 AM

Tue, Jul 9

pulkit added inline comments to D6568: abort: added support for rebase.
Tue, Jul 9, 6:31 AM
pulkit added a comment to D6567: abort: added support for graft.

This logic is registered to the statesetection API as abortfunc.

Tue, Jul 9, 6:29 AM
D6567: abort: added support for graft is now accepted and ready to land.
Tue, Jul 9, 6:26 AM
pulkit added a comment to D6566: abort: added logic for of hg abort.

hg abort currently supports --dry-run/-n flag only.
It is used to dry run hg abort

Tue, Jul 9, 6:25 AM
D6607: merge: disallow merge abort in case of an unfinished operation(issue6160) is now accepted and ready to land.
Tue, Jul 9, 5:45 AM
D6622: relnotes: document new range-select mechanism in crecord is now accepted and ready to land.
Tue, Jul 9, 5:40 AM

Mon, Jul 8

D6606: statecheck: updated docstrings related to afterresolvedstates is now accepted and ready to land.
Mon, Jul 8, 5:53 PM
pulkit added a comment to D6607: merge: disallow merge abort in case of an unfinished operation(issue6160).

Also, can you add an entry about this to relnotes/next?

Mon, Jul 8, 5:48 PM
D6616: extdata: avoid crashing inside subprocess when we get a revset parse error is now accepted and ready to land.
Mon, Jul 8, 5:42 PM
D6615: extdata: demonstrate bad behavior when a subprocess emits garbage is now accepted and ready to land.
Mon, Jul 8, 5:41 PM
pulkit added a comment to D6621: crecord: provide 'X' as a range-select mechanism.

Maybe this deserves and entry in relnotes/next as a followup.

Mon, Jul 8, 5:38 PM
D6614: py3: don't run source transformer on hgext3rd (extensions) is now accepted and ready to land.
Mon, Jul 8, 5:37 PM
D6621: crecord: provide 'X' as a range-select mechanism is now accepted and ready to land.
Mon, Jul 8, 5:37 PM
D6620: crecord: make KEY_ENTER usable in tests (by not updating UI) is now accepted and ready to land.
Mon, Jul 8, 5:37 PM
D6619: crecord: fix if -> elif when handling key presses is now accepted and ready to land.
Mon, Jul 8, 5:36 PM
D6618: crecord: add "x" alias for space, remove test-only "TOGGLE" alias is now accepted and ready to land.
Mon, Jul 8, 5:35 PM
D6617: crecord: stop using test-only "X" as alternative for "c" is now accepted and ready to land.
Mon, Jul 8, 5:35 PM
D6556: cleanup: use named constants for second arg to .seek() is now accepted and ready to land.
Mon, Jul 8, 5:10 PM
D6608: graft: moved abortgraft and readgraft to cmdutil is now accepted and ready to land.
Mon, Jul 8, 5:09 PM
pulkit added a comment to D6582: abort: added support for histedit.

Okay I will do that. So should I remove --no-backup flag altogether from this series of patches because none of the commands support --no-backup then.

Mon, Jul 8, 12:45 PM
pulkit added a comment to D6582: abort: added support for histedit.

@pulkit Yeah I know that but look at D3965. histedit once did support --no-backup flag. It was dropped off for a different reason.

Mon, Jul 8, 12:36 PM
pulkit added a comment to D6582: abort: added support for histedit.

Looking closely, the backup value comes from reading ui.configbool('rewrite', 'backup-bundle') instead of a --no-backup flag. It means we can get rid of the --backup flag to hg abort as there exists no such flag for histedit.

Mon, Jul 8, 11:59 AM
pulkit added a comment to D6608: graft: moved abortgraft and readgraft to cmdutil.

It will be nice to mention about our motivation to move code in the commit message.

Mon, Jul 8, 11:51 AM
pulkit added inline comments to D6607: merge: disallow merge abort in case of an unfinished operation(issue6160).
Mon, Jul 8, 11:49 AM
pulkit added inline comments to D6607: merge: disallow merge abort in case of an unfinished operation(issue6160).
Mon, Jul 8, 11:21 AM

Sun, Jul 7

D6610: tweakdefaults: make hg resolve require --re-merge flag to re-merge is now accepted and ready to land.
Sun, Jul 7, 2:20 PM

Sat, Jul 6

pulkit added inline comments to D6596: unshelve: add interactive mode.
Sat, Jul 6, 7:38 PM

Fri, Jul 5

D6605: unshelve: rename _dounshelve() to dounshelve() is now accepted and ready to land.
Fri, Jul 5, 5:59 PM
pulkit added inline comments to D6568: abort: added support for rebase.
Fri, Jul 5, 5:57 PM
pulkit added a comment to D6567: abort: added support for graft.

Tests have been shown as test-abort.t

Fri, Jul 5, 5:54 PM
pulkit added inline comments to D6566: abort: added logic for of hg abort.
Fri, Jul 5, 5:49 PM

Thu, Jul 4

pulkit added inline comments to D6588: abort: added support for merge.
Thu, Jul 4, 1:49 PM
pulkit added inline comments to D6588: abort: added support for merge.
Thu, Jul 4, 1:40 PM
pulkit added inline comments to D6588: abort: added support for merge.
Thu, Jul 4, 1:39 PM
D6590: relnotes: document the new --force-close-branch flag is now accepted and ready to land.
Thu, Jul 4, 10:55 AM
D6595: changelog: fix handling of empty copy entries in changeset is now accepted and ready to land.
Thu, Jul 4, 10:55 AM
pulkit added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

Since you did the nice work of moving shelve to core, how about rebasing this patch on tip of default with shelve in core?

Thu, Jul 4, 10:55 AM
pulkit added a comment to D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition.

Can you add link of mailing list thread in your commit message? Link from markmail or https://www.mercurial-scm.org/pipermail/mercurial-devel/.

Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6588: abort: added support for merge.
Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6579: abort: added support for unshelve.
Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6553: shelve: move shelve extension to core.
Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6582: abort: added support for histedit.
Thu, Jul 4, 10:55 AM
pulkit added a comment to D6568: abort: added support for rebase.

Since we both are discussing and working on this, we can understand why this patch does what it does. It will be nice to have more explained commit descriptions which explain why we need to have an function independent of rebase-runtime-state object. This applies to all the patches in the series. In the hg abort patch, explaining how it works will be good.

Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6567: abort: added support for graft.
Thu, Jul 4, 10:55 AM
pulkit added inline comments to D6566: abort: added logic for of hg abort.
Thu, Jul 4, 10:55 AM
pulkit added a comment to D6596: unshelve: add interactive mode.

Didn't look at the actual implementation yet.

Thu, Jul 4, 10:52 AM

Sun, Jun 30

pulkit added inline comments to D6588: abort: added support for merge.
Sun, Jun 30, 3:23 PM
pulkit added a comment to D6579: abort: added support for unshelve.

This patch needs to be rebased on tip of hg-committed as shelve is in core now.

Sun, Jun 30, 3:17 PM
pulkit added inline comments to D6567: abort: added support for graft.
Sun, Jun 30, 3:15 PM
pulkit added inline comments to D6567: abort: added support for graft.
Sun, Jun 30, 3:13 PM
pulkit added inline comments to D6566: abort: added logic for of hg abort.
Sun, Jun 30, 3:08 PM
pulkit closed D6511: py3: hack around inconsistency of type of name passed to DNSQuestion.
Sun, Jun 30, 6:57 AM
pulkit closed D6510: py3: add r'' prefixes and do ('%d' % int) instead of str(int).
Sun, Jun 30, 6:57 AM
pulkit committed rHG8306b6c29add: py3: hack around inconsistency of type of name passed to DNSQuestion.
py3: hack around inconsistency of type of name passed to DNSQuestion
Sun, Jun 30, 6:57 AM
pulkit committed rHG683aeef12830: py3: add r'' prefixes and do ('%d' % int) instead of str(int).
py3: add r'' prefixes and do ('%d' % int) instead of str(int)
Sun, Jun 30, 6:57 AM

Sat, Jun 29

pulkit updated the diff for D6511: py3: hack around inconsistency of type of name passed to DNSQuestion.
Sat, Jun 29, 7:15 PM
pulkit added a comment to D6511: py3: hack around inconsistency of type of name passed to DNSQuestion.

Review ping for this stack.

Sat, Jun 29, 11:54 AM
D6490: commit: add --force-close-branch flag to close a non-head changeset is now accepted and ready to land.
Sat, Jun 29, 11:53 AM
D6586: automv: access status fields by name, not index is now accepted and ready to land.
Sat, Jun 29, 11:51 AM
D6585: automv: use public API for getting copies is now accepted and ready to land.
Sat, Jun 29, 11:51 AM
pulkit accepted D6553: shelve: move shelve extension to core.
Sat, Jun 29, 11:47 AM

Fri, Jun 28

D6553: shelve: move shelve extension to core is now accepted and ready to land.

Thanks a lot for working on this. This needs to be rebased on tip of default branch. Also, can you add an entry about shelve extension being moved to core in relnotes/next file.

Fri, Jun 28, 8:50 AM

Thu, Jun 27

D6569: tests: demonstrate broken in-memory rebase of copy to empty file is now accepted and ready to land.
Thu, Jun 27, 11:47 AM
D6570: rebase: fix in-memory rebasing of copy of empty file is now accepted and ready to land.
Thu, Jun 27, 11:47 AM
D6574: zsh: enable completion support for chg as well is now accepted and ready to land.
Thu, Jun 27, 11:44 AM
D6577: py3: make catapult usable from the test runner in py3 is now accepted and ready to land.
Thu, Jun 27, 11:42 AM
D6576: py3: use integer division for the value passed to xrange is now accepted and ready to land.
Thu, Jun 27, 11:42 AM
D6575: pycompat: make fewer assumptions about sys.executable is now accepted and ready to land.
Thu, Jun 27, 11:41 AM

Mon, Jun 24

pulkit added inline comments to D6553: shelve: move shelve extension to core.
Mon, Jun 24, 8:44 AM