Feed Advanced Search

Yesterday

pulkit added a comment to D3660: graft: drop --user and --date values info from hint in case of conflicts.
In D3660#57581, @yuja wrote:

> commands.py:67
> dateutil,
> procutil,
> stringutil,

test-check-pyflakes.t complains about this no longer being used. I'll remove it in flight.

I've pushed the fixed version.

Sat, May 26, 10:48 AM
pulkit committed rHG5736570718fe: graft: drop --user and --date values info from hint in case of conflicts.
graft: drop --user and --date values info from hint in case of conflicts
Sat, May 26, 12:28 AM

Fri, May 25

pulkit added a dependent revision for D3662: graft: reuse the --log value passed initially in `hg graft --continue` (BC): D3663: graft: add test showing --continue not preserving --edit passed earlier.
Fri, May 25, 6:28 PM
pulkit added a dependency for D3663: graft: add test showing --continue not preserving --edit passed earlier: D3662: graft: reuse the --log value passed initially in `hg graft --continue` (BC).
Fri, May 25, 6:28 PM
pulkit created D3664: graft: reuse the --edit value passed initially in `hg graft --continue` (BC).
Fri, May 25, 6:26 PM
pulkit added a dependent revision for D3663: graft: add test showing --continue not preserving --edit passed earlier: D3664: graft: reuse the --edit value passed initially in `hg graft --continue` (BC).
Fri, May 25, 6:25 PM
pulkit created D3663: graft: add test showing --continue not preserving --edit passed earlier.
Fri, May 25, 6:25 PM
pulkit created D3662: graft: reuse the --log value passed initially in `hg graft --continue` (BC).
Fri, May 25, 5:45 PM
pulkit added a dependent revision for D3661: graft: add test showing --continue not preserving --log passed earlier: D3662: graft: reuse the --log value passed initially in `hg graft --continue` (BC).
Fri, May 25, 5:44 PM
pulkit created D3661: graft: add test showing --continue not preserving --log passed earlier.
Fri, May 25, 5:44 PM
pulkit closed D3660: graft: drop --user and --date values info from hint in case of conflicts.
Fri, May 25, 5:14 PM
pulkit closed D3659: graft: reuse --user and --date values in `hg graft --continue` (BC).
Fri, May 25, 5:14 PM
pulkit closed D3657: graft: store user passed date and user information in graftstate.
Fri, May 25, 5:14 PM
pulkit committed rHGdecdb587ea12: graft: reuse --user and --date values in `hg graft --continue` (BC).
graft: reuse --user and --date values in `hg graft --continue` (BC)
Fri, May 25, 5:14 PM
pulkit committed rHGd9572d344e59: graft: drop --user and --date values info from hint in case of conflicts.
graft: drop --user and --date values info from hint in case of conflicts
Fri, May 25, 5:13 PM
pulkit closed D3658: tests: add test showing --continue not preserving --date and --user flags.
Fri, May 25, 5:13 PM
pulkit committed rHG108ebd8eff5c: tests: add test showing --continue not preserving --date and --user flags.
tests: add test showing --continue not preserving --date and --user flags
Fri, May 25, 5:13 PM
pulkit committed rHG63553c2bef7e: graft: store user passed date and user information in graftstate.
graft: store user passed date and user information in graftstate
Fri, May 25, 5:13 PM
pulkit added a comment to D3657: graft: store user passed date and user information in graftstate.

I'm assuming we don't need to bump the state version since the new state file format is still relatively new. But if we had shipped the new state file in a release, I would insist on bumping the state version any time new data is added to state.

Fri, May 25, 5:11 PM
pulkit closed D3656: graft: use cmdstate.delete() to delete the state file.
Fri, May 25, 5:00 PM
pulkit committed rHG0dfa27e53c57: graft: use cmdstate.delete() to delete the state file.
graft: use cmdstate.delete() to delete the state file
Fri, May 25, 4:59 PM
pulkit abandoned D2595: graft: start using the new state file class.

Superseded by D3654.

Fri, May 25, 4:59 PM
pulkit added a comment to D2594: graft: move logic to read current graft state file in separate function.

Superseded by D3651.

Fri, May 25, 4:56 PM
pulkit abandoned D2594: graft: move logic to read current graft state file in separate function.
Fri, May 25, 4:56 PM
pulkit added a dependent revision for D3656: graft: use cmdstate.delete() to delete the state file: D3657: graft: store user passed date and user information in graftstate.
Fri, May 25, 4:55 PM
pulkit added a dependency for D3657: graft: store user passed date and user information in graftstate: D3656: graft: use cmdstate.delete() to delete the state file.
Fri, May 25, 4:55 PM
pulkit created D3660: graft: drop --user and --date values info from hint in case of conflicts.
Fri, May 25, 4:53 PM
pulkit created D3659: graft: reuse --user and --date values in `hg graft --continue` (BC).
Fri, May 25, 4:52 PM
pulkit added a dependent revision for D3659: graft: reuse --user and --date values in `hg graft --continue` (BC): D3660: graft: drop --user and --date values info from hint in case of conflicts.
Fri, May 25, 4:52 PM
pulkit added a dependent revision for D3658: tests: add test showing --continue not preserving --date and --user flags: D3659: graft: reuse --user and --date values in `hg graft --continue` (BC).
Fri, May 25, 4:52 PM
pulkit created D3657: graft: store user passed date and user information in graftstate.
Fri, May 25, 4:52 PM
pulkit created D3658: tests: add test showing --continue not preserving --date and --user flags.
Fri, May 25, 4:52 PM
pulkit added a dependent revision for D3657: graft: store user passed date and user information in graftstate: D3658: tests: add test showing --continue not preserving --date and --user flags.
Fri, May 25, 4:52 PM
pulkit accepted D3655: graph: add outputgraph() function, called by ascii() to print the graph to the ui..
Fri, May 25, 3:37 PM
pulkit closed D2597: graft: add test for reading old graftstate files with new mechanism.
Fri, May 25, 3:16 PM
pulkit committed rHGd1690a64268e: graft: add test for reading old graftstate files with new mechanism.
graft: add test for reading old graftstate files with new mechanism
Fri, May 25, 3:16 PM
pulkit created D3656: graft: use cmdstate.delete() to delete the state file.
Fri, May 25, 2:55 PM
pulkit added a dependent revision for D2597: graft: add test for reading old graftstate files with new mechanism: D3656: graft: use cmdstate.delete() to delete the state file.
Fri, May 25, 2:55 PM
pulkit updated the diff for D2597: graft: add test for reading old graftstate files with new mechanism.
Fri, May 25, 2:55 PM
pulkit added inline comments to D2597: graft: add test for reading old graftstate files with new mechanism.
Fri, May 25, 2:54 PM
pulkit closed D3654: graft: start using the cmdstate class to read and write data to graftstate.
Fri, May 25, 12:17 PM
pulkit closed D3652: graft: use state.cmdstate() to check whether graftstate exists.
Fri, May 25, 12:17 PM
pulkit closed D3651: graft: factor out function to read graft state in separate function.
Fri, May 25, 12:17 PM
pulkit committed rHG476324a304b2: graft: start using the cmdstate class to read and write data to graftstate.
graft: start using the cmdstate class to read and write data to graftstate
Fri, May 25, 12:16 PM
pulkit committed rHG58b08f4ce5f5: graft: use state.cmdstate() to check whether graftstate exists.
graft: use state.cmdstate() to check whether graftstate exists
Fri, May 25, 12:16 PM
pulkit committed rHG009aa4af5093: graft: factor out function to read graft state in separate function.
graft: factor out function to read graft state in separate function
Fri, May 25, 12:16 PM
pulkit added a comment to D3557: commit: add new close-branch command.

It doesn't seem to fit the argument schema for hg branch at all. I'm open for better places, but I couldn't think of a consistent place.

Fri, May 25, 7:31 AM
pulkit added a comment to D3557: commit: add new close-branch command.

The code looks mostly good to me. Needs tests for following cases:

Fri, May 25, 7:30 AM
pulkit added inline comments to D2597: graft: add test for reading old graftstate files with new mechanism.
Fri, May 25, 6:14 AM
pulkit added inline comments to D3653: state: removing remaining instances of opts class variable.
Fri, May 25, 6:03 AM

Thu, May 24

pulkit committed rHG6f67bfe4b82f: state: removing remaining instances of opts class variable.
state: removing remaining instances of opts class variable
Thu, May 24, 6:25 PM
pulkit closed D3653: state: removing remaining instances of opts class variable.
Thu, May 24, 6:25 PM
pulkit added a comment to D3187: phase: add dry-run functionality.

okay, but I have some queries like

  1. How about showing revision no. instead of cset id?
Thu, May 24, 5:19 PM
pulkit removed a dependent revision for D2597: graft: add test for reading old graftstate files with new mechanism: D2855: graft: add a version number to the state file formats.
Thu, May 24, 5:10 PM
pulkit removed a dependency for D2855: graft: add a version number to the state file formats: D2597: graft: add test for reading old graftstate files with new mechanism.
Thu, May 24, 5:09 PM
pulkit removed a dependent revision for D2595: graft: start using the new state file class: D2597: graft: add test for reading old graftstate files with new mechanism.
Thu, May 24, 5:08 PM
pulkit removed a dependency for D2597: graft: add test for reading old graftstate files with new mechanism: D2595: graft: start using the new state file class.
Thu, May 24, 5:08 PM
pulkit added a dependency for D2597: graft: add test for reading old graftstate files with new mechanism: D3654: graft: start using the cmdstate class to read and write data to graftstate.
Thu, May 24, 5:07 PM
pulkit added a dependent revision for D3654: graft: start using the cmdstate class to read and write data to graftstate: D2597: graft: add test for reading old graftstate files with new mechanism.
Thu, May 24, 5:07 PM
pulkit created D3654: graft: start using the cmdstate class to read and write data to graftstate.
Thu, May 24, 5:01 PM
pulkit updated the diff for D2597: graft: add test for reading old graftstate files with new mechanism.
Thu, May 24, 5:01 PM
pulkit added a dependent revision for D3653: state: removing remaining instances of opts class variable: D3654: graft: start using the cmdstate class to read and write data to graftstate.
Thu, May 24, 5:01 PM
pulkit created D3652: graft: use state.cmdstate() to check whether graftstate exists.
Thu, May 24, 5:01 PM
pulkit created D3653: state: removing remaining instances of opts class variable.
Thu, May 24, 5:00 PM
pulkit added a dependent revision for D3652: graft: use state.cmdstate() to check whether graftstate exists: D3653: state: removing remaining instances of opts class variable.
Thu, May 24, 5:00 PM
pulkit created D3651: graft: factor out function to read graft state in separate function.
Thu, May 24, 5:00 PM
pulkit added a comment to D3633: py3: use bytes in tests/printenv.py.

Looks like this needs to be dropped because due to this couple of tests which were already passing failed. Link to buildbot: https://buildbot.mercurial-scm.org/builders/py3%20tests/builds/920/steps/run-tests.py%20%28python3%29/logs/stdio

Thu, May 24, 4:52 PM

Wed, May 23

pulkit committed rHGdce718404ce6: state: raise CorruptedState error isntead of ProgrammingError.
state: raise CorruptedState error isntead of ProgrammingError
Wed, May 23, 8:34 AM
pulkit closed D3644: state: raise CorruptedState error isntead of ProgrammingError.
Wed, May 23, 8:34 AM

Tue, May 22

pulkit created D3644: state: raise CorruptedState error isntead of ProgrammingError.
Tue, May 22, 5:52 PM
pulkit committed rHGb7e5c53a779e: state: temporary silence pyflakes warning by removing variable assignment.
state: temporary silence pyflakes warning by removing variable assignment
Tue, May 22, 8:12 AM
pulkit closed D3641: state: temporary silence pyflakes warning by removing variable assignment.
Tue, May 22, 8:12 AM
pulkit committed rHGbdc4079ceb16: state: fix usage of an unassigned variable.
state: fix usage of an unassigned variable
Tue, May 22, 8:12 AM
pulkit closed D3640: state: fix usage of an unassigned variable.
Tue, May 22, 8:12 AM
pulkit committed rHG282f3daac1d7: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
py3: use encoding.strfromlocal() instead of pycompat.sysstr()
Tue, May 22, 7:41 AM
pulkit committed rHG6ef01102ebff: py3: add b'' prefixes in tests/test-revset2.t.
py3: add b'' prefixes in tests/test-revset2.t
Tue, May 22, 7:41 AM
pulkit closed D3637: py3: add b'' prefixes in tests/test-revset2.t.
Tue, May 22, 7:14 AM
pulkit committed rHGdbea87a2d7e8: py3: add b'' prefixes in tests/test-revset2.t.
py3: add b'' prefixes in tests/test-revset2.t
Tue, May 22, 7:14 AM
pulkit committed rHGd6d939a3676f: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
py3: use encoding.strfromlocal() instead of pycompat.sysstr()
Tue, May 22, 7:14 AM
pulkit closed D3642: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
Tue, May 22, 7:14 AM

Mon, May 21

pulkit created D3642: py3: use encoding.strfromlocal() instead of pycompat.sysstr().
Mon, May 21, 4:44 PM
pulkit added a dependent revision for D3640: state: fix usage of an unassigned variable: D3641: state: temporary silence pyflakes warning by removing variable assignment.
Mon, May 21, 2:56 PM
pulkit created D3641: state: temporary silence pyflakes warning by removing variable assignment.
Mon, May 21, 2:56 PM
pulkit created D3640: state: fix usage of an unassigned variable.
Mon, May 21, 2:56 PM
pulkit closed D3635: py3: add support for NoneType in stringutil.pprint().
Mon, May 21, 2:36 PM
pulkit committed rHG7aeb8aa262eb: py3: add support for NoneType in stringutil.pprint().
py3: add support for NoneType in stringutil.pprint()
Mon, May 21, 2:36 PM
pulkit closed D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output.
Mon, May 21, 2:36 PM
pulkit committed rHGd7cecea0b254: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py
Mon, May 21, 2:36 PM
pulkit closed D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
Mon, May 21, 2:36 PM
pulkit committed rHGbacbe829c2bf: py3: use bytes in tests/printenv.py.
py3: use bytes in tests/printenv.py
Mon, May 21, 2:36 PM
pulkit closed D3633: py3: use bytes in tests/printenv.py.
Mon, May 21, 2:36 PM
pulkit closed D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
Mon, May 21, 2:36 PM
pulkit committed rHGb0144fc8b681: py3: use stringutil.pprint() to prevent b'' prefixes in output.
py3: use stringutil.pprint() to prevent b'' prefixes in output
Mon, May 21, 2:36 PM
pulkit committed rHG666d90ace0bb: py3: use pycompat.fsencode to convert path to bytes.
py3: use pycompat.fsencode to convert path to bytes
Mon, May 21, 2:36 PM
pulkit committed rHGe69628f36196: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t
Mon, May 21, 2:36 PM
pulkit closed D3631: py3: use pycompat.fsencode to convert path to bytes.
Mon, May 21, 2:36 PM
pulkit committed rHG44ef9bb7ccd9: py3: add b'' prefixes in contrib/hg-ssh.
py3: add b'' prefixes in contrib/hg-ssh
Mon, May 21, 2:36 PM
pulkit closed D3629: py3: add b'' prefixes in contrib/hg-ssh.
Mon, May 21, 2:36 PM
pulkit committed rHGa0e4d654bceb: state: write the version number in plain text on top of state files.
state: write the version number in plain text on top of state files
Mon, May 21, 1:40 PM
pulkit committed rHG18c6d8b565bf: state: set canonical=True to write deterministically.
state: set canonical=True to write deterministically
Mon, May 21, 1:40 PM