For converting error messages to bytes, util.forcebytestr() is preferred. https://phab.mercurial-scm.org/D2269#inline-5791
It's recommended using util.forcebytestr() to convert error messages to bytes. https://phab.mercurial-scm.org/D2269#inline-5791
Thu, Feb 15
I'm find with you sending more parts to this series. Especially if they delete code: if they delete code then my review of the import will be a review of the final state of the code post deletions.
I see the following high-level potential use cases for infinitepush:
- A hosting/repo management alternative to forks
- A central repository for submitting changesets to a service (e.g. code review, a "try" repo to trigger CI, etc)
- As a backup mechanism
Wed, Feb 14
This one is a bugfix, so please add the issue number in the commit message. Also add related tests as that will help make sure we don't encounter such problems again in future.
Can you add tests showing what the new behavior is? The correct behavior should be to include multiple directives in the notes correctly.
I think ordering on the patches here is wrong. D2255 seems to be parent of this one. Also can you add related tests?
Tue, Feb 13
Fb's hg-experimental also uses a utility module just for this function, so I am +1 on moving this to core. https://bitbucket.org/facebook/hg-experimental/src/f27f094e91553d3cae5167c0b1c42ae940f888d5/hgext3rd/shareutil.py