Feed Advanced Search

Thu, Apr 25

taapas1128 closed D6038: push: added clear warning message when pushing closed branches(issue6080).
Thu, Apr 25, 2:08 PM
taapas1128 committed rHG5997eabc7b85: push: added clear warning message when pushing closed branches(issue6080).
push: added clear warning message when pushing closed branches(issue6080)
Thu, Apr 25, 2:07 PM

Mar 19 2019

taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Mar 19 2019, 9:05 AM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 19 2019, 9:01 AM

Mar 18 2019

taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Mar 18 2019, 2:56 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 18 2019, 2:38 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 18 2019, 2:08 PM

Mar 17 2019

taapas1128 added a comment to D6038: push: added clear warning message when pushing closed branches(issue6080).

@pulkit done.

Mar 17 2019, 9:22 AM
taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 17 2019, 9:20 AM

Mar 16 2019

taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 16 2019, 11:52 AM
taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 16 2019, 6:12 AM
taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Mar 16 2019, 5:41 AM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 16 2019, 5:36 AM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 16 2019, 5:24 AM

Mar 15 2019

taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 15 2019, 10:07 AM
taapas1128 added a comment to D6038: push: added clear warning message when pushing closed branches(issue6080).

@pulkit done.

Mar 15 2019, 10:03 AM
taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 15 2019, 10:01 AM
taapas1128 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 15 2019, 9:42 AM

Mar 14 2019

taapas1128 added a comment to D6005: uncommit: added interactive mode -i(issue6062).

@martinvonz I have made the necessary modifications and updated the description.

Mar 14 2019, 12:08 PM
taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Mar 14 2019, 10:50 AM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 14 2019, 10:38 AM

Mar 13 2019

taapas1128 abandoned D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 13 2019, 3:28 AM
taapas1128 added a comment to D6115: unamend: added match as argument for scmutil.movedirstate.

Earlier it didn't but now it can I suppose it should after the modification. Is there supposed to be any other way to verify it ?(the tests pass successfully)

Mar 13 2019, 12:50 AM

Mar 12 2019

taapas1128 added a comment to D6115: unamend: added match as argument for scmutil.movedirstate.

I have added '*pats' as argument for unamend() , won't it serve as an optimisation now ?

Mar 12 2019, 8:49 PM
taapas1128 added inline comments to D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 12 2019, 3:05 PM
taapas1128 updated the diff for D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 12 2019, 3:03 PM
taapas1128 added a comment to D6005: uncommit: added interactive mode -i(issue6062).

I suppose no .. because in the very initial patch I combined hg uncommit with hg commit -i(as was stated in the bug description(https://bz.mercurial-scm.org/show_bug.cgi?id=6062)) . But later on I was asked to import it from evolve . The basic functionality lies in _interactiveuncommit() and the other two functions are imported as dependencies to that.

Mar 12 2019, 2:48 PM
taapas1128 updated the summary of D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 12 2019, 12:55 PM
taapas1128 updated the diff for D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 12 2019, 12:53 PM

Mar 11 2019

taapas1128 added a comment to D6117: uncommit: convert _fixdirstate() into _movedirstate().

In the documentation part don't you think there should be information about the matcher as there was before D971

Mar 11 2019, 2:55 PM
taapas1128 added a comment to D971: uncommit: unify functions _uncommitdirstate and _unamenddirstate to one.
Mar 11 2019, 2:54 PM
taapas1128 updated the summary of D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 11 2019, 1:28 PM
taapas1128 updated the diff for D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 11 2019, 1:22 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 11 2019, 1:18 PM
taapas1128 abandoned D6116: uncommit: updated explanation of _fixdirstate().
Mar 11 2019, 12:48 PM
taapas1128 added a comment to D6116: uncommit: updated explanation of _fixdirstate().

okay then I am closing this .

Mar 11 2019, 12:42 PM
taapas1128 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 11 2019, 12:38 PM
taapas1128 updated the summary of D6116: uncommit: updated explanation of _fixdirstate().
Mar 11 2019, 12:27 PM
taapas1128 updated the summary of D6116: uncommit: updated explanation of _fixdirstate().
Mar 11 2019, 12:22 PM
taapas1128 created D6116: uncommit: updated explanation of _fixdirstate().
Mar 11 2019, 12:19 PM
taapas1128 created D6115: unamend: added match as argument for scmutil.movedirstate.
Mar 11 2019, 11:59 AM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 11 2019, 11:50 AM
taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 11 2019, 11:39 AM

Mar 8 2019

taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 8 2019, 2:25 PM
taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 8 2019, 1:48 PM
taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 8 2019, 12:39 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 8 2019, 10:28 AM
taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 8 2019, 10:24 AM
taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 8 2019, 2:05 AM

Mar 7 2019

taapas1128 added inline comments to D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 4:02 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 4:00 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 3:04 PM
taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 3:01 PM
taapas1128 added a comment to D6005: uncommit: added interactive mode -i(issue6062).

@martinvonz cleaned it up .

Mar 7 2019, 3:01 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 2:59 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 2:53 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Mar 7 2019, 1:24 PM

Mar 2 2019

taapas1128 added a comment to D6038: push: added clear warning message when pushing closed branches(issue6080).

@mharbison72 done.

Mar 2 2019, 2:15 AM
taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 2 2019, 2:14 AM

Feb 28 2019

taapas1128 added a comment to D6005: uncommit: added interactive mode -i(issue6062).

@pulkit Thanks for pointing that out . That was extremely silly of me . I have corrected that . Is there anything else to be changed ?

Feb 28 2019, 4:46 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Feb 28 2019, 4:44 PM
taapas1128 updated the diff for D6038: push: added clear warning message when pushing closed branches(issue6080).
Feb 28 2019, 3:46 PM
taapas1128 updated subscribers of D6005: uncommit: added interactive mode -i(issue6062).

@pulkit I am unable to figure out why the output for test-unamend.t is changing . Any hint on that ?

Feb 28 2019, 2:19 PM
taapas1128 created D6038: push: added clear warning message when pushing closed branches(issue6080).
Feb 28 2019, 2:15 PM

Feb 22 2019

taapas1128 added a comment to D6005: uncommit: added interactive mode -i(issue6062).

@martinvonz I made the changes you asked . However I am not sure why test-unamend.t is changing because when interactive is false so it should behave exactly like the previous _fixdirstate() functioned . Can you provide some help with this ? I will work further based on your review.

Feb 22 2019, 2:51 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Feb 22 2019, 2:44 PM
taapas1128 updated the diff for D6005: uncommit: added interactive mode -i(issue6062).
Feb 22 2019, 1:33 PM
taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Feb 22 2019, 1:21 PM
taapas1128 updated the summary of D6005: uncommit: added interactive mode -i(issue6062).
Feb 22 2019, 1:21 PM
taapas1128 created D6005: uncommit: added interactive mode -i(issue6062).
Feb 22 2019, 1:18 PM

Feb 21 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@martinvonz Sure I will try to unify _fixdirstate() and _uncommitdirstate(). I will follow on the advancements you made. Should I send the new patch as a follow up or and altogether new patch making the amends in this?

Feb 21 2019, 12:32 PM

Feb 20 2019

taapas1128 committed rHG64d519ca44db: uncommit: added interactive mode(issue6062).
uncommit: added interactive mode(issue6062)
Feb 20 2019, 3:31 PM
taapas1128 closed D5792: uncommit: added interactive mode(issue6062).
Feb 20 2019, 3:16 PM
taapas1128 committed rHGedd5c8dc812e: uncommit: added interactive mode(issue6062).
uncommit: added interactive mode(issue6062)
Feb 20 2019, 3:16 PM

Feb 19 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 please review this whenever you are free.

Feb 19 2019, 12:09 PM

Feb 18 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

Thank you for your help @pulkit . I have rebased it to the top and updated the diff.

Feb 18 2019, 7:30 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Feb 18 2019, 7:29 AM

Feb 17 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 I have sent the patch for hg-stable repo (https://www.mercurial-scm.org/repo/hg-stable) . Maybe it is this the reason you are unable to apply the patch. Should I send a patch for hg repo ?

Feb 17 2019, 11:14 PM
taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 to which rev should I rebase it to ?

Feb 17 2019, 2:19 PM

Feb 16 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 I have made the change. Please review.

Feb 16 2019, 2:32 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Feb 16 2019, 2:31 AM

Feb 15 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I have updated the description .

Feb 15 2019, 10:35 AM
taapas1128 updated the summary of D5792: uncommit: added interactive mode(issue6062).
Feb 15 2019, 10:34 AM

Feb 12 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit Can you please review this . I did not send a patch regarding -n flag because tests could be completed without it and also it would mean i would have to import large chunks of code.

Feb 12 2019, 11:31 PM

Feb 8 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit Apparently it seems removing -n flag altogether will not interfere with the tests and they can be completed without that flag too . I have added inline comments please review. Also I am unable to use hg diff -r . -r precursor(.) so I used hg log -G --hidden in that place.

Feb 8 2019, 9:42 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Feb 8 2019, 9:29 AM

Feb 7 2019

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I have added some inline comments . So what do you suggest one way can be merging this and I will send a follow up for integrating -n to hg uncommitand then amending the tests. The other way is I should send a request for -n flag and then make all these changes again as a follow up pr for that request.

Feb 7 2019, 2:56 PM

Feb 4 2019

taapas1128 committed rHGd783c937aa53: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Feb 4 2019, 4:55 PM
taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I was able to import the tests and make them compatible with hg-stable . Some tests which include commands like hg obslog , hg amend --extract , and hg uncommit -n which are not part of hg-stable but evolve are not running else all tests are now running smoothly .

Feb 4 2019, 9:23 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Feb 4 2019, 9:19 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Feb 4 2019, 9:12 AM

Feb 3 2019

taapas1128 committed rHGa241b304129e: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Feb 3 2019, 11:58 PM
taapas1128 closed D5803: revert: added prompt before undeleting a file in -i(issue6008).
Feb 3 2019, 7:48 AM
taapas1128 committed rHGf3f6719951a3: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Feb 3 2019, 7:48 AM

Feb 2 2019

taapas1128 added a comment to D5803: revert: added prompt before undeleting a file in -i(issue6008).

@yuja thanks for the review . I have updated the revision please tell if anything else needs to be done.

Feb 2 2019, 11:18 PM
taapas1128 updated the diff for D5803: revert: added prompt before undeleting a file in -i(issue6008).
Feb 2 2019, 11:17 PM
taapas1128 updated the diff for D5803: revert: added prompt before undeleting a file in -i(issue6008).
Feb 2 2019, 3:06 PM
taapas1128 updated the summary of D5803: revert: added prompt before undeleting a file in -i(issue6008).
Feb 2 2019, 2:58 PM
taapas1128 created D5803: revert: added prompt before undeleting a file in -i(issue6008).
Feb 2 2019, 2:56 PM
taapas1128 updated the summary of D5792: uncommit: added interactive mode(issue6062).
Feb 2 2019, 1:16 PM