Page MenuHomePhabricator
Feed Advanced Search

Thu, Feb 25

Alphare added inline comments to D9843: revlog: introduce v2 format.
Thu, Feb 25, 11:46 AM

Wed, Feb 24

Alphare closed D10034: narrow: fix flaky behavior described in issue6150.
Wed, Feb 24, 11:07 AM
Alphare committed rHGb994db7c4d1e: narrow: fix flaky behavior described in issue6150.
narrow: fix flaky behavior described in issue6150
Wed, Feb 24, 11:07 AM
Alphare accepted D10064: re2: byteify some regex used to get check re2 availability.
Wed, Feb 24, 9:34 AM

Tue, Feb 23

D10018: tags: update the hgtagsfnodes cache if invalid file nodes are found now requires changes to proceed.

I'm waiting for the "next patch" mentioned in the commit message before this can be accepted, since the behavior changed from an abort to a silent omission of valid data, which is a regression.

Tue, Feb 23, 4:47 AM
Alphare accepted D10017: tags: return set of invalid nodes from _tagsfromfnodes().
Tue, Feb 23, 4:42 AM
Alphare accepted D10016: tags: return tag cache source from _readtagcache().
Tue, Feb 23, 4:41 AM
Alphare accepted D10015: debugtagscache: verify that filenode is correct.
Tue, Feb 23, 4:33 AM
Alphare accepted D9812: tests: demonstrate a case where a corrupt tag cache causes an abort.
Tue, Feb 23, 4:31 AM
Alphare added a comment to D10014: debugcommands: prevent using `is False`.

Is if foo == False valid in this case? I probably got my wires crossed with is None. (I'm fine with the code change here, just wondering for future reference.)

Tue, Feb 23, 4:20 AM
Alphare accepted D10013: hgtagsfnodes: refactor code to compute fnode into separate fn.
Tue, Feb 23, 4:16 AM
Alphare accepted D9994: error: remove shortening of node in error message.
Tue, Feb 23, 4:14 AM
Alphare added a comment to D9992: upgrade: speed up when we have only nodemap to downgrade.

I think I'd rather we also delete the docket file(s) and transaction files if we can, but this would not be a blocker for this patch in particular to land.

Tue, Feb 23, 4:11 AM
Alphare accepted D9991: upgrade: write nodemap for manifests too.
Tue, Feb 23, 4:02 AM
Alphare accepted D10033: helptext: fix a recent typo.
Tue, Feb 23, 4:00 AM

Mon, Feb 22

Alphare accepted D10047: test-copies: add subcase titles for various "conflicting" information variant.
Mon, Feb 22, 10:59 AM
Alphare accepted D10046: test-copies: improve description of the B+F case.
Mon, Feb 22, 10:52 AM
Alphare accepted D10045: test-copies: improve description of the C+H case.
Mon, Feb 22, 10:52 AM
Alphare accepted D10044: test-copies: improve description of the B+C "revert/restore" case.
Mon, Feb 22, 10:47 AM
Alphare accepted D10043: test-copies: improve description of the G+C case.
Mon, Feb 22, 10:43 AM
Alphare accepted D10042: test-copies: improve description of the G+F case.
Mon, Feb 22, 10:42 AM
Alphare accepted D10041: test-copies: improve description of the D+G case.
Mon, Feb 22, 10:40 AM
Alphare accepted D10040: test-copies: improve description of the A+E case.
Mon, Feb 22, 10:34 AM
Alphare accepted D10039: test-copies: improve description of the B+D case.
Mon, Feb 22, 10:33 AM
Alphare accepted D10038: test-copies: improve description of the B+C case.
Mon, Feb 22, 10:32 AM
Alphare accepted D10037: test-copies: improve description of the A+B case.
Mon, Feb 22, 10:30 AM
Alphare accepted D10036: test-copies: use intermediate variable some commit descriptions.
Mon, Feb 22, 10:30 AM
Alphare added inline comments to D10035: test-copies: don't use empty file for "same content" cases.
Mon, Feb 22, 10:28 AM

Fri, Feb 19

Alphare added a comment to D10034: narrow: fix flaky behavior described in issue6150.

/!\ This change is destined for the stable branch

Fri, Feb 19, 1:40 PM
Alphare created D10034: narrow: fix flaky behavior described in issue6150.
Fri, Feb 19, 1:38 PM
Alphare accepted D10010: rust: Add a log file rotation utility.
Fri, Feb 19, 7:57 AM
Alphare created D10026: changegroup: add v4 changegroup for revlog v2 exchange.
Fri, Feb 19, 6:18 AM
Alphare created D10032: sidedata-exchange: rewrite sidedata on-the-fly whenever possible.
Fri, Feb 19, 6:18 AM
Alphare created D10031: revlog-index: add `replace` method.
Fri, Feb 19, 6:17 AM
Alphare created D10030: revlogv2: temporarily forbid inline revlogs.
Fri, Feb 19, 6:17 AM
Alphare created D10028: sidedata-exchange: add `wanted_sidedata` and `sidedata_computers` to repos.
Fri, Feb 19, 6:17 AM
Alphare created D10029: changegroupv4: add sidedata helpers.
Fri, Feb 19, 6:17 AM
Alphare created D10027: delta: add sidedata field to revision delta.
Fri, Feb 19, 6:17 AM
Alphare created D10025: revlogv2: don't assume that the sidedata of the last rev is right after data.
Fri, Feb 19, 6:16 AM
Alphare created D10024: error: add `hint` attribute to `SidedataHashError`.
Fri, Feb 19, 6:15 AM
Alphare created D10023: changegroup: use the local variable instead of reaching through self.
Fri, Feb 19, 6:15 AM
D10010: rust: Add a log file rotation utility now requires review to proceed.

Alright, let’s try this: https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/18143
What’s a good workflow when I also have additional patches to add on top of the stack?

Fri, Feb 19, 6:10 AM
D10010: rust: Add a log file rotation utility now requires changes to proceed.

/!\ CI failed for this change after you last updated.

Fri, Feb 19, 5:41 AM
Alphare accepted D10022: rust: Add some unit tests for parse_byte_size in config.
Fri, Feb 19, 4:06 AM
Alphare accepted D10021: rust: Move config value parsing functions to a new module.
Fri, Feb 19, 4:05 AM
Alphare accepted D10012: rhg: Add support for the blackbox extension.
Fri, Feb 19, 4:05 AM
Alphare accepted D10010: rust: Add a log file rotation utility.
Fri, Feb 19, 4:01 AM
Alphare added inline comments to D10008: rust: Add config parsing support for more value types.
Fri, Feb 19, 3:52 AM

Thu, Feb 18

Alphare added inline comments to D10012: rhg: Add support for the blackbox extension.
Thu, Feb 18, 5:10 AM
Alphare accepted D10011: blackbox: Remove misleading quotes in config example.
Thu, Feb 18, 4:52 AM
Alphare added inline comments to D10010: rust: Add a log file rotation utility.
Thu, Feb 18, 4:52 AM
Alphare accepted D10009: rust: Add a `ConfigValueParseError` variant to common errors.
Thu, Feb 18, 4:35 AM
Alphare accepted D10008: rust: Add config parsing support for more value types.
Thu, Feb 18, 4:33 AM
Alphare accepted D10007: rust: Introduce a get_bytes_from_os_str utility function.
Thu, Feb 18, 4:18 AM
Alphare accepted D10006: rust: Make `DirstateParents`’s fields typed `Node`s.
Thu, Feb 18, 4:13 AM
Alphare accepted D10005: rust: Rewrite dirstate parsing usin the `bytes-cast` crate.
Thu, Feb 18, 4:13 AM
Alphare accepted D10004: rhg: Move `Repo` object creation into `main()`.
Thu, Feb 18, 3:57 AM
Alphare accepted D10003: rhg: Group values passed to every sub-command into a struct.
Thu, Feb 18, 3:53 AM
Alphare accepted D10002: rhg: Remove error message on unsupported CLI arguments.
Thu, Feb 18, 3:45 AM
Alphare added a comment to D10000: tests: add a test to demonstrate a bug in `hg diff --git` (issue6486).

FWIW, I've never had a patch fail to get the stable branch tag on Phab after a phabsend.

Thu, Feb 18, 3:42 AM

Mon, Feb 15

Alphare created D9993: sidedata: move to new sidedata storage in revlogv2.
Mon, Feb 15, 5:30 AM

Sun, Feb 14

Alphare closed D9986: bundle2: pass the operation source down to the changegroup.
Sun, Feb 14, 11:06 AM
Alphare committed rHG83ac7c91e172: bundle2: pass the operation source down to the changegroup.
bundle2: pass the operation source down to the changegroup
Sun, Feb 14, 11:05 AM

Fri, Feb 12

Alphare closed D9987: tests: fix differing output between py2 and py3.
Fri, Feb 12, 11:29 AM
Alphare committed rHGc3c7a86e9c24: tests: fix differing output between py2 and py3.
tests: fix differing output between py2 and py3
Fri, Feb 12, 11:29 AM
Alphare updated the summary of D9986: bundle2: pass the operation source down to the changegroup.
Fri, Feb 12, 9:04 AM
Alphare created D9987: tests: fix differing output between py2 and py3.
Fri, Feb 12, 6:57 AM
Alphare created D9986: bundle2: pass the operation source down to the changegroup.
Fri, Feb 12, 4:26 AM

Thu, Feb 11

Alphare closed D9977: rust-status: honor matcher when using the dirstate-only fast-path (issue6483).
Thu, Feb 11, 11:22 AM
Alphare committed rHGfb6eca7b8c63: rust-status: honor matcher when using the dirstate-only fast-path (issue6483).
rust-status: honor matcher when using the dirstate-only fast-path (issue6483)
Thu, Feb 11, 11:22 AM
Alphare closed D9976: status: add test that shows that the Rust implementation has a bug.
Thu, Feb 11, 11:22 AM
Alphare committed rHG40c8ae49561d: status: add test that shows that the Rust implementation has a bug.
status: add test that shows that the Rust implementation has a bug
Thu, Feb 11, 11:22 AM

Wed, Feb 10

Alphare added a comment to D9976: status: add test that shows that the Rust implementation has a bug.

/!\ This patch and the next are destined for the stable branch /!\

Wed, Feb 10, 4:28 PM
Alphare created D9977: rust-status: honor matcher when using the dirstate-only fast-path (issue6483).
Wed, Feb 10, 4:27 PM
Alphare created D9976: status: add test that shows that the Rust implementation has a bug.
Wed, Feb 10, 4:27 PM
Alphare accepted D9924: config: use a new `alter` method in `fixconfig`.
Wed, Feb 10, 4:39 AM

Tue, Feb 9

Alphare accepted D9927: config: use level to properly deal with value priority.
Tue, Feb 9, 3:37 PM
Alphare added a comment to D9972: rhg: add limited support for the `config` sub-command.

Yes, when typing that hg cp command I thought that this copy record isn’t wrong since that’s indeed how the new file started. Is there a reason to prefer *not* having that recorded as a copy?

Tue, Feb 9, 3:36 PM
Alphare added a comment to D9972: rhg: add limited support for the `config` sub-command.

It looks like you've recorded copy information about rust/rhg/src/commands/root.rs and rust/rhg/src/commands/config.rs. Was that on purpose?

Tue, Feb 9, 4:33 AM
Alphare added a comment to D9971: rhg: Add support for --config CLI arguments.

I see that tests are added in the next patch, which makes sense considering we've avoided needing config so far.

Tue, Feb 9, 4:28 AM
Alphare added inline comments to D9970: rhg: Add support for -R and --repository command-line arguments.
Tue, Feb 9, 4:21 AM
Alphare added inline comments to D9969: rhg: Replace subcommand boilerplate with a macro.
Tue, Feb 9, 4:18 AM
Alphare added inline comments to D9967: rhg: replace command structs with functions.
Tue, Feb 9, 4:12 AM
Alphare accepted D9969: rhg: Replace subcommand boilerplate with a macro.
Tue, Feb 9, 4:03 AM
Alphare accepted D9968: rhg: Move subcommand CLI arguments definitions to respective modules.
Tue, Feb 9, 3:54 AM
Alphare accepted D9967: rhg: replace command structs with functions.
Tue, Feb 9, 3:53 AM
Alphare accepted D9966: rust: Use the DisplayBytes trait in config printing.
Tue, Feb 9, 3:45 AM
Alphare added a comment to D9964: rhg: Parse per-repository configuration.

I saw that you updated the code, looks good to me!

Tue, Feb 9, 3:42 AM
Alphare added inline comments to D9964: rhg: Parse per-repository configuration.
Tue, Feb 9, 3:41 AM
Alphare accepted D9961: rust: Parse system and user configuration.
Tue, Feb 9, 3:39 AM
Alphare accepted D9960: rust: Remove unnecessary check for absolute path before joining.
Tue, Feb 9, 3:33 AM

Mon, Feb 8

Alphare added inline comments to D9964: rhg: Parse per-repository configuration.
Mon, Feb 8, 11:56 AM
Alphare added inline comments to D9964: rhg: Parse per-repository configuration.
Mon, Feb 8, 11:46 AM
Alphare accepted D9884: changegroup: don't convert revisions to node for duplicate handling.
Mon, Feb 8, 9:50 AM
Alphare accepted D9882: revlog: change addrevision to return the new revision, not node.
Mon, Feb 8, 9:46 AM
Alphare accepted D9946: copy-tracing: add a --compute flag to debugchangedfiles.
Mon, Feb 8, 9:44 AM
Alphare accepted D9954: bundle2: print "error:abort" message to stderr instead of stdout.
Mon, Feb 8, 9:42 AM
Alphare added inline comments to D9964: rhg: Parse per-repository configuration.
Mon, Feb 8, 9:38 AM
Alphare accepted D9963: rhg: Abort based on config on share-safe mismatch.
Mon, Feb 8, 9:29 AM
Alphare accepted D9962: rhg: Parse system and user configuration at program start.
Mon, Feb 8, 9:26 AM