Mon, Nov 11
Sun, Nov 10
Fri, Nov 8
Note that there is a comment in match.py about util.dirs. It's not that important, but it should be updated.
You're right, it shouldn't
Thanks, I was going to get bitten by this!
I'll rebase this series once my other patches land, to make it easier to get all instances of HashMap in the codebase.
Thu, Nov 7
Thanks for the review @kevincox.
Wed, Nov 6
phabsend failed with the following:
Tue, Nov 5
Thu, Oct 31
Tue, Oct 29
Fri, Oct 18
@@ -919,6 +919,9 @@matchalways = match.always() matchtdir = match.traversedir dmap = self._map
+ if rustmod is not None:
+ dmap = self._map._rustmap
If it's the same trick, can't it be abstracted away? if rustmod seems weird.
Thu, Oct 17
I've seen very good results with https://github.com/servo/rust-fnv in the past so it is probably worth including that in the comparison and possibly using it. It is especially good for small keys which seems like a common case in hg.