Note that there is a comment in match.py about util.dirs. It's not that important, but it should be updated.

You're right, it shouldn't

Thanks, I was going to get bitten by this!

I'll rebase this series once my other patches land, to make it easier to get all instances of HashMap in the codebase.

Thanks for the review @kevincox.

phabsend failed with the following:

In D7118#104834, @yuja wrote:

+++ b/mercurial/dirstate.py
@@ -919,6 +919,9 @@

matchalways = match.always()
matchtdir = match.traversedir
dmap = self._map

+ if rustmod is not None:
+ dmap = self._map._rustmap

If it's the same trick, can't it be abstracted away? if rustmod seems weird.

In D7116#104685, @kevincox wrote:

I've seen very good results with https://github.com/servo/rust-fnv in the past so it is probably worth including that in the comparison and possibly using it. It is especially good for small keys which seems like a common case in hg.