- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 16 2021
Jan 13 2021
Jan 12 2021
Oct 2 2020
Updated so only dispatch.py patches sys.std* directly
Updated to remove the warning and open a separate stderr.
Sep 27 2020
In D9058#135940, @indygreg wrote:This looks like a legit bug fix. And when I see patches like this, I wonder what circumstances led to its discovery :p
Sep 22 2020
Sep 18 2020
Feb 16 2020
Jan 31 2020
No, initially because I'd never heard of it, but now because I don't want to deal with ocaml. :)
Have pyre been considered? It seems pyre only takes 10 seconds to check all the .py files.
Jan 30 2020
What do you think about this approach:
Jan 9 2020
You can use rustfmt +nightly if it's installed by rustup. It also runs on Windows.
Dec 13 2019
--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?
Dec 7 2019
We actually ran rustfmt, but it's an older version (rustfmt 1.3.0-stable (d334502 2019-06-09)) and I verified the code still formats under that particular version of rustfmt with empty rustfmt.toml. In other words, rustfmt itself seems to change over time.
No longer use this approach.
No longer use this approach.
Took another approach.
No longer needed.
Dec 3 2019
Nov 26 2019
Nov 25 2019
Oct 3 2018
Pushed. Thanks!
Sep 13 2018
Pushed. Thanks!
If backward compatibility is a concern, then there are way too many places that need change.
No, hg-experimental didn't care about compatibility with older Mercurial. Otherwise the code would be a mess.
Pushed these. Thanks!
Sep 4 2018
Aug 29 2018
Thanks for the change! A more common way to handle this is to catch ImportError to detect old versions, and try to deal with the divergence at import time:
Aug 14 2018
Pushed. Thanks!
Aug 9 2018
To clarify, I do think stateless API is better. It can be done by keeping _lastannotate as a private cache inaccessible from other APIs, move annotateresult to the return value of annotate, then add arev to replacelines to verify the cache. The C code use brev instead of rev as the parameter name for a reason.
Aug 7 2018
Aug 6 2018
Pushed. Thanks!
Aug 3 2018
--stack should work as expected if dependency is set manually.
In D4049#63026, @martinvonz wrote:
Aug 2 2018
I'd also like to see C linelog benchmark data mentioned. The current commit message implies diff algorithm is the bottleneck. That's misleading.
Aug 1 2018
I would mention in the commit message that building cache is much faster with linkrevcache prebuilt.
I think a most flexible solution is to not do the check if there is nothing to rebase.
Jul 31 2018
FB has users reporting they need to split commits in the middle of a histedit. So this might be too restrictive.
Jul 25 2018
Yeah, if only there is a json.loadb function. That could replace json.loads at line 211. I guess it could be done by using a function that recursively convert strings.
Jul 24 2018
Pushed. Thanks!