Page MenuHomePhabricator
Feed Advanced Search

Tue, Sep 17

durin42 closed D6862: tests: clean up built binaries after running test-fuzz-targets.t.
Tue, Sep 17, 3:58 PM
durin42 closed D6861: fastannotate: remove support for flock() locking.
Tue, Sep 17, 3:58 PM
durin42 committed rHG39cab871e880: tests: clean up built binaries after running test-fuzz-targets.t.
tests: clean up built binaries after running test-fuzz-targets.t
Tue, Sep 17, 3:58 PM
durin42 committed rHG0152a907f714: fastannotate: remove support for flock() locking.
fastannotate: remove support for flock() locking
Tue, Sep 17, 3:57 PM
durin42 committed rHG5316f9ff3e48: remotefilelog: remove dead code for using flock() for locking.
remotefilelog: remove dead code for using flock() for locking
Tue, Sep 17, 3:57 PM
durin42 closed D6860: remotefilelog: remove dead code for using flock() for locking.
Tue, Sep 17, 3:57 PM
durin42 created D6862: tests: clean up built binaries after running test-fuzz-targets.t.
Tue, Sep 17, 3:10 PM
durin42 created D6861: fastannotate: remove support for flock() locking.
Tue, Sep 17, 2:27 PM
durin42 created D6860: remotefilelog: remove dead code for using flock() for locking.
Tue, Sep 17, 2:27 PM
D6816: flagprocessors: writetransform function take side data as parameter (API) is now accepted and ready to land.
Tue, Sep 17, 2:14 PM
D6815: flagprocessors: add a `sidedata` parameters to _processflagswrite is now accepted and ready to land.
Tue, Sep 17, 2:14 PM
D6814: revlog: add a `sidedata` parameters to addrevision now requires changes to proceed.
Tue, Sep 17, 2:14 PM
D6813: flagprocessors: have the read transform function return side data (API) is now accepted and ready to land.
Tue, Sep 17, 2:13 PM
D6812: flagprocessors: return flagdata in the main processing function is now accepted and ready to land.
Tue, Sep 17, 2:11 PM
D6811: flagprocessors: return sidedata map in `_processflagsread` is now accepted and ready to land.
Tue, Sep 17, 2:10 PM
D6810: revlog: use the new sidedata map return in the sidedata method is now accepted and ready to land.
Tue, Sep 17, 2:10 PM
D6809: revlog: return sidedata map from `_revisiondata` is now accepted and ready to land.
Tue, Sep 17, 2:08 PM
D6808: revlog: introduce a `sidedata` method is now accepted and ready to land.
Tue, Sep 17, 2:05 PM

Mon, Sep 16

durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Mon, Sep 16, 10:27 AM

Sat, Sep 14

durin42 closed D6836: interfaces: introduce an interface for dirstate implementations.
Sat, Sep 14, 11:34 AM
durin42 closed D6839: idirstate: group private methods and attrs that are in the interface.
Sat, Sep 14, 11:34 AM
durin42 committed rHG97b79354e9f0: idirstate: group private methods and attrs that are in the interface.
idirstate: group private methods and attrs that are in the interface
Sat, Sep 14, 11:34 AM
durin42 committed rHGbbd154627a72: idirstate: remove now non-public _map attribute.
idirstate: remove now non-public _map attribute
Sat, Sep 14, 11:34 AM
durin42 closed D6838: idirstate: remove now non-public _map attribute.
Sat, Sep 14, 11:34 AM
durin42 committed rHGd459cd8ea42d: interfaces: introduce an interface for dirstate implementations.
interfaces: introduce an interface for dirstate implementations
Sat, Sep 14, 11:34 AM

Fri, Sep 13

durin42 added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass.
I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.

Fri, Sep 13, 9:40 AM

Thu, Sep 12

durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Thu, Sep 12, 5:52 PM
durin42 closed D6837: cleanup: fix leakage of dirstate._map to client code.
Thu, Sep 12, 2:27 AM
durin42 committed rHG34ed651ba7e4: cleanup: fix leakage of dirstate._map to client code.
cleanup: fix leakage of dirstate._map to client code
Thu, Sep 12, 2:26 AM

Wed, Sep 11

durin42 added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

We're really close. I've uploaded my rebase of this to the latest dev hg (along with some minor test fixes). There's now only one failure:

Wed, Sep 11, 2:07 PM
durin42 updated the diff for D6776: bookmarks: validate changes on push (issue6193) (BC).
Wed, Sep 11, 2:06 PM
durin42 added a comment to D4664: mergecommit: add a new extension to merge in-memory and create a commit.

Neat. I assume you normally check these out later?

Wed, Sep 11, 11:29 AM
durin42 abandoned D6479: shelve: first prototype of storing/restoring unresolved changes.
Wed, Sep 11, 11:28 AM
durin42 added a reviewer for D6479: shelve: first prototype of storing/restoring unresolved changes: navaneeth.suresh.
Wed, Sep 11, 11:28 AM
D6678: continue: added support for histedit is now accepted and ready to land.
Wed, Sep 11, 11:28 AM
D6665: continue: added support for graft is now accepted and ready to land.
Wed, Sep 11, 11:27 AM
D6659: graft: split graft code into seperate functions now requires changes to proceed.
Wed, Sep 11, 11:27 AM
durin42 added a comment to D6735: update: added support for --abort flag(issue4404).

This looks good to me. Does anyone else have comments? @mharbison72 are you happy with the subrepo test coverage?

Wed, Sep 11, 11:24 AM
durin42 added a comment to D6709: config: add --registered flag to show all known configs.

I'm okay with this as-is. Barring an objection in a week or so I'll queue it.

Wed, Sep 11, 11:22 AM
durin42 retitled D6776: bookmarks: validate changes on push (issue6193) (BC) from bookmarks: validate changes on push to bookmarks: validate changes on push (issue6193) (BC).
Wed, Sep 11, 10:33 AM
D6776: bookmarks: validate changes on push (issue6193) (BC) now requires changes to proceed.

I've uploaded my revised version (with the more complete commit message - no other changes) in case that helps.

Wed, Sep 11, 10:32 AM
durin42 added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I get a fair number of test failures with this, eg test-bookmarks-corner-case.t:

Wed, Sep 11, 10:31 AM
D6776: bookmarks: validate changes on push (issue6193) (BC) is now accepted and ready to land.

Queued this with lots of content added to the commit message. Thanks!

Wed, Sep 11, 10:16 AM
durin42 added a comment to D6837: cleanup: fix leakage of dirstate._map to client code.
  1. In lfs, where we deal with standins and mutating status.

s/lfs/largefiles/?

Wed, Sep 11, 9:54 AM
durin42 updated the summary of D6837: cleanup: fix leakage of dirstate._map to client code.
Wed, Sep 11, 9:53 AM

Tue, Sep 10

durin42 created D6837: cleanup: fix leakage of dirstate._map to client code.
Tue, Sep 10, 10:02 AM
durin42 created D6839: idirstate: group private methods and attrs that are in the interface.
Tue, Sep 10, 10:01 AM
durin42 created D6836: interfaces: introduce an interface for dirstate implementations.
Tue, Sep 10, 10:01 AM
durin42 created D6838: idirstate: remove now non-public _map attribute.
Tue, Sep 10, 10:01 AM

Mon, Sep 9

durin42 committed rHGf059d6ffcdf0: merge with stable.
merge with stable
Mon, Sep 9, 5:28 PM
durin42 added a comment to D6808: revlog: introduce a `sidedata` method.

FWIW I'm +0.5 on this because it seems like a reasonable abstraction and could serve a variety of purposes.

Mon, Sep 9, 2:01 PM
durin42 added inline comments to D6821: flagprocessors: directly duplicate the deprecated layer back into revlog.
Mon, Sep 9, 2:00 PM
D6822: flagprocessors: move _flagserrorclass attribute on revlog & co is now accepted and ready to land.
Mon, Sep 9, 1:57 PM
D6821: flagprocessors: directly duplicate the deprecated layer back into revlog is now accepted and ready to land.
Mon, Sep 9, 1:56 PM
D6820: flagprocessors: make `processflagsraw` a module level function is now accepted and ready to land.
Mon, Sep 9, 1:55 PM
D6819: flagprocessors: make `processflagsread` a module level function is now accepted and ready to land.
Mon, Sep 9, 1:55 PM
D6818: flagprocessors: make `processflagswrite` a module level function is now accepted and ready to land.
Mon, Sep 9, 1:55 PM
D6817: flagprocessors: make `_processflagsfunc` a module level function is now accepted and ready to land.
Mon, Sep 9, 1:54 PM
D6823: flagprocessors: remove flagprocessorsmixin is now accepted and ready to land.
Mon, Sep 9, 1:53 PM
D6814: revlog: add a `sidedata` parameters to addrevision now requires changes to proceed.
Mon, Sep 9, 1:52 PM
durin42 closed D6732: localrepo: push manifestlog and changelog construction code into store.
Mon, Sep 9, 12:09 PM
durin42 committed rHG3df3b139a43d: localrepo: push manifestlog and changelog construction code into store.
localrepo: push manifestlog and changelog construction code into store
Mon, Sep 9, 12:08 PM
durin42 added a comment to D6754: contrib: proof of concept script to build Mac packages without system python.

This is a start, but I suspect where we should end up with this is downloading and compiling the whole Python distribution, rather than relying on a virtualenv to be portable?

Mon, Sep 9, 11:51 AM
durin42 added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

Clarifying I understand: this causes pushing a bookmark to fail in what cases that it currently succeeds? I think it's just the case of:

Mon, Sep 9, 11:42 AM
durin42 added a comment to D6825: contrib: start building a library for simple hooks.

I like where this is going, but I wonder if these specific hooks can be written without being in-process Python hooks. Reason being that Python hooks use the unstable internals of hg and are semi-discouraged if they're avoidable.

Mon, Sep 9, 11:29 AM
durin42 updated subscribers of D6789: check-code: allow command substitution with $(command).

I went through the history of this line and sadly it came into existence with the initial check-code.py commit. However, I got to use hg grep for the purpose nobody uses (!) and found this:

Mon, Sep 9, 10:52 AM

Thu, Sep 5

durin42 updated the diff for D6732: localrepo: push manifestlog and changelog construction code into store.
Thu, Sep 5, 3:21 PM
durin42 updated the diff for D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Thu, Sep 5, 3:20 PM
durin42 added a comment to D6732: localrepo: push manifestlog and changelog construction code into store.

Ping on this - can we get this landed to unblock my experimentation?

Thu, Sep 5, 3:20 PM
durin42 committed rHGb22a8dadc6f5: Added signature for changeset a4e32fd539ab.
Added signature for changeset a4e32fd539ab
Thu, Sep 5, 2:25 PM
durin42 committed rHG662a4ae78a6d: Added tag 5.1.1 for changeset a4e32fd539ab.
Added tag 5.1.1 for changeset a4e32fd539ab
Thu, Sep 5, 2:25 PM

Fri, Aug 23

durin42 committed rHG50e25f30da9c: merge with stable.
merge with stable
Fri, Aug 23, 5:08 PM
durin42 updated the diff for D6522: tracing: add many more timedcm() calls throughout the codebase.
Fri, Aug 23, 5:06 PM
durin42 updated the diff for D6527: dirstate: add counter events for work queue depth.
Fri, Aug 23, 5:05 PM

Thu, Aug 22

durin42 abandoned D6748: hgit: define invalidatecaches for gitstore().
Thu, Aug 22, 10:11 AM
durin42 added a reviewer for D6748: hgit: define invalidatecaches for gitstore(): pulkit.
Thu, Aug 22, 10:11 AM
durin42 abandoned D6747: hgit: fix some pyflakes and check-code warning.
Thu, Aug 22, 10:11 AM
durin42 added a reviewer for D6747: hgit: fix some pyflakes and check-code warning: pulkit.
Thu, Aug 22, 10:11 AM
durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Thu, Aug 22, 10:04 AM
durin42 added a comment to D6732: localrepo: push manifestlog and changelog construction code into store.

I think pushing it down into the store makes a reasonable amount of sense, since it's going to be pretty heavily tied to the revision storage mechanism...

Thu, Aug 22, 10:02 AM
durin42 added a comment to D6747: hgit: fix some pyflakes and check-code warning.

Folded this and D6748 back into 6734, many thanks!

Thu, Aug 22, 10:01 AM

Aug 20 2019

durin42 committed rHG624d86262e14: setup: fix a sorting issue I noticed in package names.
setup: fix a sorting issue I noticed in package names
Aug 20 2019, 12:01 PM
durin42 added a comment to D6741: interfaces: create a new folder for interfaces and move repository.py in it.
In D6741#99023, @pulkit wrote:

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help with future patches? Or you just like this structure better?

Looking through Augie's hgit patch, I found we need to add more interfaces and decided to work on adding for store.basicstore. I found all the current interfaces in repository.py which has grown very large. I decided to create a new file to have interface for the store class, and maybe a new one for dirstate too, and having them in a separate folder dedicated to interfaces will be nice.

Aug 20 2019, 11:10 AM

Aug 17 2019

durin42 closed D6733: setup: fix a sorting issue I noticed in package names.
Aug 17 2019, 5:05 PM
durin42 committed rHGf299555785c5: setup: fix a sorting issue I noticed in package names.
setup: fix a sorting issue I noticed in package names
Aug 17 2019, 5:05 PM
durin42 committed rHG791791a1fd4e: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Aug 17 2019, 2:50 AM

Aug 16 2019

durin42 created D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Aug 16 2019, 4:54 PM
durin42 created D6732: localrepo: push manifestlog and changelog construction code into store.
Aug 16 2019, 4:54 PM
durin42 created D6733: setup: fix a sorting issue I noticed in package names.
Aug 16 2019, 4:54 PM
durin42 committed rHG302dbc9d52be: tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1)
Aug 16 2019, 8:44 AM
durin42 closed D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Aug 16 2019, 5:47 AM
durin42 committed rHG55f59a25c593: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1)
Aug 16 2019, 5:47 AM

Aug 15 2019

durin42 created D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Aug 15 2019, 11:23 AM
durin42 added a comment to D6709: config: add --registered flag to show all known configs.

Looks good to me, but I want someone else to put eyes on it before it gets pushed.

Aug 15 2019, 11:13 AM
durin42 committed rHG034b2bf377f0: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Aug 15 2019, 11:08 AM
durin42 closed D6725: tests: split joint repo/changelog fake into one for each type.
Aug 15 2019, 11:08 AM
durin42 added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

Aug 15 2019, 11:05 AM

Aug 14 2019

durin42 created D6725: tests: split joint repo/changelog fake into one for each type.
Aug 14 2019, 4:14 PM
durin42 added a comment to D6430: rust-discovery: using from Python code.

I'm not thrilled with this - it's a lot of code, and I think there are some simpler options that haven't been explored. For example, clients could use the logexchange infrastructure to prime the sampling process and do a lot better.

Aug 14 2019, 4:12 PM
durin42 added inline comments to D6517: rust-discovery: read the index from a repo passed at init.
Aug 14 2019, 3:27 PM