I'm -0 on auto-formatting third-party code at all, and that includes zstandard stuff. Why do we care if it's in the ignorelist?
Wed, Jan 22
I'm +1 on having this functionality in core, FYI.
Yes, I'll move this to stable.
Tue, Jan 21
Sat, Jan 18
Yes, I'd appreciate not adding any assumptions that nodes are 20 bytes.
Thu, Jan 16
Does mercurial currently use RE2? If not then can you explain why we don't just use the rust regex crate?
Tue, Jan 14
Mon, Jan 13
Good call on tests, I had the return type of hexdigest() wrong. Please do let me know if you think of any missing cases here.
Wed, Jan 8
Now that D7570 is landed, this is obsolete, right?
I'm a little lost on the state of this. It looks like we need to downgrade the required Rust version?
I only did a light pass, but looks good to me.
Tue, Jan 7
Mon, Jan 6
Dec 17 2019
Dec 16 2019
Dec 12 2019
Dec 11 2019
This needs a rebase that I'm not sure I can accomplish correctly. Could you take a look?
I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).
I'm a little fuzzy on this: should I see some test failures? or...?
Dec 10 2019
What are we depending on in the rustfmt settings that's nightly behavior?
Dec 9 2019
Note: please review the embedded Python segments carefully, as it's a little fidgety to get right and verify I didn't do something Really Dumb.