Page MenuHomePhabricator
Feed Advanced Search

Yesterday

durin42 added a comment to D7937: python-zstandard: blacken at 80 characters.

I'm -0 on auto-formatting third-party code at all, and that includes zstandard stuff. Why do we care if it's in the ignorelist?

Thu, Jan 23, 12:28 PM

Wed, Jan 22

durin42 added a comment to D7932: [RFC]debugbackups: introduce command to interact with strip backups.

I'm +1 on having this functionality in core, FYI.

Wed, Jan 22, 11:40 AM
durin42 added a comment to D7964: cext: change two more vars to Py_ssize_t in manifest.c.

Yes, I'll move this to stable.

Wed, Jan 22, 10:55 AM

Tue, Jan 21

durin42 committed rHG84a0102c05c7: merge to stable for 5.3 release freeze.
merge to stable for 5.3 release freeze
Tue, Jan 21, 1:22 PM
durin42 committed rHG3246cd5310b0: Added signature for changeset 84a0102c05c7.
Added signature for changeset 84a0102c05c7
Tue, Jan 21, 1:22 PM
durin42 committed rHG266c42c60183: Added tag 5.3rc0 for changeset 84a0102c05c7.
Added tag 5.3rc0 for changeset 84a0102c05c7
Tue, Jan 21, 1:22 PM

Sat, Jan 18

durin42 added a comment to D7788: rust-node: binary Node ID and conversion utilities.

Yes, I'd appreciate not adding any assumptions that nodes are 20 bytes.

Sat, Jan 18, 6:18 PM

Thu, Jan 16

durin42 added a comment to D7910: rust-re2: add wrapper for calling Re2 from Rust.

Does mercurial currently use RE2? If not then can you explain why we don't just use the rust regex crate?

Thu, Jan 16, 10:43 AM

Tue, Jan 14

durin42 committed rHG451d22174b5f: revlog: run rustfmt nightly.
revlog: run rustfmt nightly
Tue, Jan 14, 11:39 AM
durin42 committed rHG5e0505d36aee: examples: specify rustfmt nightly using a $() construct.
examples: specify rustfmt nightly using a $() construct
Tue, Jan 14, 11:39 AM
durin42 committed rHG2d49482d0dd4: hgext: replace references to hashlib.sha1 with hashutil.sha1.
hgext: replace references to hashlib.sha1 with hashutil.sha1
Tue, Jan 14, 11:39 AM
durin42 committed rHGcbc5755df6bf: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1.
sslutil: migrate to hashutil.sha1 instead of hashlib.sha1
Tue, Jan 14, 11:39 AM
durin42 committed rHGa61287a95dc3: core: migrate uses of hashlib.sha1 to hashutil.sha1.
core: migrate uses of hashlib.sha1 to hashutil.sha1
Tue, Jan 14, 11:38 AM
durin42 committed rHG7126d8b8e0e6: hashutil: new package for hashing-related features.
hashutil: new package for hashing-related features
Tue, Jan 14, 11:38 AM
durin42 committed rHG019fea5edf0c: revlog: run rustfmt nightly.
revlog: run rustfmt nightly
Tue, Jan 14, 11:37 AM
durin42 committed rHG229a1e17df58: examples: specify rustfmt nightly using a $() construct.
examples: specify rustfmt nightly using a $() construct
Tue, Jan 14, 11:37 AM
durin42 committed rHG6f40a1e56b61: hgext: replace references to hashlib.sha1 with hashutil.sha1.
hgext: replace references to hashlib.sha1 with hashutil.sha1
Tue, Jan 14, 11:37 AM
durin42 committed rHGe5db237545c2: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1.
sslutil: migrate to hashutil.sha1 instead of hashlib.sha1
Tue, Jan 14, 11:37 AM
durin42 committed rHG0ac0dbcd5b86: core: migrate uses of hashlib.sha1 to hashutil.sha1.
core: migrate uses of hashlib.sha1 to hashutil.sha1
Tue, Jan 14, 11:37 AM
durin42 committed rHGf7d2aa335cc2: hashutil: new package for hashing-related features.
hashutil: new package for hashing-related features
Tue, Jan 14, 11:37 AM
durin42 closed D7812: examples: specify rustfmt nightly using a $() construct.
Tue, Jan 14, 11:13 AM
durin42 closed D7813: revlog: run rustfmt nightly.
Tue, Jan 14, 11:13 AM
durin42 committed rHG625691953552: revlog: run rustfmt nightly.
revlog: run rustfmt nightly
Tue, Jan 14, 11:13 AM
durin42 committed rHG6e13b31f83b5: examples: specify rustfmt nightly using a $() construct.
examples: specify rustfmt nightly using a $() construct
Tue, Jan 14, 11:13 AM

Mon, Jan 13

durin42 closed D7849: core: migrate uses of hashlib.sha1 to hashutil.sha1.
Mon, Jan 13, 11:44 PM
durin42 closed D7851: hgext: replace references to hashlib.sha1 with hashutil.sha1.
Mon, Jan 13, 11:42 PM
durin42 closed D7814: sha1dc: import latest version from github.
Mon, Jan 13, 11:41 PM
durin42 committed rHG006e7821704a: hgext: replace references to hashlib.sha1 with hashutil.sha1.
hgext: replace references to hashlib.sha1 with hashutil.sha1
Mon, Jan 13, 11:40 PM
durin42 closed D7815: sha1dc: initial implementation of Python extension.
Mon, Jan 13, 11:40 PM
durin42 committed rHGfde05ece875c: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1.
sslutil: migrate to hashutil.sha1 instead of hashlib.sha1
Mon, Jan 13, 11:40 PM
durin42 closed D7850: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1.
Mon, Jan 13, 11:40 PM
durin42 committed rHG4ebd162f4d8c: core: migrate uses of hashlib.sha1 to hashutil.sha1.
core: migrate uses of hashlib.sha1 to hashutil.sha1
Mon, Jan 13, 11:39 PM
durin42 committed rHG0803f803ba03: hashutil: new package for hashing-related features.
hashutil: new package for hashing-related features
Mon, Jan 13, 11:39 PM
durin42 committed rHGbde1cd4c99d9: sha1dc: initial implementation of Python extension.
sha1dc: initial implementation of Python extension
Mon, Jan 13, 11:39 PM
durin42 closed D7848: hashutil: new package for hashing-related features.
Mon, Jan 13, 11:39 PM
durin42 committed rHG7dddc2251365: sha1dc: import latest version from github.
sha1dc: import latest version from github
Mon, Jan 13, 11:39 PM
durin42 created D7849: core: migrate uses of hashlib.sha1 to hashutil.sha1.
Mon, Jan 13, 5:52 PM
durin42 created D7851: hgext: replace references to hashlib.sha1 with hashutil.sha1.
Mon, Jan 13, 5:49 PM
durin42 updated the diff for D7814: sha1dc: import latest version from github.
Mon, Jan 13, 5:49 PM
durin42 created D7850: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1.
Mon, Jan 13, 5:48 PM
durin42 updated the diff for D7815: sha1dc: initial implementation of Python extension.
Mon, Jan 13, 5:48 PM
durin42 created D7848: hashutil: new package for hashing-related features.
Mon, Jan 13, 5:48 PM
durin42 added a comment to D7815: sha1dc: initial implementation of Python extension.

Good call on tests, I had the return type of hexdigest() wrong. Please do let me know if you think of any missing cases here.

Mon, Jan 13, 4:55 PM

Wed, Jan 8

durin42 retitled D7815: sha1dc: initial implementation of Python extension from sha1dc: initial implementation of Python extension (NOT READY) to sha1dc: initial implementation of Python extension.
Wed, Jan 8, 8:30 PM
durin42 added inline comments to D7815: sha1dc: initial implementation of Python extension.
Wed, Jan 8, 5:41 PM
durin42 updated the diff for D7815: sha1dc: initial implementation of Python extension.
Wed, Jan 8, 5:39 PM
durin42 updated the summary of D7815: sha1dc: initial implementation of Python extension.
Wed, Jan 8, 5:38 PM
durin42 updated the diff for D7814: sha1dc: import latest version from github.
Wed, Jan 8, 4:39 PM
durin42 updated the diff for D7815: sha1dc: initial implementation of Python extension.
Wed, Jan 8, 4:31 PM
durin42 created D7814: sha1dc: import latest version from github.
Wed, Jan 8, 4:28 PM
durin42 created D7815: sha1dc: initial implementation of Python extension.
Wed, Jan 8, 4:27 PM
durin42 added a comment to D7617: fix: make example fix hgrc work in subdirs.

Now that D7570 is landed, this is obsolete, right?

Wed, Jan 8, 3:02 PM
D7712: lfs: don't skip locally available blobs when verifying now requires changes to proceed.

Needs rebased.

Wed, Jan 8, 3:00 PM
durin42 added a comment to D7576: hg-core: add configparser to library.

I'm a little lost on the state of this. It looks like we need to downgrade the required Rust version?

Wed, Jan 8, 2:58 PM
durin42 added inline comments to D7808: mmap: add a size argument to mmapread.
Wed, Jan 8, 2:55 PM
durin42 created D7813: revlog: run rustfmt nightly.
Wed, Jan 8, 2:38 PM
durin42 created D7812: examples: specify rustfmt nightly using a $() construct.
Wed, Jan 8, 2:38 PM
durin42 added a comment to D7733: hgext: initial version of fastexport extension.

I only did a light pass, but looks good to me.

Wed, Jan 8, 2:30 PM
durin42 updated subscribers of D7807: hgrc: introduce HGRCSKIPREPO to skip reading the repository's hgrc.
Wed, Jan 8, 11:31 AM

Tue, Jan 7

durin42 committed rHG60de488cad11: merge with stable.
merge with stable
Tue, Jan 7, 9:26 AM

Mon, Jan 6

durin42 committed rHGb89144b81c5d: Added signature for changeset b4c82b704180.
Added signature for changeset b4c82b704180
Mon, Jan 6, 4:40 PM
durin42 committed rHG453c4f07de0f: Added tag 5.2.2 for changeset b4c82b704180.
Added tag 5.2.2 for changeset b4c82b704180
Mon, Jan 6, 4:40 PM

Dec 17 2019

durin42 closed D7683: examples: add an example configuration for go source files.
Dec 17 2019, 3:23 PM
durin42 committed rHGb78795c2a294: examples: add an example configuration for go source files.
examples: add an example configuration for go source files
Dec 17 2019, 3:23 PM
durin42 updated the diff for D7683: examples: add an example configuration for go source files.
Dec 17 2019, 2:05 PM
durin42 created D7683: examples: add an example configuration for go source files.
Dec 17 2019, 2:04 PM
durin42 committed rHGa89381e04c58: procutil: try and avoid angering CoreFoundation on macOS.
procutil: try and avoid angering CoreFoundation on macOS
Dec 17 2019, 7:56 AM
durin42 closed D7615: procutil: try and avoid angering CoreFoundation on macOS.
Dec 17 2019, 7:56 AM
durin42 committed rHG1b26cb044097: windows: if username(uid=None) is loaded, just use getpass.
windows: if username(uid=None) is loaded, just use getpass
Dec 17 2019, 3:51 AM
durin42 closed D7679: windows: if username(uid=None) is loaded, just use getpass.
Dec 17 2019, 3:51 AM

Dec 16 2019

durin42 created D7679: windows: if username(uid=None) is loaded, just use getpass.
Dec 16 2019, 5:13 PM
durin42 updated the diff for D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Dec 16 2019, 4:05 PM
durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Dec 16 2019, 3:46 PM
durin42 updated the diff for D7615: procutil: try and avoid angering CoreFoundation on macOS.
Dec 16 2019, 9:27 AM

Dec 12 2019

durin42 created D7615: procutil: try and avoid angering CoreFoundation on macOS.
Dec 12 2019, 12:38 PM
durin42 closed D7592: fuzz: add support for fuzzing under either Python 2 or 3.
Dec 12 2019, 7:53 AM
durin42 committed rHG8766728dbce6: fuzz: add support for fuzzing under either Python 2 or 3.
fuzz: add support for fuzzing under either Python 2 or 3
Dec 12 2019, 7:52 AM

Dec 11 2019

D7582: hg-core: run rustfmt on configparser is now accepted and ready to land.
Dec 11 2019, 12:45 PM
D7580: hg-core: rustfmt path.rs is now accepted and ready to land.
Dec 11 2019, 12:45 PM
D7573: hg-core: vendor Facebook's path utils module is now accepted and ready to land.
Dec 11 2019, 12:45 PM
durin42 added inline comments to D7575: hg-core: vendor Facebook's configparser crate.
Dec 11 2019, 12:44 PM
durin42 added a comment to D7522: rust-dirs: handle forgotten `Result`s.

This needs a rebase that I'm not sure I can accomplish correctly. Could you take a look?

Dec 11 2019, 12:41 PM
D7570: match: resolve filesets against the passed `cwd`, not the current one is now accepted and ready to land.

I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).

Dec 11 2019, 12:37 PM
D7569: tests: show that fileset patterns don't work with `fix` when not in repo root is now accepted and ready to land.
Dec 11 2019, 12:36 PM
durin42 added inline comments to D7595: status: outputting structured unfinished-operation information.
Dec 11 2019, 12:35 PM
durin42 added a comment to D7517: filemerge: byteify the open() mode.

I'm a little fuzzy on this: should I see some test failures? or...?

Dec 11 2019, 12:33 PM
durin42 committed rHGb7af8a02a304: fuzz: add a seed corpus for the dirs fuzzer.
fuzz: add a seed corpus for the dirs fuzzer
Dec 11 2019, 6:55 AM
durin42 closed D7600: fuzz: add a seed corpus for the dirs fuzzer.
Dec 11 2019, 6:55 AM
durin42 committed rHGd74d78aa74e9: fuzz: clean up production of seed corpora.
fuzz: clean up production of seed corpora
Dec 11 2019, 6:55 AM
durin42 closed D7599: fuzz: clean up production of seed corpora.
Dec 11 2019, 6:55 AM

Dec 10 2019

durin42 created D7600: fuzz: add a seed corpus for the dirs fuzzer.
Dec 10 2019, 7:11 PM
durin42 created D7599: fuzz: clean up production of seed corpora.
Dec 10 2019, 7:11 PM
durin42 added a comment to D7579: tests: add test for Rust formatting.

What are we depending on in the rustfmt settings that's nightly behavior?

Dec 10 2019, 10:58 AM
durin42 closed D7557: annotate: describe --skip as taking a revset.
Dec 10 2019, 10:47 AM
durin42 committed rHG36444dddaeb4: tests: replace [[]] bashism with portable [] invocation.
tests: replace [[]] bashism with portable [] invocation
Dec 10 2019, 10:47 AM
durin42 closed D7596: tests: replace [[]] bashism with portable [] invocation.
Dec 10 2019, 10:47 AM
durin42 committed rHGa6483107a07a: annotate: describe --skip as taking a revset.
annotate: describe --skip as taking a revset
Dec 10 2019, 10:45 AM
durin42 created D7596: tests: replace [[]] bashism with portable [] invocation.
Dec 10 2019, 10:31 AM

Dec 9 2019

durin42 added a comment to D7592: fuzz: add support for fuzzing under either Python 2 or 3.

Note: please review the embedded Python segments carefully, as it's a little fidgety to get right and verify I didn't do something Really Dumb.

Dec 9 2019, 10:26 PM
durin42 created D7592: fuzz: add support for fuzzing under either Python 2 or 3.
Dec 9 2019, 10:21 PM