Page MenuHomePhabricator
Feed Advanced Search

Mon, May 9

durin42 committed rHG3cd3aaba5b03: obsolete: remove two unused constants.
obsolete: remove two unused constants
Mon, May 9, 12:39 PM
durin42 committed rHG34decbaf4da3: node: manually implement Debug.
node: manually implement Debug
Mon, May 9, 12:39 PM
durin42 closed D12609: obsolete: remove two unused constants.
Mon, May 9, 11:53 AM
durin42 committed rHG0eaba2ca2e2d: obsolete: remove two unused constants.
obsolete: remove two unused constants
Mon, May 9, 11:53 AM
durin42 closed D12608: node: manually implement Debug.
Mon, May 9, 11:53 AM
durin42 committed rHG312e01ef6d77: node: manually implement Debug.
node: manually implement Debug
Mon, May 9, 11:53 AM

Thu, May 5

durin42 created D12609: obsolete: remove two unused constants.
Thu, May 5, 2:51 PM
durin42 created D12608: node: manually implement Debug.
Thu, May 5, 2:51 PM

Wed, May 4

durin42 added a comment to D12603: diff: graduate merge diffs from experimental and add to tweakdefaults.

I agree, except that I've seen it crash sometimes. I wrote a little script to find such cases now. Here's an example: hg diff --change 7c2921a6. So we need to fix that first. Sorry I never bothered to report a bug for it.

Wed, May 4, 1:10 PM
durin42 created D12603: diff: graduate merge diffs from experimental and add to tweakdefaults.
Wed, May 4, 12:19 PM
durin42 committed rHG9d1e9689a68f: merge: with stable.
merge: with stable
Wed, May 4, 11:45 AM

Mar 25 2022

durin42 committed rHG533820f5b997: merge: with stable.
merge: with stable
Mar 25 2022, 11:43 AM

Mar 2 2022

durin42 committed rHG7b068abe4aa2: rust: jettison Python 2 support.
rust: jettison Python 2 support
Mar 2 2022, 6:05 PM
durin42 committed rHGcd3e25adcf84: setup: always decode xcode version.
setup: always decode xcode version
Mar 2 2022, 6:05 PM
durin42 committed rHG12cba4886e90: setup: remove Rust support for Python 2.
setup: remove Rust support for Python 2
Mar 2 2022, 6:05 PM
durin42 committed rHGe020dbbc41e5: cleanup: stop bundling concurrent.futures on Python 2.
cleanup: stop bundling concurrent.futures on Python 2
Mar 2 2022, 6:05 PM
durin42 committed rHGa0da5075bca3: cleanup: directly use concurrent.futures instead of via pycompat.
cleanup: directly use concurrent.futures instead of via pycompat
Mar 2 2022, 6:05 PM
durin42 committed rHG029b76d645dc: imports: allow importing futures from concurrent.
imports: allow importing futures from concurrent
Mar 2 2022, 6:05 PM
durin42 committed rHG64a8cdf4f327: setup: remove pygit2 Python 2 logic.
setup: remove pygit2 Python 2 logic
Mar 2 2022, 6:05 PM
durin42 committed rHGb07b034cf548: setup: inline now-constant list.
setup: inline now-constant list
Mar 2 2022, 6:05 PM
durin42 committed rHG40e35034eac8: setup: unconditionally do this python 3 step.
setup: unconditionally do this python 3 step
Mar 2 2022, 6:05 PM
durin42 committed rHG3491c450dcae: setup: remove Python 2 support code for determining dylib suffix.
setup: remove Python 2 support code for determining dylib suffix
Mar 2 2022, 6:05 PM
durin42 committed rHGfef4198c855c: setup: inline os.fsdecode now that we're done with Python 2.
setup: inline os.fsdecode now that we're done with Python 2
Mar 2 2022, 6:05 PM
durin42 closed D12279: cleanup: directly use concurrent.futures instead of via pycompat.
Mar 2 2022, 11:29 AM
durin42 closed D12283: rust: jettison Python 2 support.
Mar 2 2022, 11:29 AM
durin42 closed D12282: setup: always decode xcode version.
Mar 2 2022, 11:28 AM
durin42 committed rHG7e64416f7642: rust: jettison Python 2 support.
rust: jettison Python 2 support
Mar 2 2022, 11:28 AM
durin42 closed D12281: setup: remove Rust support for Python 2.
Mar 2 2022, 11:28 AM
durin42 committed rHGc9b620610d75: setup: always decode xcode version.
setup: always decode xcode version
Mar 2 2022, 11:28 AM
durin42 closed D12280: cleanup: stop bundling concurrent.futures on Python 2.
Mar 2 2022, 11:28 AM
durin42 committed rHGbb8fdf22a041: setup: remove Rust support for Python 2.
setup: remove Rust support for Python 2
Mar 2 2022, 11:28 AM
durin42 committed rHG9d570dfa403f: cleanup: stop bundling concurrent.futures on Python 2.
cleanup: stop bundling concurrent.futures on Python 2
Mar 2 2022, 11:28 AM
durin42 closed D12277: setup: remove pygit2 Python 2 logic.
Mar 2 2022, 11:28 AM
durin42 committed rHGd0d411bcfcee: cleanup: directly use concurrent.futures instead of via pycompat.
cleanup: directly use concurrent.futures instead of via pycompat
Mar 2 2022, 11:28 AM
durin42 closed D12276: setup: inline now-constant list.
Mar 2 2022, 11:28 AM
durin42 closed D12278: imports: allow importing futures from concurrent.
Mar 2 2022, 11:28 AM
durin42 committed rHG0fb0cb817750: imports: allow importing futures from concurrent.
imports: allow importing futures from concurrent
Mar 2 2022, 11:28 AM
durin42 closed D12275: setup: unconditionally do this python 3 step.
Mar 2 2022, 11:27 AM
durin42 committed rHG7eda44b04376: setup: remove pygit2 Python 2 logic.
setup: remove pygit2 Python 2 logic
Mar 2 2022, 11:27 AM
durin42 committed rHG535df2ccb862: setup: inline now-constant list.
setup: inline now-constant list
Mar 2 2022, 11:27 AM
durin42 closed D12274: setup: remove Python 2 support code for determining dylib suffix.
Mar 2 2022, 11:27 AM
durin42 closed D12273: setup: inline os.fsdecode now that we're done with Python 2.
Mar 2 2022, 11:27 AM
durin42 committed rHG87007fcb3ca0: setup: unconditionally do this python 3 step.
setup: unconditionally do this python 3 step
Mar 2 2022, 11:27 AM
durin42 closed D12272: setup: inline encoding constant that is only used once.
Mar 2 2022, 11:27 AM
durin42 committed rHGbfceedafc0e3: setup: remove Python 2 support code for determining dylib suffix.
setup: remove Python 2 support code for determining dylib suffix
Mar 2 2022, 11:27 AM
durin42 closed D12271: setup: remove printf trampoline.
Mar 2 2022, 11:27 AM
durin42 committed rHGa7d5854be738: setup: inline os.fsdecode now that we're done with Python 2.
setup: inline os.fsdecode now that we're done with Python 2
Mar 2 2022, 11:27 AM
durin42 committed rHG40a65f5594f5: setup: inline encoding constant that is only used once.
setup: inline encoding constant that is only used once
Mar 2 2022, 11:27 AM
durin42 closed D12270: setup: remove more Python 2 support code.
Mar 2 2022, 11:27 AM
durin42 closed D12269: setup: remove ssl check that only matters on 2.7.
Mar 2 2022, 11:27 AM
durin42 committed rHG1371c18e467d: setup: remove printf trampoline.
setup: remove printf trampoline
Mar 2 2022, 11:27 AM
durin42 closed D12268: setup: remove block that tries to help Python 2.6 users.
Mar 2 2022, 11:26 AM
durin42 committed rHG3ce8001fd768: setup: remove more Python 2 support code.
setup: remove more Python 2 support code
Mar 2 2022, 11:26 AM
durin42 closed D12266: setup: drop statement of support for Python before 3.5.3.
Mar 2 2022, 11:26 AM
durin42 committed rHG726b3601a534: setup: remove ssl check that only matters on 2.7.
setup: remove ssl check that only matters on 2.7
Mar 2 2022, 11:26 AM
durin42 committed rHGa6970465e026: setup: remove block that tries to help Python 2.6 users.
setup: remove block that tries to help Python 2.6 users
Mar 2 2022, 11:26 AM
durin42 committed rHG9af9e2d54857: setup: drop statement of support for Python before 3.5.3.
setup: drop statement of support for Python before 3.5.3
Mar 2 2022, 11:26 AM
durin42 created D12279: cleanup: directly use concurrent.futures instead of via pycompat.
Mar 2 2022, 10:46 AM
durin42 created D12283: rust: jettison Python 2 support.
Mar 2 2022, 10:46 AM
durin42 created D12282: setup: always decode xcode version.
Mar 2 2022, 10:45 AM
durin42 created D12281: setup: remove Rust support for Python 2.
Mar 2 2022, 10:45 AM
durin42 created D12280: cleanup: stop bundling concurrent.futures on Python 2.
Mar 2 2022, 10:45 AM
durin42 created D12277: setup: remove pygit2 Python 2 logic.
Mar 2 2022, 10:45 AM
durin42 created D12278: imports: allow importing futures from concurrent.
Mar 2 2022, 10:45 AM
durin42 created D12276: setup: inline now-constant list.
Mar 2 2022, 10:45 AM
durin42 created D12275: setup: unconditionally do this python 3 step.
Mar 2 2022, 10:45 AM
durin42 created D12274: setup: remove Python 2 support code for determining dylib suffix.
Mar 2 2022, 10:45 AM
durin42 created D12273: setup: inline os.fsdecode now that we're done with Python 2.
Mar 2 2022, 10:44 AM
durin42 created D12272: setup: inline encoding constant that is only used once.
Mar 2 2022, 10:44 AM
durin42 created D12271: setup: remove printf trampoline.
Mar 2 2022, 10:44 AM
durin42 created D12270: setup: remove more Python 2 support code.
Mar 2 2022, 10:44 AM
durin42 created D12269: setup: remove ssl check that only matters on 2.7.
Mar 2 2022, 10:44 AM
durin42 created D12268: setup: remove block that tries to help Python 2.6 users.
Mar 2 2022, 10:44 AM
durin42 created D12266: setup: drop statement of support for Python before 3.5.3.
Mar 2 2022, 10:44 AM

Feb 16 2022

durin42 closed D12186: sparse: add timing block for parsing sparse configs.
Feb 16 2022, 4:59 AM
durin42 committed rHGc4149a110b5f: sparse: add timing block for parsing sparse configs.
sparse: add timing block for parsing sparse configs
Feb 16 2022, 4:59 AM
durin42 committed rHGeb9c55453249: narrowspec: add timing block for validating narrowspec.
narrowspec: add timing block for validating narrowspec
Feb 16 2022, 4:59 AM
durin42 closed D12185: narrowspec: add timing block for validating narrowspec.
Feb 16 2022, 4:59 AM

Feb 15 2022

durin42 created D12186: sparse: add timing block for parsing sparse configs.
Feb 15 2022, 2:02 PM
durin42 created D12185: narrowspec: add timing block for validating narrowspec.
Feb 15 2022, 2:02 PM

Feb 10 2022

durin42 committed rHG3199b575375d: merge: with stable.
merge: with stable
Feb 10 2022, 1:27 PM

Jan 6 2022

durin42 closed D11958: git: add opener attribute to gitstore.
Jan 6 2022, 4:36 AM
durin42 committed rHGb9d5ad7146a3: git: add opener attribute to gitstore.
git: add opener attribute to gitstore
Jan 6 2022, 4:36 AM

Jan 5 2022

durin42 created D11958: git: add opener attribute to gitstore.
Jan 5 2022, 1:36 PM

Jan 4 2022

durin42 committed rHG6bd42f9bc97e: merge: with stable.
merge: with stable
Jan 4 2022, 2:58 PM

Nov 16 2021

durin42 added a comment to D11757: backout: backout 5d83a40cd3f8 and re-instate Python 2 support.

Until this is done (hopefully this cycle), we're keeping Python 2.

To make sure I understand correctly, "this cycle" here refers to the cycle *after* 6.0? So we're instead hoping that 6.1 will be the last release with support for Python 2?

This patch basically mean that if we fix thg packaging before 6.1 is released, we can drop Python 2. For us developers, that means still supporting Python 2 until this is done. Could be tomorrow (fingers crossed heh), at the end of the cycle, or in Mercurial 7.8 if nothing moves on. As said previously we're trying to make that work currently internally at Octobus, but it's really not something that we have time (or really expertise) for right now unfortunately.

Nov 16 2021, 5:57 PM

Nov 10 2021

durin42 committed rHG557cfa049a7b: merge: with stable.
merge: with stable
Nov 10 2021, 2:58 PM

Nov 1 2021

durin42 committed rHGe2836d08c88c: merge: with stable.
merge: with stable
Nov 1 2021, 3:14 PM

Oct 26 2021

durin42 committed rHG4216f5561c3b: merge: with stable.
merge: with stable
Oct 26 2021, 10:28 AM

Oct 18 2021

durin42 added a comment to D11203: revlog: recommit 49fd21f32695 with a fix for issue6528.

Seems like a good fix, needs rebased

Oct 18 2021, 3:16 PM
durin42 added a comment to D11057: compat: enforce upper case drive letter in mercurial too.

Seems fine, needs rebased.

Oct 18 2021, 3:15 PM
durin42 added a comment to D11669: chistedit: add option to show order of commits in opposite order.

Sure, I could send a patch for adding another line to the help text. Do you think that's clear enough? I don't know where else it would go. (We would probably still want to override it internally to highlight it when we roll it out to Google devs.)

Oct 18 2021, 2:22 PM
durin42 added a comment to D11669: chistedit: add option to show order of commits in opposite order.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Oct 18 2021, 2:08 PM
durin42 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

I have not forgotten and I meant to get to that last week. Unfortunately some IRL situation came up and I have not be able to spend time on this (and even writing this message took a week longer that I wanted). Sorry for the delay. The second half of ext week should be more "normal" and I hope to get to that at that time.

Oct 18 2021, 12:51 PM
durin42 added a comment to D11669: chistedit: add option to show order of commits in opposite order.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

Oct 18 2021, 12:46 PM

Oct 17 2021

durin42 added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

I'm still struggling to identify where my proposed fix makes any of this worse.
Current state: people with a version of clang-format <11, or people with a 'trunk' version of clang-format, don't get their code run through clang-format at all, and send changes that will break CI when they land (unless the issue is caught during review).
Proposed state: that no longer happens for people running a 'trunk' version of clang-format, just those using clang-format <11.

I feel like the proposal is going in the wrong direction because it make a more diverse set of version passe the version checks while I feel like we need to more toward a narrower check. Different formater version tends to produce different results and it seems saner to pin the project to specific versions (that we update from time to time).
For the record, right now we have :

  • black: check says ">= 20.8b1", CI uses "20.8b1"
  • clang: check says ">= 11", CI uses debian's clang-format-11 package (in practice "Debian clang-format version 11.1.0-++20210622113218+1fdec59bffc1-1~exp1~20210622213839.163")
  • rust: check says "nightly-2020-10-04", CI uses "nightly-2020-10-04"

Is my feedback clearer and does it make sense to you? Or do you feel like I missed something?

Oct 17 2021, 3:09 PM

Oct 7 2021

durin42 committed rHG1b0f8aafedea: merge: with stable.
merge: with stable
Oct 7 2021, 1:27 PM

Sep 27 2021

durin42 updated subscribers of D11495: narrow: make hg manifest only print things inside the narrowspec.

I think that's a buggy test? @martinvonz and @spectral might have an opinion.

Sep 27 2021, 2:06 PM

Sep 23 2021

durin42 committed rHGf82c4e8afe5c: merge: with stable.
merge: with stable
Sep 23 2021, 5:09 PM

Sep 20 2021

durin42 committed rHGb642a6298ce0: merge: with stable.
merge: with stable
Sep 20 2021, 4:15 PM