I just want people to know that this is not good.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 18 2017
Dec 17 2017
Dec 15 2017
Dec 14 2017
Dec 13 2017
@quark: thanks for the tests note.
Dec 12 2017
Dec 11 2017
This is needed, but only fixes tests together with the other fixes, so the description is slightly incorrect.
Dec 6 2017
Dec 5 2017
address Jun's comment
Dec 1 2017
Nov 30 2017
This *looks* reasonable to me, but I am afraid I could be missing something important. Anyway, since we can turn it off via a config, I'd say it's good to be in the hotfixes.
Nov 28 2017
Nov 27 2017
Nov 26 2017
Nov 22 2017
make optimistic by default
Nov 21 2017
Nov 20 2017
hiding behind a config
remove unnecessary condition
Nov 19 2017
rewrite
Nov 17 2017
This is entirely wrong.
Tested.
Nov 16 2017
hide behind a config knob
Nov 2 2017
Oct 30 2017
Oct 25 2017
Oct 20 2017
Oct 19 2017
Oct 18 2017
Why not update this one: D1026?
It is failing to decode JSON, since the response.data seems to be an HTML piece.
Oct 17 2017
Also, just applying this patch and building a Windows version does not work: the build is successful, but ssl output shows "Error" in place of a phabricator status.
Oct 12 2017
Awesome, thanks!
I would suggest separating these concerns:
- making conduit API dependent on urllib3
- adding urllib3 to the repo
Oct 11 2017
Looks good.
Oct 9 2017
This breaks hg ssl on Windows. We can't just install dependencies there, we need to bundle them.
Oct 1 2017
LGTM
That is why we raise ProgrammingError, not some sort of UserError. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to change my name to something shorter than having it truncated at some arbitrary position.
I would rather see this thing do raise error.ProrgrammingError('metadata cannot be longer than 255 bytes') (or some other message).
Just as an FYI: I revoke my previous comments, as stuff started working for non-prefixed paths and I no longer intend to land anything related to this.
Sep 21 2017
Sep 19 2017
Please wait until the util.finddirs() is tweaked and remove normpath call.
Sep 13 2017
Sep 12 2017
Sep 11 2017
Sep 6 2017
This looks good to me, but I'd like @durham to take a final look.
One of the things that is missing in this diff however is the timeout. Were you going to publish another diff for that?