I just want people to know that this is not good.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 18 2017
Dec 18 2017
Dec 17 2017
Dec 17 2017
sshpeer: allow for additional environment passing to ssh exe
Dec 15 2017
Dec 15 2017
sshpeer: allow for additional environment passing to ssh exe
hgext3rd: make compatible with core change 8a0cac20a1ad
sshaskpass: support sshenv configs as core does
Dec 14 2017
Dec 14 2017
Dec 13 2017
Dec 13 2017
@quark: thanks for the tests note.
Dec 12 2017
Dec 12 2017
pushrebase: address missed phab comment
ikostia committed rFBHGXef4822445810: pushrebase: set legacy.exchange config when pushrebase is used.
pushrebase: set legacy.exchange config when pushrebase is used
tests_: make tests aware of the new capability
pushrebase: remove check-bookmarks parts generator
distutils_rust: teach distutils to look for windows libs
Dec 11 2017
Dec 11 2017
This is needed, but only fixes tests together with the other fixes, so the description is slightly incorrect.
Dec 6 2017
Dec 6 2017
Dec 5 2017
Dec 5 2017
address Jun's comment
Dec 1 2017
Dec 1 2017
Nov 30 2017
Nov 30 2017
This *looks* reasonable to me, but I am afraid I could be missing something important. Anyway, since we can turn it off via a config, I'd say it's good to be in the hotfixes.
Nov 28 2017
Nov 28 2017
Nov 27 2017
Nov 27 2017
phabricator: fix lint warning
remotefilelog: implement threaded _getfiles
Nov 26 2017
Nov 26 2017
Nov 22 2017
Nov 22 2017
make optimistic by default
Nov 21 2017
Nov 21 2017
ikostia committed rFBHGX865278d80ace: tweakdefaults: make util.popen4 input buffer size configurable on Windows.
tweakdefaults: make util.popen4 input buffer size configurable on Windows
Nov 20 2017
Nov 20 2017
hiding behind a config
remove unnecessary condition
Nov 19 2017
Nov 19 2017
ikostia retitled D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows from remotefilelog: set subprocess pipei buffer size to 65536 on Windows to remotefilelog: make subprocess pipei buffer size configurable on Windows.
ikostia updated the diff for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
rewrite
Nov 17 2017
Nov 17 2017
This is entirely wrong.
ikostia requested review of D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Tested.
ikostia updated the test plan for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 16 2017
Nov 16 2017
ikostia updated the diff for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
hide behind a config knob
Nov 2 2017
Nov 2 2017
Oct 30 2017
Oct 30 2017
filemerge: pass a default value to _toolstr (issue5718)
Oct 25 2017
Oct 25 2017
ikostia committed rFBHGX5145f78427e3: test-merge-conflictinfo: include expected failures according to sid's hotfix.
test-merge-conflictinfo: include expected failures according to sid's hotfix
Oct 20 2017
Oct 20 2017
Oct 19 2017
Oct 19 2017
Oct 18 2017
Oct 18 2017
Why not update this one: D1026?
It is failing to decode JSON, since the response.data seems to be an HTML piece.
Oct 17 2017
Oct 17 2017
Also, just applying this patch and building a Windows version does not work: the build is successful, but ssl output shows "Error" in place of a phabricator status.
Oct 12 2017
Oct 12 2017
Awesome, thanks!
I would suggest separating these concerns:
- making conduit API dependent on urllib3
- adding urllib3 to the repo
Oct 11 2017
Oct 11 2017
Looks good.
Oct 9 2017
Oct 9 2017
windows: add an experimental option for long paths support
This breaks hg ssl on Windows. We can't just install dependencies there, we need to bundle them.
Oct 1 2017
Oct 1 2017
ikostia accepted D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).
LGTM
ikostia added a comment to D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).
That is why we raise ProgrammingError, not some sort of UserError. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to change my name to something shorter than having it truncated at some arbitrary position.
ikostia requested changes to D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).
I would rather see this thing do raise error.ProrgrammingError('metadata cannot be longer than 255 bytes') (or some other message).
Just as an FYI: I revoke my previous comments, as stuff started working for non-prefixed paths and I no longer intend to land anything related to this.
Sep 21 2017
Sep 21 2017
Sep 19 2017
Sep 19 2017
Please wait until the util.finddirs() is tweaked and remove normpath call.
Sep 13 2017
Sep 13 2017
remotefilelog: make style-checker happy
Sep 12 2017
Sep 12 2017
rage: remove unused variable
ikostia closed D675: rage: remove unused variable by committing rFBHGXbf097bb3369f: rage: remove unused variable.
Sep 11 2017
Sep 11 2017
Sep 6 2017
Sep 6 2017
This looks good to me, but I'd like @durham to take a final look.
One of the things that is missing in this diff however is the timeout. Were you going to publish another diff for that?
Sep 5 2017
Sep 5 2017
ikostia added a reviewer for D620: remotefilelog: using fastlog as a fast path to fix linkrev: ryanmce.
Aug 31 2017
Aug 31 2017
gitrevset: add a missing import keyword
Aug 5 2017
Aug 5 2017
ikostia committed rHGc2c6a0f7408b: ui: make sure buffer is flushed before waiting for user input (issue5587).
ui: make sure buffer is flushed before waiting for user input (issue5587)