Page MenuHomePhabricator
Feed Advanced Search

Yesterday

valentin.gatienbaron closed D6667: amend: stop committing unrequested file reverts (issue6157).
Mon, Jul 22, 7:28 PM
valentin.gatienbaron committed rHGce52377102db: amend: stop committing unrequested file reverts (issue6157).
amend: stop committing unrequested file reverts (issue6157)
Mon, Jul 22, 7:27 PM
valentin.gatienbaron closed D6666: amend: add a test for a simplified version of issue6157.
Mon, Jul 22, 7:27 PM
valentin.gatienbaron committed rHG464aa857c717: amend: add a test for a simplified version of issue6157.
amend: add a test for a simplified version of issue6157
Mon, Jul 22, 7:27 PM
valentin.gatienbaron created D6667: amend: stop committing unrequested file reverts (issue6157).
Mon, Jul 22, 6:36 AM
valentin.gatienbaron created D6666: amend: add a test for a simplified version of issue6157.
Mon, Jul 22, 6:36 AM

Thu, Jul 18

valentin.gatienbaron committed rHG99ebde4fec99: commit: improve the files field of changelog for merges.
commit: improve the files field of changelog for merges
Thu, Jul 18, 9:40 AM
valentin.gatienbaron committed rHGd98ec36be808: convert: add a config option to help doing identity hg->hg conversion.
convert: add a config option to help doing identity hg->hg conversion
Thu, Jul 18, 9:40 AM
valentin.gatienbaron committed rHG20d0e59be79b: tests: show the files fields of changelogs for many merges.
tests: show the files fields of changelogs for many merges
Thu, Jul 18, 9:40 AM
valentin.gatienbaron committed rHG56132ebd14c6: blackbox: disable extremely verbose logging (issue6110).
blackbox: disable extremely verbose logging (issue6110)
Thu, Jul 18, 9:39 AM
valentin.gatienbaron added a comment to D6612: tests: show the files fields of changelogs for many merges.

Thanks! I didn't expect this would make it for 5.1.

Thu, Jul 18, 8:16 AM
valentin.gatienbaron closed D6613: commit: improve the files field of changelog for merges.
Thu, Jul 18, 1:03 AM
valentin.gatienbaron closed D6643: convert: add a config option to help doing identity hg->hg conversion.
Thu, Jul 18, 1:02 AM
valentin.gatienbaron committed rHGb928b229a9e7: commit: improve the files field of changelog for merges.
commit: improve the files field of changelog for merges
Thu, Jul 18, 1:00 AM
valentin.gatienbaron committed rHG7a44de54490a: convert: add a config option to help doing identity hg->hg conversion.
convert: add a config option to help doing identity hg->hg conversion
Thu, Jul 18, 12:59 AM
valentin.gatienbaron closed D6612: tests: show the files fields of changelogs for many merges.
Thu, Jul 18, 12:59 AM
valentin.gatienbaron committed rHGcd40411bc384: tests: show the files fields of changelogs for many merges.
tests: show the files fields of changelogs for many merges
Thu, Jul 18, 12:59 AM

Wed, Jul 17

valentin.gatienbaron committed rHG341222d54bea: blackbox: disable extremely verbose logging (issue6110).
blackbox: disable extremely verbose logging (issue6110)
Wed, Jul 17, 7:05 PM
valentin.gatienbaron closed D6611: blackbox: disable extremely verbose logging (issue6110).
Wed, Jul 17, 7:05 PM

Tue, Jul 16

valentin.gatienbaron added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

The update worked for me, thanks.

Tue, Jul 16, 10:50 PM

Mon, Jul 15

valentin.gatienbaron added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

Don't take this as a complete list, but it looks like repository.py, remotefilelog, eol, and probably keyword need to be taught the new kwarg. Note that the keyword wrapper is called kwcommitctx, so it isn't enough to grep for def commitctx.

Mon, Jul 15, 6:11 PM
valentin.gatienbaron updated the diff for D6643: convert: add a config option to help doing identity hg->hg conversion.
Mon, Jul 15, 6:05 PM

Sun, Jul 14

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

@mharbison72 I dealt with the problem of convert in the previous commit. I didn't add a config option to disable the new code path, because it's really awkward to document, and I think it would be annoying to use if I made more fixes (the other case where files are spuriously listed, involving exec bits, probably has little impact on repo size/pull performance but it may be worth fixing anyway because it causes confusion). But if there are downsides to what I did, the config option is still on the table.

Sun, Jul 14, 3:31 PM
valentin.gatienbaron retitled D6613: commit: improve the files field of changelog for merges from commit: improve the files field of changelog for merges (RFC) to commit: improve the files field of changelog for merges.
Sun, Jul 14, 3:19 PM
valentin.gatienbaron created D6643: convert: add a config option to help doing identity hg->hg conversion.
Sun, Jul 14, 3:17 PM
valentin.gatienbaron updated the summary of D6612: tests: show the files fields of changelogs for many merges.
Sun, Jul 14, 3:15 PM

Wed, Jul 10

valentin.gatienbaron added inline comments to D6613: commit: improve the files field of changelog for merges.
Wed, Jul 10, 9:45 PM
valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

Ok. Maybe it would be simpler or more robust to do the direct thing: optionally treat the files list in the input commit as input and reuse them blindly in the resulting commit, when doing a hg->hg conversion without filemap.

Maybe. I've been wondering if it's possible to just pass along the manifest and changelog instead of recalculating it. It seems there have been other issues over the years[1]. @yuja fixed something manifest related around the time of that thread IIRC. Even if a filemap is in use, the map may not modify early commits. And when those are changed unexpectedly, it makes me wonder what got lost/mangled. I looked through the repos I converted last year without any file mapping, and there were manifest node changes, but also differences in files and files+ in the changelog.

Wed, Jul 10, 8:52 PM
valentin.gatienbaron added inline comments to D6611: blackbox: disable extremely verbose logging (issue6110).
Wed, Jul 10, 6:21 PM
valentin.gatienbaron updated the diff for D6611: blackbox: disable extremely verbose logging (issue6110).
Wed, Jul 10, 6:12 PM
valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

Ok. Maybe it would be simpler or more robust to do the direct thing: optionally treat the files list in the input commit as input and reuse them blindly in the resulting commit, when doing a hg->hg conversion without filemap.
(btw, a tweak to test-merge-combinations shows the cases where convert is not the identity: 12-- and -1--, so cases where a file is absent in p1, that p2 added or modified, and the merge redeletes the file. Commit shows such files are modified (rightly) but convert doesn't)

Wed, Jul 10, 8:34 AM

Tue, Jul 9

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

If this goes forward, can this be gated by a config option (even if it is on by default)? IIUC, this will change the hash for merges, and then cascade. That seems problematic for convert operations.
Most converts will do things that change hashes anyway, but the default options don't change anything. This is a convenient behavior for easily migrating to/from LFS, for example. (In theory, anyway. In practice, I've seen repos where a convert alters the changelog.) If there is a config option, convert should probably disable it by default to maintain the current behavior. I can see a use case for enabling it though, to clean up the repo.

Tue, Jul 9, 8:40 PM
valentin.gatienbaron updated the summary of D6613: commit: improve the files field of changelog for merges.
Tue, Jul 9, 6:45 AM

Mon, Jul 8

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

I hadn't seen the bug you linked to, or your recent change, though I saw ctx.filesadded() and friends (when writing this) and suspected they were written the way they are to work nicely on merges.

Mon, Jul 8, 11:03 PM
valentin.gatienbaron closed D6610: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Mon, Jul 8, 9:11 AM
valentin.gatienbaron committed rHG44e99811bea7: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
tweakdefaults: make hg resolve require --re-merge flag to re-merge
Mon, Jul 8, 9:11 AM

Sun, Jul 7

valentin.gatienbaron created D6613: commit: improve the files field of changelog for merges.
Sun, Jul 7, 12:20 PM
valentin.gatienbaron abandoned D6609: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Sun, Jul 7, 12:20 PM
valentin.gatienbaron created D6612: tests: show the files fields of changelogs for many merges.
Sun, Jul 7, 12:18 PM
valentin.gatienbaron created D6611: blackbox: disable extremely verbose logging (issue6110).
Sun, Jul 7, 12:14 PM
valentin.gatienbaron created D6610: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Sun, Jul 7, 12:12 PM
valentin.gatienbaron created D6609: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Sun, Jul 7, 12:09 PM

Thu, Jun 27

valentin.gatienbaron closed D6581: update: fix spurious unclean status bug shown by previous commit.
Thu, Jun 27, 11:19 AM
valentin.gatienbaron committed rHGd29db0a0c4eb: update: fix spurious unclean status bug shown by previous commit.
update: fix spurious unclean status bug shown by previous commit
Thu, Jun 27, 11:18 AM
valentin.gatienbaron closed D6580: tests: show bug in update introduced in 87a34c767384.
Thu, Jun 27, 11:18 AM
valentin.gatienbaron committed rHG64a873ca7135: tests: show bug in update introduced in 87a34c767384.
tests: show bug in update introduced in 87a34c767384
Thu, Jun 27, 11:18 AM
valentin.gatienbaron created D6581: update: fix spurious unclean status bug shown by previous commit.
Thu, Jun 27, 7:01 AM
valentin.gatienbaron created D6580: tests: show bug in update introduced in 87a34c767384.
Thu, Jun 27, 7:00 AM
valentin.gatienbaron added a comment to D6475: merge: fix race that could cause wrong size in dirstate.

Try this:
hg co -C 4.9; hg debugrebuilddirstate; hg co 5.0; hg st
Before this patch, that produced an empty output as it should. After this patch, it lists hundreds of modified files (536 to be specific). A workaround is to add --config worker.enabled=no. Can you look into it? It's obviously a pretty serious bug that needs to be fixed before we release a new version.

I forgot to say that what seems wrong in the dirstate is the size (probably other fields too, but size is probably the important one).

Thu, Jun 27, 4:08 AM

Jun 14 2019

valentin.gatienbaron committed rHG9b5fbe5ead89: deltas: skip if projected compressed size is bigger than previous snapshot.
deltas: skip if projected compressed size is bigger than previous snapshot
Jun 14 2019, 10:56 AM
valentin.gatienbaron committed rHGc1c1872d25d1: deltas: skip if projected compressed size does not match text size constraint.
deltas: skip if projected compressed size does not match text size constraint
Jun 14 2019, 10:56 AM
valentin.gatienbaron committed rHG465f2d0df9ae: deltas: accept and skip None return for delta info.
deltas: accept and skip None return for delta info
Jun 14 2019, 10:56 AM
valentin.gatienbaron committed rHG66c27df1be84: deltas: skip if projected delta size is bigger than previous snapshot.
deltas: skip if projected delta size is bigger than previous snapshot
Jun 14 2019, 10:56 AM
valentin.gatienbaron committed rHG6e9ba867a946: delta: move some delta chain related computation earlier in deltainfo.
delta: move some delta chain related computation earlier in deltainfo
Jun 14 2019, 10:56 AM

Jun 13 2019

valentin.gatienbaron committed rHG87a34c767384: merge: fix race that could cause wrong size in dirstate.
merge: fix race that could cause wrong size in dirstate
Jun 13 2019, 4:40 PM
valentin.gatienbaron committed rHG5ca136bbd3f6: worker: support parallelization of functions with return values.
worker: support parallelization of functions with return values
Jun 13 2019, 4:39 PM
valentin.gatienbaron committed rHG0eb8c61c306b: tests: show how the dirstate can end up containing wrong information.
tests: show how the dirstate can end up containing wrong information
Jun 13 2019, 4:39 PM
valentin.gatienbaron closed D6475: merge: fix race that could cause wrong size in dirstate.
Jun 13 2019, 10:04 AM
valentin.gatienbaron committed rHG773b02226e93: merge: fix race that could cause wrong size in dirstate.
merge: fix race that could cause wrong size in dirstate
Jun 13 2019, 10:03 AM
valentin.gatienbaron committed rHG55b724df1a64: worker: support parallelization of functions with return values.
worker: support parallelization of functions with return values
Jun 13 2019, 10:03 AM
valentin.gatienbaron closed D6515: worker: support parallelization of functions with return values.
Jun 13 2019, 10:03 AM
valentin.gatienbaron closed D6474: tests: show how the dirstate can end up containing wrong information.
Jun 13 2019, 10:03 AM
valentin.gatienbaron committed rHGd9a50456ea3d: tests: show how the dirstate can end up containing wrong information.
tests: show how the dirstate can end up containing wrong information
Jun 13 2019, 10:03 AM
valentin.gatienbaron added inline comments to D6475: merge: fix race that could cause wrong size in dirstate.
Jun 13 2019, 2:38 AM

Jun 12 2019

valentin.gatienbaron added inline comments to D6475: merge: fix race that could cause wrong size in dirstate.
Jun 12 2019, 3:55 PM
valentin.gatienbaron updated the summary of D6475: merge: fix race that could cause wrong size in dirstate.
Jun 12 2019, 1:27 PM
valentin.gatienbaron created D6515: worker: support parallelization of functions with return values.
Jun 12 2019, 1:25 PM
valentin.gatienbaron updated the diff for D6474: tests: show how the dirstate can end up containing wrong information.
Jun 12 2019, 1:25 PM
valentin.gatienbaron closed D6506: revlog: speed up isancestor.
Jun 12 2019, 12:45 PM
valentin.gatienbaron committed rHG055c3e2c44f0: revlog: speed up isancestor.
revlog: speed up isancestor
Jun 12 2019, 12:45 PM
valentin.gatienbaron closed D6505: dagop: fix documentation of reachableroots.
Jun 12 2019, 12:44 PM
valentin.gatienbaron committed rHG3e42fc243741: dagop: fix documentation of reachableroots.
dagop: fix documentation of reachableroots
Jun 12 2019, 12:44 PM

Jun 10 2019

valentin.gatienbaron created D6506: revlog: speed up isancestor.
Jun 10 2019, 2:33 PM
valentin.gatienbaron created D6505: dagop: fix documentation of reachableroots.
Jun 10 2019, 12:46 PM

Jun 6 2019

valentin.gatienbaron closed D6477: profiling: show actual time spent in hotpath display.
Jun 6 2019, 8:22 AM
valentin.gatienbaron committed rHG0ae593e791fb: profiling: show actual time spent in hotpath display.
profiling: show actual time spent in hotpath display
Jun 6 2019, 8:21 AM

Jun 5 2019

valentin.gatienbaron updated the diff for D6477: profiling: show actual time spent in hotpath display.
Jun 5 2019, 9:18 PM
valentin.gatienbaron added a comment to D6477: profiling: show actual time spent in hotpath display.

Oh yeah, I didn't really consider the default. I clearly prefer "true", so I'll change it. Maybe it's not even worth having an option. I think the only advantage of not printing this column is to have 5 more columns available for the code excerpt at the end of lines.

Jun 5 2019, 9:09 PM
valentin.gatienbaron created D6477: profiling: show actual time spent in hotpath display.
Jun 5 2019, 3:05 PM

Jun 3 2019

valentin.gatienbaron created D6475: merge: fix race that could cause wrong size in dirstate.
Jun 3 2019, 9:01 AM
valentin.gatienbaron created D6474: tests: show how the dirstate can end up containing wrong information.
Jun 3 2019, 9:00 AM

Jan 17 2019

valentin.gatienbaron closed D5493: match: support rooted globs in hgignore.
Jan 17 2019, 8:42 AM
valentin.gatienbaron committed rHG4fab8a7d2d72: match: support rooted globs in hgignore.
match: support rooted globs in hgignore
Jan 17 2019, 8:42 AM

Jan 16 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Alright, I think I did what you asked for.

Jan 16 2019, 11:30 PM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 16 2019, 11:28 AM

Jan 15 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Sorry, it took me a while to come back to this. I renamed the syntax to rootglob.

Jan 15 2019, 11:57 PM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 15 2019, 7:02 PM

Jan 4 2019

valentin.gatienbaron created D5493: match: support rooted globs in hgignore.
Jan 4 2019, 3:34 PM

Dec 27 2018

valentin.gatienbaron closed D5482: wireproto: in batch queries, support queries with immediate responses.
Dec 27 2018, 7:34 AM
valentin.gatienbaron committed rHG55e8da487b8a: wireproto: in batch queries, support queries with immediate responses.
wireproto: in batch queries, support queries with immediate responses
Dec 27 2018, 7:33 AM

Dec 24 2018

valentin.gatienbaron created D5482: wireproto: in batch queries, support queries with immediate responses.
Dec 24 2018, 2:44 PM

Dec 23 2018

valentin.gatienbaron added a comment to D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).

IIRC, listkeys is a newer command than lookup. If the peer doesn't support listkeys, I suspect this batch query would fail. In that case, maybe listkeys has to be skipped if the peer doesn't support it and if --bookmark is not specified.

Dec 23 2018, 11:00 PM
valentin.gatienbaron closed D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 23 2018, 10:11 PM
valentin.gatienbaron committed rHGbad05a6afdc8: pull: fix inconsistent view of bookmarks during pull (issue4700).
pull: fix inconsistent view of bookmarks during pull (issue4700)
Dec 23 2018, 10:10 PM

Dec 21 2018

valentin.gatienbaron committed rHGc236a491ab7b: test-bookmarks-pushpull: add failing test of issue4700.
test-bookmarks-pushpull: add failing test of issue4700
Dec 21 2018, 9:47 PM

Dec 20 2018

valentin.gatienbaron added a comment to D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).

I'd prefer not to have unpredictable aborts where, when they happen, the solution is "try again". A year or two ago, the "remote heads changed during push" errors were like that, and they were annoying.

Dec 20 2018, 11:05 PM
valentin.gatienbaron abandoned D5448: pull: update comment and refactor in preparation for next commit.
Dec 20 2018, 10:51 PM
valentin.gatienbaron updated the diff for D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 20 2018, 10:50 PM
valentin.gatienbaron closed D5447: test: adding test of issue4700.
Dec 20 2018, 8:14 AM
valentin.gatienbaron committed rHG357bd3ecf1b2: test-bookmarks-pushpull: add failing test of issue4700.
test-bookmarks-pushpull: add failing test of issue4700
Dec 20 2018, 8:14 AM