Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 10

valentin.gatienbaron created D11750: commit: prevent possible race that results in bad dirstate.
Wed, Nov 10, 8:25 PM
valentin.gatienbaron created D11749: test: add test of a race resulting in bad dirstate.
Wed, Nov 10, 8:24 PM

Sep 24 2021

valentin.gatienbaron closed D11490: bookmarks: add an option to make pull mirror remote bookmarks.
Sep 24 2021, 9:21 AM
valentin.gatienbaron committed rHG62f325f9b347: bookmarks: add an option to make pull mirror remote bookmarks.
bookmarks: add an option to make pull mirror remote bookmarks
Sep 24 2021, 9:21 AM

Sep 22 2021

valentin.gatienbaron retitled D11490: bookmarks: add an option to make pull mirror remote bookmarks from bookmarks: add an option to make pull mirror local bookmarks to bookmarks: add an option to make pull mirror remote bookmarks.
Sep 22 2021, 6:24 PM
valentin.gatienbaron created D11490: bookmarks: add an option to make pull mirror remote bookmarks.
Sep 22 2021, 6:24 PM

Sep 13 2021

valentin.gatienbaron added a comment to D11399: narrow: show repo corruption when commiting empty files.

Maybe the server could reject such changes, but I'd rather simply roll clients with the fix.

Sep 13 2021, 3:39 PM
valentin.gatienbaron added a comment to D11399: narrow: show repo corruption when commiting empty files.

It seems that this kind of corruption can propagate between clones as well. Sadness.

Sep 13 2021, 11:54 AM
valentin.gatienbaron closed D11400: narrow: fix commits of empty files.
Sep 13 2021, 11:44 AM
valentin.gatienbaron committed rHG5b9de38a0356: narrow: fix commits of empty files.
narrow: fix commits of empty files
Sep 13 2021, 11:44 AM
valentin.gatienbaron closed D11399: narrow: show repo corruption when commiting empty files.
Sep 13 2021, 11:44 AM
valentin.gatienbaron committed rHGcc33deae66a1: narrow: show repo corruption when commiting empty files.
narrow: show repo corruption when commiting empty files
Sep 13 2021, 11:44 AM
valentin.gatienbaron updated the diff for D11400: narrow: fix commits of empty files.
Sep 13 2021, 9:22 AM

Sep 11 2021

valentin.gatienbaron added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

Thanks for bringing this up. Does that represent a large amount of work for you?

Well, my main challenge here is that I have absolutely no idea what's going on — I don't have much experience with the very low levels of networking in Mercurial, or the (relatively) new peer API. It seems to me that the point of that code is, essentially, to provide a minimal repository or peer that does nothing. Could something like that be moved to Mercurial core?

Okay, I managed to fix it:
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/130/diffs
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/131/diffs
Would one of you perhaps take a look at those changes and see if they make sense? I did it in the form of a decorator that just wraps a regular function returning a value. Something like that might be useful for core as well, and simplify a simple method like branchmap().

Sep 11 2021, 11:31 AM

Sep 10 2021

valentin.gatienbaron created D11400: narrow: fix commits of empty files.
Sep 10 2021, 3:14 PM
valentin.gatienbaron created D11399: narrow: show repo corruption when commiting empty files.
Sep 10 2021, 3:13 PM

Aug 30 2021

valentin.gatienbaron closed D11245: tests: rely on dummyssh being the default.
Aug 30 2021, 6:30 AM
valentin.gatienbaron closed D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 30 2021, 6:28 AM
valentin.gatienbaron closed D11244: tests: setup dummyssh as the default ssh.
Aug 30 2021, 6:28 AM
valentin.gatienbaron committed rHGc89ddef6474d: tests: normalize the way some debug output it matched.
tests: normalize the way some debug output it matched
Aug 30 2021, 6:26 AM
valentin.gatienbaron closed D11361: tests: normalize the way some debug output it matched.
Aug 30 2021, 6:26 AM
valentin.gatienbaron committed rHGe5efbb11e185: tests: drop hgrc bits that have become the default.
tests: drop hgrc bits that have become the default
Aug 30 2021, 6:25 AM
valentin.gatienbaron closed D11247: tests: drop hgrc bits that have become the default.
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHG0c92cd9286ee: tests: manual cleanup now that dummyssh usage is implied.
tests: manual cleanup now that dummyssh usage is implied
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHG9c4204b7f3e4: tests: rely on dummyssh being the default.
tests: rely on dummyssh being the default
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHGa28a7dcb9158: tests: setup dummyssh as the default ssh.
tests: setup dummyssh as the default ssh
Aug 30 2021, 6:25 AM

Aug 27 2021

valentin.gatienbaron updated the diff for D11245: tests: rely on dummyssh being the default.
Aug 27 2021, 9:17 AM
valentin.gatienbaron updated the diff for D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 27 2021, 9:15 AM
valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 27 2021, 9:14 AM
valentin.gatienbaron added a comment to D11245: tests: rely on dummyssh being the default.

I think this should be fixed. If I understand the diff correctly, it was a slash vs backslash change, and the rest is noise.

Aug 27 2021, 9:13 AM
valentin.gatienbaron created D11361: tests: normalize the way some debug output it matched.
Aug 27 2021, 9:12 AM

Aug 25 2021

valentin.gatienbaron committed rHG517a2c1cb788: tests: rename test-clone-uncompressed.t.
tests: rename test-clone-uncompressed.t
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG2174f54aab18: store: return just one filename in walk functions.
store: return just one filename in walk functions
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG308e843f24b1: test: reduce noise, so the important bits stand out.
test: reduce noise, so the important bits stand out
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHGc424ff4807e6: wireprotov1peer: update all rpcs to use the new batchable scheme.
wireprotov1peer: update all rpcs to use the new batchable scheme
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG0fb328bb2459: debugrebuildfncache: add a cheaper option to rebuild the fncache.
debugrebuildfncache: add a cheaper option to rebuild the fncache
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHGcdad6560e832: wireprotov1peer: simplify the way batchable rpcs are defined.
wireprotov1peer: simplify the way batchable rpcs are defined
Aug 25 2021, 9:15 AM

Aug 24 2021

valentin.gatienbaron closed D11248: store: return just one filename in walk functions.
Aug 24 2021, 12:34 PM
valentin.gatienbaron closed D11265: debugrebuildfncache: add a cheaper option to rebuild the fncache.
Aug 24 2021, 12:34 PM
valentin.gatienbaron committed rHGf5394669f57c: store: return just one filename in walk functions.
store: return just one filename in walk functions
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHG8e4659b5cf41: debugrebuildfncache: add a cheaper option to rebuild the fncache.
debugrebuildfncache: add a cheaper option to rebuild the fncache
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHGcd5a2c977741: tests: rename test-clone-uncompressed.t.
tests: rename test-clone-uncompressed.t
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11264: test: reduce noise, so the important bits stand out.
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11237: tests: rename test-clone-uncompressed.t.
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHGc5216695c54a: test: reduce noise, so the important bits stand out.
test: reduce noise, so the important bits stand out
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Aug 24 2021, 11:37 AM
valentin.gatienbaron committed rHGf4f9b0e06fb8: wireprotov1peer: update all rpcs to use the new batchable scheme.
wireprotov1peer: update all rpcs to use the new batchable scheme
Aug 24 2021, 11:36 AM
valentin.gatienbaron closed D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Aug 24 2021, 11:36 AM
valentin.gatienbaron committed rHG1364337a4613: wireprotov1peer: simplify the way batchable rpcs are defined.
wireprotov1peer: simplify the way batchable rpcs are defined
Aug 24 2021, 11:36 AM
valentin.gatienbaron updated the diff for D11248: store: return just one filename in walk functions.
Aug 24 2021, 10:53 AM
valentin.gatienbaron updated the diff for D11248: store: return just one filename in walk functions.
Aug 24 2021, 10:41 AM
valentin.gatienbaron updated the diff for D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Aug 24 2021, 10:18 AM
valentin.gatienbaron updated the diff for D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Aug 24 2021, 10:18 AM

Aug 6 2021

valentin.gatienbaron created D11265: debugrebuildfncache: add a cheaper option to rebuild the fncache.
Aug 6 2021, 4:45 PM
valentin.gatienbaron created D11264: test: reduce noise, so the important bits stand out.
Aug 6 2021, 4:44 PM

Aug 4 2021

valentin.gatienbaron added a comment to D11243: remotefilelog: fix what looks like a wrong refactoring.

I am definitely not going to write a test. I know nothing about remotefilelog. I merely happened to see this while grepping around.

Aug 4 2021, 6:05 PM
valentin.gatienbaron committed rHG6802422a1ae0: remotefilelog: fix what looks like a wrong refactoring.
remotefilelog: fix what looks like a wrong refactoring
Aug 4 2021, 4:43 PM
valentin.gatienbaron closed D11243: remotefilelog: fix what looks like a wrong refactoring.
Aug 4 2021, 4:43 PM
valentin.gatienbaron created D11248: store: return just one filename in walk functions.
Aug 4 2021, 4:42 PM

Aug 3 2021

valentin.gatienbaron created D11245: tests: rely on dummyssh being the default.
Aug 3 2021, 12:52 AM
valentin.gatienbaron created D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 3 2021, 12:50 AM
valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 3 2021, 12:49 AM
valentin.gatienbaron created D11247: tests: drop hgrc bits that have become the default.
Aug 3 2021, 12:48 AM

Aug 2 2021

valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 2 2021, 11:18 PM
valentin.gatienbaron created D11244: tests: setup dummyssh as the default ssh.
Aug 2 2021, 10:26 PM
valentin.gatienbaron created D11243: remotefilelog: fix what looks like a wrong refactoring.
Aug 2 2021, 9:57 PM
valentin.gatienbaron added a comment to D11237: tests: rename test-clone-uncompressed.t.

I have been assuming that changes can still be submitted during a change freeze, but they are just going to get ignored for a few days. None of my changes are particularly intended to go on 5.9.

Aug 2 2021, 10:40 AM
valentin.gatienbaron closed D11236: streamclone: ensure the server sends the right amount of data.
Aug 2 2021, 6:44 AM
valentin.gatienbaron committed rHG48f07adbda98: streamclone: ensure the server sends the right amount of data.
streamclone: ensure the server sends the right amount of data
Aug 2 2021, 6:44 AM

Aug 1 2021

valentin.gatienbaron created D11236: streamclone: ensure the server sends the right amount of data.
Aug 1 2021, 10:59 AM
valentin.gatienbaron created D11237: tests: rename test-clone-uncompressed.t.
Aug 1 2021, 10:59 AM

Jul 25 2021

valentin.gatienbaron created D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Jul 25 2021, 4:33 PM
valentin.gatienbaron created D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Jul 25 2021, 4:32 PM

May 23 2021

valentin.gatienbaron closed D10714: transaction: trivial refactoring.
May 23 2021, 6:05 PM
valentin.gatienbaron committed rHG13dd5bb5492a: transaction: trivial refactoring.
transaction: trivial refactoring
May 23 2021, 6:05 PM
valentin.gatienbaron closed D10757: test: remove some unnecessary dependency on repo format.
May 23 2021, 6:05 PM
valentin.gatienbaron committed rHGaa07bcc4f505: test: remove some unnecessary dependency on repo format.
test: remove some unnecessary dependency on repo format
May 23 2021, 6:05 PM

May 21 2021

valentin.gatienbaron added a comment to D10763: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows.

Maybe the forward slashes in the extension created at the beginning of the test is the source of the other windows failures?

May 21 2021, 8:12 AM

May 20 2021

valentin.gatienbaron created D10757: test: remove some unnecessary dependency on repo format.
May 20 2021, 10:31 AM
valentin.gatienbaron updated the diff for D10714: transaction: trivial refactoring.
May 20 2021, 10:27 AM
valentin.gatienbaron abandoned D10712: tests: show that hg fails to rollback transaction on revlog split.
May 20 2021, 10:25 AM
valentin.gatienbaron abandoned D10713: revlog: fix the the computation of indexes on revlog split.
May 20 2021, 10:25 AM
valentin.gatienbaron abandoned D10715: revlog: make transaction handle revlog splits better (issue6423).
May 20 2021, 10:24 AM

May 18 2021

valentin.gatienbaron added a comment to D10726: recover: only apply last journal record per file (issue6423).

Also, can you put (issue6423) in the first line of the commit message, so the bugzilla magic closes the issue?

May 18 2021, 11:39 PM
valentin.gatienbaron added a comment to D10726: recover: only apply last journal record per file (issue6423).

Does the order of the truncates actually not matter, for concurrent readers? I don't really see how it could matter (linkrevs should make it possible to ignore everything not committed), but before looking at the rollback code, I imagined it truncated in reverse order of writes (and looking it up, it's what's described in the initial revlog paper).

May 18 2021, 11:14 PM
valentin.gatienbaron accepted D10725: revlog: update data file record before index rename.
May 18 2021, 10:44 PM
valentin.gatienbaron added a comment to D10724: revlog: fix index computation during inline->non-inline transition.

I knew zstd could be turned off, but I didn't knew there was an option to turn off even zlib. Cool.

May 18 2021, 10:38 PM

May 16 2021

valentin.gatienbaron added a comment to D10712: tests: show that hg fails to rollback transaction on revlog split.

This whole stack exposes a real problem and one quite a bit older, but it is not correct in a number of ways as is.
First of all, the check added in 8502f76dbfd7 is broken for the revlog inline to non-inline migration.

May 16 2021, 9:30 PM
valentin.gatienbaron created D10715: revlog: make transaction handle revlog splits better (issue6423).
May 16 2021, 3:32 PM
valentin.gatienbaron created D10713: revlog: fix the the computation of indexes on revlog split.
May 16 2021, 3:32 PM
valentin.gatienbaron created D10714: transaction: trivial refactoring.
May 16 2021, 3:31 PM
valentin.gatienbaron created D10712: tests: show that hg fails to rollback transaction on revlog split.
May 16 2021, 3:31 PM

Apr 11 2021

valentin.gatienbaron closed D10293: blackbox: fix type error on log rotation on read-only filesystem.
Apr 11 2021, 7:23 PM
valentin.gatienbaron committed rHG4a6024b87dfc: blackbox: fix type error on log rotation on read-only filesystem.
blackbox: fix type error on log rotation on read-only filesystem
Apr 11 2021, 7:23 PM
valentin.gatienbaron committed rHG8759e22f1649: procutil: avoid using os.fork() to implement runbgcommand.
procutil: avoid using os.fork() to implement runbgcommand
Apr 11 2021, 7:23 PM
valentin.gatienbaron closed D9019: procutil: avoid using os.fork() to implement runbgcommand.
Apr 11 2021, 7:23 PM

Apr 8 2021

valentin.gatienbaron closed D10318: revlog: fix error about unknown compression format in py3.
Apr 8 2021, 6:56 AM
valentin.gatienbaron committed rHGfbfb1d6d8459: revlog: fix error about unknown compression format in py3.
revlog: fix error about unknown compression format in py3
Apr 8 2021, 6:55 AM

Apr 6 2021

valentin.gatienbaron created D10318: revlog: fix error about unknown compression format in py3.
Apr 6 2021, 1:53 PM

Mar 31 2021

valentin.gatienbaron created D10293: blackbox: fix type error on log rotation on read-only filesystem.
Mar 31 2021, 6:11 PM