Feed Advanced Search

Sat, Feb 16

navaneeth.suresh updated the diff for D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Sat, Feb 16, 12:26 AM
navaneeth.suresh added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Sat, Feb 16, 12:13 AM
navaneeth.suresh updated the diff for D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Sat, Feb 16, 12:07 AM

Fri, Feb 15

navaneeth.suresh added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 2:31 PM
navaneeth.suresh updated the diff for D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 2:08 PM
navaneeth.suresh added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 11:53 AM

Thu, Feb 14

navaneeth.suresh committed rHG5fe4de392edb: revset: improve documentation on expectsize().
revset: improve documentation on expectsize()
Thu, Feb 14, 4:17 PM
navaneeth.suresh updated the diff for D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Thu, Feb 14, 11:56 AM
navaneeth.suresh added a comment to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
In D5940#87026, @pulkit wrote:

Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the link to the original PR of this patch.

Thu, Feb 14, 9:48 AM
navaneeth.suresh closed D5953: revset: improve documentation on expectsize().
Thu, Feb 14, 8:24 AM
navaneeth.suresh committed rHG735da363556d: revset: improve documentation on expectsize().
revset: improve documentation on expectsize()
Thu, Feb 14, 8:23 AM

Wed, Feb 13

navaneeth.suresh updated the diff for D5953: revset: improve documentation on expectsize().
Wed, Feb 13, 8:00 AM
navaneeth.suresh created D5953: revset: improve documentation on expectsize().
Wed, Feb 13, 7:51 AM
navaneeth.suresh added inline comments to D5813: revset: add expect to check the size of a set.
Wed, Feb 13, 7:27 AM

Tue, Feb 12

navaneeth.suresh closed D5813: revset: add expect to check the size of a set.
Tue, Feb 12, 7:51 AM
navaneeth.suresh committed rHG8185c8abce87: revset: add expectsize to check the size of a set.
revset: add expectsize to check the size of a set
Tue, Feb 12, 7:50 AM

Mon, Feb 11

navaneeth.suresh created D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Mon, Feb 11, 2:02 PM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Mon, Feb 11, 10:14 AM

Sun, Feb 10

navaneeth.suresh added a comment to D5813: revset: add expect to check the size of a set.

nit-pick is resolved. getintrange() will throw a ParseError on setting size to one of min:, :max or :. In ideal case, on calling from expectsize() it shouldn't fail.

Sun, Feb 10, 11:13 PM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Sun, Feb 10, 11:09 PM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Sun, Feb 10, 12:19 AM

Thu, Feb 7

navaneeth.suresh added a comment to D5813: revset: add expect to check the size of a set.

@yuja I've updated the revision with the suggested changes.

Thu, Feb 7, 2:34 PM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Thu, Feb 7, 2:28 PM
navaneeth.suresh abandoned D5490: commit: remove ignore whitespace option on --interactive (issue6042).

rHG66399f2e92aa solves this issue, many thanks @spectral. Closing this.

Thu, Feb 7, 11:46 AM

Wed, Feb 6

navaneeth.suresh updated subscribers of D5490: commit: remove ignore whitespace option on --interactive (issue6042).

@spectral @yuja Can I close this?

Wed, Feb 6, 11:26 AM
navaneeth.suresh added a comment to D5813: revset: add expect to check the size of a set.

Can you share your failed attempt?

Maybe you can get how revset works by testing expression with
hg debugrevspec -v.

Wed, Feb 6, 11:19 AM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Wed, Feb 6, 11:16 AM

Tue, Feb 5

navaneeth.suresh added a comment to D5813: revset: add expect to check the size of a set.

First, I think the word expect is too general. Perhaps, this should be called
expectsize() or expectlen().

Tue, Feb 5, 12:33 PM

Mon, Feb 4

navaneeth.suresh committed rHG09f1c17e24dd: tags: avoid generating commit for an already deleted tag (issue5752).
tags: avoid generating commit for an already deleted tag (issue5752)
Mon, Feb 4, 4:54 PM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Mon, Feb 4, 1:19 AM
navaneeth.suresh added a comment to D5813: revset: add expect to check the size of a set.

@pulkit Thanks for the quick review! I've updated the revision with the suggested changes. @durin42 It would be great if you let us know your opinion on one(<set>) as an alias for expect(<set>, 1). I did it as it was present in WeShouldDoThat page.

Mon, Feb 4, 1:07 AM
navaneeth.suresh updated the diff for D5813: revset: add expect to check the size of a set.
Mon, Feb 4, 1:03 AM

Sun, Feb 3

navaneeth.suresh created D5813: revset: add expect to check the size of a set.
Sun, Feb 3, 9:28 AM

Thu, Jan 31

navaneeth.suresh closed D5780: tags: avoid generating commit for an already deleted tag (issue5752).
Thu, Jan 31, 4:20 PM
navaneeth.suresh committed rHG8db09278f7e0: tags: avoid generating commit for an already deleted tag (issue5752).
tags: avoid generating commit for an already deleted tag (issue5752)
Thu, Jan 31, 4:19 PM
navaneeth.suresh added a comment to D5780: tags: avoid generating commit for an already deleted tag (issue5752).

@durin42 Thanks for the quick review.
@mharbison72 Yup. I should not be making changes to the ui as this can be fixed simply within the call itself. My bad. I've updated the revision as per your suggestion, many thanks!

Thu, Jan 31, 2:28 PM
navaneeth.suresh updated the diff for D5780: tags: avoid generating commit for an already deleted tag (issue5752).
Thu, Jan 31, 2:21 PM
navaneeth.suresh created D5780: tags: avoid generating commit for an already deleted tag (issue5752).
Thu, Jan 31, 8:30 AM
navaneeth.suresh added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).

Sorry for bumping this up. I worked on a similar issue on D5490. My initial revision was similar to this one. @spectral Don't you think it'll affect record extension which was written with zero test coverage? Please don't feel obligated. I am just being curious.

Thu, Jan 31, 12:59 AM

Sat, Jan 26

navaneeth.suresh closed D5709: diffstat: support filenames with whitespaces on renames.
Sat, Jan 26, 4:31 AM
navaneeth.suresh committed rHG4a33a6bf2b52: diffstat: support filenames with whitespaces on renames.
diffstat: support filenames with whitespaces on renames
Sat, Jan 26, 4:30 AM
navaneeth.suresh created D5709: diffstat: support filenames with whitespaces on renames.
Sat, Jan 26, 3:26 AM
navaneeth.suresh committed rHGf1b0d9988825: diffstat: make --git work properly on renames (issue6025).
diffstat: make --git work properly on renames (issue6025)
Sat, Jan 26, 2:09 AM
navaneeth.suresh added a comment to D5628: diffstat: make --git work properly on renames (issue6025).

One nit: better to not use .split() since a filename may include whitespace.

Sat, Jan 26, 1:50 AM

Fri, Jan 25

navaneeth.suresh added a comment to D5628: diffstat: make --git work properly on renames (issue6025).

Thanks for queuing this!

Fri, Jan 25, 9:53 PM
navaneeth.suresh closed D5628: diffstat: make --git work properly on renames (issue6025).
Fri, Jan 25, 3:11 PM
navaneeth.suresh committed rHGffdac0067a14: diffstat: make --git work properly on renames (issue6025).
diffstat: make --git work properly on renames (issue6025)
Fri, Jan 25, 3:11 PM

Jan 17 2019

navaneeth.suresh created D5628: diffstat: make --git work properly on renames (issue6025).
Jan 17 2019, 7:46 AM

Jan 13 2019

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

_performrevert() would be in the same boat, but it was explicitly flagged on
at f37a69ec3f47. This implies that the diff.ignorews option would be used
in practice to exclude whitespace changes while interactive commit/revert.
So disabling any whitespace options would break someone's workflow.

Jan 13 2019, 9:31 AM

Jan 12 2019

navaneeth.suresh closed D5552: tests: add test for warning on histedit with tagged commits.
Jan 12 2019, 9:08 PM
navaneeth.suresh committed rHG172296c6db91: tests: add test for warning on histedit with tagged commits.
tests: add test for warning on histedit with tagged commits
Jan 12 2019, 9:08 PM

Jan 11 2019

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

Sorry for late, but doesn't it break hg record --ignore-all-space, etc.?

Jan 11 2019, 10:13 AM
navaneeth.suresh updated the diff for D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Jan 11 2019, 10:12 AM

Jan 10 2019

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

@durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side?

Jan 10 2019, 11:29 PM
navaneeth.suresh updated the diff for D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Jan 10 2019, 11:26 PM
navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

Could you add a test?

(Bonus points if you add a test that shows the wrong behavior and then fix it in this change.)

Jan 10 2019, 8:13 AM
navaneeth.suresh created D5552: tests: add test for warning on histedit with tagged commits.
Jan 10 2019, 8:10 AM
navaneeth.suresh added a comment to D5494: histedit: add user input to warning message on editing tagged commits.
In D5494#81855, @pulkit wrote:

Sorry for bumping on this now, can you add tests for this as follow-up?

Jan 10 2019, 3:25 AM

Jan 9 2019

navaneeth.suresh committed rHG7b7e081f8954: histedit: add user input to warning message on editing tagged commits.
histedit: add user input to warning message on editing tagged commits
Jan 9 2019, 3:00 PM
navaneeth.suresh closed D5494: histedit: add user input to warning message on editing tagged commits.
Jan 9 2019, 3:00 PM

Jan 7 2019

navaneeth.suresh added a comment to D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).

This is logically incorrect. The problem is that we're doing variable
expansion at too lower layer. vfs(expand(user_specified_path)) makes
some sense, but vfs(expand(getcwd())) is clearly wrong. And the vfs class
can't know where the base comes from.

Jan 7 2019, 11:08 PM
navaneeth.suresh updated the diff for D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).
Jan 7 2019, 7:08 AM
navaneeth.suresh created D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).
Jan 7 2019, 3:38 AM

Jan 5 2019

navaneeth.suresh added a comment to D5489: histedit: add warning message on editing tagged commits (issue4017).

@mharbison72 @yuja Thank you for the suggestions. I've created a follow-up patch making the suggested changes. Please see D5494.

Jan 5 2019, 11:15 PM
navaneeth.suresh updated the summary of D5494: histedit: add user input to warning message on editing tagged commits.
Jan 5 2019, 11:11 PM
navaneeth.suresh created D5494: histedit: add user input to warning message on editing tagged commits.
Jan 5 2019, 11:07 PM
navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).
In D5490#81294, @pulkit wrote:

I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that.

Jan 5 2019, 4:45 AM
navaneeth.suresh updated the summary of D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Jan 5 2019, 4:43 AM

Jan 4 2019

navaneeth.suresh created D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Jan 4 2019, 5:23 AM
navaneeth.suresh added inline comments to D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 4 2019, 3:28 AM

Jan 3 2019

navaneeth.suresh added a comment to D5489: histedit: add warning message on editing tagged commits (issue4017).

Thanks for queuing!

Jan 3 2019, 10:50 PM
navaneeth.suresh closed D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 3 2019, 5:54 PM
navaneeth.suresh committed rHG86f0ed7ac688: histedit: add warning message on editing tagged commits (issue4017).
histedit: add warning message on editing tagged commits (issue4017)
Jan 3 2019, 5:53 PM
navaneeth.suresh created D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 3 2019, 1:33 PM
navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

Thanks for queuing Yuya!

Jan 3 2019, 5:11 AM
navaneeth.suresh closed D5485: log: fixes line wrap on diffstat (issue5800).
Jan 3 2019, 4:39 AM
navaneeth.suresh committed rHG6a63ba61e71f: log: fix line wrap on diffstat with -G/--graph (issue5800).
log: fix line wrap on diffstat with -G/--graph (issue5800)
Jan 3 2019, 4:39 AM

Jan 2 2019

navaneeth.suresh abandoned D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Jan 2 2019, 7:23 AM
navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

@yuja Can this be closed?

Jan 2 2019, 7:07 AM
navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

@yuja Requested changes have been made in the current revision.

Jan 2 2019, 6:36 AM
navaneeth.suresh updated the diff for D5485: log: fixes line wrap on diffstat (issue5800).
Jan 2 2019, 6:32 AM

Dec 30 2018

navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

IIUC, the problem is that the width parameter is incorrect because of
graph lines.

Dec 30 2018, 8:34 AM
navaneeth.suresh updated the diff for D5485: log: fixes line wrap on diffstat (issue5800).
Dec 30 2018, 8:27 AM

Dec 28 2018

navaneeth.suresh closed D5486: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 28 2018, 12:06 AM
navaneeth.suresh committed rHG4506f801e492: branches: add -r option to show branch name(s) of a given rev (issue5948).
branches: add -r option to show branch name(s) of a given rev (issue5948)
Dec 28 2018, 12:05 AM

Dec 27 2018

navaneeth.suresh abandoned D5475: branch:Added option to show branch name of a given rev (Issue5948).
Dec 27 2018, 1:34 PM
navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81186, @yuja wrote:

I tried to queue this, but the patch doesn't include any metadata (e.g. author
and date.) Please check your configuration.

https://www.mercurial-scm.org/wiki/Phabricator

Dec 27 2018, 11:06 AM
navaneeth.suresh created D5486: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 27 2018, 11:02 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 27 2018, 8:55 AM
navaneeth.suresh created D5485: log: fixes line wrap on diffstat (issue5800).
Dec 27 2018, 6:48 AM

Dec 26 2018

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81155, @yuja wrote:

Looks mostly good.

Can you update the commit message to conform to our style?
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

Dec 26 2018, 9:43 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 26 2018, 9:39 AM

Dec 25 2018

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

@yuja Thank you so much for the information. I've updated the revision. Please review when you're free.

Dec 25 2018, 8:51 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 25 2018, 8:49 AM

Dec 24 2018

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81095, @yuja wrote:
fm.startitem()

+ rev = ctx.rev()
+ if opts.get('rev') and rev not in revs:
+ continue

ctx points to the tipmost branch head. so rev not in revs doesn't mean any
of the revs do not belong to the branch.

Dec 24 2018, 9:05 AM
navaneeth.suresh added a comment to D5475: branch:Added option to show branch name of a given rev (Issue5948).
In D5475#81071, @yuja wrote:
Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself.

I'm not sure if I get it, but my idea is to add hg branches -r/--rev
that selects branches to be listed by revisions. So, hg branch -srREV in
your original patch will be equivalent to hg branches -qrREV (-q to
suppress detailed output.)

Dec 24 2018, 6:37 AM
navaneeth.suresh created D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Dec 24 2018, 6:35 AM

Dec 23 2018

navaneeth.suresh added a comment to D5475: branch:Added option to show branch name of a given rev (Issue5948).

Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself. How's that sound to you guys, @pulkit @yuja ?

Dec 23 2018, 10:04 AM
navaneeth.suresh created D5475: branch:Added option to show branch name of a given rev (Issue5948).
Dec 23 2018, 5:22 AM