Page MenuHomePhabricator
Feed Advanced Search

Today

navaneeth.suresh added inline comments to D6728: config: add experimental argument to the config registrar.
Sun, Aug 18, 7:56 AM

Yesterday

navaneeth.suresh added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
In D6731#98871, @pulkit wrote:

In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think?

Sat, Aug 17, 5:30 PM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Sat, Aug 17, 5:29 PM
navaneeth.suresh created D6740: tests: add test to demonstrate issue6159.
Sat, Aug 17, 5:28 PM
navaneeth.suresh created D6739: unshelve: add abort on using --interactive and --unresolved together.
Sat, Aug 17, 4:41 PM
navaneeth.suresh created D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Sat, Aug 17, 4:40 PM
navaneeth.suresh created D6737: shelve: add --unresolved flag to shelve mergestate with unresolved files.
Sat, Aug 17, 4:39 PM
navaneeth.suresh created D6736: shelve: add method for storing mergestate in changeset extras.
Sat, Aug 17, 4:38 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 17, 11:10 AM
navaneeth.suresh added a comment to D6730: config: handle default values of type list.
In D6730#98852, @av6 wrote:

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Sat, Aug 17, 10:56 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 17, 10:55 AM
navaneeth.suresh committed rHG7b33ff9c5565: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Sat, Aug 17, 2:50 AM
navaneeth.suresh committed rHGa11fd395e83f: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Sat, Aug 17, 2:50 AM

Fri, Aug 16

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:23 PM
navaneeth.suresh created D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Fri, Aug 16, 4:26 PM
navaneeth.suresh closed D6699: unshelve: abort on using --keep and --interactive together.
Fri, Aug 16, 6:56 AM
navaneeth.suresh committed rHG4b0c9d47f714: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Fri, Aug 16, 6:55 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:13 AM
navaneeth.suresh updated the diff for D6730: config: handle default values of type list.
Fri, Aug 16, 5:08 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:08 AM
navaneeth.suresh created D6730: config: handle default values of type list.
Fri, Aug 16, 5:03 AM

Thu, Aug 15

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Thu, Aug 15, 3:44 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

Thu, Aug 15, 11:37 AM
navaneeth.suresh closed D6728: config: add experimental argument to the config registrar.
Thu, Aug 15, 11:25 AM
navaneeth.suresh committed rHGe67d9b6bad4d: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Thu, Aug 15, 11:24 AM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Thu, Aug 15, 11:16 AM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

I get 28 of them.
I think we need to add an experimental or status argument ot the config registration.

Thu, Aug 15, 10:32 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Thu, Aug 15, 10:31 AM
navaneeth.suresh created D6728: config: add experimental argument to the config registrar.
Thu, Aug 15, 10:22 AM

Tue, Aug 13

navaneeth.suresh closed D6724: unshelve: forget unknown files after a partial unshelve.
Tue, Aug 13, 4:49 PM
navaneeth.suresh committed rHGd684449eef67: unshelve: forget unknown files after a partial unshelve.
unshelve: forget unknown files after a partial unshelve
Tue, Aug 13, 4:49 PM
navaneeth.suresh created D6724: unshelve: forget unknown files after a partial unshelve.
Tue, Aug 13, 1:21 PM

Sun, Aug 11

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sun, Aug 11, 3:46 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sun, Aug 11, 2:13 PM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

Should we hide devel.* like we do experimental when verbose isn’t applied? Presumably we don’t want regular users to know about them.

Sun, Aug 11, 2:13 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sun, Aug 11, 9:28 AM
navaneeth.suresh added inline comments to D6709: config: add --registered flag to show all known configs.
Sun, Aug 11, 9:06 AM

Sat, Aug 10

navaneeth.suresh updated subscribers of D6709: config: add --registered flag to show all known configs.
Sat, Aug 10, 3:02 PM

Fri, Aug 9

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 9, 3:10 PM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Fri, Aug 9, 3:09 PM
navaneeth.suresh retitled D6699: unshelve: abort on using --keep and --interactive together from tests: add test for unshelve --interactive --keep to unshelve: abort on using --keep and --interactive together.
Fri, Aug 9, 2:42 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 9, 1:01 AM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

@pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following
items in configitems.py. IIUC, it should be visible when we are trying to read a config item which is
not in the registered items. But, we are iterating over registered items only.

There are "generic" config option. So it does not hold the option "name", but a regexp to match valid entry.

Fri, Aug 9, 12:54 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 9, 12:53 AM

Thu, Aug 8

navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

@pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following
items in configitems.py. IIUC, it should be visible when we are trying to read a config item which is
not in the registered items. But, we are iterating over registered items only.

Thu, Aug 8, 12:08 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Thu, Aug 8, 11:55 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Thu, Aug 8, 11:52 AM

Wed, Aug 7

navaneeth.suresh closed D6712: config: remove pycompat.bytestr() for defaultvalue.
Wed, Aug 7, 5:32 PM
navaneeth.suresh closed D6720: config: fix fm.data() handling of defaultvalue.
Wed, Aug 7, 5:32 PM
navaneeth.suresh committed rHG60789444acd6: config: fix fm.data() handling of defaultvalue.
config: fix fm.data() handling of defaultvalue
Wed, Aug 7, 5:31 PM
navaneeth.suresh committed rHG049b2ac3252e: config: remove pycompat.bytestr() for defaultvalue.
config: remove pycompat.bytestr() for defaultvalue
Wed, Aug 7, 5:31 PM
navaneeth.suresh added a comment to D6712: config: remove pycompat.bytestr() for defaultvalue.
In D6712#98424, @pulkit wrote:

The pycompat.bytestr() was there for py3 compatibility, however removing it should be fine in this case. Can you make sure test-config.t passes with this patch on Python 3?

Wed, Aug 7, 11:20 AM
navaneeth.suresh updated the diff for D6720: config: fix fm.data() handling of defaultvalue.
Wed, Aug 7, 11:18 AM
navaneeth.suresh added inline comments to D6720: config: fix fm.data() handling of defaultvalue.
Wed, Aug 7, 10:41 AM
navaneeth.suresh retitled D6720: config: fix fm.data() handling of defaultvalue from config: fix defaultvalue template keyword (patch 2 of 2) to config: fix fm.data() handling of defaultvalue.
Wed, Aug 7, 10:39 AM
navaneeth.suresh retitled D6712: config: remove pycompat.bytestr() for defaultvalue from config: fix defaultvalue template keyword (patch 1 of 2) to config: remove pycompat.bytestr() for defaultvalue.
Wed, Aug 7, 10:32 AM
navaneeth.suresh created D6720: config: fix fm.data() handling of defaultvalue.
Wed, Aug 7, 9:51 AM
navaneeth.suresh updated the summary of D6712: config: remove pycompat.bytestr() for defaultvalue.
Wed, Aug 7, 9:45 AM

Tue, Aug 6

navaneeth.suresh closed D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Tue, Aug 6, 1:22 PM
navaneeth.suresh committed rHG6957f7b93e03: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
unshelve: clear shelvedstate and _finishunshelve() on partial unshelve
Tue, Aug 6, 1:22 PM
navaneeth.suresh updated the diff for D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Tue, Aug 6, 1:10 PM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Tue, Aug 6, 1:07 PM
navaneeth.suresh updated the diff for D6712: config: remove pycompat.bytestr() for defaultvalue.
Tue, Aug 6, 1:04 PM
navaneeth.suresh closed D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Tue, Aug 6, 12:43 PM
navaneeth.suresh committed rHG073cfff9aaef: unshelve: delete shelvedstate after a successful unshelve --continue.
unshelve: delete shelvedstate after a successful unshelve --continue
Tue, Aug 6, 12:43 PM
navaneeth.suresh updated the diff for D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Tue, Aug 6, 12:06 PM
navaneeth.suresh added inline comments to D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Tue, Aug 6, 12:04 PM
navaneeth.suresh added inline comments to D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Tue, Aug 6, 12:00 PM
navaneeth.suresh updated the diff for D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Tue, Aug 6, 12:00 PM
navaneeth.suresh closed D6686: unshelve: handle stripping changesets on interactive mode.
Tue, Aug 6, 11:48 AM
navaneeth.suresh committed rHG4814d993fe21: unshelve: handle stripping changesets on interactive mode.
unshelve: handle stripping changesets on interactive mode
Tue, Aug 6, 11:48 AM
navaneeth.suresh updated the diff for D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Tue, Aug 6, 8:11 AM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Tue, Aug 6, 7:56 AM

Sat, Aug 3

navaneeth.suresh updated the summary of D6709: config: add --registered flag to show all known configs.
Sat, Aug 3, 12:54 PM
navaneeth.suresh updated the summary of D6712: config: remove pycompat.bytestr() for defaultvalue.
Sat, Aug 3, 2:55 AM
navaneeth.suresh created D6712: config: remove pycompat.bytestr() for defaultvalue.
Sat, Aug 3, 2:52 AM
navaneeth.suresh added a comment to D6704: config: add defaultvalue template keyword.

@yuja Thanks for the review. Will send a follow-up soon.

Sat, Aug 3, 2:01 AM
navaneeth.suresh added inline comments to D6709: config: add --registered flag to show all known configs.
Sat, Aug 3, 2:00 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 3, 1:56 AM

Fri, Aug 2

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 2, 6:54 AM
navaneeth.suresh created D6709: config: add --registered flag to show all known configs.
Fri, Aug 2, 5:50 AM
navaneeth.suresh abandoned D6700: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Fri, Aug 2, 4:19 AM
navaneeth.suresh created D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Fri, Aug 2, 4:17 AM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Fri, Aug 2, 4:17 AM
navaneeth.suresh updated the diff for D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit().
Fri, Aug 2, 4:17 AM
navaneeth.suresh updated the diff for D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Fri, Aug 2, 4:16 AM
navaneeth.suresh updated the diff for D6686: unshelve: handle stripping changesets on interactive mode.
Fri, Aug 2, 4:16 AM
navaneeth.suresh added inline comments to D6704: config: add defaultvalue template keyword.
Fri, Aug 2, 4:12 AM

Thu, Aug 1

navaneeth.suresh closed D6704: config: add defaultvalue template keyword.
Thu, Aug 1, 2:47 PM
navaneeth.suresh committed rHG51a2e3102db2: config: add defaultvalue template keyword.
config: add defaultvalue template keyword
Thu, Aug 1, 2:45 PM
navaneeth.suresh created D6704: config: add defaultvalue template keyword.
Thu, Aug 1, 1:43 PM

Wed, Jul 31

navaneeth.suresh closed D6703: unshelve: add abort on using continue and interactive together.
Wed, Jul 31, 7:46 PM
navaneeth.suresh committed rHG52a383451739: unshelve: add abort on using continue and interactive together.
unshelve: add abort on using continue and interactive together
Wed, Jul 31, 7:46 PM

Tue, Jul 30

navaneeth.suresh added a comment to D6679: unshelve: store information about interactive mode in shelvedstate.

mercurial/shelve.py:938: local variable 'interactive' is assigned to but never used
Maybe --continue --interactive has to be banned if the mode can't be
overridden by the command option.

Tue, Jul 30, 12:10 PM
navaneeth.suresh created D6703: unshelve: add abort on using continue and interactive together.
Tue, Jul 30, 12:10 PM

Mon, Jul 29

navaneeth.suresh added a comment to D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit().
In D6697#98061, @pulkit wrote:

test-commit-interactive.t and some other tests fail for me with this, can you have a look?

Mon, Jul 29, 11:30 AM
navaneeth.suresh closed D6679: unshelve: store information about interactive mode in shelvedstate.
Mon, Jul 29, 6:31 AM
navaneeth.suresh closed D6687: unshelve: create a matcher only if required on creating unshelve ctx.
Mon, Jul 29, 6:31 AM
navaneeth.suresh committed rHGee86ad6f50fe: unshelve: store information about interactive mode in shelvedstate.
unshelve: store information about interactive mode in shelvedstate
Mon, Jul 29, 6:31 AM
navaneeth.suresh committed rHGd5cdce3d9164: unshelve: create a matcher only if required on creating unshelve ctx.
unshelve: create a matcher only if required on creating unshelve ctx
Mon, Jul 29, 6:31 AM