Feed Advanced Search

Wed, Jan 16

indygreg accepted D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...

Wed, Jan 16, 4:33 PM
indygreg added a comment to D5589: watchman: add the possibility to set the exact watchman binary location.

Overall I like the feature. But the class initialization logic is wonky. That's not your fault: you happen to be wading into a mess. Since it looks like there will be a v2 on this series, I'd encourage you to add some inline comments about the __init__ mess at the least, or ideally refactor it so the code is cleaner.

Wed, Jan 16, 4:32 PM
indygreg requested changes to D5588: watchman: disable fsmonitor when running non-interactively.

Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from watchman.

Wed, Jan 16, 2:50 PM
indygreg accepted D5587: watchman: detect nested mercurial repositories and abort.
Wed, Jan 16, 2:44 PM
indygreg added a comment to D5586: watchman: add verbose config knob.

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

Wed, Jan 16, 2:40 PM

Sat, Jan 12

indygreg closed D5561: revlog: always enable generaldelta on version 2 revlogs.
Sat, Jan 12, 10:28 PM
indygreg closed D5564: revlog: use separate variables to track version flags.
Sat, Jan 12, 10:28 PM
indygreg closed D5563: revlog: inline opener options logic into _loadindex().
Sat, Jan 12, 10:28 PM
indygreg committed rHG3f807237dc94: revlog: use separate variables to track version flags.
revlog: use separate variables to track version flags
Sat, Jan 12, 10:27 PM
indygreg committed rHGe3cfe0702eac: revlog: inline opener options logic into _loadindex().
revlog: inline opener options logic into _loadindex()
Sat, Jan 12, 10:27 PM
indygreg closed D5562: revlog: store mmaplargeindex as an instance attribute.
Sat, Jan 12, 10:27 PM
indygreg committed rHGe7a2cc84dbc0: revlog: always enable generaldelta on version 2 revlogs.
revlog: always enable generaldelta on version 2 revlogs
Sat, Jan 12, 10:27 PM
indygreg committed rHGd0de4fdd87aa: revlog: store mmaplargeindex as an instance attribute.
revlog: store mmaplargeindex as an instance attribute
Sat, Jan 12, 10:27 PM
indygreg closed D5560: revlog: rename v to versionflags.
Sat, Jan 12, 10:27 PM
indygreg closed D5559: revlog: always process opener options.
Sat, Jan 12, 10:27 PM
indygreg committed rHG6439cefaeb64: revlog: rename v to versionflags.
revlog: rename v to versionflags
Sat, Jan 12, 10:27 PM
indygreg committed rHGcecf3f8bccd3: revlog: always process opener options.
revlog: always process opener options
Sat, Jan 12, 10:27 PM
indygreg committed rHGd8fe67db5234: internals: minor rewriting of revlogs documentation.
internals: minor rewriting of revlogs documentation
Sat, Jan 12, 10:27 PM
indygreg closed D5558: internals: minor rewriting of revlogs documentation.
Sat, Jan 12, 10:27 PM

Fri, Jan 11

indygreg planned changes to D5565: revlog: add version 2 format flag to control sparse.

Why have a flag for revlog v2 at all? Since v2 have not been "released"
yet, why not use sparse-revlog logic in all case when using revlog v2?

Fri, Jan 11, 6:11 PM

Thu, Jan 10

indygreg created D5565: revlog: add version 2 format flag to control sparse.
Thu, Jan 10, 7:34 PM
indygreg created D5566: revlog: rename revlog I/O classes to reflect version (API).
Thu, Jan 10, 7:34 PM
indygreg created D5567: revlog: assign revlog._io in version lookup conditional.
Thu, Jan 10, 7:33 PM
indygreg created D5561: revlog: always enable generaldelta on version 2 revlogs.
Thu, Jan 10, 7:33 PM
indygreg added a dependent revision for D5566: revlog: rename revlog I/O classes to reflect version (API): D5567: revlog: assign revlog._io in version lookup conditional.
Thu, Jan 10, 7:33 PM
indygreg created D5564: revlog: use separate variables to track version flags.
Thu, Jan 10, 7:33 PM
indygreg added a dependent revision for D5565: revlog: add version 2 format flag to control sparse: D5566: revlog: rename revlog I/O classes to reflect version (API).
Thu, Jan 10, 7:33 PM
indygreg created D5563: revlog: inline opener options logic into _loadindex().
Thu, Jan 10, 7:33 PM
indygreg added a dependent revision for D5564: revlog: use separate variables to track version flags: D5565: revlog: add version 2 format flag to control sparse.
Thu, Jan 10, 7:33 PM
indygreg created D5562: revlog: store mmaplargeindex as an instance attribute.
Thu, Jan 10, 7:33 PM
indygreg added a dependent revision for D5563: revlog: inline opener options logic into _loadindex(): D5564: revlog: use separate variables to track version flags.
Thu, Jan 10, 7:32 PM
indygreg created D5560: revlog: rename v to versionflags.
Thu, Jan 10, 7:32 PM
indygreg added a dependent revision for D5562: revlog: store mmaplargeindex as an instance attribute: D5563: revlog: inline opener options logic into _loadindex().
Thu, Jan 10, 7:32 PM
indygreg created D5559: revlog: always process opener options.
Thu, Jan 10, 7:32 PM
indygreg added a dependent revision for D5561: revlog: always enable generaldelta on version 2 revlogs: D5562: revlog: store mmaplargeindex as an instance attribute.
Thu, Jan 10, 7:32 PM
indygreg added a dependent revision for D5560: revlog: rename v to versionflags: D5561: revlog: always enable generaldelta on version 2 revlogs.
Thu, Jan 10, 7:32 PM
indygreg added a dependent revision for D5559: revlog: always process opener options: D5560: revlog: rename v to versionflags.
Thu, Jan 10, 7:32 PM
indygreg added a dependent revision for D5558: internals: minor rewriting of revlogs documentation: D5559: revlog: always process opener options.
Thu, Jan 10, 7:32 PM
indygreg created D5558: internals: minor rewriting of revlogs documentation.
Thu, Jan 10, 7:32 PM
indygreg added a comment to D5557: testrunner: make `-j100 --runs-per-test=100 test-foo.t` use 100 jobs.

For the record, I enjoyed @martinvonz conversing with himself on this review!

Thu, Jan 10, 7:24 PM

Wed, Jan 9

indygreg added a comment to D5519: simplestorerepo: minimal changes required to get this mostly working again.

The original purpose of the simple store repo was to flush out problems with storage abstraction by building an alternate storage backend. Now that we have storage interface unit tests and the SQLite storage backend, there is definitely less of a need for the simple store backend and we could probably consider deleting it.

I wonder if it's worth keeping the simpler simplestore code as an example. Probably not?

Wed, Jan 9, 6:11 PM
indygreg added a comment to D5523: tests: get access to thirdparty.cbor without requiring it to be installed.

I agree that we should nuke the vendored CBOR package altogether.

Wed, Jan 9, 6:07 PM
indygreg added a comment to D5519: simplestorerepo: minimal changes required to get this mostly working again.

The original purpose of the simple store repo was to flush out problems with storage abstraction by building an alternate storage backend. Now that we have storage interface unit tests and the SQLite storage backend, there is definitely less of a need for the simple store backend and we could probably consider deleting it.

Wed, Jan 9, 6:05 PM

Thu, Dec 27

indygreg closed D5408: progress: avoid ui.configbool() lookup when progress bar is active.
Thu, Dec 27, 7:34 AM
indygreg committed rHG6603de284b0a: progress: avoid ui.configbool() lookup when progress bar is active.
progress: avoid ui.configbool() lookup when progress bar is active
Thu, Dec 27, 7:34 AM

Thu, Dec 20

indygreg added a comment to D5466: repository: update interface signature of narrowmatch().

I'd say `repository.py is the best place for docs, since localrepo.py` implements the interface and the interface is what matters.

Thu, Dec 20, 6:23 PM

Dec 11 2018

indygreg abandoned D5411: sqlitestore: create new connections on new PIDs.

It turns out we were hitting a bug in an ancient version of SQLite. Upgrading from 3.11 to 3.22 fixed it. I don't think this patch is needed.

Dec 11 2018, 8:55 PM
indygreg planned changes to D5411: sqlitestore: create new connections on new PIDs.

Hold off on reviewing this. I'm still debugging some issues at Mozilla and want to be sure this patch is correct...

Dec 11 2018, 7:10 PM
indygreg created D5411: sqlitestore: create new connections on new PIDs.
Dec 11 2018, 7:00 PM

Dec 10 2018

indygreg closed D5407: perf: add perfprogress command.
Dec 10 2018, 4:26 PM
indygreg closed D5406: wireprotov2: unify file revision collection and linknode derivation.
Dec 10 2018, 4:26 PM
indygreg closed D5404: tests: add tests for server-side linknode adjustment with wireprotov2.
Dec 10 2018, 4:25 PM
indygreg committed rHG008f3491dc53: perf: add perfprogress command.
perf: add perfprogress command
Dec 10 2018, 4:25 PM
indygreg closed D5405: wireprotov2: send linknodes to emitfilerevisions().
Dec 10 2018, 4:25 PM
indygreg committed rHG08cfa77d7288: wireprotov2: unify file revision collection and linknode derivation.
wireprotov2: unify file revision collection and linknode derivation
Dec 10 2018, 4:25 PM
indygreg committed rHGca6372b7e566: tests: add tests for server-side linknode adjustment with wireprotov2.
tests: add tests for server-side linknode adjustment with wireprotov2
Dec 10 2018, 4:25 PM
indygreg committed rHG3ed77780f4a6: wireprotov2: send linknodes to emitfilerevisions().
wireprotov2: send linknodes to emitfilerevisions()
Dec 10 2018, 4:25 PM
indygreg committed rHGafdbc9c6a333: tests: fix empty commit in test.
tests: fix empty commit in test
Dec 10 2018, 4:25 PM
indygreg committed rHG5014e93a5696: tests: add sparserevlog requirement to test-sqlitestore.t.
tests: add sparserevlog requirement to test-sqlitestore.t
Dec 10 2018, 4:25 PM
indygreg closed D5403: tests: fix empty commit in test.
Dec 10 2018, 4:25 PM
indygreg closed D5402: tests: add sparserevlog requirement to test-sqlitestore.t.
Dec 10 2018, 4:25 PM
indygreg created D5407: perf: add perfprogress command.
Dec 10 2018, 3:15 PM
indygreg created D5408: progress: avoid ui.configbool() lookup when progress bar is active.
Dec 10 2018, 3:15 PM
indygreg added a dependent revision for D5407: perf: add perfprogress command: D5408: progress: avoid ui.configbool() lookup when progress bar is active.
Dec 10 2018, 3:15 PM
indygreg created D5406: wireprotov2: unify file revision collection and linknode derivation.
Dec 10 2018, 2:44 PM
indygreg created D5405: wireprotov2: send linknodes to emitfilerevisions().
Dec 10 2018, 2:43 PM
indygreg created D5404: tests: add tests for server-side linknode adjustment with wireprotov2.
Dec 10 2018, 2:43 PM
indygreg added a dependent revision for D5405: wireprotov2: send linknodes to emitfilerevisions(): D5406: wireprotov2: unify file revision collection and linknode derivation.
Dec 10 2018, 2:43 PM
indygreg added a dependent revision for D5404: tests: add tests for server-side linknode adjustment with wireprotov2: D5405: wireprotov2: send linknodes to emitfilerevisions().
Dec 10 2018, 2:43 PM
indygreg added a dependent revision for D5403: tests: fix empty commit in test: D5404: tests: add tests for server-side linknode adjustment with wireprotov2.
Dec 10 2018, 2:43 PM
indygreg created D5403: tests: fix empty commit in test.
Dec 10 2018, 2:43 PM
indygreg created D5402: tests: add sparserevlog requirement to test-sqlitestore.t.
Dec 10 2018, 2:41 PM
indygreg accepted D5345: sparse-revlog: enabled by default.

I'll be queuing this shortly.

Dec 10 2018, 11:08 AM
indygreg accepted D5314: test: make sure sparse-revlog does not interfer with test-parseindex.t.

This one had a merge conflict due to the introduction of a negative integer test. I fixed in flight by adding the --config to the new test.

Dec 10 2018, 10:35 AM
indygreg accepted D5401: tests: update network related errors for Debian 9.

This behavior is wonky and smells like a race condition in the kernel or something. But all changes are to places that are expected to fail. I don't think the actual error matters that much. And if this is beyond our control, there's nothing we can do. So ¯\_(ツ)_/¯

Dec 10 2018, 10:25 AM

Nov 29 2018

indygreg committed rHG15a643304728: wireprotov2peer: wait for initial object before resolving future.
wireprotov2peer: wait for initial object before resolving future
Nov 29 2018, 7:28 AM
indygreg committed rHG94b0d0f996e1: wireprotov2peer: always return a bool from _processredirect().
wireprotov2peer: always return a bool from _processredirect()
Nov 29 2018, 7:28 AM

Nov 14 2018

indygreg closed D5267: revlog: automatically read from opened file handles.
Nov 14 2018, 7:29 AM
indygreg closed D5266: revlog: detect incomplete revlog reads.
Nov 14 2018, 7:29 AM
indygreg closed D5265: revlog: use single file handle when de-inlining revlog.
Nov 14 2018, 7:29 AM
indygreg committed rHGe9293c5f8bb9: revlog: automatically read from opened file handles.
revlog: automatically read from opened file handles
Nov 14 2018, 7:29 AM
indygreg committed rHG87a872555e90: revlog: detect incomplete revlog reads.
revlog: detect incomplete revlog reads
Nov 14 2018, 7:29 AM
indygreg committed rHG39369475445c: revlog: use single file handle when de-inlining revlog.
revlog: use single file handle when de-inlining revlog
Nov 14 2018, 7:29 AM

Nov 13 2018

indygreg added a comment to D5064: style: run black on a subset of mercurial.

Where do we stand on the intent to mass reformat the code base?

Nov 13 2018, 8:20 PM
indygreg added a comment to D5170: branchmap: pass changelog into revbranchcache.branchinfo().

I think this patch can be abandoned because of other work late in the 4.8 cycle?

Nov 13 2018, 8:15 PM
indygreg created D5267: revlog: automatically read from opened file handles.
Nov 13 2018, 3:41 PM
indygreg created D5266: revlog: detect incomplete revlog reads.
Nov 13 2018, 3:41 PM
indygreg created D5265: revlog: use single file handle when de-inlining revlog.
Nov 13 2018, 3:41 PM
indygreg added a dependent revision for D5266: revlog: detect incomplete revlog reads: D5267: revlog: automatically read from opened file handles.
Nov 13 2018, 3:41 PM
indygreg added a dependent revision for D5265: revlog: use single file handle when de-inlining revlog: D5266: revlog: detect incomplete revlog reads.
Nov 13 2018, 3:41 PM
indygreg added a comment to D5263: py3: add b suffix to make sure file is opened in bytes mode.

Ideally we'd be using the vfs layer for I/O. But that is scope bloat and I'm not going to make you rewrite RFL to do things more correctly.

Nov 13 2018, 1:48 PM
indygreg added inline comments to D5262: py3: don't use dict.iterkeys().
Nov 13 2018, 1:46 PM

Nov 9 2018

indygreg committed rHG6107d4549fcc: hgweb: cast bytearray to bytes.
hgweb: cast bytearray to bytes
Nov 9 2018, 10:23 PM

Nov 6 2018

indygreg closed D5221: localrepo: extract loading of hgrc files to standalone function.
Nov 6 2018, 7:27 AM
indygreg committed rHG473510bf0575: localrepo: extract loading of hgrc files to standalone function.
localrepo: extract loading of hgrc files to standalone function
Nov 6 2018, 7:27 AM

Nov 5 2018

indygreg requested changes to D5224: revlog: check if PyInt_AS_LONG failed before using result.

IIRC we #define PyInt and PyLong in the source for Python 3 compatibility. I remember doing something really hacky to unblock getting the C extensions to compile on Python 3 at the Paris sprint. It would definitely be a good idea to audit everything with PyInt and PyLong in it for sanity.

Nov 5 2018, 11:16 PM
indygreg created D5221: localrepo: extract loading of hgrc files to standalone function.
Nov 5 2018, 5:16 PM

Oct 31 2018

indygreg added inline comments to D5163: filelog: add a hasnode() method (API).
Oct 31 2018, 4:11 PM
indygreg updated subscribers of D4750: filelog: stop proxying rawsize() (API).

Apparently thg uses this to avoid loading the data into memory just to figure out the length like fctx.rawsize(). Any suggestions?

https://groups.google.com/d/msg/thg-dev/6ekYID7ho_o/fbdd6rVDAwAJ

Oct 31 2018, 3:19 PM
indygreg accepted D5196: changegroup: restore default node ordering (issue6001).

db5501d93bcf6ada3426a45e901094fd877e370f changed a test. I'm surprised this patch doesn't include that revert as well. I'll verify the test as part of landing and amend as necessary.

Oct 31 2018, 3:06 PM