Feed Advanced Search

Thu, Apr 18

gracinet closed D6233: rust-discovery: implementing and exposing stats().
Thu, Apr 18, 7:26 PM
gracinet closed D6232: rust-discovery: cpython bindings for the core logic.
Thu, Apr 18, 7:26 PM
gracinet closed D6231: rust-discovery: starting core implementation.
Thu, Apr 18, 7:26 PM
gracinet committed rHG13b64247f48f: rust-discovery: cpython bindings for the core logic.
rust-discovery: cpython bindings for the core logic
Thu, Apr 18, 7:26 PM
gracinet committed rHG1b0be75cb61f: rust-discovery: implementing and exposing stats().
rust-discovery: implementing and exposing stats()
Thu, Apr 18, 7:26 PM
gracinet committed rHG10b465d61556: rust-discovery: starting core implementation.
rust-discovery: starting core implementation
Thu, Apr 18, 7:26 PM
gracinet closed D6230: rust-dagops: roots.
Thu, Apr 18, 7:26 PM
gracinet closed D6229: rust-dagops: range of revisions.
Thu, Apr 18, 7:26 PM
gracinet committed rHGbe0733552984: rust-dagops: roots.
rust-dagops: roots
Thu, Apr 18, 7:26 PM
gracinet committed rHG3bdb21bbf791: rust-dagops: range of revisions.
rust-dagops: range of revisions
Thu, Apr 18, 7:26 PM
gracinet abandoned D6270: WIP using children_cache instead of dagops::range if present.

Unwanted phabsend on that one (decidedly prematurate, sorry).

Thu, Apr 18, 5:12 AM
gracinet created D6270: WIP using children_cache instead of dagops::range if present.
Thu, Apr 18, 5:11 AM
gracinet added a dependent revision for D6262: rust-discovery: using from Python code: D6270: WIP using children_cache instead of dagops::range if present.
Thu, Apr 18, 5:11 AM
gracinet updated the diff for D6262: rust-discovery: using from Python code.
Thu, Apr 18, 5:11 AM

Wed, Apr 17

gracinet added a comment to D6231: rust-discovery: starting core implementation.

I believe to have addressed your immediate concerns.

Wed, Apr 17, 8:32 AM
gracinet added a comment to D6260: rust-discovery: takefullsample() core implementation.

As I've tried to make clear in the changeset description, this is still work in progress.

Wed, Apr 17, 8:27 AM
gracinet created D6261: rust-discovery: exposing sampling to python.
Wed, Apr 17, 8:17 AM
gracinet created D6262: rust-discovery: using from Python code.
Wed, Apr 17, 8:17 AM
gracinet added a dependent revision for D6261: rust-discovery: exposing sampling to python: D6262: rust-discovery: using from Python code.
Wed, Apr 17, 8:17 AM
gracinet updated the diff for D6257: rust-discovery: core implementation for take_quick_sample().
Wed, Apr 17, 8:17 AM
gracinet created D6260: rust-discovery: takefullsample() core implementation.
Wed, Apr 17, 8:17 AM
gracinet added a dependent revision for D6260: rust-discovery: takefullsample() core implementation: D6261: rust-discovery: exposing sampling to python.
Wed, Apr 17, 8:17 AM
gracinet updated the diff for D6233: rust-discovery: implementing and exposing stats().
Wed, Apr 17, 8:17 AM
gracinet added a dependent revision for D6257: rust-discovery: core implementation for take_quick_sample(): D6260: rust-discovery: takefullsample() core implementation.
Wed, Apr 17, 8:17 AM
gracinet updated the diff for D6231: rust-discovery: starting core implementation.
Wed, Apr 17, 8:17 AM

Tue, Apr 16

gracinet created D6257: rust-discovery: core implementation for take_quick_sample().
Tue, Apr 16, 5:51 PM

Mon, Apr 15

gracinet updated the diff for D6233: rust-discovery: implementing and exposing stats().
Mon, Apr 15, 12:52 PM
gracinet added inline comments to D6231: rust-discovery: starting core implementation.
Mon, Apr 15, 12:50 PM
gracinet updated the diff for D6231: rust-discovery: starting core implementation.
Mon, Apr 15, 12:49 PM
gracinet added a comment to D6231: rust-discovery: starting core implementation.

What I would probably do is still implement the Rust part with multiple structs but then wrap it in an enum for the python API.

Mon, Apr 15, 12:25 PM
gracinet added inline comments to D6232: rust-discovery: cpython bindings for the core logic.
Mon, Apr 15, 12:06 PM
gracinet added a comment to D6229: rust-dagops: range of revisions.

@kevincox, thanks for the review, updated version available.

Mon, Apr 15, 6:13 AM
gracinet added inline comments to D6230: rust-dagops: roots.
Mon, Apr 15, 6:11 AM
gracinet updated the diff for D6230: rust-dagops: roots.
Mon, Apr 15, 6:10 AM
gracinet updated the diff for D6229: rust-dagops: range of revisions.
Mon, Apr 15, 6:10 AM
gracinet added a comment to D6231: rust-discovery: starting core implementation.

@kevincox Thanks for the reviews !

Mon, Apr 15, 6:09 AM
gracinet added inline comments to D6229: rust-dagops: range of revisions.
Mon, Apr 15, 5:50 AM
gracinet abandoned D6228: discovery: stop direct use of attribute of partialdiscovery.

@pulkit, thanks, abandoned this one.

Mon, Apr 15, 5:37 AM

Fri, Apr 12

gracinet updated subscribers of D6228: discovery: stop direct use of attribute of partialdiscovery.

Oops sorry, this one has already been queued by @pulkit (sent it by email, but it was still a draft in my stack).

Fri, Apr 12, 2:35 PM
gracinet created D6233: rust-discovery: implementing and exposing stats().
Fri, Apr 12, 2:34 PM
gracinet created D6232: rust-discovery: cpython bindings for the core logic.
Fri, Apr 12, 2:34 PM
gracinet created D6231: rust-discovery: starting core implementation.
Fri, Apr 12, 2:34 PM
gracinet added a dependent revision for D6232: rust-discovery: cpython bindings for the core logic: D6233: rust-discovery: implementing and exposing stats().
Fri, Apr 12, 2:33 PM
gracinet created D6230: rust-dagops: roots.
Fri, Apr 12, 2:33 PM
gracinet added a dependent revision for D6231: rust-discovery: starting core implementation: D6232: rust-discovery: cpython bindings for the core logic.
Fri, Apr 12, 2:33 PM
gracinet created D6229: rust-dagops: range of revisions.
Fri, Apr 12, 2:33 PM
gracinet added a dependent revision for D6230: rust-dagops: roots: D6231: rust-discovery: starting core implementation.
Fri, Apr 12, 2:33 PM
gracinet added a dependent revision for D6229: rust-dagops: range of revisions: D6230: rust-dagops: roots.
Fri, Apr 12, 2:33 PM
gracinet added a dependent revision for D6228: discovery: stop direct use of attribute of partialdiscovery: D6229: rust-dagops: range of revisions.
Fri, Apr 12, 2:33 PM
gracinet created D6228: discovery: stop direct use of attribute of partialdiscovery.
Fri, Apr 12, 2:33 PM
gracinet committed rHG362726923ba3: discovery: stop direct use of attribute of partialdiscovery.
discovery: stop direct use of attribute of partialdiscovery
Fri, Apr 12, 8:46 AM

Thu, Apr 11

gracinet added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

We had half an hour of direct chat about this yesterday, with @martinvonz and @marmoute. Here's a summary

Thu, Apr 11, 5:22 AM

Mon, Apr 8

gracinet added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

Hi Martin,

Mon, Apr 8, 11:20 AM

Mar 15 2019

gracinet added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I thought of "closure" as well, but I fear it has too many possible meanings, "transitive closure" being one of them in that context (certainly related, but not the same thing), and of course the closures in functional programming.

Mar 15 2019, 7:13 PM

Mar 6 2019

gracinet committed rHGe5ece0f46b40: discovery: moved sampling functions inside discovery object.
discovery: moved sampling functions inside discovery object
Mar 6 2019, 4:02 PM
gracinet committed rHG82884bbf8d2b: discovery: rename `srvheads` to `knownsrvheads`.
discovery: rename `srvheads` to `knownsrvheads`
Mar 6 2019, 4:02 PM

Feb 21 2019

gracinet committed rHG37ead13fb3d4: rust-cpython: using rustext.dagop.headrevs in revlog.
rust-cpython: using rustext.dagop.headrevs in revlog
Feb 21 2019, 6:09 PM
gracinet committed rHG6843379bf99e: changelog: prefilter in headrevs().
changelog: prefilter in headrevs()
Feb 21 2019, 6:09 PM
gracinet committed rHGcde37ed080c9: tests: fixed test too dependent on actual exception wording.
tests: fixed test too dependent on actual exception wording
Feb 21 2019, 6:09 PM

Feb 15 2019

gracinet closed D5945: rust: itering less on MissingAncestors.bases for max().
Feb 15 2019, 10:35 PM
gracinet closed D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Feb 15 2019, 10:35 PM
gracinet closed D5943: rust: less set lookups in MissingAncestors.
Feb 15 2019, 10:35 PM
gracinet committed rHG9060af281be7: rust: itering less on MissingAncestors.bases for max().
rust: itering less on MissingAncestors.bases for max()
Feb 15 2019, 10:34 PM
gracinet committed rHG977432970080: rust: stop putting NULL_REVISION in MissingAncestors.bases.
rust: stop putting NULL_REVISION in MissingAncestors.bases
Feb 15 2019, 10:34 PM
gracinet committed rHGfccb61a1777b: rust: less set lookups in MissingAncestors.
rust: less set lookups in MissingAncestors
Feb 15 2019, 10:34 PM
gracinet closed D5942: rust: less set lookups in AncestorsIterator.
Feb 15 2019, 10:34 PM
gracinet committed rHG70827ebba453: rust: less set lookups in AncestorsIterator.
rust: less set lookups in AncestorsIterator
Feb 15 2019, 10:34 PM

Feb 13 2019

gracinet committed rHG0c7b353ce100: rust-cpython: binding for headrevs().
rust-cpython: binding for headrevs()
Feb 13 2019, 2:22 PM
gracinet committed rHGee7b7bd432a1: rust: translated random test of missingancestors.
rust: translated random test of missingancestors
Feb 13 2019, 2:22 PM
gracinet committed rHG060c030c9993: rust-cpython: moved py_set() utility to conversion module.
rust-cpython: moved py_set() utility to conversion module
Feb 13 2019, 2:22 PM
gracinet committed rHGe37751bd1666: rust-cpython: binding for headrevs().
rust-cpython: binding for headrevs()
Feb 13 2019, 8:19 AM
gracinet committed rHGa38c0662e9f4: rust-cpython: moved py_set() utility to conversion module.
rust-cpython: moved py_set() utility to conversion module
Feb 13 2019, 8:19 AM
gracinet closed D5417: rust: translated random test of missingancestors.
Feb 13 2019, 7:51 AM
gracinet committed rHG9370f4843084: rust: translated random test of missingancestors.
rust: translated random test of missingancestors
Feb 13 2019, 7:51 AM
gracinet updated the diff for D5945: rust: itering less on MissingAncestors.bases for max().
Feb 13 2019, 6:55 AM
gracinet updated the diff for D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Feb 13 2019, 6:55 AM
gracinet added inline comments to D5945: rust: itering less on MissingAncestors.bases for max().
Feb 13 2019, 5:18 AM

Feb 12 2019

gracinet added inline comments to D5945: rust: itering less on MissingAncestors.bases for max().
Feb 12 2019, 11:32 AM
gracinet updated the diff for D5945: rust: itering less on MissingAncestors.bases for max().
Feb 12 2019, 11:27 AM
gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja I'm trying to find a compromise between our points of view : I'd like very much it to be run automatically (hence an integration test), and you want to be parametrizable. So, I'm pushing a version that has these two properties, working with env variables, since command-line arguments are already used by the testing framework. Hope it'll suit you, if it doesn't, I'll put it in examples and find a way to run it anyway

Feb 12 2019, 9:07 AM
gracinet updated the diff for D5417: rust: translated random test of missingancestors.
Feb 12 2019, 9:05 AM
gracinet created D5945: rust: itering less on MissingAncestors.bases for max().
Feb 12 2019, 7:02 AM
gracinet created D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Feb 12 2019, 7:02 AM
gracinet added a dependent revision for D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases: D5945: rust: itering less on MissingAncestors.bases for max().
Feb 12 2019, 7:02 AM
gracinet created D5943: rust: less set lookups in MissingAncestors.
Feb 12 2019, 7:02 AM
gracinet added a dependent revision for D5943: rust: less set lookups in MissingAncestors: D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Feb 12 2019, 7:02 AM
gracinet created D5942: rust: less set lookups in AncestorsIterator.
Feb 12 2019, 7:02 AM
gracinet added a dependent revision for D5942: rust: less set lookups in AncestorsIterator: D5943: rust: less set lookups in MissingAncestors.
Feb 12 2019, 7:02 AM

Feb 5 2019

gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja we don't need a seed to reproduce: failed examples contain all the information (that's a difference with the Python version)

Feb 5 2019, 9:21 AM

Feb 4 2019

gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja now that 4.9 is out, I'm getting back to this.

Feb 4 2019, 7:30 AM

Jan 25 2019

gracinet committed rHGab0d762d89ef: rust-cpython: raising error.WdirUnsupported.
rust-cpython: raising error.WdirUnsupported
Jan 25 2019, 3:55 AM
gracinet committed rHGee943a920606: rust: error for WdirUnsupported with cpython conversion as exception.
rust: error for WdirUnsupported with cpython conversion as exception
Jan 25 2019, 3:55 AM
gracinet committed rHG2f54f31c41aa: rust: working directory revision number constant.
rust: working directory revision number constant
Jan 25 2019, 3:55 AM

Jan 16 2019

gracinet added a comment to D5579: rust: factorized testing Graphs.

@yuja the doc you're linking is about integration tests, so it wouldn't apply to these tests which are really unitary in my mind. Usually the main difference would be the access to the private constructs that the integration tests can't perform, but it's true that most of these implementations are public anyway.

Jan 16 2019, 9:50 AM
gracinet closed D5551: rust-cpython: using MissingAncestors from Python code.
Jan 16 2019, 7:45 AM
gracinet closed D5584: rust: MissingAncestors.basesheads().
Jan 16 2019, 7:45 AM
gracinet committed rHGa89b20a49c13: rust-cpython: using MissingAncestors from Python code.
rust-cpython: using MissingAncestors from Python code
Jan 16 2019, 7:44 AM
gracinet committed rHG619ee4039bd4: rust: MissingAncestors.basesheads().
rust: MissingAncestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet committed rHG4856c9b8cbaf: ancestor: incrementalmissingancestors.basesheads().
ancestor: incrementalmissingancestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet closed D5579: rust: factorized testing Graphs.
Jan 16 2019, 7:44 AM