Feed Advanced Search

Today

martinvonz accepted D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

This looks good to me. Greg?

Thu, Apr 25, 1:38 PM
martinvonz committed rHGc96507f6875c: tests: demonstrate `hg log -r . <file>` linkrev bug.
tests: demonstrate `hg log -r . <file>` linkrev bug
Thu, Apr 25, 12:33 PM
martinvonz added a comment to D6274: copies: document cases in _chain().

I think the rest of the stack from this patch are independent of the ones before, so if reviewers are intimidated by D6255, they should still be able to take this section of the stack.

Thu, Apr 25, 1:14 AM

Yesterday

martinvonz closed D6309: tests: demonstrate `hg log -r . <file>` linkrev bug.
Wed, Apr 24, 7:30 PM
martinvonz committed rHGeb68fd841984: tests: demonstrate `hg log -r . <file>` linkrev bug.
tests: demonstrate `hg log -r . <file>` linkrev bug
Wed, Apr 24, 7:29 PM
martinvonz added a comment to D6302: phabricator: include branch in the phabread output.

This series looks reasonable to me, but I have no experience with this code. Anyone else feels like reviewing? Otherwise I'll probably just queue it in a day or two.

Wed, Apr 24, 3:11 PM
martinvonz added inline comments to D6301: phabricator: fallback to reading metadata from diff for phabread.
Wed, Apr 24, 3:11 PM
martinvonz added inline comments to D6301: phabricator: fallback to reading metadata from diff for phabread.
Wed, Apr 24, 3:10 PM
martinvonz added inline comments to D6289: unionrepo: sync with repository API.
Wed, Apr 24, 3:00 PM
martinvonz added inline comments to D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).
Wed, Apr 24, 2:48 PM
martinvonz created D6309: tests: demonstrate `hg log -r . <file>` linkrev bug.
Wed, Apr 24, 2:18 PM
martinvonz added inline comments to D6308: context: check file exists before getting data from _wrappedctx.
Wed, Apr 24, 2:16 PM
martinvonz added inline comments to D6308: context: check file exists before getting data from _wrappedctx.
Wed, Apr 24, 2:10 PM
martinvonz added inline comments to D6308: context: check file exists before getting data from _wrappedctx.
Wed, Apr 24, 1:35 PM
martinvonz added inline comments to D6307: tests: show IMM is broken when merging file empty in destination.
Wed, Apr 24, 1:30 PM

Tue, Apr 23

martinvonz closed D6305: match: remove unused match.__iter__ implementation (API).
Tue, Apr 23, 7:25 PM
martinvonz committed rHG7edff8dd46a7: match: remove unused match.__iter__ implementation (API).
match: remove unused match.__iter__ implementation (API)
Tue, Apr 23, 7:25 PM
martinvonz added inline comments to D6167: fix: allow fixer tools to return metadata in addition to the file content.
Tue, Apr 23, 5:11 PM
martinvonz accepted D6167: fix: allow fixer tools to return metadata in addition to the file content.
Tue, Apr 23, 4:55 PM
martinvonz created D6306: copies: write empty entries in changeset when also writing to filelog.
Tue, Apr 23, 4:32 PM
martinvonz added a dependent revision for D6269: copies: ignore heuristics copytracing when using changeset-centric algos: D6306: copies: write empty entries in changeset when also writing to filelog.
Tue, Apr 23, 4:32 PM
martinvonz created D6305: match: remove unused match.__iter__ implementation (API).
Tue, Apr 23, 12:16 PM

Mon, Apr 22

martinvonz added inline comments to D6167: fix: allow fixer tools to return metadata in addition to the file content.
Mon, Apr 22, 6:10 PM
martinvonz added a comment to D6167: fix: allow fixer tools to return metadata in addition to the file content.

I don't like to queue patches that are written mainly for Google's benefit, but it's been a month and we haven't heard any complaints. I'll start reviewing this now and will queue it when I'm done (assuming I have no major comments, of course).

Mon, Apr 22, 5:49 PM

Sun, Apr 21

martinvonz closed D6279: tests: make log style a little easier to read in test-copytrace-heuristics.t.
Sun, Apr 21, 6:17 AM
martinvonz committed rHG802ae9772ced: tests: make log style a little easier to read in test-copytrace-heuristics.t.
tests: make log style a little easier to read in test-copytrace-heuristics.t
Sun, Apr 21, 6:17 AM

Fri, Apr 19

martinvonz closed D6280: tests: avoid cryptic nodeids in tests/test-rename-merge1.t.
Fri, Apr 19, 9:08 AM
martinvonz closed D6278: tests: defines aliases for `hg log` calls in test-copytrace-heuristics.t.
Fri, Apr 19, 9:08 AM
martinvonz committed rHGfad480dad04d: tests: avoid cryptic nodeids in tests/test-rename-merge1.t.
tests: avoid cryptic nodeids in tests/test-rename-merge1.t
Fri, Apr 19, 9:08 AM
martinvonz committed rHG1afd9d1e55ca: tests: defines aliases for `hg log` calls in test-copytrace-heuristics.t.
tests: defines aliases for `hg log` calls in test-copytrace-heuristics.t
Fri, Apr 19, 9:08 AM
martinvonz created D6279: tests: make log style a little easier to read in test-copytrace-heuristics.t.
Fri, Apr 19, 1:28 AM
martinvonz created D6280: tests: avoid cryptic nodeids in tests/test-rename-merge1.t.
Fri, Apr 19, 1:28 AM
martinvonz created D6278: tests: defines aliases for `hg log` calls in test-copytrace-heuristics.t.
Fri, Apr 19, 1:28 AM
martinvonz added a dependent revision for D6279: tests: make log style a little easier to read in test-copytrace-heuristics.t: D6280: tests: avoid cryptic nodeids in tests/test-rename-merge1.t.
Fri, Apr 19, 1:28 AM
martinvonz added a dependent revision for D6278: tests: defines aliases for `hg log` calls in test-copytrace-heuristics.t: D6279: tests: make log style a little easier to read in test-copytrace-heuristics.t.
Fri, Apr 19, 1:28 AM

Thu, Apr 18

martinvonz added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

An idea to consider (which may have been proposed already) is to write a *no copy metadata* entry into extras when writing copy metadata to the changelog. If we did things this way, a new client could know definitively that no copy metadata is available and to not fall back to reading from the filelogs. I haven't fully thought this through, but that should provide better compatibility between older and newer clients. Obviously the tradeoff is you could have a mixed repo (some changesets wouldn't have copy metadata in changelog) and you would need to duplicate copy metadata across changelog and filelogs to maintain compatibility. Something to contemplate...

Thu, Apr 18, 2:09 PM
martinvonz added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

I support experimenting with putting copy metadata in the changelog. And the patches before this one did a lot of work to allow copy metadata to be read from alternate sources, which is great, since it can allow flexibility in the future (think copy caches, copy modifications outside of a commit, etc).

Thu, Apr 18, 1:59 PM
martinvonz created D6277: copies: filter out copies from non-existent source later in _chain().
Thu, Apr 18, 1:58 PM
martinvonz updated the diff for D6276: copies: clarify mutually exclusive cases in _chain() with a s/if/elif/.
Thu, Apr 18, 1:58 PM
martinvonz added a dependent revision for D6276: copies: clarify mutually exclusive cases in _chain() with a s/if/elif/: D6277: copies: filter out copies from non-existent source later in _chain().
Thu, Apr 18, 1:58 PM
martinvonz updated the diff for D6275: copies: delete a redundant cleanup step in _chain().
Thu, Apr 18, 1:58 PM
martinvonz updated the diff for D6274: copies: document cases in _chain().
Thu, Apr 18, 1:58 PM
martinvonz added inline comments to D6274: copies: document cases in _chain().
Thu, Apr 18, 1:49 PM
martinvonz committed rHG84bd6ae2d1f6: narrow: also warn when not deleting untracked or ignored files.
narrow: also warn when not deleting untracked or ignored files
Thu, Apr 18, 1:12 PM
martinvonz committed rHGa68036b849b0: copies: delete debug message about "unmatched files new in both".
copies: delete debug message about "unmatched files new in both"
Thu, Apr 18, 1:11 PM
martinvonz committed rHG341bddf88ac5: copies: delete debug message about changes since common ancestor.
copies: delete debug message about changes since common ancestor
Thu, Apr 18, 1:11 PM
martinvonz committed rHG91a0bc50b288: copies: delete debug message about search limit.
copies: delete debug message about search limit
Thu, Apr 18, 1:11 PM
martinvonz created D6276: copies: clarify mutually exclusive cases in _chain() with a s/if/elif/.
Thu, Apr 18, 12:55 PM
martinvonz created D6275: copies: delete a redundant cleanup step in _chain().
Thu, Apr 18, 12:55 PM
martinvonz added a dependent revision for D6275: copies: delete a redundant cleanup step in _chain(): D6276: copies: clarify mutually exclusive cases in _chain() with a s/if/elif/.
Thu, Apr 18, 12:55 PM
martinvonz created D6274: copies: document cases in _chain().
Thu, Apr 18, 12:55 PM
martinvonz added a dependent revision for D6274: copies: document cases in _chain(): D6275: copies: delete a redundant cleanup step in _chain().
Thu, Apr 18, 12:55 PM
martinvonz closed D6265: narrow: also warn when not deleting untracked or ignored files.
Thu, Apr 18, 7:42 AM
martinvonz committed rHGaa8f83923aef: narrow: also warn when not deleting untracked or ignored files.
narrow: also warn when not deleting untracked or ignored files
Thu, Apr 18, 7:42 AM

Wed, Apr 17

martinvonz closed D6249: copies: delete debug message about search limit.
Wed, Apr 17, 7:29 PM
martinvonz closed D6250: copies: delete debug message about changes since common ancestor.
Wed, Apr 17, 7:28 PM
martinvonz closed D6251: copies: delete debug message about "unmatched files new in both".
Wed, Apr 17, 7:28 PM
martinvonz committed rHG1e266bd9f25b: copies: delete debug message about "unmatched files new in both".
copies: delete debug message about "unmatched files new in both"
Wed, Apr 17, 7:27 PM
martinvonz committed rHG380f59da7aea: copies: delete debug message about search limit.
copies: delete debug message about search limit
Wed, Apr 17, 7:27 PM
martinvonz closed D6246: copies: fix up "fullcopy" with missing entries from "copy".
Wed, Apr 17, 7:27 PM
martinvonz committed rHG43c2a13b56eb: copies: delete debug message about changes since common ancestor.
copies: delete debug message about changes since common ancestor
Wed, Apr 17, 7:27 PM
martinvonz closed D6248: copies: move early return for "no copies" case a little earlier.
Wed, Apr 17, 7:27 PM
martinvonz committed rHG85f5934016f9: copies: move early return for "no copies" case a little earlier.
copies: move early return for "no copies" case a little earlier
Wed, Apr 17, 7:27 PM
martinvonz closed D6245: merge: remove workaround for issue5020.
Wed, Apr 17, 7:27 PM
martinvonz closed D6247: copies: fix up "fullcopy" with missing entries from "diverge".
Wed, Apr 17, 7:27 PM
martinvonz committed rHG22c9ffdf8ef6: copies: fix up "fullcopy" with missing entries from "diverge".
copies: fix up "fullcopy" with missing entries from "diverge"
Wed, Apr 17, 7:26 PM
martinvonz closed D6244: copies: don't include copies that are not in source in directory move.
Wed, Apr 17, 7:26 PM
martinvonz committed rHG96bd75e67a94: copies: fix up "fullcopy" with missing entries from "copy".
copies: fix up "fullcopy" with missing entries from "copy"
Wed, Apr 17, 7:26 PM
martinvonz committed rHGbeec7fc6adec: merge: remove workaround for issue5020.
merge: remove workaround for issue5020
Wed, Apr 17, 7:26 PM
martinvonz closed D6242: tests: add test for issue5343 (grafting with copies).
Wed, Apr 17, 7:26 PM
martinvonz committed rHG31abb9d713af: copies: don't include copies that are not in source in directory move.
copies: don't include copies that are not in source in directory move
Wed, Apr 17, 7:26 PM
martinvonz committed rHG7815cf0ea88b: tests: add test for issue5343 (grafting with copies).
tests: add test for issue5343 (grafting with copies)
Wed, Apr 17, 7:26 PM
martinvonz added a comment to D6263: Typos.

I haven't run tests on this, but I'm guessing one of the test-check* tests will tell you that your subject line ("Typos") does not follow our style guide (you could change it to something like "setdiscovery: fix a few typos").

Wed, Apr 17, 6:41 PM
martinvonz updated the diff for D6249: copies: delete debug message about search limit.
Wed, Apr 17, 6:23 PM
martinvonz updated the diff for D6250: copies: delete debug message about changes since common ancestor.
Wed, Apr 17, 6:22 PM
martinvonz updated the diff for D6251: copies: delete debug message about "unmatched files new in both".
Wed, Apr 17, 6:21 PM
martinvonz updated the diff for D6246: copies: fix up "fullcopy" with missing entries from "copy".
Wed, Apr 17, 6:21 PM
martinvonz updated the diff for D6248: copies: move early return for "no copies" case a little earlier.
Wed, Apr 17, 6:20 PM
martinvonz updated the diff for D6244: copies: don't include copies that are not in source in directory move.
Wed, Apr 17, 6:20 PM
martinvonz updated the diff for D6247: copies: fix up "fullcopy" with missing entries from "diverge".
Wed, Apr 17, 6:20 PM
martinvonz closed D6252: tests: make merge conflicts explicit in `hg annotate` tests.
Wed, Apr 17, 6:12 PM
martinvonz closed D6243: tests: split out separate test for issue5020.
Wed, Apr 17, 6:11 PM
martinvonz closed D6254: tests: avoid a rename/delete conflict when updating in test-narrow-update.t.
Wed, Apr 17, 6:11 PM
martinvonz committed rHGf2fe7cf4ebb6: tests: split out separate test for issue5020.
tests: split out separate test for issue5020
Wed, Apr 17, 6:11 PM
martinvonz committed rHG351cbda889db: tests: avoid a rename/delete conflict when updating in test-narrow-update.t.
tests: avoid a rename/delete conflict when updating in test-narrow-update.t
Wed, Apr 17, 6:11 PM
martinvonz closed D6253: tests: delete unused function in test-rename-merge2.t.
Wed, Apr 17, 6:11 PM
martinvonz committed rHG344066b54a7b: tests: delete unused function in test-rename-merge2.t.
tests: delete unused function in test-rename-merge2.t
Wed, Apr 17, 6:11 PM
martinvonz committed rHG7116fc614cfc: tests: make merge conflicts explicit in `hg annotate` tests.
tests: make merge conflicts explicit in `hg annotate` tests
Wed, Apr 17, 6:11 PM
martinvonz committed rHG770f5f586ae5: narrow: make warning about possibly dirty files respect ui.relative-paths.
narrow: make warning about possibly dirty files respect ui.relative-paths
Wed, Apr 17, 6:11 PM
martinvonz closed D6264: narrow: make warning about possibly dirty files respect ui.relative-paths.
Wed, Apr 17, 6:11 PM
martinvonz added a comment to D6255: copies: calculate mergecopies() based on pathcopies().

Since this seems the very same code as the previous clause, I wonder if
we could factor it out. This would help to prevent subtle bug when we
update it. (the answer might be "no because python is slow).

Yes, I also considered that. I wasn't sure what a good name for the method would be and I gave up. I'll try again.

Wed, Apr 17, 6:08 PM
martinvonz updated the diff for D6255: copies: calculate mergecopies() based on pathcopies().
Wed, Apr 17, 6:07 PM
martinvonz created D6269: copies: ignore heuristics copytracing when using changeset-centric algos.
Wed, Apr 17, 6:06 PM
martinvonz updated the diff for D6256: copies: inline _computenonoverlap() in mergecopies().
Wed, Apr 17, 6:06 PM
martinvonz created D6268: copies: move check for experimental.copytrace==<falsy> earlier.
Wed, Apr 17, 6:06 PM
martinvonz updated the diff for D6266: copies: replace .items() by .values() where appropriate.
Wed, Apr 17, 6:06 PM
martinvonz added a dependent revision for D6266: copies: replace .items() by .values() where appropriate: D6268: copies: move check for experimental.copytrace==<falsy> earlier.
Wed, Apr 17, 6:06 PM
martinvonz retitled D6264: narrow: make warning about possibly dirty files respect ui.relative-paths from narrow: make warning about dirty possibly files respect ui.relative-paths to narrow: make warning about possibly dirty files respect ui.relative-paths.
Wed, Apr 17, 5:21 PM
martinvonz updated the diff for D6265: narrow: also warn when not deleting untracked or ignored files.
Wed, Apr 17, 5:19 PM
martinvonz added inline comments to D6265: narrow: also warn when not deleting untracked or ignored files.
Wed, Apr 17, 5:16 PM