Page MenuHomePhabricator
Feed Advanced Search

Yesterday

martinvonz closed D6758: narrow: fix typo "respositories".
Fri, Aug 23, 7:31 PM
martinvonz committed rHG383fdfa6bba9: narrow: fix typo "respositories".
narrow: fix typo "respositories"
Fri, Aug 23, 7:31 PM
martinvonz created D6759: run-tests: error out on `--local --with-[c]hg`.
Fri, Aug 23, 5:06 PM
martinvonz created D6760: run-tests: handle --local before --with-hg.
Fri, Aug 23, 5:06 PM

Thu, Aug 22

martinvonz created D6758: narrow: fix typo "respositories".
Thu, Aug 22, 7:51 PM
martinvonz closed D6755: merge: hint about using `hg resolve` for resolving conflicts.
Thu, Aug 22, 1:59 PM
martinvonz committed rHG7b80ad5af239: merge: hint about using `hg resolve` for resolving conflicts.
merge: hint about using `hg resolve` for resolving conflicts
Thu, Aug 22, 1:58 PM

Wed, Aug 21

martinvonz created D6755: merge: hint about using `hg resolve` for resolving conflicts.
Wed, Aug 21, 4:21 PM

Tue, Aug 20

martinvonz retitled D6751: tests: show invalid copies when turning off copies-in-changeset from test: show invalid copies when turning off copies-in-changeset to tests: show invalid copies when turning off copies-in-changeset.
Tue, Aug 20, 12:29 PM
martinvonz created D6750: context: filter out invalid copies from workingctx.p[12]copies().
Tue, Aug 20, 12:29 PM
martinvonz created D6752: copies: remove existing copy info from the changeset on amend (BC).
Tue, Aug 20, 12:29 PM
martinvonz created D6751: tests: show invalid copies when turning off copies-in-changeset.
Tue, Aug 20, 12:29 PM
martinvonz created D6749: tests: demonstrate crash when committing subset of copies to changeset.
Tue, Aug 20, 12:29 PM
martinvonz committed rHGc00005975c91: perf: don't depend on pycompat for older Mercurial versions.
perf: don't depend on pycompat for older Mercurial versions
Tue, Aug 20, 12:01 PM
martinvonz committed rHG777a9df5a1ef: perf: don't try to call `util.queue` on Mercurial version before it existed.
perf: don't try to call `util.queue` on Mercurial version before it existed
Tue, Aug 20, 12:01 PM
martinvonz committed rHGc8d3af9c7e65: perf: handle NameError for `pycompat.foo` when pycompat wasn't imported.
perf: handle NameError for `pycompat.foo` when pycompat wasn't imported
Tue, Aug 20, 12:01 PM
martinvonz closed D6745: perf: don't depend on pycompat for older Mercurial versions.
Tue, Aug 20, 11:36 AM
martinvonz closed D6744: perf: don't try to call `util.queue` on Mercurial version before it existed.
Tue, Aug 20, 11:36 AM
martinvonz closed D6743: perf: handle NameError for `pycompat.foo` when pycompat wasn't imported.
Tue, Aug 20, 11:36 AM
martinvonz committed rHG1b0af23c71c1: perf: don't depend on pycompat for older Mercurial versions.
perf: don't depend on pycompat for older Mercurial versions
Tue, Aug 20, 11:36 AM
martinvonz committed rHGb1e53b192497: perf: don't try to call `util.queue` on Mercurial version before it existed.
perf: don't try to call `util.queue` on Mercurial version before it existed
Tue, Aug 20, 11:36 AM
martinvonz committed rHGfd62b027d6a4: perf: handle NameError for `pycompat.foo` when pycompat wasn't imported.
perf: handle NameError for `pycompat.foo` when pycompat wasn't imported
Tue, Aug 20, 11:36 AM
martinvonz added a comment to D6746: perf: don't pass experimental argument in config for older Mercurial versions.

When this patch is ready, could we fold this into a11fd395e83f? I have extensions.perf=contrib/perf.py in my config and it's pretty annoying to have any commit in the broken range checked out.

Tue, Aug 20, 11:29 AM
martinvonz added a comment to D6741: interfaces: create a new folder for interfaces and move repository.py in it.
In D6741#99023, @pulkit wrote:

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help with future patches? Or you just like this structure better?

Looking through Augie's hgit patch, I found we need to add more interfaces and decided to work on adding for store.basicstore. I found all the current interfaces in repository.py which has grown very large. I decided to create a new file to have interface for the store class, and maybe a new one for dirstate too, and having them in a separate folder dedicated to interfaces will be nice.

I'm inclined to agree - the repository.py file full of interfaces has gotten crufty. It'd be nice to split it out into more files by topic.

Tue, Aug 20, 11:17 AM

Mon, Aug 19

martinvonz created D6745: perf: don't depend on pycompat for older Mercurial versions.
Mon, Aug 19, 1:43 PM
martinvonz created D6744: perf: don't try to call `util.queue` on Mercurial version before it existed.
Mon, Aug 19, 1:43 PM
martinvonz created D6743: perf: handle NameError for `pycompat.foo` when pycompat wasn't imported.
Mon, Aug 19, 1:43 PM
martinvonz added a comment to D6741: interfaces: create a new folder for interfaces and move repository.py in it.

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

Mon, Aug 19, 6:48 AM

Tue, Aug 6

martinvonz committed rHGcba59b338976: relnotes: copy "next" to "5.1" and clear "next".
relnotes: copy "next" to "5.1" and clear "next"
Tue, Aug 6, 8:08 AM
martinvonz closed D6705: relnotes: copy "next" to "5.1" and clear "next".
Tue, Aug 6, 8:08 AM

Thu, Aug 1

martinvonz created D6705: relnotes: copy "next" to "5.1" and clear "next".
Thu, Aug 1, 4:35 PM
martinvonz added a comment to D6659: graft: split graft code into seperate functions.

I just found a comment I wrote a while ago and forgot to submit. Sorry.

Thu, Aug 1, 1:42 PM

Wed, Jul 31

martinvonz closed D6664: transaction: leave unfinished without crashing when not properly released.
Wed, Jul 31, 7:46 PM
martinvonz committed rHG36c692eb28d3: transaction: leave unfinished without crashing when not properly released.
transaction: leave unfinished without crashing when not properly released
Wed, Jul 31, 7:46 PM

Thu, Jul 25

martinvonz updated subscribers of D6670: relnotes: empty to prepare for next release.
In D6670#97968, @yuja wrote:

Might be better to rename next to 5.1, and recreate new next file.
The old next file in stable branch could theoretically be edited and
merged back to default.

Thu, Jul 25, 7:44 PM
martinvonz added inline comments to D6693: fix: ignore fixer tool configurations that are missing patterns.
Thu, Jul 25, 12:01 PM

Jul 24 2019

martinvonz committed rHGa562df8a3e98: relnotes: empty to prepare for next release.
relnotes: empty to prepare for next release
Jul 24 2019, 5:32 AM
martinvonz closed D6670: relnotes: empty to prepare for next release.
Jul 24 2019, 5:32 AM
martinvonz closed D6675: copies: fix crash on in changeset-centric tracing from commit to itself.
Jul 24 2019, 5:27 AM
martinvonz committed rHG8c5a36805d5d: copies: fix crash on in changeset-centric tracing from commit to itself.
copies: fix crash on in changeset-centric tracing from commit to itself
Jul 24 2019, 5:27 AM

Jul 23 2019

martinvonz added a comment to D6675: copies: fix crash on in changeset-centric tracing from commit to itself.

Intended for stable.

Jul 23 2019, 12:16 AM
martinvonz created D6675: copies: fix crash on in changeset-centric tracing from commit to itself.
Jul 23 2019, 12:15 AM

Jul 22 2019

martinvonz created D6670: relnotes: empty to prepare for next release.
Jul 22 2019, 3:38 PM
martinvonz closed D6669: py: error out if a "skip" character was given with non-dict to util.dirs().
Jul 22 2019, 3:04 PM
martinvonz committed rHGb5092c23ca35: py: error out if a "skip" character was given with non-dict to util.dirs().
py: error out if a "skip" character was given with non-dict to util.dirs()
Jul 22 2019, 3:03 PM
martinvonz closed D6668: py3: fix incorrect fix of test-setdiscovery.t in eb27d9eee2cc.
Jul 22 2019, 3:03 PM
martinvonz committed rHG06ee841697a8: py3: fix incorrect fix of test-setdiscovery.t in eb27d9eee2cc.
py3: fix incorrect fix of test-setdiscovery.t in eb27d9eee2cc
Jul 22 2019, 3:03 PM
martinvonz committed rHGa2c02877b097: py3: add a b'' prefix in tests/test-convert-identity.t.
py3: add a b'' prefix in tests/test-convert-identity.t
Jul 22 2019, 1:19 PM
martinvonz committed rHG24111fb9a725: lookup: don't use "00changelog.i@None" when lookup of prefix fails.
lookup: don't use "00changelog.i@None" when lookup of prefix fails
Jul 22 2019, 1:19 PM
martinvonz created D6669: py: error out if a "skip" character was given with non-dict to util.dirs().
Jul 22 2019, 1:06 PM
martinvonz created D6668: py3: fix incorrect fix of test-setdiscovery.t in eb27d9eee2cc.
Jul 22 2019, 12:57 PM
martinvonz added inline comments to D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
Jul 22 2019, 12:54 PM
martinvonz closed D6661: lookup: don't use "00changelog.i@None" when lookup of prefix fails.
Jul 22 2019, 6:54 AM
martinvonz closed D6662: py3: add a b'' prefix in tests/test-convert-identity.t.
Jul 22 2019, 6:54 AM
martinvonz committed rHGc3ace4ecfb2b: py3: add a b'' prefix in tests/test-convert-identity.t.
py3: add a b'' prefix in tests/test-convert-identity.t
Jul 22 2019, 6:54 AM
martinvonz committed rHGa979939da14e: lookup: don't use "00changelog.i@None" when lookup of prefix fails.
lookup: don't use "00changelog.i@None" when lookup of prefix fails
Jul 22 2019, 6:54 AM

Jul 21 2019

martinvonz added inline comments to D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
Jul 21 2019, 8:25 PM
martinvonz created D6664: transaction: leave unfinished without crashing when not properly released.
Jul 21 2019, 11:01 AM
D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines is now accepted and ready to land.

Heh, I wrote a patch for this before I saw yours. The problem is that random.sample() (and other integer-based functions) changed, see https://bugs.python.org/issue27742.

Jul 21 2019, 10:24 AM
D6660: commands: removed part of description from abort and continue is now accepted and ready to land.
Jul 21 2019, 10:15 AM
D6663: tests: glob over some timing numbers in test-shelve.t is now accepted and ready to land.
Jul 21 2019, 10:14 AM
martinvonz added a comment to D6655: continue: added support for graft.

Sorry, but since both Yuya and I are uncomfortable with this patch, I'll de-queue it so it doesn't block other patches from getting queued. I think it would be good if you can fold D6659 into this one and then split it up so have only the refactoring in a first patch and the new support for continue in a second patch. Thanks.

Jul 21 2019, 10:10 AM

Jul 20 2019

martinvonz created D6662: py3: add a b'' prefix in tests/test-convert-identity.t.
Jul 20 2019, 2:24 PM

Jul 19 2019

martinvonz added inline comments to D6655: continue: added support for graft.
Jul 19 2019, 6:21 PM
martinvonz added a comment to D6655: continue: added support for graft.

@martinvonz I will send a patch doing that.

Jul 19 2019, 6:03 PM
martinvonz created D6661: lookup: don't use "00changelog.i@None" when lookup of prefix fails.
Jul 19 2019, 1:37 PM

Jul 18 2019

martinvonz added a comment to D6655: continue: added support for graft.

There is a lot of duplication here. Can you try to extract common parts?

Jul 18 2019, 2:20 PM

Jul 17 2019

martinvonz added a comment to D6612: tests: show the files fields of changelogs for many merges.

(Martin, this looks fine to me, if you've got no objections let's include it in 5.1)

Jul 17 2019, 6:36 PM
martinvonz closed D6647: copies: remove unnecessary override of p[12]copies() in workingctx.
Jul 17 2019, 2:27 AM
martinvonz committed rHG97b03f0e7c7b: copies: remove unnecessary override of p[12]copies() in workingctx.
copies: remove unnecessary override of p[12]copies() in workingctx
Jul 17 2019, 2:26 AM

Jul 15 2019

martinvonz committed rHG3018749a71bb: py3: source-transform only call-sites of iteritems(), not definitions.
py3: source-transform only call-sites of iteritems(), not definitions
Jul 15 2019, 7:45 PM
martinvonz added a comment to D6641: py3: source-transform only call-sites of iteritems(), not definitions.
In D6641#97205, @yuja wrote:
  • a/mercurial/__init__.py

+++ b/mercurial/__init__.py
@@ -225,7 +225,9 @@

    1. It changes iteritems/values to items/values as they are not
    2. present in Python 3 world.
  • elif fn in ('iteritems', 'itervalues'):

+ elif (fn in ('iteritems', 'itervalues') and
+ not (tokens[i - 1].type == token.NAME and
+ tokens[i - 1].string == 'def')):

Perhaps, we need to bump the BYTECODEHEADER version to recompile all
py3 modules.

Jul 15 2019, 7:42 PM
martinvonz created D6647: copies: remove unnecessary override of p[12]copies() in workingctx.
Jul 15 2019, 6:36 PM
martinvonz closed D6644: py3: fix formatting of branchmap log messages with repo.filtername=None.
Jul 15 2019, 10:14 AM
martinvonz closed D6641: py3: source-transform only call-sites of iteritems(), not definitions.
Jul 15 2019, 10:14 AM
martinvonz committed rHG5a6ba3165736: py3: source-transform only call-sites of iteritems(), not definitions.
py3: source-transform only call-sites of iteritems(), not definitions
Jul 15 2019, 10:14 AM
martinvonz committed rHGc7d236b55a3e: py3: fix formatting of branchmap log messages with repo.filtername=None.
py3: fix formatting of branchmap log messages with repo.filtername=None
Jul 15 2019, 10:14 AM
martinvonz created D6644: py3: fix formatting of branchmap log messages with repo.filtername=None.
Jul 15 2019, 2:36 AM

Jul 13 2019

martinvonz created D6641: py3: source-transform only call-sites of iteritems(), not definitions.
Jul 13 2019, 3:11 AM

Jul 10 2019

martinvonz closed D6603: copies: filter invalid copies only at end of pathcopies() (issue6163).
Jul 10 2019, 3:40 PM
martinvonz committed rHG83666f011679: py3: store _origdoc as str.
py3: store _origdoc as str
Jul 10 2019, 3:39 PM
martinvonz closed D6604: copies: follow copies across merge base without source file (issue6163).
Jul 10 2019, 3:39 PM
martinvonz closed D6623: py3: store _origdoc as str.
Jul 10 2019, 3:39 PM
martinvonz committed rHGd013099c551b: copies: filter invalid copies only at end of pathcopies() (issue6163).
copies: filter invalid copies only at end of pathcopies() (issue6163)
Jul 10 2019, 3:39 PM
martinvonz committed rHG819712deac69: copies: follow copies across merge base without source file (issue6163).
copies: follow copies across merge base without source file (issue6163)
Jul 10 2019, 3:39 PM
martinvonz closed D6602: copies: inline _chainandfilter() to prepare for next patch.
Jul 10 2019, 3:39 PM
martinvonz committed rHG11ceb1b8fd74: copies: inline _chainandfilter() to prepare for next patch.
copies: inline _chainandfilter() to prepare for next patch
Jul 10 2019, 3:39 PM
martinvonz closed D6601: copies: remove most early returns from pathcopies() and _forwardcopies().
Jul 10 2019, 3:39 PM
martinvonz committed rHGa48f6f18dc6d: copies: remove most early returns from pathcopies() and _forwardcopies().
copies: remove most early returns from pathcopies() and _forwardcopies()
Jul 10 2019, 3:39 PM
martinvonz closed D6600: copies: move short-circuiting of dirstate copies out of _forwardcopies().
Jul 10 2019, 3:39 PM
martinvonz committed rHGbcb4b5c5964b: copies: move short-circuiting of dirstate copies out of _forwardcopies().
copies: move short-circuiting of dirstate copies out of _forwardcopies()
Jul 10 2019, 3:39 PM
martinvonz closed D6599: tests: add more tests of copy tracing with removed and re-added files.
Jul 10 2019, 3:39 PM
martinvonz committed rHGab416b5d9b91: tests: add more tests of copy tracing with removed and re-added files.
tests: add more tests of copy tracing with removed and re-added files
Jul 10 2019, 3:39 PM
martinvonz closed D6598: tests: split out tests for unrelated copy source/target into separate file.
Jul 10 2019, 3:38 PM
martinvonz committed rHG67bf11597eb8: tests: split out tests for unrelated copy source/target into separate file.
tests: split out tests for unrelated copy source/target into separate file
Jul 10 2019, 3:38 PM
martinvonz updated the diff for D6623: py3: store _origdoc as str.
Jul 10 2019, 12:39 PM
martinvonz added inline comments to D6623: py3: store _origdoc as str.
Jul 10 2019, 12:32 PM

Jul 9 2019

martinvonz created D6623: py3: store _origdoc as str.
Jul 9 2019, 3:16 AM

Jul 8 2019

martinvonz closed D6614: py3: don't run source transformer on hgext3rd (extensions).
Jul 8 2019, 6:04 PM
martinvonz committed rHGd28d91f9f35a: py3: don't run source transformer on hgext3rd (extensions).
py3: don't run source transformer on hgext3rd (extensions)
Jul 8 2019, 6:04 PM