When this patch is ready, could we fold this into a11fd395e83f? I have extensions.perf=contrib/perf.py in my config and it's pretty annoying to have any commit in the broken range checked out.

In D6741#99030, @durin42 wrote:

In D6741#99023, @pulkit wrote:

In D6741#98947, @martinvonz wrote:

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help with future patches? Or you just like this structure better?

Looking through Augie's hgit patch, I found we need to add more interfaces and decided to work on adding for store.basicstore. I found all the current interfaces in repository.py which has grown very large. I decided to create a new file to have interface for the store class, and maybe a new one for dirstate too, and having them in a separate folder dedicated to interfaces will be nice.

I'm inclined to agree - the repository.py file full of interfaces has gotten crufty. It'd be nice to split it out into more files by topic.

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

I just found a comment I wrote a while ago and forgot to submit. Sorry.

In D6670#97968, @yuja wrote:

Might be better to rename next to 5.1, and recreate new next file.
The old next file in stable branch could theoretically be edited and
merged back to default.

Intended for stable.

Heh, I wrote a patch for this before I saw yours. The problem is that random.sample() (and other integer-based functions) changed, see https://bugs.python.org/issue27742.

Sorry, but since both Yuya and I are uncomfortable with this patch, I'll de-queue it so it doesn't block other patches from getting queued. I think it would be good if you can fold D6659 into this one and then split it up so have only the refactoring in a first patch and the new support for continue in a second patch. Thanks.

In D6655#97447, @taapas1128 wrote:

@martinvonz I will send a patch doing that.

There is a lot of duplication here. Can you try to extract common parts?

In D6612#97313, @durin42 wrote:

(Martin, this looks fine to me, if you've got no objections let's include it in 5.1)

In D6641#97205, @yuja wrote:

• a/mercurial/__init__.py

+++ b/mercurial/__init__.py
@@ -225,7 +225,9 @@

• 1. It changes iteritems/values to items/values as they are not
  2. present in Python 3 world.
• elif fn in ('iteritems', 'itervalues'):

+ elif (fn in ('iteritems', 'itervalues') and
+ not (tokens[i - 1].type == token.NAME and
+ tokens[i - 1].string == 'def')):

Perhaps, we need to bump the BYTECODEHEADER version to recompile all
py3 modules.