In D5801#87300, @mharbison72 wrote:

In D5801#87296, @martinvonz wrote:

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

The \r is how output normally is on Windows. The test harness accounts for this when matching lines, but displays the actual output (with \r) when there are differences. The eol extension isn’t configured on this machine, but the custom HGRCPATH content from the test harness would override that anyway.

In D5801#87273, @mharbison72 wrote:

For some reason, this breaks test-contrib-perf.t:

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

I also tried setting True and False in ui.relative-paths, to no effect. Any ideas?

In D5898#87275, @mharbison72 wrote:

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

Looks like there's plenty of space there to show the full username. I suspect it was the way it was because it came from FB where just the username is enough to identify people.

In D5936#86976, @martinvonz wrote:

Ironic given the subject line that I missed this hunk:

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -256,7 +256,7 @@ def addremove(ui, repo, *pats, **opts):
         opts['similarity'] = '100'
     matcher = scmutil.match(repo[None], pats, opts)
     relative = scmutil.anypats(pats, opts)
-    uipathfn = scmutil.getuipathfn(repo, forcerelativevalue=relative)
+    uipathfn = scmutil.getuipathfn(repo, legacyrelativevalue=relative)
     return scmutil.addremove(repo, matcher, "", uipathfn, opts)
 
 @command('annotate|blame',

I'll fold that in in flight since the commit is not yet public.

Ironic given the subject line that I missed this hunk:

In D5949#86909, @martinvonz wrote:

In D5949#86908, @JordiGH wrote:

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

Often fixed in n flight. I'll still fix it later tonight if I remember.

In D5949#86908, @JordiGH wrote:

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

In D5949#86905, @JordiGH wrote:

fix typo in synpsis
in synpsis
synpsis

https://en.wikipedia.org/wiki/Muphry%27s_law

In D5907#86706, @yuja wrote:

`getuipathfn()` uses `repo.pathto()` when a relative path was requested (including by setting `legacyrelativevalue=True` or `forcerelativevalue=True`), so I think there shouldn't be much change in behavior with that commit.

But the default of hg status is relative=False, so the status output
would have significant change on Windows.

In D5907#86625, @yuja wrote:

> It might
>  break some Windows tests, but it should already be broken since https://phab.mercurial-scm.org/rHGa997163e7fae2fe933f8d0c6d1013205befd1ee4.
>  Some (or all?) `uipathfn()`s have to respect `ui.slash` config on Windows.

Did that commit change any behavior on Windows?

Probably. pathto(f, cwd='') would return backslash path on Windows.