With a commands.push.check-dirty (or something similar) that control the default value/behavior of this flag.

Queued, thanks!

In D11669#179232, @durin42 wrote:

In D11669#179228, @martinvonz wrote:

In D11669#179227, @durin42 wrote:

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Could I get a follow-up of some kind that prints some advice for users about this in all cases? It seems like even if we don't change the default, we should just tell people. Maybe in plain-text histedit too, but I worry less about that since curses gets more mindshare.

In D11669#179227, @durin42 wrote:

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

In D11627#179224, @Alphare wrote:

In D11627#179220, @martinvonz wrote:

In D11627#179096, @Alphare wrote:

This breaks CI on Python 2: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254041
We unfortunately have to support Python 2 until the release in a few days, so this should get fixed.

It doesn't reproduce for me. Does it for you? I wonder what I need to do to make it reproduce. I have /dev/full.

It does, I'm on Linux if somehow this is OS specific.

$ HGMODULEPOLICY=py python2 ./tests/run-tests.py -j6 tests/test-basic.t
running 1 tests using 1 parallel processes
--- /home/alphare/workspace/octobus/mercurial-devel/tests/test-basic.t
+++ /home/alphare/workspace/octobus/mercurial-devel/tests/test-basic.t.err
@@ -40,13 +40,10 @@
   A a
   $ hg status >/dev/full
-  abort: No space left on device
-  [255]
 #endif
 #if devfull
   $ hg status >/dev/full 2>&1
-  [255]
   $ hg status ENOENT 2>/dev/full
   [255]
ERROR: test-basic.t output changed
!
Failed test-basic.t: output changed
# Ran 1 tests, 0 skipped, 1 failed.
python hash seed: 454035856

In D11627#179096, @Alphare wrote:

This breaks CI on Python 2: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254041
We unfortunately have to support Python 2 until the release in a few days, so this should get fixed.

In D11670#178934, @aalekseyev wrote:

@martinvonz, indeed, thanks. Sorry.

@aalekseyev, I think you'll want to run rustup install nightly-2020-10-04 to make sure that test-check-format-test.t runs.

Do you want to also update the rustfmt version used by test-check-format-rust.t?

This was already sent in D11658

In D11616#178600, @martinvonz wrote:

In D11616#178599, @aalekseyev wrote:

I'm getting ~630ms on **/moz.build when I run the original version (1b0f8aafedea), by the way. Could it be that your ~650ms measurement corresponds to that?

Yeah, it's very possible I messed up my measurements somehow. I'll check again tomorrow, then I'll probably queue your version.

In D11616#178599, @aalekseyev wrote:

I'm getting ~630ms on **/moz.build when I run the original version (1b0f8aafedea), by the way. Could it be that your ~650ms measurement corresponds to that?

In D11650#178587, @aalekseyev wrote:

In D11650#178580, @aalekseyev wrote:

I'll do that.

Submitted: https://phab.mercurial-scm.org/D11656
Is that alright, or do you prefer me amend the original commit? (will I be able to phabsend it though?)

I changed this one's parent to be D11623 since D11624 was abandoned. I hope that's how you meant it to be.

In D11624#178221, @SimonSapin wrote:

Resubmitted as D11629 because phabsend errors with abort: Conduit Error (ERR-CONDUIT-CORE): Graph cycle detected when swapping the order of two existing patches.