In D8854#132358, @indygreg wrote:OMG. When I reviewed this, I thought your assertion that resources.open_binary('mercurial.templates', 'coal/map') is not valid was wrong because the low-level resource reader on the meta path importer does allow relative paths! However, it appears that the open_binary() helper functions limit this! This is yet another example of wonky behavior in these resources APIs. FWIW I've brought many of these to the attention of the core Python people at https://bugs.python.org/issue36128 and https://gitlab.com/python-devs/importlib_resources/-/issues/58 (and a few other places that I can't find the links to).
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Today
Today
Yesterday
Yesterday
martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Mon, Aug 3
Mon, Aug 3
martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Sun, Aug 2
Sun, Aug 2
packaging: delete unnecessary updating of `dirs` list
packaging: make "mercurial.defaultrc" a key in package_data
packaging: delete unnecessary updating of `dirs` list
packaging: make "mercurial.defaultrc" a key in package_data
templatespec: use new factory functions in hooklib
templatespec: use new factory functions in logcmdutil
martinvonz committed rHG215f08c8006c: templatespec: move check for non-unicode to lower-level function.
templatespec: move check for non-unicode to lower-level function
martinvonz committed rHGdfb67cd1da7f: templatespec: logcmdutil.templatespec() gets either template or mapfile.
templatespec: logcmdutil.templatespec() gets either template or mapfile
martinvonz committed rHG8cce9f77ca73: templatespec: create a factory function for each type there is.
templatespec: create a factory function for each type there is
templater: stop accepting a single style to stylemap()
martinvonz committed rHG22eafb16f1c5: formatter: inline a variable assigned from `templater.templater.frommapfile`.
formatter: inline a variable assigned from `templater.templater.frommapfile`
martinvonz committed rHG28840ef52f71: templater: don't normalize path separators to '/' when interacting with OS.
templater: don't normalize path separators to '/' when interacting with OS
formatter: remove now-unnecessary check for file-ness
templater: make templatepath() not return directory paths
tests: show unusual error message for `hg log --style coal`
martinvonz committed rHG668af67bfd18: config: remove now-unused `abs` argument from `include` callback.
config: remove now-unused `abs` argument from `include` callback
martinvonz committed rHG83ca8d6f3206: config: re-calculate absolute %include path in `include` callback.
config: re-calculate absolute %include path in `include` callback
martinvonz committed rHG0323972f78f3: subrepoutil: use relative path for looking up config `%include`s.
subrepoutil: use relative path for looking up config `%include`s
martinvonz added a reverted change for rHG3f54242781e9: config: remove now-unused support for "includepaths": rHG081b08e4ea13: templater: look for mapfiles in template paths.
config: remove now-unused support for "includepaths"
Fri, Jul 31
Fri, Jul 31
martinvonz added inline comments to D8772: localrepo: abort creating a shared repo if the source does not have store.
martinvonz added inline comments to D8771: localrepo: only use 'bookmarksinstore' requirement if we have 'store'.
martinvonz added a comment to D8771: localrepo: only use 'bookmarksinstore' requirement if we have 'store'.
The commit message was hard to read.
martinvonz retitled D8848: templatespec: use new factory functions in logcmdutil from templatespec: use new factory functions from logcmdutil to templatespec: use new factory functions in logcmdutil.
cleanup: fix bad formatting of state.py from D8811
Thu, Jul 30
Thu, Jul 30
D8849: dirstate: revert change to Rust binding now requires changes to proceed.
The commit message is missing the "why" (which is fine if that's obvious, but it doesn't seem obvious to me here). It's also unclear how this is changing a Rust binding. Are you saying that fp is an object defined in Rust?
Wed, Jul 29
Wed, Jul 29
martinvonz added inline comments to D8845: templatespec: create a factory function for each type there is.
martinvonz updated the diff for D8806: templater: don't normalize path separators to '/' when interacting with OS.
martinvonz added a comment to D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".
I may instead make the function return a resource. We'll see.
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Tue, Jul 28
Tue, Jul 28
relnotes: copy "next" to "5.5" and clear "next"
martinvonz updated the diff for D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".
martinvonz updated the diff for D8806: templater: don't normalize path separators to '/' when interacting with OS.
martinvonz updated the diff for D8796: config: remove now-unused `abs` argument from `include` callback.
martinvonz added a comment to D8840: rename: add support for --at-rev, which marks as copy and removes the source.
I didn't include release notes in this patch because D8839 needs to get in first. If that lands quickly and gets merged to default, I'll update this patch. Otherwise I'll just send a follow-up later.
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Mon, Jul 27
Mon, Jul 27
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Sat, Jul 25
Sat, Jul 25
martinvonz committed rHGf512708a9ea8: tests: add tests trying to use dir as style, as %include, and as __base__.
tests: add tests trying to use dir as style, as %include, and as __base__
tests: fix mistaken copy&paste from commit 4489e9a22763
martinvonz committed rHG3ea3b85df03f: fix: update documentation to reflect preference for --source over --rev.
fix: update documentation to reflect preference for --source over --rev
templater: handle None returned from templatedir()
Fri, Jul 24
Fri, Jul 24