Feed Advanced Search

Today

martinvonz added a reviewer for D5981: tests: drop a few unnecessary "(glob)": mharbison72.
Mon, Feb 18, 12:24 AM
martinvonz created D5981: tests: drop a few unnecessary "(glob)".
Mon, Feb 18, 12:24 AM

Yesterday

martinvonz added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

The \r is how output normally is on Windows. The test harness accounts for this when matching lines, but displays the actual output (with \r) when there are differences. The eol extension isn’t configured on this machine, but the custom HGRCPATH content from the test harness would override that anyway.

Sun, Feb 17, 5:21 PM
martinvonz added a comment to D5801: files: respect ui.relative-paths.

For some reason, this breaks test-contrib-perf.t:

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

I also tried setting True and False in ui.relative-paths, to no effect. Any ideas?

Sun, Feb 17, 12:29 PM
martinvonz created D5978: subrepo: use root-repo-relative path from `hg files` with ui.relative-paths=no.
Sun, Feb 17, 12:18 PM
martinvonz created D5977: subrepo: demonstrate broken `hg files` with ui.relative-paths=no.
Sun, Feb 17, 12:17 PM
martinvonz added a dependent revision for D5977: subrepo: demonstrate broken `hg files` with ui.relative-paths=no: D5978: subrepo: use root-repo-relative path from `hg files` with ui.relative-paths=no.
Sun, Feb 17, 12:17 PM
martinvonz added a comment to D5898: debugignore: respect ui.relative-paths.

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

Sun, Feb 17, 1:03 AM

Fri, Feb 15

martinvonz added inline comments to D5969: uncommit: inform user if the commit is empty after uncommit.
Fri, Feb 15, 4:17 PM
martinvonz added inline comments to D5969: uncommit: inform user if the commit is empty after uncommit.
Fri, Feb 15, 3:31 PM
martinvonz added inline comments to D5969: uncommit: inform user if the commit is empty after uncommit.
Fri, Feb 15, 3:20 PM
martinvonz updated the diff for D5970: uncommit: add config option to keep commit by default.
Fri, Feb 15, 3:20 PM
martinvonz updated the diff for D5969: uncommit: inform user if the commit is empty after uncommit.
Fri, Feb 15, 3:20 PM
martinvonz added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 2:15 PM
martinvonz created D5970: uncommit: add config option to keep commit by default.
Fri, Feb 15, 2:13 PM
martinvonz created D5969: uncommit: inform user if the commit is empty after uncommit.
Fri, Feb 15, 2:12 PM
martinvonz added a dependent revision for D5969: uncommit: inform user if the commit is empty after uncommit: D5970: uncommit: add config option to keep commit by default.
Fri, Feb 15, 2:12 PM
martinvonz added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 12:36 PM
martinvonz added inline comments to D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977).
Fri, Feb 15, 11:01 AM

Thu, Feb 14

martinvonz accepted D5967: chistedit: improve proper username in histedit curses interface in changeset section (issue6072).

Looks like there's plenty of space there to show the full username. I suspect it was the way it was because it came from FB where just the username is enough to identify people.

Thu, Feb 14, 4:22 PM
martinvonz committed rHGe21183db2259: scmutil: fix a comment that doesn't match the code.
scmutil: fix a comment that doesn't match the code
Thu, Feb 14, 4:17 PM
martinvonz closed D5956: scmutil: fix a comment that doesn't match the code.
Thu, Feb 14, 8:24 AM
martinvonz committed rHG879495c68e31: scmutil: fix a comment that doesn't match the code.
scmutil: fix a comment that doesn't match the code
Thu, Feb 14, 8:23 AM

Wed, Feb 13

martinvonz created D5956: scmutil: fix a comment that doesn't match the code.
Wed, Feb 13, 3:10 PM
martinvonz committed rHG09814946cc6a: debugpathcopies: fix typo in synopsis.
debugpathcopies: fix typo in synopsis
Wed, Feb 13, 2:22 PM
martinvonz committed rHGea72da71ad69: debugrename: don't require at least one path.
debugrename: don't require at least one path
Wed, Feb 13, 2:22 PM
martinvonz committed rHGec7bba81ebf4: commit: respect ui.relative-paths.
commit: respect ui.relative-paths
Wed, Feb 13, 2:22 PM
martinvonz committed rHG935e06e95b91: resolve: respect ui.relative-paths also for warning messages.
resolve: respect ui.relative-paths also for warning messages
Wed, Feb 13, 2:22 PM
martinvonz committed rHGfee1a4935c27: resolve: slightly simplify join expression by joining with empty strings.
resolve: slightly simplify join expression by joining with empty strings
Wed, Feb 13, 2:22 PM
martinvonz committed rHGb81ecf3571d5: addremove: respect ui.relative-paths.
addremove: respect ui.relative-paths
Wed, Feb 13, 2:22 PM
martinvonz added a comment to D5936: addremove: respect ui.relative-paths.

Ironic given the subject line that I missed this hunk:

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -256,7 +256,7 @@ def addremove(ui, repo, *pats, **opts):
         opts['similarity'] = '100'
     matcher = scmutil.match(repo[None], pats, opts)
     relative = scmutil.anypats(pats, opts)
-    uipathfn = scmutil.getuipathfn(repo, forcerelativevalue=relative)
+    uipathfn = scmutil.getuipathfn(repo, legacyrelativevalue=relative)
     return scmutil.addremove(repo, matcher, "", uipathfn, opts)
 
 @command('annotate|blame',

I'll fold that in in flight since the commit is not yet public.

Wed, Feb 13, 1:51 PM
martinvonz added a comment to D5936: addremove: respect ui.relative-paths.

Ironic given the subject line that I missed this hunk:

Wed, Feb 13, 1:43 PM
martinvonz closed D5949: debugpathcopies: fix typo in synopsis.
Wed, Feb 13, 7:51 AM
martinvonz committed rHGb738093d4b8f: debugpathcopies: fix typo in synopsis.
debugpathcopies: fix typo in synopsis
Wed, Feb 13, 7:51 AM
martinvonz closed D5948: debugrename: don't require at least one path.
Wed, Feb 13, 7:51 AM
martinvonz committed rHGa04e0ec65ce3: debugrename: don't require at least one path.
debugrename: don't require at least one path
Wed, Feb 13, 7:50 AM
martinvonz closed D5936: addremove: respect ui.relative-paths.
Wed, Feb 13, 7:16 AM
martinvonz closed D5938: resolve: slightly simplify join expression by joining with empty strings.
Wed, Feb 13, 7:16 AM
martinvonz closed D5937: resolve: respect ui.relative-paths also for warning messages.
Wed, Feb 13, 7:16 AM
martinvonz committed rHGc31dd7b63ab3: resolve: slightly simplify join expression by joining with empty strings.
resolve: slightly simplify join expression by joining with empty strings
Wed, Feb 13, 7:16 AM
martinvonz committed rHG8fc63f5fb50d: commit: respect ui.relative-paths.
commit: respect ui.relative-paths
Wed, Feb 13, 7:16 AM
martinvonz closed D5939: commit: respect ui.relative-paths.
Wed, Feb 13, 7:16 AM
martinvonz committed rHGdf3c24966e4b: resolve: respect ui.relative-paths also for warning messages.
resolve: respect ui.relative-paths also for warning messages
Wed, Feb 13, 7:15 AM
martinvonz closed D5935: windows: use util.localpath for repo-relative paths in getuipathfn().
Wed, Feb 13, 7:15 AM
martinvonz committed rHGf44ab808eb91: addremove: respect ui.relative-paths.
addremove: respect ui.relative-paths
Wed, Feb 13, 7:15 AM
martinvonz committed rHGa8d3a4be066e: windows: use util.localpath for repo-relative paths in getuipathfn().
windows: use util.localpath for repo-relative paths in getuipathfn()
Wed, Feb 13, 7:15 AM
martinvonz retitled D5949: debugpathcopies: fix typo in synopsis from debugpathcopies: fix typo in synpsis to debugpathcopies: fix typo in synopsis.
Wed, Feb 13, 12:17 AM

Tue, Feb 12

martinvonz added a comment to D5949: debugpathcopies: fix typo in synopsis.

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

Often fixed in n flight. I'll still fix it later tonight if I remember.

Tue, Feb 12, 10:52 PM
martinvonz added a comment to D5949: debugpathcopies: fix typo in synopsis.

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

Tue, Feb 12, 10:49 PM
martinvonz added a comment to D5949: debugpathcopies: fix typo in synopsis.

fix typo in synpsis
in synpsis
synpsis

https://en.wikipedia.org/wiki/Muphry%27s_law

Tue, Feb 12, 10:42 PM
martinvonz created D5949: debugpathcopies: fix typo in synopsis.
Tue, Feb 12, 4:47 PM
martinvonz created D5948: debugrename: don't require at least one path.
Tue, Feb 12, 4:47 PM
martinvonz added a dependent revision for D5948: debugrename: don't require at least one path: D5949: debugpathcopies: fix typo in synopsis.
Tue, Feb 12, 4:47 PM

Mon, Feb 11

martinvonz created D5936: addremove: respect ui.relative-paths.
Mon, Feb 11, 12:52 PM
martinvonz created D5938: resolve: slightly simplify join expression by joining with empty strings.
Mon, Feb 11, 12:51 PM
martinvonz created D5937: resolve: respect ui.relative-paths also for warning messages.
Mon, Feb 11, 12:51 PM
martinvonz created D5939: commit: respect ui.relative-paths.
Mon, Feb 11, 12:51 PM
martinvonz added a dependent revision for D5938: resolve: slightly simplify join expression by joining with empty strings: D5939: commit: respect ui.relative-paths.
Mon, Feb 11, 12:50 PM
martinvonz created D5935: windows: use util.localpath for repo-relative paths in getuipathfn().
Mon, Feb 11, 12:50 PM
martinvonz added a dependent revision for D5937: resolve: respect ui.relative-paths also for warning messages: D5938: resolve: slightly simplify join expression by joining with empty strings.
Mon, Feb 11, 12:50 PM
martinvonz added a dependent revision for D5936: addremove: respect ui.relative-paths: D5937: resolve: respect ui.relative-paths also for warning messages.
Mon, Feb 11, 12:50 PM
martinvonz added a dependent revision for D5935: windows: use util.localpath for repo-relative paths in getuipathfn(): D5936: addremove: respect ui.relative-paths.
Mon, Feb 11, 12:50 PM
martinvonz added a comment to D5907: copy: respect ui.relative-paths in copy/rename.
In D5907#86706, @yuja wrote:
`getuipathfn()` uses `repo.pathto()` when a relative path was requested (including by setting `legacyrelativevalue=True` or `forcerelativevalue=True`), so I think there shouldn't be much change in behavior with that commit.

But the default of hg status is relative=False, so the status output
would have significant change on Windows.

Mon, Feb 11, 11:43 AM
martinvonz closed D5930: match: delete unused root and cwd arguments from {always,never,exact}() (API).
Mon, Feb 11, 8:56 AM
martinvonz closed D5929: match: delete unused root and cwd arguments to constructors (API).
Mon, Feb 11, 8:55 AM
martinvonz committed rHG0531dff73d0b: match: delete unused root and cwd arguments from {always,never,exact}() (API).
match: delete unused root and cwd arguments from {always,never,exact}() (API)
Mon, Feb 11, 8:54 AM
martinvonz committed rHGddbebce94665: match: delete unused root and cwd arguments to constructors (API).
match: delete unused root and cwd arguments to constructors (API)
Mon, Feb 11, 8:54 AM
martinvonz closed D5928: dirstate: call and cache os.getcwd() in constructor.
Mon, Feb 11, 8:54 AM
martinvonz committed rHGe178b131906a: dirstate: call and cache os.getcwd() in constructor.
dirstate: call and cache os.getcwd() in constructor
Mon, Feb 11, 8:54 AM
martinvonz closed D5927: cleanup: prefer matchmod.{always,never}() over accessing matchers directly.
Mon, Feb 11, 7:00 AM
martinvonz committed rHG1db5ae4b0dda: cleanup: prefer matchmod.{always,never}() over accessing matchers directly.
cleanup: prefer matchmod.{always,never}() over accessing matchers directly
Mon, Feb 11, 7:00 AM
martinvonz committed rHGc302218a2528: match: allow passing in badfn to always() and never().
match: allow passing in badfn to always() and never()
Mon, Feb 11, 7:00 AM
martinvonz closed D5926: match: allow passing in badfn to always() and never().
Mon, Feb 11, 7:00 AM
martinvonz created D5930: match: delete unused root and cwd arguments from {always,never,exact}() (API).
Mon, Feb 11, 12:54 AM
martinvonz created D5929: match: delete unused root and cwd arguments to constructors (API).
Mon, Feb 11, 12:53 AM
martinvonz created D5927: cleanup: prefer matchmod.{always,never}() over accessing matchers directly.
Mon, Feb 11, 12:52 AM
martinvonz added a dependent revision for D5929: match: delete unused root and cwd arguments to constructors (API): D5930: match: delete unused root and cwd arguments from {always,never,exact}() (API).
Mon, Feb 11, 12:52 AM
martinvonz created D5928: dirstate: call and cache os.getcwd() in constructor.
Mon, Feb 11, 12:52 AM
martinvonz added a dependent revision for D5928: dirstate: call and cache os.getcwd() in constructor: D5929: match: delete unused root and cwd arguments to constructors (API).
Mon, Feb 11, 12:52 AM
martinvonz added a dependent revision for D5927: cleanup: prefer matchmod.{always,never}() over accessing matchers directly: D5928: dirstate: call and cache os.getcwd() in constructor.
Mon, Feb 11, 12:52 AM
martinvonz created D5926: match: allow passing in badfn to always() and never().
Mon, Feb 11, 12:52 AM
martinvonz added a dependent revision for D5926: match: allow passing in badfn to always() and never(): D5927: cleanup: prefer matchmod.{always,never}() over accessing matchers directly.
Mon, Feb 11, 12:52 AM
martinvonz added a comment to D5907: copy: respect ui.relative-paths in copy/rename.
In D5907#86625, @yuja wrote:
> It might
>  break some Windows tests, but it should already be broken since https://phab.mercurial-scm.org/rHGa997163e7fae2fe933f8d0c6d1013205befd1ee4.
>  Some (or all?) `uipathfn()`s have to respect `ui.slash` config on Windows.

Did that commit change any behavior on Windows?

Probably. pathto(f, cwd='') would return backslash path on Windows.

Mon, Feb 11, 12:25 AM

Sun, Feb 10

martinvonz closed D5896: diff: make --stat respect ui.relative-paths.
Sun, Feb 10, 8:59 PM
martinvonz closed D5924: match: delete unused argument "listsubrepos" from _buildmatch().
Sun, Feb 10, 8:59 PM
martinvonz committed rHGdb69a763bc89: diff: make --stat respect ui.relative-paths.
diff: make --stat respect ui.relative-paths
Sun, Feb 10, 8:59 PM
martinvonz committed rHGa13268524c25: match: delete unused argument "listsubrepos" from _buildmatch().
match: delete unused argument "listsubrepos" from _buildmatch()
Sun, Feb 10, 8:59 PM
martinvonz closed D5923: match: delete unused rel() (API).
Sun, Feb 10, 8:59 PM
martinvonz closed D5922: largefiles: get cwd and relative paths from repo instead of matcher.
Sun, Feb 10, 8:59 PM
martinvonz committed rHGc4f023b656cf: match: delete unused rel() (API).
match: delete unused rel() (API)
Sun, Feb 10, 8:59 PM
martinvonz closed D5921: scmutil: remove special handling of pats==("",) in matchandpats() (API).
Sun, Feb 10, 8:59 PM
martinvonz committed rHG8fa1a5fb8a28: largefiles: get cwd and relative paths from repo instead of matcher.
largefiles: get cwd and relative paths from repo instead of matcher
Sun, Feb 10, 8:59 PM
martinvonz committed rHGa950b65cbe1b: scmutil: remove special handling of pats==("",) in matchandpats() (API).
scmutil: remove special handling of pats==("",) in matchandpats() (API)
Sun, Feb 10, 8:59 PM
martinvonz added a dependent revision for D5923: match: delete unused rel() (API): D5924: match: delete unused argument "listsubrepos" from _buildmatch().
Sun, Feb 10, 3:00 AM
martinvonz added a dependency for D5924: match: delete unused argument "listsubrepos" from _buildmatch(): D5923: match: delete unused rel() (API).
Sun, Feb 10, 3:00 AM
martinvonz created D5924: match: delete unused argument "listsubrepos" from _buildmatch().
Sun, Feb 10, 2:59 AM
martinvonz added a dependency for D5921: scmutil: remove special handling of pats==("",) in matchandpats() (API): D5896: diff: make --stat respect ui.relative-paths.
Sun, Feb 10, 1:19 AM
martinvonz added a dependent revision for D5896: diff: make --stat respect ui.relative-paths: D5921: scmutil: remove special handling of pats==("",) in matchandpats() (API).
Sun, Feb 10, 1:19 AM
martinvonz created D5923: match: delete unused rel() (API).
Sun, Feb 10, 1:19 AM
martinvonz created D5922: largefiles: get cwd and relative paths from repo instead of matcher.
Sun, Feb 10, 1:19 AM