Page MenuHomePhabricator
Feed Advanced Search

Yesterday

martinvonz created D6570: rebase: fix in-memory rebasing of copy of empty file.
Mon, Jun 24, 7:11 PM
martinvonz created D6569: tests: demonstrate broken in-memory rebase of copy to empty file.
Mon, Jun 24, 7:11 PM
martinvonz closed D6561: copies: simplify merging of copy dicts on merge commits.
Mon, Jun 24, 3:00 PM
martinvonz closed D6560: copies: remove a redundant matcher filtering in _changesetforwardcopies().
Mon, Jun 24, 2:59 PM
martinvonz committed rHG907cef396635: copies: simplify merging of copy dicts on merge commits.
copies: simplify merging of copy dicts on merge commits
Mon, Jun 24, 2:59 PM
martinvonz committed rHGc7104896ec42: copies: remove a redundant matcher filtering in _changesetforwardcopies().
copies: remove a redundant matcher filtering in _changesetforwardcopies()
Mon, Jun 24, 2:59 PM
martinvonz closed D6559: copies: delete obsolete comment in _changesetforwardcopies().
Mon, Jun 24, 2:59 PM
martinvonz committed rHG8f9cfc8d2ae1: copies: delete obsolete comment in _changesetforwardcopies().
copies: delete obsolete comment in _changesetforwardcopies()
Mon, Jun 24, 2:59 PM

Sun, Jun 23

martinvonz added inline comments to D6503: statecheck: added support for STATES.
Sun, Jun 23, 5:46 PM
martinvonz added inline comments to D6484: states: moved cmdutil.unfinishedstates to state.py.
Sun, Jun 23, 5:36 PM
martinvonz added a comment to D6566: abort: first prototype of hg abort.

Need to set the parent of this patch

Sun, Jun 23, 5:29 PM

Sat, Jun 22

martinvonz closed D6564: copies: avoid reusing the same variable for two different copy dicts.
Sat, Jun 22, 10:26 AM
martinvonz committed rHGe7c55e24d6bf: copies: avoid reusing the same variable for two different copy dicts.
copies: avoid reusing the same variable for two different copy dicts
Sat, Jun 22, 10:26 AM
martinvonz committed rHG15f04d652b62: drawdag: don't crash when writing copy info to changesets.
drawdag: don't crash when writing copy info to changesets
Sat, Jun 22, 10:25 AM
martinvonz closed D6565: drawdag: don't crash when writing copy info to changesets.
Sat, Jun 22, 10:25 AM
martinvonz committed rHG84aff7e20c55: merge with stable.
merge with stable
Sat, Jun 22, 2:41 AM

Fri, Jun 21

martinvonz created D6565: drawdag: don't crash when writing copy info to changesets.
Fri, Jun 21, 1:01 PM

Thu, Jun 20

martinvonz created D6564: copies: avoid reusing the same variable for two different copy dicts.
Thu, Jun 20, 7:15 PM
martinvonz created D6560: copies: remove a redundant matcher filtering in _changesetforwardcopies().
Thu, Jun 20, 5:09 PM
martinvonz created D6561: copies: simplify merging of copy dicts on merge commits.
Thu, Jun 20, 5:09 PM
martinvonz created D6559: copies: delete obsolete comment in _changesetforwardcopies().
Thu, Jun 20, 5:09 PM
martinvonz added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Thu, Jun 20, 2:25 AM

Wed, Jun 19

D6503: statecheck: added support for STATES is now accepted and ready to land.
Wed, Jun 19, 6:33 PM
martinvonz closed D6546: log: pass getcopies() function instead of getrenamed() to displayer (API).
Wed, Jun 19, 5:56 PM
martinvonz closed D6545: copies: create helper for getting all copies for changeset.
Wed, Jun 19, 5:56 PM
martinvonz closed D6544: logcmdutil: also check for copies in null revision and working copy.
Wed, Jun 19, 5:55 PM
martinvonz committed rHGa68350a7fc55: log: pass getcopies() function instead of getrenamed() to displayer (API).
log: pass getcopies() function instead of getrenamed() to displayer (API)
Wed, Jun 19, 5:55 PM
martinvonz committed rHG88ba0ff94605: copies: create helper for getting all copies for changeset.
copies: create helper for getting all copies for changeset
Wed, Jun 19, 5:55 PM
martinvonz closed D6543: tests: demonstrate missing copy information in working copy with graphlog.
Wed, Jun 19, 5:55 PM
martinvonz committed rHGc929f612afac: logcmdutil: also check for copies in null revision and working copy.
logcmdutil: also check for copies in null revision and working copy
Wed, Jun 19, 5:55 PM
martinvonz closed D6542: remotefilelog: handle copies in changesets in getrenamedfn() override.
Wed, Jun 19, 5:55 PM
martinvonz committed rHG75334e5b519e: tests: demonstrate missing copy information in working copy with graphlog.
tests: demonstrate missing copy information in working copy with graphlog
Wed, Jun 19, 5:55 PM
martinvonz committed rHGe387cb22f6c0: remotefilelog: handle copies in changesets in getrenamedfn() override.
remotefilelog: handle copies in changesets in getrenamedfn() override
Wed, Jun 19, 5:55 PM
martinvonz closed D6541: remotefilelog: check if RFL is enabled in getrenamedfn() override.
Wed, Jun 19, 5:55 PM
martinvonz committed rHGf93762f251d2: remotefilelog: check if RFL is enabled in getrenamedfn() override.
remotefilelog: check if RFL is enabled in getrenamedfn() override
Wed, Jun 19, 5:55 PM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Wed, Jun 19, 2:52 PM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Wed, Jun 19, 2:43 PM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Wed, Jun 19, 2:37 PM
martinvonz created D6546: log: pass getcopies() function instead of getrenamed() to displayer (API).
Wed, Jun 19, 2:32 PM
martinvonz created D6545: copies: create helper for getting all copies for changeset.
Wed, Jun 19, 2:32 PM
martinvonz created D6544: logcmdutil: also check for copies in null revision and working copy.
Wed, Jun 19, 2:32 PM
martinvonz created D6543: tests: demonstrate missing copy information in working copy with graphlog.
Wed, Jun 19, 2:31 PM
martinvonz created D6542: remotefilelog: handle copies in changesets in getrenamedfn() override.
Wed, Jun 19, 2:31 PM
martinvonz created D6541: remotefilelog: check if RFL is enabled in getrenamedfn() override.
Wed, Jun 19, 2:31 PM
martinvonz committed rHG089f14dd7df3: relnotes: document template support for `hg root`.
relnotes: document template support for `hg root`
Wed, Jun 19, 12:44 PM
martinvonz closed D6540: relnotes: document template support for `hg root`.
Wed, Jun 19, 12:44 PM

Tue, Jun 18

martinvonz added inline comments to D6503: statecheck: added support for STATES.
Tue, Jun 18, 4:48 PM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Tue, Jun 18, 12:48 PM
martinvonz created D6540: relnotes: document template support for `hg root`.
Tue, Jun 18, 12:00 PM
martinvonz added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.

Could you also update relnotes/next (documenting either the new flag or config option, whatever this patch ends up doing)?

Tue, Jun 18, 11:50 AM
D6502: state: moved cmdutil.STATES and utilities to state.py is now accepted and ready to land.
Tue, Jun 18, 11:48 AM
martinvonz added a comment to D6501: state: created new class statecheck to handle unfinishedstates.

At some point in this series (probably as a separate patch at the end), you should update relnotes/next to describe the API change and how to register stateful operations

Tue, Jun 18, 11:47 AM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Tue, Jun 18, 11:42 AM
martinvonz added inline comments to D6502: state: moved cmdutil.STATES and utilities to state.py.
Tue, Jun 18, 11:29 AM
D6501: state: created new class statecheck to handle unfinishedstates is now accepted and ready to land.
Tue, Jun 18, 11:27 AM
martinvonz added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Tue, Jun 18, 2:57 AM

Mon, Jun 17

martinvonz closed D6536: strip: move checksubstate() to mq (its only caller).
Mon, Jun 17, 6:40 PM
martinvonz closed D6533: mq: remove dependency on strip's checklocalchanges().
Mon, Jun 17, 6:40 PM
martinvonz closed D6535: strip: use bailifchanged() instead of reimplementing it.
Mon, Jun 17, 6:40 PM
martinvonz committed rHG4bcabb5ae9b6: strip: move checksubstate() to mq (its only caller).
strip: move checksubstate() to mq (its only caller)
Mon, Jun 17, 6:40 PM
martinvonz committed rHG1474f5d84662: strip: use bailifchanged() instead of reimplementing it.
strip: use bailifchanged() instead of reimplementing it
Mon, Jun 17, 6:39 PM
martinvonz committed rHG3a1988e915f9: strip: remove unused excsuffix argument from checklocalchanges().
strip: remove unused excsuffix argument from checklocalchanges()
Mon, Jun 17, 6:39 PM
martinvonz closed D6534: strip: remove unused excsuffix argument from checklocalchanges().
Mon, Jun 17, 6:39 PM
martinvonz committed rHGcf445a212b9c: mq: remove dependency on strip's checklocalchanges().
mq: remove dependency on strip's checklocalchanges()
Mon, Jun 17, 6:39 PM
martinvonz created D6536: strip: move checksubstate() to mq (its only caller).
Mon, Jun 17, 2:00 PM
martinvonz created D6533: mq: remove dependency on strip's checklocalchanges().
Mon, Jun 17, 2:00 PM
martinvonz created D6535: strip: use bailifchanged() instead of reimplementing it.
Mon, Jun 17, 2:00 PM
martinvonz created D6534: strip: remove unused excsuffix argument from checklocalchanges().
Mon, Jun 17, 1:59 PM
martinvonz closed D6420: copies: don't filter out copy targets created on other side of merge commit.
Mon, Jun 17, 1:33 PM
martinvonz closed D6422: copies: avoid calling matcher if matcher.always().
Mon, Jun 17, 1:33 PM
martinvonz closed D6421: copies: avoid unnecessary copying of copy dict.
Mon, Jun 17, 1:33 PM
martinvonz committed rHGc0b51449bf6b: copies: avoid calling matcher if matcher.always().
copies: avoid calling matcher if matcher.always()
Mon, Jun 17, 1:33 PM
martinvonz committed rHG5ceb91136ebe: copies: avoid unnecessary copying of copy dict.
copies: avoid unnecessary copying of copy dict
Mon, Jun 17, 1:33 PM
martinvonz committed rHG35d674a3d5db: copies: don't filter out copy targets created on other side of merge commit.
copies: don't filter out copy targets created on other side of merge commit
Mon, Jun 17, 1:33 PM
martinvonz closed D6419: copies: do full filtering at end of _changesetforwardcopies().
Mon, Jun 17, 1:33 PM
martinvonz committed rHG4c39c99d9492: copies: do full filtering at end of _changesetforwardcopies().
copies: do full filtering at end of _changesetforwardcopies()
Mon, Jun 17, 1:33 PM
martinvonz added inline comments to D6503: statecheck: added support for STATES.
Mon, Jun 17, 12:40 PM
martinvonz added a comment to D6501: state: created new class statecheck to handle unfinishedstates.

I was talking about the way in which registrar takes in data. eg: see line 168 of hgweb_mod.py.

Mon, Jun 17, 12:34 PM
martinvonz added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Mon, Jun 17, 11:47 AM
martinvonz added a comment to D6430: rust-discovery: using from Python code.

This example is not a goal in itself,

Mon, Jun 17, 1:04 AM
martinvonz added a comment to D6503: statecheck: added support for STATES.

@martinvonz I haven't changed anything regarding rebase and update on interrupted states hence not added any tests.

Mon, Jun 17, 12:44 AM

Sun, Jun 16

martinvonz added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 16, 4:53 PM

Fri, Jun 14

martinvonz closed D6532: export: don't prefetch *all* files in manifest.
Fri, Jun 14, 7:16 PM
martinvonz committed rHG307f67d4aee3: export: don't prefetch *all* files in manifest.
export: don't prefetch *all* files in manifest
Fri, Jun 14, 7:15 PM
martinvonz closed D6531: remotefilelog: remove obsolete filtering of treemanifest directories.
Fri, Jun 14, 7:15 PM
martinvonz committed rHGd768ca427249: remotefilelog: remove obsolete filtering of treemanifest directories.
remotefilelog: remove obsolete filtering of treemanifest directories
Fri, Jun 14, 7:15 PM
martinvonz created D6532: export: don't prefetch *all* files in manifest.
Fri, Jun 14, 5:27 PM
martinvonz created D6531: remotefilelog: remove obsolete filtering of treemanifest directories.
Fri, Jun 14, 5:27 PM
martinvonz added a comment to D6419: copies: do full filtering at end of _changesetforwardcopies().

Could someone look at the remaining patches in this series? They've been waiting for three weeks or so now.

Fri, Jun 14, 2:27 AM

Wed, Jun 12

martinvonz added a comment to D6503: statecheck: added support for STATES.

@martinvonz I haven't changed anything regarding rebase and update on interrupted states hence not added any tests.

Wed, Jun 12, 2:24 PM
martinvonz added a comment to D6475: merge: fix race that could cause wrong size in dirstate.

Do you need to update the metadata in Phabricator to tell it that D6515 is its new parent?

Wed, Jun 12, 2:07 PM
martinvonz added inline comments to D6475: merge: fix race that could cause wrong size in dirstate.
Wed, Jun 12, 2:05 PM

Tue, Jun 11

martinvonz added a comment to D6503: statecheck: added support for STATES.

Results of tests are shown.

Tue, Jun 11, 12:24 PM

Mon, Jun 10

martinvonz closed D6470: mixedrepostorecache: fix a silly redundant updating of set.
Mon, Jun 10, 10:57 AM
martinvonz committed rHGaae93201f758: mixedrepostorecache: fix a silly redundant updating of set.
mixedrepostorecache: fix a silly redundant updating of set
Mon, Jun 10, 10:57 AM
martinvonz added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Mon, Jun 10, 9:28 AM

Sat, Jun 8

martinvonz added inline comments to D6502: state: moved cmdutil.STATES and utilities to state.py.
Sat, Jun 8, 6:15 PM
martinvonz added a comment to D6487: states: created new class to handle multi-step unfinished states.

Please ignore my latest messages. I had not noticed yet that this was abandoned.

Sat, Jun 8, 6:10 PM
martinvonz requested changes to D6501: state: created new class statecheck to handle unfinishedstates.
Sat, Jun 8, 6:09 PM
martinvonz accepted D6484: states: moved cmdutil.unfinishedstates to state.py.

Thanks for splitting this out! Sorry about being so particular about splitting up the patch. I think it's an important part of writing patches that others will review. Hopefully it wasn't just frustrating and you can also see some benefit with it. The benefit is mostly to reviewers and future code archeologists and not to the author, so it can feel like wasting time. Remember that more people will read the patches than the people writing them (which is just you).

Sat, Jun 8, 5:47 PM