Page MenuHomePhabricator
Feed Advanced Search

Today

martinvonz created D8896: templater: try to read %include in mapfiles from resources.
Wed, Aug 5, 1:10 PM
martinvonz created D8895: templater: unroll loop over mapfile directories.
Wed, Aug 5, 1:10 PM
martinvonz created D8892: templater: replace templatepath() with function that also opens the file.
Wed, Aug 5, 12:27 PM
martinvonz created D8893: templater: pass opened file-like object to templatespec.
Wed, Aug 5, 12:26 PM
martinvonz created D8894: templater: make open_template() read from resources if in frozen binary.
Wed, Aug 5, 12:26 PM
martinvonz created D8891: templater: start passing resource to read from into _readmapfile().
Wed, Aug 5, 12:26 PM
martinvonz created D8890: templater: move stylemap() to hgweb_mod, since that's its only user.
Wed, Aug 5, 12:26 PM

Yesterday

martinvonz created D8874: hgweb: simplify staticfile() now that we always pass it a single directory.
Tue, Aug 4, 3:00 AM
martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Tue, Aug 4, 3:00 AM
martinvonz updated the diff for D8855: packaging: mark mercurial.templates and subdirs as packages.
Tue, Aug 4, 2:59 AM

Mon, Aug 3

martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Mon, Aug 3, 10:18 PM
martinvonz added a comment to D8854: templates: add __init__.py files to templates/ dirs.

OMG. When I reviewed this, I thought your assertion that resources.open_binary('mercurial.templates', 'coal/map') is not valid was wrong because the low-level resource reader on the meta path importer does allow relative paths! However, it appears that the open_binary() helper functions limit this! This is yet another example of wonky behavior in these resources APIs. FWIW I've brought many of these to the attention of the core Python people at https://bugs.python.org/issue36128 and https://gitlab.com/python-devs/importlib_resources/-/issues/58 (and a few other places that I can't find the links to).

Mon, Aug 3, 11:12 AM

Sun, Aug 2

martinvonz committed rHGc8655782ef19: packaging: delete unnecessary updating of `dirs` list.
packaging: delete unnecessary updating of `dirs` list
Sun, Aug 2, 1:42 PM
martinvonz committed rHG8bc9d045005a: packaging: make "mercurial.defaultrc" a key in package_data.
packaging: make "mercurial.defaultrc" a key in package_data
Sun, Aug 2, 1:42 PM
martinvonz closed D8845: templatespec: create a factory function for each type there is.
Sun, Aug 2, 12:35 PM
martinvonz closed D8857: packaging: delete unnecessary updating of `dirs` list.
Sun, Aug 2, 12:34 PM
martinvonz closed D8856: packaging: make "mercurial.defaultrc" a key in package_data.
Sun, Aug 2, 12:34 PM
martinvonz committed rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list.
packaging: delete unnecessary updating of `dirs` list
Sun, Aug 2, 12:34 PM
martinvonz committed rHG967c81d1b465: packaging: make "mercurial.defaultrc" a key in package_data.
packaging: make "mercurial.defaultrc" a key in package_data
Sun, Aug 2, 12:34 PM
martinvonz closed D8847: templatespec: move check for non-unicode to lower-level function.
Sun, Aug 2, 12:34 PM
martinvonz closed D8848: templatespec: use new factory functions in logcmdutil.
Sun, Aug 2, 12:34 PM
martinvonz committed rHG3c2fae87bd5a: templatespec: use new factory functions in hooklib.
templatespec: use new factory functions in hooklib
Sun, Aug 2, 12:34 PM
martinvonz closed D8853: templatespec: use new factory functions in hooklib.
Sun, Aug 2, 12:34 PM
martinvonz committed rHGc1915cfa8080: templatespec: use new factory functions in logcmdutil.
templatespec: use new factory functions in logcmdutil
Sun, Aug 2, 12:34 PM
martinvonz closed D8846: templatespec: logcmdutil.templatespec() gets either template or mapfile.
Sun, Aug 2, 12:34 PM
martinvonz committed rHG215f08c8006c: templatespec: move check for non-unicode to lower-level function.
templatespec: move check for non-unicode to lower-level function
Sun, Aug 2, 12:34 PM
martinvonz committed rHGdfb67cd1da7f: templatespec: logcmdutil.templatespec() gets either template or mapfile.
templatespec: logcmdutil.templatespec() gets either template or mapfile
Sun, Aug 2, 12:34 PM
martinvonz committed rHG8cce9f77ca73: templatespec: create a factory function for each type there is.
templatespec: create a factory function for each type there is
Sun, Aug 2, 12:34 PM
martinvonz closed D8844: templater: stop accepting a single style to stylemap().
Sun, Aug 2, 12:08 PM
martinvonz closed D8806: templater: don't normalize path separators to '/' when interacting with OS.
Sun, Aug 2, 12:08 PM
martinvonz closed D8807: formatter: inline a variable assigned from `templater.templater.frommapfile`.
Sun, Aug 2, 12:08 PM
martinvonz committed rHGb7444cfc2c05: templater: stop accepting a single style to stylemap().
templater: stop accepting a single style to stylemap()
Sun, Aug 2, 12:08 PM
martinvonz closed D8804: templater: make templatepath() not return directory paths.
Sun, Aug 2, 12:08 PM
martinvonz committed rHG22eafb16f1c5: formatter: inline a variable assigned from `templater.templater.frommapfile`.
formatter: inline a variable assigned from `templater.templater.frommapfile`
Sun, Aug 2, 12:08 PM
martinvonz committed rHG28840ef52f71: templater: don't normalize path separators to '/' when interacting with OS.
templater: don't normalize path separators to '/' when interacting with OS
Sun, Aug 2, 12:07 PM
martinvonz closed D8796: config: remove now-unused `abs` argument from `include` callback.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG653b2a439412: formatter: remove now-unnecessary check for file-ness.
formatter: remove now-unnecessary check for file-ness
Sun, Aug 2, 12:07 PM
martinvonz closed D8805: formatter: remove now-unnecessary check for file-ness.
Sun, Aug 2, 12:07 PM
martinvonz closed D8803: tests: show unusual error message for `hg log --style coal`.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG9a308336fe41: templater: make templatepath() not return directory paths.
templater: make templatepath() not return directory paths
Sun, Aug 2, 12:07 PM
martinvonz committed rHG46c8db8d4e03: tests: show unusual error message for `hg log --style coal`.
tests: show unusual error message for `hg log --style coal`
Sun, Aug 2, 12:07 PM
martinvonz closed D8795: config: re-calculate absolute %include path in `include` callback.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG668af67bfd18: config: remove now-unused `abs` argument from `include` callback.
config: remove now-unused `abs` argument from `include` callback
Sun, Aug 2, 12:07 PM
martinvonz closed D8794: subrepoutil: use relative path for looking up config `%include`s.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG83ca8d6f3206: config: re-calculate absolute %include path in `include` callback.
config: re-calculate absolute %include path in `include` callback
Sun, Aug 2, 12:07 PM
martinvonz committed rHG0323972f78f3: subrepoutil: use relative path for looking up config `%include`s.
subrepoutil: use relative path for looking up config `%include`s
Sun, Aug 2, 12:07 PM
martinvonz added a reverted change for rHG3f54242781e9: config: remove now-unused support for "includepaths": rHG081b08e4ea13: templater: look for mapfiles in template paths.
config: remove now-unused support for "includepaths"
Sun, Aug 2, 12:07 PM
martinvonz added a reverting change for rHG081b08e4ea13: templater: look for mapfiles in template paths: rHG3f54242781e9: config: remove now-unused support for "includepaths".
Sun, Aug 2, 12:07 PM
martinvonz closed D8793: config: remove now-unused support for "includepaths".
Sun, Aug 2, 12:07 PM

Fri, Jul 31

martinvonz added inline comments to D8772: localrepo: abort creating a shared repo if the source does not have store.
Fri, Jul 31, 11:44 PM
martinvonz added inline comments to D8771: localrepo: only use 'bookmarksinstore' requirement if we have 'store'.
Fri, Jul 31, 11:42 PM
martinvonz added a comment to D8771: localrepo: only use 'bookmarksinstore' requirement if we have 'store'.

The commit message was hard to read.

Fri, Jul 31, 11:36 PM
martinvonz created D8858: packaging: include templates with their package as key in package_data.
Fri, Jul 31, 7:59 PM
martinvonz created D8857: packaging: delete unnecessary updating of `dirs` list.
Fri, Jul 31, 7:59 PM
martinvonz created D8856: packaging: make "mercurial.defaultrc" a key in package_data.
Fri, Jul 31, 7:59 PM
martinvonz created D8855: packaging: mark mercurial.templates and subdirs as packages.
Fri, Jul 31, 7:59 PM
martinvonz created D8854: templates: add __init__.py files to templates/ dirs.
Fri, Jul 31, 7:59 PM
martinvonz created D8853: templatespec: use new factory functions in hooklib.
Fri, Jul 31, 7:59 PM
martinvonz retitled D8848: templatespec: use new factory functions in logcmdutil from templatespec: use new factory functions from logcmdutil to templatespec: use new factory functions in logcmdutil.
Fri, Jul 31, 7:59 PM
martinvonz closed D8841: cleanup: fix bad formatting of state.py from D8811.
Fri, Jul 31, 9:14 AM
martinvonz committed rHGd4a28b76fa54: cleanup: fix bad formatting of state.py from D8811.
cleanup: fix bad formatting of state.py from D8811
Fri, Jul 31, 9:14 AM

Thu, Jul 30

D8849: dirstate: revert change to Rust binding now requires changes to proceed.

The commit message is missing the "why" (which is fine if that's obvious, but it doesn't seem obvious to me here). It's also unclear how this is changing a Rust binding. Are you saying that fp is an object defined in Rust?

Thu, Jul 30, 12:49 AM

Wed, Jul 29

martinvonz added inline comments to D8845: templatespec: create a factory function for each type there is.
Wed, Jul 29, 3:23 PM
martinvonz created D8845: templatespec: create a factory function for each type there is.
Wed, Jul 29, 2:39 PM
martinvonz created D8847: templatespec: move check for non-unicode to lower-level function.
Wed, Jul 29, 2:39 PM
martinvonz created D8848: templatespec: use new factory functions in logcmdutil.
Wed, Jul 29, 2:38 PM
martinvonz created D8846: templatespec: logcmdutil.templatespec() gets either template or mapfile.
Wed, Jul 29, 2:38 PM
martinvonz created D8844: templater: stop accepting a single style to stylemap().
Wed, Jul 29, 2:24 PM
martinvonz updated the diff for D8807: formatter: inline a variable assigned from `templater.templater.frommapfile`.
Wed, Jul 29, 2:24 PM
martinvonz updated the diff for D8806: templater: don't normalize path separators to '/' when interacting with OS.
Wed, Jul 29, 2:24 PM
martinvonz added a comment to D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".

I may instead make the function return a resource. We'll see.

Wed, Jul 29, 2:13 PM
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Wed, Jul 29, 1:16 AM

Tue, Jul 28

martinvonz committed rHG53a6febafc66: relnotes: copy "next" to "5.5" and clear "next".
relnotes: copy "next" to "5.5" and clear "next"
Tue, Jul 28, 3:45 PM
martinvonz closed D8839: relnotes: copy "next" to "5.5" and clear "next".
Tue, Jul 28, 3:45 PM
martinvonz updated the diff for D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".
Tue, Jul 28, 2:15 PM
martinvonz updated the diff for D8807: formatter: inline a variable assigned from `templater.templater.frommapfile`.
Tue, Jul 28, 2:14 PM
martinvonz updated the diff for D8804: templater: make templatepath() not return directory paths.
Tue, Jul 28, 2:14 PM
martinvonz updated the diff for D8806: templater: don't normalize path separators to '/' when interacting with OS.
Tue, Jul 28, 2:14 PM
martinvonz updated the diff for D8796: config: remove now-unused `abs` argument from `include` callback.
Tue, Jul 28, 2:14 PM
martinvonz created D8841: cleanup: fix bad formatting of state.py from D8811.
Tue, Jul 28, 2:11 PM
martinvonz added a comment to D8840: rename: add support for --at-rev, which marks as copy and removes the source.

I didn't include release notes in this patch because D8839 needs to get in first. If that lands quickly and gets merged to default, I'll update this patch. Otherwise I'll just send a follow-up later.

Tue, Jul 28, 1:34 PM
martinvonz created D8840: rename: add support for --at-rev, which marks as copy and removes the source.
Tue, Jul 28, 1:24 PM
martinvonz created D8839: relnotes: copy "next" to "5.5" and clear "next".
Tue, Jul 28, 1:21 PM
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Tue, Jul 28, 12:14 AM

Mon, Jul 27

martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Mon, Jul 27, 7:39 PM
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Mon, Jul 27, 3:25 PM
martinvonz added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Mon, Jul 27, 2:02 PM

Sat, Jul 25

martinvonz closed D8800: tests: add tests trying to use dir as style, as %include, and as __base__.
Sat, Jul 25, 6:04 AM
martinvonz committed rHGf512708a9ea8: tests: add tests trying to use dir as style, as %include, and as __base__.
tests: add tests trying to use dir as style, as %include, and as __base__
Sat, Jul 25, 6:04 AM
martinvonz closed D8802: tests: fix mistaken copy&paste from commit 4489e9a22763.
Sat, Jul 25, 6:04 AM
martinvonz committed rHGbe1ab47d90f1: tests: fix mistaken copy&paste from commit 4489e9a22763.
tests: fix mistaken copy&paste from commit 4489e9a22763
Sat, Jul 25, 6:03 AM
martinvonz closed D8808: fix: update documentation to reflect preference for --source over --rev.
Sat, Jul 25, 6:03 AM
martinvonz committed rHG3ea3b85df03f: fix: update documentation to reflect preference for --source over --rev.
fix: update documentation to reflect preference for --source over --rev
Sat, Jul 25, 6:03 AM
martinvonz closed D8810: templater: handle None returned from templatedir().
Sat, Jul 25, 6:03 AM
martinvonz committed rHGd5ccc059fbcd: templater: handle None returned from templatedir().
templater: handle None returned from templatedir()
Sat, Jul 25, 6:02 AM

Fri, Jul 24

martinvonz created D8810: templater: handle None returned from templatedir().
Fri, Jul 24, 5:48 PM
martinvonz created D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".
Fri, Jul 24, 1:24 PM
martinvonz created D8808: fix: update documentation to reflect preference for --source over --rev.
Fri, Jul 24, 11:39 AM
martinvonz created D8807: formatter: inline a variable assigned from `templater.templater.frommapfile`.
Fri, Jul 24, 2:03 AM
martinvonz created D8806: templater: don't normalize path separators to '/' when interacting with OS.
Fri, Jul 24, 2:03 AM