Dec 19 2019
Dec 18 2019
Dec 17 2019
Dec 14 2019
Dec 13 2019
This should be documented in mercurial/helptext/config.txt I think.
Dec 12 2019
Dec 11 2019
Dec 10 2019
Dec 8 2019
Dec 4 2019
Dec 2 2019
There is apparently no test coverage for this.
Dec 1 2019
All these API where one can pass either a list of "things" or just one "thing" is kind of ugly. We should only handle the list case, I think.
Nov 30 2019
Nov 24 2019
This is actually pycompat.open(), so it need bytes.
Looks like dead code
Nov 23 2019
I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?
I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of x and * nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now.
After further review, the obsolete revisions have unstable children going way back, so that's why they show. But I'm super confused by the output. This isn't the whole output, but the middle or so that corresponds to the latest(!) commits:
Nov 22 2019
nit: the actual PEP is pep-0461 (https://www.python.org/dev/peps/pep-0461/)
The next commit is going to change the format of conduit API requests so none of the VCR recordings will match and all the tests will fail.
Nov 21 2019
Shouldn't this be also done for all similar functions? (i.e. _xmergeimm and functions registered as a merge tool with @internaltool)
Nov 20 2019
I don't see any test for hg shelve --delete NAME that's not a command error case; adding some in D7460.
Nov 19 2019
Looking closer at the error above, it mentions bytestr.__init__, not __new__ (and there is in fact no type annotation for __new__ in typeshed).
Sorry, still not ok afaict :/
Nov 16 2019
Nov 15 2019
black complains because inline comments have only one space before (esp. the first one produces a parse error).
Out of curiosity, where does this __index__ value come from?
D7430 makes this changes unnecessary I think.
Rather class bytestr(bytes): # type: Callable[[Union[bytes, str], bytestr] as @yuya suggested in D7380.
Nov 14 2019
class bytestr(bytes): # type: (Union[bytes,str]) -> bytestr [...]
Have you tried using variables annotations? Like:
strtolocal = pycompat.identity # type: (str) -> bytes strfromlocal = pycompat.identity # type: (bytes) -> str
I wonder if using importlib.import_module() wouldn't help. Or is it something we avoid in Mercurial?