Page MenuHomePhabricator
Feed Advanced Search

Today

mharbison72 added a comment to D9413: helptext: document share safe functionality in `hg help config -v`.

It might be move visible and easier to reference if this was mentioned in the ordered list of config files above too/instead.

Wed, Dec 2, 12:36 PM
D9412: helptext: mention in `hg help config` that `.hg/hgrc-not-shared` is consulted is now accepted and ready to land.
Wed, Dec 2, 12:35 PM
D9413: helptext: document share safe functionality in `hg help config -v` is now accepted and ready to land.

Queued, with some message fixes and byteification, thanks

Wed, Dec 2, 12:35 PM
D9411: share: add documentation about share-safe mode in `hg help -e share` is now accepted and ready to land.
Wed, Dec 2, 12:35 PM
D9410: helptext: update first hg version when share-safe will be released is now accepted and ready to land.
Wed, Dec 2, 12:35 PM
D9358: upgrade: add support to downgrade share safe mode is now accepted and ready to land.
Wed, Dec 2, 12:35 PM
D9369: share: show warning if share is outdated while source supports share-safe is now accepted and ready to land.
Wed, Dec 2, 12:35 PM
mharbison72 accepted D9144: upgrade: add support for experimental safe share mode.
Wed, Dec 2, 12:35 PM
D9462: chgserver: catch RepoError while loading configuration is now accepted and ready to land.
Wed, Dec 2, 9:55 AM
mharbison72 closed D9489: registrar: clarify the documentation about some byte strings being required.
Wed, Dec 2, 3:04 AM
mharbison72 committed rHGc1bb02738f96: registrar: clarify the documentation about some byte strings being required.
registrar: clarify the documentation about some byte strings being required
Wed, Dec 2, 3:04 AM
mharbison72 added inline comments to D9358: upgrade: add support to downgrade share safe mode.
Wed, Dec 2, 12:14 AM

Yesterday

D9475: upgrade: move optimisation to something more declarative is now accepted and ready to land.

Queued these 3, thanks. D9468 LGTM, but I'll leave it for @pulkit25 to make sure he's happy with it. The later ones generate merge conflicts without it, so stopping here.

Tue, Dec 1, 11:37 PM
D9473: upgrade: capitalize the `deficiency` constant is now accepted and ready to land.
Tue, Dec 1, 11:37 PM
D9474: upgrade: capitalize the `deficiency` constant is now accepted and ready to land.
Tue, Dec 1, 11:37 PM
mharbison72 added a comment to D9469: upgrade: display the list of processed revlog before proceeding.

This looks good other than the one question I had.

Tue, Dec 1, 11:25 PM
D9470: tests: set old git default branch name for compatibility is now accepted and ready to land.
Tue, Dec 1, 11:10 PM
mharbison72 added a comment to D9470: tests: set old git default branch name for compatibility.

It still fails like this for me:

--- /usr/local/google/home/martinvonz/hg/tests/test-git-interop.t
+++ /usr/local/google/home/martinvonz/hg/tests/test-git-interop.t.err
@@ -213,7 +213,8 @@
   $ hg log -r "children(3d9be8deba43)" -T"{node|short} {children}\n"
-  a1983dd7fb19 3:d8ee22687733
+  abort: unknown revision '3d9be8deba43'
+  [255]
 hg annotate
@@ -267,14 +268,13 @@
 This coveres changelog.findmissing()
   $ hg merge --preview 3d9be8deba43
+  abort: unknown revision '3d9be8deba43'
+  [255]
 This covers manifest.diff()
   $ hg diff -c 3d9be8deba43
-  diff -r c5864c9d16fb -r 3d9be8deba43 beta
-  --- /dev/null        Thu Jan 01 00:00:00 1970 +0000
-  +++ b/beta   Mon Jan 01 00:00:11 2007 +0000
-  @@ -0,0 +1,1 @@
-  +beta
+  abort: unknown revision '3d9be8deba43'
+  [255]
Tue, Dec 1, 11:07 PM
D9451: heptapod-ci: automatically refresh existing phabricator Diff on push is now accepted and ready to land.

Queued, thanks. I assume D9459 is still not ready/to be abandoned, based on the comment?

Tue, Dec 1, 10:58 PM
D9460: contrib: add a small script to refresh all diff in the current stack is now accepted and ready to land.
Tue, Dec 1, 10:58 PM
D9463: tests: conditionalize return code on chg in test-config.t is now accepted and ready to land.

Queued 1 and 3, thanks

Tue, Dec 1, 6:35 PM
D9414: tests: update test-chg.t with output change is now accepted and ready to land.
Tue, Dec 1, 6:35 PM
mharbison72 created D9489: registrar: clarify the documentation about some byte strings being required.
Tue, Dec 1, 6:26 PM
D9471: procutil: use rapply(tonativestr, ...) to preserve lists when they come in is now accepted and ready to land.

Queued for stable, thanks. It looks like none of the other Popen() calls in this module use rapply. IDK why they wouldn't trigger a failure

Tue, Dec 1, 6:20 PM
mharbison72 added inline comments to D9462: chgserver: catch RepoError while loading configuration.
Tue, Dec 1, 2:03 PM
mharbison72 added inline comments to D9471: procutil: use rapply(tonativestr, ...) to preserve lists when they come in.
Tue, Dec 1, 1:43 AM
mharbison72 added a comment to D9471: procutil: use rapply(tonativestr, ...) to preserve lists when they come in.

procutil: correctly convert to bytes when shell=False

Tue, Dec 1, 1:40 AM

Mon, Nov 30

mharbison72 closed D9405: packaging: add pygit2 to the py3 Windows installers.
Mon, Nov 30, 12:24 PM
mharbison72 committed rHGd26497811ed9: packaging: add pygit2 to the py3 Windows installers.
packaging: add pygit2 to the py3 Windows installers
Mon, Nov 30, 12:24 PM

Sun, Nov 29

mharbison72 added a comment to D9405: packaging: add pygit2 to the py3 Windows installers.

@durin42: any ideas about the stacktrace? I haven't dug into it at all, so I'm hoping maybe it's something you've seen before. It seems to original here:
https://github.com/libgit2/pygit2/blob/0129d963c8b90cd42f6f13dab0fa7953389f8441/src/repository.c#L114

Sun, Nov 29, 2:34 PM
mharbison72 closed D9396: packaging: drop Disco (19.04) and add Focal (20.04).
Sun, Nov 29, 1:40 PM
mharbison72 committed rHGd9a05b11904d: make: drop Trusty and Artful targets.
make: drop Trusty and Artful targets
Sun, Nov 29, 1:40 PM
mharbison72 closed D9395: make: drop Trusty and Artful targets.
Sun, Nov 29, 1:40 PM
mharbison72 committed rHG971424517e17: packaging: drop Disco (19.04) and add Focal (20.04).
packaging: drop Disco (19.04) and add Focal (20.04)
Sun, Nov 29, 1:40 PM
mharbison72 committed rHGf6a1540dc572: packaging: add `HG_DOCKER_OWN_USER` to `dockerdeb` like exists in `dockerrpm`.
packaging: add `HG_DOCKER_OWN_USER` to `dockerdeb` like exists in `dockerrpm`
Sun, Nov 29, 1:40 PM
mharbison72 closed D9394: packaging: add `HG_DOCKER_OWN_USER` to `dockerdeb` like exists in `dockerrpm`.
Sun, Nov 29, 1:40 PM
mharbison72 committed rHGbc1b4eb21da9: helptext: document the mechanism for extensions to report a version.
helptext: document the mechanism for extensions to report a version
Sun, Nov 29, 1:40 PM
mharbison72 closed D9448: helptext: document the mechanism for extensions to report a version.
Sun, Nov 29, 1:40 PM
mharbison72 committed rHG064449f9fdc2: run-tests: use a context manager when looking for available ports.
run-tests: use a context manager when looking for available ports
Sun, Nov 29, 9:49 AM

Sat, Nov 28

mharbison72 added inline comments to D9451: heptapod-ci: automatically refresh existing phabricator Diff on push.
Sat, Nov 28, 11:16 PM
mharbison72 added a comment to D9452: run-tests: fix a socket context manager for py2.

I broke this in e1404a75cddd

Sat, Nov 28, 11:02 PM
mharbison72 created D9452: run-tests: fix a socket context manager for py2.
Sat, Nov 28, 11:00 PM
mharbison72 added a comment to D9444: rust: fix non-utf8 char in requirements.rs.

I’m pretty sure that this U+2019 RIGHT SINGLE QUOTATION MARK character was correctly encoded in UTF-8.

Sat, Nov 28, 7:09 PM
D9444: rust: fix non-utf8 char in requirements.rs is now accepted and ready to land.

Queued, thanks

Sat, Nov 28, 3:09 PM
mharbison72 created D9448: helptext: document the mechanism for extensions to report a version.
Sat, Nov 28, 2:36 PM
mharbison72 closed D9441: run-tests: use a context manager when looking for available ports.
Sat, Nov 28, 7:07 AM
mharbison72 closed D9438: dispatch: quote the extension when printing the bug report.
Sat, Nov 28, 7:06 AM
mharbison72 closed D9440: dispatch: print the version of each extension in the bug report, if available.
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGe1404a75cddd: run-tests: use a context manager when looking for available ports.
run-tests: use a context manager when looking for available ports
Sat, Nov 28, 7:06 AM
mharbison72 closed D9437: dispatch: print the version of the extension being blamed in a bug report.
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGa120d1c9c704: dispatch: print the version of each extension in the bug report, if available.
dispatch: print the version of each extension in the bug report, if available
Sat, Nov 28, 7:06 AM
mharbison72 closed D9439: dispatch: sort the loaded extension names in the bug report.
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGd896c958e428: dispatch: sort the loaded extension names in the bug report.
dispatch: sort the loaded extension names in the bug report
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGa2104b9b1787: dispatch: quote the extension when printing the bug report.
dispatch: quote the extension when printing the bug report
Sat, Nov 28, 7:06 AM
mharbison72 closed D9436: git: show the version of `pygit2` with verbose version output.
Sat, Nov 28, 7:06 AM
mharbison72 closed D9434: tests: add a comment that we're purposely testing py2 extension attributes.
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGc26cb33e5219: dispatch: print the version of the extension being blamed in a bug report.
dispatch: print the version of the extension being blamed in a bug report
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGc7c1efdfd4de: git: show the version of `pygit2` with verbose version output.
git: show the version of `pygit2` with verbose version output
Sat, Nov 28, 7:06 AM
mharbison72 committed rHG250e18437e30: tests: add a comment that we're purposely testing py2 extension attributes.
tests: add a comment that we're purposely testing py2 extension attributes
Sat, Nov 28, 7:06 AM
mharbison72 committed rHGa001e28ad5eb: git: add the standard `testedwith` attribute.
git: add the standard `testedwith` attribute
Sat, Nov 28, 7:06 AM
mharbison72 closed D9432: formatting: drop a few extra double quotes in docstrings.
Sat, Nov 28, 7:06 AM
mharbison72 closed D9433: extensions: avoid a crash when the version isn't properly byteified on py3.
Sat, Nov 28, 7:06 AM
mharbison72 closed D9435: git: add the standard `testedwith` attribute.
Sat, Nov 28, 7:06 AM
mharbison72 committed rHG3db545fccac1: extensions: avoid a crash when the version isn't properly byteified on py3.
extensions: avoid a crash when the version isn't properly byteified on py3
Sat, Nov 28, 7:05 AM
mharbison72 committed rHG464539c305aa: formatting: drop a few extra double quotes in docstrings.
formatting: drop a few extra double quotes in docstrings
Sat, Nov 28, 7:05 AM
mharbison72 closed D9431: hghave: adjust the detection of `pylint` for modern versions.
Sat, Nov 28, 7:05 AM
mharbison72 committed rHGa9797b49fb69: hghave: adjust the detection of `pylint` for modern versions.
hghave: adjust the detection of `pylint` for modern versions
Sat, Nov 28, 7:05 AM

Fri, Nov 27

mharbison72 added a comment to D9375: ui: ensure `getpass()` returns bytes.

Should this be grafted to stable because of need for smtp.login() to have str? I don't care too much about the debug command crashing.

Fri, Nov 27, 11:54 PM
mharbison72 added a comment to D9433: extensions: avoid a crash when the version isn't properly byteified on py3.

This might be good for stable.

Fri, Nov 27, 11:51 PM
mharbison72 created D9441: run-tests: use a context manager when looking for available ports.
Fri, Nov 27, 11:49 PM
mharbison72 created D9440: dispatch: print the version of each extension in the bug report, if available.
Fri, Nov 27, 11:49 PM
mharbison72 created D9439: dispatch: sort the loaded extension names in the bug report.
Fri, Nov 27, 11:49 PM
mharbison72 created D9437: dispatch: print the version of the extension being blamed in a bug report.
Fri, Nov 27, 11:49 PM
mharbison72 created D9438: dispatch: quote the extension when printing the bug report.
Fri, Nov 27, 11:49 PM
mharbison72 created D9436: git: show the version of `pygit2` with verbose version output.
Fri, Nov 27, 11:49 PM
mharbison72 created D9433: extensions: avoid a crash when the version isn't properly byteified on py3.
Fri, Nov 27, 11:48 PM
mharbison72 created D9432: formatting: drop a few extra double quotes in docstrings.
Fri, Nov 27, 11:48 PM
mharbison72 created D9434: tests: add a comment that we're purposely testing py2 extension attributes.
Fri, Nov 27, 11:48 PM
mharbison72 created D9435: git: add the standard `testedwith` attribute.
Fri, Nov 27, 11:48 PM
mharbison72 added a comment to D9430: formating: upgrade to black 20.8b1.

Amended this into setup.py, which was changed in D9427 with the older black:

Fri, Nov 27, 11:41 PM
D9430: formating: upgrade to black 20.8b1 is now accepted and ready to land.
Fri, Nov 27, 11:37 PM
D9428: merge: remove spurious ' and trailing whitespace from triple-quoted string is now accepted and ready to land.
Fri, Nov 27, 11:37 PM
D9429: osutil: reformat triple-quoted string so black doesn't confuse itself is now accepted and ready to land.
Fri, Nov 27, 11:37 PM
mharbison72 closed D9427: cleanup: fix a few recent black formatting violations.
Fri, Nov 27, 5:19 PM
mharbison72 committed rHG66f6ca2b7aee: cleanup: fix a few recent black formatting violations.
cleanup: fix a few recent black formatting violations
Fri, Nov 27, 5:19 PM
mharbison72 created D9431: hghave: adjust the detection of `pylint` for modern versions.
Fri, Nov 27, 5:12 PM
mharbison72 created D9427: cleanup: fix a few recent black formatting violations.
Fri, Nov 27, 5:01 PM

Thu, Nov 26

mharbison72 updated subscribers of D9405: packaging: add pygit2 to the py3 Windows installers.

@durin42: any ideas about the stacktrace? I haven't dug into it at all, so I'm hoping maybe it's something you've seen before. It seems to original here:

Thu, Nov 26, 2:10 PM
mharbison72 added a comment to D9404: packaging: regenerate the Windows requirements manifest on Windows.

Sorry, I should have paid attention to what branch I was on. This series should probably go on stable, since we seem to be packing the wrong stuff.

Thu, Nov 26, 2:04 PM
mharbison72 closed D9375: ui: ensure `getpass()` returns bytes.
Thu, Nov 26, 8:16 AM
mharbison72 closed D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building.
Thu, Nov 26, 8:16 AM
mharbison72 closed D9364: tests: use `testrepohg` in one more place in test-check-code.t.
Thu, Nov 26, 8:16 AM
mharbison72 committed rHGeff26a0f664f: tests: use `testrepohg` in one more place in test-check-code.t.
tests: use `testrepohg` in one more place in test-check-code.t
Thu, Nov 26, 8:15 AM
mharbison72 committed rHG2960b7fac966: setup: copy pythonXY.dll next to the hg.exe wrapper when building.
setup: copy pythonXY.dll next to the hg.exe wrapper when building
Thu, Nov 26, 8:15 AM
mharbison72 closed D9368: exthelper: update the examples to be python3 complaint.
Thu, Nov 26, 8:15 AM
mharbison72 committed rHGbd22900e26ac: exthelper: update the examples to be python3 complaint.
exthelper: update the examples to be python3 complaint
Thu, Nov 26, 8:15 AM
mharbison72 closed D9367: helptext: byteify extensions examples.
Thu, Nov 26, 8:15 AM
mharbison72 committed rHGf177fcd9cb96: helptext: byteify extensions examples.
helptext: byteify extensions examples
Thu, Nov 26, 8:15 AM
mharbison72 closed D9366: helptext: fix sentence in extensions documentation.
Thu, Nov 26, 8:15 AM
mharbison72 committed rHG87e7dd8e7734: ui: ensure `getpass()` returns bytes.
ui: ensure `getpass()` returns bytes
Thu, Nov 26, 8:15 AM