Page MenuHomePhabricator
Feed Advanced Search

Today

mharbison72 created D10702: run-tests: use the same python version for shebang lines on Windows.
Sat, May 8, 12:30 AM

Yesterday

mharbison72 committed rHGbea4717415c0: merge with stable.
merge with stable
Fri, May 7, 10:11 PM
mharbison72 added a comment to D10701: status: Add tests for some more edge cases.

check code complains about this series:

Fri, May 7, 9:56 PM
mharbison72 added a comment to D10689: pyoxidizer: use Python 3.9 (BC).

I think I've hit a dead end trying to produce installers. I first updated rustup and pyoxidizer on my laptop that I've used in the past to successfully build pyoxidizer binaries, but it prints an error about a zip file with a date before 1980 not being supported. I switched to a clean system, ran .\contrib\install-windows-dependencies.ps1, and that died because it looks like MS removed the py27 compiler. (Maybe that should be cached somewhere for posterity, but I don't think I have a local copy.) Commenting those references out, I was eventually able to get everything installed, but it reproduced the same error:

Fri, May 7, 12:43 PM
mharbison72 added a comment to D10693: run-tests: fix whitelist/blacklist with directories on Windows.

Should we fix the handling of that list in run-tests.py instead ?

Fri, May 7, 10:24 AM
mharbison72 added a comment to D10683: pyoxidizer: support producing MSI installers.

I know very little about how to do WiX properly, but we had some issues with the redistributable runtime in TortoiseHg, and the file overwrite mode. The existing Mercurial installer shouldn't have the redistributable runtime issue (since it uses VS 2008), but does have the same overwrite mode. I'll leave them here in case they're worth considering.

Fri, May 7, 12:16 AM
mharbison72 created D10693: run-tests: fix whitelist/blacklist with directories on Windows.
Fri, May 7, 12:02 AM
mharbison72 created D10692: run-tests: ignore PermissionError when checking available ports.
Fri, May 7, 12:02 AM
mharbison72 created D10694: hghave: fix the definition of `python3` to work on Windows.
Fri, May 7, 12:02 AM

Thu, May 6

mharbison72 added a comment to D10690: automation: create Python 3.5 variant of requirements.txt.

(I do question why we are still supporting Python 3.5...)

Thu, May 6, 11:27 PM
mharbison72 closed D10633: tests: ensure `$PYTHON` is quoted for Windows.
Thu, May 6, 1:22 PM
mharbison72 closed D10637: tests: change the fixer commands to use the buffer attribute on stdio objects.
Thu, May 6, 1:21 PM
mharbison72 committed rHGea563187ee7c: tests: change the fixer commands to use the buffer attribute on stdio objects.
tests: change the fixer commands to use the buffer attribute on stdio objects
Thu, May 6, 1:21 PM
mharbison72 committed rHG9e3979a25bfe: tests: stabilize test-persistent-nodemap.t on Windows.
tests: stabilize test-persistent-nodemap.t on Windows
Thu, May 6, 1:21 PM
mharbison72 committed rHGa12819559ccb: tests: invoke some shell scripts through the shell interpreter for Windows.
tests: invoke some shell scripts through the shell interpreter for Windows
Thu, May 6, 1:20 PM
mharbison72 closed D10634: tests: run python script through quoted interpreter instead of directly.
Thu, May 6, 1:20 PM
mharbison72 closed D10636: tests: stabilize test-persistent-nodemap.t on Windows.
Thu, May 6, 1:20 PM
mharbison72 closed D10635: tests: invoke some shell scripts through the shell interpreter for Windows.
Thu, May 6, 1:20 PM
mharbison72 committed rHG7383df4f6e19: tests: run python script through quoted interpreter instead of directly.
tests: run python script through quoted interpreter instead of directly
Thu, May 6, 1:20 PM
mharbison72 committed rHG1d075b857c90: tests: ensure `$PYTHON` is quoted for Windows.
tests: ensure `$PYTHON` is quoted for Windows
Thu, May 6, 1:20 PM

Mon, May 3

mharbison72 created D10633: tests: ensure `$PYTHON` is quoted for Windows.
Mon, May 3, 2:23 PM
mharbison72 created D10637: tests: change the fixer commands to use the buffer attribute on stdio objects.
Mon, May 3, 2:22 PM
mharbison72 created D10636: tests: stabilize test-persistent-nodemap.t on Windows.
Mon, May 3, 2:22 PM
mharbison72 created D10634: tests: run python script through quoted interpreter instead of directly.
Mon, May 3, 2:22 PM
mharbison72 created D10635: tests: invoke some shell scripts through the shell interpreter for Windows.
Mon, May 3, 2:22 PM
mharbison72 added a comment to D10462: heptapod-ci: enable pytype checking.

Now that the CI images are updated, I think this is ready to land.

Mon, May 3, 1:31 PM
mharbison72 closed D10541: phabricator: adapt to the new `urlutil.url()` API.
Mon, May 3, 10:08 AM
mharbison72 committed rHG067f2c53fb24: phabricator: adapt to the new `urlutil.url()` API.
phabricator: adapt to the new `urlutil.url()` API
Mon, May 3, 10:08 AM
mharbison72 closed D10528: git: initialize `extra` to have at least the branch name for nullid.
Mon, May 3, 10:08 AM
mharbison72 closed D10540: extensions: ignore exceptions from an extension's `getversion()` method.
Mon, May 3, 10:08 AM
mharbison72 closed D10531: tests: synchronize the git and Mercurial username.
Mon, May 3, 10:08 AM
mharbison72 committed rHG553451522113: extensions: ignore exceptions from an extension's `getversion()` method.
extensions: ignore exceptions from an extension's `getversion()` method
Mon, May 3, 10:07 AM
mharbison72 closed D10532: git: ensure all dirstate state values are bytes.
Mon, May 3, 10:07 AM
mharbison72 committed rHG9cea55ca1175: git: ensure all dirstate state values are bytes.
git: ensure all dirstate state values are bytes
Mon, May 3, 10:07 AM
mharbison72 committed rHG4c7bc42a509e: tests: synchronize the git and Mercurial username.
tests: synchronize the git and Mercurial username
Mon, May 3, 10:07 AM
mharbison72 committed rHGf8fa7ec53517: git: initialize `extra` to have at least the branch name for nullid.
git: initialize `extra` to have at least the branch name for nullid
Mon, May 3, 10:07 AM
mharbison72 closed D10526: git: pass the correct type to the sqlite3 query for baselog.hasnode().
Mon, May 3, 10:07 AM
mharbison72 closed D10527: git: consistently use str for parents when rebuilding the index database.
Mon, May 3, 10:07 AM
mharbison72 committed rHGde26b9a7ec29: git: consistently use str for parents when rebuilding the index database.
git: consistently use str for parents when rebuilding the index database
Mon, May 3, 10:07 AM
mharbison72 closed D10525: git: use the correct type for stopping changelog.revs().
Mon, May 3, 10:07 AM
mharbison72 committed rHGce24a00fe7f0: git: pass the correct type to the sqlite3 query for baselog.hasnode().
git: pass the correct type to the sqlite3 query for baselog.hasnode()
Mon, May 3, 10:07 AM
mharbison72 committed rHG2a77c817d451: git: use the correct type for stopping changelog.revs().
git: use the correct type for stopping changelog.revs()
Mon, May 3, 10:07 AM
mharbison72 committed rHG03c73fc6f89a: git: use the proper filenode for deleted files in changelog.changelogrevision.
git: use the proper filenode for deleted files in changelog.changelogrevision
Mon, May 3, 10:07 AM
mharbison72 closed D10522: git: make changelog.tiprev() return int instead of tuple (issue6510).
Mon, May 3, 10:07 AM
mharbison72 closed D10523: tests: add coverage for git.changelog.headrevs(...).
Mon, May 3, 10:07 AM
mharbison72 closed D10524: git: use the proper filenode for deleted files in changelog.changelogrevision.
Mon, May 3, 10:07 AM
mharbison72 closed D10521: git: fix partial node matching.
Mon, May 3, 10:07 AM
mharbison72 committed rHG8d733cbc2724: tests: add coverage for git.changelog.headrevs(...).
tests: add coverage for git.changelog.headrevs(...)
Mon, May 3, 10:07 AM
mharbison72 committed rHG497cedcb6504: git: make changelog.tiprev() return int instead of tuple (issue6510).
git: make changelog.tiprev() return int instead of tuple (issue6510)
Mon, May 3, 10:07 AM
mharbison72 closed D10520: tests: stabilize test-git-interop.t for some versions of git.
Mon, May 3, 10:07 AM
mharbison72 committed rHG846920d89476: git: fix partial node matching.
git: fix partial node matching
Mon, May 3, 10:07 AM
mharbison72 committed rHG96d295dd4968: tests: stabilize test-git-interop.t for some versions of git.
tests: stabilize test-git-interop.t for some versions of git
Mon, May 3, 10:07 AM

Sat, May 1

mharbison72 created D10541: phabricator: adapt to the new `urlutil.url()` API.
Sat, May 1, 1:51 AM

Fri, Apr 30

D10474: errors: define OutOfBandError in py2-compatible way is now accepted and ready to land.

Already amended in as noted (let's see if accepting closes it).

Fri, Apr 30, 9:28 PM
mharbison72 updated the summary of D10540: extensions: ignore exceptions from an extension's `getversion()` method.
Fri, Apr 30, 9:08 PM
mharbison72 created D10540: extensions: ignore exceptions from an extension's `getversion()` method.
Fri, Apr 30, 8:47 PM

Wed, Apr 28

mharbison72 created D10531: tests: synchronize the git and Mercurial username.
Wed, Apr 28, 8:24 PM
mharbison72 created D10532: git: ensure all dirstate state values are bytes.
Wed, Apr 28, 8:24 PM
mharbison72 closed D10461: incoming: use bytes for an error message.
Wed, Apr 28, 11:09 AM
mharbison72 closed D10460: typing: enable pytype processing on mercurial/upgrade_utils/actions.py.
Wed, Apr 28, 11:09 AM
mharbison72 committed rHGe050efe97fbe: typing: enable pytype processing on mercurial/upgrade_utils/actions.py.
typing: enable pytype processing on mercurial/upgrade_utils/actions.py
Wed, Apr 28, 11:09 AM
mharbison72 committed rHG27602e030a1f: incoming: use bytes for an error message.
incoming: use bytes for an error message
Wed, Apr 28, 11:09 AM
mharbison72 closed D10505: mail: add a TODO about proper mbox locking.
Wed, Apr 28, 11:09 AM
mharbison72 committed rHG106402245301: mail: add a TODO about proper mbox locking.
mail: add a TODO about proper mbox locking
Wed, Apr 28, 11:09 AM
mharbison72 created D10528: git: initialize `extra` to have at least the branch name for nullid.
Wed, Apr 28, 11:07 AM
mharbison72 created D10525: git: use the correct type for stopping changelog.revs().
Wed, Apr 28, 11:07 AM
mharbison72 created D10526: git: pass the correct type to the sqlite3 query for baselog.hasnode().
Wed, Apr 28, 11:07 AM
mharbison72 created D10527: git: consistently use str for parents when rebuilding the index database.
Wed, Apr 28, 11:07 AM
mharbison72 created D10523: tests: add coverage for git.changelog.headrevs(...).
Wed, Apr 28, 11:07 AM
mharbison72 created D10522: git: make changelog.tiprev() return int instead of tuple (issue6510).
Wed, Apr 28, 11:07 AM
mharbison72 created D10524: git: use the proper filenode for deleted files in changelog.changelogrevision.
Wed, Apr 28, 11:07 AM
mharbison72 created D10521: git: fix partial node matching.
Wed, Apr 28, 11:06 AM
mharbison72 created D10520: tests: stabilize test-git-interop.t for some versions of git.
Wed, Apr 28, 11:06 AM

Tue, Apr 20

mharbison72 created D10505: mail: add a TODO about proper mbox locking.
Tue, Apr 20, 11:31 PM
mharbison72 closed D10473: mail: force SMTPException to bytes before wrapping in error.Abort.
Tue, Apr 20, 10:23 AM
mharbison72 committed rHG5fa019ceb499: mail: force SMTPException to bytes before wrapping in error.Abort.
mail: force SMTPException to bytes before wrapping in error.Abort
Tue, Apr 20, 10:23 AM
mharbison72 committed rHG83c0d144ef8d: mail: split out the SMTP login to allow the keyring extension to wrap it.
mail: split out the SMTP login to allow the keyring extension to wrap it
Tue, Apr 20, 10:23 AM
mharbison72 closed D10471: mail: split out the SMTP login to allow the keyring extension to wrap it.
Tue, Apr 20, 10:23 AM
mharbison72 added inline comments to D10462: heptapod-ci: enable pytype checking.
Tue, Apr 20, 9:48 AM
mharbison72 added a comment to D10462: heptapod-ci: enable pytype checking.

Do you need help fixing the base CI image to get the right Python version?

Tue, Apr 20, 8:54 AM
mharbison72 committed rHGd467bae86b2d: mail: use a context manager when writing to mbox.
mail: use a context manager when writing to mbox
Tue, Apr 20, 1:32 AM
mharbison72 closed D10484: mail: use a context manager when writing to mbox.
Tue, Apr 20, 1:32 AM
mharbison72 created D10484: mail: use a context manager when writing to mbox.
Tue, Apr 20, 1:10 AM
mharbison72 added a comment to D10474: errors: define OutOfBandError in py2-compatible way.

Amended this into D10465.

Tue, Apr 20, 12:15 AM

Mon, Apr 19

mharbison72 added a comment to D10464: phab-refresh: use a special comment on the stable branch.

You might want to double check this because I think the phab extension has a bug related to importing non ascii characters in some cases, but the result looked OK.

Mon, Apr 19, 11:44 PM
mharbison72 added inline comments to D10356: config: add an experimental option to list all known config.
Mon, Apr 19, 11:40 PM
mharbison72 created D10473: mail: force SMTPException to bytes before wrapping in error.Abort.
Mon, Apr 19, 9:08 PM
mharbison72 updated the diff for D10471: mail: split out the SMTP login to allow the keyring extension to wrap it.
Mon, Apr 19, 9:08 PM
mharbison72 created D10471: mail: split out the SMTP login to allow the keyring extension to wrap it.
Mon, Apr 19, 7:40 PM

Sun, Apr 18

mharbison72 created D10462: heptapod-ci: enable pytype checking.
Sun, Apr 18, 1:36 AM
mharbison72 created D10461: incoming: use bytes for an error message.
Sun, Apr 18, 1:36 AM
mharbison72 created D10460: typing: enable pytype processing on mercurial/upgrade_utils/actions.py.
Sun, Apr 18, 1:36 AM

Sat, Apr 17

mharbison72 closed D10459: cmdutil: fix an uninitialize variable usage in clearunfinished().
Sat, Apr 17, 6:13 PM
mharbison72 committed rHGd9531094cf8e: cmdutil: fix an uninitialize variable usage in clearunfinished().
cmdutil: fix an uninitialize variable usage in clearunfinished()
Sat, Apr 17, 6:13 PM
mharbison72 created D10459: cmdutil: fix an uninitialize variable usage in clearunfinished().
Sat, Apr 17, 1:13 AM

Thu, Apr 15

mharbison72 closed D10376: re2: adjust local variable assignment scope.
Thu, Apr 15, 9:44 AM
mharbison72 closed D10433: urlutil: use bytes for Abort messages.
Thu, Apr 15, 9:44 AM
mharbison72 committed rHG93c224dc099b: urlutil: use bytes for Abort messages.
urlutil: use bytes for Abort messages
Thu, Apr 15, 9:44 AM
mharbison72 committed rHG9c3e84569071: re2: adjust local variable assignment scope.
re2: adjust local variable assignment scope
Thu, Apr 15, 9:44 AM

Wed, Apr 14

mharbison72 created D10433: urlutil: use bytes for Abort messages.
Wed, Apr 14, 10:51 PM