Page MenuHomePhabricator
Feed Advanced Search

Fri, May 20

mharbison72 added a comment to D12628: worker: fix `_blockingreader.read()` to really block.

Interresting. Can I convince you to send a patch adding this explanation to the class docstring ? (and maybe fixing the class name)

Yes, I planned to do so. Should this go to the default branch?

Fri, May 20, 2:38 PM

Thu, May 19

mharbison72 added a comment to D12628: worker: fix `_blockingreader.read()` to really block.

self._wrapped is not non-blocking, therefore self._wrapped.readinto() won’t ever return None, therefore this change only adds dead code.
The name of the class _blockingreader is misleading.

Thu, May 19, 11:04 PM
mharbison72 added a comment to D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).

@mharbison72 you should have no trouble at all since you're already using Hetpapod for the CI. Please read the contributor guide here: https://www.mercurial-scm.org/wiki/Heptapod
I hope I'm clear, it's very late and my brain is half-working. :)

Thu, May 19, 11:17 AM

Wed, May 18

mharbison72 added a comment to D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).

I *think* you're supposed to open a "merge request" on https://foss.heptapod.net/mercurial/mercurial-devel these days. Right, @Alphare?

Wed, May 18, 3:59 PM
mharbison72 added a comment to D12628: worker: fix `_blockingreader.read()` to really block.

CI fails[1] with this series, but I think it's unrelated- its only chg, and test-http-bad-server.t fails for me locally in a different way, but identically with and without this series applied.

Wed, May 18, 12:41 PM
mharbison72 created D12628: worker: fix `_blockingreader.read()` to really block.
Wed, May 18, 12:36 PM
mharbison72 updated the diff for D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).
Wed, May 18, 12:36 PM

Tue, May 17

mharbison72 added a comment to D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).

This is meant for stable.

Tue, May 17, 3:34 PM
mharbison72 created D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).
Tue, May 17, 3:33 PM

Mon, May 9

mharbison72 added a comment to D12557: windows: fix stdio with py2exe and py3.

I’m a bit confused. Shouldn’t it fail already on the line stdout = _make_write_all(sys.stdout.buffer) because sys.stdout has no attribute buffer?

Mon, May 9, 8:56 PM
mharbison72 added a comment to D12557: windows: fix stdio with py2exe and py3.

The exception happened before this change- py2exe apparently wants str based stdio. The weird thing is when I retested by throwing this whole patch away, I can't recreate the issue- even by disabling evolve to get what I assume is the warning message here about obsolete markers being found without the feature being enabled.

Mon, May 9, 4:01 PM
mharbison72 committed rHG90f7d8276e26: contrib: migrate off of a couple of bitbucket URLs.
contrib: migrate off of a couple of bitbucket URLs
Mon, May 9, 12:39 PM
mharbison72 committed rHG5ad37b5bfb31: diff: add help text to highlight the ability to do "merge diffs".
diff: add help text to highlight the ability to do "merge diffs"
Mon, May 9, 12:39 PM
mharbison72 closed D12605: diff: add help text to highlight the ability to do "merge diffs".
Mon, May 9, 11:53 AM
mharbison72 committed rHG783c8eb9c000: contrib: migrate off of a couple of bitbucket URLs.
contrib: migrate off of a couple of bitbucket URLs
Mon, May 9, 11:53 AM
mharbison72 closed D12606: contrib: migrate off of a couple of bitbucket URLs.
Mon, May 9, 11:53 AM
mharbison72 committed rHGa6cfc09dcb81: diff: add help text to highlight the ability to do "merge diffs".
diff: add help text to highlight the ability to do "merge diffs"
Mon, May 9, 11:52 AM
mharbison72 committed rHGdf3e9d98951b: wix: bump the minimum Windows required to 8.1.
wix: bump the minimum Windows required to 8.1
Mon, May 9, 11:52 AM
mharbison72 closed D12596: wix: bump the minimum Windows required to 8.1.
Mon, May 9, 11:52 AM
mharbison72 closed D12595: wix: drop python2 conditionals.
Mon, May 9, 11:52 AM
mharbison72 committed rHG06107198f95b: wix: drop python2 conditionals.
wix: drop python2 conditionals
Mon, May 9, 11:52 AM

Wed, May 4

mharbison72 created D12606: contrib: migrate off of a couple of bitbucket URLs.
Wed, May 4, 5:06 PM
mharbison72 created D12605: diff: add help text to highlight the ability to do "merge diffs".
Wed, May 4, 3:46 PM
mharbison72 added a comment to D12603: diff: graduate merge diffs from experimental and add to tweakdefaults.

Do we still have the problem of not being able to individually disable options enabled by tweakdefaults? I think there was a bug about it that probably got auto-closed.

Wed, May 4, 3:01 PM
mharbison72 committed rHG1b6e381521c5: doc: use an absolute path in sys.path to work around a python DLL loading bug.
doc: use an absolute path in sys.path to work around a python DLL loading bug
Wed, May 4, 5:04 AM
mharbison72 closed D12599: doc: use an absolute path in sys.path to work around a python DLL loading bug.
Wed, May 4, 5:04 AM

Tue, May 3

mharbison72 added a comment to D12599: doc: use an absolute path in sys.path to work around a python DLL loading bug.

I feel like this should be on stable?

Tue, May 3, 9:58 AM

Mon, May 2

mharbison72 created D12599: doc: use an absolute path in sys.path to work around a python DLL loading bug.
Mon, May 2, 10:07 PM

Thu, Apr 28

mharbison72 created D12596: wix: bump the minimum Windows required to 8.1.
Thu, Apr 28, 11:44 AM
mharbison72 created D12595: wix: drop python2 conditionals.
Thu, Apr 28, 11:44 AM

Apr 19 2022

mharbison72 committed rHGea98850a136e: merge with stable.
merge with stable
Apr 19 2022, 11:08 AM
mharbison72 committed rHG1c00777702da: contrib: update python dependencies on Windows.
contrib: update python dependencies on Windows
Apr 19 2022, 10:48 AM
mharbison72 committed rHGa7fe96abcf56: packaging: fix the type hint on the download_entry function.
packaging: fix the type hint on the download_entry function
Apr 19 2022, 10:48 AM
mharbison72 committed rHGb44678aeb460: packaging: drop python27 references from the Windows instructions.
packaging: drop python27 references from the Windows instructions
Apr 19 2022, 10:48 AM
mharbison72 committed rHGdd381b973efc: contrib: add a hint if the Windows dependency MSI is already installed.
contrib: add a hint if the Windows dependency MSI is already installed
Apr 19 2022, 10:48 AM
mharbison72 committed rHG020328be00cb: git: un-byteify the `mode` argument for the builtin `open()`.
git: un-byteify the `mode` argument for the builtin `open()`
Apr 19 2022, 10:48 AM
mharbison72 committed rHGf40fb4c52594: packaging: add a missing parenthesis to help text.
packaging: add a missing parenthesis to help text
Apr 19 2022, 10:48 AM
mharbison72 committed rHG20d151e43429: git: adapt to some recent dirstate API changes.
git: adapt to some recent dirstate API changes
Apr 19 2022, 10:48 AM
mharbison72 committed rHG9c8d67a3af5e: idirstate: add missing get_entry() method.
idirstate: add missing get_entry() method
Apr 19 2022, 10:48 AM
mharbison72 committed rHG7afa96d3b484: windows: disable pager when packaged with py2exe.
windows: disable pager when packaged with py2exe
Apr 19 2022, 10:48 AM
mharbison72 committed rHG4ba27acdea63: resourceutil: force filesystem access to resources when using py2exe.
resourceutil: force filesystem access to resources when using py2exe
Apr 19 2022, 10:48 AM
mharbison72 committed rHG97f2554cb647: setup: fix the py2exe logic to work with py3.
setup: fix the py2exe logic to work with py3
Apr 19 2022, 10:48 AM
mharbison72 committed rHG8e10aac28194: contrib: update python dependencies on Windows.
contrib: update python dependencies on Windows
Apr 19 2022, 8:34 AM
mharbison72 closed D12559: contrib: update python dependencies on Windows.
Apr 19 2022, 8:34 AM
mharbison72 closed D12555: procutil: avoid `+= None` when writing to full std{err,out} descriptor on py3.
Apr 19 2022, 5:19 AM
mharbison72 committed rHG90e564882f07: procutil: avoid `+= None` when writing to full std{err,out} descriptor on py3.
procutil: avoid `+= None` when writing to full std{err,out} descriptor on py3
Apr 19 2022, 5:19 AM
mharbison72 closed D12570: packaging: drop python27 references from the Windows instructions.
Apr 19 2022, 5:19 AM
mharbison72 closed D12560: contrib: add a hint if the Windows dependency MSI is already installed.
Apr 19 2022, 5:19 AM
mharbison72 committed rHG246ee748fe67: contrib: add a hint if the Windows dependency MSI is already installed.
contrib: add a hint if the Windows dependency MSI is already installed
Apr 19 2022, 5:19 AM
mharbison72 committed rHG93a78d8ccf8a: packaging: fix the type hint on the download_entry function.
packaging: fix the type hint on the download_entry function
Apr 19 2022, 5:19 AM
mharbison72 closed D12571: packaging: fix the type hint on the download_entry function.
Apr 19 2022, 5:19 AM
mharbison72 committed rHG136e94edff38: packaging: drop python27 references from the Windows instructions.
packaging: drop python27 references from the Windows instructions
Apr 19 2022, 5:19 AM
mharbison72 committed rHG04837f013fe7: packaging: add a missing parenthesis to help text.
packaging: add a missing parenthesis to help text
Apr 19 2022, 5:19 AM
mharbison72 closed D12556: windows: disable pager when packaged with py2exe.
Apr 19 2022, 5:19 AM
mharbison72 closed D12569: packaging: add a missing parenthesis to help text.
Apr 19 2022, 5:19 AM
mharbison72 closed D12567: git: adapt to some recent dirstate API changes.
Apr 19 2022, 5:19 AM
mharbison72 closed D12568: git: un-byteify the `mode` argument for the builtin `open()`.
Apr 19 2022, 5:19 AM
mharbison72 committed rHGd35c18ceaf0a: git: un-byteify the `mode` argument for the builtin `open()`.
git: un-byteify the `mode` argument for the builtin `open()`
Apr 19 2022, 5:19 AM
mharbison72 committed rHGaa400bf66880: git: adapt to some recent dirstate API changes.
git: adapt to some recent dirstate API changes
Apr 19 2022, 5:19 AM
mharbison72 committed rHG9ab62e1fc7fe: idirstate: add missing get_entry() method.
idirstate: add missing get_entry() method
Apr 19 2022, 5:19 AM
mharbison72 closed D12553: setup: fix the py2exe logic to work with py3.
Apr 19 2022, 5:19 AM
mharbison72 closed D12566: idirstate: add missing get_entry() method.
Apr 19 2022, 5:19 AM
mharbison72 committed rHG30825d156611: windows: disable pager when packaged with py2exe.
windows: disable pager when packaged with py2exe
Apr 19 2022, 5:19 AM
mharbison72 closed D12554: resourceutil: force filesystem access to resources when using py2exe.
Apr 19 2022, 5:19 AM
mharbison72 committed rHG3e8134f74d4d: resourceutil: force filesystem access to resources when using py2exe.
resourceutil: force filesystem access to resources when using py2exe
Apr 19 2022, 5:19 AM
mharbison72 committed rHG11fc5d8a4411: setup: fix the py2exe logic to work with py3.
setup: fix the py2exe logic to work with py3
Apr 19 2022, 5:19 AM

Apr 18 2022

mharbison72 created D12570: packaging: drop python27 references from the Windows instructions.
Apr 18 2022, 4:36 PM
mharbison72 created D12571: packaging: fix the type hint on the download_entry function.
Apr 18 2022, 4:36 PM
mharbison72 created D12569: packaging: add a missing parenthesis to help text.
Apr 18 2022, 4:35 PM
mharbison72 created D12568: git: un-byteify the `mode` argument for the builtin `open()`.
Apr 18 2022, 2:54 PM
mharbison72 created D12567: git: adapt to some recent dirstate API changes.
Apr 18 2022, 12:39 PM
mharbison72 created D12566: idirstate: add missing get_entry() method.
Apr 18 2022, 12:39 PM

Apr 15 2022

mharbison72 created D12560: contrib: add a hint if the Windows dependency MSI is already installed.
Apr 15 2022, 11:37 AM
mharbison72 created D12559: contrib: update python dependencies on Windows.
Apr 15 2022, 11:37 AM

Apr 14 2022

mharbison72 added a comment to D12553: setup: fix the py2exe logic to work with py3.

Shouldn't this series (aside from the last one that is not supposed to be queued) be for stable?

Apr 14 2022, 10:34 AM

Apr 13 2022

mharbison72 created D12556: windows: disable pager when packaged with py2exe.
Apr 13 2022, 6:48 PM
mharbison72 created D12557: windows: fix stdio with py2exe and py3.
Apr 13 2022, 6:48 PM
mharbison72 created D12555: procutil: avoid `+= None` when writing to full std{err,out} descriptor on py3.
Apr 13 2022, 6:48 PM
mharbison72 created D12553: setup: fix the py2exe logic to work with py3.
Apr 13 2022, 6:48 PM
mharbison72 created D12554: resourceutil: force filesystem access to resources when using py2exe.
Apr 13 2022, 6:48 PM

Apr 6 2022

mharbison72 closed D12400: pytype: drop py3.6 support.
Apr 6 2022, 6:10 AM
mharbison72 committed rHG455dce344c56: pytype: drop py3.6 support.
pytype: drop py3.6 support
Apr 6 2022, 6:10 AM

Apr 1 2022

mharbison72 closed D12421: util: drop a duplicate import.
Apr 1 2022, 3:41 PM
mharbison72 closed D12423: tests: stop excluding the pycompat module from pyflakes.
Apr 1 2022, 3:41 PM
mharbison72 closed D12419: util: restore the util.pickle symbol.
Apr 1 2022, 3:41 PM
mharbison72 committed rHG20c6c9e43397: tests: stop excluding the pycompat module from pyflakes.
tests: stop excluding the pycompat module from pyflakes
Apr 1 2022, 3:41 PM
mharbison72 closed D12422: tests: drop some py2 specific pyflake failures.
Apr 1 2022, 3:41 PM
mharbison72 committed rHG54bf76d005df: tests: drop some py2 specific pyflake failures.
tests: drop some py2 specific pyflake failures
Apr 1 2022, 3:41 PM
mharbison72 committed rHG7ccf3dac1a8f: util: drop a duplicate import.
util: drop a duplicate import
Apr 1 2022, 3:41 PM
mharbison72 committed rHGe45c39273395: pycompat: drop the pickle import.
pycompat: drop the pickle import
Apr 1 2022, 3:41 PM
mharbison72 closed D12420: pycompat: drop the pickle import.
Apr 1 2022, 3:41 PM
mharbison72 committed rHG225659936fff: util: restore the util.pickle symbol.
util: restore the util.pickle symbol
Apr 1 2022, 3:40 PM

Mar 30 2022

mharbison72 added inline comments to D12419: util: restore the util.pickle symbol.
Mar 30 2022, 1:49 AM
mharbison72 created D12421: util: drop a duplicate import.
Mar 30 2022, 1:46 AM
mharbison72 created D12423: tests: stop excluding the pycompat module from pyflakes.
Mar 30 2022, 1:46 AM
mharbison72 created D12419: util: restore the util.pickle symbol.
Mar 30 2022, 1:46 AM
mharbison72 created D12422: tests: drop some py2 specific pyflake failures.
Mar 30 2022, 1:46 AM
mharbison72 created D12420: pycompat: drop the pickle import.
Mar 30 2022, 1:46 AM

Mar 25 2022

mharbison72 closed D12401: pytype: disable a few errors about Windows specific module attributes.
Mar 25 2022, 11:43 AM
mharbison72 committed rHGd500df2e8034: pytype: disable a few errors about Windows specific module attributes.
pytype: disable a few errors about Windows specific module attributes
Mar 25 2022, 11:43 AM