Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 27

mharbison72 closed D11354: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
Fri, Aug 27, 5:26 AM
mharbison72 committed rHG769cd5703b2c: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
hg: don't attempt to extend `sys.path` with the user site without `APPDATA`
Fri, Aug 27, 5:26 AM

Thu, Aug 26

mharbison72 created D11354: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
Thu, Aug 26, 11:19 AM

Wed, Aug 25

mharbison72 committed rHG4162f6b40f2c: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
windows: degrade to py2 behavior when reading a non-symlink as a symlink
Wed, Aug 25, 9:15 AM
mharbison72 committed rHG95af358fcdfe: pyoxidizer: add user-site to `sys.path` on Windows.
pyoxidizer: add user-site to `sys.path` on Windows
Wed, Aug 25, 9:15 AM
mharbison72 committed rHGad2c37075f46: zeroconf: fix an issue concatenating bytes and str.
zeroconf: fix an issue concatenating bytes and str
Wed, Aug 25, 9:15 AM
mharbison72 closed D11308: pyoxidizer: add user-site to `sys.path` on Windows.
Wed, Aug 25, 6:08 AM
mharbison72 closed D11333: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
Wed, Aug 25, 6:08 AM
mharbison72 closed D11303: zeroconf: fix an issue concatenating bytes and str.
Wed, Aug 25, 6:08 AM
mharbison72 committed rHG9c67faf2e28e: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
windows: degrade to py2 behavior when reading a non-symlink as a symlink
Wed, Aug 25, 6:08 AM
mharbison72 committed rHGc18210649334: pyoxidizer: add user-site to `sys.path` on Windows.
pyoxidizer: add user-site to `sys.path` on Windows
Wed, Aug 25, 6:08 AM
mharbison72 committed rHG66f720b3dd98: zeroconf: fix an issue concatenating bytes and str.
zeroconf: fix an issue concatenating bytes and str
Wed, Aug 25, 6:08 AM

Mon, Aug 23

mharbison72 added a comment to D11308: pyoxidizer: add user-site to `sys.path` on Windows.

This looks good (i.e. similar to what is done in the ./hg script).
Do you think we could get a test for that in test-extensions ? (using a fake APPDATA for that part of the test) ?

I haven't quite got the test working yet (should foo.py in site-packages be loadable, or does it need a directory with __init__.py?). But I see that site.getuserpackages() is available on py3, and it would be easier to write a test against that with support for all platforms. But that should (probably?) go on default, especially since the non pyoxidizer path needs to be updated to stay in sync. So how about this for stable, and a rework on default that supports py3 everywhere.

You mean getting this specific patch for stable, without a test, and a more complete version for default, with a test ?

Mon, Aug 23, 10:12 AM

Sun, Aug 22

mharbison72 added a comment to D11308: pyoxidizer: add user-site to `sys.path` on Windows.

This looks good (i.e. similar to what is done in the ./hg script).
Do you think we could get a test for that in test-extensions ? (using a fake APPDATA for that part of the test) ?

Sun, Aug 22, 9:45 PM
mharbison72 created D11333: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
Sun, Aug 22, 7:39 PM
mharbison72 committed rHG155a2ec8a9dc: merge with stable.
merge with stable
Sun, Aug 22, 4:55 PM

Wed, Aug 18

mharbison72 created D11308: pyoxidizer: add user-site to `sys.path` on Windows.
Wed, Aug 18, 10:47 PM
D11298: pyoxidized: install fuzzywuzzy too is now accepted and ready to land.
Wed, Aug 18, 9:14 PM
mharbison72 added a comment to D11307: run-tests: avoid silently switching the hg executable used.

I seems a bit weird to be that we try to manually put self._bindir and self._hgcommand together while if I am not mistaken, they both originate from the splitting of some absolute path somewhere. So keeping that absolute path around would seems safer/cleaner to me. However I might be missing something.

Wed, Aug 18, 7:29 PM
mharbison72 added a comment to D11307: run-tests: avoid silently switching the hg executable used.

Not sure that we want to take this as-is (even though it does avoid a bad problem outside of the internal tests). I'm hoping someone has some insight and saves me some time trial and erroring through this.

Wed, Aug 18, 5:08 PM
mharbison72 created D11307: run-tests: avoid silently switching the hg executable used.
Wed, Aug 18, 5:00 PM
mharbison72 created D11303: zeroconf: fix an issue concatenating bytes and str.
Wed, Aug 18, 3:00 PM

Aug 18 2021

mharbison72 added inline comments to D11286: pyoxidized: add a dedicated target in the tests.
Aug 18 2021, 12:07 AM
mharbison72 added inline comments to D11284: pyoxidized: adapt test-devel-warnings.t.
Aug 18 2021, 12:06 AM

Aug 10 2021

mharbison72 closed D11278: ci: run --pyoxidized tests on Windows.
Aug 10 2021, 10:08 AM
mharbison72 committed rHG9261326dd032: ci: run --pyoxidized tests on Windows.
ci: run --pyoxidized tests on Windows
Aug 10 2021, 10:08 AM
mharbison72 closed D11275: contrib: switch the Windows bootstrap environment to py3.9.
Aug 10 2021, 9:32 AM
mharbison72 committed rHG3b04e4746020: contrib: switch the Windows bootstrap environment to py3.9.
contrib: switch the Windows bootstrap environment to py3.9
Aug 10 2021, 9:32 AM
mharbison72 closed D11274: contrib: comment out the 64-bit py38 dependency installation on Windows.
Aug 10 2021, 9:32 AM
mharbison72 closed D11273: contrib: drop python2.7 from the Windows dependency install script.
Aug 10 2021, 9:32 AM
mharbison72 committed rHG7f220c6f3c81: contrib: drop python2.7 from the Windows dependency install script.
contrib: drop python2.7 from the Windows dependency install script
Aug 10 2021, 9:32 AM
mharbison72 committed rHG7a0d7c34e0ab: contrib: comment out the 64-bit py38 dependency installation on Windows.
contrib: comment out the 64-bit py38 dependency installation on Windows
Aug 10 2021, 9:32 AM
mharbison72 closed D11272: contrib: log the command and args for every process installing windows deps.
Aug 10 2021, 9:32 AM
mharbison72 committed rHGfb7d17496aca: contrib: log the command and args for every process installing windows deps.
contrib: log the command and args for every process installing windows deps
Aug 10 2021, 9:31 AM

Aug 9 2021

mharbison72 created D11275: contrib: switch the Windows bootstrap environment to py3.9.
Aug 9 2021, 8:46 PM
mharbison72 created D11274: contrib: comment out the 64-bit py38 dependency installation on Windows.
Aug 9 2021, 8:46 PM
mharbison72 created D11273: contrib: drop python2.7 from the Windows dependency install script.
Aug 9 2021, 8:46 PM
mharbison72 created D11272: contrib: log the command and args for every process installing windows deps.
Aug 9 2021, 8:46 PM

Aug 7 2021

mharbison72 added a comment to D11261: ci: backed out changeset 2fb4bd5f773f.

Pruned because D11255 was pruned

Aug 7 2021, 3:22 PM
mharbison72 added a comment to D11255: windows-ci: temporarily disable test-censor.t.

Pruned because the issue is fixed by D11260

Aug 7 2021, 3:22 PM
mharbison72 added a comment to D11266: test-pager: properly mark a line as optional.

Folded into D11257

Aug 7 2021, 3:11 PM

Aug 2 2021

mharbison72 added a comment to D11240: windows: avoid a bytes vs unicode crash reading passwords on py2.

This got published as 064cd182555f, without the differential URL. Probably another reviewer needs to accept/close it, because that's not an option for me.

Aug 2 2021, 8:54 PM
mharbison72 committed rHGa11520e66ade: typing: add several assertions to dirstatemap to appease pytype.
typing: add several assertions to dirstatemap to appease pytype
Aug 2 2021, 12:47 PM
mharbison72 committed rHG064cd182555f: windows: avoid a bytes vs unicode crash reading passwords on py2.
windows: avoid a bytes vs unicode crash reading passwords on py2
Aug 2 2021, 12:47 PM
mharbison72 created D11240: windows: avoid a bytes vs unicode crash reading passwords on py2.
Aug 2 2021, 11:00 AM

Jul 30 2021

mharbison72 added inline comments to D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Jul 30 2021, 2:11 PM
mharbison72 closed D11235: typing: add several assertions to dirstatemap to appease pytype.
Jul 30 2021, 11:11 AM
mharbison72 committed rHG460e479be66e: typing: add several assertions to dirstatemap to appease pytype.
typing: add several assertions to dirstatemap to appease pytype
Jul 30 2021, 11:11 AM
mharbison72 created D11235: typing: add several assertions to dirstatemap to appease pytype.
Jul 30 2021, 1:13 AM

Jul 29 2021

mharbison72 added inline comments to D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Jul 29 2021, 11:16 PM
mharbison72 added a comment to D11231: tests: add explicit coverage for update_hash_refs from rewriteutil.

I couldn't find any evidence this is covered by tests in core

Jul 29 2021, 11:07 PM
mharbison72 added inline comments to D11163: largefile: use `set_possibly_dirty` instead of `normallookup`.
Jul 29 2021, 10:00 PM
mharbison72 added inline comments to D11132: dirstate: factor out the part retrieve "filedata" out of `normal`.
Jul 29 2021, 9:46 PM
mharbison72 added inline comments to D11088: dirstate-v2: Introduce a docket file.
Jul 29 2021, 9:32 PM

Jul 22 2021

mharbison72 closed D11206: typing: convert an annotation to an assertion in commands.py.
Jul 22 2021, 1:07 PM
mharbison72 closed D11207: upgrade: byteify an i18n message.
Jul 22 2021, 1:07 PM
mharbison72 committed rHG6b9ad3a0c348: upgrade: byteify an i18n message.
upgrade: byteify an i18n message
Jul 22 2021, 1:07 PM
mharbison72 committed rHG76dccbbe73fd: typing: convert an annotation to an assertion in commands.py.
typing: convert an annotation to an assertion in commands.py
Jul 22 2021, 1:07 PM

Jul 21 2021

mharbison72 added a comment to D11207: upgrade: byteify an i18n message.

file is not bytes, so this will crash, will it not ?

Jul 21 2021, 5:31 PM
mharbison72 created D11206: typing: convert an annotation to an assertion in commands.py.
Jul 21 2021, 4:07 PM
mharbison72 created D11207: upgrade: byteify an i18n message.
Jul 21 2021, 4:07 PM

Jul 18 2021

mharbison72 committed rHG0caac68a5c3c: doc: wrap the help text for the purge extension.
doc: wrap the help text for the purge extension
Jul 18 2021, 6:05 AM
mharbison72 closed D11036: doc: wrap the help text for the purge extension.
Jul 18 2021, 6:05 AM

Jul 11 2021

mharbison72 added inline comments to D11081: run-test: rework the redirection script for python on windows.
Jul 11 2021, 7:54 PM
mharbison72 added inline comments to D11049: run-tests: introduce a `HGTEST_REAL_HG` variable for test.
Jul 11 2021, 7:35 PM
D11046: run-test: clarify the error with a bad --with-hg is passed now requires changes to proceed.
Jul 11 2021, 7:29 PM
mharbison72 added a comment to D11025: ci-windows: introduce manual windows CI.

I assume the various things that I was installing in before_script are now baked into to the docker image/runner host? (That's good, it was my intention. But the TEMP variable hack made me wonder if maybe it wasn't yet.)

Yes they are.

I'm also a bit surprised you haven't hit any issues by leaving out the make local bits.

I don't know what error you were getting without --local, but the latest run are doing without it. I made a bunch of fixes to run-tests.py that might have helped (and there will be more)

Jul 11 2021, 2:02 PM

Jul 10 2021

mharbison72 added a comment to D11025: ci-windows: introduce manual windows CI.

I assume the various things that I was installing in before_script are now baked into to the docker image/runner host? (That's good, it was my intention. But the TEMP variable hack made me wonder if maybe it wasn't yet.)

Jul 10 2021, 7:18 PM
mharbison72 added inline comments to D11057: compat: enforce upper case drive letter in mercurial too.
Jul 10 2021, 4:38 PM

Jul 9 2021

mharbison72 added a comment to D11035: run-tests: enforce the drive letter from `getcwd` to upper case.

Does the issue happen with 3.7? I'm wondering if this is the normalization they started to do in os.path.realpath(). See 3dfebba99ef6

Jul 9 2021, 1:02 PM
mharbison72 created D11036: doc: wrap the help text for the purge extension.
Jul 9 2021, 11:45 AM
mharbison72 added a comment to D10693: run-tests: fix whitelist/blacklist with directories on Windows.

This landed as dff19fe2973c, but lacked the Differential URL in the commit comment somehow. It may have gotten pulled off of the Windows CI work on heptapod.

Jul 9 2021, 11:31 AM
mharbison72 added a comment to D10692: run-tests: ignore PermissionError when checking available ports.

This landed as 6e0af81c43b2, but lacked the Differential URL in the commit comment somehow. It may have gotten pulled off of the Windows CI work on heptapod.

Jul 9 2021, 11:25 AM
mharbison72 added a comment to D10693: run-tests: fix whitelist/blacklist with directories on Windows.

It looks like this never landed.

Jul 9 2021, 11:13 AM
mharbison72 added inline comments to D11000: windows: add windows behavior on broken pager.
Jul 9 2021, 11:08 AM

Jul 8 2021

mharbison72 added a comment to D11000: windows: add windows behavior on broken pager.

Is there any more context you can/want to supply about the bug, what's better about Windows, the rabbit hole, etc?

Jul 8 2021, 12:01 PM

Jul 3 2021

mharbison72 added inline comments to D10936: cmdutil: fix newandmodified file accounting for --interactive commits.
Jul 3 2021, 12:21 AM

Jun 24 2021

mharbison72 committed rHG75d4e60c7c81: purge: restore the `testedwith` declaration.
purge: restore the `testedwith` declaration
Jun 24 2021, 4:18 AM
mharbison72 closed D10895: purge: restore the `testedwith` declaration.
Jun 24 2021, 4:18 AM

Jun 23 2021

mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

We have talked internally at work about some kind of interactive hg absorb that lets you decide which commit each line should go into. That sounds similar to what you're thinking of.

Jun 23 2021, 1:22 AM

Jun 22 2021

mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.
Jun 22 2021, 8:39 PM
mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

This is indeed a very important quality-of-life feature and I'm +1 on adding it to Mercurial.

Jun 22 2021, 6:13 PM
mharbison72 created D10895: purge: restore the `testedwith` declaration.
Jun 22 2021, 1:25 PM

Jun 21 2021

mharbison72 added a comment to D10870: typing: disable warnings for a couple of Windows specific attributes.

Can this get grafted to stable? It goes with 5b3513177f2b. I'm not sure why the stable branch wasn't flagged in phab, because that's where the obsolete commit is in my repo.

Jun 21 2021, 11:13 PM

Jun 17 2021

mharbison72 closed D10870: typing: disable warnings for a couple of Windows specific attributes.
Jun 17 2021, 9:31 AM
mharbison72 committed rHGf77404040776: typing: disable warnings for a couple of Windows specific attributes.
typing: disable warnings for a couple of Windows specific attributes
Jun 17 2021, 9:31 AM
mharbison72 closed D10876: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
Jun 17 2021, 9:31 AM
mharbison72 committed rHGbe903d043099: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
typing: suppress a false error in mercurial/revlogutils/docket.py on py2
Jun 17 2021, 9:31 AM

Jun 15 2021

mharbison72 closed D10873: py3: byteify the version string passed to the deprecation warning method.
Jun 15 2021, 2:56 PM
mharbison72 closed D10875: revlog: byteify a few error strings.
Jun 15 2021, 2:56 PM
mharbison72 closed D10874: revlog: fix a typo closing the wrong file.
Jun 15 2021, 2:56 PM
mharbison72 committed rHG5fbac82a8780: revlog: byteify a few error strings.
revlog: byteify a few error strings
Jun 15 2021, 2:56 PM
mharbison72 committed rHG5e44936b82be: revlog: fix a typo closing the wrong file.
revlog: fix a typo closing the wrong file
Jun 15 2021, 2:56 PM
mharbison72 closed D10872: urlutil: byteify several localized messages.
Jun 15 2021, 2:56 PM
mharbison72 committed rHGc887bab2dccf: py3: byteify the version string passed to the deprecation warning method.
py3: byteify the version string passed to the deprecation warning method
Jun 15 2021, 2:56 PM
mharbison72 committed rHG515014d72aa2: urlutil: byteify several localized messages.
urlutil: byteify several localized messages
Jun 15 2021, 2:56 PM
mharbison72 closed D10871: urlutil: use the deprecation warning function on the `ui` object.
Jun 15 2021, 2:56 PM
mharbison72 committed rHG65333ecc8b34: urlutil: use the deprecation warning function on the `ui` object.
urlutil: use the deprecation warning function on the `ui` object
Jun 15 2021, 2:56 PM

Jun 12 2021

mharbison72 created D10876: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
Jun 12 2021, 2:51 PM
mharbison72 created D10873: py3: byteify the version string passed to the deprecation warning method.
Jun 12 2021, 12:57 AM