Page MenuHomePhabricator
Feed Advanced Search

Today

mharbison72 added a comment to D8337: pycompat: change argv conversion semantics.

This looks like it also fixes the phabricator test on Windows, which diverged by creating a different hash for the create alpha for phabricator test € commit.

Mon, Mar 30, 1:09 AM
mharbison72 added a comment to D8345: tests: look for CRLF on Windows.

The test harness *should* match existing \n output as a fallback, which got me to wondering if it was the (esc) at the end screwing it up. I tried this patch:

Mon, Mar 30, 12:51 AM

Yesterday

mharbison72 updated the diff for D8314: phabricator: add an option to fold several commits into one review (issue6244).
Sun, Mar 29, 12:58 AM
mharbison72 updated the diff for D8313: phabricator: extract logic to print the status when posting a commit.
Sun, Mar 29, 12:57 AM
mharbison72 updated the diff for D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
Sun, Mar 29, 12:57 AM
mharbison72 updated the diff for D8312: phabricator: extract the logic to amend diff properties to a function.
Sun, Mar 29, 12:57 AM
mharbison72 updated the diff for D8310: phabricator: teach createdifferentialrevision() to allow a folded commit range.
Sun, Mar 29, 12:57 AM
mharbison72 updated the diff for D8309: phabricator: combine commit messages into the review when folding commits.
Sun, Mar 29, 12:57 AM
mharbison72 updated the diff for D8308: phabricator: record all local commits used to create a Differential revision.
Sun, Mar 29, 12:57 AM
mharbison72 added a comment to D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.

Could you add a comment about what happens if you hg split either the base or the tip of the range?

I think what happens is each newnode key maps to a single precursor, so it's like a regular amend case. It just happens that multiple newnode keys have the same oldnode in their value tuple. But all we care about is the first and last newnode in the range.
That said, I tried creating a simple test where I amended in a new file to the last commit of the last test, split it with the internal extension, and... Somehow I ended up with a weird state where the first half of the split is pruned...

Sun, Mar 29, 12:53 AM

Thu, Mar 26

mharbison72 closed D8307: phabricator: account for `basectx != ctx` when calculating renames.
Thu, Mar 26, 6:51 AM
mharbison72 closed D8306: phabricator: add basectx arguments to file related `phabsend` utilities.
Thu, Mar 26, 6:51 AM
mharbison72 closed D8305: phabricator: eliminate a couple of duplicate filectx lookups.
Thu, Mar 26, 6:51 AM
mharbison72 committed rHG022bf71515c9: phabricator: account for `basectx != ctx` when calculating renames.
phabricator: account for `basectx != ctx` when calculating renames
Thu, Mar 26, 6:51 AM
mharbison72 committed rHG53d75fdeaaaa: phabricator: add basectx arguments to file related `phabsend` utilities.
phabricator: add basectx arguments to file related `phabsend` utilities
Thu, Mar 26, 6:51 AM
mharbison72 committed rHG7b9aaec17126: phabricator: eliminate a couple of duplicate filectx lookups.
phabricator: eliminate a couple of duplicate filectx lookups
Thu, Mar 26, 6:50 AM

Wed, Mar 25

mharbison72 accepted D8331: py3: make setup.py's hgcommand() consistently return bytes.
Wed, Mar 25, 11:48 PM
mharbison72 updated subscribers of D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.

Could you add a comment about what happens if you hg split either the base or the tip of the range?

Wed, Mar 25, 11:42 PM
mharbison72 added a comment to D8317: cext: move more variable declarations to the top of the block for C89 support.

Duplicate of 0424a9134bcf

Wed, Mar 25, 4:41 PM
mharbison72 added a comment to D8306: phabricator: add basectx arguments to file related `phabsend` utilities.

I am very curious as to how the UI will look on a folded series.

Wed, Mar 25, 4:40 PM
mharbison72 added a comment to D8330: cext: move more variable declarations to the top of the block for C89 support.

This was a test run of phabsend --fold to show what the UI looks like. It's a fold of D8317 and D8318 (with the URLs removed).

Wed, Mar 25, 4:36 PM
mharbison72 created D8330: cext: move more variable declarations to the top of the block for C89 support.
Wed, Mar 25, 4:34 PM

Tue, Mar 24

mharbison72 closed D8318: setup: build C extensions with -Werror=declaration-after-statement.
Tue, Mar 24, 8:56 AM
mharbison72 committed rHG2a98b0cd4995: setup: build C extensions with -Werror=declaration-after-statement.
setup: build C extensions with -Werror=declaration-after-statement
Tue, Mar 24, 8:56 AM

Sat, Mar 21

mharbison72 updated the diff for D8318: setup: build C extensions with -Werror=declaration-after-statement.
Sat, Mar 21, 2:22 PM

Fri, Mar 20

mharbison72 added a comment to D8304: cext: move variable declaration to the top of the block for C89 support.

Great, @mharbison72 can you submit a patch ?

Fri, Mar 20, 11:56 PM
mharbison72 created D8318: setup: build C extensions with -Werror=declaration-after-statement.
Fri, Mar 20, 11:55 PM
mharbison72 created D8317: cext: move more variable declarations to the top of the block for C89 support.
Fri, Mar 20, 11:55 PM
mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

What's the status of this ? @mharbison72 id the linking problem got solved ?

Fri, Mar 20, 10:50 PM
mharbison72 added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.
  • I'm *not* expecting to do anything about \ -> / conversion.
Fri, Mar 20, 10:44 PM
mharbison72 created D8314: phabricator: add an option to fold several commits into one review (issue6244).
Fri, Mar 20, 5:25 PM
mharbison72 created D8313: phabricator: extract logic to print the status when posting a commit.
Fri, Mar 20, 5:24 PM
mharbison72 created D8312: phabricator: extract the logic to amend diff properties to a function.
Fri, Mar 20, 5:24 PM
mharbison72 created D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
Fri, Mar 20, 5:24 PM
mharbison72 created D8310: phabricator: teach createdifferentialrevision() to allow a folded commit range.
Fri, Mar 20, 5:24 PM
mharbison72 created D8309: phabricator: combine commit messages into the review when folding commits.
Fri, Mar 20, 5:24 PM
mharbison72 created D8308: phabricator: record all local commits used to create a Differential revision.
Fri, Mar 20, 5:24 PM
mharbison72 created D8307: phabricator: account for `basectx != ctx` when calculating renames.
Fri, Mar 20, 5:24 PM
mharbison72 created D8306: phabricator: add basectx arguments to file related `phabsend` utilities.
Fri, Mar 20, 5:24 PM
mharbison72 created D8305: phabricator: eliminate a couple of duplicate filectx lookups.
Fri, Mar 20, 5:24 PM
mharbison72 closed D8233: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate.
Fri, Mar 20, 12:40 PM
mharbison72 committed rHGa7f8c657a3f0: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate.
phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate
Fri, Mar 20, 12:39 PM
mharbison72 added a comment to D8304: cext: move variable declaration to the top of the block for C89 support.
In D8304#124116, @yuja wrote:
Could we enable some kind of warning to catch this in the tests ?

-Wdeclaration-after-statement for gcc and maybe clang.

Fri, Mar 20, 11:09 AM
mharbison72 added a comment to D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.
In D8232#124097, @yuja wrote:

+def _getdrevs(ui, stack, *specs):
+ """convert user supplied DREVSPECs into "Differential Revision" dicts
+
+ See `hg help phabread` for how to specify each DREVSPEC.
+ """
+ if len(*specs) > 0:

^^^^^^

Fixed bad argument expansion since I had to rebase this. Please let me
know if that's wrong.

Never mind. Maybe specs is a list containing a single list, in which case,
the code is valid.

Fri, Mar 20, 10:50 AM
mharbison72 closed D8304: cext: move variable declaration to the top of the block for C89 support.
Fri, Mar 20, 10:37 AM
mharbison72 committed rHG3122058df7a5: cext: move variable declaration to the top of the block for C89 support.
cext: move variable declaration to the top of the block for C89 support
Fri, Mar 20, 10:37 AM
mharbison72 added a comment to D8304: cext: move variable declaration to the top of the block for C89 support.

Could we enable some kind of warning to catch this in the tests ?

Fri, Mar 20, 10:36 AM
mharbison72 added a comment to D8304: cext: move variable declaration to the top of the block for C89 support.

This is needed on stable to fix the build.

Fri, Mar 20, 10:07 AM
mharbison72 created D8304: cext: move variable declaration to the top of the block for C89 support.
Fri, Mar 20, 10:06 AM
mharbison72 updated the diff for D8233: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate.
Fri, Mar 20, 9:58 AM
mharbison72 committed rHG90adda73676a: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.
phabricator: add a helper function to convert DREVSPECs to a DREV dict list
Fri, Mar 20, 4:45 AM
mharbison72 closed D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.
Fri, Mar 20, 4:25 AM
mharbison72 committed rHG6d5db16f6195: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.
phabricator: add a helper function to convert DREVSPECs to a DREV dict list
Fri, Mar 20, 4:25 AM

Thu, Mar 19

mharbison72 closed D8303: tests: avoid logging a commit with a Unicode character in test-phabricator.t.
Thu, Mar 19, 4:15 PM
mharbison72 committed rHG2ec6160449aa: tests: avoid logging a commit with a Unicode character in test-phabricator.t.
tests: avoid logging a commit with a Unicode character in test-phabricator.t
Thu, Mar 19, 4:15 PM
mharbison72 created D8303: tests: avoid logging a commit with a Unicode character in test-phabricator.t.
Thu, Mar 19, 3:01 PM

Wed, Mar 18

mharbison72 added a comment to D8301: phabricator: remove duplicated byteskwargs conversion.

Thanks, I just hit this myself.

Wed, Mar 18, 4:26 PM

Mon, Mar 16

mharbison72 added a comment to D8284: fix: disallow `hg fix --all --working-dir`.

If --working-dir and --all are redundant, I don't see anyharm in allowing both to be passed.

The idea was to inform users that they're doing something that's a little weird, in case they were hoping for it to do something else. I don't care much and I'm fine with dropping this patch if that's the consensus.

If the intend is to inform, maybe we could issue a warning?

Makes sense. I suppose we should do the same for --all and --rev REV in that case. We currently consider that an error. I don't care much about this issue, so I'll just move this patch to the side for now. That way the rest of the stack (which I care about) can be queued independently.

Mon, Mar 16, 9:56 PM
mharbison72 added a comment to D6735: update: added support for --abort flag(issue4404).

Here's a case I stumbled upon that is a problem. It looks like it thinks it isn't in the middle of an update, but .hgsubstate isn't put back to the pre-update state.

diff --git a/tests/test-subrepo.t b/tests/test-subrepo.t
--- a/tests/test-subrepo.t
+++ b/tests/test-subrepo.t
@@ -1027,10 +1027,38 @@ filesystem (see also issue4583))
   > [extensions]
   > fakedirstatewritetime = $TESTDIR/fakedirstatewritetime.py
   > EOF
+  $ hg -R repo st -S
+  ? s/b
+  $ hg -R repo diff -S
+  $ hg -R repo log -r .
+  changeset:   0:c4018e9aea1b
+  user:        test
+  date:        Thu Jan 01 00:00:00 1970 +0000
+  summary:     1
+
+  $ cat repo/.hgsubstate
+  f7b1eb17ad24730a1651fccd46c43826d1bbc2ac s
   $ hg -R repo update
   b: untracked file differs
   abort: untracked files in working directory differ from files in requested revision (in subrepository "s")

@mharbison72 I am bit confused here.

  1. Since hg -R repo update resulted with an abort then why we have dirty working directory now? Isn't transaction rollback worked correctly?
Mon, Mar 16, 6:45 PM

Fri, Mar 13

mharbison72 accepted D8293: rebase: accept multiple --base arguments (BC).
Fri, Mar 13, 11:43 PM
mharbison72 accepted D8292: rebase: accept multiple --source arguments (BC).
Fri, Mar 13, 11:43 PM
mharbison72 added a comment to D8295: rebase: mention -r argument in synopsis.

Weird, I thought this was dependent on evolve too. But I guess if that were really the case, it would have be implemented in a wrapper in evolve. I suppose it works without evolve if using --keep, but I never use that.

Fri, Mar 13, 11:42 PM
mharbison72 added inline comments to D8293: rebase: accept multiple --base arguments (BC).
Fri, Mar 13, 9:45 PM
mharbison72 accepted D8292: rebase: accept multiple --source arguments (BC).
Fri, Mar 13, 9:35 PM
mharbison72 accepted D8291: rebase: remove unused defaults argument values from _definedestmap().
Fri, Mar 13, 9:25 PM
mharbison72 closed D8137: phabricator: add a config knob to import in the secret phase.
Fri, Mar 13, 8:38 PM
mharbison72 closed D8136: phabricator: add a `phabimport` command.
Fri, Mar 13, 8:38 PM
mharbison72 closed D8138: phabricator: add a config knob to create obsolete markers when importing.
Fri, Mar 13, 8:38 PM
mharbison72 committed rHGf10055b099b3: phabricator: add a config knob to create obsolete markers when importing.
phabricator: add a config knob to create obsolete markers when importing
Fri, Mar 13, 8:38 PM
mharbison72 committed rHG9bae1d1a0f4c: phabricator: add a config knob to import in the secret phase.
phabricator: add a config knob to import in the secret phase
Fri, Mar 13, 8:37 PM
mharbison72 committed rHGbbb170f9396d: phabricator: add a `phabimport` command.
phabricator: add a `phabimport` command
Fri, Mar 13, 8:37 PM
mharbison72 accepted D8287: fix: add a -s option to format a revision and its descendants.
Fri, Mar 13, 7:31 PM
mharbison72 accepted D8288: fix: mark -r as advanced.
Fri, Mar 13, 6:41 PM
mharbison72 added a comment to D8287: fix: add a -s option to format a revision and its descendants.

Thanks for this!

Fri, Mar 13, 6:41 PM
mharbison72 accepted D8286: fix: move handling of --all into getrevstofix() for consistency.
Fri, Mar 13, 6:22 PM
mharbison72 accepted D8285: fix: refactor getrevstofix() to define revisions first, then validate them.
Fri, Mar 13, 6:16 PM
mharbison72 accepted D8283: tests: simplify test-fix-topology.t slightly by using a `(case !)`.
Fri, Mar 13, 6:08 PM
mharbison72 accepted D8284: fix: disallow `hg fix --all --working-dir`.
Fri, Mar 13, 6:08 PM
mharbison72 added a comment to D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.

This seems like something that can easily have a few simple unit tests

Fri, Mar 13, 1:49 PM
mharbison72 accepted D8280: tests: make test-doctest.t module list match reality.
Fri, Mar 13, 12:54 PM
mharbison72 added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.

The Windows path changes seem like a good idea.
Would quoting paths with commas eliminate the need for custom escaping? I don't feel strongly about it, but custom escaping always feels weird to me. (I fact, a coworker did some homebrew escaping for CSV files a few days ago, but I forget how it ultimately ended up.)

Let me play with that a bit, I think it'll work and be detectable on the server since the first character can't currently be a double-quote, so there wouldn't really be any BC issues aside from the pconvert (which wouldn't be as important anymore, but still probably a good idea?)

Fri, Mar 13, 9:57 AM
mharbison72 accepted D8282: tests: consistently put #testcases at beginning of file.
Fri, Mar 13, 9:52 AM
mharbison72 added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.

The Windows path changes seem like a good idea.

Fri, Mar 13, 1:13 AM
D8280: tests: make test-doctest.t module list match reality now requires changes to proceed.

It looks like test-run-tests.py and i18n/check-translation.py have a test too. (Not sure if we care about them; I mostly care about Windows.)

Fri, Mar 13, 1:06 AM

Wed, Mar 11

mharbison72 committed rHG20d74eebe56c: tests: drop an extraneous (glob) from test-debugbackupbundle.t.
tests: drop an extraneous (glob) from test-debugbackupbundle.t
Wed, Mar 11, 4:10 PM
mharbison72 committed rHGb08bea3f9a1f: tests: drop an extraneous (glob) from test-debugbackupbundle.t.
tests: drop an extraneous (glob) from test-debugbackupbundle.t
Wed, Mar 11, 3:16 PM
mharbison72 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I think it might be better to poll more often in the script and not even take a timeout: sleep forever waiting for the condition, and if it never comes let the test timeout at the runner level. Thoughts?

I filed a bug about this that self-archived, but:

$ echo '  $ sleep 10' > test-timeout.t
$ time ./run-tests.py --local test-timeout.t -t 5
running 1 tests using 1 parallel processes
t
Failed test-timeout.t: timed out
# Ran 1 tests, 0 skipped, 1 failed.
python hash seed: 204038743
real    0m10.363s
user    0m0.000s
sys     0m0.030s

So it looks like tests never timeout, but then the result is discarded afterward if the timeout period elapsed. I can reproduce it on Windows and macOS.

Do you have a link to the bug ?

Wed, Mar 11, 2:53 PM
mharbison72 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I think it might be better to poll more often in the script and not even take a timeout: sleep forever waiting for the condition, and if it never comes let the test timeout at the runner level. Thoughts?

Wed, Mar 11, 2:04 PM
mharbison72 closed D8269: tests: drop an extraneous (glob) from test-debugbackupbundle.t.
Wed, Mar 11, 12:49 PM
mharbison72 committed rHGcae7cddef4b0: tests: drop an extraneous (glob) from test-debugbackupbundle.t.
tests: drop an extraneous (glob) from test-debugbackupbundle.t
Wed, Mar 11, 12:49 PM
mharbison72 added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

Wed, Mar 11, 12:04 AM

Tue, Mar 10

mharbison72 added inline comments to D7932: debugbackupbundle: introduce command to interact with strip backups.
Tue, Mar 10, 3:02 PM

Mon, Mar 9

mharbison72 created D8269: tests: drop an extraneous (glob) from test-debugbackupbundle.t.
Mon, Mar 9, 9:38 PM
mharbison72 added inline comments to D8268: git: don't fail import when pygit2 is not install.
Mon, Mar 9, 6:37 PM
mharbison72 accepted D8267: hghave: add a check for pygit2.
Mon, Mar 9, 6:30 PM

Sun, Mar 8

mharbison72 added inline comments to D8265: git: key off `git` in .hg/requires rather than separate file.
Sun, Mar 8, 12:12 AM

Fri, Mar 6

mharbison72 updated the diff for D8233: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate.
Fri, Mar 6, 11:05 AM
mharbison72 updated the summary of D8136: phabricator: add a `phabimport` command.
Fri, Mar 6, 11:04 AM
mharbison72 updated the diff for D8137: phabricator: add a config knob to import in the secret phase.
Fri, Mar 6, 11:04 AM
mharbison72 updated the diff for D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.
Fri, Mar 6, 11:04 AM