Page MenuHomePhabricator
Feed Advanced Search

Nov 26 2020

mharbison72 committed rHGcb728894f91d: helptext: fix sentence in extensions documentation.
helptext: fix sentence in extensions documentation
Nov 26 2020, 8:15 AM
mharbison72 committed rHG62329b759635: packaging: regenerate the Windows requirements manifest on Windows.
packaging: regenerate the Windows requirements manifest on Windows
Nov 26 2020, 8:15 AM
mharbison72 closed D9406: pyoxidizer: point to the py3 requirements instead of py2 on Windows.
Nov 26 2020, 8:15 AM
mharbison72 closed D9404: packaging: regenerate the Windows requirements manifest on Windows.
Nov 26 2020, 8:15 AM
mharbison72 committed rHG926c7ed47ab0: pyoxidizer: point to the py3 requirements instead of py2 on Windows.
pyoxidizer: point to the py3 requirements instead of py2 on Windows
Nov 26 2020, 8:15 AM
mharbison72 created D9406: pyoxidizer: point to the py3 requirements instead of py2 on Windows.
Nov 26 2020, 3:17 AM
mharbison72 updated the summary of D9405: packaging: add pygit2 to the py3 Windows installers.
Nov 26 2020, 3:17 AM
mharbison72 added a comment to D9405: packaging: add pygit2 to the py3 Windows installers.

the PyOxidizer target looks in the py2.txt file for requirements instead of py3

Nov 26 2020, 2:59 AM
mharbison72 created D9405: packaging: add pygit2 to the py3 Windows installers.
Nov 26 2020, 2:55 AM
mharbison72 created D9404: packaging: regenerate the Windows requirements manifest on Windows.
Nov 26 2020, 2:55 AM
mharbison72 added a comment to D9267: crecord: render chunkpad on Windows (issue6427).

I didn't realize this was available on Windows. Is this stable enough that we could add it to the packaging, so that tweakdefaults is consistent across platforms? I just discovered the interface on Linux, and it is so much nicer than the default -i menu.

Nov 26 2020, 1:05 AM

Nov 25 2020

D9401: pyoxidizer: make sure defaultrc directory exists before trying to write to it is now accepted and ready to land.
Nov 25 2020, 7:09 PM
D9360: commands: fix checking of share safe requirement on `config --shared` is now accepted and ready to land.
Nov 25 2020, 5:31 PM
D9359: dispatch: pass root path in ui.readconfig() as root of main repo is now accepted and ready to land.
Nov 25 2020, 5:31 PM
D9357: scmutil: try-delete `.hg/store/requires` if store requirements are empty is now accepted and ready to land.
Nov 25 2020, 5:31 PM
mharbison72 added inline comments to D9401: pyoxidizer: make sure defaultrc directory exists before trying to write to it.
Nov 25 2020, 5:14 PM
mharbison72 added a comment to D9387: errors: raise InputError on early parse error in dispatch.

If this is purely from --config instead of a file and you're collecting metrics, would you want this to be an InputError? (I'm happy to queue this as-is, I just wanted to double check)

Nov 25 2020, 5:10 PM
mharbison72 added a comment to D9391: errors: raise StateError when push fails because it creates new heads.

I decided to raise InputError here because the user should adapt

Nov 25 2020, 5:07 PM
D9388: errors: raise InputError on bad top-level flags is now accepted and ready to land.
Nov 25 2020, 5:01 PM
D9393: errors: raise StateError on uncommitted changes when merge starts is now accepted and ready to land.
Nov 25 2020, 4:52 PM
D9392: errors: raise StateError when there are unresolves merge conflicts is now accepted and ready to land.
Nov 25 2020, 4:52 PM
D9390: errors: introduce SecurityError and use it in a few places is now accepted and ready to land.
Nov 25 2020, 4:52 PM
D9389: errors: raise InputError when too few arguments given to alias is now accepted and ready to land.
Nov 25 2020, 4:52 PM
D9385: errors: raise InputError on bad bookmark argument is now accepted and ready to land.

Queued to here, thanks

Nov 25 2020, 1:34 AM
D9384: errors: raise ConfigError on bad alias definition is now accepted and ready to land.
Nov 25 2020, 1:34 AM
D9383: errors: raise InputError on bad repo arguments is now accepted and ready to land.
Nov 25 2020, 1:34 AM
D9382: errors: drop trailing "!" for some errors about bookmarks is now accepted and ready to land.
Nov 25 2020, 1:34 AM
D9381: errors: remove trailing "!" in messages about bad top-level args is now accepted and ready to land.
Nov 25 2020, 1:34 AM
D9380: errors: remove trailing "!" in messages about creating new heads on push is now accepted and ready to land.
Nov 25 2020, 1:34 AM
D9379: errors: consistently don't use trailing "!" in "not found in manifest" message is now accepted and ready to land.
Nov 25 2020, 1:34 AM
mharbison72 added inline comments to D9386: errors: raise more specifc errors from narrowcommands.
Nov 25 2020, 1:29 AM
D9378: errors: remove trailing "!" from some error messages for consistency is now accepted and ready to land.
Nov 25 2020, 1:12 AM
mharbison72 added a comment to D9371: bisect: use tuple literal instead of split on string literal.

Queued, up to here, thanks.

Nov 25 2020, 12:42 AM
D9370: hgignore: add VS Code config is now accepted and ready to land.
Nov 25 2020, 12:41 AM
D9371: bisect: use tuple literal instead of split on string literal is now accepted and ready to land.
Nov 25 2020, 12:41 AM
mharbison72 added inline comments to D9374: bisect: add a `--rev` flag.
Nov 25 2020, 12:38 AM
mharbison72 added inline comments to D9372: bisect: refactor to work on a list of revspecs.
Nov 25 2020, 12:31 AM
mharbison72 created D9396: packaging: drop Disco (19.04) and add Focal (20.04).
Nov 25 2020, 12:14 AM
mharbison72 created D9395: make: drop Trusty and Artful targets.
Nov 25 2020, 12:14 AM
mharbison72 created D9394: packaging: add `HG_DOCKER_OWN_USER` to `dockerdeb` like exists in `dockerrpm`.
Nov 25 2020, 12:14 AM

Nov 24 2020

D9377: tests: make test-worker.t pass on py2 is now accepted and ready to land.
Nov 24 2020, 4:33 PM
D9376: tests: update test-https.t's #no-defaultcacertsloaded block with new exit code is now accepted and ready to land.
Nov 24 2020, 4:33 PM
D9365: chg: fix test-check-clang-format.t failure is now accepted and ready to land.
Nov 24 2020, 4:33 PM

Nov 23 2020

mharbison72 created D9375: ui: ensure `getpass()` returns bytes.
Nov 23 2020, 12:26 PM
mharbison72 added a comment to D9288: share: fix a typo in a safe share error message.

Superseded by D9360

Nov 23 2020, 11:53 AM
mharbison72 added a comment to D9356: phabricator: allow local revisions to be specified with `phabupdate`.

This seems like the right choice to me, confusing the local and remote revisions would be bad.

Nov 23 2020, 10:37 AM

Nov 22 2020

mharbison72 added a comment to D9368: exthelper: update the examples to be python3 complaint.

I accidentally interrupted phabsend with this series, so let me know if there are issue importing it. It looks like it's all here, and only that I don't have the URL embedded locally.

Nov 22 2020, 3:11 PM
mharbison72 created D9368: exthelper: update the examples to be python3 complaint.
Nov 22 2020, 3:08 PM
mharbison72 created D9367: helptext: byteify extensions examples.
Nov 22 2020, 3:08 PM
mharbison72 created D9366: helptext: fix sentence in extensions documentation.
Nov 22 2020, 3:08 PM
mharbison72 closed D9363: extensions: gracefully warn when doing min version check with no local version.
Nov 22 2020, 12:57 PM
mharbison72 committed rHGf96059fa519c: extensions: gracefully warn when doing min version check with no local version.
extensions: gracefully warn when doing min version check with no local version
Nov 22 2020, 12:57 PM
mharbison72 committed rHG4f6816e8440b: make: switch the PYTHON default to `py.exe -3` on Windows.
make: switch the PYTHON default to `py.exe -3` on Windows
Nov 22 2020, 12:57 PM
mharbison72 closed D9361: make: switch the PYTHON default to `py.exe -3` on Windows.
Nov 22 2020, 12:57 PM

Nov 21 2020

mharbison72 created D9364: tests: use `testrepohg` in one more place in test-check-code.t.
Nov 21 2020, 11:03 PM
mharbison72 created D9363: extensions: gracefully warn when doing min version check with no local version.
Nov 21 2020, 4:59 PM
mharbison72 created D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building.
Nov 21 2020, 4:22 PM
mharbison72 created D9361: make: switch the PYTHON default to `py.exe -3` on Windows.
Nov 21 2020, 3:38 PM
D9332: errors: use exit code 10 for parse errors is now accepted and ready to land.
Nov 21 2020, 3:10 PM
D9355: errors: raise ConfigError on failure to parse config file is now accepted and ready to land.
Nov 21 2020, 3:10 PM
mharbison72 added a comment to D9358: upgrade: add support to downgrade share safe mode.

I haven't followed all of the sharesafe stuff, but should the nonsharedhgrc be folded into the hgrc when downgrading or unsharing? I don't see that, at least in the unshare code.

Nov 21 2020, 2:39 PM
mharbison72 added a comment to D7918: create draft change for phabricator testing.

more test recording noise

Nov 21 2020, 12:24 AM
mharbison72 added a comment to D7917: create public change for phabricator testing.

more test recording noise

Nov 21 2020, 12:23 AM
mharbison72 created D9356: phabricator: allow local revisions to be specified with `phabupdate`.
Nov 21 2020, 12:22 AM

Nov 20 2020

mharbison72 reclaimed D7918: create draft change for phabricator testing.
Nov 20 2020, 11:42 PM
mharbison72 reclaimed D7917: create public change for phabricator testing.
Nov 20 2020, 11:42 PM
D9354: errors: remove ParseError.args is now accepted and ready to land.

Queued to here, thanks

Nov 20 2020, 9:45 PM
D9352: config: clean up message about ignored untrusted config is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9353: errors: let ParseError use Abort.__bytes__ is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9350: errors: make ParseError a subtype of Abort is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9351: tests: use new ParseError.format() in test-trusted.py is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9347: errors: make formatparse() an instance method on ParseError is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9348: errors: format "abort: " text in a new Abort.format() method is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9349: tests: make doctests not depend on str(ParseError()) format is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9346: errors: create "similarity hint" for UnknownIdentifier eagerly in constructor is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9345: errors: move similarity_hint() to error module is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9344: errors: morph reportsimilar() into similarity_hint() is now accepted and ready to land.
Nov 20 2020, 9:45 PM
D9343: errors: restructure formatparse() to clarify conditions a bit is now accepted and ready to land.
Nov 20 2020, 9:45 PM
mharbison72 added inline comments to D9355: errors: raise ConfigError on failure to parse config file.
Nov 20 2020, 9:41 PM

Nov 18 2020

mharbison72 added inline comments to D9332: errors: use exit code 10 for parse errors.
Nov 18 2020, 6:58 PM
D9340: errors: raise InputError in `hg absorb` is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9339: errors: introduce CanceledError and use it in a few places is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9338: errors: raise InputError in `hg split` is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9337: errors: raise StateError in `hg bisect` is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9333: errors: raise InputError when line range to followlines() is out of bounds is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9336: errors: raise InputError in `hg debugobsolete` is now accepted and ready to land.
Nov 18 2020, 1:46 AM
D9331: dispatch: move some helper functions down into scmutil is now accepted and ready to land.
Nov 18 2020, 1:42 AM
D9330: errors: raise more specific errors from rewriteutil is now accepted and ready to land.
Nov 18 2020, 1:42 AM

Nov 17 2020

D9329: errors: use InputError for some errors on `hg clone` is now accepted and ready to land.

Queued, thanks

Nov 17 2020, 1:14 AM
D9328: errors: raise InputError when given non-existent paths etc is now accepted and ready to land.
Nov 17 2020, 1:14 AM
D9326: errors: use InputError for errors about bad paths is now accepted and ready to land.
Nov 17 2020, 1:14 AM
D9327: errors: use InputError for errors about bad label names (tags etc) is now accepted and ready to land.
Nov 17 2020, 1:14 AM
D9309: errors: set detailed exit code to 100 for some remote errors is now accepted and ready to land.
Nov 17 2020, 12:55 AM
D9318: errors: catch urllib errors specifically instead of using safehasattr() is now accepted and ready to land.
Nov 17 2020, 12:55 AM
D9308: errors: raise InputError in fancyopts is now accepted and ready to land.
Nov 17 2020, 12:55 AM

Nov 16 2020

mharbison72 added a comment to D9273: global: use python3 in shebangs.

This causes problems on Windows (since python3 == python.exe)- for example, all test-check-* but one are skipped because hghave is failing, complaining python3 is missing. The only way I can think of to work around this is to use $PYTHON to run the scripts instead of directly executing them. Before I do that, is there some other simpler mechanism that I'm overlooking? I tried to add alias python3="py -3" to the script that gets generated when MSYSTEM is in the environment around run-tests.py:1760, but that didn't help (likely env doesn't know about it).

Nov 16 2020, 11:40 PM
mharbison72 added inline comments to D9318: errors: catch urllib errors specifically instead of using safehasattr().
Nov 16 2020, 2:15 PM
mharbison72 added inline comments to D9309: errors: set detailed exit code to 100 for some remote errors.
Nov 16 2020, 1:06 AM
D9313: destutil: raise more specific error when histedit.defaultrev is empty is now accepted and ready to land.
Nov 16 2020, 1:02 AM
D9312: errors: raise more specific errors when default remote not configured is now accepted and ready to land.
Nov 16 2020, 1:02 AM