Page MenuHomePhabricator
Feed Advanced Search

Yesterday

marmoute added a comment to D7204: fsmonitor: reapply b1f62cd39b5c.

Same question as for D7203 Out of curiosity, was the fix submitted upstream too ?

Wed, Nov 20, 12:51 PM
marmoute added a comment to D7203: fsmonitor: reapply dd35abc409ee.

Out of curiosity, was the fix submitted upstream too ?

Wed, Nov 20, 12:51 PM

Mon, Nov 18

marmoute added a comment to D7144: status: use unfiltered repo if we're getting status of working copy.

I am working on a non-experimental series that get things more contained in repo/changectx to robustness. It also contains tests making sure we do not regress. I think we could so something really robust, efficient and transparent, but having this and that filtered changelog level, with lazyer filtering computation. However I think I dig the rabbit out enough for now. Eventually I think we could get O(1) filtering too removing the need for all this.

Mon, Nov 18, 1:03 PM

Sat, Nov 16

marmoute committed rHG4cd911040ba5: pure: use string for another exception in the pure version of base85.
pure: use string for another exception in the pure version of base85
Sat, Nov 16, 9:02 PM
marmoute committed rHG4394687b298b: pure: use string for exception in the pure version of base85.
pure: use string for exception in the pure version of base85
Sat, Nov 16, 9:02 PM

Fri, Nov 15

marmoute added a comment to D7420: black: blacken scripts.

Can we update the test for catch theses too ?

Fri, Nov 15, 6:52 AM

Thu, Nov 14

marmoute added a comment to D7144: status: use unfiltered repo if we're getting status of working copy.

I took more time to look at your series and at the bigger picture. My general position is still that passing the wrong filter level to high level function is hacking and will be a significant source of bugs.

I agree that it's a hack.

For example, hg status taks a "PATTERN" argument, that pattern can be fileset, that fileset can contains revset. PAssing the wrong filtering will result in wrongdoing of that revset.
However it might be a good idea to do this hack if:

  • the performance gain is significant,
  • the hack is temporary,
  • there is no reasonable alternative available short terms.

I took some time to poke at the issues, and I managed to get all 4 commands listed in this series with a first throw of abotu 12 changesets. The idea is to recognise pattern that will not be filtered and to have lower level logic skip around the filtering in this case. So the higher level logic is still filtered with the right semantic. One can have a look at the very first throw here: https://dev.heptapod.net/octobus/mercurial-devel/commits/topic/default/filter-trigger

I did something similar (but much smaller in scope) a long time ago: https://www.mercurial-scm.org/repo/hg/rev/a9b61dbdb827. That hack has since become ineffective, and I think some of your commits aim at restoring its effect. I felt that that approach was also fragile since quite subtle code changes can make it stop working (as has already happened with my original hack). So I'm not convinced that is the right approach either, but I'm fine with taking that series instead if you clean it up (I do see the risk of bugs with my series).

Thu, Nov 14, 10:13 AM

Wed, Nov 13

marmoute added a comment to D7144: status: use unfiltered repo if we're getting status of working copy.

I took more time to look at your series and at the bigger picture. My general position is still that passing the wrong filter level to high level function is hacking and will be a significant source of bugs.

Wed, Nov 13, 6:11 PM
marmoute added a comment to D7198: lock: refactor in preparation for next commit.

@marmoute can you have a look at these two patches?

Wed, Nov 13, 9:21 AM

Tue, Nov 12

marmoute added a comment to D7257: [RFC] repoview: add a "filter" that just disallows walking to heads.

Can you elaborate on what this changeset is about ? the description is a bit… short;-)

Tue, Nov 12, 5:06 PM

Sun, Nov 10

marmoute committed rHGf5991fd7cca7: revlog: remove the, now unused, `revlog._nodepos` attribute.
revlog: remove the, now unused, `revlog._nodepos` attribute
Sun, Nov 10, 6:31 PM
marmoute committed rHG9e1932eb41f9: nodemap: use bytes for the error message.
nodemap: use bytes for the error message
Sun, Nov 10, 6:31 PM
marmoute committed rHG02802fa87b74: revlog: deprecate direct `nodemap` access.
revlog: deprecate direct `nodemap` access
Sun, Nov 10, 10:38 AM
marmoute committed rHGd3df05bab081: revlog: drop special hack in the `nodemap` property.
revlog: drop special hack in the `nodemap` property
Sun, Nov 10, 10:38 AM
marmoute committed rHGc314177eb9bb: perf: make `perfrevlogindex` use the new `index.rev` api if available.
perf: make `perfrevlogindex` use the new `index.rev` api if available
Sun, Nov 10, 10:38 AM
marmoute committed rHG22cd0064370d: perf: make `perfnodemap` use the new `index.get_rev` api if available.
perf: make `perfnodemap` use the new `index.get_rev` api if available
Sun, Nov 10, 10:38 AM
marmoute committed rHGbda86cfe6261: index: use `index.get_rev` in `remotefilelog`.
index: use `index.get_rev` in `remotefilelog`
Sun, Nov 10, 10:38 AM
marmoute committed rHG418ca164d44c: index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`.
index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`
Sun, Nov 10, 10:38 AM
marmoute committed rHG43e722fc2909: index: use `index.get_rev` in `histedit.processreplacement`.
index: use `index.get_rev` in `histedit.processreplacement`
Sun, Nov 10, 10:38 AM
marmoute committed rHG0fea03924990: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`.
index: use `index.get_rev` in `rebase._computeobsoletenotrebased`
Sun, Nov 10, 10:38 AM
marmoute committed rHG054846d213ba: index: use `index.get_rev` in `rebase.successorrevs`.
index: use `index.get_rev` in `rebase.successorrevs`
Sun, Nov 10, 10:38 AM
marmoute committed rHGf212cc5ffceb: index: use `index.get_rev` in `unionrepo.unionrevlog`.
index: use `index.get_rev` in `unionrepo.unionrevlog`
Sun, Nov 10, 10:38 AM
marmoute committed rHG698e11f7be6a: index: use `index.rev` in `bundlerepo.bundlerevlog`.
index: use `index.rev` in `bundlerepo.bundlerevlog`
Sun, Nov 10, 10:38 AM
marmoute committed rHG4d8a4ecbb8b9: index: use `index.get_rev` in `exchange._pullapplyphases`.
index: use `index.get_rev` in `exchange._pullapplyphases`
Sun, Nov 10, 10:38 AM
marmoute committed rHGa49b2e253035: index: use `index.rev` in `exchange.fallbackheads`.
index: use `index.rev` in `exchange.fallbackheads`
Sun, Nov 10, 10:37 AM
marmoute committed rHG90de6bcdf226: index: use `index.get_rev` in `repoview.pinnedrevs`.
index: use `index.get_rev` in `repoview.pinnedrevs`
Sun, Nov 10, 10:37 AM
marmoute committed rHG45d123d84011: index: use `index.get_rev` in `revset._mapbynodefunc`.
index: use `index.get_rev` in `revset._mapbynodefunc`
Sun, Nov 10, 10:37 AM
marmoute committed rHG65d6770273c8: index: use `index.get_rev` in `discovery._postprocessobsolete`.
index: use `index.get_rev` in `discovery._postprocessobsolete`
Sun, Nov 10, 10:37 AM
marmoute committed rHG1542773ffa5d: index: use `index.get_rev` in `obsolete._computephasedivergentset`.
index: use `index.get_rev` in `obsolete._computephasedivergentset`
Sun, Nov 10, 10:37 AM
marmoute committed rHG505a2bc53759: index: use `index.get_rev` in `phases.newheads`.
index: use `index.get_rev` in `phases.newheads`
Sun, Nov 10, 10:37 AM
marmoute committed rHGacaff50079ff: index: use `index.get_rev` in `obsutil.getobsoleted`.
index: use `index.get_rev` in `obsutil.getobsoleted`
Sun, Nov 10, 10:37 AM
marmoute committed rHGded3d545b6f0: index: use `index.get_rev` in `localrepo.known`.
index: use `index.get_rev` in `localrepo.known`
Sun, Nov 10, 10:37 AM
marmoute committed rHGbd87114ce341: index: add a `rev` method (API).
index: add a `rev` method (API)
Sun, Nov 10, 10:37 AM
marmoute committed rHGb56de57c45ce: index: add a `get_rev` method (API).
index: add a `get_rev` method (API)
Sun, Nov 10, 10:37 AM
marmoute committed rHG2da51e292734: index: use `index.rev` in `revlog.rev`.
index: use `index.rev` in `revlog.rev`
Sun, Nov 10, 10:37 AM
marmoute committed rHGa936a3455bb1: index: use `index.has_node` in `infinitypush`.
index: use `index.has_node` in `infinitypush`
Sun, Nov 10, 10:37 AM
marmoute committed rHG3350d7aefe67: perf: make `perfphasesremote` use the new `index.has_node` api.
perf: make `perfphasesremote` use the new `index.has_node` api
Sun, Nov 10, 10:37 AM
marmoute committed rHG4cb3f5bb29ec: index: use `index.has_node` in `phabricator.getoldnodedrevmap`.
index: use `index.has_node` in `phabricator.getoldnodedrevmap`
Sun, Nov 10, 10:37 AM
marmoute committed rHGccda03f6abcb: index: use `index.has_node` in `histedit.cleanupnode`.
index: use `index.has_node` in `histedit.cleanupnode`
Sun, Nov 10, 10:37 AM
marmoute committed rHG2b5d07702f94: index: use `index.has_node` in `histedit._finishhistedit.
index: use `index.has_node` in `histedit._finishhistedit
Sun, Nov 10, 10:37 AM
marmoute committed rHGa166fadf5c3b: index: use `index.has_node` in `exchangev2._pullchangesetdiscovery`.
index: use `index.has_node` in `exchangev2._pullchangesetdiscovery`
Sun, Nov 10, 10:37 AM
marmoute committed rHG886ec3962c66: index: use `index.has_node` in `bookmarks.bmstore`.
index: use `index.has_node` in `bookmarks.bmstore`
Sun, Nov 10, 10:37 AM
marmoute committed rHG9c1f4e2f1fc4: index: use `index.has_node` in `exchange._pulldiscoverychangegroup`.
index: use `index.has_node` in `exchange._pulldiscoverychangegroup`
Sun, Nov 10, 10:37 AM
marmoute committed rHG2c3afd083e45: index: use `index.has_node` in `tags.findglobaltags`.
index: use `index.has_node` in `tags.findglobaltags`
Sun, Nov 10, 10:37 AM
marmoute committed rHG5f347567589b: index: use `index.has_node` in `bundlerepo.bundlerevlog`.
index: use `index.has_node` in `bundlerepo.bundlerevlog`
Sun, Nov 10, 10:37 AM
marmoute committed rHGc8f1e8412db4: index: use `index.has_node` in `obsutil.exclusivemarkers`.
index: use `index.has_node` in `obsutil.exclusivemarkers`
Sun, Nov 10, 10:37 AM
marmoute committed rHG1944aaaecabf: index: use `index.has_node` in `obsutil.foreground`.
index: use `index.has_node` in `obsutil.foreground`
Sun, Nov 10, 10:37 AM
marmoute committed rHG44f54b8f9f10: index: use `index.has_node` in `phases.filterunknown`.
index: use `index.has_node` in `phases.filterunknown`
Sun, Nov 10, 10:37 AM
marmoute committed rHG7f489b9a79a1: index: use `index.has_node` in `repo._rollback`.
index: use `index.has_node` in `repo._rollback`
Sun, Nov 10, 10:37 AM
marmoute committed rHGbf6fa330e0a5: index: use `index.has_node` in `revlog.addgroup`.
index: use `index.has_node` in `revlog.addgroup`
Sun, Nov 10, 10:37 AM
marmoute committed rHG9970412d2ce3: index: use `index.has_node` in `analyzeremotephases`.
index: use `index.has_node` in `analyzeremotephases`
Sun, Nov 10, 10:37 AM
marmoute committed rHG8b533de0429d: index: use `index.has_node` in `revlog.addrevision`.
index: use `index.has_node` in `revlog.addrevision`
Sun, Nov 10, 10:37 AM
marmoute committed rHG0c659fc20207: index: add a `has_node` method (API).
index: add a `has_node` method (API)
Sun, Nov 10, 10:37 AM
marmoute committed rHG642433629e20: revlog: deal with nodemap deletion within the index.
revlog: deal with nodemap deletion within the index
Sun, Nov 10, 10:37 AM
marmoute committed rHG53581e220ba3: revlog: clean up the node of all revision stripped in the C code.
revlog: clean up the node of all revision stripped in the C code
Sun, Nov 10, 10:37 AM
marmoute committed rHGdcf9826c8d8c: revlog: move nodemap update within the index code.
revlog: move nodemap update within the index code
Sun, Nov 10, 10:37 AM
marmoute committed rHG6e3e3e5446ba: revlog: deprecate the _nodecache attribute (API).
revlog: deprecate the _nodecache attribute (API)
Sun, Nov 10, 10:37 AM
marmoute committed rHGbf176127033a: revlog: access the nodemap through the index.
revlog: access the nodemap through the index
Sun, Nov 10, 10:37 AM
marmoute committed rHG90a0f631829e: revlog: return the nodemap as the nodecache.
revlog: return the nodemap as the nodecache
Sun, Nov 10, 10:37 AM
marmoute committed rHG43424f03d9a4: revlog: clarify which version use the older API in perf.
revlog: clarify which version use the older API in perf
Sun, Nov 10, 10:37 AM
marmoute committed rHGe258ad110488: revlog: no longer return the nodemap after parsing.
revlog: no longer return the nodemap after parsing
Sun, Nov 10, 10:37 AM
marmoute committed rHG845e5b313783: revlog: move the nodemap into the index object (for pure).
revlog: move the nodemap into the index object (for pure)
Sun, Nov 10, 10:37 AM
marmoute committed rHGa7c0c5b5a50f: revlog: introduce an explicit NodeMap class for pure code.
revlog: introduce an explicit NodeMap class for pure code
Sun, Nov 10, 10:37 AM
marmoute committed rHGc21aca51b392: utils: move the `dirs` definition in pathutil (API).
utils: move the `dirs` definition in pathutil (API)
Sun, Nov 10, 10:37 AM
marmoute committed rHG82f88e24caaf: revlog: drop special hack in the `nodemap` property.
revlog: drop special hack in the `nodemap` property
Sun, Nov 10, 3:56 AM
marmoute committed rHG38ff8653d1bc: revlog: deprecate direct `nodemap` access.
revlog: deprecate direct `nodemap` access
Sun, Nov 10, 3:56 AM
marmoute committed rHGb6c9c4b1f7e0: perf: make `perfrevlogindex` use the new `index.rev` api if available.
perf: make `perfrevlogindex` use the new `index.rev` api if available
Sun, Nov 10, 3:56 AM
marmoute committed rHG4b9668fa8dda: index: use `index.get_rev` in `histedit.processreplacement`.
index: use `index.get_rev` in `histedit.processreplacement`
Sun, Nov 10, 3:56 AM
marmoute committed rHG0346013e81e0: index: use `index.get_rev` in `remotefilelog`.
index: use `index.get_rev` in `remotefilelog`
Sun, Nov 10, 3:56 AM
marmoute committed rHG9bca501c557d: perf: make `perfnodemap` use the new `index.get_rev` api if available.
perf: make `perfnodemap` use the new `index.get_rev` api if available
Sun, Nov 10, 3:56 AM
marmoute committed rHG81b0ebc65c1d: index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`.
index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`
Sun, Nov 10, 3:56 AM
marmoute committed rHG19dc1e50fd48: index: use `index.get_rev` in `unionrepo.unionrevlog`.
index: use `index.get_rev` in `unionrepo.unionrevlog`
Sun, Nov 10, 3:56 AM
marmoute committed rHGc9106bf2482f: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`.
index: use `index.get_rev` in `rebase._computeobsoletenotrebased`
Sun, Nov 10, 3:56 AM
marmoute committed rHG9167a2912721: index: use `index.get_rev` in `rebase.successorrevs`.
index: use `index.get_rev` in `rebase.successorrevs`
Sun, Nov 10, 3:56 AM
marmoute committed rHG5f8edad0b685: index: use `index.rev` in `bundlerepo.bundlerevlog`.
index: use `index.rev` in `bundlerepo.bundlerevlog`
Sun, Nov 10, 3:56 AM
marmoute committed rHG7d783d5079fb: index: use `index.rev` in `exchange.fallbackheads`.
index: use `index.rev` in `exchange.fallbackheads`
Sun, Nov 10, 3:56 AM
marmoute committed rHG4bdad2355bf6: index: use `index.get_rev` in `exchange._pullapplyphases`.
index: use `index.get_rev` in `exchange._pullapplyphases`
Sun, Nov 10, 3:56 AM
marmoute committed rHGe9e11f63cf31: index: use `index.get_rev` in `revset._mapbynodefunc`.
index: use `index.get_rev` in `revset._mapbynodefunc`
Sun, Nov 10, 3:55 AM
marmoute committed rHGb5643a9010bd: index: use `index.get_rev` in `discovery._postprocessobsolete`.
index: use `index.get_rev` in `discovery._postprocessobsolete`
Sun, Nov 10, 3:55 AM
marmoute committed rHG4d56633362fc: index: use `index.get_rev` in `obsolete._computephasedivergentset`.
index: use `index.get_rev` in `obsolete._computephasedivergentset`
Sun, Nov 10, 3:55 AM
marmoute committed rHGce7130dd6c44: index: use `index.get_rev` in `repoview.pinnedrevs`.
index: use `index.get_rev` in `repoview.pinnedrevs`
Sun, Nov 10, 3:55 AM
marmoute committed rHGda46ebfd3f4e: index: use `index.get_rev` in `obsutil.getobsoleted`.
index: use `index.get_rev` in `obsutil.getobsoleted`
Sun, Nov 10, 3:55 AM
marmoute committed rHG1628cb02959f: index: use `index.get_rev` in `phases.newheads`.
index: use `index.get_rev` in `phases.newheads`
Sun, Nov 10, 3:55 AM
marmoute committed rHG9543781abd01: index: use `index.get_rev` in `localrepo.known`.
index: use `index.get_rev` in `localrepo.known`
Sun, Nov 10, 3:55 AM
marmoute committed rHG1741058d1a78: index: add a `get_rev` method (API).
index: add a `get_rev` method (API)
Sun, Nov 10, 3:55 AM

Sat, Nov 9

marmoute closed D7360: perf: make `perfrevlogindex` use the new `index.rev` api if available.
Sat, Nov 9, 11:01 AM
marmoute closed D7358: perf: make `perfnodemap` use the new `index.get_rev` api if available.
Sat, Nov 9, 11:01 AM
marmoute committed rHGc7791864af80: revlog: drop special hack in the `nodemap` property.
revlog: drop special hack in the `nodemap` property
Sat, Nov 9, 11:01 AM
marmoute committed rHG75a25a0a8317: revlog: deprecate direct `nodemap` access.
revlog: deprecate direct `nodemap` access
Sat, Nov 9, 11:01 AM
marmoute closed D7362: revlog: deprecate direct `nodemap` access.
Sat, Nov 9, 11:01 AM
marmoute closed D7361: revlog: drop special hack in the `nodemap` property.
Sat, Nov 9, 11:01 AM
marmoute closed D7354: index: use `index.get_rev` in `histedit.processreplacement`.
Sat, Nov 9, 11:00 AM
marmoute committed rHG4e989b24da69: perf: make `perfrevlogindex` use the new `index.rev` api if available.
perf: make `perfrevlogindex` use the new `index.rev` api if available
Sat, Nov 9, 11:00 AM
marmoute closed D7353: index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`.
Sat, Nov 9, 11:00 AM
marmoute committed rHG9a645bdf6f35: perf: make `perfnodemap` use the new `index.get_rev` api if available.
perf: make `perfnodemap` use the new `index.get_rev` api if available
Sat, Nov 9, 11:00 AM
marmoute closed D7357: index: use `index.get_rev` in `remotefilelog`.
Sat, Nov 9, 11:00 AM
marmoute committed rHGb9831609ba0d: index: use `index.get_rev` in `remotefilelog`.
index: use `index.get_rev` in `remotefilelog`
Sat, Nov 9, 11:00 AM
marmoute closed D7350: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`.
Sat, Nov 9, 10:59 AM
marmoute committed rHG34b38e09d084: index: use `index.get_rev` in `histedit.processreplacement`.
index: use `index.get_rev` in `histedit.processreplacement`
Sat, Nov 9, 10:59 AM
marmoute closed D7349: index: use `index.get_rev` in `rebase.successorrevs`.
Sat, Nov 9, 10:59 AM