Page MenuHomePhabricator
Feed Advanced Search

Yesterday

marmoute added a comment to D8141: darwin: add another preemptive gui() call when using chg.

I would be nice to have test but I assume this is hard. The description seems clear so I trusting Kyle on this one.

Fri, Feb 21, 3:49 AM
marmoute added a comment to D8140: shelve: fix ordering of merge labels.

Looks good. Thansk for the fix. I assume this should go on stable?

Fri, Feb 21, 3:48 AM
marmoute added a comment to D8139: shelve: add test clearly demonstrating that the conflict labels are backwards.

This patch seem (embarrassedly) right.

Fri, Feb 21, 3:47 AM

Mon, Feb 17

marmoute added a comment to D8125: transactions: convert changes['phases'] to list of ranges.

I've a couple of high level question:

Mon, Feb 17, 5:49 PM

Sat, Feb 15

marmoute closed D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.
Sat, Feb 15, 2:15 PM
marmoute committed rHGf7459da77f23: nodemap: introduce an option to use mmap to read the nodemap mapping.
nodemap: introduce an option to use mmap to read the nodemap mapping
Sat, Feb 15, 2:12 PM

Fri, Feb 14

marmoute accepted D8088: rust-status: add missing variants to `Dispatch` enum.
Fri, Feb 14, 6:52 AM
marmoute added a comment to D8087: rust-status: rename `StatusResult` to `DirstateStatus`.

Simple clear effective. Thanks for splitting

Fri, Feb 14, 6:52 AM
marmoute added a comment to D8086: rust-status: refactor options into a `StatusOptions` struct.

looks good to me. thanks for plitting

Fri, Feb 14, 3:44 AM
D7728: rebase: add test to demonstrate issue6180 now requires changes to proceed.

As per comment of Pulkit and I on D7730, please spin this test toward forbiding the prune while the rebase is in progress.

Fri, Feb 14, 3:38 AM
D7730: rebase: make sure pruning does not confuse rebase (issue6180) now requires changes to proceed.

I think is would be simpler and sfare to prevent unrelated operation during rebase. If the user cannot prune here we won't have to deal with it. This woudl also apply to other operation that can alter the repository, like another rebase, amend or a pull. Starting using a unified and safe approach seems to provide more benefit with less chance of UI inconsistency.

I agree. We should disallow prune if an unfinished operation exists.

Fri, Feb 14, 3:23 AM
marmoute added a comment to D7384: commands: necessary annotations and suppresssions to pass pytype.

There don't seems to be any remaininf feedback on this.

Fri, Feb 14, 3:21 AM

Thu, Feb 13

marmoute added inline comments to D8029: copy: add option to unmark file as copied.
Thu, Feb 13, 6:59 PM
marmoute added inline comments to D8029: copy: add option to unmark file as copied.
Thu, Feb 13, 6:49 PM
marmoute added a comment to D8030: copy: add experimetal support for unmarking committed copies.

I don't like the idea of delaying this feature two months.

Thu, Feb 13, 6:46 PM
D8035: copy: add experimental support for marking committed copies now requires changes to proceed.
Thu, Feb 13, 6:35 PM
marmoute added a comment to D8035: copy: add experimental support for marking committed copies.

See my comment on D8030 https://phab.mercurial-scm.org/D8030#120771 This proposed change is part of a much bigger picture that requires wider discussion before we can safely proceed.

Thu, Feb 13, 6:33 PM
marmoute added a comment to D8035: copy: add experimental support for marking committed copies.

See my comment in D8030, the feature is interresting, but it seems to me that we should implement that through regular amend.

On the one hand that's a thought, but I mostly feel like the functionality belongs in hg copy since that's where I'd look for it.

Thu, Feb 13, 6:32 PM
marmoute added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

As explained in this comment https://phab.mercurial-scm.org/D8030#120771 I find the idea of usign a changeset in place of the working copy interresting. However, this is a larger big UX change that seems to deserve a wider discussion with more of the community involved. In particular I am not convinced about the --rev flag usage.

Thu, Feb 13, 6:31 PM
D8030: copy: add experimetal support for unmarking committed copies now requires changes to proceed.

I had a longer discussion with @martinvonz on IRC on about this feature, he also pointed out to D7631 doing similar work for hg absorb.

Thu, Feb 13, 6:28 PM
marmoute added inline comments to D8029: copy: add option to unmark file as copied.
Thu, Feb 13, 6:14 PM
marmoute added a comment to D7795: rust-nodemap: insert method.

The change seesm good to me. However kevincox proposal to use #[cfg(test)] for pad_node seems worth applying inflight.

For future reference, I'm going to add it here, but if you're going to the trouble of uploading a new revision, it would have been nice to do this and save reviewer toil.

Thu, Feb 13, 6:04 PM
D8029: copy: add option to unmark file as copied now requires changes to proceed.

The UI seems good, but it seems like we should have --dry-run supports and I find the help text confusing (I made improvement suggestion).

Thu, Feb 13, 5:57 PM
marmoute closed D8112: test: pin the number of CPU for issue4074 tests.
Thu, Feb 13, 12:56 PM
marmoute committed rHG60bc043d7df7: test: pin the number of CPU for issue4074 tests.
test: pin the number of CPU for issue4074 tests
Thu, Feb 13, 12:56 PM
marmoute updated subscribers of D8110: rust-dirstatemap: cache non normal and other parent set.

This is supposed to be a graft of something already accepted on default. So unless I did a mistake on the graft (cc @Alphare for checking) any feedback on this also apply on the default one.

Thu, Feb 13, 9:42 AM

Wed, Feb 12

marmoute added a comment to D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

phabricator seems to be very confused about the performance number formatting…

Wed, Feb 12, 10:07 PM
marmoute updated the summary of D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.
Wed, Feb 12, 10:01 PM
marmoute created D8112: test: pin the number of CPU for issue4074 tests.
Wed, Feb 12, 7:45 PM
marmoute created D8111: rust-dirstatemap: add `NonNormalEntries` class.

INTENDED FOR STABLE

Wed, Feb 12, 6:33 PM
marmoute created D8110: rust-dirstatemap: cache non normal and other parent set.

INTENDED FOR STABLE

Wed, Feb 12, 6:33 PM

Tue, Feb 11

marmoute added a comment to D7630: absorb: make the absorbed changeset be automatically "evolved".

It looks like this series is introducing UI change of the same kind as the one @martinvonz is looking into for hg copy. I'll try to have a look at both of them tomorrow.

Tue, Feb 11, 5:40 PM
marmoute updated the diff for D7797: rust-nodemap: pure Rust example.
Tue, Feb 11, 7:03 AM
Herald added a reviewer for D7894: nodemap: introduce an option to use mmap to read the nodemap mapping: indygreg.
Tue, Feb 11, 7:03 AM

Mon, Feb 10

marmoute closed D7888: nodemap: track the maximum revision tracked in the nodemap.
Mon, Feb 10, 8:28 PM
marmoute closed D7892: nodemap: never read more than the expected data amount.
Mon, Feb 10, 8:28 PM
marmoute closed D7893: nodemap: update the index with the newly written data (when appropriate).
Mon, Feb 10, 8:28 PM
marmoute committed rHG6ecc34b31137: nodemap: update the index with the newly written data (when appropriate).
nodemap: update the index with the newly written data (when appropriate)
Mon, Feb 10, 8:28 PM
marmoute committed rHGc7eebdb15139: nodemap: never read more than the expected data amount.
nodemap: never read more than the expected data amount
Mon, Feb 10, 8:28 PM
marmoute committed rHG2ea6a67ff502: nodemap: write new data from the expected current data length.
nodemap: write new data from the expected current data length
Mon, Feb 10, 8:28 PM
marmoute closed D7890: nodemap: double check the source docket when doing incremental update.
Mon, Feb 10, 8:28 PM
marmoute closed D7891: nodemap: write new data from the expected current data length.
Mon, Feb 10, 8:28 PM
marmoute closed D7889: nodemap: track the total and unused amount of data in the rawdata file.
Mon, Feb 10, 8:28 PM
marmoute committed rHG1d2b37def017: nodemap: double check the source docket when doing incremental update.
nodemap: double check the source docket when doing incremental update
Mon, Feb 10, 8:28 PM
marmoute committed rHG8374b69aef75: nodemap: track the total and unused amount of data in the rawdata file.
nodemap: track the total and unused amount of data in the rawdata file
Mon, Feb 10, 8:28 PM
marmoute closed D7887: nodemap: add a flag to dump the details of the docket.
Mon, Feb 10, 8:28 PM
marmoute closed D7885: nodemap: keep track of the docket for loaded data.
Mon, Feb 10, 8:28 PM
marmoute committed rHGe41a164db7a9: nodemap: track the maximum revision tracked in the nodemap.
nodemap: track the maximum revision tracked in the nodemap
Mon, Feb 10, 8:26 PM
marmoute committed rHG6614b301ea58: nodemap: add a flag to dump the details of the docket.
nodemap: add a flag to dump the details of the docket
Mon, Feb 10, 8:26 PM
marmoute closed D7886: nodemap: introduce append-only incremental update of the persisten data.
Mon, Feb 10, 8:26 PM
marmoute closed D7845: nodemap: add basic checking of the on disk nodemap content.
Mon, Feb 10, 8:26 PM
marmoute committed rHG50ad851efd9b: nodemap: introduce append-only incremental update of the persistent data.
nodemap: introduce append-only incremental update of the persistent data
Mon, Feb 10, 8:26 PM
marmoute closed D7840: nodemap: add a (python) index class for persistent nodemap testing.
Mon, Feb 10, 8:26 PM
marmoute committed rHG76a96e3a2bbb: nodemap: keep track of the docket for loaded data.
nodemap: keep track of the docket for loaded data
Mon, Feb 10, 8:26 PM
marmoute closed D7847: nodemap: provide the on disk data to indexes who support it.
Mon, Feb 10, 8:26 PM
marmoute committed rHG72c15641c8b4: nodemap: introduce an explicit class/object for the docket.
nodemap: introduce an explicit class/object for the docket
Mon, Feb 10, 8:26 PM
marmoute closed D7884: nodemap: introduce an explicit class/object for the docket.
Mon, Feb 10, 8:25 PM
marmoute committed rHGf0862ee1a31e: nodemap: keep track of the ondisk id of nodemap blocks.
nodemap: keep track of the ondisk id of nodemap blocks
Mon, Feb 10, 8:25 PM
marmoute closed D7883: nodemap: keep track of the ondisk id of nodemap blocks.
Mon, Feb 10, 8:25 PM
marmoute committed rHG671f9479af0e: nodemap: provide the on disk data to indexes who support it.
nodemap: provide the on disk data to indexes who support it
Mon, Feb 10, 8:25 PM
marmoute closed D7846: nodemap: all check that revision and nodes match in the nodemap.
Mon, Feb 10, 8:25 PM
marmoute committed rHGd58206b70199: nodemap: all check that revision and nodes match in the nodemap.
nodemap: all check that revision and nodes match in the nodemap
Mon, Feb 10, 8:25 PM
marmoute committed rHG20e125cdd719: nodemap: add basic checking of the on disk nodemap content.
nodemap: add basic checking of the on disk nodemap content
Mon, Feb 10, 8:25 PM
marmoute closed D7835: nodemap: write nodemap data on disk.
Mon, Feb 10, 8:25 PM
marmoute closed D7844: nodemap: code to parse the persistent binary nodemap data.
Mon, Feb 10, 8:25 PM
marmoute committed rHG78721bbdb2ab: nodemap: code to parse the persistent binary nodemap data.
nodemap: code to parse the persistent binary nodemap data
Mon, Feb 10, 8:25 PM
marmoute closed D7843: nodemap: move the iteratio inside the Block object.
Mon, Feb 10, 8:25 PM
marmoute committed rHG55b12f2593c1: nodemap: move the iteratio inside the Block object.
nodemap: move the iteratio inside the Block object
Mon, Feb 10, 8:25 PM
marmoute closed D7842: nodemap: use an explicit "Block" object in the reference implementation.
Mon, Feb 10, 8:25 PM
marmoute committed rHG7762a295fd4d: nodemap: use an explicit "Block" object in the reference implementation.
nodemap: use an explicit "Block" object in the reference implementation
Mon, Feb 10, 8:25 PM
marmoute committed rHG7f4f7ef3133e: nodemap: add a optional `nodemap_add_full` method on indexes.
nodemap: add a optional `nodemap_add_full` method on indexes
Mon, Feb 10, 8:24 PM
marmoute closed D7841: nodemap: add a optional `nodemap_add_full` method on indexes.
Mon, Feb 10, 8:24 PM
marmoute closed D7834: nodemap: have some python code writing a nodemap in persistent binary form.
Mon, Feb 10, 8:24 PM
marmoute committed rHG6f9e8e142cea: nodemap: add a (python) index class for persistent nodemap testing.
nodemap: add a (python) index class for persistent nodemap testing
Mon, Feb 10, 8:24 PM
marmoute closed D7839: nodemap: delete older raw data file when creating a new ones.
Mon, Feb 10, 8:24 PM
marmoute committed rHG563dfdfd01a4: nodemap: delete older raw data file when creating a new ones.
nodemap: delete older raw data file when creating a new ones
Mon, Feb 10, 8:24 PM
marmoute closed D7836: nodemap: add a function to read the data from disk.
Mon, Feb 10, 8:24 PM
marmoute committed rHG2b72c4ff8ed1: nodemap: use an intermediate "docket" file to carry small metadata.
nodemap: use an intermediate "docket" file to carry small metadata
Mon, Feb 10, 8:24 PM
marmoute closed D7838: nodemap: use an intermediate "docket" file to carry small metadata.
Mon, Feb 10, 8:24 PM
marmoute committed rHGdaad3aace942: nodemap: only use persistent nodemap for non-inlined revlog.
nodemap: only use persistent nodemap for non-inlined revlog
Mon, Feb 10, 8:23 PM
marmoute committed rHG6c07480d6659: nodemap: add a function to read the data from disk.
nodemap: add a function to read the data from disk
Mon, Feb 10, 8:23 PM
marmoute closed D7837: nodemap: only use persistent nodemap for non-inlined revlog.
Mon, Feb 10, 8:23 PM
marmoute committed rHG5962fd0d1045: nodemap: write nodemap data on disk.
nodemap: write nodemap data on disk
Mon, Feb 10, 8:22 PM
marmoute committed rHGc577bb4a04d4: nodemap: have some python code writing a nodemap in persistent binary form.
nodemap: have some python code writing a nodemap in persistent binary form
Mon, Feb 10, 8:22 PM
marmoute added a comment to D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

More throughful benchmarking has arrived.

Mon, Feb 10, 7:13 PM
marmoute closed D8103: test: simplify test-amend.t to avoid race condition.
Mon, Feb 10, 5:56 PM
marmoute committed rHG5f55b5c35630: test: simplify test-amend.t to avoid race condition.
test: simplify test-amend.t to avoid race condition
Mon, Feb 10, 5:56 PM
marmoute closed D8102: remotefilelog-test: glob some flacky output line (issue6083).
Mon, Feb 10, 5:56 PM
marmoute committed rHGee0959e7d435: remotefilelog-test: glob some flaky output line (issue6083).
remotefilelog-test: glob some flaky output line (issue6083)
Mon, Feb 10, 5:56 PM
marmoute created D8103: test: simplify test-amend.t to avoid race condition.
Mon, Feb 10, 5:38 AM
marmoute created D8102: remotefilelog-test: glob some flacky output line (issue6083).
Mon, Feb 10, 5:38 AM
marmoute added a comment to D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

Here are quick performance number on our mozilla-try reference:

Mon, Feb 10, 5:13 AM

Sat, Feb 8

marmoute updated the diff for D7819: rust-nodemap: core implementation for shortest.
Sat, Feb 8, 12:46 PM
marmoute created D8098: rust-nodemap: a method for full invalidation.
Sat, Feb 8, 12:45 PM
marmoute updated the diff for D7797: rust-nodemap: pure Rust example.
Sat, Feb 8, 12:45 PM
marmoute created D8097: rust-nodemap: accounting for dead blocks.
Sat, Feb 8, 12:45 PM
marmoute updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Sat, Feb 8, 12:45 PM
marmoute updated the diff for D7796: rust-nodemap: input/output primitives.
Sat, Feb 8, 12:45 PM
marmoute updated the diff for D7795: rust-nodemap: insert method.
Sat, Feb 8, 12:45 PM
marmoute added a comment to D8096: purge: add -i flag to delete ignored files instead of untracked files.

The feature is great (I actually needs it from time to time) and the code looks good.

Sat, Feb 8, 12:42 PM