Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2020

sfink added a comment to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).

The documentation updates look good to me, but there are still some code changes that were probably not intentional, and the commit message probably needs an update.

Aug 29 2020, 4:49 PM
sfink added inline comments to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).
Aug 29 2020, 4:36 PM

Aug 28 2020

sfink created D8968: phabricator: Pass through diffoptions.

Nothing uses this directly, but it makes it much easier to another extension to call into this code and be able to request different diff options

Aug 28 2020, 5:00 PM
sfink added a comment to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).

It gets a little messy when uploading partial patches to code that I am patching

Aug 28 2020, 4:15 PM
sfink retitled D8524: phabricator: add .arcconfig to help messages and comments (issue6331) from Bug None - Bug None - Bug None - Bug None - phabricator: add .arcconfig to help messages and comments (issue6331) to phabricator: add .arcconfig to help messages and comments (issue6331).
Aug 28 2020, 4:10 PM
sfink retitled D8524: phabricator: add .arcconfig to help messages and comments (issue6331) from phabricator: load .arcconfig during reposetup (issue6331) to Bug None - Bug None - Bug None - Bug None - phabricator: add .arcconfig to help messages and comments (issue6331).

I thought I would at least keep the help message updates instead of scrapping the whole thing.

Aug 28 2020, 4:09 PM
sfink added a comment to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).

I finally got around to looking at why I needed this. It turned out to be pretty complicated, and although this patch would work for me, I'm sure there are other ways to work around this so it may not make sense to land.

Aug 28 2020, 2:16 PM

May 14 2020

sfink created D8525: phabricator: avoid passing None to pycompat.fsdecode.

I got crashes without vcr enabled

May 14 2020, 8:20 PM
sfink edited reviewers for D8524: phabricator: add .arcconfig to help messages and comments (issue6331), added: mharbison72; removed: hg-reviewers.
May 14 2020, 8:16 PM
sfink created D8524: phabricator: add .arcconfig to help messages and comments (issue6331).
May 14 2020, 8:15 PM

Feb 25 2020

sfink added a comment to D8150: histedit: py3 fixes for curses mode.

Maybe this should be in the patch comment, but justification for the change:

Feb 25 2020, 4:37 PM
sfink created D8150: histedit: py3 fixes for curses mode.
Feb 25 2020, 4:32 PM