Page MenuHomePhabricator
Feed All Stories

Yesterday

mharbison72 created D7950: verify: avoid spurious integrity warnings in verbose mode (issue6172).
Sat, Jan 18, 7:37 PM
durin42 added a comment to D7788: rust-node: binary Node and conversion utilities.

Yes, I'd appreciate not adding any assumptions that nodes are 20 bytes.

Sat, Jan 18, 6:18 PM
martinvonz added inline comments to D7788: rust-node: binary Node and conversion utilities.
Sat, Jan 18, 5:57 PM
indygreg created D7948: debugcommands: move away from line buffered output on binary stream.
Sat, Jan 18, 4:19 PM
indygreg created D7944: localrepo: handle ValueError during repository opening.
Sat, Jan 18, 4:18 PM
indygreg created D7949: py3: suppress unraisable exceptions in test-worker.t.
Sat, Jan 18, 4:18 PM
indygreg created D7947: py3: conditionalize test-lfs-serve-access.t for Python 3.8.
Sat, Jan 18, 4:18 PM
indygreg created D7946: py3: add extra traceback line present on Python 3.8.
Sat, Jan 18, 4:18 PM
indygreg created D7945: py3: conditionalize test-flagprocessor.t on Python 3.8.
Sat, Jan 18, 4:18 PM
indygreg created D7943: tests: conditionalize test-hightlight.t on pygments version.
Sat, Jan 18, 4:18 PM
indygreg created D7940: py3: make flush() line optional.
Sat, Jan 18, 2:43 AM
indygreg created D7942: py3: make test-http-bad-server.t conditional on Python 3.6+.
Sat, Jan 18, 2:43 AM
indygreg created D7941: py3: wallpaper over demand importer differences on Python 3.5.
Sat, Jan 18, 2:42 AM
indygreg created D7939: py3: glob over exception in test-check-py3-compat.t.
Sat, Jan 18, 2:42 AM
indygreg created D7938: py3: string normalization and I/O tweaks in test-lfs.t.
Sat, Jan 18, 2:42 AM
indygreg created D7937: python-zstandard: blacken at 80 characters.
Sat, Jan 18, 12:55 AM

Fri, Jan 17

martinvonz added inline comments to D7790: rust-node: handling binary Node prefix.
Fri, Jan 17, 11:16 PM
mharbison72 created D7936: help: minor copy editing to the `config.format` section.
Fri, Jan 17, 9:29 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

Fri, Jan 17, 9:03 PM
martinvonz added a comment to D7789: rust-revlog: a trait for the revlog index.

The None return cases in node() match what the index_node()
C function does.

Fri, Jan 17, 8:30 PM
D7788: rust-node: binary Node and conversion utilities now requires changes to proceed.
Fri, Jan 17, 8:24 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

--- d:/mercurial/tests/test-phabricator.t
+++ d:/mercurial/tests/test-phabricator.t.err
@@ -56,7 +56,10 @@
   $ echo alpha > alpha
   $ hg ci --addremove -m 'create alpha for phabricator test Ç'
   adding alpha
-
+  transaction abort!
+  rollback completed
+  abort: decoding near 'ator test \x80': 'utf8' codec can't decode byte 0x80 in position 34: invalid start byte! (esc)
+  [255]
 A bad .arcconfig doesn't error out
   $ echo 'garbage' > .arcconfig
   $ hg config phabricator --debug
ERROR: test-phabricator.t output changed

So I'm not sure if there is a phabsend or phabread issue.

Fri, Jan 17, 5:51 PM
mharbison72 created D7935: phabricator: use .arcconfig for `phabricator.url` if not set locally.
Fri, Jan 17, 5:47 PM
mharbison72 created D7934: phabricator: use .arcconfig for the callsign if not set locally (issue6243).
Fri, Jan 17, 5:47 PM
mharbison72 created D7933: config: add a function to insert non-file based, but overridable settings.
Fri, Jan 17, 5:47 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

Fri, Jan 17, 5:13 PM
pulkit created D7932: [RFC]debugbackups: introduce command to interact with strip backups.
Fri, Jan 17, 1:25 PM
marmoute updated the diff for D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.
Fri, Jan 17, 1:12 PM
marmoute updated the diff for D7888: nodemap: track the maximum revision tracked in the nodemap.
Fri, Jan 17, 1:11 PM
marmoute updated the diff for D7889: nodemap: track the total and unused amount of data in the rawdata file.
Fri, Jan 17, 1:10 PM
marmoute updated the diff for D7887: nodemap: add a flag to dump the details of the docket.
Fri, Jan 17, 1:10 PM
marmoute updated the diff for D7885: nodemap: keep track of the docket for loaded data.
Fri, Jan 17, 1:10 PM
marmoute updated the diff for D7845: nodemap: add basic checking of the on disk nodemap content.
Fri, Jan 17, 1:09 PM
marmoute updated the diff for D7840: nodemap: add a (python) index class for persistent nodemap testing.
Fri, Jan 17, 1:09 PM
marmoute updated the diff for D7847: nodemap: provide the on disk data to indexes who support it.
Fri, Jan 17, 1:08 PM
marmoute updated the diff for D7835: nodemap: write nodemap data on disk.
Fri, Jan 17, 1:07 PM
marmoute updated the diff for D7834: nodemap: have some python code serializing a nodemap.
Fri, Jan 17, 1:07 PM
marmoute updated the diff for D7836: nodemap: add a function to read the data from disk.
Fri, Jan 17, 1:07 PM
marmoute updated the diff for D7837: nodemap: only use persistent nodemap for non-inlined revlog.
Fri, Jan 17, 1:06 PM
marmoute added a comment to D7834: nodemap: have some python code serializing a nodemap.

As stated yesterday, I'll have limited screen exposure time available for the next couple of day. I am going to ignore any minor nits during that time. (Am I happy to look at them afterward and follow up).

Fri, Jan 17, 1:05 PM
martinvonz added inline comments to D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`.
Fri, Jan 17, 12:30 PM
Alphare created D7931: rust-status: use bare hg status fastpath from Python.
Fri, Jan 17, 11:54 AM
Alphare created D7930: rust-status: update rust-cpython bridge to account for the changes in core.
Fri, Jan 17, 11:54 AM
Alphare created D7929: rust-status: add bare `hg status` support in hg-core.
Fri, Jan 17, 11:53 AM
Alphare updated the diff for D7925: rust-matchers: add `IgnoreMatcher`.
Fri, Jan 17, 11:53 AM
Alphare updated the diff for D7924: rust-matchers: add `build_regex_match` function.
Fri, Jan 17, 11:53 AM
Alphare updated the summary of D7926: rust-dependencies: update rayon.
Fri, Jan 17, 11:53 AM
Alphare updated the diff for D7923: rust-matchers: add functions to get roots, dirs and parents from patterns.
Fri, Jan 17, 11:53 AM
Alphare added inline comments to D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`.
Fri, Jan 17, 11:51 AM
marmoute added a comment to D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

How much does this patch help performance?
I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it that the file is smaller and thus faster to read? Or is it more the building of the tree than the reading that's slow? You mentioned you use some private repo for testing this. How large is the 00changelog.n file in that repo and how large is 00changelog.i?

This save hundreds of milli second at initialization of large repositories. The repositories we are looking at are about 2 millions revisions. (but this will help smaller repository too). Mozilla try is a public repository in that range. It 00changelog.i is 103MB

And 00changelog.n?

Fri, Jan 17, 11:30 AM
martinvonz added a comment to D7926: rust-dependencies: update rayon.

I have no problem with the patch itself, but could you add a few words about the motivation? Even if that's just "no particular reason, I just like us to stay up to date".

Fri, Jan 17, 11:26 AM
martinvonz added a comment to D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

How much does this patch help performance?
I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it that the file is smaller and thus faster to read? Or is it more the building of the tree than the reading that's slow? You mentioned you use some private repo for testing this. How large is the 00changelog.n file in that repo and how large is 00changelog.i?

This save hundreds of milli second at initialization of large repositories. The repositories we are looking at are about 2 millions revisions. (but this will help smaller repository too). Mozilla try is a public repository in that range. It 00changelog.i is 103MB

Fri, Jan 17, 11:14 AM
martinvonz added inline comments to D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`.
Fri, Jan 17, 11:08 AM
D7923: rust-matchers: add functions to get roots, dirs and parents from patterns now requires changes to proceed.
Fri, Jan 17, 11:05 AM
martinvonz added a comment to D7834: nodemap: have some python code serializing a nodemap.

Can you clarify which change you are actually requesting (I see mostly nits).
So far I see the **args**opts change but I might be missing others.

Fri, Jan 17, 10:54 AM
marmoute added a comment to D7834: nodemap: have some python code serializing a nodemap.

Can you clarify which change you are actually requesting (I see mostly nits).

Fri, Jan 17, 10:39 AM
Alphare created D7928: rust-status: add function for sequential traversal of the working directory.
Fri, Jan 17, 10:34 AM
Alphare created D7927: rust-status: add util for listing a directory.
Fri, Jan 17, 10:33 AM
Alphare created D7926: rust-dependencies: update rayon.
Fri, Jan 17, 10:33 AM
marmoute closed D7492: localrepo: also fastpath access to working copy parents when possible.
Fri, Jan 17, 10:16 AM
marmoute closed D7502: changectx: mark parent of changesets as non filtered.
Fri, Jan 17, 10:15 AM
marmoute closed D7501: changectx: use unfiltered changelog to walk ancestors in annotate.
Fri, Jan 17, 10:15 AM
marmoute committed rHG98349eddceef: changectx: mark parent of changesets as non filtered.
changectx: mark parent of changesets as non filtered
Fri, Jan 17, 10:15 AM
marmoute committed rHGc472970339d2: changectx: use unfiltered changelog to walk ancestors in annotate.
changectx: use unfiltered changelog to walk ancestors in annotate
Fri, Jan 17, 10:15 AM
marmoute closed D7495: localrepo: recognize trivial request for '.'.
Fri, Jan 17, 10:15 AM
marmoute closed D7498: localrepo: also fast past the parents of working copies parents.
Fri, Jan 17, 10:15 AM
marmoute committed rHG5a012404503b: localrepo: also fast past the parents of working copies parents.
localrepo: also fast past the parents of working copies parents
Fri, Jan 17, 10:14 AM
marmoute closed D7494: localrepo: fastpath access to ".".
Fri, Jan 17, 10:14 AM
marmoute committed rHGbfaf4c673bec: localrepo: recognize trivial request for '.'.
localrepo: recognize trivial request for '.'
Fri, Jan 17, 10:13 AM
martinvonz closed D7911: examples: refer to nightly rustfmt in Windows-compatible way.
Fri, Jan 17, 10:13 AM
marmoute committed rHGd86dede17392: localrepo: fastpath access to ".".
localrepo: fastpath access to "."
Fri, Jan 17, 10:13 AM
marmoute committed rHG85c4cd73996b: localrepo: also fastpath access to working copy parents when possible.
localrepo: also fastpath access to working copy parents when possible
Fri, Jan 17, 10:13 AM
martinvonz committed rHG2077ffede71f: examples: refer to nightly rustfmt in Windows-compatible way.
examples: refer to nightly rustfmt in Windows-compatible way
Fri, Jan 17, 10:13 AM
joerg.sonnenberger closed D7732: convert: refactor authormap into separate function for outside use.
Fri, Jan 17, 10:13 AM
joerg.sonnenberger committed rHGfdaa4233dc18: convert: refactor authormap into separate function for outside use.
convert: refactor authormap into separate function for outside use
Fri, Jan 17, 10:13 AM
pulkit added a comment to D7732: convert: refactor authormap into separate function for outside use.

Amending the following in flight to make test-check-format.t (or black) happy:

Fri, Jan 17, 10:08 AM
kevincox accepted D7910: rust-re2: add wrapper for calling Re2 from Rust.
Fri, Jan 17, 10:08 AM
marmoute added a comment to D7492: localrepo: also fastpath access to working copy parents when possible.

Thank you, much appreciated.

Fri, Jan 17, 10:00 AM
D7502: changectx: mark parent of changesets as non filtered is now accepted and ready to land.
Fri, Jan 17, 10:00 AM
D7501: changectx: use unfiltered changelog to walk ancestors in annotate is now accepted and ready to land.
Fri, Jan 17, 9:59 AM
D7498: localrepo: also fast past the parents of working copies parents is now accepted and ready to land.

There are a descent odds that their will be needed too.

There are descent odds that they will be needed too.

Fri, Jan 17, 9:59 AM
D7495: localrepo: recognize trivial request for '.' is now accepted and ready to land.
Fri, Jan 17, 9:58 AM
D7494: localrepo: fastpath access to "." is now accepted and ready to land.
Fri, Jan 17, 9:58 AM
pulkit added a comment to D7494: localrepo: fastpath access to ".".

"." is just an aliast for p1(wdir(),

"." is just an alias for p1(wdir()),

Fri, Jan 17, 9:58 AM
D7492: localrepo: also fastpath access to working copy parents when possible is now accepted and ready to land.

Amending the perf numbers in commit message and fixed some spellings.

Fri, Jan 17, 9:57 AM
D7911: examples: refer to nightly rustfmt in Windows-compatible way is now accepted and ready to land.
Fri, Jan 17, 9:43 AM
Inada Naoki <songofacandy@gmail.com> committed rHG25097b4d2c6f: remotefilelog: fix opening validatecachelog in text mode.
remotefilelog: fix opening validatecachelog in text mode
Fri, Jan 17, 9:42 AM
D7732: convert: refactor authormap into separate function for outside use is now accepted and ready to land.
Fri, Jan 17, 9:42 AM
spectral closed D7913: cext: fix compiler warning about sign changing.
Fri, Jan 17, 7:21 AM
mharbison72 closed D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
Fri, Jan 17, 7:21 AM
spectral committed rHG969527ac7b44: cext: fix compiler warning about sign changing.
cext: fix compiler warning about sign changing
Fri, Jan 17, 7:21 AM
mharbison72 committed rHGb4420cea45e8: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008
Fri, Jan 17, 7:21 AM
yuja added a comment to D7913: cext: fix compiler warning about sign changing.

static PyObject *hashflags(line *l)
{

	char *s = l->start;
  • size_t plen = pathlen(l);

+ Py_ssize_t plen = pathlen(l);

Fri, Jan 17, 7:14 AM
Alphare created D7925: rust-matchers: add `IgnoreMatcher`.
Fri, Jan 17, 6:00 AM
Alphare updated the diff for D7910: rust-re2: add wrapper for calling Re2 from Rust.
Fri, Jan 17, 5:43 AM
Alphare created D7924: rust-matchers: add `build_regex_match` function.
Fri, Jan 17, 5:42 AM
Alphare created D7921: rust-dirs-multiset: improve temporary error message.
Fri, Jan 17, 5:42 AM
Alphare created D7922: rust-matchers: add function to generate a regex matcher function.
Fri, Jan 17, 5:42 AM
Alphare created D7923: rust-matchers: add functions to get roots, dirs and parents from patterns.
Fri, Jan 17, 5:42 AM
marmoute updated subscribers of D7894: nodemap: introduce an option to use mmap to read the nodemap mapping.

How much does this patch help performance?
I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it that the file is smaller and thus faster to read? Or is it more the building of the tree than the reading that's slow? You mentioned you use some private repo for testing this. How large is the 00changelog.n file in that repo and how large is 00changelog.i?

Fri, Jan 17, 5:25 AM