Page MenuHomePhabricator
Feed All Stories

Yesterday

indygreg added a comment to D8353: debugcommands: create new debugantivirusrunning command.

I do not understand what the intended side-effect of running this command is supposed to be.

Wed, Apr 1, 8:33 PM
martinvonz created D8356: rebase: don't create merge when continuing rebase interrupted by old hg.
Wed, Apr 1, 5:46 PM
martinvonz created D8355: tests: demonstrate how continuing rebase after upgrade can result in merge.
Wed, Apr 1, 5:46 PM
spectral closed D8354: histedit: add missing b prefix to a string.
Wed, Apr 1, 5:34 PM
spectral committed rHG8fca7e8449a8: histedit: add missing b prefix to a string.
histedit: add missing b prefix to a string
Wed, Apr 1, 5:34 PM
spectral created D8354: histedit: add missing b prefix to a string.
Wed, Apr 1, 5:26 PM
yuja committed rHG649fd6c3ed33: debugcommands: fix typo in debuguigetpass.
debugcommands: fix typo in debuguigetpass
Wed, Apr 1, 3:49 PM
yuja committed rHG67f757ed86e0: dagop: fix subsetparentswalker to set p1/p2 chains at merge revision.
dagop: fix subsetparentswalker to set p1/p2 chains at merge revision
Wed, Apr 1, 3:49 PM
yuja committed rHG25436f83fb95: dagop: simplify dict/set reuse condition in subsetparentswalker.
dagop: simplify dict/set reuse condition in subsetparentswalker
Wed, Apr 1, 3:49 PM
indygreg closed D8344: extensions: refactor function for obtaining disabled extension help.
Wed, Apr 1, 3:10 PM
indygreg committed rHG843418dc0b1b: extensions: refactor function for obtaining disabled extension help.
extensions: refactor function for obtaining disabled extension help
Wed, Apr 1, 3:09 PM
indygreg closed D8342: tests: prevent printing \r to stdout.
Wed, Apr 1, 3:09 PM
indygreg closed D8343: tests: perform grep manually in test-doctest.py.
Wed, Apr 1, 3:09 PM
indygreg committed rHG15aef805619d: tests: perform grep manually in test-doctest.py.
tests: perform grep manually in test-doctest.py
Wed, Apr 1, 3:09 PM
indygreg closed D8339: dispatch: force \n for newlines on sys.std* streams (BC).
Wed, Apr 1, 3:09 PM
indygreg committed rHG47e6ec977555: tests: prevent printing \r to stdout.
tests: prevent printing \r to stdout
Wed, Apr 1, 3:09 PM
indygreg committed rHGd359f0d1a3d3: tests: force \n newlines when writing to sys.stdout.
tests: force \n newlines when writing to sys.stdout
Wed, Apr 1, 3:09 PM
indygreg closed D8341: tests: force \n newlines when writing to sys.stdout.
Wed, Apr 1, 3:09 PM
indygreg committed rHG02fa5392bab6: dispatch: force \n for newlines on sys.std* streams (BC).
dispatch: force \n for newlines on sys.std* streams (BC)
Wed, Apr 1, 3:09 PM
indygreg committed rHG3cbbfd0bfc17: hook: move stdio redirection to context manager.
hook: move stdio redirection to context manager
Wed, Apr 1, 3:09 PM
indygreg closed D8338: hook: move stdio redirection to context manager.
Wed, Apr 1, 3:09 PM
D8243: copies: stop recording buggy file merge when new file overwrite an old one now requires changes to proceed.

Per irc checkin, we expect changes on this before review.

Wed, Apr 1, 3:01 PM
indygreg committed rHG00e0c5c06ed5: pycompat: change argv conversion semantics.
pycompat: change argv conversion semantics
Wed, Apr 1, 2:55 PM
indygreg closed D8337: pycompat: change argv conversion semantics.
Wed, Apr 1, 2:55 PM
martinvonz added a comment to D7827: rebase: don't use rebased node as dirstate p2 (BC).

Heads up that we ran into a fun bug that was probably caused by this patch. I think what happened was this:

Wed, Apr 1, 2:08 PM
mharbison72 closed D8312: phabricator: extract the logic to amend diff properties to a function.
Wed, Apr 1, 11:23 AM
mharbison72 closed D8313: phabricator: extract logic to print the status when posting a commit.
Wed, Apr 1, 11:23 AM
mharbison72 closed D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
Wed, Apr 1, 11:23 AM
mharbison72 committed rHG99fa161a883c: phabricator: extract the logic to amend diff properties to a function.
phabricator: extract the logic to amend diff properties to a function
Wed, Apr 1, 11:23 AM
mharbison72 committed rHG949a87145336: phabricator: extract logic to print the status when posting a commit.
phabricator: extract logic to print the status when posting a commit
Wed, Apr 1, 11:23 AM
mharbison72 closed D8310: phabricator: teach createdifferentialrevision() to allow a folded commit range.
Wed, Apr 1, 11:23 AM
mharbison72 committed rHG5f9c917e3b50: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
phabricator: teach `getoldnodedrevmap()` to handle folded reviews
Wed, Apr 1, 11:23 AM
mharbison72 closed D8309: phabricator: combine commit messages into the review when folding commits.
Wed, Apr 1, 11:23 AM
mharbison72 closed D8308: phabricator: record all local commits used to create a Differential revision.
Wed, Apr 1, 11:23 AM
mharbison72 committed rHG419fec8237b7: phabricator: teach createdifferentialrevision() to allow a folded commit range.
phabricator: teach createdifferentialrevision() to allow a folded commit range
Wed, Apr 1, 11:23 AM
mharbison72 committed rHG0437959de6f5: phabricator: record all local commits used to create a Differential revision.
phabricator: record all local commits used to create a Differential revision
Wed, Apr 1, 11:23 AM
mharbison72 committed rHGdbe9182c90f5: phabricator: combine commit messages into the review when folding commits.
phabricator: combine commit messages into the review when folding commits
Wed, Apr 1, 11:23 AM
indygreg closed D8336: tests: use `f --hexdump` to print file content.
Wed, Apr 1, 11:23 AM
indygreg closed D8350: hgcli: add stub PyOxidizer project.
Wed, Apr 1, 11:23 AM
indygreg committed rHGda9b7f9635a2: tests: use `f --hexdump` to print file content.
tests: use `f --hexdump` to print file content
Wed, Apr 1, 11:23 AM
indygreg closed D8351: hgcli: customize for Mercurial.
Wed, Apr 1, 11:23 AM
indygreg closed D8335: url: pass str to pathname2url.
Wed, Apr 1, 11:23 AM
indygreg committed rHGe74af49aa3c9: url: pass str to pathname2url.
url: pass str to pathname2url
Wed, Apr 1, 11:22 AM
marmoute closed D8192: nodemap: display percentage of unused in `hg debugnodemap`.
Wed, Apr 1, 11:22 AM
indygreg committed rHG51ffb2a6c08a: tests: pass str to matchoutput().
tests: pass str to matchoutput()
Wed, Apr 1, 11:22 AM
indygreg closed D8334: tests: pass str to matchoutput().
Wed, Apr 1, 11:22 AM
indygreg committed rHGbc847878f4c0: hgcli: customize for Mercurial.
hgcli: customize for Mercurial
Wed, Apr 1, 11:22 AM
indygreg committed rHGaf739894a4c1: hgcli: add stub PyOxidizer project.
hgcli: add stub PyOxidizer project
Wed, Apr 1, 11:22 AM
indygreg closed D8349: hgcli: remove legacy project.
Wed, Apr 1, 11:22 AM
marmoute closed D8193: nodemap: automatically "vacuum" the persistent nodemap when too sparse.
Wed, Apr 1, 11:22 AM
indygreg committed rHG02f66b23cba3: hgcli: remove legacy project.
hgcli: remove legacy project
Wed, Apr 1, 11:22 AM
marmoute closed D8316: testlib: adjust wait-on-file timeout according to the global test timeout.
Wed, Apr 1, 11:22 AM
marmoute committed rHGc70bcaf7927b: nodemap: automatically "vacuum" the persistent nodemap when too sparse.
nodemap: automatically "vacuum" the persistent nodemap when too sparse
Wed, Apr 1, 11:22 AM
marmoute closed D8191: nodemap: make sure on disk change get rolled back with the transaction.
Wed, Apr 1, 11:21 AM
marmoute committed rHG99ea74cbed74: nodemap: display percentage of unused in `hg debugnodemap`.
nodemap: display percentage of unused in `hg debugnodemap`
Wed, Apr 1, 11:21 AM
marmoute closed D8190: nodemap: test that concurrent process don't see the pending transaction.
Wed, Apr 1, 11:21 AM
marmoute committed rHG01b0805534bb: nodemap: make sure on disk change get rolled back with the transaction.
nodemap: make sure on disk change get rolled back with the transaction
Wed, Apr 1, 11:21 AM
marmoute committed rHGdd5b47fb0860: nodemap: test that concurrent process don't see the pending transaction.
nodemap: test that concurrent process don't see the pending transaction
Wed, Apr 1, 11:21 AM
marmoute committed rHG82543879b48e: testlib: adjust wait-on-file timeout according to the global test timeout.
testlib: adjust wait-on-file timeout according to the global test timeout
Wed, Apr 1, 11:21 AM
marmoute closed D8189: testlib: add a small scrip to help process to synchronise using file.
Wed, Apr 1, 11:21 AM
marmoute committed rHG1ed6293fc31b: testlib: add a small scrip to help process to synchronise using file.
testlib: add a small scrip to help process to synchronise using file
Wed, Apr 1, 11:21 AM
durin42 committed rHG4c6189d45d67: setup: work around old versions of distutils breaking setup.py.
setup: work around old versions of distutils breaking setup.py
Wed, Apr 1, 11:21 AM
durin42 updated the diff for D8353: debugcommands: create new debugantivirusrunning command.
Wed, Apr 1, 10:51 AM
durin42 created D8353: debugcommands: create new debugantivirusrunning command.
Wed, Apr 1, 10:47 AM
pulkit committed rHGd37975386798: chgserver: update the umask cache before each run.
chgserver: update the umask cache before each run
Wed, Apr 1, 9:02 AM
marmoute added a comment to D8336: tests: use `f --hexdump` to print file content.

sure

Wed, Apr 1, 4:18 AM
D8352: extensions: don't crash if __file__ not defined now requires changes to proceed.
Wed, Apr 1, 4:17 AM
marmoute added a comment to D8351: hgcli: customize for Mercurial.

Seems overall good. I added a request for comments.

Wed, Apr 1, 4:15 AM
marmoute accepted D8350: hgcli: add stub PyOxidizer project.
Wed, Apr 1, 4:11 AM
marmoute added a comment to D8349: hgcli: remove legacy project.

sure

Wed, Apr 1, 4:08 AM

Tue, Mar 31

indygreg created D8350: hgcli: add stub PyOxidizer project.
Tue, Mar 31, 11:29 PM
indygreg created D8351: hgcli: customize for Mercurial.
Tue, Mar 31, 11:29 PM
indygreg created D8352: extensions: don't crash if __file__ not defined.
Tue, Mar 31, 11:29 PM
indygreg created D8349: hgcli: remove legacy project.
Tue, Mar 31, 11:29 PM
mharbison72 added inline comments to D8314: phabricator: add an option to fold several commits into one review (issue6244).
Tue, Mar 31, 9:42 AM
pulkit added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I wanted to help with things here but unfortunately I have ~0 experience with shell scripts and the kind of process testing going in next few patches.

Tue, Mar 31, 9:21 AM
yuja added a comment to D8337: pycompat: change argv conversion semantics.
> On Windows, my assumption was os.fsencode() == .encode("mbcs") if
> sys._enablelegacywindowsfsencoding(). So this looks good to me.
> Perhaps, the "ignore" error mode would match the legacy Windows behavior.
Does this mean it could be a problem running from source on Windows?  For example, `hg version` (as opposed to `hg.exe version`) seems to be equivalent to `python hg`, which obviously doesn't have the proper environment variable or C API option to enable legacy mode.  Should there be code early on that detects this and warns/aborts?
Tue, Mar 31, 8:08 AM
durin42 closed D8333: tests: handle new error string from FreeBSD for dns entry not resolving.
Tue, Mar 31, 6:23 AM
joerg.sonnenberger closed D8172: notify: optional mail threading based on obsmarker.
Tue, Mar 31, 6:23 AM
durin42 committed rHG4dacd0cef146: tests: handle new error string from FreeBSD for dns entry not resolving.
tests: handle new error string from FreeBSD for dns entry not resolving
Tue, Mar 31, 6:23 AM
joerg.sonnenberger committed rHG947e6df4ff77: notify: optional mail threading based on obsmarker.
notify: optional mail threading based on obsmarker
Tue, Mar 31, 6:23 AM
D8335: url: pass str to pathname2url is now accepted and ready to land.
Tue, Mar 31, 6:17 AM
D8334: tests: pass str to matchoutput() is now accepted and ready to land.
Tue, Mar 31, 6:16 AM
D8333: tests: handle new error string from FreeBSD for dns entry not resolving is now accepted and ready to land.
Tue, Mar 31, 5:53 AM
Alphare accepted D8338: hook: move stdio redirection to context manager.
Tue, Mar 31, 5:08 AM
Alphare accepted D8333: tests: handle new error string from FreeBSD for dns entry not resolving.
Tue, Mar 31, 5:05 AM
D8314: phabricator: add an option to fold several commits into one review (issue6244) now requires changes to proceed.
Tue, Mar 31, 4:57 AM
Alphare accepted D8313: phabricator: extract logic to print the status when posting a commit.
Tue, Mar 31, 4:39 AM
Alphare accepted D8312: phabricator: extract the logic to amend diff properties to a function.
Tue, Mar 31, 4:35 AM
Alphare accepted D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
Tue, Mar 31, 4:33 AM

Mon, Mar 30

mharbison72 added inline comments to D8314: phabricator: add an option to fold several commits into one review (issue6244).
Mon, Mar 30, 10:26 PM
mharbison72 added a comment to D8344: extensions: refactor function for obtaining disabled extension help.

I noticed inconsistencies with this too. I was wondering if we should populate __index__ with the full help text to avoid that. (The other inconsistency that comes to mind is printing out the disabled extension list in hg help extensions.) While it is apparently only used for py2exe based stuff, it might be handy with PyOxidizer too, until that gains the ability to enumerate and read embedded *.py files and directories as resources.

Mon, Mar 30, 3:14 PM
mharbison72 added a comment to D8334: tests: pass str to matchoutput().

I suspect the Windows process code in Python doesn't accept bytes and the POSIX code does?

Mon, Mar 30, 2:37 PM
mharbison72 added a comment to D8337: pycompat: change argv conversion semantics.
In D8337#124542, @yuja wrote:

On Windows, my assumption was os.fsencode() == .encode("mbcs") if
sys._enablelegacywindowsfsencoding(). So this looks good to me.
Perhaps, the "ignore" error mode would match the legacy Windows behavior.

Mon, Mar 30, 1:54 PM
D8172: notify: optional mail threading based on obsmarker is now accepted and ready to land.
Mon, Mar 30, 6:50 AM
mharbison72 added a comment to D8337: pycompat: change argv conversion semantics.

This looks like it also fixes the phabricator test on Windows, which diverged by creating a different hash for the create alpha for phabricator test € commit.

Mon, Mar 30, 1:09 AM
mharbison72 added a comment to D8345: tests: look for CRLF on Windows.

The test harness *should* match existing \n output as a fallback, which got me to wondering if it was the (esc) at the end screwing it up. I tried this patch:

Mon, Mar 30, 12:51 AM

Sun, Mar 29

indygreg added a comment to D8340: dispatch: force \n for newlines on sys.std* streams (BC).

This is a dupe of D8339.

Sun, Mar 29, 9:32 PM
indygreg created D8344: extensions: refactor function for obtaining disabled extension help.
Sun, Mar 29, 9:30 PM
indygreg created D8348: tests: force newlines to LF in inline Python script.
Sun, Mar 29, 9:30 PM