Page MenuHomePhabricator
Feed All Stories

Today

Alphare added inline comments to D8872: rhg: make output of `files` relative to the current directory and the root.
Wed, Aug 12, 6:01 AM
Alphare added inline comments to D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand.
Wed, Aug 12, 5:58 AM

Yesterday

martinvonz closed D8925: revert: remove dangerous `parents` argument from `cmdutil.revert()`.
Tue, Aug 11, 10:06 AM
martinvonz committed rHG8c466bcb0879: revert: remove dangerous `parents` argument from `cmdutil.revert()`.
revert: remove dangerous `parents` argument from `cmdutil.revert()`
Tue, Aug 11, 10:03 AM
D8925: revert: remove dangerous `parents` argument from `cmdutil.revert()` is now accepted and ready to land.
Tue, Aug 11, 5:41 AM
pulkit added a comment to D8633: share: introduce config option to store requires in .hg/store.

I need to think about the implications of this change a bit more: the requires file plays an important part in how clients open repositories and there are significant backwards and forwards compatibility concerns.
One immediate request is to document semantics in mercurial/helptext/internals/requirements.txt as part of this change.

Tue, Aug 11, 5:27 AM
pulkit added a comment to D8633: share: introduce config option to store requires in .hg/store.

I left a handful of comments.
Changing repo opening semantics and requirements handling is a bit scary.
I'm generally in favor of separating working directory requirements from non-working directory requirements so I think this patch is a step in the right direction. There are a few alternative implementations worth considering. (Although I'm unsure if they are superior.)

  1. Write the new requirements file in the .hg directory as .hg/store-requires (or similar). Conceptually, we're talking about working directory and backend requirements. The "store" is just today's layout for storing backend data [which can be shared between working directories].
  2. Write a new requirements file for working directory specific requirements.

Hi, thanks a lot for the detailed review. I think we can have .hg/requires as working directory specific and .hg/store/requires as store requirements.
I have not yet implemented all the fixes you mentioned. Hence marking this as planned changes. However I have added some parents patches which should be good to review.

Tue, Aug 11, 5:25 AM
pulkit updated the diff for D8673: config: add a .hg/nonsharedrc which won't be shared in share-safe mode.
Tue, Aug 11, 5:09 AM
pulkit updated the diff for D8633: share: introduce config option to store requires in .hg/store.
Tue, Aug 11, 5:08 AM
pulkit updated the diff for D8660: upgrade: support running upgrade if repository has share-safe requirement.
Tue, Aug 11, 5:07 AM
pulkit updated the diff for D8656: localrepo: load the share source .hg/hgrc also in share-safe mode (API).
Tue, Aug 11, 5:07 AM
pulkit created D8926: requirements: introduce constants for `shared` and `relshared` requirements.
Tue, Aug 11, 5:06 AM
pulkit added a comment to D8923: mergestate: replace `addmergedother()` with generic `addcommitinfo()` (API).

This seems to conflict with my request for D8921, do we have a good way forward that allow to still rename the key ?

Tue, Aug 11, 3:49 AM
pulkit added a comment to D8921: merge: use collections.defaultdict() for mergeresult.commitinfo.

Having a filenode key that does not contains a filenode is quite misleading. Can we use a different key ? (and align the extrastate dict in the same direction?)

Tue, Aug 11, 3:47 AM
pulkit updated the diff for D8923: mergestate: replace `addmergedother()` with generic `addcommitinfo()` (API).
Tue, Aug 11, 3:47 AM
pulkit updated the diff for D8920: mergestate: use _stateextras instead of merge records for commit related info.
Tue, Aug 11, 3:47 AM
pulkit updated the diff for D8922: merge: introduce `addcommitinfo()` on mergeresult object.
Tue, Aug 11, 3:47 AM
pulkit added inline comments to D8919: mergestate: use collections.defaultdict(dict) for _stateextras.
Tue, Aug 11, 3:47 AM
pulkit updated the diff for D8921: merge: use collections.defaultdict() for mergeresult.commitinfo.
Tue, Aug 11, 3:46 AM
pulkit updated the diff for D8919: mergestate: use collections.defaultdict(dict) for _stateextras.
Tue, Aug 11, 3:46 AM
martinvonz created D8925: revert: remove dangerous `parents` argument from `cmdutil.revert()`.
Tue, Aug 11, 1:27 AM

Mon, Aug 10

pulkit closed D8917: requirements: introduce new requirements related module.
Mon, Aug 10, 9:17 PM
pulkit closed D8916: repository: introduce constant for treemanifest requirement and use it.
Mon, Aug 10, 9:17 PM
pulkit closed D8918: localrepo: move requirements constant to requirements module.
Mon, Aug 10, 9:15 PM
pulkit committed rHGbd56597b2254: requirements: introduce a set of working directory specific requirements.
requirements: introduce a set of working directory specific requirements
Mon, Aug 10, 9:14 PM
pulkit closed D8924: requirements: introduce a set of working directory specific requirements.
Mon, Aug 10, 9:14 PM
pulkit committed rHGd7dcc75a3eae: localrepo: move requirements constant to requirements module.
localrepo: move requirements constant to requirements module
Mon, Aug 10, 9:14 PM
pulkit committed rHG77b8588dd84e: requirements: introduce new requirements related module.
requirements: introduce new requirements related module
Mon, Aug 10, 9:14 PM
pulkit committed rHGe58e234096de: repository: introduce constant for treemanifest requirement and use it.
repository: introduce constant for treemanifest requirement and use it
Mon, Aug 10, 9:14 PM
indygreg added inline comments to D8919: mergestate: use collections.defaultdict(dict) for _stateextras.
Mon, Aug 10, 9:06 PM
D8924: requirements: introduce a set of working directory specific requirements is now accepted and ready to land.
Mon, Aug 10, 9:00 PM
D8918: localrepo: move requirements constant to requirements module is now accepted and ready to land.
Mon, Aug 10, 8:59 PM
D8917: requirements: introduce new requirements related module is now accepted and ready to land.
Mon, Aug 10, 8:58 PM
D8916: repository: introduce constant for treemanifest requirement and use it is now accepted and ready to land.
Mon, Aug 10, 8:53 PM
D8923: mergestate: replace `addmergedother()` with generic `addcommitinfo()` (API) now requires changes to proceed.

This seems to conflict with my request for D8921, do we have a good way forward that allow to still rename the key ?

Mon, Aug 10, 1:22 PM
marmoute accepted D8922: merge: introduce `addcommitinfo()` on mergeresult object.
Mon, Aug 10, 1:19 PM
D8921: merge: use collections.defaultdict() for mergeresult.commitinfo now requires changes to proceed.

Having a filenode key that does not contains a filenode is quite misleading. Can we use a different key ? (and align the extrastate dict in the same direction?)

Mon, Aug 10, 1:18 PM
marmoute accepted D8921: merge: use collections.defaultdict() for mergeresult.commitinfo.
Mon, Aug 10, 1:17 PM
marmoute accepted D8920: mergestate: use _stateextras instead of merge records for commit related info.
Mon, Aug 10, 1:15 PM
marmoute accepted D8919: mergestate: use collections.defaultdict(dict) for _stateextras.
Mon, Aug 10, 1:14 PM
pulkit updated the diff for D8673: config: add a .hg/nonsharedrc which won't be shared in share-safe mode.
Mon, Aug 10, 11:31 AM
pulkit updated the diff for D8659: config: add `--shared` flag to edit config file of shared source.
Mon, Aug 10, 11:29 AM
pulkit updated the diff for D8660: upgrade: support running upgrade if repository has share-safe requirement.
Mon, Aug 10, 11:29 AM
pulkit updated the diff for D8656: localrepo: load the share source .hg/hgrc also in share-safe mode (API).
Mon, Aug 10, 11:28 AM
pulkit updated the diff for D8633: share: introduce config option to store requires in .hg/store.
Mon, Aug 10, 11:28 AM
pulkit updated the summary of D8913: scmutil: introduce filterrequirements() to split reqs into wc and store ones.
Mon, Aug 10, 11:25 AM
pulkit created D8924: requirements: introduce a set of working directory specific requirements.
Mon, Aug 10, 11:24 AM
pulkit created D8923: mergestate: replace `addmergedother()` with generic `addcommitinfo()` (API).
Mon, Aug 10, 7:19 AM
pulkit created D8920: mergestate: use _stateextras instead of merge records for commit related info.
Mon, Aug 10, 7:18 AM
pulkit created D8922: merge: introduce `addcommitinfo()` on mergeresult object.
Mon, Aug 10, 7:18 AM
pulkit created D8921: merge: use collections.defaultdict() for mergeresult.commitinfo.
Mon, Aug 10, 7:18 AM
pulkit created D8919: mergestate: use collections.defaultdict(dict) for _stateextras.
Mon, Aug 10, 7:17 AM

Sun, Aug 9

pulkit created D8917: requirements: introduce new requirements related module.
Sun, Aug 9, 5:28 AM
pulkit created D8916: repository: introduce constant for treemanifest requirement and use it.
Sun, Aug 9, 5:27 AM
pulkit created D8918: localrepo: move requirements constant to requirements module.
Sun, Aug 9, 5:26 AM

Sat, Aug 8

martinvonz closed D8840: rename: add support for --at-rev, which marks as copy and removes the source.
Sat, Aug 8, 5:02 PM
ced closed D8859: keepalive: Do not append _rbuf if _raw_readinto exists (issue6356).
Sat, Aug 8, 5:02 PM
ced committed rHG49f8ba4febec: keepalive: Do not append _rbuf if _raw_readinto exists (issue6356).
keepalive: Do not append _rbuf if _raw_readinto exists (issue6356)
Sat, Aug 8, 5:02 PM
joerg.sonnenberger closed D8782: tests: make flag parsing test more future safe.
Sat, Aug 8, 5:01 PM
martinvonz committed rHG5178dd2233d0: rename: add support for --at-rev, which marks as copy and removes the source.
rename: add support for --at-rev, which marks as copy and removes the source
Sat, Aug 8, 5:01 PM
joerg.sonnenberger committed rHG15d35f2ba474: tests: make flag parsing test more future safe.
tests: make flag parsing test more future safe
Sat, Aug 8, 5:01 PM
spectral closed D8813: tests: make test-install.t work on debian systems.
Sat, Aug 8, 5:01 PM
spectral committed rHGd71693f799a0: tests: make test-install.t work on debian systems.
tests: make test-install.t work on debian systems
Sat, Aug 8, 5:01 PM
D8859: keepalive: Do not append _rbuf if _raw_readinto exists (issue6356) is now accepted and ready to land.

Good work tracking down this obscure failure!

Sat, Aug 8, 5:01 PM
indygreg closed D7221: hghave: fix bytes/string issue on Python 3.
Sat, Aug 8, 4:56 PM
indygreg added a reviewer for D7221: hghave: fix bytes/string issue on Python 3: durin42.
Sat, Aug 8, 4:56 PM
indygreg added a comment to D7221: hghave: fix bytes/string issue on Python 3.

A similar patch already landed. I'm going to commandeer and close.

Sat, Aug 8, 4:56 PM
D8782: tests: make flag parsing test more future safe is now accepted and ready to land.
Sat, Aug 8, 4:54 PM
indygreg added a comment to D8840: rename: add support for --at-rev, which marks as copy and removes the source.

I'm not sure what the README.rst rename was doing in the diff. So I dropped it in-flight.

Sat, Aug 8, 4:52 PM
D8840: rename: add support for --at-rev, which marks as copy and removes the source is now accepted and ready to land.
Sat, Aug 8, 4:51 PM
acezar closed D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand.
Sat, Aug 8, 4:32 PM
acezar closed D8871: rhg: handle broken pipe error for stderr.
Sat, Aug 8, 4:32 PM
acezar committed rHG53af26aa5951: rhg: handle broken pipe error for stderr.
rhg: handle broken pipe error for stderr
Sat, Aug 8, 4:32 PM
D8813: tests: make test-install.t work on debian systems is now accepted and ready to land.

Debian's perturbations to how Python is packaged continue to confound me. There's aren't enough Picard facepalm memes to express my feelings on the matter.

Sat, Aug 8, 4:32 PM
acezar closed D8870: rhg: extract function handle_stdout_error.
Sat, Aug 8, 4:32 PM
acezar committed rHG10c36ead86f8: rhg: extract function handle_stdout_error.
rhg: extract function handle_stdout_error
Sat, Aug 8, 4:32 PM
acezar closed D8869: rhg: add a limited `rhg files` subcommand.
Sat, Aug 8, 4:32 PM
acezar closed D8865: rhg: ask the error message from `CommandError`.
Sat, Aug 8, 4:31 PM
acezar committed rHG26440adbe3e9: rhg: add a limited `rhg files` subcommand.
rhg: add a limited `rhg files` subcommand
Sat, Aug 8, 4:31 PM
acezar committed rHG5fe25f8ef5d9: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand.
rhg: add a `Files` `Command` to prepare the `rhg files` subcommand
Sat, Aug 8, 4:31 PM
acezar closed D8867: rhg: simplify `FindRootError` handling.
Sat, Aug 8, 4:31 PM
acezar closed D8862: hg-core: remove the `Operation` trait.
Sat, Aug 8, 4:31 PM
acezar committed rHG5dbf875b3275: rhg: simplify `FindRootError` handling.
rhg: simplify `FindRootError` handling
Sat, Aug 8, 4:31 PM
acezar committed rHGeb55274d3650: rhg: add buffered stdout writing possibility.
rhg: add buffered stdout writing possibility
Sat, Aug 8, 4:31 PM
acezar closed D8866: rhg: add buffered stdout writing possibility.
Sat, Aug 8, 4:31 PM
acezar closed D8864: rhg: Do not return error when when we really mean ok in commands.
Sat, Aug 8, 4:30 PM
acezar committed rHG47997afadf08: rhg: ask the error message from `CommandError`.
rhg: ask the error message from `CommandError`
Sat, Aug 8, 4:30 PM
acezar closed D8861: hg-core: make parse_dirstate return references rather than update hashmaps.
Sat, Aug 8, 4:30 PM
acezar committed rHG227281e76c22: rhg: Do not return error when when we really mean ok in commands.
rhg: Do not return error when when we really mean ok in commands
Sat, Aug 8, 4:30 PM
acezar closed D8863: hg-core: define a `ListTrackedFiles` `Operation`.
Sat, Aug 8, 4:30 PM
acezar committed rHG0f5286ccf82c: hg-core: define a `ListTrackedFiles` `Operation`.
hg-core: define a `ListTrackedFiles` `Operation`
Sat, Aug 8, 4:29 PM
acezar committed rHG452ece5654c5: hg-core: remove the `Operation` trait.
hg-core: remove the `Operation` trait
Sat, Aug 8, 4:29 PM
acezar committed rHG27424779c5b8: hg-core: make parse_dirstate return references rather than update hashmaps.
hg-core: make parse_dirstate return references rather than update hashmaps
Sat, Aug 8, 4:29 PM
indygreg added inline comments to D8872: rhg: make output of `files` relative to the current directory and the root.
Sat, Aug 8, 4:19 PM
D8871: rhg: handle broken pipe error for stderr is now accepted and ready to land.
Sat, Aug 8, 4:12 PM
D8870: rhg: extract function handle_stdout_error is now accepted and ready to land.
Sat, Aug 8, 4:12 PM
D8869: rhg: add a limited `rhg files` subcommand is now accepted and ready to land.
Sat, Aug 8, 4:11 PM
D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand is now accepted and ready to land.
Sat, Aug 8, 4:09 PM
D8623: rebase: add a config knob for forcing in-memory rebasing now requires changes to proceed.
Sat, Aug 8, 4:05 PM
D8562: shelve: get mergestate via context now requires changes to proceed.
Sat, Aug 8, 4:05 PM