I do not understand what the intended side-effect of running this command is supposed to be.
Per irc checkin, we expect changes on this before review.
Heads up that we ran into a fun bug that was probably caused by this patch. I think what happened was this:
Seems overall good. I added a request for comments.
Tue, Mar 31
I wanted to help with things here but unfortunately I have ~0 experience with shell scripts and the kind of process testing going in next few patches.
> On Windows, my assumption was os.fsencode() == .encode("mbcs") if > sys._enablelegacywindowsfsencoding(). So this looks good to me. > Perhaps, the "ignore" error mode would match the legacy Windows behavior. Does this mean it could be a problem running from source on Windows? For example, `hg version` (as opposed to `hg.exe version`) seems to be equivalent to `python hg`, which obviously doesn't have the proper environment variable or C API option to enable legacy mode. Should there be code early on that detects this and warns/aborts?
Mon, Mar 30
I noticed inconsistencies with this too. I was wondering if we should populate __index__ with the full help text to avoid that. (The other inconsistency that comes to mind is printing out the disabled extension list in hg help extensions.) While it is apparently only used for py2exe based stuff, it might be handy with PyOxidizer too, until that gains the ability to enumerate and read embedded *.py files and directories as resources.
I suspect the Windows process code in Python doesn't accept bytes and the POSIX code does?
On Windows, my assumption was os.fsencode() == .encode("mbcs") if
sys._enablelegacywindowsfsencoding(). So this looks good to me.
Perhaps, the "ignore" error mode would match the legacy Windows behavior.
This looks like it also fixes the phabricator test on Windows, which diverged by creating a different hash for the create alpha for phabricator test € commit.
The test harness *should* match existing \n output as a fallback, which got me to wondering if it was the (esc) at the end screwing it up. I tried this patch:
Sun, Mar 29
This is a dupe of D8339.