Page MenuHomePhabricator
Feed All Stories

Today

quark added a comment to D7582: rust-configparser: run rustfmt.

We actually ran rustfmt, but it's an older version (rustfmt 1.3.0-stable (d334502 2019-06-09)) and I verified the code still formats under that particular version of rustfmt with empty rustfmt.toml. In other words, rustfmt itself seems to change over time.

Sat, Dec 7, 6:32 PM
indygreg added a comment to D7575: hg-core: vendor Facebook's configparser crate.

Thank you for the feedback, @quark! You enlightened me to a few issues I missed during my very quick perusal.

Sat, Dec 7, 6:10 PM
quark added inline comments to D7575: hg-core: vendor Facebook's configparser crate.
Sat, Dec 7, 6:06 PM
indygreg created D7582: rust-configparser: run rustfmt.
Sat, Dec 7, 5:58 PM
indygreg updated the diff for D7577: rust-configparser: implement Mercurial's config file discovery logic.
Sat, Dec 7, 5:58 PM
indygreg updated the summary of D7576: hg-core: add configparser to library.
Sat, Dec 7, 5:58 PM
indygreg created D7581: rust-configparser: regenerate parser.rs.
Sat, Dec 7, 5:57 PM
indygreg created D7580: hg-core: rustfmt path.rs.
Sat, Dec 7, 5:56 PM
indygreg created D7578: rust: run rustfmt.
Sat, Dec 7, 4:12 PM
indygreg created D7579: tests: add test for Rust formatting.
Sat, Dec 7, 4:12 PM
indygreg created D7575: hg-core: vendor Facebook's configparser crate.
Sat, Dec 7, 3:19 PM
indygreg created D7576: hg-core: add configparser to library.
Sat, Dec 7, 3:19 PM
indygreg created D7577: rust-configparser: implement Mercurial's config file discovery logic.
Sat, Dec 7, 3:19 PM
indygreg created D7574: hg-core: add utils::path to project.
Sat, Dec 7, 3:18 PM
indygreg created D7573: hg-core: vendor Facebook's path utils module.
Sat, Dec 7, 3:17 PM
durin42 committed rHGd9f85f61f0ed: fuzz: clean up some repetition on building parsers.so fuzzers.
fuzz: clean up some repetition on building parsers.so fuzzers
Sat, Dec 7, 12:54 PM
durin42 committed rHGd37658efbec2: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
fuzz: remove legacy setup for running fuzzers outside oss-fuzz
Sat, Dec 7, 12:54 PM
durin42 committed rHG19da643dc10c: tests: finally fix up test-fuzz-targets.t.
tests: finally fix up test-fuzz-targets.t
Sat, Dec 7, 12:54 PM
durin42 committed rHGe137338e926b: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize
Sat, Dec 7, 12:54 PM
durin42 committed rHG5a9e2ae9899b: fuzz: use a more standard approach to allow local builds of fuzzers.
fuzz: use a more standard approach to allow local builds of fuzzers
Sat, Dec 7, 12:54 PM
durin42 committed rHGbf0453866c80: fuzz: use a variable to allow specifying python-config to use.
fuzz: use a variable to allow specifying python-config to use
Sat, Dec 7, 12:54 PM
durin42 committed rHGd1587fadff06: fuzz: suppress deprecated-register warnings in our compile.
fuzz: suppress deprecated-register warnings in our compile
Sat, Dec 7, 12:54 PM
durin42 committed rHG51a99e09c54b: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
fuzz: always define LLVMFuzzerInitialize() even if we don't need it
Sat, Dec 7, 12:54 PM
durin42 committed rHG53f582bee3d1: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE
Sat, Dec 7, 12:54 PM
durin42 committed rHGc78f8f0720cc: fuzz: fix an unused result on getcwd() in pyutil.
fuzz: fix an unused result on getcwd() in pyutil
Sat, Dec 7, 12:54 PM
durin42 committed rHG54a6846ba96f: fuzz: remove debug prints from revlog_corpus.py.
fuzz: remove debug prints from revlog_corpus.py
Sat, Dec 7, 12:54 PM
marmoute committed rHGacbb55b8e9dc: upgraderepo: add a config option for parallel computation.
upgraderepo: add a config option for parallel computation
Sat, Dec 7, 12:54 PM
marmoute committed rHGad84fc97d120: upgrade-repo: colorize some of the output.
upgrade-repo: colorize some of the output
Sat, Dec 7, 12:54 PM
quark added a comment to D1518: nodemap: move some methods to changelog utils.

No longer use this approach.

Sat, Dec 7, 2:14 AM
quark abandoned D1519: childmap: add a map for efficient children query.
Sat, Dec 7, 2:13 AM
quark added a comment to D1520: clindex: integrate Rust childmap.

No longer use this approach.

Sat, Dec 7, 2:13 AM
quark added a comment to D1521: clindex: use childmap to calculate phases.

Took another approach.

Sat, Dec 7, 2:13 AM
quark added a comment to D1665: perftweaks: pass a correct revgen to branchcache.update.

No longer needed.

Sat, Dec 7, 2:12 AM

Yesterday

yuja added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
if listsubrepos:
    for subpath in ctx.substate:
  • sm = ctx.sub(subpath).matchfileset(pat, badfn=badfn)

+ sm = ctx.sub(subpath).matchfileset(
+ pat, badfn=badfn, cwd=cwd
+ )

Fri, Dec 6, 11:56 PM
mharbison72 created D7572: tests: stabilize test-extdiff.t on Windows.
Fri, Dec 6, 11:49 PM
indygreg created D7571: automation: use latest Windows AMI as base.
Fri, Dec 6, 11:12 PM
durin42 closed D7564: fuzz: use a more standard approach to allow local builds of fuzzers.
Fri, Dec 6, 11:04 PM
durin42 closed D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
Fri, Dec 6, 11:04 PM
durin42 closed D7568: fuzz: clean up some repetition on building parsers.so fuzzers.
Fri, Dec 6, 11:04 PM
durin42 committed rHGceeff2d99cc9: fuzz: clean up some repetition on building parsers.so fuzzers.
fuzz: clean up some repetition on building parsers.so fuzzers
Fri, Dec 6, 11:04 PM
durin42 closed D7566: tests: finally fix up test-fuzz-targets.t.
Fri, Dec 6, 11:04 PM
durin42 committed rHG7857bd9bb2b0: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
fuzz: remove legacy setup for running fuzzers outside oss-fuzz
Fri, Dec 6, 11:04 PM
durin42 closed D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
Fri, Dec 6, 11:04 PM
durin42 committed rHGece907920139: tests: finally fix up test-fuzz-targets.t.
tests: finally fix up test-fuzz-targets.t
Fri, Dec 6, 11:04 PM
durin42 committed rHG01ec70a80a7b: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize
Fri, Dec 6, 11:03 PM
durin42 committed rHG28a91a581fd9: fuzz: use a more standard approach to allow local builds of fuzzers.
fuzz: use a more standard approach to allow local builds of fuzzers
Fri, Dec 6, 11:03 PM
D7568: fuzz: clean up some repetition on building parsers.so fuzzers is now accepted and ready to land.
Fri, Dec 6, 11:02 PM
D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz is now accepted and ready to land.
Fri, Dec 6, 11:01 PM
D7566: tests: finally fix up test-fuzz-targets.t is now accepted and ready to land.
Fri, Dec 6, 11:01 PM
durin42 closed D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
Fri, Dec 6, 10:59 PM
D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize is now accepted and ready to land.
Fri, Dec 6, 10:59 PM
durin42 closed D7563: fuzz: use a variable to allow specifying python-config to use.
Fri, Dec 6, 10:59 PM
durin42 committed rHG4445e2775066: fuzz: use a variable to allow specifying python-config to use.
fuzz: use a variable to allow specifying python-config to use
Fri, Dec 6, 10:59 PM
durin42 closed D7562: fuzz: suppress deprecated-register warnings in our compile.
Fri, Dec 6, 10:59 PM
durin42 closed D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
Fri, Dec 6, 10:59 PM
durin42 committed rHG28be1932f61f: fuzz: suppress deprecated-register warnings in our compile.
fuzz: suppress deprecated-register warnings in our compile
Fri, Dec 6, 10:59 PM
durin42 committed rHG7cb99887bcc3: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE
Fri, Dec 6, 10:59 PM
durin42 committed rHG0a56e5f26a52: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
fuzz: always define LLVMFuzzerInitialize() even if we don't need it
Fri, Dec 6, 10:59 PM
D7564: fuzz: use a more standard approach to allow local builds of fuzzers is now accepted and ready to land.
Fri, Dec 6, 10:59 PM
durin42 closed D7559: fuzz: remove debug prints from revlog_corpus.py.
Fri, Dec 6, 10:59 PM
durin42 committed rHG98eb12eab5e5: fuzz: remove debug prints from revlog_corpus.py.
fuzz: remove debug prints from revlog_corpus.py
Fri, Dec 6, 10:59 PM
durin42 closed D7558: fuzz: fix an unused result on getcwd() in pyutil.
Fri, Dec 6, 10:59 PM
durin42 committed rHGf6c0b0510b49: fuzz: fix an unused result on getcwd() in pyutil.
fuzz: fix an unused result on getcwd() in pyutil
Fri, Dec 6, 10:59 PM
D7563: fuzz: use a variable to allow specifying python-config to use is now accepted and ready to land.
Fri, Dec 6, 10:57 PM
yuja added a comment to D7550: chg: fix chg to work with py3.7+ "coercing" the locale.
When the environment is empty (specifically: it doesn't contain LC_ALL,
LC_CTYPE, or LANG), Python will "coerce" the locale environment variables to be
a UTF-8 capable one. It sets LC_CTYPE in the environment, and this breaks chg,
since chg operates by:
- start hg, using whatever environment the user has when chg starts
- hg stores a hash of this "original" environment, but python has already set LC_CTYPE even though the user doesn't have it in their environment
- chg calls setenv over the commandserver. This clears the environment inside of hg and sets it to be exactly what the environment in chg is (without LC_CTYPE).
- chg calls validate to ensure that the environment hg is using (after the setenv call) is the one that the chg process has - if not, it is assumed the user changed their environment and we should use a different server. This will *never* be true in this situation because LC_CTYPE was removed.
Fri, Dec 6, 10:57 PM
D7562: fuzz: suppress deprecated-register warnings in our compile is now accepted and ready to land.
Fri, Dec 6, 10:57 PM
D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE is now accepted and ready to land.
Fri, Dec 6, 10:57 PM
D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it is now accepted and ready to land.
Fri, Dec 6, 10:56 PM
D7559: fuzz: remove debug prints from revlog_corpus.py is now accepted and ready to land.
Fri, Dec 6, 10:56 PM
D7558: fuzz: fix an unused result on getcwd() in pyutil is now accepted and ready to land.
Fri, Dec 6, 10:56 PM
mharbison72 updated subscribers of D7570: match: resolve filesets against the passed `cwd`, not the current one.

CC: @martinvonz

Fri, Dec 6, 10:44 PM
mharbison72 created D7570: match: resolve filesets against the passed `cwd`, not the current one.
Fri, Dec 6, 10:16 PM
mharbison72 created D7569: tests: show that fileset patterns don't work with `fix` when not in repo root.
Fri, Dec 6, 10:15 PM
durin42 created D7568: fuzz: clean up some repetition on building parsers.so fuzzers.
Fri, Dec 6, 4:12 PM
durin42 created D7564: fuzz: use a more standard approach to allow local builds of fuzzers.
Fri, Dec 6, 3:52 PM
durin42 created D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
Fri, Dec 6, 3:52 PM
durin42 created D7566: tests: finally fix up test-fuzz-targets.t.
Fri, Dec 6, 3:51 PM
durin42 created D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
Fri, Dec 6, 3:51 PM
durin42 created D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
Fri, Dec 6, 3:51 PM
durin42 created D7563: fuzz: use a variable to allow specifying python-config to use.
Fri, Dec 6, 3:51 PM
durin42 created D7562: fuzz: suppress deprecated-register warnings in our compile.
Fri, Dec 6, 3:51 PM
durin42 created D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
Fri, Dec 6, 3:51 PM
durin42 created D7558: fuzz: fix an unused result on getcwd() in pyutil.
Fri, Dec 6, 3:50 PM
durin42 created D7559: fuzz: remove debug prints from revlog_corpus.py.
Fri, Dec 6, 3:50 PM
marmoute committed rHG982a91c23849: upgraderepo: add a config option for parallel computation.
upgraderepo: add a config option for parallel computation
Fri, Dec 6, 3:50 PM
marmoute committed rHG91007890d366: upgrade-repo: colorize some of the output.
upgrade-repo: colorize some of the output
Fri, Dec 6, 3:50 PM
durin42 added a comment to D7557: annotate: describe --skip as taking a revset.

It said revision before, so at a minimum we should add an s...

Fri, Dec 6, 1:12 PM
pulkit added a comment to D7557: annotate: describe --skip as taking a revset.

Isn't it that where ever we says revisions we imply revsets?

Fri, Dec 6, 1:10 PM
pulkit added a comment to D7521: amend: check for file modifications when updating dirstate (issue6233).

Looks like I forgot to drop this from my queue and pushed it. :(

Fri, Dec 6, 1:05 PM
durin42 created D7557: annotate: describe --skip as taking a revset.
Fri, Dec 6, 1:00 PM
Paul Sonnenschein <paul@sonnenschein.ruhr> closed D7556: tests: remove hardcoded errno values.
Fri, Dec 6, 10:43 AM
Paul Sonnenschein <paul@sonnenschein.ruhr> committed rHG76d32a0edbc6: tests: remove hardcoded errno values.
tests: remove hardcoded errno values
Fri, Dec 6, 10:43 AM
spectral closed D7521: amend: check for file modifications when updating dirstate (issue6233).
Fri, Dec 6, 10:38 AM
spectral closed D7552: tests: fix deprecation warning about regex flags not at beginning of expr.
Fri, Dec 6, 10:38 AM
spectral committed rHGe6cda6efb12a: tests: expect return status 255 on exception for test-blackbox.t with chg.
tests: expect return status 255 on exception for test-blackbox.t with chg
Fri, Dec 6, 10:38 AM
spectral closed D7554: tests: expect return status 255 on exception for test-blackbox.t with chg.
Fri, Dec 6, 10:38 AM
spectral closed D7553: tests: fix command name in test-blackbox.t to be bytes.
Fri, Dec 6, 10:38 AM
spectral committed rHGc6b4c348360e: tests: fix command name in test-blackbox.t to be bytes.
tests: fix command name in test-blackbox.t to be bytes
Fri, Dec 6, 10:37 AM
spectral committed rHG3fe91bcd5199: tests: fix deprecation warning about regex flags not at beginning of expr.
tests: fix deprecation warning about regex flags not at beginning of expr
Fri, Dec 6, 10:37 AM
spectral closed D7551: tests: fix test-chg.t to work with py3 (no setprocname).
Fri, Dec 6, 10:37 AM