Page MenuHomePhabricator
Feed All Stories

Today

marmoute created D9865: store: use `endswith` to detect revlog extension.
Mon, Jan 25, 4:32 PM
SimonSapin created D9863: rust: Make NodePrefix allocation-free and Copy, remove NodePrefixRef.
Mon, Jan 25, 4:14 PM
SimonSapin created D9864: rust: Remove hex parsing from the nodemap.
Mon, Jan 25, 4:14 PM
SimonSapin created D9862: rust: Exclude empty node prefixes.
Mon, Jan 25, 4:13 PM
SimonSapin created D9861: rust: Simplify error type for reading hex node IDs.
Mon, Jan 25, 4:13 PM
SimonSapin created D9860: rust: replace Node::encode_hex with std::fmt::LowerHex.
Mon, Jan 25, 4:12 PM
valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

Closing the peer is what I was describing as solution 3 in D9019. But I think I was wrong in saying that it doesn't help with calls to logtoprocess in the middle of commands. I also just noticed that does that, in fact. I'll try and find some time to do that.

Mon, Jan 25, 11:49 AM
valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

What's holding this back is lack of py2 compatibility. Although maybe I want to wait it out at this point. Do we expect to drop py3 in a few days, after 5.7 is released for instance?

Mon, Jan 25, 11:38 AM
valentin.gatienbaron abandoned D9284: purge: move extension into core mercurial.
Mon, Jan 25, 11:30 AM
marmoute added inline comments to D9810: persistent-nodemap: also exchange the nodemap data over the wire.
Mon, Jan 25, 10:34 AM
marmoute added a comment to D9789: clone: make sure we warm the cache after a clone.

I'm -0 on this change. Caches are caches and IMO should only be populated on demand.

Mon, Jan 25, 10:24 AM
marmoute added inline comments to D9760: persistent-node: check the value of the slow-path config.
Mon, Jan 25, 10:19 AM
instantfinance24 updated instantfinance24.
Mon, Jan 25, 9:16 AM
kevinbooth21 updated kevinbooth21.
Mon, Jan 25, 8:40 AM
nicolassmith8 updated nicolassmith8.
Mon, Jan 25, 8:10 AM
Robertmccroy updated Robertmccroy.
Mon, Jan 25, 7:19 AM
jonmathews updated jonmathews.
Mon, Jan 25, 6:58 AM
fgfdgdfgdf updated fgfdgdfgdf.
Mon, Jan 25, 6:03 AM
manisha_grg updated manisha_grg.
Mon, Jan 25, 5:48 AM
SimonSapin created D9859: rust: replace an unsafe use of transmute with a safe use of bytes-cast.
Mon, Jan 25, 5:34 AM
Idamdavis updated Idamdavis.
Mon, Jan 25, 5:07 AM
ezequielvince updated ezequielvince.
Mon, Jan 25, 4:40 AM
laticiagibson updated laticiagibson.
Mon, Jan 25, 3:32 AM
softencreativeuk updated softencreativeuk.
Mon, Jan 25, 2:17 AM
morganwill updated morganwill.
Mon, Jan 25, 1:28 AM
hennabeth updated hennabeth.
Mon, Jan 25, 12:46 AM
hennabeth updated hennabeth.
Mon, Jan 25, 12:46 AM

Yesterday

mharbison72 archived Get personalized coffee mugs for sisters from lulufam.
Sun, Jan 24, 11:54 PM
jonwick created Get personalized coffee mugs for sisters from lulufam.
Sun, Jan 24, 11:47 PM
indygreg closed D9858: contrib: update PyOxidizer to 0.10.3.
Sun, Jan 24, 10:20 PM
indygreg committed rHGa6c5ec6b4728: contrib: update PyOxidizer to 0.10.3.
contrib: update PyOxidizer to 0.10.3
Sun, Jan 24, 10:20 PM
D9858: contrib: update PyOxidizer to 0.10.3 is now accepted and ready to land.
Sun, Jan 24, 10:13 PM
indygreg created D9858: contrib: update PyOxidizer to 0.10.3.
Sun, Jan 24, 9:28 PM
indygreg added a comment to D9843: revlog: introduce v2 format.

I'm not going to review this right now, but I have prior art at https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-February/093657.html and https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-May/097960.html that might be worth a read. I believe the wiki page on this format only contains a subset of the deficiencies I outlined in the 1st link.

Sun, Jan 24, 8:50 PM
mharbison72 added a comment to D9856: packaging: allow specifying modules to include with py2exe.

This is meant for stable, to avoid a partial installation.

Sun, Jan 24, 8:34 PM
mharbison72 created D9856: packaging: allow specifying modules to include with py2exe.
Sun, Jan 24, 8:33 PM
mharbison72 created D9857: packaging: include `windows_curses` when building py2exe.
Sun, Jan 24, 8:33 PM
roy added a comment to D9848: fastexport: committer name should not be quoted.

So if I send an email, using thunderbird, 9 folders or gmail and look at the email source the email name is not quoted.
All I ask is that hg behaves the same way. That should not be took much to ask?

Sun, Jan 24, 6:16 PM
roy added a comment to D9848: fastexport: committer name should not be quoted.

Horrible parsing code, but not relevant for here. I gave the reasons why the original code used "", but I don't care either way if git doesn't fall apart anymore than already does when an address is not pretending to be a mail.

Sun, Jan 24, 6:14 PM
joerg.sonnenberger added a comment to D9848: fastexport: committer name should not be quoted.

Horrible parsing code, but not relevant for here. I gave the reasons why the original code used "", but I don't care either way if git doesn't fall apart anymore than already does when an address is not pretending to be a mail.

Sun, Jan 24, 6:02 PM
indygreg added a comment to D9516: perf: use the `perf--` prefix for perf command.

The -- also bothers me and I came here to see if it had been discussed before accepting this patch.

Sun, Jan 24, 5:32 PM
mharbison72 added a comment to D9808: hghave: adjust the definition of `tic` to allow curses tests on Windows.

Shouldn't this patch be checking for the existence of the windows_curses package instead?

Sun, Jan 24, 3:57 PM
indygreg added inline comments to D9810: persistent-nodemap: also exchange the nodemap data over the wire.
Sun, Jan 24, 3:33 PM
indygreg added a comment to D9808: hghave: adjust the definition of `tic` to allow curses tests on Windows.

Shouldn't this patch be checking for the existence of the windows_curses package instead?

Sun, Jan 24, 3:32 PM
indygreg added a comment to D9789: clone: make sure we warm the cache after a clone.

I'm -0 on this change. Caches are caches and IMO should only be populated on demand.

Sun, Jan 24, 3:27 PM
indygreg added inline comments to D9760: persistent-node: check the value of the slow-path config.
Sun, Jan 24, 3:17 PM
indygreg added a comment to D9695: upgrade: don't perform anything if nothing to do.

I mostly support this change. However, a supposed no-op upgrade may still result in differences! For example, if we change the algorithm for computing how revlog deltas are computed without actually changing the storage semantics, performing a no-op upgrade would migrate the store to use the new code.

Sun, Jan 24, 2:57 PM
Alphare accepted D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Sun, Jan 24, 12:23 AM

Sat, Jan 23

jendavis created Things to Consider When Picking a Coffee Machine For Your Home.
Sat, Jan 23, 2:14 PM
marmoute added a comment to D9516: perf: use the `perf--` prefix for perf command.

Big picture, why do we need to be able to tell namespace parts from command parts?

To make sure the user understand they are stepping in an entire different realm with different rules.
In the standard namespace (no prefix) we garantee (or aims at) the lack of footgun and excellent backward compatibility.
The debug namespace should not be somewhere any normal user ever have to go (at least without a responsible staff member)
The admin namespace will have its own rules and its own "be careful, this is not a "normal" situation to be there.
So we want something more distincting than just a simple - that we could have for "command group" or readability like phab-send, phab-read, etc.

So it sounds like more of a convention for these behavior properties than say, commands in the admin group requiring --yes-i-know-this-may-eat-my-data. We'll have to have to figure out how to convey that somehow. I see admin, for example, and think "I'm in charge of making this work for my group, and it sounds like it does what I want, so it's for me and just some extra characters to type". I don't have any suggestions on how to highlight these behaviors ATM.

Sat, Jan 23, 5:32 AM

Fri, Jan 22

Elizbeth644 updated Elizbeth644.
Fri, Jan 22, 11:47 PM
Elizbeth644 updated Elizbeth644.
Fri, Jan 22, 11:45 PM
Victor Stinner <vstinner@python.org> closed D9825: cext: add Python 3.10 support.
Fri, Jan 22, 9:16 PM
Victor Stinner <vstinner@python.org> committed rHGe92ca942ddca: cext: add Python 3.10 support.
cext: add Python 3.10 support
Fri, Jan 22, 9:14 PM
indygreg added a comment to D9825: cext: add Python 3.10 support.

Do you think we should go ahead and apply the local patch then until we can update the vendored copy?

Fri, Jan 22, 9:10 PM
durin42 added a comment to D9825: cext: add Python 3.10 support.

Do you think we should go ahead and apply the local patch then until we can update the vendored copy?

Fri, Jan 22, 9:08 PM
indygreg added a comment to D9825: cext: add Python 3.10 support.

Yes, please remove the python-zstandard changes from here, and send them directly to @indygreg upstream for that.

Fri, Jan 22, 8:25 PM
mharbison72 closed D9851: share-safe: fix an abort message that references the experimental requirement.
Fri, Jan 22, 4:25 PM
Alphare closed D9717: contrib: stop building rust for every job.
Fri, Jan 22, 4:24 PM
Alphare committed rHGe78dea142968: contrib: stop building rust for every job.
contrib: stop building rust for every job
Fri, Jan 22, 4:24 PM
mharbison72 committed rHG085294a8c0e0: share-safe: fix an abort message that references the experimental requirement.
share-safe: fix an abort message that references the experimental requirement
Fri, Jan 22, 4:24 PM
mharbison72 committed rHGe30ef4a36e1d: doc: fix a formatting error in requirements.txt.
doc: fix a formatting error in requirements.txt
Fri, Jan 22, 4:24 PM
mharbison72 closed D9850: doc: fix a formatting error in requirements.txt.
Fri, Jan 22, 4:24 PM
mharbison72 committed rHG86842c4accc1: doc: drop the `exp-` prefix from the `share-safe` requirement.
doc: drop the `exp-` prefix from the `share-safe` requirement
Fri, Jan 22, 4:24 PM
mharbison72 closed D9849: doc: drop the `exp-` prefix from the `share-safe` requirement.
Fri, Jan 22, 4:24 PM
durin42 created D9855: histedit: rip out mysterious catch-all ignore curses.error handler.
Fri, Jan 22, 3:46 PM
durin42 created D9854: histedit: notice when the main window underflows height and abort.
Fri, Jan 22, 3:46 PM
durin42 created D9853: histedit: don't assign to _ for unused values.
Fri, Jan 22, 3:46 PM
roy added a comment to D9848: fastexport: committer name should not be quoted.

Finds the author command
https://github.com/git/git/blob/7f7ebe054af6d831b999d6c2241b9227c4e4e08d/builtin/fast-import.c#L2689

Fri, Jan 22, 3:45 PM
valentin.gatienbaron closed D9820: purge: move extension into core mercurial.
Fri, Jan 22, 3:41 PM
joerg.sonnenberger closed D9781: branchmap: update rev-branch-cache incrementally.
Fri, Jan 22, 3:40 PM
joerg.sonnenberger closed D9847: revlog: decouple caching from addrevision callback for addgroup.
Fri, Jan 22, 3:40 PM
joerg.sonnenberger committed rHG711ba0f1057e: revlog: decouple caching from addrevision callback for addgroup.
revlog: decouple caching from addrevision callback for addgroup
Fri, Jan 22, 3:40 PM
joerg.sonnenberger closed D9780: repository: introduce register_changeset callback.
Fri, Jan 22, 3:40 PM
joerg.sonnenberger committed rHG3e91d9978bec: branchmap: update rev-branch-cache incrementally.
branchmap: update rev-branch-cache incrementally
Fri, Jan 22, 3:39 PM
joerg.sonnenberger committed rHG0903d6b9b1df: repository: introduce register_changeset callback.
repository: introduce register_changeset callback
Fri, Jan 22, 3:39 PM
Dan Villiom Podlaski Christiansen <danchr@gmail.com> closed D9852: rust: lower compile error on non-linux platforms to a warning.
Fri, Jan 22, 3:39 PM
joerg.sonnenberger closed D9779: changelog: move branchinfo to changelogrevision.
Fri, Jan 22, 3:39 PM
joerg.sonnenberger committed rHGcad17d50736c: changelog: move branchinfo to changelogrevision.
changelog: move branchinfo to changelogrevision
Fri, Jan 22, 3:39 PM
marmoute closed D9819: purge: also deal with directory with --confirm.
Fri, Jan 22, 3:39 PM
danchr committed rHGcabc5e9366c5: rust: lower compile error on non-linux platforms to a warning.
rust: lower compile error on non-linux platforms to a warning
Fri, Jan 22, 3:39 PM
marmoute closed D9818: purge: add a --confirm option.
Fri, Jan 22, 3:39 PM
valentin.gatienbaron committed rHGbb3a5c0df06b: purge: move extension into core mercurial.
purge: move extension into core mercurial
Fri, Jan 22, 3:38 PM
marmoute committed rHG57370e7deb7b: purge: also deal with directory with --confirm.
purge: also deal with directory with --confirm
Fri, Jan 22, 3:38 PM
marmoute committed rHG135056e8b5a8: purge: add a --confirm option.
purge: add a --confirm option
Fri, Jan 22, 3:38 PM
joerg.sonnenberger added a comment to D9848: fastexport: committer name should not be quoted.

The basic concern I have here is that I have stepped on git's toes here before and the field is nowhere near as free text as it is supposed to be according to the specification. So any change should at least double check what the git code is actually doing, because it doesn't do the same as the documentation from what I have seen. Case in point is the data handling, where git does distingiush between +0 and -0.

Fri, Jan 22, 3:20 PM
durin42 added a comment to D9848: fastexport: committer name should not be quoted.

Should we add a test that, if git-fast-import is available, actually tries the import and verifies that things look reasonable?

Fri, Jan 22, 2:55 PM
D9825: cext: add Python 3.10 support now requires changes to proceed.

Yes, please remove the python-zstandard changes from here, and send them directly to @indygreg upstream for that.

Fri, Jan 22, 2:54 PM
pulkit added inline comments to D9820: purge: move extension into core mercurial.
Fri, Jan 22, 11:48 AM
SimonSapin added inline comments to D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Fri, Jan 22, 11:48 AM
SimonSapin updated the diff for D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Fri, Jan 22, 11:43 AM
SimonSapin updated the diff for D9683: copies-rust: split up combine_changeset_copies function into a struct.
Fri, Jan 22, 11:43 AM
pulkit added inline comments to D9844: revlogv2: allow upgrading to v2.
Fri, Jan 22, 11:42 AM
pulkit added a comment to D9843: revlog: introduce v2 format.

Couple of changes from this patch can be separated and send individually as prepare for revlog v2 which will help speed up review.

Fri, Jan 22, 11:40 AM
pulkit added a comment to D9825: cext: add Python 3.10 support.

The contrib/zstandard/ changes should be dropped from this patch. IIRC, Victor already created a PR for that.

Fri, Jan 22, 11:36 AM
D9852: rust: lower compile error on non-linux platforms to a warning is now accepted and ready to land.
Fri, Jan 22, 11:35 AM
Alphare added inline comments to D9819: purge: also deal with directory with --confirm.
Fri, Jan 22, 11:01 AM
Alphare accepted D9685: copies-rust: introduce PyBytesWithData to reduce GIL requirement.
Fri, Jan 22, 11:00 AM
roy added a comment to D9848: fastexport: committer name should not be quoted.

So just for kicks I did hg fastexport on my dhcpcd repo where the author names look fine.
I then did hg fastimport (3rd party plugin) on the resultant fast-import file generated from the above.

Fri, Jan 22, 10:07 AM
roy added a comment to D9848: fastexport: committer name should not be quoted.

Using git to create a fast-import, the comitter is never quoted.
Again, using git to import a quoted comitter name, preserves the quotes.
Using git log to display the import, the comitters name appears as "Roy Marples" <roy@marples.name> which just looks wrong.

Fri, Jan 22, 9:50 AM