Feed All Stories

Today

lothiraldan created D5445: tests: followup on network related errors on Debian 9.
Sun, Dec 16, 1:52 PM
yuja committed rHG2393c4044214: py3: unimplement RevlogError.__str__().
py3: unimplement RevlogError.__str__()
Sun, Dec 16, 8:56 AM
yuja committed rHG8c8fcb385c46: py3: use forcebytestr() to stringify hook exception.
py3: use forcebytestr() to stringify hook exception
Sun, Dec 16, 8:56 AM
mharbison72 committed rHG7654291091cf: color: fix a documentation typo.
color: fix a documentation typo
Sun, Dec 16, 3:27 AM
gracinet committed rHG74f41329bf55: rust-cpython: testing the bindings from Python.
rust-cpython: testing the bindings from Python
Sun, Dec 16, 3:27 AM
mharbison72 committed rHG55fcdb73c88b: py3: quote $PYTHON in test-patchbomb.t for Windows.
py3: quote $PYTHON in test-patchbomb.t for Windows
Sun, Dec 16, 3:27 AM
gracinet committed rHG462a26756f70: rust-cpython: build via HGWITHRUSTEXT=cpython.
rust-cpython: build via HGWITHRUSTEXT=cpython
Sun, Dec 16, 3:27 AM
gracinet committed rHG5532823e8c18: rust-cpython: start cpython crate bindings.
rust-cpython: start cpython crate bindings
Sun, Dec 16, 3:27 AM
gracinet committed rHG1eaf62a67c1a: rust: better treatment of cargo/rustc errors.
rust: better treatment of cargo/rustc errors
Sun, Dec 16, 3:27 AM
lothiraldan committed rHG2e305e54eae3: sparse-revlog: protect C code against delta chain including nullrev.
sparse-revlog: protect C code against delta chain including nullrev
Sun, Dec 16, 3:27 AM
gracinet committed rHG98a0fbda8739: rust-cpython: exclude hgcli from workspace.
rust-cpython: exclude hgcli from workspace
Sun, Dec 16, 3:27 AM
lothiraldan committed rHG43974cd44967: revlog: introduce a constant for nullrev in `revlog.c`.
revlog: introduce a constant for nullrev in `revlog.c`
Sun, Dec 16, 3:27 AM
lothiraldan committed rHGc6939b353ebd: sparse-revlog: handle nullrev in index_get_length.
sparse-revlog: handle nullrev in index_get_length
Sun, Dec 16, 3:27 AM
lothiraldan committed rHGb54727f82511: sparse-revlog: handle nullrev in index_get_start.
sparse-revlog: handle nullrev in index_get_start
Sun, Dec 16, 3:27 AM
madprog committed rHGabd7b75e80bc: contrib: provide a small script that draw performance plot.
contrib: provide a small script that draw performance plot
Sun, Dec 16, 3:27 AM
gracinet committed rHGd097dd0afc19: rust: translation of missingancestors.
rust: translation of missingancestors
Sun, Dec 16, 3:27 AM
lothiraldan committed rHG74ee5ff1e81c: perf: report more of the higher range in perfrevlogwrite.
perf: report more of the higher range in perfrevlogwrite
Sun, Dec 16, 3:27 AM
lothiraldan committed rHGf960c51eebf3: delta: filter nullrev out first.
delta: filter nullrev out first
Sun, Dec 16, 3:27 AM
martinvonz committed rHGf6187e60f792: help: present boolean arguments as "--[no-]foo".
help: present boolean arguments as "--[no-]foo"
Sun, Dec 16, 3:27 AM
martinvonz committed rHG8604f130eb43: help: show "default: off" for boolean flags that default to off.
help: show "default: off" for boolean flags that default to off
Sun, Dec 16, 3:27 AM
martinvonz committed rHG05abb5fb146a: help: use "default: on" instead of "default: True".
help: use "default: on" instead of "default: True"
Sun, Dec 16, 3:27 AM
pulkit committed rHG52fbf8a9907c: py3: add a b'' prefix in tests/test-remotefilelog-pull-noshallow.t.
py3: add a b'' prefix in tests/test-remotefilelog-pull-noshallow.t
Sun, Dec 16, 3:27 AM
hooper committed rHGe993a86cfcb8: absorb: don't prompt to apply changes when there are none to apply.
absorb: don't prompt to apply changes when there are none to apply
Sun, Dec 16, 3:27 AM
martinvonz committed rHG811f772b44aa: check-commit: disallow capitalization only right after topic.
check-commit: disallow capitalization only right after topic
Sun, Dec 16, 3:27 AM
durin42 committed rHGf732889abe0e: error: implement __str__ on RevlogError to fix some output defects on Py3.
error: implement __str__ on RevlogError to fix some output defects on Py3
Sun, Dec 16, 3:27 AM
durin42 committed rHGa314eafd7c8d: perf: add two more missing b prefixes for Python 3.
perf: add two more missing b prefixes for Python 3
Sun, Dec 16, 3:27 AM
durin42 committed rHG9e462fb88f79: match: fix doctest to use bytes instead of str.
match: fix doctest to use bytes instead of str
Sun, Dec 16, 3:27 AM
pulkit committed rHG5fd63bca43a4: py3: use pycompat.bytechr() instead of chr() in test-fastannotate-revmap.py.
py3: use pycompat.bytechr() instead of chr() in test-fastannotate-revmap.py
Sun, Dec 16, 3:27 AM
pulkit committed rHGebc471ce9fad: py3: add a missing b'' prefix in contrib/perf.py.
py3: add a missing b'' prefix in contrib/perf.py
Sun, Dec 16, 3:27 AM
pulkit committed rHG789515904b03: py3: use '%d' for integers instead of '%s'.
py3: use '%d' for integers instead of '%s'
Sun, Dec 16, 3:27 AM
pulkit committed rHG205c639ce27d: py3: whitelist another passing test caught by buildbot.
py3: whitelist another passing test caught by buildbot
Sun, Dec 16, 3:27 AM
yuja committed rHGe48fdeb08c77: py3: fix bad escapes of sub() replacement pattern in test-template-basic.t.
py3: fix bad escapes of sub() replacement pattern in test-template-basic.t
Sun, Dec 16, 3:27 AM
gracinet committed rHGdb6cace18765: perfdiscovery: benching findcommonheads().
perfdiscovery: benching findcommonheads()
Sun, Dec 16, 3:27 AM
yuja added a comment to D5409: remotefilelog: accepting a None node to cmp.

I'm dropping this since I found a bug in memfilectx. That's probably why
absorb crashed.

Sun, Dec 16, 3:22 AM
mharbison72 committed rHGf1a69099327b: color: fix a documentation typo.
color: fix a documentation typo
Sun, Dec 16, 12:39 AM
mharbison72 committed rHG12bbb8b95280: py3: quote $PYTHON in test-patchbomb.t for Windows.
py3: quote $PYTHON in test-patchbomb.t for Windows
Sun, Dec 16, 12:39 AM

Yesterday

yuja added a comment to D5442: rust-cpython: using the new bindings from Python.

+try:
+ from . import rustext
+except ImportError:
+ rustext = None

Sat, Dec 15, 11:46 PM
yuja added a comment to D5443: ancestor: uniformity of calling lazyancestors classes.

+def parentsfunc(index):
+ def parentrevs(rev):
+ try:
+ entry = index[rev]
+ except IndexError:
+ if rev == wdirrev:
+ raise error.WdirUnsupported
+ raise
+
+ return entry[5], entry[6]
+ return parentrevs

Sat, Dec 15, 11:46 PM
yuja added a comment to D5441: rust-cpython: binding for LazyAncestors.

Nit: While it's correct per our naming convention, I prefer calling it
as LazyAncestors in Rust, and export as lazyancestors.

Sat, Dec 15, 11:45 PM
yuja added a comment to D5440: rust: core implementation for lazyancestors.
  • a/rust/hg-core/src/lib.rs +++ b/rust/hg-core/src/lib.rs @@ -2,8 +2,10 @@ This software may be used and distributed according to the terms of the // GNU General Public License version 2 or any later version. +use std::clone::Clone;
Sat, Dec 15, 11:45 PM
yuja added a comment to D5439: rust-cpython: binding for AncestorsIterator.
// GNU General Public License version 2 or any later version.
  • //! Bindings for the hg::ancestors module provided by the
Sat, Dec 15, 11:02 PM
yuja added a comment to D5438: rust-cpython: implementing Graph using C parents function.

+type IndexParentsFn = unsafe extern "C" fn(
+ index: *mut python_sys::PyObject,
+ rev: ssize_t,
+ ps: *mut [c_int; 2],
+ max_rev: c_int,
+) -> c_int;

Sat, Dec 15, 10:42 PM
gracinet closed D5434: rust-cpython: started cpython crate bindings.
Sat, Dec 15, 10:31 PM
gracinet closed D5433: rust-cpython: excluded hgcli from workspace.
Sat, Dec 15, 10:30 PM
gracinet committed rHG57e3dfeb3a5d: rust-cpython: testing the bindings from Python.
rust-cpython: testing the bindings from Python
Sat, Dec 15, 10:30 PM
gracinet closed D5436: rust-cpython: build via HGWITHRUSTEXT=cpython.
Sat, Dec 15, 10:30 PM
gracinet closed D5437: rust-cpython: testing the bindings from Python.
Sat, Dec 15, 10:30 PM
gracinet committed rHG9e755c16f05d: rust-cpython: build via HGWITHRUSTEXT=cpython.
rust-cpython: build via HGWITHRUSTEXT=cpython
Sat, Dec 15, 10:30 PM
gracinet closed D5435: rust: better treatment of cargo/rustc errors.
Sat, Dec 15, 10:30 PM
gracinet committed rHG5955cf85ed74: rust: better treatment of cargo/rustc errors.
rust: better treatment of cargo/rustc errors
Sat, Dec 15, 10:30 PM
gracinet committed rHGa3ba080b3118: rust-cpython: start cpython crate bindings.
rust-cpython: start cpython crate bindings
Sat, Dec 15, 10:30 PM
gracinet committed rHG6e815adf91de: rust-cpython: exclude hgcli from workspace.
rust-cpython: exclude hgcli from workspace
Sat, Dec 15, 10:30 PM
lothiraldan committed rHGadff02d0cb23: sparse-revlog: protect C code against delta chain including nullrev.
sparse-revlog: protect C code against delta chain including nullrev
Sat, Dec 15, 10:30 PM
lothiraldan committed rHG2cfebe51a57a: sparse-revlog: handle nullrev in index_get_length.
sparse-revlog: handle nullrev in index_get_length
Sat, Dec 15, 10:30 PM
lothiraldan committed rHG8eb47e7f032f: revlog: introduce a constant for nullrev in `revlog.c`.
revlog: introduce a constant for nullrev in `revlog.c`
Sat, Dec 15, 10:30 PM
lothiraldan committed rHGedfc0a1f2bec: sparse-revlog: handle nullrev in index_get_start.
sparse-revlog: handle nullrev in index_get_start
Sat, Dec 15, 10:30 PM
yuja added a comment to D5434: rust-cpython: started cpython crate bindings.

I've queued the first 5 patches, thanks. Please send a follow up to fix nits
and minor issues.

Sat, Dec 15, 10:22 PM
yuja added a comment to D5436: rust-cpython: build via HGWITHRUSTEXT=cpython.

I expect we'll soon drop the support for the old ffi binding.

Sat, Dec 15, 10:22 PM
yuja added a comment to D5435: rust: better treatment of cargo/rustc errors.

+ cargocmd = ['cargo', 'build', '-vv', '--release']
+ try:
+ subprocess.check_call(cargocmd, env=env, cwd=self.rustsrcdir)
+ except OSError as exc:
+ if exc.errno == os.errno.ENOENT:

Sat, Dec 15, 10:22 PM
yuja added a comment to D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".

I feel --no-<thing> and --<thing>=off|false are more natural, and
(default: %s) is the latter form.

Sat, Dec 15, 8:48 PM
mharbison72 committed rHG8d9f366b7f19: vfs: ensure closewrapbase fh doesn't escape by entering context manager.
vfs: ensure closewrapbase fh doesn't escape by entering context manager
Sat, Dec 15, 8:14 PM
mharbison72 committed rHG120ecb17242b: windows: ensure pure posixfile fd doesn't escape by entering context manager.
windows: ensure pure posixfile fd doesn't escape by entering context manager
Sat, Dec 15, 8:14 PM
mharbison72 committed rHG9ae4aed27930: windows: ensure mixedfilemodewrapper fd doesn't escape by entering context mgr.
windows: ensure mixedfilemodewrapper fd doesn't escape by entering context mgr
Sat, Dec 15, 8:14 PM
mharbison72 committed rHGe11e03f72baf: py3: ensure the proxied Windows fd doesn't escape by entering context manager.
py3: ensure the proxied Windows fd doesn't escape by entering context manager
Sat, Dec 15, 8:14 PM
martinvonz added a comment to D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".

Arguments against yes/no:

Sat, Dec 15, 2:47 PM
av6 added a comment to D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".

The point of D5430 was to make hg help output more human friendly by replacing True and False with something less Python-related. In other words, more human-friendly. "Yes" and "no" are way more human-friendly:

Sat, Dec 15, 1:03 PM
pulkit added a comment to D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".

TBH, I think 'on' and 'off' are more appropriate than 'yes' and 'no'.

Sat, Dec 15, 10:35 AM
kevincox accepted D5441: rust-cpython: binding for LazyAncestors.
Sat, Dec 15, 8:14 AM
kevincox accepted D5440: rust: core implementation for lazyancestors.
Sat, Dec 15, 8:08 AM
kevincox accepted D5439: rust-cpython: binding for AncestorsIterator.
Sat, Dec 15, 7:59 AM
gracinet added a comment to D5443: ancestor: uniformity of calling lazyancestors classes.

obviously, this one could be adapted for application before the rust-cpython bindings, and extended for the incrementalmissingancestors as well

Sat, Dec 15, 7:28 AM
gracinet added a comment to D5438: rust-cpython: implementing Graph using C parents function.

Here, I'd be tempted to submit a py_capsule_fn macro to rust-cpython, but I guess it can wait.

Sat, Dec 15, 7:02 AM
gracinet added a reviewer for D5433: rust-cpython: excluded hgcli from workspace: indygreg.
Sat, Dec 15, 6:52 AM
gracinet abandoned D5370: rust: core implementation of missingancestors (no bindings).

This Differential has been superseded by D5414 through D5417

Sat, Dec 15, 6:51 AM
av6 created D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".
Sat, Dec 15, 6:50 AM
gracinet created D5443: ancestor: uniformity of calling lazyancestors classes.
Sat, Dec 15, 6:43 AM
gracinet created D5442: rust-cpython: using the new bindings from Python.
Sat, Dec 15, 6:43 AM
gracinet created D5440: rust: core implementation for lazyancestors.
Sat, Dec 15, 6:43 AM
gracinet created D5441: rust-cpython: binding for LazyAncestors.
Sat, Dec 15, 6:43 AM
gracinet added a dependent revision for D5442: rust-cpython: using the new bindings from Python: D5443: ancestor: uniformity of calling lazyancestors classes.
Sat, Dec 15, 6:43 AM
gracinet created D5438: rust-cpython: implementing Graph using C parents function.
Sat, Dec 15, 6:43 AM
gracinet added a dependent revision for D5441: rust-cpython: binding for LazyAncestors: D5442: rust-cpython: using the new bindings from Python.
Sat, Dec 15, 6:42 AM
gracinet added a dependent revision for D5440: rust: core implementation for lazyancestors: D5441: rust-cpython: binding for LazyAncestors.
Sat, Dec 15, 6:42 AM
gracinet created D5434: rust-cpython: started cpython crate bindings.
Sat, Dec 15, 6:42 AM
gracinet created D5439: rust-cpython: binding for AncestorsIterator.
Sat, Dec 15, 6:42 AM
gracinet added a dependent revision for D5439: rust-cpython: binding for AncestorsIterator: D5440: rust: core implementation for lazyancestors.
Sat, Dec 15, 6:42 AM
gracinet added a dependent revision for D5438: rust-cpython: implementing Graph using C parents function: D5439: rust-cpython: binding for AncestorsIterator.
Sat, Dec 15, 6:42 AM
gracinet added a dependent revision for D5437: rust-cpython: testing the bindings from Python: D5438: rust-cpython: implementing Graph using C parents function.
Sat, Dec 15, 6:42 AM
gracinet created D5437: rust-cpython: testing the bindings from Python.
Sat, Dec 15, 6:42 AM
gracinet created D5436: rust-cpython: build via HGWITHRUSTEXT=cpython.
Sat, Dec 15, 6:42 AM
gracinet added a dependent revision for D5435: rust: better treatment of cargo/rustc errors: D5436: rust-cpython: build via HGWITHRUSTEXT=cpython.
Sat, Dec 15, 6:41 AM
gracinet created D5435: rust: better treatment of cargo/rustc errors.
Sat, Dec 15, 6:41 AM
gracinet created D5433: rust-cpython: excluded hgcli from workspace.
Sat, Dec 15, 6:41 AM
gracinet added a dependent revision for D5434: rust-cpython: started cpython crate bindings: D5435: rust: better treatment of cargo/rustc errors.
Sat, Dec 15, 6:41 AM
gracinet added a dependent revision for D5433: rust-cpython: excluded hgcli from workspace: D5434: rust-cpython: started cpython crate bindings.
Sat, Dec 15, 6:41 AM
gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja: I'll look into it, maybe that's a case for benches (I've not played with them yet).

Sat, Dec 15, 4:35 AM

Fri, Dec 14

yuja added a comment to D5417: rust: translated random test of missingancestors.
In case of a failed example, all needed information
for reproduction is included in the panic message,
so that we don't need to
seed the random generator explicitely. This is how
`test_remove_ancestors_from_case1()` has been generated.
Fri, Dec 14, 10:29 PM
gracinet closed D5416: rust: translation of missingancestors.
Fri, Dec 14, 10:20 PM
gracinet committed rHG5817c3b186a7: rust: translation of missingancestors.
rust: translation of missingancestors
Fri, Dec 14, 10:20 PM
yuja added a comment to D5416: rust: translation of missingancestors.

Queued this, thanks.

Fri, Dec 14, 10:19 PM