Page MenuHomePhabricator
Feed All Stories

Today

marmoute committed rHG2119647f127e: rawdata: update callers in storageutils.
rawdata: update callers in storageutils
Sun, Aug 18, 12:08 AM
marmoute committed rHG581a658e3fc8: rawdata: update callers in shallowbundle.
rawdata: update callers in shallowbundle
Sun, Aug 18, 12:08 AM
marmoute committed rHGe11e03190dc0: rawdata: update callers in delta utils.
rawdata: update callers in delta utils
Sun, Aug 18, 12:08 AM
marmoute committed rHGe6c55ad8216e: rawdata: update callers in test-revlog-raw.
rawdata: update callers in test-revlog-raw
Sun, Aug 18, 12:08 AM
marmoute committed rHGa6ad5f477ea1: rawdata: update callers in testing/storage.py.
rawdata: update callers in testing/storage.py
Sun, Aug 18, 12:08 AM
marmoute committed rHG7aac7f009f7c: rawdata: update callers in repository.
rawdata: update callers in repository
Sun, Aug 18, 12:08 AM
marmoute committed rHG0f2069f91bf2: rawdata: update callers in lfs' tests.
rawdata: update callers in lfs' tests
Sun, Aug 18, 12:08 AM
marmoute committed rHGe44d25456503: rawdata: update callers in lfs' wrapper.
rawdata: update callers in lfs' wrapper
Sun, Aug 18, 12:08 AM
marmoute committed rHGa6808d41d0ad: rawdata: update callers in debugcommands.
rawdata: update callers in debugcommands
Sun, Aug 18, 12:08 AM
marmoute committed rHG2d2e35c79ba1: rawdata: update caller in wireprotov2server.
rawdata: update caller in wireprotov2server
Sun, Aug 18, 12:08 AM
marmoute committed rHGac9fed512035: rawdata: update callers in sqlitestore.
rawdata: update callers in sqlitestore
Sun, Aug 18, 12:08 AM
marmoute committed rHGd53975bb429f: rawdata: update caller in remotefilelog.
rawdata: update caller in remotefilelog
Sun, Aug 18, 12:08 AM
marmoute committed rHGe6d5ac170906: rawdata: update callers in bundlerepo.
rawdata: update callers in bundlerepo
Sun, Aug 18, 12:08 AM
marmoute committed rHG1928f7bbe469: rawdata: update callers in context.
rawdata: update callers in context
Sun, Aug 18, 12:08 AM
marmoute committed rHG8890d68b8f8f: rawdata: update caller in revlog.
rawdata: update caller in revlog
Sun, Aug 18, 12:08 AM

Yesterday

pulkit created D6741: interfaces: create a new folder for interfaces and move repository.py in it.
Sat, Aug 17, 7:45 PM
pulkit created D6742: interfaceutil: move to interfaces/.
Sat, Aug 17, 7:44 PM
navaneeth.suresh added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
In D6731#98871, @pulkit wrote:

In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think?

Sat, Aug 17, 5:30 PM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Sat, Aug 17, 5:29 PM
navaneeth.suresh created D6740: tests: add test to demonstrate issue6159.
Sat, Aug 17, 5:28 PM
durin42 closed D6733: setup: fix a sorting issue I noticed in package names.
Sat, Aug 17, 5:05 PM
durin42 committed rHGf299555785c5: setup: fix a sorting issue I noticed in package names.
setup: fix a sorting issue I noticed in package names
Sat, Aug 17, 5:05 PM
navaneeth.suresh created D6739: unshelve: add abort on using --interactive and --unresolved together.
Sat, Aug 17, 4:41 PM
navaneeth.suresh created D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Sat, Aug 17, 4:40 PM
navaneeth.suresh created D6737: shelve: add --unresolved flag to shelve mergestate with unresolved files.
Sat, Aug 17, 4:39 PM
navaneeth.suresh created D6736: shelve: add method for storing mergestate in changeset extras.
Sat, Aug 17, 4:38 PM
D6733: setup: fix a sorting issue I noticed in package names is now accepted and ready to land.
Sat, Aug 17, 3:32 PM
pulkit added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

The ultimate goal is to store the mergestate info in the changeset extras only. But, now , it has no support to store the local version of the files which are stored in the mergestate. This lacks info when the user gets conflicts other than a usual hg merge.

Sat, Aug 17, 3:30 PM
pulkit added inline comments to D6735: update: added support for --abort flag(issue4404).
Sat, Aug 17, 3:29 PM
pulkit added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).

In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think?

Sat, Aug 17, 3:26 PM
pulkit added inline comments to D6728: config: add experimental argument to the config registrar.
Sat, Aug 17, 3:25 PM
taapas1128 updated the diff for D6735: update: added support for --abort flag(issue4404).
Sat, Aug 17, 3:17 PM
taapas1128 updated the diff for D6735: update: added support for --abort flag(issue4404).
Sat, Aug 17, 12:19 PM
taapas1128 created D6735: update: added support for --abort flag(issue4404).
Sat, Aug 17, 12:14 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 17, 11:10 AM
navaneeth.suresh added a comment to D6730: config: handle default values of type list.
In D6730#98852, @av6 wrote:

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Sat, Aug 17, 10:56 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 17, 10:55 AM
yuja committed rHG9c589dde075f: py3: do not convert rust module/attribute names to bytes.
py3: do not convert rust module/attribute names to bytes
Sat, Aug 17, 9:53 AM
yuja committed rHG8c3bbf6f54a0: transplant: unnest --stop case.
transplant: unnest --stop case
Sat, Aug 17, 9:53 AM
D6730: config: handle default values of type list now requires changes to proceed.

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Sat, Aug 17, 9:00 AM
av6 added inline comments to D6709: config: add --registered flag to show all known configs.
Sat, Aug 17, 8:59 AM
D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Sat, Aug 17, 8:55 AM
taapas1128 added a comment to D6678: continue: added support for histedit.

@pulkit This one is ready too.

Sat, Aug 17, 6:13 AM
taapas1128 abandoned D6696: abort: added support for transplant.
Sat, Aug 17, 6:12 AM
yuja added a comment to D6631: rust-cpython: add macro for sharing references.

+impl PySharedState {
+ pub fn borrow_mut<'a, T>(
+ &'a self,
+ py: Python<'a>,
+ pyrefmut: RefMut<'a, T>,
+ ) -> PyResult<PyRefMut<'a, T>> {
+ if self.mutably_borrowed.get() {
+ return Err(AlreadyBorrowed::new(
+ py,
+ "Cannot borrow mutably while there exists another \
+ mutable reference in a Python object",
+ ));
+ }
+ match self.leak_count.get() {
+ 0 => {
+ self.mutably_borrowed.replace(true);
+ Ok(PyRefMut::new(py, pyrefmut, self))
+ }
+ TODO
+
For now, this works differently than Python references
+ in the case of iterators.
+
Python does not complain when the data an iterator
+ points to is modified if the iterator is never used
+
afterwards.
+ Here, we are stricter than this by refusing to give a
+
mutable reference if it is already borrowed.
+ While the additional safety might be argued for, it
+
breaks valid programming patterns in Python and we need
+ to fix this issue down the line.
+ _ => Err(AlreadyBorrowed::new(
+ py,
+ "Cannot borrow mutably while there are \
+ immutable references in Python objects",
+ )),
+ }
+ }
+
+
/ Return a reference to the wrapped data with an artificial static
+ / lifetime.
+
/ We need to be protected by the GIL for thread-safety.
+ pub fn leak_immutable<T>(
+ &self,
+ py: Python,
+ data: &RefCell<T>,
+ ) -> PyResult<&'static T> {
+ if self.mutably_borrowed.get() {
+ return Err(AlreadyBorrowed::new(
+ py,
+ "Cannot borrow immutably while there is a \
+ mutable reference in Python objects",
+ ));
+ }
+ let ptr = data.as_ptr();
+ self.leak_count.replace(self.leak_count.get() + 1);
+ unsafe { Ok(&*ptr) }
+ }

Sat, Aug 17, 4:43 AM
yuja added a comment to D6632: rust-dirstate: rust implementation of dirstatemap.

+ if let Some(ref mut file_fold_map) = self.file_fold_map {
+ file_fold_map
+ .remove::<Vec<u8>>(filename.to_ascii_uppercase().as_ref());

Sat, Aug 17, 3:50 AM
yuja committed rHG88d6a6f7e837: rust-discovery: use while loop instead of match + break.
rust-discovery: use while loop instead of match + break
Sat, Aug 17, 2:50 AM
yuja committed rHG2e9b29fa3e80: rust-discovery: remove useless extern crate.
rust-discovery: remove useless extern crate
Sat, Aug 17, 2:50 AM
taapas1128 committed rHGf6a4db4b40ed: transplant: added support for --stop flag.
transplant: added support for --stop flag
Sat, Aug 17, 2:50 AM
navaneeth.suresh committed rHG7b33ff9c5565: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Sat, Aug 17, 2:50 AM
navaneeth.suresh committed rHGa11fd395e83f: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Sat, Aug 17, 2:50 AM
durin42 committed rHG791791a1fd4e: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Sat, Aug 17, 2:50 AM
hooper committed rHGe9f503074044: fix: pass line ranges as value instead of callback.
fix: pass line ranges as value instead of callback
Sat, Aug 17, 2:50 AM
hooper committed rHG2d70b1118af2: fix: correctly parse the :metadata subconfig.
fix: correctly parse the :metadata subconfig
Sat, Aug 17, 2:50 AM
hooper committed rHGed0da6e0d6ee: fix: allow tools to use :linerange, but also run if a file is unchanged.
fix: allow tools to use :linerange, but also run if a file is unchanged
Sat, Aug 17, 2:50 AM
Alphare committed rHG749ef8c31187: rust-dirstate: call rust dirstatemap from Python.
rust-dirstate: call rust dirstatemap from Python
Sat, Aug 17, 2:50 AM
Alphare committed rHG4e8f504424f3: rust-dirstate: rust-cpython bridge for dirstatemap.
rust-dirstate: rust-cpython bridge for dirstatemap
Sat, Aug 17, 2:50 AM
Alphare committed rHGfce6dc93a510: rust-dirstate: rust implementation of dirstatemap.
rust-dirstate: rust implementation of dirstatemap
Sat, Aug 17, 2:50 AM
Alphare committed rHG30320c7bf79f: rust-cpython: add macro for sharing references.
rust-cpython: add macro for sharing references
Sat, Aug 17, 2:50 AM
Alphare committed rHG4b3b27d567d5: rust-docstrings: add missing module docstrings.
rust-docstrings: add missing module docstrings
Sat, Aug 17, 2:50 AM
Alphare committed rHG849e744b925d: rust-dirstate: improve API of `DirsMultiset`.
rust-dirstate: improve API of `DirsMultiset`
Sat, Aug 17, 2:50 AM
Alphare committed rHG7ceded4419a3: rust-dirstate: use EntryState enum instead of literals.
rust-dirstate: use EntryState enum instead of literals
Sat, Aug 17, 2:50 AM
Alphare committed rHG7cae6bc29ff9: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop.
rust-parsers: switch to parse/pack_dirstate to mutate-on-loop
Sat, Aug 17, 2:50 AM
Alphare committed rHG760a7851e9ba: rust-parsers: move parser bindings to their own file and Python module.
rust-parsers: move parser bindings to their own file and Python module
Sat, Aug 17, 2:50 AM
Alphare committed rHGb3518b0baa47: rust-dirstate: create dirstate submodule in hg-cpython.
rust-dirstate: create dirstate submodule in hg-cpython
Sat, Aug 17, 2:50 AM
yuja added a comment to D6633: rust-dirstate: rust-cpython bridge for dirstatemap.

+ def getdirs(&self) -> PyResult<Dirs> {
+ TODO don't copy, share the reference
+ self.inner(py).borrow_mut().set_dirs();
+ Dirs::from_inner(
+ py,
+ DirsMultiset::new(
+ DirsIterable::Dirstate(&self.inner(py).borrow()),
+ Some(EntryState::Removed),
+ ),
+ )
+ }
+ def getalldirs(&self) -> PyResult<Dirs> {
+
TODO don't copy, share the reference
+ self.inner(py).borrow_mut().set_all_dirs();
+ Dirs::from_inner(
+ py,
+ DirsMultiset::new(
+ DirsIterable::Dirstate(&self.inner(py).borrow()),
+ None,
+ ),
+ )
+ }

Sat, Aug 17, 2:49 AM

Fri, Aug 16

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:23 PM
yuja committed rHG0e3364c4d306: rust-discovery: use while loop instead of match + break.
rust-discovery: use while loop instead of match + break
Fri, Aug 16, 5:16 PM
yuja committed rHGa585cbff23b0: rust-discovery: remove useless extern crate.
rust-discovery: remove useless extern crate
Fri, Aug 16, 5:16 PM
durin42 created D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Fri, Aug 16, 4:54 PM
durin42 created D6732: localrepo: push manifestlog and changelog construction code into store.
Fri, Aug 16, 4:54 PM
durin42 created D6733: setup: fix a sorting issue I noticed in package names.
Fri, Aug 16, 4:54 PM
navaneeth.suresh created D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Fri, Aug 16, 4:26 PM
durin42 committed rHG302dbc9d52be: tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1)
Fri, Aug 16, 8:44 AM
taapas1128 closed D6695: transplant: added support for --stop flag.
Fri, Aug 16, 6:56 AM
navaneeth.suresh closed D6699: unshelve: abort on using --keep and --interactive together.
Fri, Aug 16, 6:56 AM
taapas1128 committed rHG4d10aada6c3b: transplant: added support for --stop flag.
transplant: added support for --stop flag
Fri, Aug 16, 6:55 AM
navaneeth.suresh committed rHG4b0c9d47f714: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Fri, Aug 16, 6:55 AM
D6695: transplant: added support for --stop flag is now accepted and ready to land.
Fri, Aug 16, 5:54 AM
durin42 closed D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Fri, Aug 16, 5:47 AM
durin42 committed rHG55f59a25c593: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1)
Fri, Aug 16, 5:47 AM
pulkit accepted D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Fri, Aug 16, 5:45 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:13 AM
navaneeth.suresh updated the diff for D6730: config: handle default values of type list.
Fri, Aug 16, 5:08 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Fri, Aug 16, 5:08 AM
navaneeth.suresh created D6730: config: handle default values of type list.
Fri, Aug 16, 5:03 AM
av6 added a comment to D6709: config: add --registered flag to show all known configs.

It looks fine to me, one thing that could be improved is the output format of list values. For example, progress.format: its default value is shown to be ['topic', 'bar', 'number', 'estimate'], but it doesn't match hg help config.progress.format (it says default: topic bar number estimate), and that is also not the format that users would need to use for the actual value in hgrc or using --config flag.

Fri, Aug 16, 3:51 AM
D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1) is now accepted and ready to land.
Fri, Aug 16, 12:52 AM

Thu, Aug 15

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Thu, Aug 15, 3:44 PM
taapas1128 updated the diff for D6695: transplant: added support for --stop flag.
Thu, Aug 15, 12:30 PM
taapas1128 retitled D6695: transplant: added support for --stop flag from transplant: added support for --abort flag to transplant: added support for --stop flag.
Thu, Aug 15, 12:27 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

Thu, Aug 15, 11:37 AM
pulkit added a comment to D6695: transplant: added support for --stop flag.

Let's rename this to transplant --stop instead.

Thu, Aug 15, 11:32 AM
navaneeth.suresh closed D6728: config: add experimental argument to the config registrar.
Thu, Aug 15, 11:25 AM
navaneeth.suresh committed rHGe67d9b6bad4d: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Thu, Aug 15, 11:24 AM
durin42 created D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Thu, Aug 15, 11:23 AM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Thu, Aug 15, 11:16 AM
durin42 added a comment to D6709: config: add --registered flag to show all known configs.

Looks good to me, but I want someone else to put eyes on it before it gets pushed.

Thu, Aug 15, 11:13 AM
durin42 committed rHG034b2bf377f0: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Thu, Aug 15, 11:08 AM
durin42 closed D6725: tests: split joint repo/changelog fake into one for each type.
Thu, Aug 15, 11:08 AM