Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

spectral updated the diff for D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
Fri, Dec 13, 8:39 PM
spectral added a comment to D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
In D7620#112376, @dlax wrote:

This should be documented in mercurial/helptext/config.txt I think.

Fri, Dec 13, 8:38 PM
spectral added inline comments to D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
Fri, Dec 13, 8:27 PM
martinvonz added inline comments to D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
Fri, Dec 13, 7:09 PM
D7664: rebase: make rebase not crash if p1 == p2 != nullid is now accepted and ready to land.

I think "historical" here means "before D7549.

Fri, Dec 13, 7:03 PM
spectral created D7664: rebase: make rebase not crash if p1 == p2 != nullid.
Fri, Dec 13, 6:58 PM
spectral created D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
Fri, Dec 13, 6:58 PM
martinvonz created D7662: bookmarks: use check_incompatible_arguments() for inactive+action.
Fri, Dec 13, 6:01 PM
martinvonz updated the diff for D7648: bookmarks: use cmdutil.check_unique_argument() for action+rev.
Fri, Dec 13, 6:01 PM
martinvonz created D7663: transplant: use check_incompatible_arguments().
Fri, Dec 13, 6:01 PM
martinvonz updated the diff for D7645: rebase: use cmdutil.check_unique_argument() for action+revision.
Fri, Dec 13, 6:00 PM
martinvonz updated the diff for D7644: rebase: use cmdutil.check_unique_argument() for --auto-orphans.
Fri, Dec 13, 6:00 PM
martinvonz updated the diff for D7646: rebase: inline single-use variables passed to _definedestmap().
Fri, Dec 13, 6:00 PM
martinvonz updated the diff for D7643: rebase: use cmdutil.check_unique_argument() for -b/-s/-r.
Fri, Dec 13, 6:00 PM
martinvonz updated the diff for D7642: rebase: inline single-use `dryrun` and `confirm` variables.
Fri, Dec 13, 5:59 PM
martinvonz updated the diff for D7640: rebase: use cmdutil.check_unique_argument() for action.
Fri, Dec 13, 5:57 PM
martinvonz updated the diff for D7641: rebase: use cmdutil.check_unique_argument() for --confirm/--dry-run.
Fri, Dec 13, 5:57 PM
martinvonz created D7661: rebase: use cmdutil.check_incompatible_arguments() for action+confirm/dryrun.
Fri, Dec 13, 5:57 PM
martinvonz retitled D7639: releasenotes: extract helper for checking for incompatible arguments from releasenotes: use cmdutil.check_unique_argument() to releasenotes: extract helper for checking for incompatible arguments.
Fri, Dec 13, 5:57 PM
martinvonz updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
Fri, Dec 13, 5:15 PM
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112206, @yuja wrote:

I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.

@yuja, maybe I've addressed both comments with the two new patches I added to the stack?

This latest diff reverted the cwd is None changes. IIUC, the TODO shouldn't be needed anymore.

Fri, Dec 13, 5:14 PM
mharbison72 added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112206, @yuja wrote:

I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.

@yuja, maybe I've addressed both comments with the two new patches I added to the stack?

Fri, Dec 13, 3:39 PM
marmoute created D7660: rust-index: add a `experimental.rust.index` option to use the wrapper.
Fri, Dec 13, 3:13 PM
marmoute created D7659: rust-index: use the new method in shortesthexnodeidprefix.
Fri, Dec 13, 3:13 PM
marmoute created D7658: rust-index: expose a method to retrieve the C index.
Fri, Dec 13, 3:13 PM
marmoute created D7653: rust-index: add a function to convert PyObject index for hg-core.
Fri, Dec 13, 3:13 PM
marmoute created D7656: rust-index: make it possible to clone the struct referencing the C index.
Fri, Dec 13, 3:12 PM
marmoute created D7655: rust-index: add a struct wrapping the C index.
Fri, Dec 13, 3:12 PM
marmoute created D7657: rust-index: handle `MixedIndex` in `pyindex_to_graph`.
Fri, Dec 13, 3:12 PM
marmoute created D7654: rust-index: add a `inner` method to the Index struct.
Fri, Dec 13, 3:12 PM
marmoute created D7651: nodetree: simplify a conditionnal in shortesthexnodeidprefix.
Fri, Dec 13, 3:11 PM
marmoute created D7652: test: extract some generic data and utility from test-rust-ancestor.py.
Fri, Dec 13, 3:11 PM
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112206, @yuja wrote:
> In D7570#111892 <https://phab.mercurial-scm.org/D7570#111892>, @durin42 wrote:
>
>> I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).
>
> I *think* they're addressed, but we there's no rush to get this in so let's give Yuya a chance to comment, because I'm not sure if the issue with subrepos is an existing or new issue.
@yuja, what do you think?

I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.

Fri, Dec 13, 2:52 PM
martinvonz updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
Fri, Dec 13, 2:52 PM
martinvonz created D7649: match: make sure `root` argument is always an absolute path.
Fri, Dec 13, 2:51 PM
martinvonz created D7650: match: normalize `cwd` early.
Fri, Dec 13, 2:51 PM
martinvonz updated the diff for D7569: tests: show that fileset patterns don't work with `fix` when not in repo root.
Fri, Dec 13, 2:48 PM
quark added a comment to D7631: RFC: absorb: allowing committed changes to be absorbed into their ancestors.

--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?

Fri, Dec 13, 1:21 PM
yuja closed D7614: rust-cpython: do not convert warning pattern to utf-8 bytes.
Fri, Dec 13, 1:18 PM
martinvonz committed rHGcf065c6a0197: merge with stable.
merge with stable
Fri, Dec 13, 1:18 PM