In D7620#112376, @dlax wrote:This should be documented in mercurial/helptext/config.txt I think.
Active Repositories
Active Repositories
- rNRWHG narrowhg
- 369 Commits
- ·
- Restricted Project
- Jan 26 2018, 6:48 PM
- Mercurial
Recent Activity
Recent Activity
Today
Today
spectral updated the diff for D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
spectral added a comment to D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
spectral added inline comments to D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
martinvonz added inline comments to D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
D7664: rebase: make rebase not crash if p1 == p2 != nullid is now accepted and ready to land.
I think "historical" here means "before D7549.
martinvonz updated the diff for D7648: bookmarks: use cmdutil.check_unique_argument() for action+rev.
martinvonz updated the diff for D7645: rebase: use cmdutil.check_unique_argument() for action+revision.
martinvonz updated the diff for D7644: rebase: use cmdutil.check_unique_argument() for --auto-orphans.
martinvonz updated the diff for D7646: rebase: inline single-use variables passed to _definedestmap().
martinvonz updated the diff for D7641: rebase: use cmdutil.check_unique_argument() for --confirm/--dry-run.
martinvonz retitled D7639: releasenotes: extract helper for checking for incompatible arguments from releasenotes: use cmdutil.check_unique_argument() to releasenotes: extract helper for checking for incompatible arguments.
martinvonz updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112516, @mharbison72 wrote:In D7570#112436, @martinvonz wrote:In D7570#112206, @yuja wrote:I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.@yuja, maybe I've addressed both comments with the two new patches I added to the stack?
This latest diff reverted the cwd is None changes. IIUC, the TODO shouldn't be needed anymore.
mharbison72 added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112436, @martinvonz wrote:In D7570#112206, @yuja wrote:I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.@yuja, maybe I've addressed both comments with the two new patches I added to the stack?
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112206, @yuja wrote:> In D7570#111892 <https://phab.mercurial-scm.org/D7570#111892>, @durin42 wrote: > >> I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path). > > I *think* they're addressed, but we there's no rush to get this in so let's give Yuya a chance to comment, because I'm not sure if the issue with subrepos is an existing or new issue. @yuja, what do you think?I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.
martinvonz updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
quark added a comment to D7631: RFC: absorb: allowing committed changes to be absorbed into their ancestors.
--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?