Today

joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:16 PM
martinvonz created D1867: evolution: report new unstable changesets.
Tue, Jan 16, 3:16 PM
Matt DeVore <matvore@google.com> committed rNRWHG487edd5b33a2: narrowspec.py: error if a narrowspec path has '.' or '..' path components.
narrowspec.py: error if a narrowspec path has '.' or '..' path components
Tue, Jan 16, 3:16 PM
yuja committed rHG821d8a5ab4ff: match: do not weirdly include explicit files excluded by -X option.
match: do not weirdly include explicit files excluded by -X option
Tue, Jan 16, 3:16 PM
mharbison72 committed rHGa1222a8cc93b: lfs: add the '{oid}' template keyword to '{lfs_files}'.
lfs: add the '{oid}' template keyword to '{lfs_files}'
Tue, Jan 16, 3:16 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:16 PM
mharbison72 committed rHG8580e5898cb7: lfs: convert '{lfs_files}' keyword to a hybrid list.
lfs: convert '{lfs_files}' keyword to a hybrid list
Tue, Jan 16, 3:16 PM
lothiraldan committed rHGc9eb92fb87b7: showstack: add an extension docstring.
showstack: add an extension docstring
Tue, Jan 16, 3:16 PM
lothiraldan committed rHG2f54a3e228ff: bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'.
bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'
Tue, Jan 16, 3:16 PM
av6 committed rHG59c842a3d1e1: hgweb: remove unused second argument of nextPageVarGet().
hgweb: remove unused second argument of nextPageVarGet()
Tue, Jan 16, 3:16 PM
lothiraldan added a comment to D1074: branch: add a --rev flag to change branch name of given revisions.

Apart from my review, it looks good to me.

Tue, Jan 16, 3:15 PM
quark added inline comments to D1849: lfs: remove internal url in test.
Tue, Jan 16, 3:14 PM
quark updated the diff for D1849: lfs: remove internal url in test.
Tue, Jan 16, 3:14 PM
joerg.sonnenberger added a dependency for D1856: wireproto: support for pullbundles: D1862: wireproto: split streamres into legacy and modern case.
Tue, Jan 16, 3:14 PM
joerg.sonnenberger added a dependent revision for D1862: wireproto: split streamres into legacy and modern case: D1856: wireproto: support for pullbundles.
Tue, Jan 16, 3:14 PM
martinvonz created D1868: evolution: make reporting of new unstable changesets optional.
Tue, Jan 16, 3:14 PM
martinvonz created D1866: transaction: register summary callbacks only at start of transaction (BC).
Tue, Jan 16, 3:14 PM
lothiraldan added a comment to D1867: evolution: report new unstable changesets.

LGTM on a first quick review

Tue, Jan 16, 3:14 PM
martinvonz added a comment to D1867: evolution: report new unstable changesets.

For the effects on the evolve repo, see https://bitbucket.org/martinvonz/mutable-history/commits/288b3db249c10bc22158d06cc11bceea94c0dc6a

Tue, Jan 16, 3:14 PM
martinvonz abandoned D1863: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:14 PM
martinvonz added a dependent revision for D1867: evolution: report new unstable changesets: D1868: evolution: make reporting of new unstable changesets optional.
Tue, Jan 16, 3:13 PM
martinvonz created D1864: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:13 PM
martinvonz created D1865: repair: filter out unknown revisions from phasecache within transaction.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1866: transaction: register summary callbacks only at start of transaction (BC): D1867: evolution: report new unstable changesets.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1865: repair: filter out unknown revisions from phasecache within transaction: D1866: transaction: register summary callbacks only at start of transaction (BC).
Tue, Jan 16, 3:13 PM
martinvonz created D1863: repair: drop unnecessary phase cache invalidation.
Tue, Jan 16, 3:13 PM
martinvonz added a dependent revision for D1864: repair: drop unnecessary phase cache invalidation: D1865: repair: filter out unknown revisions from phasecache within transaction.
Tue, Jan 16, 3:13 PM

Yesterday

joerg.sonnenberger created D1862: wireproto: split streamres into legacy and modern case.
Mon, Jan 15, 6:31 PM
indygreg created D1861: wireproto: drop support for reader interface from streamres (API).
Mon, Jan 15, 6:20 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

The ideal solution would be a way to reset the context for the byte stream. Essentially we'd add a marker telling consumers they've reached EOF of either a bundle2 stream or a compression context. The next byte should be interpreted as a new bundle2 stream or a new compression context.

Mon, Jan 15, 5:39 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

Mon, Jan 15, 5:33 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 5:31 PM
tom.prince updated the diff for D1802: phabricator: add a template item for linking to a differential review.
Mon, Jan 15, 4:58 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 2:33 PM
joerg.sonnenberger abandoned D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.

Merging into the parent review.

Mon, Jan 15, 2:26 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Mon, Jan 15, 2:22 PM
pulkit updated subscribers of D1074: branch: add a --rev flag to change branch name of given revisions.

@durin42 @yuja @indygreg @krbullock this one is lying here for months. Does this conflict with anything or is a BC or something else, or was just missed for the review?

Mon, Jan 15, 1:45 PM
durin42 added a comment to D1856: wireproto: support for pullbundles.

My biggest concern with the architecture of this feature is the multiple roundtrips. I really wish we could stream multiple bundles off disk to the wire with no decompression/compression involved. That would mean storing compressed bundles on disk. But this would require some additional bundle2 magic. The existing solution is simple and elegant. I do like that. I'd very much like to get the opinion of someone like @durin42 (who also likes designing protocols).

Mon, Jan 15, 11:02 AM
indygreg closed D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 8:25 AM
indygreg committed rHG48fe4f56a3b4: dispatch: handle IOError when writing to stderr.
dispatch: handle IOError when writing to stderr
Mon, Jan 15, 8:25 AM