Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User Details

User Since
Apr 18 2019, 7:59 AM (119 w, 6 d)

Recent Activity

Today

Alphare updated the diff for D11239: debugcommands: introduce a debug command to repair repos affected by issue6528.
Wed, Aug 4, 4:43 PM
Alphare retitled D11239: debugcommands: introduce a debug command to repair repos affected by issue6528 from debugcommands: introduce a debug command to fix repos affected by issue6528 to debugcommands: introduce a debug command to repair repos affected by issue6528.
Wed, Aug 4, 4:43 PM
D11250: testing: make sure write_file is "atomic" is now accepted and ready to land.
Wed, Aug 4, 4:42 PM
Alphare added a comment to D11239: debugcommands: introduce a debug command to repair repos affected by issue6528.

Pending CI refresh

Wed, Aug 4, 4:40 PM
Alphare accepted D11249: check-module-imports: ignore non-stdlib module installed by distribution.
Wed, Aug 4, 4:40 PM

Mon, Aug 2

Alphare closed D11241: pytype: add assertions to explain revlogv2 invariants to Pytype.
Mon, Aug 2, 10:11 PM
Alphare closed D11242: heptapod-ci: enable pytype testing for all pipelines.
Mon, Aug 2, 10:11 PM
Alphare committed rHG6c86f96042c9: heptapod-ci: enable pytype testing for all pipelines.
heptapod-ci: enable pytype testing for all pipelines
Mon, Aug 2, 10:11 PM
Alphare committed rHG60ccc86a12f3: pytype: add assertions to explain revlogv2 invariants to Pytype.
pytype: add assertions to explain revlogv2 invariants to Pytype
Mon, Aug 2, 10:11 PM
Alphare created D11242: heptapod-ci: enable pytype testing for all pipelines.
Mon, Aug 2, 12:49 PM
Alphare created D11241: pytype: add assertions to explain revlogv2 invariants to Pytype.
Mon, Aug 2, 12:49 PM
Alphare added a comment to D11235: typing: add several assertions to dirstatemap to appease pytype.

For some reason, phabsend did not record the branch information (which was stable, according to Matt Harbison), so this went on default. It also shouldn't have landed on default at all since we're in a freeze, but the impact is minimal. I'll graft it to stable soon.

Mon, Aug 2, 12:00 PM
Alphare added a comment to D11237: tests: rename test-clone-uncompressed.t.

Even though it is quite simple, it can wait for the end of the freeze.
@valentin.gatienbaron We're supposed to have a real code freeze this cycle, so it's really the reviewers' job to ignore the patches that don't meet the stable criteria until the end of the freeze. As Martin said, it seems that some reviewers still queued patches.

Mon, Aug 2, 10:42 AM
Alphare added a comment to D11238: rust-nodemap: falling back to C impl as mitigation.

I'll give other reviewers a little time to review as well, but this looks fine as a workaround. I hope we'll be able to figure out the underlying cause soon.

Mon, Aug 2, 9:49 AM
Alphare created D11239: debugcommands: introduce a debug command to repair repos affected by issue6528.
Mon, Aug 2, 9:37 AM
Alphare added a comment to D11236: streamclone: ensure the server sends the right amount of data.

@pulkit I think this would be a good contender for stable and should go in during the freeze.

Mon, Aug 2, 5:00 AM

Mon, Jul 26

Alphare added a comment to D11211: wireprotov1peer: simplify the way batchable rpcs are defined.

Thanks for the patches, they look like a good idea, however we're in a freeze right now so we'll take a look in August.

Mon, Jul 26, 4:51 AM

Fri, Jul 23

Alphare added inline comments to D11052: tests: blacklist a handful of test with `rhg` or `chg`.
Fri, Jul 23, 8:31 AM

Thu, Jul 22

Alphare added a comment to D11204: hgwebdir: avoid systematic full garbage collection.

Should this go to stable or should it wait the end of the freeze? I'm not too sure.

Thu, Jul 22, 12:11 PM
Alphare added a comment to D11206: typing: convert an annotation to an assertion in commands.py.

I'm assuming both patches were intended for stable?

Thu, Jul 22, 12:08 PM
D11205: test: remove `sleep` usage in `test-nointerrupt.t` (issue6271) is now accepted and ready to land.

Does rhg still fail with this new mechanism? I'm assuming it does because nothing changed on its side, but we wouldn't want to lose the reproduction case.

Thu, Jul 22, 12:08 PM
D11207: upgrade: byteify an i18n message is now accepted and ready to land.
Thu, Jul 22, 12:01 PM
D11206: typing: convert an annotation to an assertion in commands.py is now accepted and ready to land.
Thu, Jul 22, 12:01 PM

Mon, Jul 19

D11199: dirstate: deprecate the `add` method is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11198: mq: replace `add` call with newer API is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11197: largefile: use `updatefile` instead of `add` in `synclfdirstate` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11196: largefile: use `update_file` instead of `add` in `mergerecordupdates` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11195: dirstate: deprecate the `drop` method is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11194: narrow: stop using `drop` in the `updateworkingcopy` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11193: mq: replace `drop` call with newer API is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11192: largefile: use `update_file` instead of `drop` during `rollback` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11191: largefile: use `update_file` instead of `drop` in `synclfdirstate` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11190: sparse: use `update_file` instead of `drop` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11189: sparse: use `update_file` instead of `drop` in `refreshwdir` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11188: amend: use `update_file` instead of `drop` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11187: context: use `update_file` instead of `drop` in `markcommitted` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11186: dirstate: deprecate the `merge` method in all cases is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11185: mq: drop the use of `dirstate.merged is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11184: dirstate: deprecate the `otherparent` method in all cases is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11183: dirstate: deprecate the `normallookup` method in all cases is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11182: narrow: stop using `normallookup` during a test is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11181: narrow: use `update_file` instead of `normallookup` after update is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11180: test: use the internal `_normallookup` in `test-rebuildstate.t` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11179: sparse: use `update_file` instead of `normallookup` in refreshwdir is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11178: keywork: use `update_file_p1` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11177: fix: use `set_possibly_dirty` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11176: eol: use `set_possibly_dirty` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:29 PM
D11174: revert: use `set_possibly_dirty` instead of `normal_lookup` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11175: mq: replace `normallookup` call with newer API is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11173: dirstate: enforce `possibly_dirty` in `set_tracked` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11172: record: use `update_file` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11171: copy: use `set_tracked` instead of `normallookup` in `dirstatecopy` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11170: amend: use `update_file` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11169: mergestate: use `update_file` to handle `for ACTION_EXEC` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11168: mergestate: use `update_file` to handle `for ACTION_ADD_MODIFIED` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11167: largefile: use `update_file` for `synclfdirstate` "m" case is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11166: largefile: use `update_file` for `synclfdirstate` "n" case is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11165: largefile: replace the `normallookup` call when creating a new lfdirstate is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11164: largefile: use `update_file` instead of `normallookup` in `updatelfiles` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11163: largefile: use `set_possibly_dirty` instead of `normallookup` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11162: dirstate: add a `set_possibly_dirty` method is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11161: dirstate: deprecate the `normal` method in all cases is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11160: test: use `set_traced` in `test-context` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11159: mq: replace usage of `normal` with newer API is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11158: largefile: use `update_file` instead of `normal` in `synclfdirstate` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11157: largefile: use `set_clean` instead of `normal` in `repo.status` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11156: largefile: use `set_clean` instead of `normal` in `lfdirstatestatus` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11155: largefile: use `update_file` instead of `normal` in `updatelfiles` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11154: largefile: respect the `normal` signature is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11153: keywork: use `set_clean` instead of `normal` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11152: sparse: use `update_file` instead of `normal` in `refreshwdir` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11151: sparse: use `update_file` instead of `normal` during `applyupdates` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11150: sparse: apply update with in a `parentchange` context is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11149: revert: use `set_clean` instead of `normal` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11148: context: use `update_file` instead of `normal` in `markcommitted` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11147: context: use new API instead of `normal` during fixup post status is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11146: dirstate: introduce a `set_clean` method is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11145: largefile: use `update_file` instead of `normal` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11144: largefile: adjust the dirstate post update within a `parentchange` context is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11143: dirstate: deprecate `dirstate.remove` in all cases is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11142: largefile: use `update_file` instead of `remove` in `synclfdirstate` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11141: largefile: rearrange conditionnal in `synclfdirstate` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11140: largefile: use `update_file` instead of `remove` in `mergerecordupdates` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11139: mq: use `update_file_p1` instead of `remove` when adjusting dirstate is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11138: dirstate: properly update `_lastnormaltime` in `update_file_p1` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11137: dirstate: properly update `_lastnormaltime` in `update_file` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11136: dirstate: use `reset_state` in `update_file_p1` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11135: dirstate: rename `update_file_reference` to `update_file_p1` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11134: dirstate-map: move most of `dirstate.update_file` logic in the dsmap is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11133: dirstate: replace `update_parent_file_data` with simpler `update_parent` call is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11132: dirstate: factor out the part retrieve "filedata" out of `normal` is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11131: dirstate-map: factor out the change to _dirs and _alldirs on removing is now accepted and ready to land.
Mon, Jul 19, 12:28 PM
D11130: dirstate-map: factor out the change to _dirs and _alldirs on dropping is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11129: dirstate-map: factor out the change to _dirs and _alldirs on adding is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11128: dirstate: replace a dead conditional branch with an assert in `update_file` is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11127: dirstate-map: do not use `size` to gate copy dropping during remove_file is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11126: dirstate: drop a duplicated assert is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11125: dirstate: drop duplicated check is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11124: dirstate-item: introduce a `dm_otherparent` property is now accepted and ready to land.
Mon, Jul 19, 12:27 PM
D11123: dirstate-item: introduce a `dm_nonnormal` property is now accepted and ready to land.
Mon, Jul 19, 12:27 PM