- User Since
- Apr 18 2019, 7:59 AM (22 w, 2 d)
Tue, Sep 17
It is indeed Sync because the py_class! macro forces us to have a reference to the GIL at the type level to access the data attributes, but I would also like to be extra sure and have someone else confirm it.
Fri, Sep 13
Wed, Sep 11
I would love for this series to be queued. Is there anything I didn't address left to do?
Thu, Sep 5
Tue, Sep 3
Mon, Sep 2
Sun, Sep 1
@kevincox said "it would be good to [...] add a debug_assert! on
creation/modification to check that everything is as expected."
IIUC, his idea is that the debug_assert!() condition must always be met,
which is the guarantee that the HgPath type provides. In order to ensure
that, we'll have to validate all paths read from dirstate, for example,
prior to casting to HgPath type. Otherwise debug_assert!() would fail,
meaning the implementation had a bug.
So, my question is, do we really need such strong guarantee by default?
Sat, Aug 31
Fri, Aug 30
Thu, Aug 29
Mon, Aug 26
Thu, Aug 22
Aug 22 2019
Aug 17 2019
Aug 14 2019
Aug 6 2019
@reviewers I am leaving for a vacation on the 9th and I won't be able to answer your questions or work on those patches before the 20th. This series has been idle for a long time, I didn't want it to be forgotten about.
Aug 5 2019
Aug 2 2019
Jul 31 2019
Jul 24 2019
@kevincox I've renamed the file since it no longer just contains macros.
Most of those will be taken care of in a follow-up patch, since they're cosmetic, plus this change just moves code around.