- User Since
- Apr 18 2019, 7:59 AM (98 w, 4 d)
Fri, Mar 5
Maybe I'm trying too hard, but is looking for : in the repo bytes too wide to detect an URL? I know actual URL parsing is out of the question right now, but maybe we can do a little bit more since : is allowed in filenames on many platforms. What do you think?
Please add a small description to your changeset that explains the new config value and why we would want rhg to host a fallback system itself when it already has a specific error code for this.
Your changeset description uses abort twice, FYI, otherwise this looks good.
Thu, Mar 4
Wed, Mar 3
Tue, Mar 2
This was a harder one, macro_rules!, for all their usefulness are not the easiest thing to digest.
This should probably go to the stable branch though
But looking up this blog post I see that support for this new format was introduced in 1.40.0. Since the oldest version we support is 1.41.1 (for Debian) maybe we should just do the upgrade.
Thu, Feb 25
Wed, Feb 24
Tue, Feb 23
I'm waiting for the "next patch" mentioned in the commit message before this can be accepted, since the behavior changed from an abort to a silent omission of valid data, which is a regression.
I think I'd rather we also delete the docket file(s) and transaction files if we can, but this would not be a blocker for this patch in particular to land.
Mon, Feb 22
Fri, Feb 19
/!\ This change is destined for the stable branch