Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2019, 7:59 AM (22 w, 2 d)

Recent Activity

Tue, Sep 17

Alphare added a comment to D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC).

It is indeed Sync because the py_class! macro forces us to have a reference to the GIL at the type level to access the data attributes, but I would also like to be extra sure and have someone else confirm it.

Tue, Sep 17, 5:04 AM

Fri, Sep 13

Alphare added inline comments to D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Fri, Sep 13, 6:10 AM
Alphare updated the diff for D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Fri, Sep 13, 6:08 AM
Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Fri, Sep 13, 6:07 AM
Alphare added inline comments to D6836: interfaces: introduce an interface for dirstate implementations.
Fri, Sep 13, 4:41 AM
Alphare accepted D6838: idirstate: remove now non-public _map attribute.
Fri, Sep 13, 4:38 AM

Wed, Sep 11

Alphare added a comment to D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.

I would love for this series to be queued. Is there anything I didn't address left to do?

Wed, Sep 11, 5:50 AM

Thu, Sep 5

Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Thu, Sep 5, 8:02 AM

Tue, Sep 3

Alphare updated the diff for D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Tue, Sep 3, 5:00 AM
Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Tue, Sep 3, 4:59 AM

Mon, Sep 2

Alphare updated the diff for D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Mon, Sep 2, 4:42 AM
Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Mon, Sep 2, 4:41 AM

Sun, Sep 1

Alphare added a comment to D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.

@kevincox said "it would be good to [...] add a debug_assert! on
creation/modification to check that everything is as expected."
IIUC, his idea is that the debug_assert!() condition must always be met,
which is the guarantee that the HgPath type provides. In order to ensure
that, we'll have to validate all paths read from dirstate, for example,
prior to casting to HgPath type. Otherwise debug_assert!() would fail,
meaning the implementation had a bug.
So, my question is, do we really need such strong guarantee by default?

Sun, Sep 1, 5:30 AM

Sat, Aug 31

Alphare committed rHGb1b984f9c01d: rust-utils: add normalize_case util to mirror Python one.
rust-utils: add normalize_case util to mirror Python one
Sat, Aug 31, 11:10 PM
Alphare closed D6756: rust-utils: add normalize_case util to mirror Python one.
Sat, Aug 31, 6:59 PM
Alphare committed rHG6edca369d242: rust-utils: add normalize_case util to mirror Python one.
rust-utils: add normalize_case util to mirror Python one
Sat, Aug 31, 6:59 PM
Alphare added a comment to D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
In D6773#99433, @yuja wrote:

+#[derive(Eq, Ord, PartialEq, PartialOrd, Debug, Hash)]
+pub struct HgPath {
+ inner: [u8],
+}

I found std::path::Path has a well-written inline comment about
the unsafe pointer cast. Let's copy it so we won't introduce a
memory issue.

Sat, Aug 31, 11:54 AM

Fri, Aug 30

Alphare added inline comments to D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Fri, Aug 30, 10:41 AM
Alphare updated the diff for D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Fri, Aug 30, 10:40 AM
Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Fri, Aug 30, 10:38 AM
Alphare updated the diff for D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Fri, Aug 30, 5:27 AM

Thu, Aug 29

Alphare committed rHG6a551a2dc666: rust: run cargo fmt.
rust: run cargo fmt
Thu, Aug 29, 7:34 PM
Alphare created D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf.
Thu, Aug 29, 10:41 AM
Alphare created D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths.
Thu, Aug 29, 10:40 AM

Mon, Aug 26

Alphare accepted D6765: rustfilepatterns: shorter code for concatenating slices.
Mon, Aug 26, 2:38 AM

Thu, Aug 22

Alphare committed rHG7521e6d18057: makefile: run Rust tests if cargo is installed.
makefile: run Rust tests if cargo is installed
Thu, Aug 22, 7:25 PM

Aug 22 2019

Alphare created D6756: rust-utils: add normalize_case util to mirror Python one.
Aug 22 2019, 8:54 AM

Aug 17 2019

Alphare committed rHG749ef8c31187: rust-dirstate: call rust dirstatemap from Python.
rust-dirstate: call rust dirstatemap from Python
Aug 17 2019, 2:50 AM
Alphare committed rHG4e8f504424f3: rust-dirstate: rust-cpython bridge for dirstatemap.
rust-dirstate: rust-cpython bridge for dirstatemap
Aug 17 2019, 2:50 AM
Alphare committed rHGfce6dc93a510: rust-dirstate: rust implementation of dirstatemap.
rust-dirstate: rust implementation of dirstatemap
Aug 17 2019, 2:50 AM
Alphare committed rHG30320c7bf79f: rust-cpython: add macro for sharing references.
rust-cpython: add macro for sharing references
Aug 17 2019, 2:50 AM
Alphare committed rHG4b3b27d567d5: rust-docstrings: add missing module docstrings.
rust-docstrings: add missing module docstrings
Aug 17 2019, 2:50 AM
Alphare committed rHG849e744b925d: rust-dirstate: improve API of `DirsMultiset`.
rust-dirstate: improve API of `DirsMultiset`
Aug 17 2019, 2:50 AM
Alphare committed rHG7ceded4419a3: rust-dirstate: use EntryState enum instead of literals.
rust-dirstate: use EntryState enum instead of literals
Aug 17 2019, 2:50 AM
Alphare committed rHG7cae6bc29ff9: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop.
rust-parsers: switch to parse/pack_dirstate to mutate-on-loop
Aug 17 2019, 2:50 AM
Alphare committed rHG760a7851e9ba: rust-parsers: move parser bindings to their own file and Python module.
rust-parsers: move parser bindings to their own file and Python module
Aug 17 2019, 2:50 AM
Alphare committed rHGb3518b0baa47: rust-dirstate: create dirstate submodule in hg-cpython.
rust-dirstate: create dirstate submodule in hg-cpython
Aug 17 2019, 2:50 AM

Aug 14 2019

Alphare closed D6634: rust-dirstate: call rust dirstatemap from Python.
Aug 14 2019, 4:42 PM
Alphare closed D6633: rust-dirstate: rust-cpython bridge for dirstatemap.
Aug 14 2019, 4:42 PM
Alphare closed D6632: rust-dirstate: rust implementation of dirstatemap.
Aug 14 2019, 4:42 PM
Alphare committed rHG39674659b3f4: rust-dirstate: call rust dirstatemap from Python.
rust-dirstate: call rust dirstatemap from Python
Aug 14 2019, 4:41 PM
Alphare committed rHGe0f7ee53107e: rust-dirstate: rust-cpython bridge for dirstatemap.
rust-dirstate: rust-cpython bridge for dirstatemap
Aug 14 2019, 4:41 PM
Alphare closed D6631: rust-cpython: add macro for sharing references.
Aug 14 2019, 4:41 PM
Alphare closed D6628: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop.
Aug 14 2019, 4:41 PM
Alphare committed rHG565c143f4377: rust-dirstate: rust implementation of dirstatemap.
rust-dirstate: rust implementation of dirstatemap
Aug 14 2019, 4:41 PM
Alphare committed rHG826407e1ecba: rust-cpython: add macro for sharing references.
rust-cpython: add macro for sharing references
Aug 14 2019, 4:41 PM
Alphare closed D6629: rust-dirstate: use EntryState enum instead of literals.
Aug 14 2019, 4:41 PM
Alphare closed D6630: rust-docstrings: add missing module docstrings.
Aug 14 2019, 4:41 PM
Alphare committed rHG0def0fcbb2fc: rust-docstrings: add missing module docstrings.
rust-docstrings: add missing module docstrings
Aug 14 2019, 4:40 PM
Alphare closed D6627: rust-parsers: move parser bindings to their own file and Python module.
Aug 14 2019, 4:40 PM
Alphare committed rHG4f9dff6f4d7e: rust-dirstate: improve API of `DirsMultiset`.
rust-dirstate: improve API of `DirsMultiset`
Aug 14 2019, 4:39 PM
Alphare closed D6690: rust-dirstate: improve API of `DirsMultiset`.
Aug 14 2019, 4:39 PM
Alphare committed rHG7102ef7dfa31: rust-dirstate: use EntryState enum instead of literals.
rust-dirstate: use EntryState enum instead of literals
Aug 14 2019, 4:39 PM
Alphare closed D6626: rust-dirstate: create dirstate submodule in hg-cpython.
Aug 14 2019, 4:38 PM
Alphare committed rHGc36bdb4e884d: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop.
rust-parsers: switch to parse/pack_dirstate to mutate-on-loop
Aug 14 2019, 4:38 PM
Alphare committed rHG83c836e8efcc: rust-parsers: move parser bindings to their own file and Python module.
rust-parsers: move parser bindings to their own file and Python module
Aug 14 2019, 4:38 PM
Alphare committed rHG85cb54e76d48: rust-dirstate: create dirstate submodule in hg-cpython.
rust-dirstate: create dirstate submodule in hg-cpython
Aug 14 2019, 4:38 PM

Aug 6 2019

Alphare updated subscribers of D6634: rust-dirstate: call rust dirstatemap from Python.

@reviewers I am leaving for a vacation on the 9th and I won't be able to answer your questions or work on those patches before the 20th. This series has been idle for a long time, I didn't want it to be forgotten about.

Aug 6 2019, 12:22 PM
Alphare committed rHG11498aa91c03: byteify-strings: add --version argument.
byteify-strings: add --version argument
Aug 6 2019, 10:05 AM
Alphare committed rHGf9b64ff9d26b: byteify-strings: add space in special comments to silence flake8 error.
byteify-strings: add space in special comments to silence flake8 error
Aug 6 2019, 10:05 AM

Aug 5 2019

Alphare committed rHG26a31c88e1a5: byteify-strings: fix misalignment with multi-line parenthesis.
byteify-strings: fix misalignment with multi-line parenthesis
Aug 5 2019, 9:08 AM
Alphare committed rHG3364b4da5271: byteify-strings: add test for byteify-strings.py.
byteify-strings: add test for byteify-strings.py
Aug 5 2019, 9:08 AM

Aug 2 2019

Alphare committed rHGbbb002b378f3: byteify-strings: add cli argument to handle `attr*()` when they are methods.
byteify-strings: add cli argument to handle `attr*()` when they are methods
Aug 2 2019, 8:51 PM
Alphare committed rHG5e296f618920: byteify-strings: simplify default value for `--treat-as-kwargs`.
byteify-strings: simplify default value for `--treat-as-kwargs`
Aug 2 2019, 8:51 PM
Alphare committed rHGf95b59ffc307: byteify-strings: add --treat-as-kwargs argument to handle kwargs-like objects.
byteify-strings: add --treat-as-kwargs argument to handle kwargs-like objects
Aug 2 2019, 9:24 AM
Alphare committed rHGc9fd8163131f: byteify-strings: add helpers to check for item access or method call.
byteify-strings: add helpers to check for item access or method call
Aug 2 2019, 9:24 AM
Alphare committed rHGb9a200477edf: byteify-strings: add support for ignore comments.
byteify-strings: add support for ignore comments
Aug 2 2019, 9:24 AM
Alphare committed rHGe9592e113c31: byteify-strings: handle triple quoted strings if they are not docstrings.
byteify-strings: handle triple quoted strings if they are not docstrings
Aug 2 2019, 9:24 AM
Alphare committed rHG70bd1965bd07: byteify-strings: handle multi-line strings in _ensuresysstr.
byteify-strings: handle multi-line strings in _ensuresysstr
Aug 2 2019, 9:24 AM

Jul 31 2019

Alphare committed rHGa7f1a0b3f461: module-policy: update rust extension import to use the new module policy.
module-policy: update rust extension import to use the new module policy
Jul 31 2019, 7:46 PM
Alphare closed D6677: module-policy: update rust extension import to use the new module policy.
Jul 31 2019, 7:46 PM

Jul 24 2019

Alphare added a comment to D6631: rust-cpython: add macro for sharing references.

@kevincox I've renamed the file since it no longer just contains macros.

Jul 24 2019, 11:33 AM
Alphare updated the diff for D6634: rust-dirstate: call rust dirstatemap from Python.
Jul 24 2019, 11:25 AM
Alphare updated the diff for D6633: rust-dirstate: rust-cpython bridge for dirstatemap.
Jul 24 2019, 11:25 AM
Alphare updated the diff for D6632: rust-dirstate: rust implementation of dirstatemap.
Jul 24 2019, 11:25 AM
Alphare updated the diff for D6628: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop.
Jul 24 2019, 11:25 AM
Alphare updated the summary of D6631: rust-cpython: add macro for sharing references.
Jul 24 2019, 11:24 AM
Alphare updated the diff for D6629: rust-dirstate: use EntryState enum instead of literals.
Jul 24 2019, 11:24 AM
Alphare updated the diff for D6630: rust-docstrings: add missing module docstrings.
Jul 24 2019, 11:24 AM
Alphare created D6690: rust-dirstate: improve API of `DirsMultiset`.
Jul 24 2019, 11:23 AM
Alphare updated the diff for D6627: rust-parsers: move parser bindings to their own file and Python module.
Jul 24 2019, 11:23 AM
Alphare updated the diff for D6626: rust-dirstate: create dirstate submodule in hg-cpython.
Jul 24 2019, 11:22 AM
Alphare added a comment to D6626: rust-dirstate: create dirstate submodule in hg-cpython.

Most of those will be taken care of in a follow-up patch, since they're cosmetic, plus this change just moves code around.

Jul 24 2019, 11:15 AM

Jul 23 2019

Alphare updated the diff for D6427: discovery: new devel.discovery.randomize option.
Jul 23 2019, 5:15 AM
Alphare updated the diff for D6426: rust-discovery: optionally don't randomize at all, for tests.
Jul 23 2019, 5:15 AM
Alphare updated the diff for D6425: rust-discovery: exposing sampling to python.
Jul 23 2019, 5:15 AM
Alphare updated the diff for D6424: rust-discovery: takefullsample() core implementation.
Jul 23 2019, 5:15 AM
Alphare updated the diff for D6517: rust-discovery: read the index from a repo passed at init.
Jul 23 2019, 5:14 AM
Alphare updated the diff for D6516: rust-discovery: accept the new 'respectsize' init arg.
Jul 23 2019, 5:14 AM
Alphare created D6677: module-policy: update rust extension import to use the new module policy.
Jul 23 2019, 5:14 AM
Alphare added a comment to D6516: rust-discovery: accept the new 'respectsize' init arg.

It seems weird to add this argument without using it. I would much rather it was added as the implementation was added.

Jul 23 2019, 5:03 AM

Jul 18 2019

Alphare committed rHG2f760da140ee: rust-utils: remove buggy assertion.
rust-utils: remove buggy assertion
Jul 18 2019, 8:49 AM
Alphare committed rHG5672bb73f61e: rust-utils: add docstrings and doctests for utils.rs.
rust-utils: add docstrings and doctests for utils.rs
Jul 18 2019, 8:49 AM
Alphare committed rHG326fdce22fb2: rust: switch hg-core and hg-cpython to rust 2018 edition.
rust: switch hg-core and hg-cpython to rust 2018 edition
Jul 18 2019, 8:49 AM
Alphare added a comment to D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition.
In D6597#97348, @yuja wrote:

diff --git a/rust/hg-core/src/utils/mod.rs b/rust/hg-core/src/utils/mod.rs
deleted file mode 100644

Can you rename these instead of adding new files? Last time I fixed that
manually, and I don't wanna do that again.

Jul 18 2019, 5:24 AM

Jul 17 2019

Alphare closed D6651: rust-utils: remove buggy assertion.
Jul 17 2019, 7:04 PM
Alphare committed rHGa6a272c4ebf9: rust-utils: remove buggy assertion.
rust-utils: remove buggy assertion
Jul 17 2019, 7:04 PM
Alphare updated the diff for D6427: discovery: new devel.discovery.randomize option.
Jul 17 2019, 12:31 PM
Alphare updated the diff for D6426: rust-discovery: optionally don't randomize at all, for tests.
Jul 17 2019, 12:31 PM
Alphare updated the diff for D6424: rust-discovery: takefullsample() core implementation.
Jul 17 2019, 12:31 PM