Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User Details

User Since
Apr 18 2019, 7:59 AM (106 w, 6 d)

Recent Activity

Today

Alphare closed D10360: sidedata: move sidedata-related utils to the dedicated module.
Wed, May 5, 6:45 PM
Alphare closed D10361: sidedata: move documentation about sidedata helpers to sidedata module.
Wed, May 5, 6:44 PM
Alphare closed D10359: sidedata: replace sidedata upgrade mechanism with the new one.
Wed, May 5, 6:44 PM
Alphare committed rHG8bd769b5c941: sidedata: move documentation about sidedata helpers to sidedata module.
sidedata: move documentation about sidedata helpers to sidedata module
Wed, May 5, 6:44 PM
Alphare closed D10344: sidedata: enable sidedata computers to optionally rewrite flags.
Wed, May 5, 6:44 PM
Alphare committed rHG3aab2330b7d3: sidedata: move sidedata-related utils to the dedicated module.
sidedata: move sidedata-related utils to the dedicated module
Wed, May 5, 6:43 PM
Alphare closed D10358: sidedata: add a way of replacing an existing sidedata computer.
Wed, May 5, 6:43 PM
Alphare committed rHG27f1191b1305: sidedata: replace sidedata upgrade mechanism with the new one.
sidedata: replace sidedata upgrade mechanism with the new one
Wed, May 5, 6:43 PM
Alphare committed rHG81eb7091c494: sidedata: add a way of replacing an existing sidedata computer.
sidedata: add a way of replacing an existing sidedata computer
Wed, May 5, 6:43 PM
Alphare closed D10345: bundle2: remove restriction around sidedata.
Wed, May 5, 6:42 PM
Alphare closed D10343: cg4: introduce protocol flag to signify the presence of sidedata.
Wed, May 5, 6:42 PM
Alphare committed rHG1680c94741f8: bundle2: remove restriction around sidedata.
bundle2: remove restriction around sidedata
Wed, May 5, 6:42 PM
Alphare committed rHG223b47235d1c: sidedata: enable sidedata computers to optionally rewrite flags.
sidedata: enable sidedata computers to optionally rewrite flags
Wed, May 5, 6:42 PM
Alphare committed rHG119790e1c67c: cg4: introduce protocol flag to signify the presence of sidedata.
cg4: introduce protocol flag to signify the presence of sidedata
Wed, May 5, 6:41 PM
Alphare closed D10341: sidedata: gate sidedata functionality to revlogv2 in more places.
Wed, May 5, 6:41 PM
Alphare committed rHG08e26ef4ad35: changegroup: don't limit cgv4 to revlogv2 repos.
changegroup: don't limit cgv4 to revlogv2 repos
Wed, May 5, 6:40 PM
Alphare closed D10342: changegroup: don't limit cgv4 to revlogv2 repos.
Wed, May 5, 6:39 PM
Alphare committed rHG5554aacd783f: sidedata: gate sidedata functionality to revlogv2 in more places.
sidedata: gate sidedata functionality to revlogv2 in more places
Wed, May 5, 6:39 PM
Alphare closed D10340: sidedata: register copies sidedata computer regardless of the revlog version.
Wed, May 5, 6:39 PM
Alphare committed rHGb409cdc6a139: sidedata: register copies sidedata computer regardless of the revlog version.
sidedata: register copies sidedata computer regardless of the revlog version
Wed, May 5, 6:38 PM

Yesterday

Alphare created D10639: rust-status: fix ignore and include not composing (issue6514).

Pending CI refresh

Tue, May 4, 4:48 AM
Alphare created D10638: rust-status: highlight a bug in Rust-augmented status.

Pending CI refresh

Tue, May 4, 4:48 AM

Mon, May 3

D10555: rust: Remove handling of `parents` in `DirstateMap` is now accepted and ready to land.
Mon, May 3, 3:18 PM
Alphare committed rHG7431f5ab0d2a: branching: merge stable into default.
branching: merge stable into default
Mon, May 3, 1:16 PM
D10560: dirstate-tree: Borrow paths from the "on disk" bytes is now accepted and ready to land.
Mon, May 3, 12:45 PM
D10559: dirstate-tree: Borrow copy source paths from the "on disk" bytes is now accepted and ready to land.
Mon, May 3, 12:24 PM
D10558: rust: Use `&HgPath` instead of `&HgPathBuf` in may APIs is now accepted and ready to land.
Mon, May 3, 12:23 PM
D10557: dirstate-tree: Make `DirstateMap` borrow from a bytes buffer is now accepted and ready to land.

Note: Simon and I discussed this at length beforehand.

Mon, May 3, 12:21 PM
D10556: rust: Read dirstate from disk in DirstateMap constructor is now accepted and ready to land.
Mon, May 3, 12:06 PM
Alphare added a comment to D10555: rust: Remove handling of `parents` in `DirstateMap`.

While I'm always happy about removing code, what happens in a non-Python context? Are we ripping support for reading/setting parents? Or would that come back in a different form later?

Mon, May 3, 11:55 AM
D10554: dirstate-tree: Fold "tracked descendants" counter update in main walk is now accepted and ready to land.
Mon, May 3, 11:50 AM
Alphare committed rHG19fac68f1d53: branching: merge stable into default.
branching: merge stable into default
Mon, May 3, 11:41 AM
D10553: dirstate-tree: Use HashMap instead of BTreeMap is now accepted and ready to land.
Mon, May 3, 10:49 AM
D10552: dirstate-tree: Add #[timed] attribute to `status` and `DirstateMap::read` is now accepted and ready to land.
Mon, May 3, 10:48 AM
D10551: dirstate-tree: Paralellize the status algorithm with Rayon is now accepted and ready to land.

I wonder which of using std::Mutex vs a crossbeam channel is faster. But this can be fine-tuned when we actually have most of the work done.

Mon, May 3, 10:48 AM
D10550: dirstate-tree: Avoid BTreeMap double-lookup when inserting a dirstate entry is now accepted and ready to land.
Mon, May 3, 10:44 AM
D10549: dirstate-tree: Handle I/O errors in status is now accepted and ready to land.
Mon, May 3, 10:40 AM
Alphare added a comment to D10548: dirstate-tree: Ignore FIFOs etc. in the status algorithm.

If the non-file, non-symlink entry is exactly matched, it should be reported as a warning as a "bad" match

Mon, May 3, 10:39 AM
Alphare added inline comments to D10547: dirstate-tree: Add the new `status()` algorithm.
Mon, May 3, 10:37 AM
Alphare added inline comments to D10546: dirstate-tree: Give to `status()` mutable access to the `DirstateMap`.
Mon, May 3, 9:03 AM
D10495: rust: Add doc-comments to DirstateStatus fields is now accepted and ready to land.
Mon, May 3, 9:02 AM
D10491: dirstate-tree: Add add_file, remove_file, and drop_file is now accepted and ready to land.
Mon, May 3, 9:02 AM
D10490: dirstate-tree: Add has_dir and has_tracked_dir is now accepted and ready to land.
Mon, May 3, 9:01 AM
D10536: core: don't hard-code node length is now accepted and ready to land.
Mon, May 3, 8:07 AM
D10535: core: don't hard-code hex node lengths is now accepted and ready to land.
Mon, May 3, 8:07 AM
D10534: tests: bump default timeout to 360s is now accepted and ready to land.
Mon, May 3, 8:07 AM
D10533: manifests: push down expected node length into the parser is now accepted and ready to land.
Mon, May 3, 8:07 AM
Alphare added a comment to D10513: convert-bazaar: use breezy package instead of old bzr one.

Just to be clear, this is now good to review.

Mon, May 3, 7:51 AM
Alphare added inline comments to D10495: rust: Add doc-comments to DirstateStatus fields.
Mon, May 3, 6:19 AM

Fri, Apr 30

Alphare added a comment to D10470: chg: pass --no-profile to disable profiling when starting hg serve.

This breaks the CI https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/21383.

Fri, Apr 30, 11:56 AM

Thu, Apr 29

D10500: relnotes: copy contents of "next" to "5.8" and clear "next" is now accepted and ready to land.
Thu, Apr 29, 10:58 AM
D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames is now accepted and ready to land.

I thought I'd run the entire test suite and it passed before sending. Sorry about that! Fixed fncache and inherit-mode by not writing out the narrowspec backup in the mkstemp call. I'm not getting any failures in test-check-code.t, can you share what ones you're seeing?

Thu, Apr 29, 10:57 AM
D10511: revlog: code for `revlogv0` in its own module is now accepted and ready to land.
Thu, Apr 29, 10:43 AM
D10510: revlog: have an explicit "pack_header" method is now accepted and ready to land.
Thu, Apr 29, 10:43 AM
D10509: revlog: remove the revlogio class is now accepted and ready to land.
Thu, Apr 29, 10:37 AM
D10508: revlog: add a `entry_binary` method on index is now accepted and ready to land.
Thu, Apr 29, 10:36 AM
D10530: rewriteutil: adapt "cannot %s while merging" to work with "change branch of" is now accepted and ready to land.
Thu, Apr 29, 10:27 AM
D10455: urlutil: provide some information about "bad url" when processing `pushurl` is now accepted and ready to land.
Thu, Apr 29, 9:46 AM
D10454: revset: document the `outgoing` behavior if the path resolve to multiple urls is now accepted and ready to land.
Thu, Apr 29, 9:43 AM
D10453: multi-urls: document the feature is now accepted and ready to land.
Thu, Apr 29, 9:43 AM
D10452: multi-urls: add a boolean suboption that unlock path specification as list is now accepted and ready to land.
Thu, Apr 29, 9:42 AM
D10451: urlutil: move url "fixing" at the time of `ui.paths` initialization is now accepted and ready to land.
Thu, Apr 29, 9:37 AM
D10450: path: teach the `hg path` command to display boolean sub-option is now accepted and ready to land.
Thu, Apr 29, 9:18 AM
D10449: parselist: move the function from config to stringutil is now accepted and ready to land.
Thu, Apr 29, 9:17 AM
D10448: bookmark: use `list_paths` to access path definition is now accepted and ready to land.
Thu, Apr 29, 9:16 AM
D10447: urlutil: make `paths` class old list of `path` now requires changes to proceed.
Thu, Apr 29, 9:14 AM

Wed, Apr 28

Alphare closed D10506: lint: fix failing code check.
Wed, Apr 28, 11:09 AM
Alphare committed rHGfceccc36873d: lint: fix failing code check.
lint: fix failing code check
Wed, Apr 28, 11:09 AM
Alphare created D10513: convert-bazaar: use breezy package instead of old bzr one.
Wed, Apr 28, 11:04 AM
Alphare added a comment to D10513: convert-bazaar: use breezy package instead of old bzr one.

I broke something, sorry for the noise.

Wed, Apr 28, 11:02 AM
Alphare created D10512: bzr: only support bzr conversion on Python3.
Wed, Apr 28, 11:02 AM
Alphare added inline comments to D10495: rust: Add doc-comments to DirstateStatus fields.
Wed, Apr 28, 10:59 AM
Alphare created D10506: lint: fix failing code check.
Wed, Apr 28, 10:59 AM
D10493: rust: Remove DirstateMap::file_fold_map is now accepted and ready to land.

A welcome change!

Wed, Apr 28, 10:59 AM
D10494: rust: Move "lookup" a.k.a. "unsure" paths into `DirstateStatus` struct is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10492: dirstate-tree: Add "non normal" and "from other parent" sets is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10486: dirstate-tree: Serialize to disk is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
Alphare added inline comments to D10491: dirstate-tree: Add add_file, remove_file, and drop_file.
Wed, Apr 28, 10:59 AM
Alphare added inline comments to D10490: dirstate-tree: Add has_dir and has_tracked_dir.
Wed, Apr 28, 10:59 AM
D10489: dirstate-tree: Add clear_ambiguous_times in the new DirstateMap is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10488: dirstate-tree: Add copy_map_insert and copy_map_remove is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10487: dirstate-tree: Maintain a counter of DirstateEntry’s and copy sources is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10485: rust: Add a Timestamp struct instead of abusing Duration is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10507: tests: don't hard-code /bin/bash is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
Alphare added a comment to D10506: lint: fix failing code check.

/!\ Meant for stable /!\

Wed, Apr 28, 10:59 AM
Alphare added a comment to D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.

Thanks for following up, I couldn't trigger it on one pipeline run, which is a good sign (on top of the patch making sense to me).

Wed, Apr 28, 10:59 AM
D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames now requires changes to proceed.
Wed, Apr 28, 10:59 AM
D10500: relnotes: copy contents of "next" to "5.8" and clear "next" now requires changes to proceed.

I've taken @marmoute 's series first as you suggested, you can rebase yours now. Thanks for noticing!

Wed, Apr 28, 10:59 AM
D10505: mail: add a TODO about proper mbox locking is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10462: heptapod-ci: enable pytype checking is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10502: packaging: extract pre-computed version when running from plain tarball is now accepted and ready to land.
Wed, Apr 28, 10:59 AM
D10437: url_util: introduce a `try_path` function is now accepted and ready to land.
Wed, Apr 28, 10:59 AM

Tue, Apr 20

D10446: urlutil: extract `chain_path` in a function is now accepted and ready to land.
Tue, Apr 20, 11:29 AM
D10445: urlutil: add a `copy` method to `path is now accepted and ready to land.
Tue, Apr 20, 11:27 AM
D10444: template: add a `paths` field to all entry in peerurls is now accepted and ready to land.

Note, your description contains peersurl instead of peerurls, which had me confused when grepping.

Tue, Apr 20, 11:24 AM
D10443: template: make an explicit closure for formatting entry in peerurls is now accepted and ready to land.
Tue, Apr 20, 10:57 AM
D10442: template: use `list_paths` in `peerurls` is now accepted and ready to land.
Tue, Apr 20, 10:57 AM
D10441: paths: use `list_paths` in `hg paths` is now accepted and ready to land.
Tue, Apr 20, 10:54 AM
D10440: urlutil: introduce a new `list_paths` function is now accepted and ready to land.
Tue, Apr 20, 10:52 AM
D10439: urlutil: deprecate `getpath` is now accepted and ready to land.
Tue, Apr 20, 10:51 AM