Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2019, 7:59 AM (34 w, 1 d)

Recent Activity

Today

Alphare closed D7611: py3: pass bytes to `configint` and `configbool`.
Fri, Dec 13, 1:17 PM
Alphare closed D7612: py3: send bytes from Rust-created warning patterns.
Fri, Dec 13, 1:17 PM
Alphare closed D7610: rust-threads: force Rayon to respect the worker count in config.
Fri, Dec 13, 1:17 PM
Alphare committed rHGa264e8a91798: py3: send bytes from Rust-created warning patterns.
py3: send bytes from Rust-created warning patterns
Fri, Dec 13, 1:17 PM
Alphare committed rHG578c42f998d9: py3: pass bytes to `configint` and `configbool`.
py3: pass bytes to `configint` and `configbool`
Fri, Dec 13, 1:17 PM
Alphare committed rHG37cbf45bb858: rust-threads: force Rayon to respect the worker count in config.
rust-threads: force Rayon to respect the worker count in config
Fri, Dec 13, 1:17 PM
Alphare closed D7609: rust-dirs: handle forgotten `Result`s.
Fri, Dec 13, 12:59 PM
Alphare committed rHGbc7d8f45c3b6: rust-dirs: handle forgotten `Result`s.
rust-dirs: handle forgotten `Result`s
Fri, Dec 13, 12:58 PM
Alphare updated the diff for D7609: rust-dirs: handle forgotten `Result`s.
Fri, Dec 13, 4:53 AM

Yesterday

Alphare added inline comments to D7576: hg-core: add configparser to library.
Thu, Dec 12, 2:57 PM
Alphare added a comment to D7610: rust-threads: force Rayon to respect the worker count in config.

This entire series is a graft of existing changesets onto stable, to fix the current CI for the Rust module policy.

Thu, Dec 12, 12:38 PM
Alphare created D7614: rust-cpython: do not convert warning pattern to utf-8 bytes.
Thu, Dec 12, 12:38 PM
Alphare created D7613: rust-cpython: import utils::files::* function at module level.
Thu, Dec 12, 12:38 PM
Alphare created D7612: py3: send bytes from Rust-created warning patterns.
Thu, Dec 12, 12:38 PM
Alphare created D7611: py3: pass bytes to `configint` and `configbool`.
Thu, Dec 12, 12:38 PM
Alphare created D7610: rust-threads: force Rayon to respect the worker count in config.
Thu, Dec 12, 12:37 PM
Alphare updated the diff for D7530: rust-dirstate-status: update bridge for new rust version of `dirstate.status`.
Thu, Dec 12, 10:41 AM
Alphare retitled D7531: rust-matchers: add support for `exactmatcher` in `dirstate.status` from rust-matchers: add support for `explicitmatcher` in `dirstate.status` to rust-matchers: add support for `exactmatcher` in `dirstate.status`.
Thu, Dec 12, 10:41 AM
Alphare updated the diff for D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait.
Thu, Dec 12, 10:40 AM
Alphare updated the summary of D7528: rust-matchers: add `FileMatcher` implementation.
Thu, Dec 12, 10:40 AM
Alphare updated subscribers of D7609: rust-dirs: handle forgotten `Result`s.

@martinvonz This should be ok.

Thu, Dec 12, 10:10 AM
Alphare updated the diff for D7609: rust-dirs: handle forgotten `Result`s.
Thu, Dec 12, 10:09 AM
Alphare added a comment to D7522: rust-dirs: handle forgotten `Result`s.

Abandoned in favor of D7609

Thu, Dec 12, 10:00 AM
Alphare created D7609: rust-dirs: handle forgotten `Result`s.
Thu, Dec 12, 9:59 AM
Alphare added a comment to D7522: rust-dirs: handle forgotten `Result`s.

@martinvonz I was scratching my head trying to find this changeset to update/rebase it, here's hg obslog -r 5a1ff3d75f35 --hidden:

Thu, Dec 12, 3:59 AM
Alphare added inline comments to D7576: hg-core: add configparser to library.
Thu, Dec 12, 3:48 AM

Wed, Dec 11

Alphare accepted D7604: rust-hg-path: implement more readable custom Debug for HgPath{,Buf}.
Wed, Dec 11, 2:28 PM
Alphare added inline comments to D7528: rust-matchers: add `FileMatcher` implementation.
Wed, Dec 11, 4:29 AM
Alphare added inline comments to D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Wed, Dec 11, 3:42 AM
Alphare added a comment to D7531: rust-matchers: add support for `exactmatcher` in `dirstate.status`.

Yes, I meant exactmatcher indeed.
FileMatcher is meant for the Rust side of things, I do not intend to rename it in Python because it is a minor change that would make a lot of noise for bikeshedding. Do you think that would be a good idea?

Wed, Dec 11, 3:40 AM
Alphare added a comment to D7118: rust-dirstatemap: remove additional lookups in traverse.

What's the state of this patch? The description makes it sound like it's a Rust patch, but it only modifies Python code.

Wed, Dec 11, 3:37 AM

Tue, Dec 10

Alphare added a comment to D7579: tests: add test for Rust formatting.

What are we depending on in the rustfmt settings that's nightly behavior?

Tue, Dec 10, 11:55 AM
Alphare closed D7527: rust-matchers: add doctests for `AlwaysMatcher`.
Tue, Dec 10, 11:18 AM
Alphare closed D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Tue, Dec 10, 11:18 AM
Alphare committed rHG542c8b277261: rust-matchers: add doctests for `AlwaysMatcher`.
rust-matchers: add doctests for `AlwaysMatcher`
Tue, Dec 10, 11:18 AM
Alphare closed D7525: rust-matchers: improve `Matcher` trait ergonomics.
Tue, Dec 10, 11:18 AM
Alphare closed D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible.
Tue, Dec 10, 11:18 AM
Alphare committed rHG4f1543a2f5c3: rust-hg-path: add method to get part of a path relative to a prefix.
rust-hg-path: add method to get part of a path relative to a prefix
Tue, Dec 10, 11:17 AM
Alphare committed rHG1bb4e9b02984: rust-matchers: improve `Matcher` trait ergonomics.
rust-matchers: improve `Matcher` trait ergonomics
Tue, Dec 10, 11:17 AM
Alphare committed rHG088ba9d94079: rust-dirs-multiset: use `AsRef` instead of concrete types when possible.
rust-dirs-multiset: use `AsRef` instead of concrete types when possible
Tue, Dec 10, 11:17 AM
Alphare closed D7116: rust-performance: introduce FastHashMap type alias for HashMap.
Tue, Dec 10, 10:48 AM
Alphare committed rHGc27e688fcdc3: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`.
rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`
Tue, Dec 10, 10:46 AM
Alphare closed D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`.
Tue, Dec 10, 10:46 AM
Alphare committed rHG5ac243a92e37: rust-performance: introduce FastHashMap type alias for HashMap.
rust-performance: introduce FastHashMap type alias for HashMap
Tue, Dec 10, 10:46 AM
Alphare updated the diff for D7530: rust-dirstate-status: update bridge for new rust version of `dirstate.status`.
Tue, Dec 10, 10:27 AM
Alphare updated the diff for D7116: rust-performance: introduce FastHashMap type alias for HashMap.
Tue, Dec 10, 10:27 AM
Alphare updated the diff for D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible.
Tue, Dec 10, 10:26 AM
Alphare updated the diff for D7119: rust-dirstatemap: remove additional lookup in dirstate.matches.
Tue, Dec 10, 10:26 AM
Alphare updated the diff for D7118: rust-dirstatemap: remove additional lookups in traverse.
Tue, Dec 10, 10:26 AM

Mon, Dec 9

Alphare accepted D7582: hg-core: run rustfmt on configparser.
Mon, Dec 9, 8:16 AM
Alphare accepted D7580: hg-core: rustfmt path.rs.
Mon, Dec 9, 8:16 AM
Alphare accepted D7579: tests: add test for Rust formatting.
Mon, Dec 9, 8:15 AM
Alphare added a comment to D7579: tests: add test for Rust formatting.

While I am not a huge fan of the use of a nightly toolchain, I like the fact that we get the latest features and behavior as rustfmt is still pre-1.0 and subject to change. So far, it has been nice to us and has not broken anything I can recall, I vote for keeping it that way until it reaches 1.0.

Mon, Dec 9, 8:15 AM
Alphare accepted D7578: rust: run rustfmt.
Mon, Dec 9, 8:09 AM
Alphare accepted D7577: hg-core: implement Mercurial's config file discovery logic.
Mon, Dec 9, 8:08 AM
Alphare added inline comments to D7575: hg-core: vendor Facebook's configparser crate.
Mon, Dec 9, 8:02 AM
Alphare added inline comments to D7576: hg-core: add configparser to library.
Mon, Dec 9, 8:00 AM
Alphare added inline comments to D7575: hg-core: vendor Facebook's configparser crate.
Mon, Dec 9, 6:38 AM
Alphare added inline comments to D7574: hg-core: add utils::path to project.
Mon, Dec 9, 5:54 AM
Alphare accepted D7573: hg-core: vendor Facebook's path utils module.
Mon, Dec 9, 5:38 AM

Tue, Dec 3

Alphare committed rHG1fe2e574616e: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
rust-dirs: address failing tests for `dirs` impl with a temporary fix
Tue, Dec 3, 10:59 AM

Mon, Dec 2

Alphare added inline comments to D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait.
Mon, Dec 2, 9:21 AM
Alphare added inline comments to D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Mon, Dec 2, 9:20 AM
Alphare updated the diff for D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait.
Mon, Dec 2, 9:20 AM
Alphare updated the diff for D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Mon, Dec 2, 9:20 AM
Alphare added inline comments to D7525: rust-matchers: improve `Matcher` trait ergonomics.
Mon, Dec 2, 9:20 AM
Alphare updated the diff for D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`.
Mon, Dec 2, 9:20 AM
Alphare updated the diff for D7528: rust-matchers: add `FileMatcher` implementation.
Mon, Dec 2, 6:49 AM

Fri, Nov 29

Alphare created D7530: rust-dirstate-status: update bridge for new rust version of `dirstate.status`.
Fri, Nov 29, 1:22 PM
Alphare created D7531: rust-matchers: add support for `exactmatcher` in `dirstate.status`.
Fri, Nov 29, 1:22 PM
Alphare created D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait.
Fri, Nov 29, 1:22 PM
Alphare created D7528: rust-matchers: add `FileMatcher` implementation.
Fri, Nov 29, 12:57 PM
Alphare created D7527: rust-matchers: add doctests for `AlwaysMatcher`.
Fri, Nov 29, 12:57 PM
Alphare created D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Fri, Nov 29, 12:57 PM
Alphare created D7525: rust-matchers: improve `Matcher` trait ergonomics.
Fri, Nov 29, 12:57 PM
Alphare created D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible.
Fri, Nov 29, 12:56 PM
Alphare created D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`.
Fri, Nov 29, 12:56 PM

Wed, Nov 27

Alphare added a comment to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.

Okay, then using non-debug assert!() seems more appropriate. If we prefer
being stricter, "checked" HgPath type can be introduced.
...
Actually I tried to suppress these warnings by propagating Result upwards,
and I got a feeling that we're doing wrong.

Wed, Nov 27, 8:35 AM
Alphare created D7522: rust-dirs: handle forgotten `Result`s.
Wed, Nov 27, 8:30 AM
Alphare added a comment to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.

I generally prefer adding safety checks at ABI boundary. If malicious input
makes Rust code crash or exhaust CPU/memory resource, I would add sanity
check to rust-cpython layer.

Wed, Nov 27, 6:32 AM

Mon, Nov 25

Alphare added a comment to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
In D7503#110345, @yuja wrote:

Many unhandled results:

Mon, Nov 25, 5:25 AM

Fri, Nov 22

Alphare added inline comments to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
Fri, Nov 22, 12:46 PM
Alphare closed D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
Fri, Nov 22, 12:44 PM
Alphare committed rHG20a3bf5e71d6: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
rust-dirs: address failing tests for `dirs` impl with a temporary fix
Fri, Nov 22, 12:44 PM
Alphare created D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
Fri, Nov 22, 4:47 AM

Tue, Nov 19

Alphare added a comment to D7252: dirs: reject consecutive slashes in paths.

Oh, you mean the Rust version doesn't do the same rejection?

Tue, Nov 19, 10:52 AM
Alphare added a comment to D7252: dirs: reject consecutive slashes in paths.

Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted.

Tue, Nov 19, 5:30 AM

Mon, Nov 18

Alphare closed D7453: py3: pass bytes to `configint` and `configbool`.
Mon, Nov 18, 10:49 PM
Alphare closed D7454: py3: send bytes from Rust-created warning patterns.
Mon, Nov 18, 10:49 PM
Alphare committed rHGdc4e74d0ef96: py3: send bytes from Rust-created warning patterns.
py3: send bytes from Rust-created warning patterns
Mon, Nov 18, 10:49 PM
Alphare committed rHG794426e96970: py3: pass bytes to `configint` and `configbool`.
py3: pass bytes to `configint` and `configbool`
Mon, Nov 18, 10:49 PM
Alphare created D7453: py3: pass bytes to `configint` and `configbool`.
Mon, Nov 18, 11:44 AM
Alphare created D7454: py3: send bytes from Rust-created warning patterns.
Mon, Nov 18, 11:44 AM
Alphare accepted D7439: dirstate: include explicit matches in match.traversedir calls.
Mon, Nov 18, 8:59 AM
Alphare accepted D7438: commit: drop unused "vdirs" argument from repo.checkcommitpatterns().
Mon, Nov 18, 4:27 AM
Alphare added inline comments to D7439: dirstate: include explicit matches in match.traversedir calls.
Mon, Nov 18, 4:27 AM
Alphare accepted D7440: dirstate: stop caring about match.explicitdir.
Mon, Nov 18, 4:26 AM
Alphare accepted D7441: match: remove explicitdir attribute.
Mon, Nov 18, 4:26 AM

Fri, Nov 15

Alphare added a comment to D7406: scmutil: convert status data object from a tuple to an attrs (API).

It appears PyCharm is confused by this change, which is weird, because it's supposed to support attrs. I would have to file a bug.

Fri, Nov 15, 4:19 AM

Nov 12 2019

Alphare updated the diff for D7116: rust-performance: introduce FastHashMap type alias for HashMap.
Nov 12 2019, 5:04 AM