Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2019, 7:59 AM (51 w, 2 h)

Recent Activity

Yesterday

Alphare accepted D8384: rust-chg: silence warning about dated coding style.
Wed, Apr 8, 4:48 AM
Alphare added a comment to D8383: rust-chg: update name of the server process.

For (d) [modernizing the codebase], we'll probably want to switch to async-std, but I'm thinking of
upgrading to Tokio 0.2 as an intermediate step since process API isn't
ported to async-std yet. I'm pretty sure future migration to async-std
will be painless compared to the mass rewrite from futures-0.1 to 0.3.

Wed, Apr 8, 4:47 AM
Alphare accepted D8382: rust-chg: send client side umask to server.
Wed, Apr 8, 4:41 AM
Alphare accepted D8381: rust-chg: add config validation and process returned instructions.
Wed, Apr 8, 4:36 AM
Alphare accepted D8380: rust-chg: collect server flags from command arguments.
Wed, Apr 8, 4:23 AM
Alphare accepted D8379: rust-chg: add interface to run "validate" request.
Wed, Apr 8, 4:09 AM
Alphare added a comment to D8378: rust-chg: add helper to parse instructions sent from server.

I had to squint hard at the c code to find any discrepancy, of which there seems to be none.

Wed, Apr 8, 4:03 AM

Fri, Apr 3

Alphare added a comment to D8357: rust-chg: add brief comment about initial capacity of temp_sock_path().

This series is great.

Fri, Apr 3, 8:25 AM
Alphare accepted D8364: rust-chg: send client-side environment variables to server.
Fri, Apr 3, 8:24 AM
Alphare accepted D8363: rust-chg: add helper to pack environment variables.
Fri, Apr 3, 8:24 AM
Alphare accepted D8362: rust-chg: move set_current_dir() to Locator.
Fri, Apr 3, 8:23 AM
Alphare accepted D8361: rust-chg: abort if server doesn't have required capabilities.
Fri, Apr 3, 8:21 AM
Alphare added a comment to D8360: rust-chg: spawn server process if not running.

Aside from the outdated futures and Rust edition that Yuya already said are temporary, this looks good!

Fri, Apr 3, 8:20 AM
Alphare added a comment to D8359: rust-chg: update dependencies.

Shouldn't this be merged with the previous change?

Fri, Apr 3, 8:19 AM
Alphare accepted D8358: rust-chg: depend on released version of tokio-process.
Fri, Apr 3, 8:19 AM
Alphare added a comment to D8357: rust-chg: add brief comment about initial capacity of temp_sock_path().

(I'll be re-pasting all of my comments that got lost in emails for this series)

Fri, Apr 3, 8:18 AM

Tue, Mar 31

Alphare accepted D8338: hook: move stdio redirection to context manager.
Tue, Mar 31, 5:08 AM
Alphare accepted D8333: tests: handle new error string from FreeBSD for dns entry not resolving.
Tue, Mar 31, 5:05 AM
D8314: phabricator: add an option to fold several commits into one review (issue6244) now requires changes to proceed.
Tue, Mar 31, 4:57 AM
Alphare accepted D8313: phabricator: extract logic to print the status when posting a commit.
Tue, Mar 31, 4:39 AM
Alphare accepted D8312: phabricator: extract the logic to amend diff properties to a function.
Tue, Mar 31, 4:35 AM
Alphare accepted D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews.
Tue, Mar 31, 4:33 AM

Wed, Mar 25

Alphare closed D8320: rust: update all dependencies.
Wed, Mar 25, 4:32 PM
Alphare committed rHGc13cbc3872c8: rust: update README to reflect use of `regex` crate.
rust: update README to reflect use of `regex` crate
Wed, Mar 25, 4:32 PM
Alphare closed D8325: rust: update README to reflect use of `regex` crate.
Wed, Mar 25, 4:32 PM
Alphare closed D8315: rust-status: only involve ignore mechanism when needed.
Wed, Mar 25, 4:32 PM
Alphare committed rHGd31d1c0685be: rust: update all dependencies.
rust: update all dependencies
Wed, Mar 25, 4:32 PM
Alphare closed D8319: rust: update micro-timer dependency.
Wed, Mar 25, 4:32 PM
Alphare committed rHGf451a347d21a: rust: update micro-timer dependency.
rust: update micro-timer dependency
Wed, Mar 25, 4:32 PM
Alphare committed rHGe62052d0f377: rust-status: only involve ignore mechanism when needed.
rust-status: only involve ignore mechanism when needed
Wed, Mar 25, 4:31 PM
D8311: phabricator: teach `getoldnodedrevmap()` to handle folded reviews now requires changes to proceed.

Could you add a comment about what happens if you hg split either the base or the tip of the range?

Wed, Mar 25, 2:46 PM
Alphare accepted D8310: phabricator: teach createdifferentialrevision() to allow a folded commit range.
Wed, Mar 25, 2:36 PM
Alphare accepted D8309: phabricator: combine commit messages into the review when folding commits.
Wed, Mar 25, 2:32 PM
Alphare accepted D8308: phabricator: record all local commits used to create a Differential revision.
Wed, Mar 25, 2:18 PM
Alphare accepted D8307: phabricator: account for `basectx != ctx` when calculating renames.
Wed, Mar 25, 2:05 PM
Alphare added a comment to D8306: phabricator: add basectx arguments to file related `phabsend` utilities.

I am very curious as to how the UI will look on a folded series.

Wed, Mar 25, 2:03 PM
Alphare accepted D8305: phabricator: eliminate a couple of duplicate filectx lookups.
Wed, Mar 25, 1:47 PM
Alphare accepted D8322: shelve: split up dounshelve() in unshelvecmd() and _dounshelve().
Wed, Mar 25, 1:43 PM
Alphare accepted D8329: tests: update test-debugcommands.t stack trace checks for python3.9.
Wed, Mar 25, 1:42 PM
Alphare accepted D8328: tests: update test-archive.t expectations for python3.9 changes.
Wed, Mar 25, 1:39 PM
Alphare accepted D8327: setup: relax -Werror for declaration-after-statement on Python 3.9.
Wed, Mar 25, 1:39 PM
Alphare updated the summary of D8320: rust: update all dependencies.
Wed, Mar 25, 5:38 AM
Alphare created D8325: rust: update README to reflect use of `regex` crate.
Wed, Mar 25, 5:38 AM

Tue, Mar 24

Alphare closed D8323: rust-matchers: use the `regex` crate.
Tue, Mar 24, 7:01 PM
Alphare committed rHG496868f1030c: rust-matchers: use the `regex` crate.
rust-matchers: use the `regex` crate
Tue, Mar 24, 7:01 PM
Alphare created D8323: rust-matchers: use the `regex` crate.
Tue, Mar 24, 1:56 PM

Mon, Mar 23

Alphare updated the diff for D8320: rust: update all dependencies.
Mon, Mar 23, 12:24 PM
Alphare created D8320: rust: update all dependencies.
Mon, Mar 23, 12:17 PM
Alphare created D8319: rust: update micro-timer dependency.
Mon, Mar 23, 12:17 PM

Fri, Mar 20

Alphare created D8315: rust-status: only involve ignore mechanism when needed.
Fri, Mar 20, 5:53 PM

Thu, Mar 19

Alphare closed D8300: rust-status: add trace-level logging for Rust status fallback for debugging.
Thu, Mar 19, 4:45 AM
Alphare committed rHG245aec57d76a: rust-status: add trace-level logging for Rust status fallback for debugging.
rust-status: add trace-level logging for Rust status fallback for debugging
Thu, Mar 19, 4:45 AM

Wed, Mar 18

Alphare created D8300: rust-status: add trace-level logging for Rust status fallback for debugging.
Wed, Mar 18, 10:01 AM

Tue, Mar 17

Alphare added a comment to D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.

The next patch attempts to provide coverage. I'm not sure how else to test this, because it wants to communicate with the server to resolve these values, so then it needs to be run as a command to hook up with the VCR infrastructure.

Tue, Mar 17, 4:10 AM

Mon, Mar 16

Alphare closed D8278: rust-core: add missing `Debug` traits.
Mon, Mar 16, 11:22 PM
Alphare committed rHGece43c79333e: rust-core: add missing `Debug` traits.
rust-core: add missing `Debug` traits
Mon, Mar 16, 11:22 PM

Fri, Mar 13

Alphare added a comment to D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list.

This seems like something that can easily have a few simple unit tests

Fri, Mar 13, 12:26 PM
Alphare accepted D8279: tests: remove doctest in narrowspec, it is broken.
Fri, Mar 13, 12:08 PM
Alphare accepted D8258: copies-tests: remove spurious `]` in the template.
Fri, Mar 13, 12:08 PM
Alphare accepted D8137: phabricator: add a config knob to import in the secret phase.
Fri, Mar 13, 11:55 AM
Alphare accepted D8283: tests: simplify test-fix-topology.t slightly by using a `(case !)`.
Fri, Mar 13, 11:49 AM
Alphare accepted D8275: heptapod-ci: fix test paths in the listing file.
Fri, Mar 13, 11:49 AM
Alphare accepted D8276: cext-index: propagate inline_scan error in `index_deref`.
Fri, Mar 13, 11:48 AM

Thu, Mar 12

Alphare created D8278: rust-core: add missing `Debug` traits.
Thu, Mar 12, 7:43 PM
Alphare added a comment to D8246: hg-core: add a compilation error if trying to compile outside of Linux.
In D8246#123554, @yuja wrote:

+/ Remove this to see (potential) non-artificial compile failures. MacOS
+
/ *should* compile, but fail to compile tests for example as of 2020-03-06

Un-doccommented this to silence build warning.

Thu, Mar 12, 4:59 PM
Alphare closed D8274: rust: update the README with more up-to-date and thorough information.
Thu, Mar 12, 12:19 PM
Alphare committed rHG47f8c741df0f: rust: update the README with more up-to-date and thorough information.
rust: update the README with more up-to-date and thorough information
Thu, Mar 12, 12:19 PM
Alphare committed rHGdf5dfee8cfb4: hg-core: add a compilation error if trying to compile outside of Linux.
hg-core: add a compilation error if trying to compile outside of Linux
Thu, Mar 12, 9:02 AM
Alphare created D8274: rust: update the README with more up-to-date and thorough information.
Thu, Mar 12, 5:17 AM

Wed, Mar 11

Alphare committed rHG81a873477feb: test-install: don't print Rust re2 bindings information if Rust is not in use.
test-install: don't print Rust re2 bindings information if Rust is not in use
Wed, Mar 11, 4:10 PM
Alphare closed D8273: test-install: don't print Rust re2 bindings information if Rust is not in use.
Wed, Mar 11, 3:16 PM
Alphare committed rHG9350ae3a42f1: test-install: don't print Rust re2 bindings information if Rust is not in use.
test-install: don't print Rust re2 bindings information if Rust is not in use
Wed, Mar 11, 3:16 PM
Alphare created D8273: test-install: don't print Rust re2 bindings information if Rust is not in use.
Wed, Mar 11, 1:19 PM
Alphare committed rHG5a50e8c39b82: hg-core: add a compilation error if trying to compile outside of Linux.
hg-core: add a compilation error if trying to compile outside of Linux
Wed, Mar 11, 12:34 PM
Alphare closed D8246: hg-core: add a compilation error if trying to compile outside of Linux.
Wed, Mar 11, 12:34 PM
Alphare closed D8253: hg-core: add function timing information.
Wed, Mar 11, 12:26 PM
Alphare closed D8252: rust: add logging utils.
Wed, Mar 11, 12:26 PM
Alphare closed D8251: rust-status: traverse working directory in parallel.
Wed, Mar 11, 12:26 PM
Alphare committed rHGd880805d5442: hg-core: add function timing information.
hg-core: add function timing information
Wed, Mar 11, 12:26 PM
Alphare committed rHG82f51ab7a2dd: rust: add logging utils.
rust: add logging utils
Wed, Mar 11, 12:26 PM
Alphare committed rHGfe7d2cf0b429: rust-status: traverse working directory in parallel.
rust-status: traverse working directory in parallel
Wed, Mar 11, 12:26 PM
Alphare closed D8250: rust-status: wrap `stat_dmap_entries` to ease profiling.
Wed, Mar 11, 12:26 PM
Alphare closed D8226: debuginstall: add entry about re2 Rust bindings when applicable.
Wed, Mar 11, 12:26 PM
Alphare committed rHGb8ba46c97cdd: rust-status: wrap `stat_dmap_entries` to ease profiling.
rust-status: wrap `stat_dmap_entries` to ease profiling
Wed, Mar 11, 12:25 PM
Alphare committed rHG5f6a504dc0bd: rust-status: refactor handling of unknown files.
rust-status: refactor handling of unknown files
Wed, Mar 11, 12:25 PM
Alphare closed D8213: rust-pathauditor: use interior mutability for use in multi-threaded contexts.
Wed, Mar 11, 12:25 PM
Alphare closed D8215: rust-status: move to recursive traversal to prepare for parallel traversal.
Wed, Mar 11, 12:25 PM
Alphare closed D8249: rust-status: refactor handling of unknown files.
Wed, Mar 11, 12:25 PM
Alphare committed rHGf8a9922a02cb: rust-status: move to recursive traversal to prepare for parallel traversal.
rust-status: move to recursive traversal to prepare for parallel traversal
Wed, Mar 11, 12:25 PM
Alphare closed D8212: rust-pathauditor: actually populate the `audited_dirs` cache.
Wed, Mar 11, 12:25 PM
Alphare committed rHG07d9fd6097e6: rust-pathauditor: use interior mutability for use in multi-threaded contexts.
rust-pathauditor: use interior mutability for use in multi-threaded contexts
Wed, Mar 11, 12:25 PM
Alphare closed D7931: rust-status: use bare hg status fastpath from Python.
Wed, Mar 11, 12:25 PM
Alphare committed rHG8a237131ff0f: rust-pathauditor: actually populate the `audited_dirs` cache.
rust-pathauditor: actually populate the `audited_dirs` cache
Wed, Mar 11, 12:25 PM
Alphare committed rHGe63b4a1f2271: rust-pathauditor: actually split Windows shortname aliases at `~`.
rust-pathauditor: actually split Windows shortname aliases at `~`
Wed, Mar 11, 12:25 PM
Alphare closed D8211: rust-pathauditor: actually split Windows shortname aliases at `~`.
Wed, Mar 11, 12:25 PM
Alphare closed D7930: rust-status: update rust-cpython bridge to account for the changes in core.
Wed, Mar 11, 12:25 PM
Alphare committed rHGc989737158aa: debuginstall: add entry about re2 Rust bindings when applicable.
debuginstall: add entry about re2 Rust bindings when applicable
Wed, Mar 11, 12:24 PM
Alphare closed D8225: rust-cpython: add `debug` module to expose debug information to Python.
Wed, Mar 11, 12:24 PM
Alphare committed rHGd4f19eb471ca: rust-cpython: add `debug` module to expose debug information to Python.
rust-cpython: add `debug` module to expose debug information to Python
Wed, Mar 11, 12:24 PM
Alphare closed D7929: rust-status: add bare `hg status` support in hg-core.
Wed, Mar 11, 12:24 PM