Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2019, 7:59 AM (74 w, 2 d)

Recent Activity

Thu, Sep 17

Alphare accepted D9024: run-test: allow relative path in `--blacklist` and `--whitelist` (issue6351).
Thu, Sep 17, 8:02 AM
Alphare added a comment to D9015: rhg: add `--revision` argument to `rhg files`.

Maybe adding some performance numbers in the commit message would be useful and motivating, seeing as it is very fast.

Thu, Sep 17, 6:29 AM
Alphare accepted D9015: rhg: add `--revision` argument to `rhg files`.
Thu, Sep 17, 6:28 AM
Alphare accepted D9014: hg-core: add a `ListRevTrackedFiles` operation.
Thu, Sep 17, 6:23 AM
Alphare added a comment to D9013: hg-core: simplify `list_tracked_files` operation.

Good stuff, thanks for removing the cruft I introduced. :D

Thu, Sep 17, 6:14 AM
D9012: hg-core: add `Revlog.get_node_rev` now requires changes to proceed.
Thu, Sep 17, 6:11 AM
Alphare accepted D9011: hg-core: add `Manifest` a specialized `Revlog`.
Thu, Sep 17, 6:02 AM
Alphare added a comment to D9010: hg-core: add `Changlog` a specialized `Revlog`.

Minor nits, this looks good.

Thu, Sep 17, 5:57 AM
Alphare added a comment to D9005: hg-core: check data integrity in `Revlog`.

Both remarks are nits and can be addressed later if need be, this looks good otherwise.

Thu, Sep 17, 5:48 AM
Alphare added a comment to D8960: rhg: add a `DebugData` `Command` to prepare the `rhg debugdata` subcommand.

Good enough for now, thanks.
I'll probably send a follow-up for the typo and maybe see about removing the .into() calls.

Thu, Sep 17, 5:18 AM

Fri, Sep 11

Alphare closed D8872: rhg: make output of `files` relative to the current directory and the root.
Fri, Sep 11, 5:47 AM
Alphare committed rHG1b3197047f5c: rhg: make output of `files` relative to the current directory and the root.
rhg: make output of `files` relative to the current directory and the root
Fri, Sep 11, 5:46 AM

Thu, Sep 10

Alphare added a comment to D8937: rust: enable on macOS.

Thanks for taking the time to do this.

Thu, Sep 10, 4:33 AM
Alphare accepted D8968: phabricator: Pass through diffoptions.
Thu, Sep 10, 4:17 AM
Alphare added a comment to D8801: obsstore: refactor v1 logic to fix 32 byte hash support.

Other than my "nit but please do it" comment, this looks fine.

Thu, Sep 10, 4:15 AM

Sun, Sep 6

Alphare created D8990: rust-cpython: switch logging facade from `simple_logger` to `env_logger`.
Sun, Sep 6, 4:35 AM
Alphare added inline comments to D8960: rhg: add a `DebugData` `Command` to prepare the `rhg debugdata` subcommand.
Sun, Sep 6, 4:01 AM
Alphare accepted D8959: hg-core: define a `DebugData` `Operation`.
Sun, Sep 6, 3:59 AM
Alphare accepted D8956: rhg: print error message when argument parsing fails.
Sun, Sep 6, 3:52 AM
Alphare accepted D8958: hg-core: Add a limited read only `revlog` implementation.
Sun, Sep 6, 3:51 AM

Mon, Aug 31

Alphare added inline comments to D8958: hg-core: Add a limited read only `revlog` implementation.
Mon, Aug 31, 5:10 AM

Fri, Aug 28

Alphare added inline comments to D8958: hg-core: Add a limited read only `revlog` implementation.
Fri, Aug 28, 1:14 PM
Alphare added inline comments to D8958: hg-core: Add a limited read only `revlog` implementation.
Fri, Aug 28, 9:35 AM
Alphare accepted D8962: rhg: Add debug timing.
Fri, Aug 28, 8:58 AM
Alphare accepted D8961: rhg: add a limited `rhg debugdata` subcommand.
Fri, Aug 28, 8:58 AM
Alphare added inline comments to D8960: rhg: add a `DebugData` `Command` to prepare the `rhg debugdata` subcommand.
Fri, Aug 28, 8:54 AM
D8959: hg-core: define a `DebugData` `Operation` now requires changes to proceed.
Fri, Aug 28, 8:46 AM
Alphare added a comment to D8958: hg-core: Add a limited read only `revlog` implementation.

Overall this looks good. I have obviously left many comments, but a lot of them are nits, and it's a huge patch.

Fri, Aug 28, 8:34 AM
D8958: hg-core: Add a limited read only `revlog` implementation now requires changes to proceed.

This is my partial review, as indicated by my last comment, I'll be resuming it later today.

Fri, Aug 28, 6:11 AM
Alphare accepted D8957: hg-core: fix some `clippy` warnings.
Fri, Aug 28, 4:24 AM
Alphare added inline comments to D8956: rhg: print error message when argument parsing fails.
Fri, Aug 28, 4:23 AM
Alphare accepted D8955: rhg: fix `clippy` warnings.
Fri, Aug 28, 4:19 AM
Alphare accepted D8954: rhg: pass `ui` to `Command` `run`.
Fri, Aug 28, 4:18 AM
Alphare accepted D8953: documentation: add `zstd` compression to the internal `revlogs` documentation.
Fri, Aug 28, 4:18 AM

Tue, Aug 25

Alphare added a comment to D8937: rust: enable on macOS.

I'd like to investigate further, but I'm not sure how to debug the Rust code. The error I get is this:

--- .../tests/test-casefolding.t
+++ .../tests/test-casefolding.t.err
@@ -34,13 +34,226 @@
   $ hg mv a A
   $ hg mv A a
+  ** unknown exception encountered, please report by visiting
+  ** https://mercurial-scm.org/wiki/BugTracker
+  ** Python 3.8.5 (default, Jul 21 2020, 18:31:18) [Clang 11.0.3 (clang-1103.0.32.62)]
+  ** Mercurial Distributed SCM (version 5.4.1+168-120ca13cb67c+20200821)
+  ** Extensions loaded: 
+  Traceback (most recent call last):
[snip]
+    File ".../mercurial/dirstate.py", line 602, in normalize
+      return self._normalize(path, isknown, ignoremissing)
+    File ".../mercurial/dirstate.py", line 569, in _normalize
+      folded = self._map.filefoldmap.get(normed, None)
+    File ".../mercurial/util.py", line 1744, in __get__
+      result = self.func(obj)
+    File ".../mercurial/dirstate.py", line 1888, in filefoldmap
+      return self._rustmap.filefoldmapasdict()
+  TypeError: unhashable type: 'list'
+  [1]

Could you perhaps offer some pointers on how I might investigate what's going wrong?

Tue, Aug 25, 3:55 AM

Fri, Aug 21

D8937: rust: enable on macOS now requires changes to proceed.

What do you mean by "mishandling removed files"? The fold map is there to give a mapping between the normalized (internal) representation of file paths and the actual ones on disk. As much as I hate the dirstate code, this is a useful part of the software that is triggered depending on your filesystem and paths used.

Fri, Aug 21, 4:24 AM

Aug 18 2020

Alphare added a comment to D8872: rhg: make output of `files` relative to the current directory and the root.

@indygreg Does my justification seem reasonable? Could we get both patches accepted?

Aug 18 2020, 5:41 AM

Aug 12 2020

Alphare added inline comments to D8872: rhg: make output of `files` relative to the current directory and the root.
Aug 12 2020, 6:01 AM
Alphare added inline comments to D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand.
Aug 12 2020, 5:58 AM

Aug 3 2020

Alphare added a comment to D8873: rhg: add harness tests for rhg files.

Maybe add an example with | head for completeness?

Aug 3 2020, 11:27 AM
Alphare added a comment to D8872: rhg: make output of `files` relative to the current directory and the root.

To reviewers: this was my changeset, I'm not sure how authorship is attributed but I... accept the revision of course.

Aug 3 2020, 11:25 AM
Alphare accepted D8871: rhg: handle broken pipe error for stderr.
Aug 3 2020, 11:24 AM
Alphare accepted D8870: rhg: extract function handle_stdout_error.
Aug 3 2020, 11:21 AM
Alphare accepted D8869: rhg: add a limited `rhg files` subcommand.
Aug 3 2020, 11:17 AM
Alphare accepted D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand.
Aug 3 2020, 11:17 AM
Alphare added a comment to D8867: rhg: simplify `FindRootError` handling.

Typo in the title: s/simply/simplify/

Aug 3 2020, 11:11 AM
Alphare added a comment to D8866: rhg: add buffered stdout writing possibility.

@acezar Do you remember the kind of performance difference we had when adding this? I think it would be interesting to add it to the commit message.

Aug 3 2020, 11:10 AM
Alphare accepted D8865: rhg: ask the error message from `CommandError`.
Aug 3 2020, 11:08 AM
Alphare accepted D8864: rhg: Do not return error when when we really mean ok in commands.
Aug 3 2020, 11:02 AM
Alphare accepted D8863: hg-core: define a `ListTrackedFiles` `Operation`.
Aug 3 2020, 11:02 AM
Alphare added a comment to D8862: hg-core: remove the `Operation` trait.

To add to this change, it's also entirely possible that we may never need the trait altogether.

Aug 3 2020, 11:00 AM
Alphare accepted D8861: hg-core: make parse_dirstate return references rather than update hashmaps.
Aug 3 2020, 10:59 AM

Jul 30 2020

Alphare accepted D8850: dirstate: restore original estimation and update comment.
Jul 30 2020, 10:57 AM
Alphare added a comment to D8849: dirstate: revert change to Rust binding.

@martinvonz this is inside the dirstatemap variant defined in case we use the Rust version. I agree that a small commit description is needed, otherwise this seems fine.

Jul 30 2020, 3:10 AM

Jul 29 2020

Alphare added inline comments to D8815: dirstate: isolate node len dependency for the pure version.
Jul 29 2020, 4:22 PM

Jul 23 2020

D8773: hg-core: define a `ListTrackedFiles` `Operation` now requires changes to proceed.

Note to reviewers: this series will be updated soon with a lot of changes from IRL discussions we had.

Jul 23 2020, 4:43 AM

Jul 15 2020

Alphare closed D8663: hg-core: define a `dirstate_status` `Operation`.
Jul 15 2020, 12:14 PM
Alphare committed rHG98817e5daca7: hg-core: define a `dirstate_status` `Operation`.
hg-core: define a `dirstate_status` `Operation`
Jul 15 2020, 12:13 PM
Alphare closed D8661: rust-status: refactor status into a struct.
Jul 15 2020, 12:13 PM
Alphare committed rHG470d306e616c: rust-status: improve documentation and readability.
rust-status: improve documentation and readability
Jul 15 2020, 12:13 PM
Alphare closed D8662: rust-status: improve documentation and readability.
Jul 15 2020, 12:13 PM
Alphare committed rHG7528699c6ccb: rust-status: refactor status into a struct.
rust-status: refactor status into a struct
Jul 15 2020, 12:13 PM
Alphare accepted D8647: run-tests: replace '#' with '-' in temp path of repos created for tests.
Jul 15 2020, 12:10 PM
Alphare accepted D8750: extensions: make `hg nonexistent` not crash with PyOxidizer.
Jul 15 2020, 12:03 PM
Alphare added a comment to D8690: extdiff: add some comments in diffrevs().

I'm not a big fan of the small-but-non-obvious variable names in this series, but they predate your patches, so maybe for another time.
Thanks for this series

Jul 15 2020, 12:02 PM
Alphare accepted D8689: extdiff: add comments and minor variable renames diffpatch().
Jul 15 2020, 11:59 AM
D8688: extdiff: remove unrequired do3way argument to diffpatch() now requires changes to proceed.
Jul 15 2020, 11:59 AM
Alphare accepted D8688: extdiff: remove unrequired do3way argument to diffpatch().
Jul 15 2020, 11:57 AM
Alphare added a comment to D8687: extdiff: refactor logic to diff revs of versions of files.

Thanks again for refactoring

Jul 15 2020, 11:56 AM
Alphare added a comment to D8686: extdiff: refactor logic which does diff of patches.

Thanks for refactoring first!

Jul 15 2020, 11:50 AM
Alphare added a comment to D8749: absorb: make it explicit if empty changeset was created.

Not a fan of the wording, as you said... Maybe "became empty as <rev>:<hash>"?

Jul 15 2020, 11:36 AM
Alphare accepted D8748: absorb: consider rewrite.empty-successor configuration.
Jul 15 2020, 11:33 AM
Alphare accepted D8747: rebase: consider rewrite.empty-successor configuration.
Jul 15 2020, 11:30 AM
Alphare accepted D8746: rewriteutil: add utility to check whether empty successors should be skipped.
Jul 15 2020, 11:26 AM
Alphare added a comment to D8745: config: add option to control creation of empty successors during rewrite.

I seems like a good idea, but pinging @marmoute on this since he might have more perspective on that subject.

Jul 15 2020, 11:03 AM

Jul 1 2020

Alphare accepted D8632: debugcommands: introduce new debugrequirements command.
Jul 1 2020, 11:21 AM
Alphare accepted D8670: repoview: use the phasecache directly to determine mutable revisions.
Jul 1 2020, 11:20 AM
Alphare accepted D8613: rhg: add a limited `rhg root` subcommand.
Jul 1 2020, 5:15 AM

Jun 29 2020

Alphare abandoned D8634: hg-core: commit forgotten Cargo.lock.
Jun 29 2020, 4:17 AM

Jun 25 2020

Alphare created D8663: hg-core: define a `dirstate_status` `Operation`.
Jun 25 2020, 5:03 AM
Alphare created D8661: rust-status: refactor status into a struct.
Jun 25 2020, 5:03 AM
Alphare created D8662: rust-status: improve documentation and readability.
Jun 25 2020, 5:03 AM

Jun 24 2020

Alphare accepted D8612: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.
Jun 24 2020, 10:05 AM
D8613: rhg: add a limited `rhg root` subcommand now requires changes to proceed.
Jun 24 2020, 10:05 AM

Jun 22 2020

Alphare added a comment to D8614: rhg: add rhg tests to the Rust tests.

Maybe send another patch that updates contrib/heptapod-ci.yml?

Jun 22 2020, 10:47 AM
Alphare added a comment to D8613: rhg: add a limited `rhg root` subcommand.

nit: "it's a wild used" -> "it's a wildly used" and "it can deal with bytes"... technically it deals with OS encoding. Which is good for our purposes, but is slightly different.

Jun 22 2020, 10:46 AM
Alphare added a comment to D8612: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

Looks good. If I could nitpick some more, the description talks about WTF8, when it's UTF8 (because we're talking about String and not OsString).

Jun 22 2020, 10:44 AM
D8648: [rhg] format code now requires changes to proceed.

(I know this is a misfire, but just so that this isn't taken by a committed)
The title is invalid

Jun 22 2020, 5:49 AM

Jun 16 2020

Alphare closed D8635: rust: do a clippy pass.
Jun 16 2020, 4:04 PM
Alphare committed rHG26114bd6ec60: rust: do a clippy pass.
rust: do a clippy pass
Jun 16 2020, 4:03 PM

Jun 15 2020

Alphare created D8635: rust: do a clippy pass.
Jun 15 2020, 1:58 PM
Alphare created D8634: hg-core: commit forgotten Cargo.lock.
Jun 15 2020, 1:55 PM
Alphare accepted D8611: rhg: add Command trait for subcommands implemented by rhg.
Jun 15 2020, 5:32 AM
Alphare accepted D8610: rhg: add rhg crate.
Jun 15 2020, 5:32 AM
Alphare accepted D8609: hg-core: add FindRoot operation to find repository root path.
Jun 15 2020, 5:31 AM
Alphare accepted D8608: hg-core: add Operation interface for high-level hg operations.
Jun 15 2020, 5:28 AM

Jun 9 2020

Alphare closed D8605: rust-dependencies: upgrade `micro-timer` dependency.
Jun 9 2020, 6:09 AM
Alphare committed rHG2093b2fc70d4: rust-dependencies: upgrade `micro-timer` dependency.
rust-dependencies: upgrade `micro-timer` dependency
Jun 9 2020, 6:09 AM

Jun 5 2020

D8613: rhg: add a limited `rhg root` subcommand now requires changes to proceed.
Jun 5 2020, 11:46 AM

Jun 2 2020

Alphare created D8605: rust-dependencies: upgrade `micro-timer` dependency.
Jun 2 2020, 11:24 AM