Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User Details

User Since
Apr 18 2019, 7:59 AM (131 w, 2 d)

Recent Activity

Yesterday

D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy is now accepted and ready to land.
Fri, Oct 22, 3:25 AM

Thu, Oct 21

Alphare added a comment to D11716: tests: better determinism in test-chg.t.

The use of sleep is definitely an issue that should be fixed (should have been months ago but delays), but this stops it from being irritating for a bit while not actually really hiding a bug (IIUC)

Thu, Oct 21, 12:56 PM
Alphare committed rHG96aa3a68d3b5: branching: merge stable into default.
branching: merge stable into default
Thu, Oct 21, 11:26 AM
Alphare closed D11717: heptapod-ci: actually give pytest more time before timeout.
Thu, Oct 21, 10:41 AM
Alphare committed rHGf3e218ae3fd9: heptapod-ci: actually give pytest more time before timeout.
heptapod-ci: actually give pytest more time before timeout
Thu, Oct 21, 10:41 AM
D11716: tests: better determinism in test-chg.t is now accepted and ready to land.

I'll queue this on stable to help benefit the 5.9.3 release as well, and try to merge into default.

Thu, Oct 21, 8:07 AM
Alphare created D11717: heptapod-ci: actually give pytest more time before timeout.
Thu, Oct 21, 8:03 AM
Alphare added inline comments to D11713: dirstate: add missing return on platforms without exec or symlink.
Thu, Oct 21, 3:43 AM
Alphare created D11715: dirstate: group return logic and clarify each function in flagfunc.
Thu, Oct 21, 3:42 AM
Alphare committed rHG3a95a4e660b9: python: compatibility for python 3.11 (issue6604).
python: compatibility for python 3.11 (issue6604)
Thu, Oct 21, 3:27 AM
Alphare committed rHGf6b045910d82: pyoxidizer: force pip to not use pep517 in order to be able to install hg.
pyoxidizer: force pip to not use pep517 in order to be able to install hg
Thu, Oct 21, 3:27 AM

Wed, Oct 20

Alphare added a comment to D11713: dirstate: add missing return on platforms without exec or symlink.

I'm not sure the etiquette here; I'm accepting the revision since it obviously fixes a bug, but still would like the comments to be considered/responded to?

Wed, Oct 20, 5:10 PM
Alphare created D11713: dirstate: add missing return on platforms without exec or symlink.
Wed, Oct 20, 1:07 PM
Alphare created D11712: parsers: don't ask about symlinks on platforms that don't support them.
Wed, Oct 20, 1:07 PM
Alphare created D11711: parsers: don't ask about the exec bit on platforms that don't have it.
Wed, Oct 20, 1:07 PM
Alphare closed D11690: python: compatibility for python 3.11 (issue6604).
Wed, Oct 20, 11:52 AM
Alphare committed rHGcc9acd2c6fd0: python: compatibility for python 3.11 (issue6604).
python: compatibility for python 3.11 (issue6604)
Wed, Oct 20, 11:52 AM
Alphare committed rHGe95fd116c968: pyoxidizer: force pip to not use pep517 in order to be able to install hg.
pyoxidizer: force pip to not use pep517 in order to be able to install hg
Wed, Oct 20, 11:52 AM
Alphare closed D11710: pyoxidizer: force pip to not use pep517 in order to still be able to install hg.
Wed, Oct 20, 11:16 AM
Alphare committed rHGf2694f9d90dc: pyoxidizer: force pip to not use pep517 in order to still be able to install hg.
pyoxidizer: force pip to not use pep517 in order to still be able to install hg
Wed, Oct 20, 11:16 AM
Alphare added inline comments to D11709: dirstate-v2: freeze the on-disk format.
Wed, Oct 20, 11:11 AM
Alphare created D11710: pyoxidizer: force pip to not use pep517 in order to still be able to install hg.
Wed, Oct 20, 11:04 AM
Alphare added a comment to D11703: rust-nodemap: backed out mitigation for issue 6554.

Not sure why phab hasn't picked up on it yet, but this has been queued.

Wed, Oct 20, 5:34 AM
D11704: dirstate-v2: reorder flag to group related one together is now accepted and ready to land.
Wed, Oct 20, 5:26 AM
D11694: dirstate-v2: adjust the meaning of directory flags is now accepted and ready to land.
Wed, Oct 20, 5:26 AM
Alphare added a comment to D11707: fsmonitor: fix traceback after removal of nonnormalset (issue6600).

This only affects default which is why it's not for stable (just so it's clear it's not a mistake).

Wed, Oct 20, 5:20 AM
D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve is now accepted and ready to land.
Wed, Oct 20, 5:14 AM
D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt is now accepted and ready to land.

This looks good, but it should go on stable (as should the fix), I'll tell you if that doesn't apply.

Wed, Oct 20, 5:07 AM
D11704: dirstate-v2: reorder flag to group related one together now requires changes to proceed.
Wed, Oct 20, 4:56 AM
D11695: dirstate-v2: read the fallback value in Rust is now accepted and ready to land.

Oops

Wed, Oct 20, 4:53 AM
D11694: dirstate-v2: adjust the meaning of directory flags now requires changes to proceed.

Since this needs a bit of work, you can also go back to add the docstring I asked in the earlier patch in the same update.

Wed, Oct 20, 4:52 AM
D11702: dirstate-v2: actually use sub-second mtime precision is now accepted and ready to land.
Wed, Oct 20, 4:40 AM
D11701: dirstate: ignore sub-second component when either is zero in mtime is now accepted and ready to land.
Wed, Oct 20, 4:39 AM
D11700: dirstate-v2: add a new MTIME_SECOND_AMBIGUOUS flags is now accepted and ready to land.
Wed, Oct 20, 4:35 AM
D11696: rust: remove now-unused DirstateEntry::clear_ambiguous_mtime method is now accepted and ready to land.
Wed, Oct 20, 4:33 AM
D11699: dirstate: align Rust function name to `need_delay` is now accepted and ready to land.

I think a docstring would be good for this function. If this ends up being the only nit in the series it can be done in a follow-up.

Wed, Oct 20, 4:33 AM
D11691: dirstate: rename a `very_likely_equal` method to `likely_equal` is now accepted and ready to land.
Wed, Oct 20, 4:31 AM
Alphare created D11708: fsmonitor: fix traceback about bytes and str incompatibility.
Wed, Oct 20, 4:27 AM
Alphare created D11707: fsmonitor: fix traceback after removal of nonnormalset (issue6600).
Wed, Oct 20, 4:26 AM
D11698: pyoxidizer: update README.md with several small fixes is now accepted and ready to land.
Wed, Oct 20, 3:22 AM
Alphare added a comment to D11703: rust-nodemap: backed out mitigation for issue 6554.

Note that this should have been on stable, but I think the rebase will go fine.

Wed, Oct 20, 3:21 AM
D11703: rust-nodemap: backed out mitigation for issue 6554 is now accepted and ready to land.

Thanks, just in time for 5.9.3 and 6.0, we forgot about it :)

Wed, Oct 20, 3:20 AM
D11697: pyoxidizer: disable using in-memory resources is now accepted and ready to land.
Wed, Oct 20, 3:18 AM

Tue, Oct 19

Alphare closed D11693: backout: backed out changeset 6edc8800dbc3.
Tue, Oct 19, 1:50 PM
Alphare closed D11692: backout: backed out changeset 2f2107c01dee.
Tue, Oct 19, 1:50 PM
Alphare added a reverting change for D11627: dispatch: ignore failure to flush ui: rHG56d037d07395: backout: backed out changeset 2f2107c01dee.
Tue, Oct 19, 1:50 PM
Alphare added a reverting change for rHG2f2107c01dee: dispatch: ignore failure to flush ui: rHG56d037d07395: backout: backed out changeset 2f2107c01dee.
Tue, Oct 19, 1:50 PM
Alphare added reverted changes for rHG56d037d07395: backout: backed out changeset 2f2107c01dee: rHG2f2107c01dee: dispatch: ignore failure to flush ui, D11627: dispatch: ignore failure to flush ui.
backout: backed out changeset 2f2107c01dee
Tue, Oct 19, 1:50 PM
Alphare added a reverting change for D11628: dispatch: use detailed exit code 250 for keyboard interrupt: rHG8c34edb1ad10: backout: backed out changeset 6edc8800dbc3.
Tue, Oct 19, 1:49 PM
Alphare added a reverting change for rHG6edc8800dbc3: dispatch: use detailed exit code 250 for keyboard interrupt: rHG8c34edb1ad10: backout: backed out changeset 6edc8800dbc3.
Tue, Oct 19, 1:49 PM
Alphare added reverted changes for rHG8c34edb1ad10: backout: backed out changeset 6edc8800dbc3: rHG6edc8800dbc3: dispatch: use detailed exit code 250 for keyboard interrupt, D11628: dispatch: use detailed exit code 250 for keyboard interrupt.
backout: backed out changeset 6edc8800dbc3
Tue, Oct 19, 1:49 PM
Alphare added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 1:05 PM
Alphare created D11693: backout: backed out changeset 6edc8800dbc3.
Tue, Oct 19, 1:05 PM
Alphare created D11692: backout: backed out changeset 2f2107c01dee.
Tue, Oct 19, 1:05 PM
Alphare added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 11:12 AM
Alphare added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 11:07 AM
Alphare added a reverting change for D11627: dispatch: ignore failure to flush ui: rHGd24bba52407d: backout: backed out changeset 2f2107c01dee (+1 change).
Tue, Oct 19, 11:02 AM
Alphare added a reverting change for rHG2f2107c01dee: dispatch: ignore failure to flush ui: rHGd24bba52407d: backout: backed out changeset 2f2107c01dee (+1 change).
Tue, Oct 19, 11:02 AM
Alphare added reverted changes for rHGd24bba52407d: backout: backed out changeset 2f2107c01dee (+1 change): rHG2f2107c01dee: dispatch: ignore failure to flush ui, D11627: dispatch: ignore failure to flush ui.
backout: backed out changeset 2f2107c01dee (+1 change)
Tue, Oct 19, 11:02 AM
Alphare created D11690: python: compatibility for python 3.11 (issue6604).
Tue, Oct 19, 10:09 AM
Alphare added a reverting change for D11627: dispatch: ignore failure to flush ui: rHGfbda0f5b57b9: backout: backed out changeset 2f2107c01dee (+1 change).
Tue, Oct 19, 9:51 AM
Alphare added a reverting change for rHG2f2107c01dee: dispatch: ignore failure to flush ui: rHGfbda0f5b57b9: backout: backed out changeset 2f2107c01dee (+1 change).
Tue, Oct 19, 9:51 AM
Alphare added reverted changes for rHGfbda0f5b57b9: backout: backed out changeset 2f2107c01dee (+1 change): rHG2f2107c01dee: dispatch: ignore failure to flush ui, D11627: dispatch: ignore failure to flush ui.
backout: backed out changeset 2f2107c01dee (+1 change)
Tue, Oct 19, 9:51 AM
D11684: dirstate: store mtimes with nanosecond precision in memory is now accepted and ready to land.
Tue, Oct 19, 8:44 AM
D11687: dirstate: make DirstateItem constructor accept fallback value is now accepted and ready to land.
Tue, Oct 19, 8:13 AM
D11686: dirstate: add a concept of "fallback" flags to dirstate item is now accepted and ready to land.
Tue, Oct 19, 8:12 AM
D11682: dirstate-v2: adds two flag to track the presence of some unrecorded files is now accepted and ready to land.
Tue, Oct 19, 8:08 AM
Alphare added a reverting change for D11627: dispatch: ignore failure to flush ui: rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 7:56 AM
Alphare added a reverting change for rHG2f2107c01dee: dispatch: ignore failure to flush ui: rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 7:56 AM
Alphare added reverted changes for rHG8fb71d1ab953: Backed out changeset 2f2107c01dee: rHG2f2107c01dee: dispatch: ignore failure to flush ui, D11627: dispatch: ignore failure to flush ui.
Backed out changeset 2f2107c01dee
Tue, Oct 19, 7:56 AM
Alphare committed rHG531d26b1390a: rewrite: fix issue6599.
rewrite: fix issue6599
Tue, Oct 19, 7:46 AM
Alphare updated subscribers of D11685: rewrite: fix issue6599.

@joerg.sonnenberger mentioned that the length check isn't needed, so I'll amend my change to remove it.

Tue, Oct 19, 7:44 AM
D11689: rhg: simplify split_metadata is now accepted and ready to land.

That looks good, thanks.

Tue, Oct 19, 7:35 AM
Alphare added inline comments to D11679: rhg: internally, return a structured representation from hg cat.
Tue, Oct 19, 5:39 AM
Alphare added inline comments to D11688: dirstate-v2: preserve the fallback values on disk.
Tue, Oct 19, 4:29 AM
D11687: dirstate: make DirstateItem constructor accept fallback value now requires changes to proceed.
Tue, Oct 19, 4:19 AM
D11686: dirstate: add a concept of "fallback" flags to dirstate item now requires changes to proceed.

Adding my comments on top of Matt's.

Tue, Oct 19, 4:15 AM
D11682: dirstate-v2: adds two flag to track the presence of some unrecorded files now requires changes to proceed.

Aside from my one comment, the commit message should say "whether unknown/ignored children are recorded or not"

Tue, Oct 19, 3:58 AM
Alphare added a comment to D11679: rhg: internally, return a structured representation from hg cat.

@aalekseyev could you follow-up on the new comments?

Tue, Oct 19, 3:52 AM

Mon, Oct 18

Alphare closed D11360: pyoxidizer: default to a meaningless release instead of hardcoding 5.8.
Mon, Oct 18, 3:35 PM
Alphare committed rHG7f23a472068f: pyoxidizer: default to a meaningless release instead of hardcoding 5.8.
pyoxidizer: default to a meaningless release instead of hardcoding 5.8
Mon, Oct 18, 3:35 PM
Alphare closed D11683: fix: appease pyflakes and make unused variables more obvious.
Mon, Oct 18, 3:35 PM
Alphare committed rHG2f7caef017d9: fix: appease pyflakes and make unused variables more obvious.
fix: appease pyflakes and make unused variables more obvious
Mon, Oct 18, 3:34 PM
Alphare closed D11685: rewrite: fix issue6599.
Mon, Oct 18, 3:34 PM
Alphare committed rHG32b824459175: rewrite: fix issue6599.
rewrite: fix issue6599
Mon, Oct 18, 3:34 PM
Alphare added a comment to D11627: dispatch: ignore failure to flush ui.

Oh, it does reproduce for me too now. Sorry, I had forgotten that I updated to another commit while trying to figure out how to run the python2 test. I'll see if I can figure out what's happening there. Worst case we roll it back and wait until after we don't care about py2 anymore.

Mon, Oct 18, 12:34 PM
Alphare added a comment to D11627: dispatch: ignore failure to flush ui.

This breaks CI on Python 2: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254041
We unfortunately have to support Python 2 until the release in a few days, so this should get fixed.

It doesn't reproduce for me. Does it for you? I wonder what I need to do to make it reproduce. I have /dev/full.

Mon, Oct 18, 12:11 PM
D11682: dirstate-v2: adds two flag to track the presence of some unrecorded files now requires changes to proceed.

After discussing this in a VC, we'll flip the logic to avoid double negatives

Mon, Oct 18, 12:00 PM
Alphare created D11685: rewrite: fix issue6599.
Mon, Oct 18, 11:12 AM
D11252: debugupgraderepo: add fix-metaencoding-flag pass for issue6528 now requires changes to proceed.
Mon, Oct 18, 8:05 AM
D11681: dirstate-v2: adds a flag to mark a file as modified is now accepted and ready to land.
Mon, Oct 18, 7:59 AM
Alphare accepted D11671: path: add a new argument to control path validation.
Mon, Oct 18, 7:49 AM
D11679: rhg: internally, return a structured representation from hg cat is now accepted and ready to land.
Mon, Oct 18, 7:40 AM
Alphare added a comment to D11667: copy: recommend `--at-rev .` if target was added in parent commit.

This looks good aside from the small comment I have.

Mon, Oct 18, 6:22 AM
Alphare added a comment to D11679: rhg: internally, return a structured representation from hg cat.

Oh also, (sorry I forgot to say anything) the commit message has a typo in "representation".

Mon, Oct 18, 6:15 AM
Alphare added inline comments to D11679: rhg: internally, return a structured representation from hg cat.
Mon, Oct 18, 6:12 AM
D11679: rhg: internally, return a structured representation from hg cat now requires changes to proceed.

This does not apply on top of default sorry, please send a rebase.

Mon, Oct 18, 6:10 AM
D11679: rhg: internally, return a structured representation from hg cat is now accepted and ready to land.

Sounds good to me!

Mon, Oct 18, 6:08 AM
D11677: bookmarks: add a `ignore` variant of the bookmark mode is now accepted and ready to land.
Mon, Oct 18, 6:06 AM
D11676: bookmarks: add support for `mirror` mode to `incoming` is now accepted and ready to land.
Mon, Oct 18, 6:05 AM