- User Since
- Apr 18 2019, 7:59 AM (34 w, 1 d)
This entire series is a graft of existing changesets onto stable, to fix the current CI for the Rust module policy.
@martinvonz This should be ok.
Abandoned in favor of D7609
@martinvonz I was scratching my head trying to find this changeset to update/rebase it, here's hg obslog -r 5a1ff3d75f35 --hidden:
Wed, Dec 11
Yes, I meant exactmatcher indeed.
FileMatcher is meant for the Rust side of things, I do not intend to rename it in Python because it is a minor change that would make a lot of noise for bikeshedding. Do you think that would be a good idea?
Tue, Dec 10
Mon, Dec 9
While I am not a huge fan of the use of a nightly toolchain, I like the fact that we get the latest features and behavior as rustfmt is still pre-1.0 and subject to change. So far, it has been nice to us and has not broken anything I can recall, I vote for keeping it that way until it reaches 1.0.
Tue, Dec 3
Mon, Dec 2
Fri, Nov 29
Wed, Nov 27
Okay, then using non-debug assert!() seems more appropriate. If we prefer
being stricter, "checked" HgPath type can be introduced.
Actually I tried to suppress these warnings by propagating Result upwards,
and I got a feeling that we're doing wrong.
I generally prefer adding safety checks at ABI boundary. If malicious input
makes Rust code crash or exhaust CPU/memory resource, I would add sanity
check to rust-cpython layer.
Mon, Nov 25
Fri, Nov 22
Tue, Nov 19
Oh, you mean the Rust version doesn't do the same rejection?
Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted.
Mon, Nov 18
Fri, Nov 15
It appears PyCharm is confused by this change, which is weird, because it's supposed to support attrs. I would have to file a bug.