Page MenuHomePhabricator

Alphare (Raphaël Gomès)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2019, 7:59 AM (84 w, 6 d)

Recent Activity

Tue, Dec 1

Alphare updated the diff for D9408: hg-core: add basic config module.
Tue, Dec 1, 8:55 AM
Alphare updated the diff for D9409: hg-core: add format-bytes dependency.
Tue, Dec 1, 8:55 AM

Mon, Nov 30

Alphare committed rHGfada33872b5b: rhg: use `format_bytes!` for error messages.
rhg: use `format_bytes!` for error messages
Mon, Nov 30, 4:14 PM
Alphare closed D9407: rhg: use `format_bytes!` for error messages.
Mon, Nov 30, 12:24 PM
Alphare committed rHGcb774609dced: rhg: use `format_bytes!` for error messages.
rhg: use `format_bytes!` for error messages
Mon, Nov 30, 12:24 PM
Alphare added a comment to D9407: rhg: use `format_bytes!` for error messages.

@pulkit rebased

Mon, Nov 30, 11:03 AM
Alphare updated the diff for D9408: hg-core: add basic config module.
Mon, Nov 30, 11:01 AM
Alphare updated the diff for D9407: rhg: use `format_bytes!` for error messages.
Mon, Nov 30, 11:01 AM
Alphare updated the diff for D9409: hg-core: add format-bytes dependency.
Mon, Nov 30, 11:01 AM

Fri, Nov 27

Alphare created D9426: copies-rust: hide most of the comparison details inside a closure.
Fri, Nov 27, 11:12 AM
Alphare created D9425: copies-rust: move the mapping merging into a else clause.
Fri, Nov 27, 11:12 AM
Alphare created D9422: copies: iterate over children directly (instead of parents).
Fri, Nov 27, 11:12 AM
Alphare created D9424: copies-rust: extract conflicting value comparison in its own function.
Fri, Nov 27, 11:12 AM
Alphare created D9423: copies: no longer cache the ChangedFiles during copy tracing.
Fri, Nov 27, 11:12 AM
Alphare created D9421: copies-rust: extract the processing of a ChangedFiles in its own function.
Fri, Nov 27, 11:12 AM
Alphare created D9420: copies-rust: move the parent token to an enum.
Fri, Nov 27, 11:12 AM
Alphare created D9419: copies: properly copies parent dictionary before updating it.
Fri, Nov 27, 11:12 AM
Alphare created D9418: copies: clarify the return of _merge_copies_dict.
Fri, Nov 27, 11:12 AM
Alphare created D9417: copies: simplify the call to _merge_copies_dict.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9307: copies-rust: parse the changed-file sidedata directly in rust.
Fri, Nov 27, 11:11 AM
Alphare created D9416: copies: avoid unwanted side effect from one branch to another.
Fri, Nov 27, 11:11 AM
Alphare created D9415: copies: fast path no-op merge.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9306: copies-rust: encapsulate internal sets on `changes`.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9305: copies-rust: pre-indent some code to clarify the next patch.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9303: copies-rust: move is_ancestor caching within the rust code.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9304: copies-rust: combine the iteration over remove and copies into one.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9302: copies-rust: leverage the immutability for efficient update.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9301: copies-rust: pre-indent some code to clarify the next changeset.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9300: copies-rust: use immutable "OrdMap" to store copies information.
Fri, Nov 27, 11:11 AM
Alphare updated the diff for D9299: copies: use the rust code for `combine_changeset_copies`.
Fri, Nov 27, 11:10 AM
Alphare added inline comments to D9408: hg-core: add basic config module.
Fri, Nov 27, 4:34 AM
Alphare updated the diff for D9408: hg-core: add basic config module.
Fri, Nov 27, 4:34 AM
Alphare updated the diff for D9408: hg-core: add basic config module.
Fri, Nov 27, 4:32 AM

Thu, Nov 26

Alphare added inline comments to D9408: hg-core: add basic config module.
Thu, Nov 26, 11:09 AM
Alphare added a comment to D9407: rhg: use `format_bytes!` for error messages.

Dropped

Thu, Nov 26, 10:12 AM
Alphare updated the diff for D9408: hg-core: add basic config module.
Thu, Nov 26, 10:12 AM
Alphare added inline comments to D9408: hg-core: add basic config module.
Thu, Nov 26, 10:12 AM
Alphare updated the diff for D9407: rhg: use `format_bytes!` for error messages.
Thu, Nov 26, 10:12 AM
Alphare created D9409: hg-core: add format-bytes dependency.
Thu, Nov 26, 10:12 AM
Alphare added a comment to D9407: rhg: use `format_bytes!` for error messages.

Look much neater. If you can fix the unrelated change that would be great.

Thu, Nov 26, 8:45 AM
Alphare added a comment to D9408: hg-core: add basic config module.

I am not sure if had a look at https://phab.mercurial-scm.org/D7575 or not.

Thu, Nov 26, 8:20 AM
Alphare created D9408: hg-core: add basic config module.
Thu, Nov 26, 5:48 AM
Alphare created D9407: rhg: use `format_bytes!` for error messages.
Thu, Nov 26, 5:48 AM

Tue, Nov 24

Alphare accepted D9374: bisect: add a `--rev` flag.
Tue, Nov 24, 6:17 AM
Alphare accepted D9373: bisect: add `-G` to an `hg log` command in a test.
Tue, Nov 24, 6:03 AM
Alphare accepted D9372: bisect: refactor to work on a list of revspecs.
Tue, Nov 24, 6:03 AM
Alphare accepted D9371: bisect: use tuple literal instead of split on string literal.
Tue, Nov 24, 5:59 AM
Alphare accepted D9382: errors: drop trailing "!" for some errors about bookmarks.
Tue, Nov 24, 5:59 AM
Alphare accepted D9381: errors: remove trailing "!" in messages about bad top-level args.
Tue, Nov 24, 5:58 AM
Alphare accepted D9380: errors: remove trailing "!" in messages about creating new heads on push.
Tue, Nov 24, 5:57 AM
Alphare accepted D9379: errors: consistently don't use trailing "!" in "not found in manifest" message.
Tue, Nov 24, 5:57 AM
Alphare accepted D9378: errors: remove trailing "!" from some error messages for consistency.
Tue, Nov 24, 5:56 AM
Alphare accepted D9370: hgignore: add VS Code config.
Tue, Nov 24, 5:43 AM

Mon, Nov 23

Alphare accepted D9369: share: show warning if share is outdated while source supports share-safe.
Mon, Nov 23, 11:30 AM
Alphare added a comment to D9360: commands: fix checking of share safe requirement on `config --shared`.

Ouch!

Mon, Nov 23, 11:18 AM
Alphare accepted D9359: dispatch: pass root path in ui.readconfig() as root of main repo.
Mon, Nov 23, 11:16 AM
Alphare added inline comments to D9358: upgrade: add support to downgrade share safe mode.
Mon, Nov 23, 11:10 AM
Alphare accepted D9357: scmutil: try-delete `.hg/store/requires` if store requirements are empty.
Mon, Nov 23, 11:06 AM
Alphare added a comment to D9367: helptext: byteify extensions examples.

This is nice for extensions writers indeed. Although I hope one day we might roll back to using strings for command names and help texts, this is fine for the near future.

Mon, Nov 23, 10:58 AM
Alphare accepted D9366: helptext: fix sentence in extensions documentation.
Mon, Nov 23, 10:48 AM
Alphare accepted D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building.
Mon, Nov 23, 10:41 AM
Alphare added a comment to D9356: phabricator: allow local revisions to be specified with `phabupdate`.

This seems like the right choice to me, confusing the local and remote revisions would be bad.

Mon, Nov 23, 10:33 AM

Fri, Nov 20

Alphare accepted D9342: pyoxidizer: run buildifier.
Fri, Nov 20, 4:54 AM

Wed, Nov 18

Alphare closed D9320: rust-status: don't bubble up os errors, translate them to bad matches.
Wed, Nov 18, 6:07 PM
Alphare committed rHG5c736ba5dc27: rust-status: don't bubble up os errors, translate them to bad matches.
rust-status: don't bubble up os errors, translate them to bad matches
Wed, Nov 18, 6:06 PM
Alphare committed rHGc9c3c277e5a5: rust-status: properly translate OSError to Python.
rust-status: properly translate OSError to Python
Wed, Nov 18, 6:06 PM
Alphare closed D9319: rust-status: properly translate OSError to Python.
Wed, Nov 18, 6:06 PM

Mon, Nov 16

Alphare created D9320: rust-status: don't bubble up os errors, translate them to bad matches.
Mon, Nov 16, 11:03 AM
Alphare created D9319: rust-status: properly translate OSError to Python.
Mon, Nov 16, 11:02 AM
Alphare added a comment to D9294: packaging: enable rust extensions on centos.

Rust on CentOS 7 is 1.47.0, if I'm not mistaken.

Cool

Mon, Nov 16, 6:44 AM
Alphare accepted D9307: copies-rust: parse the changed-file sidedata directly in rust.
Mon, Nov 16, 6:39 AM
Alphare accepted D9306: copies-rust: encapsulate internal sets on `changes`.
Mon, Nov 16, 6:21 AM
Alphare accepted D9304: copies-rust: combine the iteration over remove and copies into one.
Mon, Nov 16, 6:19 AM
Alphare accepted D9298: copies: introduce the hg-cpython wrapper for `combine_changeset_copies`.
Mon, Nov 16, 6:12 AM
Alphare accepted D9297: copies: introduce a basic Rust function for `combine_changeset_copies`.
Mon, Nov 16, 6:10 AM

Fri, Nov 13

D9307: copies-rust: parse the changed-file sidedata directly in rust now requires changes to proceed.

A couple of missing assert!, but otherwise looks good.

Fri, Nov 13, 8:17 AM
Alphare accepted D9306: copies-rust: encapsulate internal sets on `changes`.
Fri, Nov 13, 7:58 AM
Alphare accepted D9305: copies-rust: pre-indent some code to clarify the next patch.
Fri, Nov 13, 7:56 AM
Alphare added a comment to D9304: copies-rust: combine the iteration over remove and copies into one.

You accidentally a verb at the end of the commit description, and there are a few typos here and there, but otherwise it looks good.

Fri, Nov 13, 7:54 AM
Alphare accepted D9303: copies-rust: move is_ancestor caching within the rust code.
Fri, Nov 13, 6:45 AM
Alphare added a comment to D9302: copies-rust: leverage the immutability for efficient update.

Please proof-read your commit message, there are missing words and additional punctuation.

Fri, Nov 13, 6:35 AM
Alphare accepted D9301: copies-rust: pre-indent some code to clarify the next changeset.
Fri, Nov 13, 6:27 AM
Alphare added a comment to D9300: copies-rust: use immutable "OrdMap" to store copies information.

This is the right niche for im-rc, nice library!

Fri, Nov 13, 6:26 AM
Alphare accepted D9299: copies: use the rust code for `combine_changeset_copies`.
Fri, Nov 13, 6:24 AM
D9298: copies: introduce the hg-cpython wrapper for `combine_changeset_copies` now requires changes to proceed.
Fri, Nov 13, 6:21 AM
Alphare added a comment to D9297: copies: introduce a basic Rust function for `combine_changeset_copies`.

Mostly nits, but I'd like not to break clippy when we can help it.

Fri, Nov 13, 6:03 AM
Alphare added a comment to D9296: copies: cache the ancestor checking call when tracing copy.

Maybe use triple backticks in your commit message to force the tables to monospace? They are quite hard to read.

Fri, Nov 13, 5:30 AM
Alphare added a comment to D9294: packaging: enable rust extensions on centos.

I'm glad to see this patch!

Fri, Nov 13, 5:22 AM
Alphare accepted D9318: errors: catch urllib errors specifically instead of using safehasattr().
Fri, Nov 13, 5:07 AM
Alphare accepted D9308: errors: raise InputError in fancyopts.
Fri, Nov 13, 5:03 AM
Alphare accepted D9279: pure: guard against empty blocks.
Fri, Nov 13, 5:00 AM
Alphare accepted D9280: revlog: pass sidedata argument to flagutil.processflagswrite().
Fri, Nov 13, 5:00 AM
D9281: cext: add .pyi files for C extensions now requires changes to proceed.

Thanks for this.

Fri, Nov 13, 4:59 AM

Thu, Nov 5

Alphare accepted D9266: relnotes: document new [command-templates] section.
Thu, Nov 5, 5:33 AM
Alphare accepted D9265: help: document the new [command-templates] config section.
Thu, Nov 5, 5:33 AM
Alphare accepted D9269: config: read system hgrc in lexicographical order.
Thu, Nov 5, 5:30 AM

Oct 30 2020

Alphare added a comment to D9264: rhg: strip copied files metadata from `cat` output.

Looks good!

Oct 30 2020, 5:08 AM

Oct 29 2020

Alphare added a comment to D9121: hg-core: fix path encoding usage.

Yes, sorry I forgot about this even though I talked about it with Antoine.

Oct 29 2020, 4:27 AM

Oct 19 2020

Alphare added a comment to D9228: pyoxidizer: update to PyOxidizer 0.9.

Thanks

Oct 19 2020, 4:08 AM

Oct 16 2020

Alphare added a comment to D9203: dirstate-tree: simplify the control flow in the Node.insert method.

We did this cleanup together, this is better than the original code. Thanks

Oct 16 2020, 4:48 AM