User Details
User Details
- User Since
- Mar 2 2019, 11:21 AM (90 w, 5 d)
Jul 31 2020
Jul 31 2020
Kwan committed rHGb1f2659c1c34: phabricator: unconditionally pop `test_vcr` to fix debugcallconduit.
phabricator: unconditionally pop `test_vcr` to fix debugcallconduit
Kwan committed rHGb4887d0680a4: phabricator: demonstrate debugcallconduit being broken without --test-vcr.
phabricator: demonstrate debugcallconduit being broken without --test-vcr
Jul 30 2020
Jul 30 2020
Nov 8 2019
Nov 8 2019
phabricator: use context manager form of progress in uploadchunks
Nov 4 2019
Nov 4 2019
contrib: require Python 3.7 for byteify-strings.py
Kwan committed rHG90fba2248693: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception.
fsmonitor: use stringutil.forcebytestr() instead of str() on an exception
Kwan added a comment to D7219: hghave: decode black's version before passing to StrictVersion.
Drop in favour of D7221.
Kwan added a comment to D7061: convert: don't pass bytes to, or expect bytes from, emailparser.
Obsoleted by a better fix in cf3bf3b03445.
py3: use %d to format an int
Nov 2 2019
Nov 2 2019
Nov 1 2019
Nov 1 2019
Kwan added a comment to D7134: phabricator: use context manager form of progress in uploadchunks.
Rebase onto stable
Oct 31 2019
Oct 31 2019
Kwan committed rHG6bff75fd19fe: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
setup: allow py3 install without env vars
setup: allow py3 install without env vars
Kwan committed rHG132ddd1cba85: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
Oct 30 2019
Oct 30 2019
Kwan committed rHGe57bf37eaeb5: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
setup: allow py3 install without env vars
Oct 24 2019
Oct 24 2019
Kwan updated the summary of D7153: py3: use %d instead of %s when formatting an int into a bytestring.
py3: use %d instead of %s when formatting an int into a bytestring
Kwan updated the summary of D7153: py3: use %d instead of %s when formatting an int into a bytestring.
Oct 23 2019
Oct 23 2019
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.
I'm not that bothered about this so going to abandon it for now, can always revisit it later.
Oct 18 2019
Oct 18 2019
py3: don't index into bytes in phabricator's _tokenize()
py3: don't index into bytes in phabricator's _tokenize()
Oct 17 2019
Oct 17 2019
Oct 16 2019
Oct 16 2019
Kwan committed rHG8c0fe77f47c5: convert: convert os.devnull to bytes before trying to join it with other bytes.
convert: convert os.devnull to bytes before trying to join it with other bytes
phabricator: update hgmatcher to cope with the new data format
Kwan committed rHG06a33a501aa2: phabricator: treat non-utf-8 text files as binary as phabricator requires.
phabricator: treat non-utf-8 text files as binary as phabricator requires
phabricator: switch to the creatediff endpoint
phabricator: remove tests and all recordings
phabricator: change conduit data format to match arcanist
phabricator: add addadded function
Kwan committed rHG162b81e65e60: phabricator: convert phabhunk and phabchange keys to bytes when finalising.
phabricator: convert phabhunk and phabchange keys to bytes when finalising
Kwan committed rHG6ef48274e803: convert: convert os.devnull to bytes before trying to join it with other bytes.
convert: convert os.devnull to bytes before trying to join it with other bytes
phabricator: update hgmatcher to cope with the new data format
Kwan committed rHGa852a1ef8c8a: phabricator: treat non-utf-8 text files as binary as phabricator requires.
phabricator: treat non-utf-8 text files as binary as phabricator requires
phabricator: switch to the creatediff endpoint
phabricator: change conduit data format to match arcanist
phabricator: remove tests and all recordings
Kwan committed rHG7dca674a456b: phabricator: convert phabhunk and phabchange keys to bytes when finalising.
phabricator: convert phabhunk and phabchange keys to bytes when finalising
phabricator: add addadded function
Oct 12 2019
Oct 12 2019
Kwan added inline comments to D7061: convert: don't pass bytes to, or expect bytes from, emailparser.
Kwan added inline comments to D7055: phabricator: update hgmatcher to cope with the new data format.
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.
I'd missed out the attrs key conversion needed on py3.
Kwan added a comment to D7055: phabricator: update hgmatcher to cope with the new data format.
I'd missed out the attrs key conversion needed on py3.
Kwan added a comment to D7054: phabricator: treat non-utf-8 text files as binary as phabricator requires.
I'd missed out the attrs key conversion needed on py3.
Kwan added a comment to D7053: phabricator: switch to the creatediff endpoint.
I'd missed out the attrs key conversion needed on py3.
Kwan added a comment to D7052: phabricator: change conduit data format to match arcanist.
I'd missed out the attrs key conversion needed on py3.
I'd missed out the attrs key conversion needed on py3.
Oct 11 2019
Oct 11 2019
py3: fix test-bad-extension expectations for py35
phabricator: add addremoved and addmodified functions
phabricator: add makebinary and addoldbinary functions
phabricator: add the uploadfile function
phabricator: add the uploadchunks function
phabricator: add the maketext function
phabricator: add the phabchange data structure
phabricator: add the phabdiff data structure
phabricator: add the phabhunk data structure
phabricator: add the DiffChangeType and DiffFileType constants
Kwan added a comment to D7063: py3: fix test-bad-extension expectations for py35.
Tested in a xenial VM with 3.5.2 and this does make the test pass.
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.
Fix some test-check-code issues, and one test-check-pyflakes unused local.
Kwan added a comment to D7055: phabricator: update hgmatcher to cope with the new data format.
Fix some test-check-code issues, and one test-check-pyflakes unused local.
Kwan added a comment to D7054: phabricator: treat non-utf-8 text files as binary as phabricator requires.
Fix some test-check-code issues, and one test-check-pyflakes unused local.
Kwan added a comment to D7053: phabricator: switch to the creatediff endpoint.
Fix some test-check-code issues, and one test-check-pyflakes unused local.
Kwan added a comment to D7052: phabricator: change conduit data format to match arcanist.
Fix some test-check-code issues, and one test-check-pyflakes unused local.