Page MenuHomePhabricator
People Kwan

Kwan (Ian Moody)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2019, 11:21 AM (167 w, 6 d)

Recent Activity
View All

Wed, May 11

Kwan added inline comments to D12619: auto-upgrade: skip the operation if the repository cannot be locked.
Wed, May 11, 9:53 AM

Dec 11 2020

Kwan added a comment to D9565: debugdiscovery: display the number of roundtrip used.
In D9565#144082, @marmoute wrote:

Test are fine.
This says it was updated, but phabricator did not update it.
https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/132899

Dec 11 2020, 8:38 AM

Nov 30 2020

Kwan updated subscribers of D9444: rust: fix non-utf8 char in requirements.rs.
In D9444#142315, @SimonSapin wrote:

My editor is configured as UTF-8 and the typographical apostrophe on my keyboard layout is U+2019 which is [0xE7, 0xA8, 0x9A] in UTF-8. On https://phab.mercurial-scm.org/D9398?vs=23670&id=23692#toc the History tab of Phabricator shows two diffs. I don’t know why, I did not edit this patch after first submitting it.

This is usual and expected, the second diff is the landed version. All DREVs get closed by daemon and get a new diff reflecting the landed commit when the commit gets picked up by Diffusion.

The first diff correctly shows the apostrophe. The difference between these two diffs shows that the apostrophe and the following lower case letter t have been replaced with CJK ideogram 稚, U+7A1A, [0xE7 0xA8 0x9A] in UTF-8.
My local repository does not have a commit f3a001cfe4b8. It has a2eda1ff22aa, where the apostrophe was replaced with a single 0x92 byte (and the letter t following it is there).

0x92 is the RIGHT SINGLE QUOTATION MARK in Windows-1252, which is what the requirements.rs file gets detected as prior to this commit. I don't know how phab mangles that into the ideogram, but locally the quotation mark is there, just not a UTF-8 one.

Nov 30 2020, 5:29 PM

Jul 31 2020

Kwan closed D8852: phabricator: unconditionally pop `test_vcr` from kwargs to fix debugcallconduit.
Jul 31 2020, 9:15 AM
Kwan closed D8851: phabricator: demonstrate debugcallconduit being broken without --test-vcr.
Jul 31 2020, 9:14 AM
Kwan committed rHGb1f2659c1c34: phabricator: unconditionally pop `test_vcr` to fix debugcallconduit.
phabricator: unconditionally pop `test_vcr` to fix debugcallconduit
Jul 31 2020, 9:14 AM
Kwan committed rHGb4887d0680a4: phabricator: demonstrate debugcallconduit being broken without --test-vcr.
phabricator: demonstrate debugcallconduit being broken without --test-vcr
Jul 31 2020, 9:14 AM

Jul 30 2020

Kwan created D8852: phabricator: unconditionally pop `test_vcr` from kwargs to fix debugcallconduit.
Jul 30 2020, 12:04 PM
Kwan created D8851: phabricator: demonstrate debugcallconduit being broken without --test-vcr.
Jul 30 2020, 12:03 PM

Nov 8 2019

Kwan closed D7134: phabricator: use context manager form of progress in uploadchunks.
Nov 8 2019, 1:26 PM
Kwan committed rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks.
phabricator: use context manager form of progress in uploadchunks
Nov 8 2019, 1:25 PM

Nov 4 2019

Kwan closed D7220: contrib: require Python 3.7 for byteify-strings.py.
Nov 4 2019, 5:08 PM
Kwan committed rHG09234eeae206: contrib: require Python 3.7 for byteify-strings.py.
contrib: require Python 3.7 for byteify-strings.py
Nov 4 2019, 5:08 PM
Kwan closed D7218: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception.
Nov 4 2019, 4:53 PM
Kwan committed rHG90fba2248693: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception.
fsmonitor: use stringutil.forcebytestr() instead of str() on an exception
Nov 4 2019, 4:53 PM
Kwan added a comment to D7219: hghave: decode black's version before passing to StrictVersion.

Drop in favour of D7221.

Nov 4 2019, 4:35 PM
Kwan added a comment to D7061: convert: don't pass bytes to, or expect bytes from, emailparser.

Obsoleted by a better fix in cf3bf3b03445.

Nov 4 2019, 2:28 PM
Kwan created D7220: contrib: require Python 3.7 for byteify-strings.py.
Nov 4 2019, 2:21 PM
Kwan created D7219: hghave: decode black's version before passing to StrictVersion.
Nov 4 2019, 2:12 PM
Kwan created D7218: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception.
Nov 4 2019, 2:06 PM
Kwan closed D7215: py3: use %d to format an int.
Nov 4 2019, 11:28 AM
Kwan committed rHG742065def6ca: py3: use %d to format an int.
py3: use %d to format an int
Nov 4 2019, 11:28 AM

Nov 2 2019

Kwan created D7215: py3: use %d to format an int.
Nov 2 2019, 6:22 PM

Nov 1 2019

Kwan added a comment to D7134: phabricator: use context manager form of progress in uploadchunks.

Rebase onto stable

Nov 1 2019, 8:57 PM

Oct 31 2019

Kwan committed rHG6bff75fd19fe: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
Oct 31 2019, 10:20 PM
Kwan committed rHGe7772b6b0a33: setup: allow py3 install without env vars.
setup: allow py3 install without env vars
Oct 31 2019, 10:20 PM
Kwan committed rHGc3e10f705a6c: setup: allow py3 install without env vars.
setup: allow py3 install without env vars
Oct 31 2019, 9:14 AM
Kwan committed rHG132ddd1cba85: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
Oct 31 2019, 9:14 AM

Oct 30 2019

Kwan closed D7151: setup: allow py3 install without env vars.
Oct 30 2019, 4:49 PM
Kwan closed D7152: phabricator: use True primitive instead of b'true' for phabupdate actions.
Oct 30 2019, 4:49 PM
Kwan committed rHGe57bf37eaeb5: phabricator: use True primitive instead of b'true' for phabupdate actions.
phabricator: use True primitive instead of b'true' for phabupdate actions
Oct 30 2019, 4:49 PM
Kwan committed rHG3733533c22a4: setup: allow py3 install without env vars.
setup: allow py3 install without env vars
Oct 30 2019, 4:49 PM

Oct 24 2019

Kwan updated the summary of D7153: py3: use %d instead of %s when formatting an int into a bytestring.
Oct 24 2019, 12:45 PM
Kwan closed D7153: py3: use %d instead of %s when formatting an int into a bytestring.
Oct 24 2019, 12:32 PM
Kwan committed rHGa2ff3aff81d2: py3: use %d instead of %s when formatting an int into a bytestring.
py3: use %d instead of %s when formatting an int into a bytestring
Oct 24 2019, 12:32 PM
Kwan updated the summary of D7153: py3: use %d instead of %s when formatting an int into a bytestring.
Oct 24 2019, 5:57 AM

Oct 23 2019

Kwan created D7153: py3: use %d instead of %s when formatting an int into a bytestring.
Oct 23 2019, 6:10 PM
Kwan created D7152: phabricator: use True primitive instead of b'true' for phabupdate actions.
Oct 23 2019, 5:31 PM
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.

I'm not that bothered about this so going to abandon it for now, can always revisit it later.

Oct 23 2019, 5:20 PM
Kwan created D7151: setup: allow py3 install without env vars.
Oct 23 2019, 10:11 AM

Oct 18 2019

Kwan committed rHG47946f08e463: py3: don't index into bytes in phabricator's _tokenize().
py3: don't index into bytes in phabricator's _tokenize()
Oct 18 2019, 12:45 PM
Kwan closed D7129: py3: don't index into bytes in phabricator's _tokenize().
Oct 18 2019, 7:08 AM
Kwan committed rHGb3a1ba3f46f1: py3: don't index into bytes in phabricator's _tokenize().
py3: don't index into bytes in phabricator's _tokenize()
Oct 18 2019, 7:08 AM
Kwan created D7134: phabricator: use context manager form of progress in uploadchunks.
Oct 18 2019, 2:21 AM

Oct 17 2019

Kwan created D7129: py3: don't index into bytes in phabricator's _tokenize().
Oct 17 2019, 7:31 PM

Oct 16 2019

Kwan committed rHG8c0fe77f47c5: convert: convert os.devnull to bytes before trying to join it with other bytes.
convert: convert os.devnull to bytes before trying to join it with other bytes
Oct 16 2019, 10:38 PM
Kwan committed rHGa4da1c3b82ab: phabricator: update hgmatcher to cope with the new data format.
phabricator: update hgmatcher to cope with the new data format
Oct 16 2019, 10:38 PM
Kwan committed rHG06a33a501aa2: phabricator: treat non-utf-8 text files as binary as phabricator requires.
phabricator: treat non-utf-8 text files as binary as phabricator requires
Oct 16 2019, 10:38 PM
Kwan committed rHGaf067d29b19e: phabricator: switch to the creatediff endpoint.
phabricator: switch to the creatediff endpoint
Oct 16 2019, 10:38 PM
Kwan committed rHGec4dfcc39638: phabricator: remove tests and all recordings.
phabricator: remove tests and all recordings
Oct 16 2019, 10:38 PM
Kwan committed rHGf5aa4a53acd1: phabricator: change conduit data format to match arcanist.
phabricator: change conduit data format to match arcanist
Oct 16 2019, 10:38 PM
Kwan committed rHGd5d1edf66091: phabricator: add addadded function.
phabricator: add addadded function
Oct 16 2019, 10:38 PM
Kwan committed rHG162b81e65e60: phabricator: convert phabhunk and phabchange keys to bytes when finalising.
phabricator: convert phabhunk and phabchange keys to bytes when finalising
Oct 16 2019, 10:38 PM
Kwan committed rHG6ef48274e803: convert: convert os.devnull to bytes before trying to join it with other bytes.
convert: convert os.devnull to bytes before trying to join it with other bytes
Oct 16 2019, 9:52 PM
Kwan closed D7062: convert: convert os.devnull to bytes before trying to join it with other bytes.
Oct 16 2019, 9:52 PM
Kwan closed D7055: phabricator: update hgmatcher to cope with the new data format.
Oct 16 2019, 4:51 PM
Kwan closed D7054: phabricator: treat non-utf-8 text files as binary as phabricator requires.
Oct 16 2019, 4:51 PM
Kwan committed rHGa124b79a3a7e: phabricator: update hgmatcher to cope with the new data format.
phabricator: update hgmatcher to cope with the new data format
Oct 16 2019, 4:51 PM
Kwan committed rHGa852a1ef8c8a: phabricator: treat non-utf-8 text files as binary as phabricator requires.
phabricator: treat non-utf-8 text files as binary as phabricator requires
Oct 16 2019, 4:51 PM
Kwan closed D7053: phabricator: switch to the creatediff endpoint.
Oct 16 2019, 4:51 PM
Kwan closed D7052: phabricator: change conduit data format to match arcanist.
Oct 16 2019, 4:51 PM
Kwan committed rHGd5fabfe54ec6: phabricator: switch to the creatediff endpoint.
phabricator: switch to the creatediff endpoint
Oct 16 2019, 4:51 PM
Kwan closed D7051: phabricator: remove tests and all recordings.
Oct 16 2019, 4:51 PM
Kwan committed rHGfaf084d63c72: phabricator: change conduit data format to match arcanist.
phabricator: change conduit data format to match arcanist
Oct 16 2019, 4:51 PM
Kwan closed D7066: phabricator: convert phabhunk and phabchange keys to bytes when finalising.
Oct 16 2019, 4:51 PM
Kwan committed rHGee317af408d6: phabricator: remove tests and all recordings.
phabricator: remove tests and all recordings
Oct 16 2019, 4:51 PM
Kwan closed D7050: phabricator: add addadded function.
Oct 16 2019, 4:51 PM
Kwan committed rHG7dca674a456b: phabricator: convert phabhunk and phabchange keys to bytes when finalising.
phabricator: convert phabhunk and phabchange keys to bytes when finalising
Oct 16 2019, 4:51 PM
Kwan committed rHG1bc599b69354: phabricator: add addadded function.
phabricator: add addadded function
Oct 16 2019, 4:51 PM

Oct 12 2019

Kwan added inline comments to D7061: convert: don't pass bytes to, or expect bytes from, emailparser.
Oct 12 2019, 10:36 AM
Kwan added inline comments to D7055: phabricator: update hgmatcher to cope with the new data format.
Oct 12 2019, 10:02 AM
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:46 AM
Kwan added a comment to D7055: phabricator: update hgmatcher to cope with the new data format.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:46 AM
Kwan added a comment to D7054: phabricator: treat non-utf-8 text files as binary as phabricator requires.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:46 AM
Kwan added a comment to D7053: phabricator: switch to the creatediff endpoint.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:45 AM
Kwan added a comment to D7052: phabricator: change conduit data format to match arcanist.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:45 AM
Kwan created D7066: phabricator: convert phabhunk and phabchange keys to bytes when finalising.

I'd missed out the attrs key conversion needed on py3.

Oct 12 2019, 9:45 AM

Oct 11 2019

Kwan closed D7063: py3: fix test-bad-extension expectations for py35.
Oct 11 2019, 9:59 PM
Kwan committed rHG5ed1abd0ea26: py3: fix test-bad-extension expectations for py35.
py3: fix test-bad-extension expectations for py35
Oct 11 2019, 9:59 PM
Kwan closed D7049: phabricator: add addremoved and addmodified functions.
Oct 11 2019, 9:57 PM
Kwan closed D7048: phabricator: add makebinary and addoldbinary functions.
Oct 11 2019, 9:57 PM
Kwan closed D7047: phabricator: add the uploadfile function.
Oct 11 2019, 9:57 PM
Kwan committed rHGc19b327017b9: phabricator: add addremoved and addmodified functions.
phabricator: add addremoved and addmodified functions
Oct 11 2019, 9:57 PM
Kwan committed rHG9f802243a42e: phabricator: add makebinary and addoldbinary functions.
phabricator: add makebinary and addoldbinary functions
Oct 11 2019, 9:56 PM
Kwan committed rHG24e8aac7c630: phabricator: add the uploadfile function.
phabricator: add the uploadfile function
Oct 11 2019, 9:56 PM
Kwan closed D7046: phabricator: add the uploadchunks function.
Oct 11 2019, 9:56 PM
Kwan closed D7045: phabricator: add the maketext function.
Oct 11 2019, 9:56 PM
Kwan closed D7044: phabricator: add the phabdiff data structure.
Oct 11 2019, 9:56 PM
Kwan committed rHG453079605242: phabricator: add the uploadchunks function.
phabricator: add the uploadchunks function
Oct 11 2019, 9:56 PM
Kwan committed rHGf742fabad507: phabricator: add the maketext function.
phabricator: add the maketext function
Oct 11 2019, 9:56 PM
Kwan closed D7043: phabricator: add the phabchange data structure.
Oct 11 2019, 9:56 PM
Kwan closed D7042: phabricator: add the phabhunk data structure.
Oct 11 2019, 9:56 PM
Kwan committed rHG99ee4afd352f: phabricator: add the phabchange data structure.
phabricator: add the phabchange data structure
Oct 11 2019, 9:56 PM
Kwan committed rHG75e7628b488f: phabricator: add the phabdiff data structure.
phabricator: add the phabdiff data structure
Oct 11 2019, 9:56 PM
Kwan closed D7041: phabricator: add the DiffChangeType and DiffFileType constants.
Oct 11 2019, 9:56 PM
Kwan committed rHG73d4bc60e389: phabricator: add the phabhunk data structure.
phabricator: add the phabhunk data structure
Oct 11 2019, 9:56 PM
Kwan committed rHGa66e2844b0c6: phabricator: add the DiffChangeType and DiffFileType constants.
phabricator: add the DiffChangeType and DiffFileType constants
Oct 11 2019, 9:56 PM
Kwan added a comment to D7063: py3: fix test-bad-extension expectations for py35.

Tested in a xenial VM with 3.5.2 and this does make the test pass.

Oct 11 2019, 3:48 PM
Kwan added a comment to D7056: phabricator: include bookmark in diff metadata.

Fix some test-check-code issues, and one test-check-pyflakes unused local.

Oct 11 2019, 1:55 PM
Kwan added a comment to D7055: phabricator: update hgmatcher to cope with the new data format.

Fix some test-check-code issues, and one test-check-pyflakes unused local.

Oct 11 2019, 1:55 PM