Page MenuHomePhabricator

SimonSapin
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2020, 12:09 PM (9 w, 16 h)

Recent Activity

Today

SimonSapin added a comment to D9853: histedit: don't assign to _ for unused values.

I half-expected this to fail some linter, but I see tests/test-check-pylint.t only enables very few checks. Still, it might be good to call unused variables _unused with the _ prefix for intentionally unused?

Tue, Jan 26, 1:37 AM
SimonSapin added a comment to D9865: store: use `endswith` to detect revlog extension.

Today I learned about tuple argument for endswith. Looks good.

Tue, Jan 26, 1:16 AM

Yesterday

SimonSapin created D9863: rust: Make NodePrefix allocation-free and Copy, remove NodePrefixRef.
Mon, Jan 25, 4:14 PM
SimonSapin created D9864: rust: Remove hex parsing from the nodemap.
Mon, Jan 25, 4:14 PM
SimonSapin created D9862: rust: Exclude empty node prefixes.
Mon, Jan 25, 4:13 PM
SimonSapin created D9861: rust: Simplify error type for reading hex node IDs.
Mon, Jan 25, 4:13 PM
SimonSapin created D9860: rust: replace Node::encode_hex with std::fmt::LowerHex.
Mon, Jan 25, 4:12 PM
SimonSapin created D9859: rust: replace an unsafe use of transmute with a safe use of bytes-cast.
Mon, Jan 25, 5:34 AM

Fri, Jan 22

SimonSapin added inline comments to D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Fri, Jan 22, 11:48 AM
SimonSapin updated the diff for D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Fri, Jan 22, 11:43 AM
SimonSapin updated the diff for D9683: copies-rust: split up combine_changeset_copies function into a struct.
Fri, Jan 22, 11:43 AM
SimonSapin added inline comments to D9685: copies-rust: introduce PyBytesWithData to reduce GIL requirement.
Fri, Jan 22, 9:05 AM

Mon, Jan 18

SimonSapin updated the diff for D9788: rust: use the bytes-cast crate to parse persistent nodemaps.
Mon, Jan 18, 9:22 AM

Fri, Jan 15

SimonSapin created D9788: rust: use the bytes-cast crate to parse persistent nodemaps.
Fri, Jan 15, 10:12 AM

Wed, Jan 13

SimonSapin closed D9728: rhg: use a release-mode executable in tests.
Wed, Jan 13, 7:50 AM
SimonSapin committed rHGe73b40c790ec: rhg: use a release-mode executable in tests.
rhg: use a release-mode executable in tests
Wed, Jan 13, 7:50 AM
SimonSapin added a comment to D9728: rhg: use a release-mode executable in tests.

Yes, having debug assertions enabled when running tests would be valuable, but at the moment they’re already disabled in hg-cpython since setup.py always runs Cargo with --release.

Wed, Jan 13, 5:22 AM

Tue, Jan 12

SimonSapin created D9728: rhg: use a release-mode executable in tests.
Tue, Jan 12, 12:41 PM

Wed, Jan 6

SimonSapin created D9684: copies-rust: move CPU-heavy Rust processing into a child thread.
Wed, Jan 6, 9:13 AM
SimonSapin created D9686: copies-rust: send PyBytes values back be dropped ino the parent thread.
Wed, Jan 6, 9:12 AM
SimonSapin created D9685: copies-rust: introduce PyBytesWithData to reduce GIL requirement.
Wed, Jan 6, 9:12 AM
SimonSapin created D9683: copies-rust: split up combine_changeset_copies function into a struct.
Wed, Jan 6, 9:12 AM
SimonSapin created D9682: copies-rust: extract generic map merge logic from merge_copies_dict.
Wed, Jan 6, 9:12 AM

Mon, Dec 28

SimonSapin added a comment to D9656: copies-rust: use imrs::OrdSet instead of imrs::HashSet.

The speedup comes from OrdMap using reference counting internally, so clone() does not need to allocate. (Mutation after clone does copy-on-writes and allocate, but that’s evidently less frequent.) Background: https://docs.rs/im-rc/15.0.0/im_rc/#when-does-cloning-happen

Mon, Dec 28, 10:15 AM
SimonSapin accepted D9648: copies-rust: extract the processing of a single copy information.
Mon, Dec 28, 8:50 AM
SimonSapin added a comment to D9647: copies-rust: use matching to select the final copies information.

These first two match expressions could be calls to Option::map instead, but this is fine.

Mon, Dec 28, 8:49 AM
SimonSapin added a comment to D9657: copies-rust: fix reverted argument when merging tiny minor or major.

This makes the else if major.len() * 2 < minor.len() block the same as else if minor.len() * 2 < major.len() block above but with major and minor swapped, as it should be.

Mon, Dec 28, 8:38 AM

Dec 21 2020

SimonSapin closed D9596: rust: introduce Repo and Vfs types for filesystem abstraction.
Dec 21 2020, 1:36 PM
SimonSapin committed rHG8a4914397d02: rust: introduce Repo and Vfs types for filesystem abstraction.
rust: introduce Repo and Vfs types for filesystem abstraction
Dec 21 2020, 1:35 PM

Dec 19 2020

SimonSapin updated the diff for D9596: rust: introduce Repo and Vfs types for filesystem abstraction.
Dec 19 2020, 4:42 PM

Dec 17 2020

SimonSapin closed D9595: rust: replace most "operation" structs with functions.
Dec 17 2020, 6:58 AM
SimonSapin closed D9625: rust: document how to enable debug information in optimized builds.
Dec 17 2020, 6:57 AM
SimonSapin committed rHGec14c37958ec: rust: document how to enable debug information in optimized builds.
rust: document how to enable debug information in optimized builds
Dec 17 2020, 6:57 AM
SimonSapin closed D9594: rust: change &PathBuf parameters to &Path.
Dec 17 2020, 6:57 AM
SimonSapin committed rHGdca9cb99971c: rust: replace most "operation" structs with functions.
rust: replace most "operation" structs with functions
Dec 17 2020, 6:57 AM
SimonSapin committed rHGcc6faec62cb7: rust: change &PathBuf parameters to &Path.
rust: change &PathBuf parameters to &Path
Dec 17 2020, 6:56 AM
SimonSapin created D9625: rust: document how to enable debug information in optimized builds.
Dec 17 2020, 6:29 AM

Dec 14 2020

SimonSapin updated the diff for D9596: rust: introduce Repo and Vfs types for filesystem abstraction.
Dec 14 2020, 11:44 AM
SimonSapin updated the diff for D9595: rust: replace most "operation" structs with functions.
Dec 14 2020, 11:44 AM
SimonSapin created D9596: rust: introduce Repo and Vfs types for filesystem abstraction.
Dec 14 2020, 11:28 AM
SimonSapin created D9595: rust: replace most "operation" structs with functions.
Dec 14 2020, 11:28 AM
SimonSapin created D9594: rust: change &PathBuf parameters to &Path.
Dec 14 2020, 11:27 AM

Dec 10 2020

SimonSapin closed D9520: rhg: use persistent nodemap when available.
Dec 10 2020, 4:42 AM
Simon Sapin <simon-commits@exyr.org> committed rHG9eb07ab3f2d4: rhg: use persistent nodemap when available.
rhg: use persistent nodemap when available
Dec 10 2020, 4:41 AM
SimonSapin closed D9533: persistent-nodemap: properly ignore non-existent `.nd` data file.
Dec 10 2020, 4:41 AM
Simon Sapin <simon-commits@exyr.org> committed rHG8ff2d8359d0f: persistent-nodemap: properly ignore non-existent `.nd` data file.
persistent-nodemap: properly ignore non-existent `.nd` data file
Dec 10 2020, 4:41 AM

Dec 7 2020

SimonSapin updated the diff for D9520: rhg: use persistent nodemap when available.
Dec 7 2020, 12:53 PM
SimonSapin added inline comments to D9520: rhg: use persistent nodemap when available.
Dec 7 2020, 12:53 PM
SimonSapin created D9533: persistent-nodemap: properly ignore non-existent `.nd` data file.
Dec 7 2020, 12:53 PM

Dec 6 2020

SimonSapin closed D9521: rust: use crossbeam-channel crate directly.
Dec 6 2020, 7:16 AM
Simon Sapin <simon-commits@exyr.org> committed rHGfd47483f1645: rust: use crossbeam-channel crate directly.
rust: use crossbeam-channel crate directly
Dec 6 2020, 7:16 AM

Dec 5 2020

SimonSapin created D9521: rust: use crossbeam-channel crate directly.
Dec 5 2020, 3:58 AM

Dec 4 2020

SimonSapin closed D9490: rust: use NodePrefix::from_hex instead of hex::decode directly.
Dec 4 2020, 2:52 PM
SimonSapin closed D9479: rhg: allow specifying a changeset ID prefix.
Dec 4 2020, 2:52 PM
SimonSapin closed D9519: rhg: add a test with persistent-nodemap.
Dec 4 2020, 2:52 PM
Simon Sapin <simon-commits@exyr.org> committed rHG0c02c2a0badb: rhg: add a test with persistent-nodemap.
rhg: add a test with persistent-nodemap
Dec 4 2020, 2:51 PM
Simon Sapin <simon-commits@exyr.org> committed rHG88e741bf2d93: rust: use NodePrefix::from_hex instead of hex::decode directly.
rust: use NodePrefix::from_hex instead of hex::decode directly
Dec 4 2020, 2:51 PM
Simon Sapin <simon-commits@exyr.org> committed rHG8d6164098782: rhg: allow specifying a changeset ID prefix.
rhg: allow specifying a changeset ID prefix
Dec 4 2020, 2:51 PM
SimonSapin created D9520: rhg: use persistent nodemap when available.
Dec 4 2020, 12:28 PM
SimonSapin created D9519: rhg: add a test with persistent-nodemap.
Dec 4 2020, 12:28 PM

Dec 2 2020

SimonSapin added inline comments to D9493: copies-rust: tokenize all paths into integer.
Dec 2 2020, 1:46 PM
SimonSapin added inline comments to D9493: copies-rust: tokenize all paths into integer.
Dec 2 2020, 11:15 AM
SimonSapin added inline comments to D9479: rhg: allow specifying a changeset ID prefix.
Dec 2 2020, 9:25 AM
SimonSapin added inline comments to D9479: rhg: allow specifying a changeset ID prefix.
Dec 2 2020, 9:23 AM
SimonSapin created D9490: rust: use NodePrefix::from_hex instead of hex::decode directly.
Dec 2 2020, 9:23 AM
SimonSapin updated the diff for D9479: rhg: allow specifying a changeset ID prefix.
Dec 2 2020, 9:23 AM
SimonSapin updated the diff for D9478: rhg: add a test for --rev with a hex changeset ID.
Dec 2 2020, 9:22 AM
SimonSapin closed D9478: rhg: add a test for --rev with a hex changeset ID.
Dec 2 2020, 3:04 AM
Simon Sapin <simon-commits@exyr.org> committed rHG904647f7d983: rhg: add a test for --rev with a hex changeset ID.
rhg: add a test for --rev with a hex changeset ID
Dec 2 2020, 3:04 AM

Dec 1 2020

SimonSapin created D9478: rhg: add a test for --rev with a hex changeset ID.
Dec 1 2020, 1:27 PM
SimonSapin created D9479: rhg: allow specifying a changeset ID prefix.
Dec 1 2020, 1:27 PM
SimonSapin added a comment to D9307: copies-rust: parse the changed-file sidedata directly in rust.

Looks good to me!

Dec 1 2020, 4:10 AM

Nov 30 2020

SimonSapin added a comment to D9398: requirements: move loading to hg-core and add parsing.

@martinvonz yes. The patch I submitted had don’t. I’m not sure what happened next. See https://phab.mercurial-scm.org/D9444#142315

Nov 30 2020, 12:35 PM
SimonSapin added a comment to D9444: rust: fix non-utf8 char in requirements.rs.

I apologize, in my previous message I misunderstood what was going on.

Nov 30 2020, 10:01 AM

Nov 29 2020

SimonSapin closed D9372: bisect: refactor to work on a list of revspecs.
Nov 29 2020, 2:57 PM
SimonSapin closed D9373: bisect: add `-G` to an `hg log` command in a test.
Nov 29 2020, 2:56 PM
Simon Sapin <simon-commits@exyr.org> committed rHG744ea3c4f41b: bisect: add `-G` to an `hg log` command in a test.
bisect: add `-G` to an `hg log` command in a test
Nov 29 2020, 2:56 PM
Simon Sapin <simon-commits@exyr.org> committed rHGc3d0b3c29ec4: bisect: refactor to work on a list of revspecs.
bisect: refactor to work on a list of revspecs
Nov 29 2020, 2:56 PM

Nov 28 2020

SimonSapin added a comment to D9444: rust: fix non-utf8 char in requirements.rs.

I’m pretty sure that this U+2019 RIGHT SINGLE QUOTATION MARK character was correctly encoded in UTF-8. Calling it "non-UTF-8" is incorrect, although it is indeed non-ASCII. The regex [^0-9-a-zA-Z /(|).,{}!\[\]:"&=>?_*-;<\'#]` is testing for ASCII "printable" characters.

Nov 28 2020, 6:42 PM

Nov 27 2020

SimonSapin closed D9399: rhg: exit with relevant code for unsupported requirements.
Nov 27 2020, 6:34 AM
SimonSapin closed D9400: rhg: check that .hg/requires is ASCII.
Nov 27 2020, 6:34 AM
Simon Sapin <simon-commits@exyr.org> committed rHGf5d62f4d5327: rhg: check that .hg/requires is ASCII.
rhg: check that .hg/requires is ASCII
Nov 27 2020, 6:34 AM
Simon Sapin <simon-commits@exyr.org> committed rHG2ad2745e0be9: rhg: exit with relevant code for unsupported requirements.
rhg: exit with relevant code for unsupported requirements
Nov 27 2020, 6:34 AM

Nov 26 2020

SimonSapin closed D9398: requirements: move loading to hg-core and add parsing.
Nov 26 2020, 8:15 AM
SimonSapin closed D9397: rhg: add a `debugrequirements` subcommand.
Nov 26 2020, 8:15 AM
Simon Sapin <simon-commits@exyr.org> committed rHGa2eda1ff22aa: requirements: move loading to hg-core and add parsing.
requirements: move loading to hg-core and add parsing
Nov 26 2020, 8:15 AM
Simon Sapin <simon-commits@exyr.org> committed rHGead435aa5294: rhg: add a `debugrequirements` subcommand.
rhg: add a `debugrequirements` subcommand
Nov 26 2020, 8:14 AM
SimonSapin added a comment to D9397: rhg: add a `debugrequirements` subcommand.

“For now” was intended as: until the next commit in the series which parses into a list of feature names. But with share-safe, did you mean that .hg/store/requires should also be read? Indeed that is not part of this series.

Nov 26 2020, 5:01 AM

Nov 25 2020

SimonSapin updated SimonSapin.
Nov 25 2020, 8:58 AM
SimonSapin added inline comments to D9297: copies: introduce a basic Rust function for `combine_changeset_copies`.
Nov 25 2020, 8:55 AM
SimonSapin created D9399: rhg: exit with relevant code for unsupported requirements.
Nov 25 2020, 7:42 AM
SimonSapin created D9398: requirements: move loading to hg-core and add parsing.
Nov 25 2020, 7:42 AM
SimonSapin created D9397: rhg: add a `debugrequirements` subcommand.
Nov 25 2020, 7:42 AM
SimonSapin created D9400: rhg: check that .hg/requires is ASCII.
Nov 25 2020, 7:42 AM
SimonSapin added a comment to D9396: packaging: drop Disco (19.04) and add Focal (20.04).

I’ve run into this issue of tzdata prompting for user input in automation before, and worked around it by setting the DEBIAN_FRONTEND=noninteractive environment variable based on https://stackoverflow.com/questions/44331836/apt-get-install-tzdata-noninteractive. This might also help if an other system package starts prompting.

Nov 25 2020, 4:46 AM
SimonSapin closed D9371: bisect: use tuple literal instead of split on string literal.
Nov 25 2020, 12:45 AM
SimonSapin committed rHGe131dbf6ee15: bisect: use tuple literal instead of split on string literal.
bisect: use tuple literal instead of split on string literal
Nov 25 2020, 12:44 AM
SimonSapin closed D9370: hgignore: add VS Code config.
Nov 25 2020, 12:44 AM
SimonSapin committed rHGe63daff6e8ed: hgignore: add VS Code config.
hgignore: add VS Code config
Nov 25 2020, 12:44 AM

Nov 23 2020

SimonSapin created D9374: bisect: add a `--rev` flag.
Nov 23 2020, 12:19 PM