This will likely still need minor changes to make a test pass: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/340039
This produces output that looks correct when rendered by a terminal, but escape sequences are not exactly where the test expects them.

This will likely still need minor changes to make a test pass: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/340039
This produces output that looks correct when rendered by a terminal, but escape sequences are not exactly where the test expects them.

Ideally we’d have a way to parse and validate separate regexps from individual patterns (reporting errors with only the relevant line), then combine them (like in https://twitter.com/thingskatedid/status/1472360823058157569 and the preceding thread). If it’s cheap to combine already-fully-compiled DFAs, maybe the regex crate could have an API that takes multiple Regex values? In the meantime if we accept some duplicated setup-time work we could validate each pattern with Regex::new, report errors individually, throw away successful results and then at the end build the mega-regex from concatenated strings like now.