Page MenuHomePhabricator

SimonSapin
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2020, 12:09 PM (20 w, 20 h)

Recent Activity

Yesterday

SimonSapin created D10369: dirstate-tree: Add map `get` and `contains_key` methods.
Mon, Apr 12, 8:24 AM
SimonSapin created D10362: dirstate-tree: Make Rust DirstateMap bindings go through a trait object.
Mon, Apr 12, 8:24 AM
SimonSapin created D10370: dirstate-tree: Add tree traversal/iteration.
Mon, Apr 12, 8:24 AM
SimonSapin created D10366: rust: Refactor parse_dirstate() to take a callback.
Mon, Apr 12, 8:24 AM
SimonSapin created D10368: dirstate-tree: Add parsing only dirstate parents from disk.
Mon, Apr 12, 8:24 AM
SimonSapin created D10364: dirstate-tree: Empty shell for a second Rust DirstateMap implementation.
Mon, Apr 12, 8:24 AM
SimonSapin created D10367: dirstate-tree: Implement DirstateMap::read.
Mon, Apr 12, 8:23 AM
SimonSapin created D10363: dirstate-tree: Abstract "non-normal" and "other parent" sets.
Mon, Apr 12, 8:23 AM
SimonSapin created D10365: dirstate-tree: Add `WithBasename` wrapper for `HgPath`.
Mon, Apr 12, 8:23 AM

Sun, Apr 11

SimonSapin closed D10329: rust: Remove the compile-time 'dirstate-tree' feature flag.
Sun, Apr 11, 7:24 PM
SimonSapin closed D10328: rust: Remove use of `py.eval()`.
Sun, Apr 11, 7:23 PM
SimonSapin committed rHGc6ceb5f27f97: rust: Remove use of `py.eval()`.
rust: Remove use of `py.eval()`
Sun, Apr 11, 7:23 PM
SimonSapin committed rHG441024b279a6: rust: Remove the compile-time 'dirstate-tree' feature flag.
rust: Remove the compile-time 'dirstate-tree' feature flag
Sun, Apr 11, 7:23 PM
SimonSapin closed D10351: unit-tests: Fix `cargo test` on 32-bit platforms.
Sun, Apr 11, 7:22 PM
SimonSapin committed rHG6d5a26e94d9e: unit-tests: Fix `cargo test` on 32-bit platforms.
unit-tests: Fix `cargo test` on 32-bit platforms
Sun, Apr 11, 7:22 PM

Fri, Apr 9

SimonSapin created D10351: unit-tests: Fix `cargo test` on 32-bit platforms.
Fri, Apr 9, 6:08 AM
SimonSapin added a comment to D10330: share: store relative share paths with '/' separators.

This patch affects creation of new shared repositories, right? At the moment we don’t have any Rust code doing that.

Fri, Apr 9, 5:33 AM

Thu, Apr 8

SimonSapin added a comment to D10296: rhg: read [paths] for `--repository` value.

This version of the patch looks good, thanks!

Thu, Apr 8, 4:06 PM
SimonSapin created D10329: rust: Remove the compile-time 'dirstate-tree' feature flag.
Thu, Apr 8, 3:52 PM
SimonSapin created D10328: rust: Remove use of `py.eval()`.
Thu, Apr 8, 3:39 PM

Tue, Apr 6

SimonSapin added a comment to D10296: rhg: read [paths] for `--repository` value.

Looks good, but there seems to be yet another edge case within the edge case… *sigh*. See inline comment.

Tue, Apr 6, 5:23 AM

Thu, Mar 25

SimonSapin added inline comments to D10254: rhg: raise wdir specific error for `hg debugdata`.
Thu, Mar 25, 11:48 AM
SimonSapin added a comment to D10253: rhg: add support for detailed exit code for ConfigParseError.

Looks good, thanks!

Thu, Mar 25, 7:23 AM

Wed, Mar 24

SimonSapin added a comment to D10239: rhg: Initial support for the 'status' command.

Apparently Phabricator doesn’t show commit author separately from submitter, but this was written a few months ago by Georges Racinet. I’ve reviewed it, rebased it, adapted it to compile again, and added the config to disable it by default. Some tests are failing when running this for hg status (hence disabling) but this is still a good start.

Wed, Mar 24, 11:21 AM

Mon, Mar 22

SimonSapin closed D10238: rhg: Add more conversions between error types.
Mon, Mar 22, 5:51 AM
SimonSapin committed rHGbcdcb4423ae3: rhg: Add more conversions between error types.
rhg: Add more conversions between error types
Mon, Mar 22, 5:51 AM

Fri, Mar 19

SimonSapin created D10239: rhg: Initial support for the 'status' command.
Fri, Mar 19, 8:28 AM
SimonSapin created D10238: rhg: Add more conversions between error types.
Fri, Mar 19, 8:28 AM

Wed, Mar 17

SimonSapin closed D10199: rust: Preallocate the returned `Vec` in `utils::files::relativize_path`.
Wed, Mar 17, 10:42 AM
SimonSapin committed rHGc94fa884240b: rust: Preallocate the returned `Vec` in `utils::files::relativize_path`.
rust: Preallocate the returned `Vec` in `utils::files::relativize_path`
Wed, Mar 17, 10:42 AM

Tue, Mar 16

SimonSapin closed D10142: rhg: `cat` command: print error messages for missing files.
Tue, Mar 16, 5:50 PM
SimonSapin committed rHG6b5714479288: ci: Add a job testing with rhg installed as `hg`.
ci: Add a job testing with rhg installed as `hg`
Tue, Mar 16, 5:49 PM
SimonSapin closed D10190: tests: Disable for rhg remaining tests that fail in that mode.
Tue, Mar 16, 5:49 PM
SimonSapin closed D10196: ci: Add a job testing with rhg installed as `hg`.
Tue, Mar 16, 5:49 PM
SimonSapin closed D10189: rhg: Remove `rhg.fallback-executable=hg` default configuration.
Tue, Mar 16, 5:49 PM
SimonSapin committed rHG5a2212d40398: tests: Disable for rhg remaining tests that fail in that mode.
tests: Disable for rhg remaining tests that fail in that mode
Tue, Mar 16, 5:49 PM
SimonSapin committed rHGbde90e9b4507: rhg: Remove `rhg.fallback-executable=hg` default configuration.
rhg: Remove `rhg.fallback-executable=hg` default configuration
Tue, Mar 16, 5:48 PM
SimonSapin closed D10145: rhg: Return an error code for `rhg config Section.idontexist`.
Tue, Mar 16, 5:48 PM
SimonSapin closed D10144: rhg: Fall back to Python for --version.
Tue, Mar 16, 5:48 PM
SimonSapin committed rHGb1e6265e8336: rhg: Return an error code for `rhg config Section.idontexist`.
rhg: Return an error code for `rhg config Section.idontexist`
Tue, Mar 16, 5:48 PM
SimonSapin committed rHGeb14264b98e8: rhg: Fall back to Python for --version.
rhg: Fall back to Python for --version
Tue, Mar 16, 5:48 PM
SimonSapin closed D10138: rhg: Don’t make repository path absolute too early.
Tue, Mar 16, 5:48 PM
SimonSapin closed D10143: rhg: Exit with an error code if `files` finds nothing.
Tue, Mar 16, 5:48 PM
SimonSapin committed rHG63bfcddddac1: rhg: Exit with an error code if `files` finds nothing.
rhg: Exit with an error code if `files` finds nothing
Tue, Mar 16, 5:48 PM
SimonSapin closed D10140: rhg: Add support for environment variables in config include paths.
Tue, Mar 16, 5:48 PM
SimonSapin committed rHGb1f2c2b336ec: rhg: `cat` command: print error messages for missing files.
rhg: `cat` command: print error messages for missing files
Tue, Mar 16, 5:48 PM
SimonSapin closed D10141: rhg: Silently ignore missing files in config %include.
Tue, Mar 16, 5:48 PM
SimonSapin committed rHG84a3deca963a: rhg: Silently ignore missing files in config %include.
rhg: Silently ignore missing files in config %include
Tue, Mar 16, 5:48 PM
SimonSapin closed D10139: rhg: Add support for the HGRCSKIPREPO environment variable.
Tue, Mar 16, 5:48 PM
SimonSapin committed rHG91ab5190a3de: rhg: Add support for environment variables in config include paths.
rhg: Add support for environment variables in config include paths
Tue, Mar 16, 5:47 PM
SimonSapin closed D10133: rhg: Align with Python on some more error messages.
Tue, Mar 16, 5:47 PM
SimonSapin committed rHG25e3dac511f0: rhg: Add support for the HGRCSKIPREPO environment variable.
rhg: Add support for the HGRCSKIPREPO environment variable
Tue, Mar 16, 5:47 PM
SimonSapin committed rHG97ac588b6d9e: rhg: Don’t make repository path absolute too early.
rhg: Don’t make repository path absolute too early
Tue, Mar 16, 5:47 PM
SimonSapin closed D10137: rhg: Fall back to Python if ui.relative-paths is configured.
Tue, Mar 16, 5:47 PM
SimonSapin committed rHGc184b490da37: rhg: Fall back to Python if ui.relative-paths is configured.
rhg: Fall back to Python if ui.relative-paths is configured
Tue, Mar 16, 5:47 PM
SimonSapin closed D10135: tests: Adapt expected output for minor differences with rhg.
Tue, Mar 16, 5:47 PM
SimonSapin committed rHGe96a0a53de20: tests: Adapt expected output for minor differences with rhg.
tests: Adapt expected output for minor differences with rhg
Tue, Mar 16, 5:46 PM
SimonSapin closed D10134: rhg: Add support for --cwd.
Tue, Mar 16, 5:46 PM
SimonSapin committed rHG2255e7eb39e5: rhg: Add support for --cwd.
rhg: Add support for --cwd
Tue, Mar 16, 5:46 PM
SimonSapin committed rHG12d59eec7f1d: rhg: Align with Python on some more error messages.
rhg: Align with Python on some more error messages
Tue, Mar 16, 5:46 PM
SimonSapin closed D10112: rhg: Fall back to Python if unsupported extensions are enabled.
Tue, Mar 16, 5:46 PM
SimonSapin closed D10110: rhg: Align config file parse error formatting with Python.
Tue, Mar 16, 5:46 PM
SimonSapin committed rHG1a036d33bc18: rhg: Add an allow-list of ignored extensions.
rhg: Add an allow-list of ignored extensions
Tue, Mar 16, 5:46 PM
SimonSapin closed D10188: rhg: Add an allow-list of ignored extensions.
Tue, Mar 16, 5:46 PM
SimonSapin committed rHG1bac7764ceef: rhg: Fall back to Python if unsupported extensions are enabled.
rhg: Fall back to Python if unsupported extensions are enabled
Tue, Mar 16, 5:45 PM
SimonSapin committed rHG60fe9ebae29b: rhg: Sort config files when adding a directory.
rhg: Sort config files when adding a directory
Tue, Mar 16, 5:45 PM
SimonSapin closed D10111: rhg: Sort config files when adding a directory.
Tue, Mar 16, 5:45 PM
SimonSapin committed rHG3d692e724d06: rhg: Align config file parse error formatting with Python.
rhg: Align config file parse error formatting with Python
Tue, Mar 16, 5:45 PM
SimonSapin closed D10101: rhg: Fall back to Python on --repository with an URL.
Tue, Mar 16, 5:45 PM
SimonSapin closed D10102: rhg: Fall back to Python for bundle repositories.
Tue, Mar 16, 5:45 PM
SimonSapin committed rHGdfd35823635b: rhg: Fall back to Python for bundle repositories.
rhg: Fall back to Python for bundle repositories
Tue, Mar 16, 5:45 PM
SimonSapin closed D10096: tests: Add `rhg` and `no-rhg` for #require and #if in .t files.
Tue, Mar 16, 5:45 PM
SimonSapin committed rHG6cd9f53aaed8: rhg: Fall back to Python on --repository with an URL.
rhg: Fall back to Python on --repository with an URL
Tue, Mar 16, 5:45 PM
SimonSapin closed D10100: rhg: Print non-absolutized path in "repository {} not found" errors.
Tue, Mar 16, 5:44 PM
SimonSapin committed rHG562a676e255a: rhg: Print non-absolutized path in "repository {} not found" errors.
rhg: Print non-absolutized path in "repository {} not found" errors
Tue, Mar 16, 5:44 PM
SimonSapin closed D10099: rhg: Align "malformed --config" error message with Python.
Tue, Mar 16, 5:44 PM
SimonSapin committed rHG28a54c128e82: rhg: Align "malformed --config" error message with Python.
rhg: Align "malformed --config" error message with Python
Tue, Mar 16, 5:44 PM
SimonSapin closed D10187: tests: Enable rhg fallback to Python by default in tests.
Tue, Mar 16, 5:44 PM
SimonSapin committed rHG92e3cfd63096: rhg: Fall back to Python on unsupported `rhg config <section>`.
rhg: Fall back to Python on unsupported `rhg config <section>`
Tue, Mar 16, 5:44 PM
SimonSapin closed D10098: rhg: Fall back to Python on unsupported `rhg config <section>`.
Tue, Mar 16, 5:44 PM
SimonSapin committed rHGdf247f58ecee: rhg: Fall back to Python for unsupported revset syntax.
rhg: Fall back to Python for unsupported revset syntax
Tue, Mar 16, 5:44 PM
SimonSapin closed D10097: rhg: Fall back to Python for unsupported revset syntax.
Tue, Mar 16, 5:44 PM
SimonSapin committed rHG78e6700ab009: tests: Add `rhg` and `no-rhg` for #require and #if in .t files.
tests: Add `rhg` and `no-rhg` for #require and #if in .t files
Tue, Mar 16, 5:44 PM
SimonSapin committed rHGa6553ba1c598: tests: Enable rhg fallback to Python by default in tests.
tests: Enable rhg fallback to Python by default in tests
Tue, Mar 16, 5:44 PM
SimonSapin closed D10186: rhg: Add environment variables for fallback configuration.
Tue, Mar 16, 5:43 PM
SimonSapin committed rHG08a35cec14d4: rhg: Add environment variables for fallback configuration.
rhg: Add environment variables for fallback configuration
Tue, Mar 16, 5:43 PM

Mon, Mar 15

SimonSapin added inline comments to D10196: ci: Add a job testing with rhg installed as `hg`.
Mon, Mar 15, 7:49 AM
SimonSapin added a comment to D10199: rust: Preallocate the returned `Vec` in `utils::files::relativize_path`.

I haven’t measured memory at all but I’d expect the effect to be very small or not noticeable since this function is typically called for printing the return value to stdout then deallocating it immediately. We’re not accumulating many "relativized" paths in memory at any given time.

Mon, Mar 15, 7:35 AM
SimonSapin added a comment to D10186: rhg: Add environment variables for fallback configuration.

Yes, absolutely. The new configuration keys and their values too. However this is split between several patches that I feel are not quite settled yet, so it’ll be easier to start writing docs after this patch series has been merged.

Mon, Mar 15, 6:54 AM

Mar 13 2021

SimonSapin created D10200: rhg: Make `files` work on repo-relative paths when possible.
Mar 13 2021, 3:54 AM
SimonSapin updated the summary of D10199: rust: Preallocate the returned `Vec` in `utils::files::relativize_path`.
Mar 13 2021, 3:09 AM
SimonSapin created D10199: rust: Preallocate the returned `Vec` in `utils::files::relativize_path`.
Mar 13 2021, 3:02 AM

Mar 12 2021

SimonSapin added a comment to D10094: rhg: Make fallback to Python the default behavior.

Marmoute makes a good point about the default to looking up hg in $PATH being fragile, making it easy to accidentally use not the expected installation of Mercurial.

Mar 12 2021, 5:15 PM
SimonSapin updated the summary of D10142: rhg: `cat` command: print error messages for missing files.
Mar 12 2021, 5:10 PM
SimonSapin created D10195: run-test: install rhg if --rhg is passed.
Mar 12 2021, 5:10 PM
SimonSapin created D10190: tests: Disable for rhg remaining tests that fail in that mode.
Mar 12 2021, 5:09 PM
SimonSapin created D10196: ci: Add a job testing with rhg installed as `hg`.
Mar 12 2021, 5:09 PM
SimonSapin created D10189: rhg: Remove `rhg.fallback-executable=hg` default configuration.
Mar 12 2021, 5:09 PM
SimonSapin created D10194: makefile: add a install option.
Mar 12 2021, 5:09 PM
SimonSapin created D10193: makefile: add a build-rhg option.
Mar 12 2021, 5:09 PM