Page MenuHomePhabricator

SimonSapin
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2020, 12:09 PM (42 w, 4 d)

Recent Activity

Today

SimonSapin created D11446: rust: Update the memmap2 crate to version 0.4.0.
Fri, Sep 17, 2:58 AM

Yesterday

SimonSapin closed D11416: rust: Rename get_node methods to data_for_node, get_rev to data_for_rev.
Thu, Sep 16, 4:03 AM
SimonSapin closed D11415: rust: Rename the `Revlog::get_node_rev` method to `rev_from_node`.
Thu, Sep 16, 4:03 AM
SimonSapin closed D11414: rust: Make private the `index` field of the `Revlog` struct.
Thu, Sep 16, 4:02 AM
SimonSapin committed rHG87e3f878e65f: rust: Rename get_node methods to data_for_node, get_rev to data_for_rev.
rust: Rename get_node methods to data_for_node, get_rev to data_for_rev
Thu, Sep 16, 4:02 AM
SimonSapin committed rHG6f579618ea7b: rust: Rename the `Revlog::get_node_rev` method to `rev_from_node`.
rust: Rename the `Revlog::get_node_rev` method to `rev_from_node`
Thu, Sep 16, 4:02 AM
SimonSapin committed rHG6c653d9d41b8: rust: Make private the `index` field of the `Revlog` struct.
rust: Make private the `index` field of the `Revlog` struct
Thu, Sep 16, 4:02 AM

Tue, Sep 14

SimonSapin created D11416: rust: Rename get_node methods to data_for_node, get_rev to data_for_rev.
Tue, Sep 14, 12:46 PM
SimonSapin created D11415: rust: Rename the `Revlog::get_node_rev` method to `rev_from_node`.
Tue, Sep 14, 12:46 PM
SimonSapin created D11414: rust: Make private the `index` field of the `Revlog` struct.
Tue, Sep 14, 12:45 PM
SimonSapin accepted D11403: rhg: fall back if subrepos are detected.
Tue, Sep 14, 11:15 AM
SimonSapin accepted D11401: rust-revset: add separate match logic for shortcuts.
Tue, Sep 14, 11:14 AM
SimonSapin accepted D11402: rust-revset: support explicit `.` revision.
Tue, Sep 14, 11:13 AM
SimonSapin closed D11413: dirstate-v2: Remove the `.d` suffix in data file names.
Tue, Sep 14, 10:29 AM
SimonSapin committed rHG681851d6409b: dirstate-v2: Remove the `.d` suffix in data file names.
dirstate-v2: Remove the `.d` suffix in data file names
Tue, Sep 14, 10:29 AM
SimonSapin created D11413: dirstate-v2: Remove the `.d` suffix in data file names.
Tue, Sep 14, 9:42 AM
SimonSapin closed D11410: rust: Return HgError instead of RevlogError in revlog constructors.
Tue, Sep 14, 4:21 AM
SimonSapin closed D11411: rhg: Reuse manifest when checking status of multiple ambiguous files.
Tue, Sep 14, 4:21 AM
SimonSapin closed D11412: rhg: Don’t compare ambiguous files one byte at a time.
Tue, Sep 14, 4:21 AM
SimonSapin committed rHGf9e6f2bb721d: rhg: Don’t compare ambiguous files one byte at a time.
rhg: Don’t compare ambiguous files one byte at a time
Tue, Sep 14, 4:21 AM
SimonSapin closed D11408: rust: Add a Filelog struct that wraps Revlog.
Tue, Sep 14, 4:21 AM
SimonSapin committed rHG796206e74b10: rhg: Reuse manifest when checking status of multiple ambiguous files.
rhg: Reuse manifest when checking status of multiple ambiguous files
Tue, Sep 14, 4:20 AM
SimonSapin committed rHG001d747c2baf: rust: Return HgError instead of RevlogError in revlog constructors.
rust: Return HgError instead of RevlogError in revlog constructors
Tue, Sep 14, 4:20 AM
SimonSapin closed D11409: rhg: Align with Python on some revset parsing corner cases.
Tue, Sep 14, 4:20 AM
SimonSapin committed rHG8c29af0f6d6e: rhg: Align with Python on some revset parsing corner cases.
rhg: Align with Python on some revset parsing corner cases
Tue, Sep 14, 4:20 AM
SimonSapin closed D11406: rust: Keep lazily-initialized Changelog and Manifest log on the Repo object.
Tue, Sep 14, 4:20 AM
SimonSapin closed D11407: rust: Add Repo::manifest(revision).
Tue, Sep 14, 4:20 AM
SimonSapin committed rHG4d2a5ca060e3: rust: Add a Filelog struct that wraps Revlog.
rust: Add a Filelog struct that wraps Revlog
Tue, Sep 14, 4:19 AM
SimonSapin closed D11404: rust: Rename Manifest to Manifestlog, ManifestEntry to Manifest.
Tue, Sep 14, 4:19 AM
SimonSapin committed rHGcfb6e6699b25: rust: Add Repo::manifest(revision).
rust: Add Repo::manifest(revision)
Tue, Sep 14, 4:19 AM
SimonSapin closed D11405: rust: Move lazy initialization of `Repo::dirstate_map` into a generic struct.
Tue, Sep 14, 4:19 AM
SimonSapin committed rHG21d25e9ee58e: rust: Keep lazily-initialized Changelog and Manifest log on the Repo object.
rust: Keep lazily-initialized Changelog and Manifest log on the Repo object
Tue, Sep 14, 4:19 AM
SimonSapin committed rHGfc208d6faed3: rust: Move lazy initialization of `Repo::dirstate_map` into a generic struct.
rust: Move lazy initialization of `Repo::dirstate_map` into a generic struct
Tue, Sep 14, 4:19 AM
SimonSapin committed rHGd44740725b95: rust: Rename Manifest to Manifestlog, ManifestEntry to Manifest.
rust: Rename Manifest to Manifestlog, ManifestEntry to Manifest
Tue, Sep 14, 4:19 AM
SimonSapin accepted D11380: rhg: fallback if the current command has any generic hook defined.
Tue, Sep 14, 3:55 AM
SimonSapin accepted D11381: rhg: fallback if `defaults` config is set for the current command.
Tue, Sep 14, 3:54 AM
SimonSapin added inline comments to D11412: rhg: Don’t compare ambiguous files one byte at a time.
Tue, Sep 14, 12:12 AM
SimonSapin updated the diff for D11412: rhg: Don’t compare ambiguous files one byte at a time.
Tue, Sep 14, 12:07 AM

Mon, Sep 13

SimonSapin added a comment to D11410: rust: Return HgError instead of RevlogError in revlog constructors.

There are strictly more error cases that can be represented by RevlogError so it is more general. (Since it has an Other variant that contains an HgError, plus some other variants.)

Mon, Sep 13, 4:38 PM
SimonSapin added inline comments to D11408: rust: Add a Filelog struct that wraps Revlog.
Mon, Sep 13, 4:36 PM
SimonSapin created D11410: rust: Return HgError instead of RevlogError in revlog constructors.
Mon, Sep 13, 2:15 PM
SimonSapin created D11411: rhg: Reuse manifest when checking status of multiple ambiguous files.
Mon, Sep 13, 2:15 PM
SimonSapin created D11408: rust: Add a Filelog struct that wraps Revlog.
Mon, Sep 13, 2:14 PM
SimonSapin created D11412: rhg: Don’t compare ambiguous files one byte at a time.
Mon, Sep 13, 2:14 PM
SimonSapin created D11409: rhg: Align with Python on some revset parsing corner cases.
Mon, Sep 13, 2:14 PM
SimonSapin created D11406: rust: Keep lazily-initialized Changelog and Manifest log on the Repo object.
Mon, Sep 13, 2:14 PM
SimonSapin created D11407: rust: Add Repo::manifest(revision).
Mon, Sep 13, 2:14 PM
SimonSapin created D11404: rust: Rename Manifest to Manifestlog, ManifestEntry to Manifest.
Mon, Sep 13, 2:14 PM
SimonSapin created D11405: rust: Move lazy initialization of `Repo::dirstate_map` into a generic struct.
Mon, Sep 13, 2:13 PM
SimonSapin closed D11396: rust: Make OwningDirstateMap generic and move it into hg-core.
Mon, Sep 13, 10:06 AM
SimonSapin closed D11398: rust: Add Repo::dirstate_map and use it in `rhg status`.
Mon, Sep 13, 10:06 AM
SimonSapin closed D11397: rust: Switch to the memmap2-rs crate.
Mon, Sep 13, 10:06 AM
SimonSapin committed rHG81aedf1fc897: rust: Add Repo::dirstate_map and use it in `rhg status`.
rust: Add Repo::dirstate_map and use it in `rhg status`
Mon, Sep 13, 10:06 AM
SimonSapin closed D11394: rust: Move VFS code to its own module.
Mon, Sep 13, 10:06 AM
SimonSapin committed rHGe834b79def74: rust: Switch to the memmap2-rs crate.
rust: Switch to the memmap2-rs crate
Mon, Sep 13, 10:05 AM
SimonSapin closed D11395: rust: Move PyBytesWithData out of copy-tracing code.
Mon, Sep 13, 10:05 AM
SimonSapin committed rHG4afd6cc447b9: rust: Make OwningDirstateMap generic and move it into hg-core.
rust: Make OwningDirstateMap generic and move it into hg-core
Mon, Sep 13, 10:05 AM
SimonSapin committed rHG8f031a274cd6: rust: Move PyBytesWithData out of copy-tracing code.
rust: Move PyBytesWithData out of copy-tracing code
Mon, Sep 13, 10:05 AM
SimonSapin committed rHG9cd35c8c6044: rust: Move VFS code to its own module.
rust: Move VFS code to its own module
Mon, Sep 13, 10:05 AM
SimonSapin added inline comments to D11398: rust: Add Repo::dirstate_map and use it in `rhg status`.
Mon, Sep 13, 6:44 AM
SimonSapin added a comment to D11396: rust: Make OwningDirstateMap generic and move it into hg-core.

I’ve edited the commit message to discuss genericity and StableDeref

Mon, Sep 13, 6:41 AM
SimonSapin updated the diff for D11398: rust: Add Repo::dirstate_map and use it in `rhg status`.
Mon, Sep 13, 6:41 AM
SimonSapin updated the summary of D11396: rust: Make OwningDirstateMap generic and move it into hg-core.
Mon, Sep 13, 6:38 AM

Fri, Sep 10

SimonSapin created D11396: rust: Make OwningDirstateMap generic and move it into hg-core.
Fri, Sep 10, 11:12 AM
SimonSapin created D11397: rust: Switch to the memmap2-rs crate.
Fri, Sep 10, 11:12 AM
SimonSapin created D11398: rust: Add Repo::dirstate_map and use it in `rhg status`.
Fri, Sep 10, 11:12 AM
SimonSapin created D11394: rust: Move VFS code to its own module.
Fri, Sep 10, 11:11 AM
SimonSapin created D11395: rust: Move PyBytesWithData out of copy-tracing code.
Fri, Sep 10, 11:11 AM

Thu, Sep 9

SimonSapin closed D11390: rhg: Switch rhg.ignored-extensions config to Python-compatible list syntax.
Thu, Sep 9, 10:07 AM
SimonSapin closed D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.
Thu, Sep 9, 10:07 AM
SimonSapin closed D11388: rust: Generalize the `trim_end_newlines` utility of byte strings.
Thu, Sep 9, 10:07 AM
SimonSapin committed rHGcff41e168c25: rhg: Switch rhg.ignored-extensions config to Python-compatible list syntax.
rhg: Switch rhg.ignored-extensions config to Python-compatible list syntax
Thu, Sep 9, 10:06 AM
SimonSapin committed rHG6961eca0b3ee: rhg: Port Python’s `ui.configlist` as `Config::get_list`.
rhg: Port Python’s `ui.configlist` as `Config::get_list`
Thu, Sep 9, 10:06 AM
SimonSapin committed rHG696abab107b4: rust: Generalize the `trim_end_newlines` utility of byte strings.
rust: Generalize the `trim_end_newlines` utility of byte strings
Thu, Sep 9, 10:06 AM
SimonSapin added inline comments to D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.
Thu, Sep 9, 9:48 AM
SimonSapin accepted D11377: rhg: add support for calling `rhg cat` without a revision.
Thu, Sep 9, 9:42 AM
SimonSapin added inline comments to D11380: rhg: fallback if the current command has any generic hook defined.
Thu, Sep 9, 9:37 AM
SimonSapin added a comment to D11378: rhg-cat: fallback when detecting `.` or `..` path segments.

Ok. The correct normalization can be added later, let’s not block this patch.

Thu, Sep 9, 9:36 AM

Sat, Sep 4

SimonSapin added a comment to D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.

Updated manually rather than trough Baymax since the windows-py3-pyox job in https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/26551 failed 4 times in a row with different error messages.

Sat, Sep 4, 3:27 AM
SimonSapin updated the diff for D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.
Sat, Sep 4, 3:25 AM

Fri, Sep 3

SimonSapin added a comment to D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.

Inline the whole parser into one function

Fri, Sep 3, 11:07 AM
SimonSapin added a comment to D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.

Dear reviewer, when trying to find cases where this code has different behavior than that of mercurial/utils/stringutil.py (or convince yourself that it’s the same), I advise for your own mental well-being not to question too much what that behavior is.

Fri, Sep 3, 10:52 AM
SimonSapin created D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`.
Fri, Sep 3, 10:38 AM
SimonSapin created D11390: rhg: Switch rhg.ignored-extensions config to Python-compatible list syntax.
Fri, Sep 3, 10:38 AM
SimonSapin created D11388: rust: Generalize the `trim_end_newlines` utility of byte strings.
Fri, Sep 3, 10:38 AM

Thu, Sep 2

SimonSapin added a comment to D11378: rhg-cat: fallback when detecting `.` or `..` path segments.

Is https://doc.rust-lang.org/std/fs/fn.canonicalize.html the correct normalization needed here? (Note that it follows symlinks.) If it’s easy enough, it may be worth implementing the correct behavior instead of adding fallback.

Thu, Sep 2, 2:40 PM
SimonSapin accepted D11379: rhg-cat: fallback in presence of a fileset.
Thu, Sep 2, 2:38 PM
SimonSapin accepted D11380: rhg: fallback if the current command has any generic hook defined.
Thu, Sep 2, 2:36 PM
SimonSapin accepted D11381: rhg: fallback if `defaults` config is set for the current command.
Thu, Sep 2, 2:32 PM
SimonSapin added a comment to D11341: rust: update the minimum version of Rust.

Looks good. This should be merged around the same time as CI is changed to use 1.48.0

Thu, Sep 2, 2:31 PM
SimonSapin added inline comments to D11377: rhg: add support for calling `rhg cat` without a revision.
Thu, Sep 2, 2:29 PM

Jul 30 2021

SimonSapin closed D11230: rhg: Propagate permission errors when finding a repository.
Jul 30 2021, 11:13 AM
SimonSapin committed rHGcf5f8da2244c: rhg: Propagate permission errors when finding a repository.
rhg: Propagate permission errors when finding a repository
Jul 30 2021, 11:12 AM
SimonSapin committed rHG6df528ed47a9: rhg: Add build and config instructions to the README file.
rhg: Add build and config instructions to the README file
Jul 30 2021, 11:12 AM
SimonSapin closed D11229: rhg: Add build and config instructions to the README file.
Jul 30 2021, 11:12 AM

Jul 29 2021

SimonSapin added a comment to D11230: rhg: Propagate permission errors when finding a repository.

I’ve changed this to only propagate permission errors specifically, for now. This seems to be the one that’s somewhat likely to happen, from possible errors listed in man 2 stat.

Jul 29 2021, 2:36 PM
SimonSapin added a comment to D11230: rhg: Propagate permission errors when finding a repository.

This should not be merged as-is: some tests fail because this function returns an error if an ancestor of the given path is not a directory. We’d want to handle that case like "not found" errors instead, but https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html#variant.NotADirectory is not stable yet (and does not exist at all in 1.41)

Jul 29 2021, 10:57 AM
SimonSapin added a comment to D11052: tests: blacklist a handful of test with `rhg` or `chg`.

I’ve reproduced the same as Alphare.

Jul 29 2021, 6:57 AM
SimonSapin created D11230: rhg: Propagate permission errors when finding a repository.
Jul 29 2021, 6:22 AM
SimonSapin created D11229: rhg: Add build and config instructions to the README file.
Jul 29 2021, 5:53 AM