Page MenuHomePhabricator

av6 (Anton Shestakov)
User

Projects

User Details

User Since
Oct 6 2017, 1:37 AM (206 w, 10 h)

Recent Activity

Aug 4 2021

av6 committed rHG2cd00052ae4d: obsolete: disable other evolution config options if createmarkers is off.
obsolete: disable other evolution config options if createmarkers is off
Aug 4 2021, 4:43 PM
av6 committed rHG16c60e90a496: rebase: use obsolete.isenabled() to check for experimental.allowdivergence.
rebase: use obsolete.isenabled() to check for experimental.allowdivergence
Aug 4 2021, 4:43 PM
av6 committed rHGe69c82bf3a01: fix: use obsolete.isenabled() to check for experimental.allowdivergence.
fix: use obsolete.isenabled() to check for experimental.allowdivergence
Aug 4 2021, 4:43 PM

Jul 30 2021

av6 closed D11221: rebase: use obsolete.isenabled() to check for experimental.allowdivergence.
Jul 30 2021, 11:11 AM
av6 closed D11223: obsolete: disable other evolution config options if createmarkers is off.
Jul 30 2021, 11:11 AM
av6 committed rHGb1e1559f5a45: obsolete: disable other evolution config options if createmarkers is off.
obsolete: disable other evolution config options if createmarkers is off
Jul 30 2021, 11:11 AM
av6 closed D11222: fix: use obsolete.isenabled() to check for experimental.allowdivergence.
Jul 30 2021, 11:11 AM
av6 committed rHG82c87566bfc0: fix: use obsolete.isenabled() to check for experimental.allowdivergence.
fix: use obsolete.isenabled() to check for experimental.allowdivergence
Jul 30 2021, 11:11 AM
av6 committed rHG0044a7ad9f2f: rebase: use obsolete.isenabled() to check for experimental.allowdivergence.
rebase: use obsolete.isenabled() to check for experimental.allowdivergence
Jul 30 2021, 11:11 AM

Jul 28 2021

av6 created D11223: obsolete: disable other evolution config options if createmarkers is off.
Jul 28 2021, 8:32 AM
av6 created D11221: rebase: use obsolete.isenabled() to check for experimental.allowdivergence.
Jul 28 2021, 8:32 AM
av6 created D11222: fix: use obsolete.isenabled() to check for experimental.allowdivergence.
Jul 28 2021, 8:32 AM

Jul 21 2021

av6 added a comment to D11204: hgwebdir: avoid systematic full garbage collection.

Okay, let's compromise.

Jul 21 2021, 9:15 AM
av6 added a comment to D11204: hgwebdir: avoid systematic full garbage collection.

So, was it with or without the patch applied?

These were the figures to show what happens without ff2370a70fe8. More specifically, it's current hg built from public default of hg-committed, but with the gc.collect() line commented out. The leak is indeed very worrying, and currently this gc.collect() on every request is the only solution that we have.

Jul 21 2021, 8:26 AM

Jul 20 2021

av6 added a comment to D11204: hgwebdir: avoid systematic full garbage collection.

Thank you for caring about hgweb, it doesn't get this treatment often.

Jul 20 2021, 3:48 PM

Jul 3 2021

av6 closed D10948: exchange: use "served" repo filter to guess what the server will publish.
Jul 3 2021, 3:29 PM
av6 committed rHGf03e9d30258e: exchange: use "served" repo filter to guess what the server will publish.
exchange: use "served" repo filter to guess what the server will publish
Jul 3 2021, 3:28 PM
av6 created D10948: exchange: use "served" repo filter to guess what the server will publish.
Jul 3 2021, 4:13 AM

Jun 15 2020

av6 closed D8630: tests: adjust to the new format in pyflakes output.
Jun 15 2020, 5:28 AM
av6 closed D8629: tests: consistently use pyflakes as a Python module.
Jun 15 2020, 5:28 AM
av6 committed rHG170f8a43b5b8: tests: adjust to the new format in pyflakes output.
tests: adjust to the new format in pyflakes output
Jun 15 2020, 5:28 AM
av6 committed rHGf9099e210c57: tests: consistently use pyflakes as a Python module.
tests: consistently use pyflakes as a Python module
Jun 15 2020, 5:27 AM
av6 closed D8628: tests: skip pyflakes for mercurial/thirdparty/.
Jun 15 2020, 5:27 AM
av6 committed rHG1ca0d5cae9bc: tests: skip pyflakes for mercurial/thirdparty/.
tests: skip pyflakes for mercurial/thirdparty/
Jun 15 2020, 5:27 AM

Jun 11 2020

av6 closed D8619: tests: skip pyflakes for mercurial/thirdparty/.
Jun 11 2020, 9:39 AM
av6 committed rHGa4438263b228: tests: skip pyflakes for mercurial/thirdparty/.
tests: skip pyflakes for mercurial/thirdparty/
Jun 11 2020, 9:39 AM

Jun 9 2020

av6 retitled D8619: tests: skip pyflakes for mercurial/thirdparty/ from tests: skip pyflakes for selectors2.py to tests: skip pyflakes for mercurial/thirdparty/.
Jun 9 2020, 8:34 AM
av6 closed D8618: tests: adjust to the new format in pyflakes output.
Jun 9 2020, 6:10 AM
av6 committed rHG3d409f4ff46b: tests: adjust to the new format in pyflakes output.
tests: adjust to the new format in pyflakes output
Jun 9 2020, 6:10 AM
av6 closed D8617: tests: consistently use pyflakes as a Python module.
Jun 9 2020, 6:10 AM
av6 committed rHGf4361aed565d: tests: consistently use pyflakes as a Python module.
tests: consistently use pyflakes as a Python module
Jun 9 2020, 6:10 AM

Jun 6 2020

av6 added inline comments to D8619: tests: skip pyflakes for mercurial/thirdparty/.
Jun 6 2020, 9:09 AM
av6 created D8619: tests: skip pyflakes for mercurial/thirdparty/.
Jun 6 2020, 7:31 AM
av6 created D8618: tests: adjust to the new format in pyflakes output.
Jun 6 2020, 7:31 AM
av6 created D8617: tests: consistently use pyflakes as a Python module.
Jun 6 2020, 7:31 AM

Apr 15 2020

av6 closed D8394: revset: implement a simple 'foo#generations' expression.
Apr 15 2020, 11:18 AM
av6 closed D8393: revset: rename generationsrel() to generationssubrel().
Apr 15 2020, 11:18 AM
av6 committed rHGeca82eb9d777: revset: implement a simple 'foo#generations' expression.
revset: implement a simple 'foo#generations' expression
Apr 15 2020, 11:18 AM
av6 committed rHG8859de3e83dc: revset: rename generationsrel() to generationssubrel().
revset: rename generationsrel() to generationssubrel()
Apr 15 2020, 11:18 AM

Apr 10 2020

av6 created D8394: revset: implement a simple 'foo#generations' expression.
Apr 10 2020, 1:02 PM
av6 created D8393: revset: rename generationsrel() to generationssubrel().
Apr 10 2020, 1:02 PM

Sep 23 2019

av6 committed rHG763028fc6a69: stack: use repo.revs() instead of revsetlang.formatspec() + scmutil.revrange().
stack: use repo.revs() instead of revsetlang.formatspec() + scmutil.revrange()
Sep 23 2019, 9:05 AM
av6 added a reverting change for rHGa4ca0610c754: merge: respect parents order when using `graft` on a merge: rHG181e52f2b62f: merge: back out changeset a4ca0610c754 (parents order when grafting a merge).
Sep 23 2019, 9:05 AM
av6 added a reverted change for rHG181e52f2b62f: merge: back out changeset a4ca0610c754 (parents order when grafting a merge): rHGa4ca0610c754: merge: respect parents order when using `graft` on a merge.
merge: back out changeset a4ca0610c754 (parents order when grafting a merge)
Sep 23 2019, 9:04 AM

Sep 18 2019

av6 committed rHG085295f82845: merge: respect parents order when using `graft` on a merge, this time for real.
merge: respect parents order when using `graft` on a merge, this time for real
Sep 18 2019, 6:52 PM

Sep 17 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#99199, @av6 wrote:

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

I disagree that the primary use is script only. As a suer I have wanted this for a long time and I am happy to finally have a way to get this data without grepping the source.

Sep 17 2019, 4:58 AM

Sep 13 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

I'll be okay with this too, once we get rid of (EXPERIMENTAL) everywhere.

Sep 13 2019, 12:12 AM

Aug 25 2019

av6 closed D6762: packaging: add Bullseye, remove Jessie.
Aug 25 2019, 12:09 PM
av6 committed rHG0a50a4232db7: packaging: add Bullseye, remove Jessie.
packaging: add Bullseye, remove Jessie
Aug 25 2019, 12:09 PM
av6 committed rHG0363bb086c57: packaging: add Cosmic and Disco, remove Trusty and Artful.
packaging: add Cosmic and Disco, remove Trusty and Artful
Aug 25 2019, 12:09 PM
av6 closed D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.
Aug 25 2019, 12:09 PM
D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst' is now accepted and ready to land.
Aug 25 2019, 8:59 AM
av6 abandoned D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".
Aug 25 2019, 8:54 AM
av6 added a comment to D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.

Intended for stable.

Aug 25 2019, 8:53 AM
av6 added a comment to D6762: packaging: add Bullseye, remove Jessie.

Intended for stable.

Aug 25 2019, 8:53 AM
av6 created D6762: packaging: add Bullseye, remove Jessie.
Aug 25 2019, 8:50 AM
av6 created D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.
Aug 25 2019, 8:50 AM

Aug 24 2019

D6709: config: add --registered flag to show all known configs now requires changes to proceed.

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

Aug 24 2019, 1:24 AM

Aug 22 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

@marmoute did you want this flag marked as experimental or am I misremembering?

Aug 22 2019, 11:27 PM

Aug 21 2019

av6 added inline comments to D6709: config: add --registered flag to show all known configs.
Aug 21 2019, 12:48 AM

Aug 17 2019

D6730: config: handle default values of type list now requires changes to proceed.

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Aug 17 2019, 9:00 AM
av6 added inline comments to D6709: config: add --registered flag to show all known configs.
Aug 17 2019, 8:59 AM
D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Aug 17 2019, 8:55 AM

Aug 16 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

It looks fine to me, one thing that could be improved is the output format of list values. For example, progress.format: its default value is shown to be ['topic', 'bar', 'number', 'estimate'], but it doesn't match hg help config.progress.format (it says default: topic bar number estimate), and that is also not the format that users would need to use for the actual value in hgrc or using --config flag.

Aug 16 2019, 3:51 AM
D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1) is now accepted and ready to land.
Aug 16 2019, 12:52 AM

Aug 6 2019

av6 closed D6707: revset: drop argument when it's None.
Aug 6 2019, 9:02 AM
av6 committed rHG911e25dc9d8c: revset: drop argument when it's None.
revset: drop argument when it's None
Aug 6 2019, 9:02 AM
av6 committed rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate.
stack: remove unnecessary reverse() predicate
Aug 6 2019, 9:02 AM
av6 closed D6706: stack: remove unnecessary reverse() predicate.
Aug 6 2019, 9:02 AM

Aug 2 2019

D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Aug 2 2019, 8:45 AM
av6 created D6707: revset: drop argument when it's None.
Aug 2 2019, 4:12 AM
av6 created D6706: stack: remove unnecessary reverse() predicate.
Aug 2 2019, 4:11 AM

Jul 4 2019

av6 committed rHG93fed084ce36: move: --force flag forcibly moves, not copies.
move: --force flag forcibly moves, not copies
Jul 4 2019, 11:01 AM
av6 committed rHG50eacdeea88c: copy: correct synopsis by making SOURCE a required argument.
copy: correct synopsis by making SOURCE a required argument
Jul 4 2019, 11:01 AM
av6 added inline comments to D6551: statecheck: added support for cmdutil.afterresolvedstates.
Jul 4 2019, 10:55 AM

Jun 18 2019

av6 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Jun 18 2019, 2:38 AM

Jun 4 2019

av6 closed D6476: merge: correct argument name in docstring.
Jun 4 2019, 10:09 AM
av6 committed rHG127937874395: merge: correct argument name in docstring.
merge: correct argument name in docstring
Jun 4 2019, 10:09 AM
av6 created D6476: merge: correct argument name in docstring.
Jun 4 2019, 5:29 AM

Jun 3 2019

av6 accepted D6467: doc: fix description of "predecessors" to match reality.
Jun 3 2019, 9:58 AM

Jun 1 2019

av6 added a comment to D6467: doc: fix description of "predecessors" to match reality.

This change looks good, but I have doubts about "visible" in the docstring. 1858fc2327ef does say that this template keyword respects repo filtering, but I've encountered instances where it shows hidden predecessors (that need --hidden to be seen).

Jun 1 2019, 3:55 AM

May 30 2019

av6 closed D6461: githelp: translate git stash show and clear actions and --patch flag.
May 30 2019, 2:02 PM
av6 closed D6459: githelp: translate --directory of git apply to --prefix.
May 30 2019, 2:02 PM
av6 committed rHG7752cd3a2f83: githelp: translate git stash show and clear actions and --patch flag.
githelp: translate git stash show and clear actions and --patch flag
May 30 2019, 2:02 PM
av6 closed D6460: githelp: add --dry-run for mv.
May 30 2019, 2:02 PM
av6 committed rHGeddff539f5be: githelp: translate --directory of git apply to --prefix.
githelp: translate --directory of git apply to --prefix
May 30 2019, 2:02 PM
av6 committed rHG37ff80505dfd: githelp: add --dry-run for mv.
githelp: add --dry-run for mv
May 30 2019, 2:02 PM
av6 created D6461: githelp: translate git stash show and clear actions and --patch flag.
May 30 2019, 4:47 AM
av6 created D6460: githelp: add --dry-run for mv.
May 30 2019, 4:47 AM
av6 created D6459: githelp: translate --directory of git apply to --prefix.
May 30 2019, 4:46 AM

May 24 2019

av6 added inline comments to D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145).
May 24 2019, 9:08 AM
av6 added inline comments to D6442: help: include subtopic in error message if passed.
May 24 2019, 9:06 AM

May 4 2019

av6 committed rHG0f01394457a0: commit: add ability to print file status after each successful invocation.
commit: add ability to print file status after each successful invocation
May 4 2019, 10:36 AM
av6 committed rHG165b1aad43da: tests: flatten repo structure in test-commit.t.
tests: flatten repo structure in test-commit.t
May 4 2019, 10:36 AM

Mar 21 2019

av6 added a comment to D6122: tests: add a file listing all the flaky tests.

@av6 is a --no-flaky-tests flag what you had in mind?

Mar 21 2019, 8:31 AM

Mar 13 2019

av6 added a comment to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).

Okay, let's go over #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist once more. If you want to know what a good "topic" is, look at what other people do. How patches that get accepted generally look. How bug-fixing commits are worded.

Mar 13 2019, 2:02 PM
av6 added inline comments to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).
Mar 13 2019, 5:23 AM
av6 added a comment to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).

I find it troubling that we now have contributors that don't follow #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. Potentially #4 too (as Pulkit commented).

Mar 13 2019, 5:20 AM

Mar 12 2019

av6 added a comment to D6122: tests: add a file listing all the flaky tests.

Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can #require flaky or even mark a specific block with #if flaky. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea altogether, but I'm not going to claim that it's easy.

Mar 12 2019, 8:04 AM

Feb 4 2019

av6 committed rHG530d211ae9a8: relnotes: more improvements.
relnotes: more improvements
Feb 4 2019, 4:55 PM