Page MenuHomePhabricator

av6 (Anton Shestakov)
User

Projects

User Details

User Since
Oct 6 2017, 1:37 AM (106 w, 2 d)

Recent Activity

Mon, Sep 23

av6 committed rHG763028fc6a69: stack: use repo.revs() instead of revsetlang.formatspec() + scmutil.revrange().
stack: use repo.revs() instead of revsetlang.formatspec() + scmutil.revrange()
Mon, Sep 23, 9:05 AM
av6 added a reverting change for rHGa4ca0610c754: merge: respect parents order when using `graft` on a merge: rHG181e52f2b62f: merge: back out changeset a4ca0610c754 (parents order when grafting a merge).
Mon, Sep 23, 9:05 AM
av6 added a reverted change for rHG181e52f2b62f: merge: back out changeset a4ca0610c754 (parents order when grafting a merge): rHGa4ca0610c754: merge: respect parents order when using `graft` on a merge.
merge: back out changeset a4ca0610c754 (parents order when grafting a merge)
Mon, Sep 23, 9:04 AM

Sep 18 2019

av6 committed rHG085295f82845: merge: respect parents order when using `graft` on a merge, this time for real.
merge: respect parents order when using `graft` on a merge, this time for real
Sep 18 2019, 6:52 PM

Sep 17 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#99199, @av6 wrote:

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

I disagree that the primary use is script only. As a suer I have wanted this for a long time and I am happy to finally have a way to get this data without grepping the source.

Sep 17 2019, 4:58 AM

Sep 13 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

I'll be okay with this too, once we get rid of (EXPERIMENTAL) everywhere.

Sep 13 2019, 12:12 AM

Aug 25 2019

av6 closed D6762: packaging: add Bullseye, remove Jessie.
Aug 25 2019, 12:09 PM
av6 committed rHG0a50a4232db7: packaging: add Bullseye, remove Jessie.
packaging: add Bullseye, remove Jessie
Aug 25 2019, 12:09 PM
av6 committed rHG0363bb086c57: packaging: add Cosmic and Disco, remove Trusty and Artful.
packaging: add Cosmic and Disco, remove Trusty and Artful
Aug 25 2019, 12:09 PM
av6 closed D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.
Aug 25 2019, 12:09 PM
D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst' is now accepted and ready to land.
Aug 25 2019, 8:59 AM
av6 abandoned D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".
Aug 25 2019, 8:54 AM
av6 added a comment to D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.

Intended for stable.

Aug 25 2019, 8:53 AM
av6 added a comment to D6762: packaging: add Bullseye, remove Jessie.

Intended for stable.

Aug 25 2019, 8:53 AM
av6 created D6762: packaging: add Bullseye, remove Jessie.
Aug 25 2019, 8:50 AM
av6 created D6761: packaging: add Cosmic and Disco, remove Trusty and Artful.
Aug 25 2019, 8:50 AM

Aug 24 2019

D6709: config: add --registered flag to show all known configs now requires changes to proceed.

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

Aug 24 2019, 1:24 AM

Aug 22 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

@marmoute did you want this flag marked as experimental or am I misremembering?

Aug 22 2019, 11:27 PM

Aug 21 2019

av6 added inline comments to D6709: config: add --registered flag to show all known configs.
Aug 21 2019, 12:48 AM

Aug 17 2019

D6730: config: handle default values of type list now requires changes to proceed.

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Aug 17 2019, 9:00 AM
av6 added inline comments to D6709: config: add --registered flag to show all known configs.
Aug 17 2019, 8:59 AM
D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Aug 17 2019, 8:55 AM

Aug 16 2019

av6 added a comment to D6709: config: add --registered flag to show all known configs.

It looks fine to me, one thing that could be improved is the output format of list values. For example, progress.format: its default value is shown to be ['topic', 'bar', 'number', 'estimate'], but it doesn't match hg help config.progress.format (it says default: topic bar number estimate), and that is also not the format that users would need to use for the actual value in hgrc or using --config flag.

Aug 16 2019, 3:51 AM
D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1) is now accepted and ready to land.
Aug 16 2019, 12:52 AM

Aug 6 2019

av6 closed D6707: revset: drop argument when it's None.
Aug 6 2019, 9:02 AM
av6 committed rHG911e25dc9d8c: revset: drop argument when it's None.
revset: drop argument when it's None
Aug 6 2019, 9:02 AM
av6 committed rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate.
stack: remove unnecessary reverse() predicate
Aug 6 2019, 9:02 AM
av6 closed D6706: stack: remove unnecessary reverse() predicate.
Aug 6 2019, 9:02 AM

Aug 2 2019

D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Aug 2 2019, 8:45 AM
av6 created D6707: revset: drop argument when it's None.
Aug 2 2019, 4:12 AM
av6 created D6706: stack: remove unnecessary reverse() predicate.
Aug 2 2019, 4:11 AM

Jul 4 2019

av6 committed rHG93fed084ce36: move: --force flag forcibly moves, not copies.
move: --force flag forcibly moves, not copies
Jul 4 2019, 11:01 AM
av6 committed rHG50eacdeea88c: copy: correct synopsis by making SOURCE a required argument.
copy: correct synopsis by making SOURCE a required argument
Jul 4 2019, 11:01 AM
av6 added inline comments to D6551: statecheck: added support for cmdutil.afterresolvedstates.
Jul 4 2019, 10:55 AM

Jun 18 2019

av6 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Jun 18 2019, 2:38 AM

Jun 4 2019

av6 closed D6476: merge: correct argument name in docstring.
Jun 4 2019, 10:09 AM
av6 committed rHG127937874395: merge: correct argument name in docstring.
merge: correct argument name in docstring
Jun 4 2019, 10:09 AM
av6 created D6476: merge: correct argument name in docstring.
Jun 4 2019, 5:29 AM

Jun 3 2019

av6 accepted D6467: doc: fix description of "predecessors" to match reality.
Jun 3 2019, 9:58 AM

Jun 1 2019

av6 added a comment to D6467: doc: fix description of "predecessors" to match reality.

This change looks good, but I have doubts about "visible" in the docstring. 1858fc2327ef does say that this template keyword respects repo filtering, but I've encountered instances where it shows hidden predecessors (that need --hidden to be seen).

Jun 1 2019, 3:55 AM

May 30 2019

av6 closed D6461: githelp: translate git stash show and clear actions and --patch flag.
May 30 2019, 2:02 PM
av6 closed D6459: githelp: translate --directory of git apply to --prefix.
May 30 2019, 2:02 PM
av6 committed rHG7752cd3a2f83: githelp: translate git stash show and clear actions and --patch flag.
githelp: translate git stash show and clear actions and --patch flag
May 30 2019, 2:02 PM
av6 closed D6460: githelp: add --dry-run for mv.
May 30 2019, 2:02 PM
av6 committed rHGeddff539f5be: githelp: translate --directory of git apply to --prefix.
githelp: translate --directory of git apply to --prefix
May 30 2019, 2:02 PM
av6 committed rHG37ff80505dfd: githelp: add --dry-run for mv.
githelp: add --dry-run for mv
May 30 2019, 2:02 PM
av6 created D6461: githelp: translate git stash show and clear actions and --patch flag.
May 30 2019, 4:47 AM
av6 created D6460: githelp: add --dry-run for mv.
May 30 2019, 4:47 AM
av6 created D6459: githelp: translate --directory of git apply to --prefix.
May 30 2019, 4:46 AM

May 24 2019

av6 added inline comments to D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145).
May 24 2019, 9:08 AM
av6 added inline comments to D6442: help: include subtopic in error message if passed.
May 24 2019, 9:06 AM

May 4 2019

av6 committed rHG0f01394457a0: commit: add ability to print file status after each successful invocation.
commit: add ability to print file status after each successful invocation
May 4 2019, 10:36 AM
av6 committed rHG165b1aad43da: tests: flatten repo structure in test-commit.t.
tests: flatten repo structure in test-commit.t
May 4 2019, 10:36 AM

Mar 21 2019

av6 added a comment to D6122: tests: add a file listing all the flaky tests.

@av6 is a --no-flaky-tests flag what you had in mind?

Mar 21 2019, 8:31 AM

Mar 13 2019

av6 added a comment to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).

Okay, let's go over #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist once more. If you want to know what a good "topic" is, look at what other people do. How patches that get accepted generally look. How bug-fixing commits are worded.

Mar 13 2019, 2:02 PM
av6 added inline comments to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).
Mar 13 2019, 5:23 AM
av6 added a comment to D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099).

I find it troubling that we now have contributors that don't follow #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. Potentially #4 too (as Pulkit commented).

Mar 13 2019, 5:20 AM

Mar 12 2019

av6 added a comment to D6122: tests: add a file listing all the flaky tests.

Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can #require flaky or even mark a specific block with #if flaky. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea altogether, but I'm not going to claim that it's easy.

Mar 12 2019, 8:04 AM

Feb 4 2019

av6 committed rHG530d211ae9a8: relnotes: more improvements.
relnotes: more improvements
Feb 4 2019, 4:55 PM

Feb 3 2019

av6 committed rHG2a42a63241d0: relnotes: more improvements.
relnotes: more improvements
Feb 3 2019, 11:58 PM

Feb 2 2019

av6 committed rHGbb8179171655: relnotes: more improvements.
relnotes: more improvements
Feb 2 2019, 10:45 AM

Jan 31 2019

av6 closed D5779: copyright: update to 2019.
Jan 31 2019, 11:31 AM
av6 committed rHG8427fea04017: copyright: update to 2019.
copyright: update to 2019
Jan 31 2019, 11:30 AM
av6 added a comment to D5779: copyright: update to 2019.

Intended for stable.

Jan 31 2019, 2:46 AM
av6 created D5779: copyright: update to 2019.
Jan 31 2019, 12:34 AM

Jan 30 2019

av6 abandoned D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC).

Okay then, I'll work on a non-PoC version of this.

Jan 30 2019, 8:34 AM
av6 abandoned D5537: obsutil: add a simplified obshistorywalker() (PoC).

Okay then, I'll work on a non-PoC version of this.

Jan 30 2019, 8:33 AM

Jan 26 2019

av6 added a comment to D5710: py3: add 7 new passing tests to whitelist found by buildbot.

Is this patch a result of some flawed automated script? Because wow, unless my eyes fail me, these additions are all duplicates.

Jan 26 2019, 7:32 AM
av6 committed rHG7e55ca658e4b: dagop: check if stopdepth is greater than or equal to maxlogdepth.
dagop: check if stopdepth is greater than or equal to maxlogdepth
Jan 26 2019, 2:10 AM
av6 committed rHGee7791f2515b: revset: move dagop.maxlogdepth usage to generationsrel().
revset: move dagop.maxlogdepth usage to generationsrel()
Jan 26 2019, 2:10 AM
av6 committed rHG947b81560583: test-revset: check that #generations[1:-1] doesn't result in any errors.
test-revset: check that #generations[1:-1] doesn't result in any errors
Jan 26 2019, 2:10 AM
av6 committed rHG7e934f45d257: dagop: check if stopdepth is greater than or equal to maxlogdepth.
dagop: check if stopdepth is greater than or equal to maxlogdepth
Jan 26 2019, 12:40 AM
av6 committed rHG9c133fd9cf74: revset: move dagop.maxlogdepth usage to generationsrel().
revset: move dagop.maxlogdepth usage to generationsrel()
Jan 26 2019, 12:40 AM
av6 committed rHGe124196c75e8: test-revset: check that #generations[1:-1] doesn't result in any errors.
test-revset: check that #generations[1:-1] doesn't result in any errors
Jan 26 2019, 12:40 AM

Jan 25 2019

av6 committed rHG431cf2c8c839: revset: support ranges in #generations relation.
revset: support ranges in #generations relation
Jan 25 2019, 8:20 AM

Jan 9 2019

av6 created D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC).
Jan 9 2019, 6:12 AM
av6 created D5537: obsutil: add a simplified obshistorywalker() (PoC).
Jan 9 2019, 6:11 AM

Dec 23 2018

av6 added inline comments to D5474: obsutil: fix the issue5686.
Dec 23 2018, 1:43 AM

Dec 20 2018

av6 accepted D5455: help: hide default value for default-off flags.

These look good. One more thing I want to mention: hg help evolve looks like this:

   --phase-divergent   solves only phase-divergent changesets
   --content-divergent solves only content-divergent changesets
   --orphan            solves only orphan changesets (default)
-a --all               evolve all troubled changesets related to the current
                       working directory and its descendants
   --[no-]update       update to the head of evolved changesets (default: on)
Dec 20 2018, 6:29 AM
av6 accepted D5454: help: show "[no-]" only for default-on Flags.
Dec 20 2018, 6:21 AM

Dec 15 2018

av6 added a comment to D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".

The point of D5430 was to make hg help output more human friendly by replacing True and False with something less Python-related. In other words, more human-friendly. "Yes" and "no" are way more human-friendly:

Dec 15 2018, 1:03 PM
av6 created D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off".
Dec 15 2018, 6:50 AM

Dec 13 2018

av6 committed rHGe54bfde922f2: revset: move subscript relation functions to its own dict.
revset: move subscript relation functions to its own dict
Dec 13 2018, 3:07 PM
av6 committed rHGf0e8763ed1d4: revset: move subscript relation functions to its own dict.
revset: move subscript relation functions to its own dict
Dec 13 2018, 6:45 AM

Nov 30 2018

av6 committed rHG33d30fb1e4ae: push: config option to control behavior when pushing to a publishing server.
push: config option to control behavior when pushing to a publishing server
Nov 30 2018, 7:55 PM

Nov 22 2018

av6 committed rHG9b8d1ad851f8: push: add --publish flag to change phase of pushed changesets.
push: add --publish flag to change phase of pushed changesets
Nov 22 2018, 8:33 AM

Nov 17 2018

av6 committed rHG69268a13ffa5: branch: allow changing branch of merge commits with --rev.
branch: allow changing branch of merge commits with --rev
Nov 17 2018, 9:32 PM

Nov 15 2018

av6 committed rHG8c6329fa6038: rewriteutil: move publicrevs closer to where it's used.
rewriteutil: move publicrevs closer to where it's used
Nov 15 2018, 6:16 AM

Nov 14 2018

av6 committed rHGe5f54c4ec075: copystore: provide unit to ui.makeprogress().
copystore: provide unit to ui.makeprogress()
Nov 14 2018, 3:29 PM
av6 committed rHGd2ff0af6e959: verify: provide unit to ui.makeprogress().
verify: provide unit to ui.makeprogress()
Nov 14 2018, 3:29 PM
av6 added a comment to D5064: style: run black on a subset of mercurial.

I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable.

Nov 14 2018, 1:41 AM

Nov 2 2018

av6 added projects to D4362: zsh_completion: complete merge tools for -t/--tool: Restricted Project, hg-reviewers.

Changing project tags, please ignore.

Nov 2 2018, 3:12 PM · hg-reviewers, Restricted Project
av6 committed rHG683e99f0b30c: relnotes: various tweaks for release notes.
relnotes: various tweaks for release notes
Nov 2 2018, 1:52 PM

Oct 26 2018

av6 committed rHG7e4ffe2719e4: crecord: make nextsametype() check that parent item exists (issue6009).
crecord: make nextsametype() check that parent item exists (issue6009)
Oct 26 2018, 7:42 AM

Oct 22 2018

av6 committed rHG4ab6e7b4fe8a: streamclone: abort when client needs to handle obsmarkers, but doesn't.
streamclone: abort when client needs to handle obsmarkers, but doesn't
Oct 22 2018, 11:49 AM
av6 committed rHG0ac794e0e285: streamclone: include obsstore file into stream bundle if client can read it.
streamclone: include obsstore file into stream bundle if client can read it
Oct 22 2018, 11:49 AM

Oct 18 2018

av6 committed rHG943248e47864: commands: adjust metavariables as appropriate.
commands: adjust metavariables as appropriate
Oct 18 2018, 9:11 AM

Oct 17 2018

av6 committed rHG01bdf7294274: zsh_completion: fix a couple of flags still not being perfect.
zsh_completion: fix a couple of flags still not being perfect
Oct 17 2018, 6:14 PM
av6 committed rHGd365e2b7aa2a: zsh_completion: add -l/--list flag for hg bookmarks completion.
zsh_completion: add -l/--list flag for hg bookmarks completion
Oct 17 2018, 6:14 PM
av6 closed D5142: zsh_completion: add -l/--list flag for hg bookmarks completion.
Oct 17 2018, 6:14 PM